ABataev added inline comments.
================
Comment at: clang/lib/Basic/OpenMPKinds.cpp:64
+ return OMPC_MAP_MODIFIER_unknown;
+ if (!LangOpts.OpenMPExtensions && Type == OMPC_MAP_MODIFIER_ompx_hold)
return OMPC_MAP_MODIFIER_unknown;
----------------
jdenny wrote:
> ABataev wrote:
> > I would enable this since OpenMP 5.2, since in 5.2 `ompx_` is officially
> > allowed extension format.
> Do you mean both `-fopenmp-version=52` and `-fopenmp-extensions` should be
> required to enable `ompx_hold`?
>
> Or do you mean only `-fopenmp-version=52` should be required to enable
> `ompx_hold`, and we can drop the `-fopenmp-extensions` implementation?
Second option. Actually, we can enable it if either `-fopenmp-version=52` or
`-fopenmp-extensions` is used, depends if we want to add a switch for
non-standard OpenMP extensions. If OpenMP 5.2 is on, we can just ignore
`-f[no]-openmp-extensions`. Thoughts?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D106509/new/
https://reviews.llvm.org/D106509
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
