Author: bader
Date: Wed Oct 11 04:16:31 2017
New Revision: 315453
URL: http://llvm.org/viewvc/llvm-project?rev=315453&view=rev
Log:
[OpenCL] Allow function declaration with empty argument list.
Treat 'f()' as 'f(void)' rather than a function w/o a prototype.
Reviewers: Anastasia, yaxunl
Reviewe
Author: bader
Date: Fri Jun 2 13:08:58 2017
New Revision: 304575
URL: http://llvm.org/viewvc/llvm-project?rev=304575&view=rev
Log:
[OpenCL] Harden function pointer diagnostics.
Summary: Improve OpenCL type checking by rejecting function pointer types.
Reviewers: Anastasia, yaxunl
Reviewed By:
Author: bader
Date: Tue Jun 20 09:30:18 2017
New Revision: 305796
URL: http://llvm.org/viewvc/llvm-project?rev=305796&view=rev
Log:
[OpenCL] Fix OpenCL and SPIR version metadata generation.
Summary: OpenCL and SPIR version metadata must be generated once per module
instead of once per mangled gl
Author: bader
Date: Wed Jun 20 01:31:24 2018
New Revision: 335103
URL: http://llvm.org/viewvc/llvm-project?rev=335103&view=rev
Log:
[Sema] Allow creating types with multiple of the same addrspace.
Summary:
The comment with the OpenCL clause about this clearly
says: "No type shall be qualified by
Author: bader
Date: Tue Feb 19 07:19:06 2019
New Revision: 354337
URL: http://llvm.org/viewvc/llvm-project?rev=354337&view=rev
Log:
[OpenCL] Change type of block pointer for OpenCL
Summary:
For some reason OpenCL blocks in LLVM IR are represented as function pointers.
These pointers do not point
Author: bader
Date: Mon Feb 25 03:48:48 2019
New Revision: 354773
URL: http://llvm.org/viewvc/llvm-project?rev=354773&view=rev
Log:
[SYCL] Add clang front-end option to enable SYCL device compilation flow.
Patch by Mariya Podchishchaeva
Added:
cfe/trunk/test/Preprocessor/sycl-macro.cpp (w
Author: Alexey Bader
Date: 2020-05-22T13:43:24+03:00
New Revision: e95ee300c0530158d86430fd82ffabd36262e862
URL:
https://github.com/llvm/llvm-project/commit/e95ee300c0530158d86430fd82ffabd36262e862
DIFF:
https://github.com/llvm/llvm-project/commit/e95ee300c0530158d86430fd82ffabd36262e862.diff
Author: Mariya Podchishchaeva
Date: 2020-05-29T18:00:48+03:00
New Revision: cf6cc6622b1416430f517850be9032788e39
URL:
https://github.com/llvm/llvm-project/commit/cf6cc6622b1416430f517850be9032788e39
DIFF:
https://github.com/llvm/llvm-project/commit/cf6cc6622b1416430f517850be9032788e
Author: Mariya Podchishchaeva
Date: 2020-05-30T12:27:58+03:00
New Revision: bd85b7d6688725e854a694f9f3e8baa6a3077a4a
URL:
https://github.com/llvm/llvm-project/commit/bd85b7d6688725e854a694f9f3e8baa6a3077a4a
DIFF:
https://github.com/llvm/llvm-project/commit/bd85b7d6688725e854a694f9f3e8baa6a3077a
Author: Alexey Bader
Date: 2020-07-29T17:24:53+03:00
New Revision: 8d27be8dbaffce0519ac41173d51923fc2524b1b
URL:
https://github.com/llvm/llvm-project/commit/8d27be8dbaffce0519ac41173d51923fc2524b1b
DIFF:
https://github.com/llvm/llvm-project/commit/8d27be8dbaffce0519ac41173d51923fc2524b1b.diff
Author: Alexey Bader
Date: 2020-06-17T13:04:01+03:00
New Revision: 93cd4115799cefa698833ca7a2f1899243d94c77
URL:
https://github.com/llvm/llvm-project/commit/93cd4115799cefa698833ca7a2f1899243d94c77
DIFF:
https://github.com/llvm/llvm-project/commit/93cd4115799cefa698833ca7a2f1899243d94c77.diff
Author: Mariya Podchishchaeva
Date: 2020-06-17T14:36:00+03:00
New Revision: 0bdcd95bf20f159a2512aff1ef032bec52039bf6
URL:
https://github.com/llvm/llvm-project/commit/0bdcd95bf20f159a2512aff1ef032bec52039bf6
DIFF:
https://github.com/llvm/llvm-project/commit/0bdcd95bf20f159a2512aff1ef032bec52039b
bader added inline comments.
Comment at: lib/Sema/SemaDecl.cpp:7599-7602
@@ -7595,3 +7598,6 @@
// of event_t type.
-S.Diag(Param->getLocation(), diag::err_bad_kernel_param_type) << PT;
+// Do not diagnose half type since it is diagnosed as invalid argument
+// typ
Author: bader
Date: Fri Sep 23 09:20:00 2016
New Revision: 282252
URL: http://llvm.org/viewvc/llvm-project?rev=282252&view=rev
Log:
[OpenCL] Augment pipe built-ins with pipe packet size and alignment.
Reviewers: Anastasia, vpykhtin
Subscribers: dmitry, cfe-commits
Differential Revision: https:/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL282252: [OpenCL] Augment pipe built-ins with pipe packet
size and alignment. (authored by bader).
Changed prior to commit:
https://reviews.llvm.org/D23992?vs=70366&id=72276#toc
Repository:
rL LLVM
h
Author: Alexey Bader
Date: 2022-07-06T06:20:09-07:00
New Revision: 923b56e7ca96e03cedcb0e3a5df5c05e8e975a38
URL:
https://github.com/llvm/llvm-project/commit/923b56e7ca96e03cedcb0e3a5df5c05e8e975a38
DIFF:
https://github.com/llvm/llvm-project/commit/923b56e7ca96e03cedcb0e3a5df5c05e8e975a38.diff
Author: Pavel Samolysov
Date: 2022-04-04T12:16:39+03:00
New Revision: 87b28f5092f2f92fc380f18e8578746bdd2a54b2
URL:
https://github.com/llvm/llvm-project/commit/87b28f5092f2f92fc380f18e8578746bdd2a54b2
DIFF:
https://github.com/llvm/llvm-project/commit/87b28f5092f2f92fc380f18e8578746bdd2a54b2.dif
bader wrote:
> How does this attribute relate to `reqd_work_group_size` and related existing
> attributes?
They seems to be different/"unrelated". Based on the description of the
`amdgpu-num-work-groups` attribute it provides "number of work-groups", whereas
`reqd_work_group_size` provides "n
Author: Alexey Bader
Date: 2019-12-28T16:35:51+03:00
New Revision: 128f39da932be50cb49646084820119e6e0d1e22
URL:
https://github.com/llvm/llvm-project/commit/128f39da932be50cb49646084820119e6e0d1e22
DIFF:
https://github.com/llvm/llvm-project/commit/128f39da932be50cb49646084820119e6e0d1e22.diff
Author: Alexey Bader
Date: 2020-12-12T23:26:54+03:00
New Revision: a500a4358789d1794bc672421c55900ea2bbc938
URL:
https://github.com/llvm/llvm-project/commit/a500a4358789d1794bc672421c55900ea2bbc938
DIFF:
https://github.com/llvm/llvm-project/commit/a500a4358789d1794bc672421c55900ea2bbc938.diff
Author: Alexey Bader
Date: 2020-09-29T15:23:50+03:00
New Revision: 9263931fcccdc99000c1de668bea330711333729
URL:
https://github.com/llvm/llvm-project/commit/9263931fcccdc99000c1de668bea330711333729
DIFF:
https://github.com/llvm/llvm-project/commit/9263931fcccdc99000c1de668bea330711333729.diff
Author: Alexey Bader
Date: 2021-05-18T10:27:35+03:00
New Revision: 2ab513cd3e0648806db7ed1f8170ad4a3d4e7749
URL:
https://github.com/llvm/llvm-project/commit/2ab513cd3e0648806db7ed1f8170ad4a3d4e7749
DIFF:
https://github.com/llvm/llvm-project/commit/2ab513cd3e0648806db7ed1f8170ad4a3d4e7749.diff
Author: Alexey Bader
Date: 2021-09-20T09:32:25+03:00
New Revision: 15feaaa359c7245bb59ff0a2aa3b806682f44286
URL:
https://github.com/llvm/llvm-project/commit/15feaaa359c7245bb59ff0a2aa3b806682f44286
DIFF:
https://github.com/llvm/llvm-project/commit/15feaaa359c7245bb59ff0a2aa3b806682f44286.diff
Author: Alexey Bader
Date: 2021-08-13T08:59:47+03:00
New Revision: c064ba34c7d867c1180279fe3dca8817d835cb28
URL:
https://github.com/llvm/llvm-project/commit/c064ba34c7d867c1180279fe3dca8817d835cb28
DIFF:
https://github.com/llvm/llvm-project/commit/c064ba34c7d867c1180279fe3dca8817d835cb28.diff
Author: Alexey Bader
Date: 2021-08-13T13:20:11+03:00
New Revision: d754b970eddb83b1c68346a36b067391d93166b0
URL:
https://github.com/llvm/llvm-project/commit/d754b970eddb83b1c68346a36b067391d93166b0
DIFF:
https://github.com/llvm/llvm-project/commit/d754b970eddb83b1c68346a36b067391d93166b0.diff
Author: Henry Linjamäki
Date: 2021-11-18T03:41:24+03:00
New Revision: 49682f14bf3fb8db5e2721d9896b27bb4c2bd635
URL:
https://github.com/llvm/llvm-project/commit/49682f14bf3fb8db5e2721d9896b27bb4c2bd635
DIFF:
https://github.com/llvm/llvm-project/commit/49682f14bf3fb8db5e2721d9896b27bb4c2bd635.dif
Author: Alexey Bader
Date: 2022-10-19T03:50:47-07:00
New Revision: 66bd6074c133402e45075b591c062c22f308ef26
URL:
https://github.com/llvm/llvm-project/commit/66bd6074c133402e45075b591c062c22f308ef26
DIFF:
https://github.com/llvm/llvm-project/commit/66bd6074c133402e45075b591c062c22f308ef26.diff
Author: Alexey Bader
Date: 2023-09-11T16:24:37-07:00
New Revision: a2e2f471c51f0aea836a4929dfdf50523dcff1eb
URL:
https://github.com/llvm/llvm-project/commit/a2e2f471c51f0aea836a4929dfdf50523dcff1eb
DIFF:
https://github.com/llvm/llvm-project/commit/a2e2f471c51f0aea836a4929dfdf50523dcff1eb.diff
Author: Ruyman
Date: 2020-02-27T15:08:42+03:00
New Revision: bd97704eb5a95ecb048ce343c1a4be5d94e5
URL:
https://github.com/llvm/llvm-project/commit/bd97704eb5a95ecb048ce343c1a4be5d94e5
DIFF:
https://github.com/llvm/llvm-project/commit/bd97704eb5a95ecb048ce343c1a4be5d94e5.diff
LOG: [
Author: Alexey Bader
Date: 2020-02-27T16:23:54+03:00
New Revision: 740ed617f7d4d16e7883636c5eff994f8be7eba4
URL:
https://github.com/llvm/llvm-project/commit/740ed617f7d4d16e7883636c5eff994f8be7eba4
DIFF:
https://github.com/llvm/llvm-project/commit/740ed617f7d4d16e7883636c5eff994f8be7eba4.diff
Author: Mariya Podchishchaeva
Date: 2019-12-03T16:13:22+03:00
New Revision: c094e7dc4b3f9d1c1e590b008bb1cc46e3496abd
URL:
https://github.com/llvm/llvm-project/commit/c094e7dc4b3f9d1c1e590b008bb1cc46e3496abd
DIFF:
https://github.com/llvm/llvm-project/commit/c094e7dc4b3f9d1c1e590b008bb1cc46e3496a
Author: Victor Lomuller
Date: 2019-12-05T12:24:06+03:00
New Revision: 11a9bae8f66986751078501988b4414f24dbe37e
URL:
https://github.com/llvm/llvm-project/commit/11a9bae8f66986751078501988b4414f24dbe37e
DIFF:
https://github.com/llvm/llvm-project/commit/11a9bae8f66986751078501988b4414f24dbe37e.dif
Author: Alexey Bader
Date: 2019-12-11T12:40:43+03:00
New Revision: cb30ad728f0b791c72a6a1399f36ebc60ad5
URL:
https://github.com/llvm/llvm-project/commit/cb30ad728f0b791c72a6a1399f36ebc60ad5
DIFF:
https://github.com/llvm/llvm-project/commit/cb30ad728f0b791c72a6a1399f36ebc60ad5.diff
Author: Alexey Bader
Date: 2019-12-12T14:36:11+03:00
New Revision: 2d6a5e4fe45d0a1f1c94df6b3422ffb0d676fb6d
URL:
https://github.com/llvm/llvm-project/commit/2d6a5e4fe45d0a1f1c94df6b3422ffb0d676fb6d
DIFF:
https://github.com/llvm/llvm-project/commit/2d6a5e4fe45d0a1f1c94df6b3422ffb0d676fb6d.diff
Author: Ruyman
Date: 2020-03-07T18:28:54+03:00
New Revision: 118b057f1268d1789e40ffceb214e73772df04f4
URL:
https://github.com/llvm/llvm-project/commit/118b057f1268d1789e40ffceb214e73772df04f4
DIFF:
https://github.com/llvm/llvm-project/commit/118b057f1268d1789e40ffceb214e73772df04f4.diff
LOG: [
Author: Alexey Bader
Date: 2020-02-06T08:42:31+03:00
New Revision: 863d9752105f390b31b3d08d1980d2888c15b034
URL:
https://github.com/llvm/llvm-project/commit/863d9752105f390b31b3d08d1980d2888c15b034
DIFF:
https://github.com/llvm/llvm-project/commit/863d9752105f390b31b3d08d1980d2888c15b034.diff
Author: Alexey Bader
Date: 2020-01-21T18:30:56+03:00
New Revision: dd18729b2a7a23b76b8d74fbf4f4bb4efbe8aa97
URL:
https://github.com/llvm/llvm-project/commit/dd18729b2a7a23b76b8d74fbf4f4bb4efbe8aa97
DIFF:
https://github.com/llvm/llvm-project/commit/dd18729b2a7a23b76b8d74fbf4f4bb4efbe8aa97.diff
Author: bader
Date: Wed Nov 15 03:38:17 2017
New Revision: 318290
URL: http://llvm.org/viewvc/llvm-project?rev=318290&view=rev
Log:
[OpenCL] Fix code generation of function-scope constant samplers.
Summary:
Constant samplers are handled as static variables and clang's code generation
library, whi
bader accepted this revision.
bader added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D23914
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
bader accepted this revision.
bader added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D23915
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
bader created this revision.
bader added reviewers: Anastasia, vpykhtin.
bader added a subscriber: cfe-commits.
Keep pipe packet size and alignment in LLVM IR layer to enable
translation from LLVM IR to SPIR-V format.
https://reviews.llvm.org/D23992
Files:
lib/CodeGen/CGBuiltin.cpp
lib/CodeG
This revision was automatically updated to reflect the committed changes.
Closed by commit rL280097: [OpenCL] Make is_valid_event, create_user_event
overloadable. (authored by bader).
Changed prior to commit:
https://reviews.llvm.org/D23914?vs=69650&id=69682#toc
Repository:
rL LLVM
https://
Author: bader
Date: Tue Aug 30 09:42:54 2016
New Revision: 280097
URL: http://llvm.org/viewvc/llvm-project?rev=280097&view=rev
Log:
[OpenCL] Make is_valid_event, create_user_event overloadable.
Summary: Make is_valid_event and create_user_event overloadable like other
built-ins.
Patch by Evgeni
bader created this revision.
bader added a reviewer: Anastasia.
bader added subscribers: yaxunl, cfe-commits.
By default return type of call expressions calling built-in
functions is set to bool.
Fixes https://llvm.org/bugs/show_bug.cgi?id=30219.
https://reviews.llvm.org/D24136
Files:
lib/Sem
bader added a comment.
Could you a regression test, please?
https://reviews.llvm.org/D24054
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bader updated this revision to Diff 70366.
bader added a comment.
Applied code review comment from Anastasia.
Use getTypeSizeInChars instead of getTypeSize to get type size in bytes. Assume
that char size is always one byte.
https://reviews.llvm.org/D23992
Files:
lib/CodeGen/CGBuiltin.cpp
bader updated this revision to Diff 70368.
bader added a comment.
Added get_pipe_num_packets and get_pipe_max_packets test cases.
https://reviews.llvm.org/D24136
Files:
lib/Sema/SemaChecking.cpp
test/CodeGenOpenCL/pipe_builtin.cl
Index: test/CodeGenOpenCL/pipe_builtin.cl
==
Author: bader
Date: Tue Sep 6 05:10:28 2016
New Revision: 280699
URL: http://llvm.org/viewvc/llvm-project?rev=280699&view=rev
Log:
[OpenCL] Remove access qualifiers on images in arg info metadata.
Summary:
Remove access qualifiers on images in arg info metadata:
* kernel_arg_type
* kernel_arg_
This revision was automatically updated to reflect the committed changes.
Closed by commit rL280699: [OpenCL] Remove access qualifiers on images in arg
info metadata. (authored by bader).
Changed prior to commit:
https://reviews.llvm.org/D23915?vs=69649&id=70372#toc
Repository:
rL LLVM
http
Author: bader
Date: Wed Sep 7 05:32:03 2016
New Revision: 280800
URL: http://llvm.org/viewvc/llvm-project?rev=280800&view=rev
Log:
[OpenCL] Fix pipe built-in functions return type.
By default return type of call expressions calling built-in
functions is set to bool.
Fixes https://llvm.org/bugs/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL280800: [OpenCL] Fix pipe built-in functions return type.
(authored by bader).
Changed prior to commit:
https://reviews.llvm.org/D24136?vs=70368&id=70516#toc
Repository:
rL LLVM
https://reviews.llvm
bader added a comment.
Valery, do you have any additional comments/questions regarding this patch?
https://reviews.llvm.org/D23992
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bader accepted this revision.
bader added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks.
https://reviews.llvm.org/D24626
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
bader added inline comments.
Comment at: test/SemaOpenCL/half.cl:29
@@ +28,3 @@
+kernel void half_disabled_kernel(global half *p,
+ half h); // expected-error{{'half' cannot be
used as the type of a kernel parameter}} // expected-error{{declaring
bader added inline comments.
Comment at: lib/Sema/SemaDecl.cpp:7599-7602
@@ -7595,3 +7598,6 @@
// of event_t type.
-S.Diag(Param->getLocation(), diag::err_bad_kernel_param_type) << PT;
+// Do not diagnose half type since it is diagnosed as invalid argument
+// typ
Author: bader
Date: Thu Jun 29 01:44:10 2017
New Revision: 306653
URL: http://llvm.org/viewvc/llvm-project?rev=306653&view=rev
Log:
[OpenCL] Allow function declaration with empty argument list.
Summary:
does it make sense to enable K&R function declaration style for OpenCL?
clang throws following
Author: bader
Date: Fri Jan 26 03:48:46 2018
New Revision: 323522
URL: http://llvm.org/viewvc/llvm-project?rev=323522&view=rev
Log:
[OpenCL] Add "cles_khr_int64" extension.
Summary:
For OpenCL 1.1 embedded profile 64 bit integers i.e. long,
ulong including the appropriate vector data types and op
bader accepted this revision.
bader added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks!
A few minor comments regarding outdated comments and style.
Comment at: include/clang/AST/ASTContext.h:1124
/// \brief Return pipe type for the specified typ
Author: bader
Date: Tue Nov 29 04:21:40 2016
New Revision: 288126
URL: http://llvm.org/viewvc/llvm-project?rev=288126&view=rev
Log:
[OpenCL] Prohibit using reserve_id_t in program scope.
Patch by Egor Churaev (echuraev).
Reviewers: Anastasia
Subscribers: cfe-commits, yaxunl, bader
Differential
Author: bader
Date: Wed Dec 7 02:38:24 2016
New Revision: 288890
URL: http://llvm.org/viewvc/llvm-project?rev=288890&view=rev
Log:
[OpenCL] Fix SPIR version generation.
Patch by Egor Churaev (echuraev).
Reviewers: Anastasia
Subscribers: bader, yaxunl, cfe-commits
Differential Revision: https:
Author: bader
Date: Wed Dec 7 02:43:49 2016
New Revision: 288891
URL: http://llvm.org/viewvc/llvm-project?rev=288891&view=rev
Log:
[OpenCL] Added a LIT test for ensuring address space mangling is done the same
both in OpenCL1.2 and OpenCL2.0.
Patch by Egor Churaev (echuraev).
Reviewers: Anasta
bader accepted this revision.
bader added a comment.
LGTM
https://reviews.llvm.org/D25305
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bader added inline comments.
Comment at: lib/CodeGen/CGDecl.cpp:1272
+if (getLangOpts().OpenCL) {
+ UA = llvm::GlobalValue::UnnamedAddr::None;
+ AS = CGM.getContext().getTargetAddressSpace(LangAS::opencl_constant);
AlexeySotkin wrote:
> Anastasia wr
bader added inline comments.
Comment at: lib/CodeGen/CGDecl.cpp:1272
+if (getLangOpts().OpenCL) {
+ UA = llvm::GlobalValue::UnnamedAddr::None;
+ AS = CGM.getContext().getTargetAddressSpace(LangAS::opencl_constant);
Anastasia wrote:
> bader wrote:
>
Author: bader
Date: Mon Oct 31 05:26:31 2016
New Revision: 285557
URL: http://llvm.org/viewvc/llvm-project?rev=285557&view=rev
Log:
[OpenCL] Setting constant address space for array initializers
Summary: Setting constant address space for global constants used for
memcpy-initialization of arrays
bader added a comment.
Committed at 285557 with updated tests.
https://reviews.llvm.org/D25305
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: bader
Date: Tue Nov 1 10:50:52 2016
New Revision: 285700
URL: http://llvm.org/viewvc/llvm-project?rev=285700&view=rev
Log:
[OpenCL] Override supported OpenCL extensions with -cl-ext option
Summary:
This patch adds a command line option '-cl-ext' to control a set of
supported OpenCL exten
This revision was automatically updated to reflect the committed changes.
Closed by commit rL285700: [OpenCL] Override supported OpenCL extensions with
-cl-ext option (authored by bader).
Changed prior to commit:
https://reviews.llvm.org/D23712?vs=75568&id=76571#toc
Repository:
rL LLVM
http
bader added a comment.
@pekka.jaaskelainen, I have related question: what is the problem with
retaining OpenCL address space information in LLVM IR?
My understanding is that target CodeGen can ignore this information for the
machines with 'flat' address space model.
On the other hand I would exp
bader created this revision.
bader added a reviewer: pekka.jaaskelainen.
bader added a subscriber: cfe-commits.
Patch by Pedro Ferreira.
This patch was reviewed here:
http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20150629/thread.html#131992,
but wasn't submitted into the tree.
Rebased
bader added a comment.
In http://reviews.llvm.org/D12855#246004, @pekka.jaaskelainen wrote:
> The patch seems straightforward enough. BTW does someone know if anyone has
> worked on the 'pipe' qualifier?
I'm currently supporting Intel's implementation of 'pipe' qualifier and I'd
like to contr
Author: bader
Date: Tue Sep 15 06:18:52 2015
New Revision: 247676
URL: http://llvm.org/viewvc/llvm-project?rev=247676&view=rev
Log:
[OpenCL] Add new types for OpenCL 2.0.
Patch by Pedro Ferreira.
Reviewers: pekka.jaaskelainen
Differential Revision: http://reviews.llvm.org/D12855
Modified:
cf
This revision was automatically updated to reflect the committed changes.
Closed by commit rL247676: [OpenCL] Add new types for OpenCL 2.0. (authored by
bader).
Changed prior to commit:
http://reviews.llvm.org/D12855?vs=34709&id=34796#toc
Repository:
rL LLVM
http://reviews.llvm.org/D12855
Author: bader
Date: Tue Sep 15 07:18:29 2015
New Revision: 247678
URL: http://llvm.org/viewvc/llvm-project?rev=247678&view=rev
Log:
Run clang-format to unify the switch statement style as suggest here:
http://reviews.llvm.org/D12855#246073.
NFC.
Modified:
cfe/trunk/lib/AST/ItaniumMangle.cpp
bader added a subscriber: bader.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:7472-7473
@@ -7469,4 +7471,4 @@
"sampler type cannot be used with the __local and __global address space
qualifiers">;
def err_opencl_global_invalid_addr_space : Error<
- "global variable
bader created this revision.
bader added a subscriber: cfe-commits.
http://reviews.llvm.org/D12378
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaExpr.cpp
test/SemaOpenCL/cond.cl
Index: test/SemaOpenCL/cond.cl
Author: bader
Date: Sun Aug 30 13:06:39 2015
New Revision: 246393
URL: http://llvm.org/viewvc/llvm-project?rev=246393&view=rev
Log:
[OpenCL] Improve diagnostics detecting implicit vector conversion.
Reviewers: pekka.jaaskelainen
Differential Revision: http://reviews.llvm.org/D12470
Modified:
bader closed this revision.
bader added a comment.
Thanks! Committed at rev. 246393.
http://reviews.llvm.org/D12378
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bader created this revision.
bader added reviewers: pekka.jaaskelainen, gbenyei.
bader added a subscriber: cfe-commits.
Initial support for OpenCL 2.0 feature: pipe types.
http://reviews.llvm.org/D14441
Files:
include/clang/AST/ASTContext.h
include/clang/AST/DataRecursiveASTVisitor.h
inclu
bader added inline comments.
Comment at: test/CodeGenOpenCL/cl20-device-side-enqueue.cl:12
@@ -11,3 +11,3 @@
unsigned flags = 0;
- // CHECK: %ndrange = alloca %opencl.ndrange_t*
+ // CHECK: %ndrange = alloca %ndrange_t
ndrange_t ndrange;
Could you also add
bader created this revision.
bader added reviewers: Anastasia, yaxunl.
bader added a subscriber: cfe-commits.
In order to re-define OpenCL built-in functions
'to_{private,local,global}' in OpenCL run-time library LLVM names must
be different from the clang built-in function names.
https://reviews
Author: bader
Date: Thu Aug 4 13:06:27 2016
New Revision: 277743
URL: http://llvm.org/viewvc/llvm-project?rev=277743&view=rev
Log:
[OpenCL] Added underscores to the names of 'to_addr' OpenCL built-ins.
Summary:
In order to re-define OpenCL built-in functions
'to_{private,local,global}' in OpenCL
This revision was automatically updated to reflect the committed changes.
Closed by commit rL277743: [OpenCL] Added underscores to the names of 'to_addr'
OpenCL built-ins. (authored by bader).
Changed prior to commit:
https://reviews.llvm.org/D23120?vs=66653&id=66832#toc
Repository:
rL LLVM
bader added a subscriber: bader.
Comment at: test/SemaOpenCL/ternary-implicit-casts.cl:10-11
@@ +9,4 @@
+kernel void implicit_cast_generic(global int* gint, local int* lint, int cond)
{
+ // will compile, ptr is generic and can accept global and local
+ int* ptr = con
bader accepted this revision.
bader added a reviewer: bader.
bader added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D20090
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cg
bader accepted this revision.
bader added a comment.
This revision is now accepted and ready to land.
LGTM.
Comment at: test/CodeGenOpenCL/as_type.cl:6
@@ +5,3 @@
+
+//CHECK: define spir_func <3 x i8> @f1(<4 x i8> %[[x:.*]])
+//CHECK: %[[astype:.*]] = shufflevector <4 x i8> %[[x
bader added inline comments.
Comment at: include/clang/Basic/OpenCLExtensions.def:64
@@ +63,3 @@
+OPENCLEXT_INTERNAL(cl_khr_initialize_memory, 200, ~0U)
+OPENCLEXT_INTERNAL(cl_khr_spir, 200, ~0U)
+OPENCLEXT_INTERNAL(cl_khr_srgb_image_writes, 200, ~0U)
Minimum requ
bader accepted this revision.
bader added a comment.
LGTM. Thanks!
http://reviews.llvm.org/D19484
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bader added inline comments.
Comment at: include/clang/AST/ASTContext.h:903
@@ +902,3 @@
+#define IMAGE_TYPE(ImgType, Id, SingletonId, Access, Suffix)
\
+ CanQualType SingletonId;
+#include "clang/AST/OpenCLImageTypes.def"
mgrang wrote:
> remov
bader added a comment.
In http://reviews.llvm.org/D17821#393387, @Anastasia wrote:
> Regarding, extending this approach for OpenCL pipe types too. I was thinking
> we could change current implementation to have ReadPipeType and
> WritePipeType. They can both be derived from PipeType that we alr
bader added a comment.
In http://reviews.llvm.org/D17821#394620, @Anastasia wrote:
> Yes, I think it's better to go in a separate commit, not to complicate this
> one too much. Also since there are not many comment here, I think we should
> try to commit it ASAP otherwise rebasing would be an i
Author: bader
Date: Fri Apr 8 08:40:33 2016
New Revision: 265783
URL: http://llvm.org/viewvc/llvm-project?rev=265783&view=rev
Log:
[OpenCL] Complete image types support.
I. Current implementation of images is not conformant to spec in the following
points:
1. It makes no distinction with resp
bader added a comment.
In http://reviews.llvm.org/D17821#394708, @bader wrote:
> In http://reviews.llvm.org/D17821#394620, @Anastasia wrote:
>
> > Yes, I think it's better to go in a separate commit, not to complicate this
> > one too much. Also since there are not many comment here, I think we
This revision was automatically updated to reflect the committed changes.
Closed by commit rL265783: [OpenCL] Complete image types support. (authored by
bader).
Changed prior to commit:
http://reviews.llvm.org/D17821?vs=51303&id=53021#toc
Repository:
rL LLVM
http://reviews.llvm.org/D17821
Author: bader
Date: Wed Apr 13 03:33:41 2016
New Revision: 266180
URL: http://llvm.org/viewvc/llvm-project?rev=266180&view=rev
Log:
[OpenCL] Move OpenCLImageTypes.def from clangAST to clangBasic library.
Putting OpenCLImageTypes.def to clangAST library violates layering requirement:
"It's not OK
Author: bader
Date: Wed Apr 13 04:54:47 2016
New Revision: 266187
URL: http://llvm.org/viewvc/llvm-project?rev=266187&view=rev
Log:
[modules] Add OpenCLImageTypes.def to module map to fix the modules build.
Modified:
cfe/trunk/include/clang/module.modulemap
Modified: cfe/trunk/include/clang/
bader added a comment.
LGTM
http://reviews.llvm.org/D19071
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bader added inline comments.
Comment at: lib/Headers/opencl.h:14892-14898
@@ +14891,9 @@
+
+/**
+* Sampler-less Image Access
+*/
+
+float4 __const_func __attribute__((overloadable)) read_imagef(read_only
image1d_t image, int coord);
+int4 __const_func __attribute__((overloadable)
bader added inline comments.
Comment at: lib/Headers/opencl.h:15372-15373
@@ +15371,4 @@
+ */
+int __const_func __attribute__((overloadable)) get_image_width(image1d_t
image);
+int __const_func __attribute__((overloadable))
get_image_width(image1d_buffer_t image);
+int __const_f
bader added a comment.
To clarify my last comment: I don't think we should define Image Query built-in
functions only for 'read_only' access qualifier in OpenCL 1.x.
It's just bug in OpenCL 1.x specifications. I think the intention was to
provide these built-in functions for both 'read_only' and
1 - 100 of 198 matches
Mail list logo
