bader added a comment. In http://reviews.llvm.org/D17821#393387, @Anastasia wrote:
> Regarding, extending this approach for OpenCL pipe types too. I was thinking > we could change current implementation to have ReadPipeType and > WritePipeType. They can both be derived from PipeType that we already have > now (we can make it an abstract class to avoid its instantiation?). > > Similarly to images, since read and write pipes will be mapped to different > Clang types, we won't need any extra semantical checking but just need to add > extra code in CodeGen of pipe type and builtins to accept two separate types > for read only and write only cases. > > Would this make sense? Sure. Do you want me to add it here or it's okay if we fix pipes in a separate patch? ================ Comment at: include/clang/AST/ASTContext.h:903 @@ +902,3 @@ +#define IMAGE_TYPE(ImgType, Id, SingletonId, Access, Suffix) \ + CanQualType SingletonId; +#include "clang/AST/OpenCLImageTypes.def" ---------------- Anastasia wrote: > bader wrote: > > mgrang wrote: > > > remove extra spacing in front of the \ > > Sorry for delay... > > I used clang-format tool to format that code. I expect it to be in > > agreement with LLVM coding style guide. > > Did I miss something or it's clang-format bug? > I would have thought clang-format should be fine. > > But it does look a bit weird here. There are other places in this patch that > have the same formatting. > > I can't find anything relevant in coding style description: > http://llvm.org/docs/CodingStandards.html#source-code-width > > I'll remove extra spacing. http://reviews.llvm.org/D17821 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
