[PATCH] D71499: Add builtins for aligning and checking alignment of pointers and integers

arichardson updated this revision to Diff 234064. arichardson added a comment. Fix align32array[0] -> &align32array[0] typo in test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71499/new/ https://reviews.llvm.org/D71499 Files: clang/include/cla

[PATCH] D71554: [llvm-ranlib] Handle -D and -U command line flag

arichardson created this revision. arichardson added a reviewer: rupprecht. Herald added subscribers: llvm-commits, cfe-commits, krytarowski, emaste. Herald added projects: clang, LLVM. arichardson updated this revision to Diff 234082. arichardson added a comment. Drop unrelated change I have be

[PATCH] D71554: [llvm-ranlib] Handle -D and -U command line flag

arichardson updated this revision to Diff 234082. arichardson added a comment. Drop unrelated change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71554/new/ https://reviews.llvm.org/D71554 Files: llvm/test/tools/llvm-ranlib/D-flag.test llvm/t

[PATCH] D71554: [llvm-ranlib] Handle -D and -U command line flag

arichardson updated this revision to Diff 234088. arichardson added a comment. Force UTC timezone for reproducible results Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71554/new/ https://reviews.llvm.org/D71554 Files: llvm/test/tools/llvm-ranli

[PATCH] D71554: [llvm-ranlib] Handle -D and -U command line flag

arichardson marked an inline comment as done. arichardson added inline comments. Comment at: llvm/tools/llvm-ar/llvm-ar.cpp:69 + --version - Display the version of this program + -D- Use zero for timestamps and uids/gids (default) + -U

[PATCH] D71554: [llvm-ranlib] Handle -D and -U command line flag

arichardson updated this revision to Diff 234479. arichardson added a comment. Also handle -h/-v as short options. Does the adjusted test look okay? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71554/new/ https://reviews.llvm.org/D71554 Files:

[PATCH] D71615: [clang] [cmake] Fix gen_ast_dump_json_test.py binary dir

arichardson accepted this revision. arichardson added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71615/new/ https://reviews.llvm.org/D71615 ___ cfe-commits mailing list cfe

[PATCH] D71554: [llvm-ranlib] Handle -D and -U command line flag

arichardson updated this revision to Diff 234506. arichardson added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71554/new/ https://reviews.llvm.org/D71554 Files: llvm/test/tools/llvm-ranlib/D-flag.test llvm/test/tools

[PATCH] D71499: Add builtins for aligning and checking alignment of pointers and integers

arichardson updated this revision to Diff 234921. arichardson added a comment. - Add documentation for the new alignment builtins Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71499/new/ https://reviews.llvm.org/D71499 Files: clang/docs/Language

[PATCH] D73742: [Clang][Driver] After default -fintegrated-cc1, fix report_fatal_error no longer generates preprocessed source + reproducer.sh

arichardson added inline comments. Comment at: clang/tools/driver/cc1_main.cpp:73 // defined as an internal software error. Otherwise, exit with status 1. - exit(GenCrashDiag ? 70 : 1); + llvm::sys::Process::Exit(GenCrashDiag ? 70 : 1); } I don't think it

[PATCH] D74051: Add a dependency on clang for check-llvm

arichardson updated this revision to Diff 243859. arichardson added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Move tests to clang/ instead Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74051/new/ https://revi

[PATCH] D74051: Move update_cc_test_checks.py tests to clang

This revision was automatically updated to reflect the committed changes. Closed by commit rG61dd0603bd8a: Move update_cc_test_checks.py tests to clang (authored by arichardson). Changed prior to commit: https://reviews.llvm.org/D74051?vs=243859&id=244650#toc Repository: rG LLVM Github Monor

[PATCH] D74051: Move update_cc_test_checks.py tests to clang

arichardson added a comment. In D74051#1876291 , @thakis wrote: > Fails on windows, looks like line endings: > http://45.33.8.238/win/8350/step_7.txt Are the other update_test_checks.py and update_llc_test_checks.py tests running on that bot? I would e

[PATCH] D74051: Move update_cc_test_checks.py tests to clang

arichardson added a comment. Turns out those scripts use different code to write the updated file. The failure should hopefully be fixed in rGc29310707e9a85e70a226277657cd9d9182a5d04 Repository: rG LLVM Github Monorepo CH

[PATCH] D72829: Implement -fsemantic-interposition

arichardson added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:907 + +.. option:: -fsemantic-interposition, -fno-semantic-interposition + This looks like it should be reordered? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D73543: [clang] Add support for __builtin_memcpy_inline

arichardson added inline comments. Comment at: clang/docs/LanguageExtensions.rst:2259 +``__builtin_memcpy_inline(dst, src, size)`` is identical to +``__builtin_memcpy(dst, src, size)`` expect that the generated code is +guaranteed not to call any external functions. See [LLVM IR

[PATCH] D72829: Implement -fsemantic-interposition

arichardson added a comment. In D72829#1846157 , @serge-sans-paille wrote: > @arichardson doc updated, any other advice? No comments on the code just wondering if the documentation should be expanded. I just came across this review by chance and it was

[PATCH] D72829: Implement -fsemantic-interposition

arichardson added a comment. Thanks documentation looks much better now. Comment at: clang/docs/ClangCommandLineReference.rst:907 + +.. option:: -fsemantic-interposition, -fno-semantic-interposition + arichardson wrote: > arichardson wrote: > > This looks like

[PATCH] D44093: [BUILTINS] structure pretty printer

arichardson added a comment. I'm also often restricted to using printf for debugging so this looks really useful! However, before committing this I feel like the test should also verify that the format strings that are generated are sensible. Also what should happens when you have enum members

[PATCH] D44093: [BUILTINS] structure pretty printer

arichardson accepted this revision. arichardson added a comment. > So, for the moment, we are only handling basic types. That said, for the enum > in C, we will print according to the type of the enum. > In the future versions, I really want to be able to print the name of the > enum so that th

[PATCH] D44093: [BUILTINS] structure pretty printer

arichardson added a comment. In https://reviews.llvm.org/D44093#1063679, @paulsemel wrote: > Ok, I found the problem. In fact the size of `long` is 4 bytes on your > machine, but 8 bytes on mine. > This makes this `// CHECK: [[LOAD1:%[0-9]+]] = load i64, i64* [[RES1]],` > fail. > Do you know

[PATCH] D44093: [BUILTINS] structure pretty printer

arichardson added a comment. In https://reviews.llvm.org/D44093#1063679, @paulsemel wrote: > Ok, I found the problem. In fact the size of `long` is 4 bytes on your > machine, but 8 bytes on mine. > This makes this `// CHECK: [[LOAD1:%[0-9]+]] = load i64, i64* [[RES1]],` > fail. > Do you know

[PATCH] D39537: Rename identifiers named `__output`

arichardson created this revision. In the CHERI clang compiler __output and __input are keywords and therefore we can't compile libc++ with our compiler. Repository: rL LLVM https://reviews.llvm.org/D39537 Files: include/algorithm include/experimental/algorithm include/experimental/ite

[PATCH] D39537: Rename identifiers named `__output`

arichardson added inline comments. Comment at: test/support/nasty_macros.hpp:55 +#define __output NASTY_MACRO +#define __input NASTY_MACRO EricWF wrote: > Shouldn't these not be defined when running the tests with a CHER compiler? > Otherwise the macro will co

[PATCH] D39537: Rename identifiers named `__output`

This revision was automatically updated to reflect the committed changes. Closed by commit rL318144: Rename identifiers named `__output` (authored by arichardson). Repository: rL LLVM https://reviews.llvm.org/D39537 Files: libcxx/trunk/include/algorithm libcxx/trunk/include/experimental/a

[PATCH] D40016: Use ImplicitConversionSequence::setAsIdentityConversion(QualType). NFC

arichardson created this revision. Slightly reduces the amount of duplicated code. https://reviews.llvm.org/D40016 Files: lib/Sema/SemaOverload.cpp Index: lib/Sema/SemaOverload.cpp === --- lib/Sema/SemaOverload.cpp +++ lib/Sema

[PATCH] D144341: [Driver][FreeBSD] Correct driver behavior if a triple is provided without a version

arichardson added a comment. LGTM, but I'll let @dim and @emaste decide if FreeBSD 8 code is still needed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144341/new/ https://reviews.llvm.org/D144341 ___ c

[PATCH] D142934: clang: Use ptrmask for pointer alignment

arichardson added a comment. The `__builtin_align_{up,down}` code generation could also make use of this IIRC. I think the reason I didn't do this initially was concerns about ptrmask not being optimized as well. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142934/new/ https://review

[PATCH] D152285: Add support for the NO_COLOR environment variable

arichardson added a comment. >>> [...] I don't know what compelling use case there is for forcing colors >>> *on*, [...] until we know why users need to force-enable colors. >> >> The reason is that adding `-fcolor-diagnostics` to the command line is not >> always feasible, e.g. most build sys

[PATCH] D139305: [clang][driver] Support option '-mcpu' on target AVR

arichardson added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:387 return A->getValue(); +if (const Arg *A = Args.getLastArg(options::OPT_mcpu_EQ)) + return A->getValue(); It looks to me that -mcpu will always take prece

[PATCH] D138722: Overload all llvm.annotation intrinsics for globals argument

arichardson updated this revision to Diff 480900. arichardson added a comment. use opaque pointers in the new test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138722/new/ https://reviews.llvm.org/D138722 Files: clang/lib/CodeGen/CGBuiltin.cpp

[PATCH] D138722: Overload all llvm.annotation intrinsics for globals argument

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. arichardson marked 2 inline comments as done. Closed by commit rG9114ac67a986: Overload all llvm.annotation intrinsics for globals argument (authored by arichardson).

[PATCH] D138316: [ASTContext] Avoid duplicating address space map. NFCI

arichardson updated this revision to Diff 481664. arichardson added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138316/new/ https://reviews.llvm.org/D138316 Files: clang/include/clang/AST/ASTContext.h clang/lib/AST/ASTConte

[PATCH] D138316: [ASTContext] Avoid duplicating address space map. NFCI

arichardson added a comment. As this is a rather simple cleanup, I'll go ahead and merge this next week unless there is any objection until then. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138316/new/ https://reviews.llvm.org/D138316 _

[PATCH] D138316: [ASTContext] Avoid duplicating address space map. NFCI

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc4c23527d6c9: [ASTContext] Avoid duplicating address space map. NFCI (authored by arichardson). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D139006: [UpdateTestChecks] Match define for labels

arichardson added a comment. I like the idea of defaulting to --function-signature for new tests a lot, so I've implemented that in D140212 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139006/new/ https://review

[PATCH] D140218: [update_cc_test_checks] Default to --function-signature for new tests

arichardson created this revision. arichardson added reviewers: nikic, lebedev.ri, jdoerfert, spatel, sebastian-ne. Herald added a project: All. arichardson requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, sstefan1. Herald added projects: clang, LLVM. This is

[PATCH] D140218: [update_cc_test_checks] Default to --function-signature for new tests

arichardson added a comment. In D140218#4001835 , @jdoerfert wrote: > I don't understand why we would remove the flag for _cc_. I feel all these > patches are going exactly in the opposite direction I would think one would > go. The flag is not being r

[PATCH] D42139: [UPSTREAM] Allow passing additional compiler/linker flags for the tests

arichardson created this revision. arichardson added a reviewer: EricWF. Herald added subscribers: cfe-commits, mgorny. These flags can be specified using the CMake variables LIBCXX_TEST_LINKER_FLAGS and LIBCXX_TEST_COMPILER_FLAGS. When building the tests for CHERI I need to pass additional flags

[PATCH] D27140: Allow clang to write compilation database records

arichardson added a comment. It would also be good to append --sysroot=DEFAULT_SYSROOT if DEFAULT_SYSROOT is not empty and there is no explicit --sysroot flag. That way the compilation database can also be consumed by a libclang based too that does not have the same DEFAULT_SYSROOT set. Repos

[PATCH] D32425: [mips] Make checks in CodeGen/mips-varargs.c less fragile

arichardson updated this revision to Diff 98059. arichardson retitled this revision from "[mips] Make N32 checks in CodeGen/mips-varargs.c less fragile" to "[mips] Make checks in CodeGen/mips-varargs.c less fragile". arichardson edited the summary of this revision. arichardson added a comment. He

[PATCH] D32425: [mips] Make checks in CodeGen/mips-varargs.c less fragile

arichardson added a comment. I don't have commit access, could you commit for me please? https://reviews.llvm.org/D32425 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D71026: Fix LLVM_ENABLE_MODULES=ON + BUILD_SHARED_LIBS=ON build

arichardson abandoned this revision. arichardson added a comment. I believe this is no longer necessary. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71026/new/ https://reviews.llvm.org/D71026 ___ cfe-c

[PATCH] D100810: [llvm] Use `GNUInstallDirs` to support custom installation dirs

arichardson added inline comments. Comment at: llvm/CMakeLists.txt:5 +include(GNUInstallDirs) + This seems to be causing the following warning for me: ``` CMake Warning (dev) at /opt/clion-2021.2/bin/cmake/linux/share/cmake-3.20/Modules/GNUInstallDirs.cmake:2

[PATCH] D100810: [llvm] Use `GNUInstallDirs` to support custom installation dirs

arichardson added inline comments. Comment at: llvm/CMakeLists.txt:5 +include(GNUInstallDirs) + arichardson wrote: > This seems to be causing the following warning for me: > > ``` > CMake Warning (dev) at > /opt/clion-2021.2/bin/cmake/linux/share/cmake-3.20/M

[PATCH] D113372: [Driver] Add CLANG_DEFAULT_PIE_ON_LINUX to emulate GCC --enable-default-pie

arichardson added inline comments. Comment at: clang/CMakeLists.txt:232 +if(CLANG_DEFAULT_PIE_ON_LINUX) + set(CLANG_DEFAULT_PIE_ON_LINUX 1) +endif() Can these 3 lines be removed after D115751? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D102669: [analyzer][ctu] Fix wrong 'multiple definitions' errors caused by space characters in lookup names when parsing the ctu index file

arichardson added inline comments. Comment at: clang/test/Analysis/ctu-lookup-name-with-space.cpp:13 +// RUN: -verify %s + +void importee(); OikawaKirie wrote: > Adding this line here. Disabling the test on non- Linux is not a good idea IMO since it means we lo

[PATCH] D98712: [Utils] Support lit-like substitutions in update_cc_test_checks

arichardson added inline comments. Comment at: llvm/utils/update_cc_test_checks.py:228 + '%t' : tempfile.NamedTemporaryFile().name, + '%S' : os.getcwd(), +} Shouldn't this be the directory containing the test? Repository: rG LLVM Github Monorep

[PATCH] D55212: Handle alloc_size attribute on function pointers

arichardson added a comment. Herald added a subscriber: jdoerfert. I completely forgot about this patch. @aaron.ballman are you still happy for me to commit this? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55212/new/ https://reviews.llvm.org/D55212 _

[PATCH] D94355: [Passes] Add relative lookup table converter pass

arichardson added inline comments. Comment at: llvm/lib/Transforms/Utils/RelLookupTableConverter.cpp:91 + ArrayType::get(Type::getInt32Ty(M.getContext()), NumElts); + GlobalVariable *RelLookupTable = new GlobalVariable( + M, IntArrayTy, LookupTable.isConstant(), Lookup

[PATCH] D97462: [clang][cli] Round-trip cc1 arguments in assert builds

arichardson added a comment. How expensive are these checks? If it is non-trivial overhead, maybe it should default to `${LLVM_ENABLE_EXPENSIVE_CHECKS}` instead? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97462/new/ https://reviews.llvm.org/D97

[PATCH] D98286: [Driver] Enable kernel address and memory sanitizers on FreeBSD

arichardson accepted this revision. arichardson added a comment. This revision is now accepted and ready to land. Does it also work on AArch64? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98286/new/ https://reviews.llvm.org/D98286 __

[PATCH] D99790: [CGCall] Annotate `this` argument with alignment

arichardson added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2314 + llvm::Align Alignment = + getNaturalTypeAlignment(ThisTy, /*BaseInfo=*/nullptr, + /*TBAAInfo=*/nullptr, Shouldn't the alignment also

[PATCH] D99996: [Driver] Drop $DEFAULT_TRIPLE-$name as a fallback program name

arichardson added a comment. I believe adding the default triple is causing the wrong linker to be selected for me when compiling with -m32, so I'd be happy for this code to be removed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6/new/ http

[PATCH] D100054: Handle flags such as -m32 when computing the triple prefix for programs

arichardson created this revision. arichardson added reviewers: MaskRay, phosek. Herald added subscribers: frasercrmck, luismarques, apazos, sameer.abuasal, pengfei, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, niosHD, sabuasal, simoncoo

[PATCH] D100054: Handle flags such as -m32 when computing the triple prefix for programs

arichardson planned changes to this revision. arichardson added a comment. In D100054#2675152 , @joerg wrote: > This sounds wrong. If you are using 'x86_64-freebsd' as triple and -m32, it > should still call 'x86_64-freebsd-ld', but it is the responsibil

[PATCH] D100054: Handle flags such as -m32 when computing the prefix for programs/runtime libs

arichardson updated this revision to Diff 336059. arichardson added a comment. Add the raw triple prefix for programs (but prefer the adjusted triple) and always use the adjusted triple for libraries. Should hopefully address the feedback from @joerg. Also improve tests to check that we don't in

[PATCH] D100054: Handle flags such as -m32 when computing the prefix for programs/runtime libs

arichardson updated this revision to Diff 336061. arichardson added a comment. Drop chunk that is no longer necessary Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100054/new/ https://reviews.llvm.org/D100054 Files: clang/include/clang/Driver/Dr

[PATCH] D97462: [clang][cli] Round-trip cc1 arguments in assert builds

arichardson added a comment. I just merged this commit into our CHERI fork and noticed some failing tests due to round tripping: We add some additional CodeGenOptions and LangOptions, but are not including those in the generated command line. For example, I added an additional `std::string CHER

[PATCH] D97462: [clang][cli] Round-trip cc1 arguments in assert builds

arichardson added a comment. In D97462#2678889 , @jansvoboda11 wrote: > In D97462#2677130 , @arichardson > wrote: > >> I just merged this commit into our CHERI fork and noticed some failing tests >> due to round

[PATCH] D100054: Handle flags such as -m32 when computing the prefix for programs/runtime libs

arichardson updated this revision to Diff 336483. arichardson added a comment. - Fix Windows path regex Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100054/new/ https://reviews.llvm.org/D100054 Files: clang/include/clang/Driver/Driver.h clang

[PATCH] D55212: Handle alloc_size attribute on function pointers

This revision was automatically updated to reflect the committed changes. Closed by commit rGdc4abca7662b: Handle alloc_size attribute on function pointers (authored by arichardson). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D55212?vs=177519&id=336519#toc

[PATCH] D98286: [Driver] Enable kernel address and memory sanitizers on FreeBSD

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG99eca1bd9c7a: [Driver] Enable kernel address and memory sanitizers on FreeBSD (authored by markj, committed by arichardson). Repository: rG LLVM G

[PATCH] D100762: [clang][cli] Extract AST dump format into extra option

arichardson requested changes to this revision. arichardson added a reviewer: aaron.ballman. arichardson added a comment. I'm not sure it's a good idea to remove the `-ast-dump=json` option. While this is -cc1 option, there do seem to be external consumers based on a quick search for "-ast-dump=

[PATCH] D100762: [clang][cli] Extract AST dump format into extra option

arichardson added a comment. In D100762#2707812 , @jansvoboda11 wrote: > If `-ast-dump=json` was a driver flag, it would be trivial to pass `-ast-dump > -ast-dump-format json` to -cc1 instead. However, aliasing a single option to > two options within t

[PATCH] D110257: [CFE][Codegen] Make sure to maintain the contiguity of all the static allocas

arichardson added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:115 +if (AllocaInsertedAtAllocaInsertPt) + AllocaAddrSpaceInsertPt = dyn_cast(V)->getIterator(); } Shouldn't this use `cast` instead? Repository: rG LLVM Github Monorepo

[PATCH] D108110: Fix LLVM_ENABLE_THREADS check from 26a92d5852b2c6bf77efd26f6c0194c913f40285

This revision was automatically updated to reflect the committed changes. Closed by commit rGbf66b0eefcda: Fix LLVM_ENABLE_THREADS check from 26a92d5852b2c6bf77efd26f6c0194c913f40285 (authored by arichardson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D105972: Fix __attribute__((annotate("")) with non-zero globals AS

This revision was automatically updated to reflect the committed changes. Closed by commit rG7cab90a7b1c4: Fix __attribute__((annotate("")) with non-zero globals AS (authored by arichardson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105972/new/

[PATCH] D87118: Add an explicit toggle for the static analyzer in clang-tidy

arichardson added inline comments. Herald added subscribers: manas, steakhal. Herald added a project: clang-tools-extra. Comment at: clang/lib/CMakeLists.txt:24 add_subdirectory(IndexSerialization) -if(CLANG_ENABLE_STATIC_ANALYZER) - add_subdirectory(StaticAnalyzer) ---

[PATCH] D109611: Fix CLANG_ENABLE_STATIC_ANALYZER=OFF building all analyzer source

arichardson created this revision. arichardson added reviewers: thakis, hans, tstellar. Herald added subscribers: manas, steakhal, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware, mgorny. arichardson requested review of this revision. Herald added projects: cla

[PATCH] D87118: Add an explicit toggle for the static analyzer in clang-tidy

arichardson added inline comments. Comment at: clang/lib/CMakeLists.txt:24 add_subdirectory(IndexSerialization) -if(CLANG_ENABLE_STATIC_ANALYZER) - add_subdirectory(StaticAnalyzer) arichardson wrote: > thakis wrote: > > hans wrote: > > > Why does removing the c

[PATCH] D109611: Fix CLANG_ENABLE_STATIC_ANALYZER=OFF building all analyzer source

arichardson added a comment. In D109611#2997236 , @thakis wrote: > Can you just set `CLANG_TIDY_ENABLE_STATIC_ANALYZER=OFF` too if you care > about this? That doesn't have any effect on the libraries linked into clang-shlib. I am not building clang-too

[PATCH] D103835: [CUDA][HIP] Fix store of vtbl in ctor

arichardson added a comment. Merging this change broke our out-of-tree CHERI targets (and Arm Morello). We use addrspace(200) for *all* globals (including vtables). It would have been nice if I had been added to this review considering that I added line you are changing here. If vtables are no

[PATCH] D103835: [CUDA][HIP] Fix store of vtbl in ctor

arichardson added a comment. In D103835#2999731 , @yaxunl wrote: > In D103835#2999545 , @arichardson > wrote: > >> Merging this change broke our out-of-tree CHERI targets (and Arm Morello). >> We use addrspace(2

[PATCH] D109841: Fix vtbl field addr space

arichardson accepted this revision. arichardson added a comment. This revision is now accepted and ready to land. Thanks, I can confirm that this fixes the assertions we were seeing after merging D103835 . A few minor suggestions below: There's a typo in the co

<    1   2   3   4