arichardson added a comment.

Merging this change broke our out-of-tree CHERI targets (and Arm Morello). We 
use addrspace(200) for *all* globals (including vtables). It would have been 
nice if I had been added to this review considering that I added line you are 
changing here.

If vtables are not in the default globals address space, I think we need 
another way of expressing this. I think 
`CGM.getContext().getTargetAddressSpace(LangAS::Default))` should also be 
correct for your use-case?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103835/new/

https://reviews.llvm.org/D103835

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to