Author: alexfh
Date: Wed Jan 31 05:31:51 2018
New Revision: 323871
URL: http://llvm.org/viewvc/llvm-project?rev=323871&view=rev
Log:
Update header guard.
Modified:
clang-tools-extra/trunk/clang-tidy/bugprone/IncorrectRoundingsCheck.h
Modified: clang-tools-extra/trunk/clang-tidy/bugprone/Inco
Author: alexfh
Date: Thu Feb 1 08:39:12 2018
New Revision: 323980
URL: http://llvm.org/viewvc/llvm-project?rev=323980&view=rev
Log:
[clang-tidy] misc-redundant-expression: fix a crash under ubsan
Modified:
clang-tools-extra/trunk/clang-tidy/misc/RedundantExpressionCheck.cpp
clang-tools-e
Thanks! I knew there was something already, but I hadn't find it ;)
On Fri, Feb 2, 2018 at 2:23 PM, Benjamin Kramer via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: d0k
> Date: Fri Feb 2 05:23:21 2018
> New Revision: 324079
>
> URL: http://llvm.org/viewvc/llvm-project?rev=324079&vi
Author: alexfh
Date: Fri Feb 10 08:57:19 2017
New Revision: 294751
URL: http://llvm.org/viewvc/llvm-project?rev=294751&view=rev
Log:
[clang-tidy] Fix handling of function types in google-readability-casting
Modified:
clang-tools-extra/trunk/clang-tidy/google/AvoidCStyleCastsCheck.cpp
clan
Author: alexfh
Date: Thu Feb 16 04:23:18 2017
New Revision: 295303
URL: http://llvm.org/viewvc/llvm-project?rev=295303&view=rev
Log:
[clang-tidy] Ignore spaces between globs in the Checks option.
Modified:
clang-tools-extra/trunk/clang-tidy/ClangTidyDiagnosticConsumer.cpp
clang-tools-ext
Author: alexfh
Date: Sat Feb 18 03:45:00 2017
New Revision: 295544
URL: http://llvm.org/viewvc/llvm-project?rev=295544&view=rev
Log:
[clang-tidy] google-readability-casting: Handle user-defined conversions
Modified:
clang-tools-extra/trunk/clang-tidy/google/AvoidCStyleCastsCheck.cpp
clang
Author: alexfh
Date: Tue Feb 28 08:13:26 2017
New Revision: 296472
URL: http://llvm.org/viewvc/llvm-project?rev=296472&view=rev
Log:
Misspelled checker description (argument comment)
Reviewers: alexfh
Reviewed By: alexfh
Subscribers: Eugene.Zelenko
Tags: #clang-tools-extra
Patch by Peter Szec
Author: alexfh
Date: Wed Mar 1 04:16:36 2017
New Revision: 296598
URL: http://llvm.org/viewvc/llvm-project?rev=296598&view=rev
Log:
[clang-tidy] Fix handling of methods with try-statement as a body in
modernize-use-override
Summary:
Fix generated by modernize-use-override caused syntax error wh
Author: alexfh
Date: Wed Mar 1 04:17:32 2017
New Revision: 296599
URL: http://llvm.org/viewvc/llvm-project?rev=296599&view=rev
Log:
[clang-tidy] Add parametercount for readibility-function-size
Summary:
Add an option to function-size to warn about high parameter counts.
This might be relevant f
Author: alexfh
Date: Wed Mar 1 08:41:11 2017
New Revision: 296627
URL: http://llvm.org/viewvc/llvm-project?rev=296627&view=rev
Log:
[clang-tidy] Attempt to fix the test where exceptions are disabled by default.
Modified:
clang-tools-extra/trunk/test/clang-tidy/modernize-use-override.cpp
Mod
Author: alexfh
Date: Thu Mar 2 02:28:55 2017
New Revision: 296734
URL: http://llvm.org/viewvc/llvm-project?rev=296734&view=rev
Log:
[clang-tidy] Function names configurable for cppcoreguidelines-nomalloc -
checker
Summary:
Hello everybody,
this is an incremental patch for the NoMalloc-Checker
Author: alexfh
Date: Thu Mar 2 09:27:34 2017
New Revision: 296753
URL: http://llvm.org/viewvc/llvm-project?rev=296753&view=rev
Log:
[clang-tidy] Fix a few more issues in google-readability-casting
* suggest static_cast instead of reinterpret_cast for casts from void*
* top-level const doesn't ne
Author: alexfh
Date: Thu Mar 2 09:47:28 2017
New Revision: 296755
URL: http://llvm.org/viewvc/llvm-project?rev=296755&view=rev
Log:
[clang-tidy] google-readability-casting: detect redundant casts with top-level
const
Modified:
clang-tools-extra/trunk/clang-tidy/google/AvoidCStyleCastsCheck.
Author: alexfh
Date: Fri Mar 3 02:18:49 2017
New Revision: 296858
URL: http://llvm.org/viewvc/llvm-project?rev=296858&view=rev
Log:
[clang-tidy] google-readability-casting: don't use constructor call syntax for
const types
Modified:
clang-tools-extra/trunk/clang-tidy/google/AvoidCStyleCasts
Author: alexfh
Date: Fri Mar 3 05:16:34 2017
New Revision: 296864
URL: http://llvm.org/viewvc/llvm-project?rev=296864&view=rev
Log:
[clang-tidy] Format code around applied fixes
Summary:
Add -format option (disabled by default for now) to trigger formatting
of replacements.
Reviewers: ioeric
R
Author: alexfh
Date: Wed Mar 8 16:19:55 2017
New Revision: 297311
URL: http://llvm.org/viewvc/llvm-project?rev=297311&view=rev
Log:
[clang-tidy] readability-function-size: remove default param count threshold
Modified:
clang-tools-extra/trunk/clang-tidy/readability/FunctionSizeCheck.cpp
Mod
Thank you! Completely forgot about this.
On Thu, Mar 9, 2017 at 10:15 AM, Haojian Wu via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: hokein
> Date: Thu Mar 9 03:15:16 2017
> New Revision: 297367
>
> URL: http://llvm.org/viewvc/llvm-project?rev=297367&view=rev
> Log:
> [clang-tidy]
t; take this to mean that vim has done the decoding already. If not, there's
> a bug
> in vim.
>
> I've attached a small patch that addresses this issue. Wdyt?
>
>
>
>
> thanks,
> vedant
>
>
> > On Oct 27, 2016, at 8:15 AM, Alexander Kornie
Author: alexfh
Date: Tue Dec 13 10:19:19 2016
New Revision: 289542
URL: http://llvm.org/viewvc/llvm-project?rev=289542&view=rev
Log:
Remove deprecated methods ast_matchers::BoundNodes::{getStmtAs,getDeclAs}
Modified:
clang-tools-extra/trunk/clang-tidy/misc/BoolPointerImplicitConversionCheck.
Author: alexfh
Date: Tue Dec 13 10:19:34 2016
New Revision: 289543
URL: http://llvm.org/viewvc/llvm-project?rev=289543&view=rev
Log:
Remove deprecated methods ast_matchers::BoundNodes::{getStmtAs,getDeclAs}
Modified:
cfe/trunk/include/clang/ASTMatchers/ASTMatchers.h
cfe/trunk/lib/Tooling/
Author: alexfh
Date: Tue Dec 13 10:38:18 2016
New Revision: 289546
URL: http://llvm.org/viewvc/llvm-project?rev=289546&view=rev
Log:
[Clang-tidy] check for malloc, realloc and free calls
Summary:
This checker flags the use of C-style memory management functionality and notes
about modern alterna
Author: alexfh
Date: Tue Dec 13 10:38:45 2016
New Revision: 289547
URL: http://llvm.org/viewvc/llvm-project?rev=289547&view=rev
Log:
Remove trailing whitespace in docs and clang-tidy sources.
Modified:
clang-tools-extra/trunk/clang-tidy/modernize/LoopConvertCheck.cpp
clang-tools-extra/tru
Author: alexfh
Date: Tue Dec 13 10:49:10 2016
New Revision: 289549
URL: http://llvm.org/viewvc/llvm-project?rev=289549&view=rev
Log:
Fix sphinx build.
Modified:
clang-tools-extra/trunk/docs/clang-tidy/checks/cppcoreguidelines-no-malloc.rst
Modified:
clang-tools-extra/trunk/docs/clang-tidy/
Author: alexfh
Date: Wed Apr 26 11:39:11 2017
New Revision: 301431
URL: http://llvm.org/viewvc/llvm-project?rev=301431&view=rev
Log:
[clang-tidy] Update IdentifierNamingCheck to remove extra leading/trailing
underscores
Summary:
The goal of this change is to fix the following suboptimal replacem
Author: alexfh
Date: Sat Apr 29 07:06:45 2017
New Revision: 301743
URL: http://llvm.org/viewvc/llvm-project?rev=301743&view=rev
Log:
[clang-tidy] Expand AllowConditional*Casts to binary logical operators
Modified:
clang-tools-extra/trunk/clang-tidy/readability/ImplicitBoolCastCheck.cpp
c
Author: alexfh
Date: Thu May 4 10:34:06 2017
New Revision: 302159
URL: http://llvm.org/viewvc/llvm-project?rev=302159&view=rev
Log:
[Tooling] add a createReplacement overload for StringRef
Modified:
cfe/trunk/include/clang/Tooling/FixIt.h
Modified: cfe/trunk/include/clang/Tooling/FixIt.h
UR
Author: alexfh
Date: Thu May 4 10:34:23 2017
New Revision: 302160
URL: http://llvm.org/viewvc/llvm-project?rev=302160&view=rev
Log:
[clang-tidy] Code cleanup, (almost) NFC (*).
(*) Printed types of member pointers don't use elaborated type specifiers
(`int struct S::*` -> `int S::*`).
Modified:
Author: alexfh
Date: Thu May 4 10:34:31 2017
New Revision: 302161
URL: http://llvm.org/viewvc/llvm-project?rev=302161&view=rev
Log:
[clang-tidy] fix readability-implicit-bool-cast false alarm on |=, &=
Modified:
clang-tools-extra/trunk/clang-tidy/readability/ImplicitBoolCastCheck.cpp
cla
Author: alexfh
Date: Thu May 4 11:06:08 2017
New Revision: 302164
URL: http://llvm.org/viewvc/llvm-project?rev=302164&view=rev
Log:
[clang-tidy] fix readability-implicit-bool-cast false positive with xor
Modified:
clang-tools-extra/trunk/clang-tidy/readability/ImplicitBoolCastCheck.cpp
c
Author: alexfh
Date: Fri May 5 12:33:49 2017
New Revision: 302261
URL: http://llvm.org/viewvc/llvm-project?rev=302261&view=rev
Log:
[clang-tidy] Fix misc-move-const-arg for move-only types.
Summary: Fix misc-move-const-arg false positives on move-only types.
Reviewers: sbenza
Reviewed By: sben
Author: alexfh
Date: Mon May 8 09:17:27 2017
New Revision: 302425
URL: http://llvm.org/viewvc/llvm-project?rev=302425&view=rev
Log:
[clang-tidy] Ignore private =deleted methods in macros.
modernize-use-equals-delete is extremely noisy in code using
DISALLOW_COPY_AND_ASSIGN-style macros and there
Author: alexfh
Date: Mon May 8 10:22:09 2017
New Revision: 302431
URL: http://llvm.org/viewvc/llvm-project?rev=302431&view=rev
Log:
[clang-tidy] Fix readability-implicit-bool-cast false positives
The patch makes the check treat binary conditional operator (`x ?: y`), `while`
and regular `for` lo
Author: alexfh
Date: Tue May 9 07:41:11 2017
New Revision: 302522
URL: http://llvm.org/viewvc/llvm-project?rev=302522&view=rev
Log:
[clang-tidy] Minor cleanup + a disabled test case for PR26228. NFC
Modified:
clang-tools-extra/trunk/clang-tidy/readability/BracesAroundStatementsCheck.cpp
Author: alexfh
Date: Tue May 9 09:56:28 2017
New Revision: 302534
URL: http://llvm.org/viewvc/llvm-project?rev=302534&view=rev
Log:
Change EOL style to LF. NFC
Modified:
clang-tools-extra/trunk/clang-tidy/ClangTidyDiagnosticConsumer.cpp
clang-tools-extra/trunk/clang-tidy/misc/ForwardingR
Author: alexfh
Date: Tue May 9 10:10:26 2017
New Revision: 302536
URL: http://llvm.org/viewvc/llvm-project?rev=302536&view=rev
Log:
[clang-tidy] Allow disabling compatibility check for generated fixes.
Modified:
clang-tools-extra/trunk/clang-tidy/ClangTidyDiagnosticConsumer.cpp
clang-too
Author: alexfh
Date: Fri May 12 06:24:25 2017
New Revision: 302889
URL: http://llvm.org/viewvc/llvm-project?rev=302889&view=rev
Log:
Fix an assertion failure (PR33020).
Adding a test separately (tools/extra/test/clang-tidy/misc-use-after-move.cpp).
Modified:
cfe/trunk/lib/AST/DeclCXX.cpp
Mo
Author: alexfh
Date: Fri May 12 06:24:58 2017
New Revision: 302890
URL: http://llvm.org/viewvc/llvm-project?rev=302890&view=rev
Log:
[clang-tidy] Add a test for PR33020
Fix committed in clang as r302889.
Modified:
clang-tools-extra/trunk/test/clang-tidy/misc-use-after-move.cpp
Modified: cla
Author: alexfh
Date: Mon May 15 12:06:51 2017
New Revision: 303081
URL: http://llvm.org/viewvc/llvm-project?rev=303081&view=rev
Log:
[clang-tidy] Partly rewrite readability-simplify-boolean-expr using RAV
The check was using AST matchers in a very inefficient manner. By rewriting the
BinaryOperat
Author: alexfh
Date: Mon May 15 12:37:48 2017
New Revision: 303085
URL: http://llvm.org/viewvc/llvm-project?rev=303085&view=rev
Log:
Make google-build-using-namespace skip std::.*literals
Summary:
C++14 added a couple of user-defined literals in the standard library. E.g.
std::chrono_literals and
Author: alexfh
Date: Tue May 16 10:44:42 2017
New Revision: 303180
URL: http://llvm.org/viewvc/llvm-project?rev=303180&view=rev
Log:
[clang-tidy] Optimize matchers in readability-implicit-bool-cast. NFC
Don't repeat `isInTemplateInstantiation()` and `hasAncestor()` unnecessarily.
This speeds up t
Author: alexfh
Date: Tue May 16 11:40:46 2017
New Revision: 303187
URL: http://llvm.org/viewvc/llvm-project?rev=303187&view=rev
Log:
[clang-tidy] Optimize readability-implicit-bool-cast, NFC
Rearrange matchers to put the most expensive ones closer to the end. Speed up
another 3-5x on some files.
Author: alexfh
Date: Tue May 16 12:28:17 2017
New Revision: 303191
URL: http://llvm.org/viewvc/llvm-project?rev=303191&view=rev
Log:
[clang-tidy] Speed up performance-unnecessary-value-param check
Moved slower matchers closer to the end. The total speed up on a large file I
was interested in is n
Author: alexfh
Date: Tue May 16 21:25:11 2017
New Revision: 303230
URL: http://llvm.org/viewvc/llvm-project?rev=303230&view=rev
Log:
[clang-tidy] Optimize misc-unused-parameters. NFCI
Don't traverse AST each time we need to find references to a certain function.
Traverse the AST once using RAV an
Author: alexfh
Date: Wed May 17 07:57:06 2017
New Revision: 303256
URL: http://llvm.org/viewvc/llvm-project?rev=303256&view=rev
Log:
[clang-tidy] A bit of refactoring of modernize-replace-auto-ptr. NFC
Modified:
clang-tools-extra/trunk/clang-tidy/modernize/ReplaceAutoPtrCheck.cpp
Modified: c
Author: alexfh
Date: Wed May 17 09:39:39 2017
New Revision: 303263
URL: http://llvm.org/viewvc/llvm-project?rev=303263&view=rev
Log:
[clang-tidy] Replace matchesName with hasName where no regex is needed
Modified:
clang-tools-extra/trunk/clang-tidy/modernize/MakeSharedCheck.cpp
clang-tool
Author: alexfh
Date: Wed May 17 09:39:47 2017
New Revision: 303264
URL: http://llvm.org/viewvc/llvm-project?rev=303264&view=rev
Log:
Change getChecksFilter() interface to hide implementation details.
Modified:
clang-tools-extra/trunk/clang-tidy/ClangTidy.cpp
clang-tools-extra/trunk/clang-
Author: alexfh
Date: Wed May 17 20:13:51 2017
New Revision: 303321
URL: http://llvm.org/viewvc/llvm-project?rev=303321&view=rev
Log:
[clang-tidy] Optimize GlobList::contains
With large lists of checks and large number of warnings GlobList::contains
starts being ridiculously CPU hungry, since it r
Author: alexfh
Date: Wed May 17 22:02:15 2017
New Revision: 303325
URL: http://llvm.org/viewvc/llvm-project?rev=303325&view=rev
Log:
Fix an assertion failure in FormatASTNodeDiagnosticArgument.
Summary:
The test being added in this patch used to cause an assertion failure:
/build/./bin/clang -cc
Thanks!
On Thu, May 18, 2017 at 12:48 PM, Simon Pilgrim via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rksimon
> Date: Thu May 18 05:48:23 2017
> New Revision: 303344
>
> URL: http://llvm.org/viewvc/llvm-project?rev=303344&view=rev
> Log:
> Fix 'not all control paths return a valu
Author: alexfh
Date: Mon May 22 08:58:16 2017
New Revision: 303551
URL: http://llvm.org/viewvc/llvm-project?rev=303551&view=rev
Log:
[clang-tidy] readability-braces-around-statements false positive with char
literals
Summary:
Single-line if statements cause a false positive when the last token i
Author: alexfh
Date: Mon May 22 08:58:57 2017
New Revision: 303552
URL: http://llvm.org/viewvc/llvm-project?rev=303552&view=rev
Log:
[clang-tidy] readability-redundant-declaration false positive for defaulted
function
Summary:
```
template
struct C {
C();
};
template
C::C() = default;
```
Author: alexfh
Date: Mon May 22 09:30:14 2017
New Revision: 303554
URL: http://llvm.org/viewvc/llvm-project?rev=303554&view=rev
Log:
[clang-tidy] misc-move-const-arg shouldn't complain on std::move(lambda)
Modified:
clang-tools-extra/trunk/clang-tidy/misc/MoveConstantArgumentCheck.cpp
cla
Author: alexfh
Date: Mon Oct 17 12:25:02 2016
New Revision: 284399
URL: http://llvm.org/viewvc/llvm-project?rev=284399&view=rev
Log:
[clang-tidy] Clean up code after applying replacements.
Summary:
Remove empty namespaces and initializer list commas / colons in
affected ranges. Initial patch: pro
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284399: [clang-tidy] Clean up code after applying
replacements. (authored by alexfh).
Changed prior to commit:
https://reviews.llvm.org/D24572?vs=74160&id=74868#toc
Repository:
rL LLVM
https://revie
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
Sorry for the delay. I'm on vacation, returning on Monday.
The patch looks good when the comments are fixed.
Comment at: clang-tidy/readability/RedundantDeclarationCheck.cpp
Wait, I thought the check was mostly useful for C code, where it detects
real issues? Etienne, can you comment?
On Fri, Oct 21, 2016 at 11:50 PM, Richard Smith via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rsmith
> Date: Fri Oct 21 16:50:28 2016
> New Revision: 284888
>
> URL: ht
Author: alexfh
Date: Mon Oct 24 11:31:26 2016
New Revision: 284988
URL: http://llvm.org/viewvc/llvm-project?rev=284988&view=rev
Log:
Fix clang-format vim integration issue with non-ascii characters
clang-format.py currently seems to treat vim.current.buf as ascii-encoded data,
which leads to an U
Author: alexfh
Date: Thu Oct 27 08:46:49 2016
New Revision: 285291
URL: http://llvm.org/viewvc/llvm-project?rev=285291&view=rev
Log:
Fix warnings from python difflib.
Modified:
cfe/trunk/tools/clang-format/clang-format.py
Modified: cfe/trunk/tools/clang-format/clang-format.py
URL:
http://ll
alexfh added a comment.
A few late comments (seems to be relevant to the revision finally committed
after all fixes).
Comment at: clang-tidy/utils/NamespaceAliaser.cpp:35
+return None;
+
+
nit: Too many empty lines.
Comment at: clang-tid
alexfh requested changes to this revision.
alexfh added a reviewer: alexfh.
alexfh added a comment.
This revision now requires changes to proceed.
Kirill, if you still have time for this, could you submit reformatting as a
separate patch to make semantic changes more visible?
https://reviews.ll
Author: alexfh
Date: Thu Oct 27 10:15:23 2016
New Revision: 285301
URL: http://llvm.org/viewvc/llvm-project?rev=285301&view=rev
Log:
Attempt to make clang-format.py python 3 - compatible.
Modified:
cfe/trunk/tools/clang-format/clang-format.py
Modified: cfe/trunk/tools/clang-format/clang-form
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG modulo comments.
Comment at: clang-tidy/misc/UseAfterMoveCheck.cpp:498
+auto addDeclRefs = [this, Block,
+DeclRefs](const SmallVectorImpl &Matc
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
Sorry for the delay. Feel free to ping earlier.
One more comment, otherwise looks good.
Comment at: docs/clang-tidy/checks/modernize-use-auto.rst:163
+The check handles ``st
alexfh requested changes to this revision.
alexfh added a comment.
This revision now requires changes to proceed.
Removing from my dashboard. Ping me once you have a new patch.
Repository:
rL LLVM
https://reviews.llvm.org/D22725
___
cfe-commits m
alexfh added a comment.
"Use delete" makes me think of the `delete` operator. I'd suggest one of these
names:
- modernize-use-equals-delete
- modernize-use-deleted-special-members
- modernize-delete-special-members
(feel free to suggest a better alternative).
Comment at: cla
alexfh added inline comments.
Comment at:
clang-tools-extra/trunk/test/clang-tidy/readability-redundant-declaration.cpp:11
+extern int A, B;
+// CHECK-MESSAGES: :[[@LINE-1]]:12: warning: redundant 'A' declaration
+// CHECK-FIXES: {{^}}extern int A, B;{{$}}
Just
alexfh created this revision.
alexfh added a reviewer: zaks.anna.
alexfh added a subscriber: cfe-commits.
This provides a better interface for clang-tidy and encapsulates the knowledge
about experimental checkers instead of leaving this to the clients.
https://reviews.llvm.org/D26310
Files:
i
alexfh created this revision.
alexfh added reviewers: zaks.anna, hokein.
alexfh added a subscriber: cfe-commits.
alexfh added a dependency: D26310: Add a method to get the list of registered
static analyzer checkers..
Depends on https://reviews.llvm.org/D26310.
https://reviews.llvm.org/D26311
alexfh added a comment.
Thank you for the fix! One late comment inline.
Comment at:
clang-tools-extra/trunk/test/clang-tidy/performance-unnecessary-value-param.cpp:241
+
+// Ensure that incomplete types result in an error from the frontend and not a
+// clang-tidy diagnostic a
alexfh added a comment.
I guess, "readability" will be a better category for this check.
https://reviews.llvm.org/D21298
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
Thank you for tracking and fixing this! One nit inline.
Comment at: clang-tidy/modernize/UseNullptrCheck.cpp:194
+// Catch the castExpr inside cxxDefaultArgExpr.
+if
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
One nit. Otherwise looks good. Thank you!
Comment at: clang-tidy/rename_check.py:89
- header_guard_old = module.upper() + '_' + check_name.upper().replace('-',
'_')
- he
alexfh requested changes to this revision.
alexfh added a comment.
This revision now requires changes to proceed.
Thank you for resurrecting this patch! A few comments inline.
Comment at: include/clang/Tooling/Core/Diagnostic.h:35
+ DiagnosticMessage(llvm::StringRef Message, c
alexfh updated this revision to Diff 77098.
alexfh added a comment.
- Don't expose debug checkers.
https://reviews.llvm.org/D26310
Files:
include/clang/StaticAnalyzer/Core/AnalyzerOptions.h
lib/StaticAnalyzer/Core/AnalyzerOptions.cpp
unittests/StaticAnalyzer/AnalyzerOptionsTest.cpp
Inde
alexfh added a comment.
I think, silently choosing one of the checks may be confusing and
counter-intuitive. Should we just warn in case we see the same check enabled by
multiple aliases?
https://reviews.llvm.org/D25659
___
cfe-commits mailing lis
alexfh requested changes to this revision.
alexfh added a comment.
This revision now requires changes to proceed.
In https://reviews.llvm.org/D25659#588658, @alexfh wrote:
> I think, silently choosing one of the checks may be confusing and
> counter-intuitive. Should we just warn in case we see
alexfh added inline comments.
Comment at: clang-tidy/ClangTidy.cpp:297
+ const auto &RegisteredCheckers =
+ AnalyzerOptions::getRegisteredCheckers(IncludeExperimentalCheckers);
+ bool AnalyzerChecksEnabled = false;
hokein wrote:
> Since the default argumen
alexfh added a comment.
Benjamin, what's the plan here?
https://reviews.llvm.org/D23130
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG. Sorry for the delay.
https://reviews.llvm.org/D25911
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
alexfh added inline comments.
Comment at:
clang-tools-extra/trunk/test/clang-tidy/performance-unnecessary-value-param.cpp:241
+
+// Ensure that incomplete types result in an error from the frontend and not a
+// clang-tidy diagnostic about IncompleteType being expensive to copy.
alexfh updated this revision to Diff 77112.
alexfh added a comment.
- Address review comments.
https://reviews.llvm.org/D26311
Files:
clang-tidy/ClangTidy.cpp
clang-tidy/ClangTidy.h
Index: clang-tidy/ClangTidy.h
===
--- clang-
alexfh added inline comments.
Comment at: test/clang-tidy/nolint.cpp:36
+}
+// CHECK-NOT: trigger_warning.h:{{.*}} warning: The left operand of '>' is a
garbage value
+// CHECK-NOT: :[[@LINE-4]]:{{.*}} note
The test is too brittle: if the functionality breaks af
Author: alexfh
Date: Mon Nov 7 23:58:07 2016
New Revision: 286213
URL: http://llvm.org/viewvc/llvm-project?rev=286213&view=rev
Log:
[clang-tidy] Simplify matchers
Modified:
clang-tools-extra/trunk/clang-tidy/misc/NonCopyableObjects.cpp
Modified: clang-tools-extra/trunk/clang-tidy/misc/NonCo
Author: alexfh
Date: Tue Nov 8 01:23:32 2016
New Revision: 286218
URL: http://llvm.org/viewvc/llvm-project?rev=286218&view=rev
Log:
Add a method to get the list of registered static analyzer checkers.
Summary:
This provides a better interface for clang-tidy and encapsulates the knowledge
about e
This revision was automatically updated to reflect the committed changes.
Closed by commit rL286218: Add a method to get the list of registered static
analyzer checkers. (authored by alexfh).
Changed prior to commit:
https://reviews.llvm.org/D26310?vs=77098&id=77151#toc
Repository:
rL LLVM
This revision was automatically updated to reflect the committed changes.
Closed by commit rL286219: Use AnalyzerOptions::getRegisteredCheckers() instead
of… (authored by alexfh).
Changed prior to commit:
https://reviews.llvm.org/D26311?vs=77112&id=77154#toc
Repository:
rL LLVM
https://revi
Author: alexfh
Date: Tue Nov 8 01:43:42 2016
New Revision: 286219
URL: http://llvm.org/viewvc/llvm-project?rev=286219&view=rev
Log:
Use AnalyzerOptions::getRegisteredCheckers() instead of
clang/StaticAnalyzer/Checkers/Checkers.inc
Summary: Depends on D26310.
Reviewers: zaks.anna, hokein
Subsc
Author: alexfh
Date: Tue Nov 8 02:28:19 2016
New Revision: 286222
URL: http://llvm.org/viewvc/llvm-project?rev=286222&view=rev
Log:
[clang-tidy] clang-analyzer-alpha* checks are not registered, so there's no
need to disable them
Modified:
clang-tools-extra/trunk/clang-tidy/tool/ClangTidyMai
alexfh added a comment.
In https://reviews.llvm.org/D25659#589081, @malcolm.parsons wrote:
> In https://reviews.llvm.org/D25659#588663, @alexfh wrote:
>
> > In https://reviews.llvm.org/D25659#588658, @alexfh wrote:
> >
> > > I think, silently choosing one of the checks may be confusing and
> > >
I'd instead ask Static Analyzer folks if they can graduate this check. What
is your experience with it? Do you feel it's good enough for mainstream?
On Nov 8, 2016 2:11 AM, "Malcolm Parsons" wrote:
> On 8 November 2016 at 08:28, Alexander Kornienko via cfe-commits
&g
Author: alexfh
Date: Tue Nov 8 12:12:56 2016
New Revision: 286257
URL: http://llvm.org/viewvc/llvm-project?rev=286257&view=rev
Log:
Remove mentions of clang-analyzer-alpha
Modified:
clang-tools-extra/trunk/docs/clang-tidy/index.rst
clang-tools-extra/trunk/test/clang-tidy/static-analyzer.
alexfh added a comment.
> and generally frowned upon in many codebases (e.g. LLVM)
Should it still be a part of google/? The old check was enforcing a part of the
Google C++ style guide, but the new one seems to be somewhat broader. Am I
mistaken?
https://reviews.llvm.org/D23130
__
alexfh added a comment.
What's the biggest complexity with -header-filter? Lack of way to specify ? Will it help to make -header-filter a GlobList?
https://reviews.llvm.org/D26418
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.
alexfh added a comment.
I also don't understand the use case for turning off only some checks for
third-party headers. Either you care about third-party stuff or not, why only
switch off certain checks?
https://reviews.llvm.org/D26418
___
cfe-comm
Author: alexfh
Date: Wed Nov 9 14:03:30 2016
New Revision: 286390
URL: http://llvm.org/viewvc/llvm-project?rev=286390&view=rev
Log:
[clang-tidy docs] Recommend using add_new_check.py more
Modified:
clang-tools-extra/trunk/docs/clang-tidy/index.rst
Modified: clang-tools-extra/trunk/docs/clan
Author: alexfh
Date: Wed Nov 9 16:31:07 2016
New Revision: 286404
URL: http://llvm.org/viewvc/llvm-project?rev=286404&view=rev
Log:
[clang-tidy docs] Minor formatting changes.
Modified:
clang-tools-extra/trunk/docs/clang-tidy/index.rst
Modified: clang-tools-extra/trunk/docs/clang-tidy/index
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
Thanks! LG
https://reviews.llvm.org/D26466
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
Malcolm, does it work for you?
On Wed, Nov 9, 2016 at 10:56 AM, Devin Coughlin wrote:
> + Anna, Alexander, and Artem.
>
> > On Nov 9, 2016, at 10:50 AM, Devin Coughlin via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
> >
> >
> >> On Nov 8, 2016, at 9:44 AM, Malcolm Parsons
> wrote:
> >>
>
Author: alexfh
Date: Tue Sep 8 04:44:04 2015
New Revision: 246996
URL: http://llvm.org/viewvc/llvm-project?rev=246996&view=rev
Log:
[clang-tidy] Updated docs.
Added:
clang-tools-extra/trunk/docs/clang-tidy/checks/modernize-replace-auto-ptr.rst
clang-tools-extra/trunk/docs/clang-tidy/che
Author: alexfh
Date: Tue Sep 8 05:31:36 2015
New Revision: 247002
URL: http://llvm.org/viewvc/llvm-project?rev=247002&view=rev
Log:
[clang-tidy] Fix run-clang-tidy.py.
Do not add "-*" to the list of checks. Make consistent the list of enabled
checks and the checks in use. Moreover, removing "-*"
401 - 500 of 1886 matches
Mail list logo
