alexfh added inline comments.
================
Comment at: test/clang-tidy/nolint.cpp:36
+}
+// CHECK-NOT: trigger_warning.h:{{.*}} warning: The left operand of '>' is a
garbage value
+// CHECK-NOT: :[[@LINE-4]]:{{.*}} note
----------------
The test is too brittle: if the functionality breaks after the text of the
message changes, it will still pass.
Two ways to deal with it:
1. add a positive test to ensure this pattern actually triggers a warning
2. make the CHECK-NOT pattern broader: `// CHECK-NOT: warning:`.
https://reviews.llvm.org/D26218
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
