[PATCH] D75661: Remove SequentialType from the type heirarchy.

ftynse added a comment. LGTM for MLIR part. Comment at: mlir/lib/Target/LLVMIR/ModuleTranslation.cpp:60 + } else { emitError(loc) << "expected sequential LLVM types wrapping a scalar"; return nullptr; Nit: can we update the error message not to menti

[PATCH] D78882: [IR] Replace all uses of CallBase::getCalledValue() with getCalledOperand().

ftynse accepted this revision. ftynse added a comment. This revision is now accepted and ready to land. LGTM for MLIR Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78882/new/ https://reviews.llvm.org/D78882 __

[PATCH] D121076: [MLIR][Python] Add SCFIfOp Python binding

ftynse accepted this revision. ftynse added a comment. Thanks! Let me know if you need help landing this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121076/new/ https://reviews.llvm.org/D121076 ___ cf

[PATCH] D91556: [OpenMPIRBuilder} Add capturing of parameters to pass to omp::parallel

ftynse added a comment. Thanks! I have a couple of comments, but I will defer to @jdoerfert for approval in any case. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:676 + + /// Capture the above-defined paraneters for the parallel regions. + /// ---

[PATCH] D91410: [llvm][clang][mlir] Add checks for the return values from Target::createXXX to prevent protential null deref

ftynse added a comment. Herald added a subscriber: teijeong. LGTM for the MLIR part Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91410/new/ https://reviews.llvm.org/D91410 ___ cfe-commits mailing list c

[PATCH] D92189: [OpenMPIRBuilder] forward arguments as pointers to outlined function

ftynse updated this revision to Diff 308643. ftynse added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix clang tests. The order of arguments is switched in the internal outlined function. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D92189: [OpenMPIRBuilder] forward arguments as pointers to outlined function

ftynse added inline comments. Comment at: clang/test/OpenMP/parallel_codegen.cpp:139 // CHECK: call {{.*}}void (%struct.ident_t*, i32, void (i32*, i32*, ...)*, ...) @__kmpc_fork_call(%struct.ident_t* [[DEF_LOC_2]], i32 2, void (i32*, i32*, ...)* bitcast (void (i32*, i32*

[PATCH] D92189: [OpenMPIRBuilder] forward arguments as pointers to outlined function

ftynse planned changes to this revision. ftynse added inline comments. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:736 "Expected copy/create callback to set replacement value!"); - if (ReplacementValue == &V) -return; }

[PATCH] D92189: [OpenMPIRBuilder] forward arguments as pointers to outlined function

ftynse updated this revision to Diff 308698. ftynse added a comment. Simplify the code by adapting the PrivatizationCallback signature. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92189/new/ https://reviews.llvm.org/D92189 Files: clang/lib/Cod

[PATCH] D92189: [OpenMPIRBuilder] forward arguments as pointers to outlined function

ftynse updated this revision to Diff 308933. ftynse marked 6 inline comments as done. ftynse added a comment. Address all remaining review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92189/new/ https://reviews.llvm.org/D92189 Files:

[PATCH] D92189: [OpenMPIRBuilder] forward arguments as pointers to outlined function

ftynse updated this revision to Diff 308938. ftynse added a comment. Herald added subscribers: teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, stephenneuendorffer, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, nicolasvasilache, antiagainst, shauheen, rriddl

[PATCH] D92189: [OpenMPIRBuilder] forward arguments as pointers to outlined function

ftynse added a comment. Windows failure is unrelated, broken by an earlier commit to MLIR PDL. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92189/new/ https://reviews.llvm.org/D92189 ___ cfe-commits mai

[PATCH] D92189: [OpenMPIRBuilder] forward arguments as pointers to outlined function

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG240dd92432eb: [OpenMPIRBuilder] forward arguments as pointers to outlined function (authored by ftynse). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D107540: [OMPIRBuilder] Clarify CanonicalLoopInfo. NFC.

ftynse accepted this revision. ftynse added a comment. This revision is now accepted and ready to land. Thanks! Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:364 + /// over all chunks that are executed on the same thread. Returning + /// CanonicalLoopInfo objec

[PATCH] D136746: [mlir] Saturation arithmetic intrinsics

ftynse added inline comments. Comment at: mlir/include/mlir/Dialect/LLVMIR/LLVMIntrinsicOps.td:179 +def LLVM_SAddSat : LLVM_BinarySameArgsIntrOpI<"sadd.sat">; +def LLVM_SAddSat : LLVM_BinarySameArgsIntrOpI<"uadd.sat">; +def LLVM_SAddSat : LLVM_BinarySameArgsIntrOpI<"ssub.sat">; -

[PATCH] D136746: [mlir] Saturation arithmetic intrinsics

ftynse accepted this revision. ftynse added a comment. This revision is now accepted and ready to land. Please wait for the tests to pass before submitting. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136746/new/ https://reviews.llvm.org/D136746 __

[PATCH] D134425: [NFC] Create a AllocLikeOpInterface and make memref::AllocOp, memref::AllocaOp and gpu::AllocOp implement it.

ftynse requested changes to this revision. ftynse added a comment. This revision now requires changes to proceed. I would expect a new top-level interface (in lib/Interfaces) to go through the RFC process. I have concerns about the interface design. Specifically, it appears to be promoting deta

[PATCH] D128049: [mlir] move SCF headers to SCF/{IR,Transforms} respectively

ftynse marked an inline comment as done. ftynse added inline comments. Comment at: mlir/include/mlir/Dialect/SCF/Transforms/Transforms.h:13 -#ifndef MLIR_DIALECT_SCF_TRANSFORMS_H_ -#define MLIR_DIALECT_SCF_TRANSFORMS_H_ +#ifndef MLIR_DIALECT_SCF_TRANSFORMS_TRANSFORMS_H_ +#defin

[PATCH] D128049: [mlir] move SCF headers to SCF/{IR,Transforms} respectively

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8b68da2c7d97: [mlir] move SCF headers to SCF/{IR,Transforms} respectively (authored by ftynse). Changed prior to commit: https://reviews.llvm.org/

[PATCH] D151492: Add fastmath attributes to llvm.call_intrinsic

ftynse added inline comments. Comment at: clang/lib/CodeGen/CGHLSLRuntime.cpp:367 // that can be valid on the real entry. - // This is what I want to do AttributeList NewAttrs = AttributeList::get(Ctx, AttributeList::FunctionIndex, This cleanup should go

[PATCH] D151492: Add fastmath attributes to llvm.call_intrinsic

ftynse added inline comments. Comment at: clang/lib/CodeGen/CGHLSLRuntime.cpp:367 // that can be valid on the real entry. - // This is what I want to do AttributeList NewAttrs = AttributeList::get(Ctx, AttributeList::FunctionIndex, electriclilies wrote: >

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

ftynse added inline comments. Comment at: mlir/include/mlir/Target/LLVMIR/Dialect/Utils.h:13 + +#ifndef MLIR_DIALECT_UTILS_H +#define MLIR_DIALECT_UTILS_H This tag is wrong. It should be `MLIR_TARGET_LLVMIR_DIALECT_UTILS_H`. Comment at: mlir/in

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

ftynse added inline comments. Comment at: mlir/include/mlir/Target/LLVMIR/Dialect/Utils.h:27 +/// Create a constant string location from the MLIR Location information. +static llvm::Constant * +createSourceLocStrFromLocation(Location loc, llvm::OpenMPIRBuilder &builder, -