ftynse added inline comments.
================ Comment at: clang/lib/CodeGen/CGHLSLRuntime.cpp:367 // that can be valid on the real entry. - // This is what I want to do AttributeList NewAttrs = AttributeList::get(Ctx, AttributeList::FunctionIndex, ---------------- electriclilies wrote: > ftynse wrote: > > This cleanup should go in a separate commit. > For some reason arcanist is showing the diff between my 2 latest commits, not > between main and my branch, I added this in a previous commit then removed it > in my final clean up commit.. If you create it with `arc`, the command indicates with respect to which other commit the diff is taken, e.g. `arc diff HEAD^` is the diff between the currently checked out commit and the previous one (`HEAD^`). You can do several steps (`HEAD^^^` for three) or specify the commit hash explicitly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151492/new/ https://reviews.llvm.org/D151492 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
