[PATCH] D159126: [Clang] Add captures to the instantiation scope of lambda call operators

abrachet added a comment. I'm seeing libcxx failures after this patch. See https://ci.chromium.org/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b8770673168839783889/overview # .---command stderr # | /b/s/w/ir/x/w/llvm-llvm-project/libcxx/test/std/ranges/range.adaptors/rang

[PATCH] D75332: [clang-tidy] Add module for llvm-libc and restrict-system-libc-header-check.

abrachet added inline comments. Comment at: clang-tools-extra/clang-tidy/llvmlibc/RestrictSystemLibcHeadersCheck.cpp:40 +SrcMgr::CharacteristicKind FileType) { + if (SrcMgr::isSystem(FileType)) { +if (!SM.isInMainFile(HashLoc)) { Could you whitelist the

[PATCH] D75332: [clang-tidy] Add module for llvm-libc and restrict-system-libc-header-check.

abrachet added inline comments. Comment at: clang-tools-extra/clang-tidy/llvmlibc/RestrictSystemLibcHeadersCheck.cpp:40 +SrcMgr::CharacteristicKind FileType) { + if (SrcMgr::isSystem(FileType)) { +if (!SM.isInMainFile(HashLoc)) { PaulkaToast wrote: > aa

[PATCH] D75153: [ThinLTO] Allow usage of all SMT threads in the system

abrachet added inline comments. Comment at: llvm/include/llvm/Support/Threading.h:201 + /// hardware core is used. + inline ThreadPoolStrategy heavyweight_hardware_concurrency(StringRef Num) { +Optional S = Nit: Remove `inline` https://llvm.org/docs/Coding

[PATCH] D145725: [Driver] Make -X default for baremetal riscv

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. abrachet marked 2 inline comments as done. Closed by commit rGdf405dbfd316: [Driver] Make -X default for baremetal riscv (authored by abrachet). Herald added a project:

[PATCH] D145725: [Driver] Make -X default for baremetal riscv

abrachet added a comment. Both comments addressed in commit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145725/new/ https://reviews.llvm.org/D145725 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D151681: [CMake][Fuchsia] Enable standalone libatomic

This revision was automatically updated to reflect the committed changes. Closed by commit rG1be27bd8ce08: [CMake][Fuchsia] Enable standalone libatomic (authored by abrachet). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D147250: [CMake] Switch to -fPIE for Fuchsia Toolchain

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1fab236e6e45: [CMake] Switch to -fPIE for Fuchsia Toolchain (authored by abrachet). Herald added a project: clang. Herald added a subscriber: cfe-com

[PATCH] D151502: [clang-tidy][docs] Fix link to libc style guide

abrachet created this revision. abrachet added reviewers: mcgrathr, sivachandra. Herald added subscribers: PiotrZSL, carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. abrachet requested review of this revision. Herald added a project: clang-tools-extra. Heral

[PATCH] D151502: [clang-tidy][docs] Fix link to libc style guide

abrachet updated this revision to Diff 525814. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151502/new/ https://reviews.llvm.org/D151502 Files: clang-tools-extra/clang-tidy/llvmlibc/InlineFunctionDeclCheck.h clang-tools-extra/docs/clang-tidy/checks/llvmlibc/inline-function-decl.rst

[PATCH] D151502: [clang-tidy][docs] Fix link to libc style guide

This revision was automatically updated to reflect the committed changes. Closed by commit rG54d45ddc89f1: [clang-tidy][docs] Fix link to libc style guide (authored by abrachet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151502/new/ https://revi

[PATCH] D137799: [llvm-driver] Pass extra arguments to tools

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1f173a0653e7: [llvm-driver] Pass extra arguments to tools (authored by abrachet). Herald added a project: clang. Herald added a subscriber: cfe-commi

[PATCH] D137800: [llvm-driver] Reinvoke clang as described by llvm driver extra args

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. abrachet marked 2 inline comments as done. Closed by commit rG3e57aa304f15: [llvm-driver] Reinvoke clang as described by llvm driver extra args (authored by abrachet).

[PATCH] D141808: [Driver] Add --vfsoverlay flag

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdf5beebc98bb: [Driver] Add --vfsoverlay flag (authored by abrachet). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed

[PATCH] D144287: [Fuchsia] Enable llvm-driver build

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4eadd19cc423: [Fuchsia] Enable llvm-driver build (authored by abrachet). Herald added a project: clang. Herald added a subscriber: cfe-commits. Chan

[PATCH] D144287: [Fuchsia] Enable llvm-driver build

abrachet marked an inline comment as done. abrachet added inline comments. Comment at: clang/cmake/caches/Fuchsia-stage2.cmake:26 set(LLVM_USE_RELATIVE_PATHS_IN_FILES ON CACHE BOOL "") +set(LLVM_TOOL_LLVM_DRIVER_BUILD ON CACHE BOOL "") phosek wrote: > Nit: can

[PATCH] D150799: [Fuchsia] Correctly pass lists from STAGE2_ vars

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG30c57e275e5a: [Fuchsia] Correctly pass lists from STAGE2_ vars (authored by abrachet). Herald added a project: clang. Herald added a subscriber: cfe-

[PATCH] D148583: [clang-scan-deps] Add clang-scan-deps to llvm-driver build

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc2423a334585: [clang-scan-deps] Add clang-scan-deps to llvm-driver build (authored by abrachet). Herald added a project: clang. Herald added a subscr

[PATCH] D148869: [Driver][BareMetal] Support --emit-static-lib in BareMetal driver

abrachet accepted this revision. abrachet added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Driver/ToolChains/BareMetal.cpp:170 bool BareMetal::handlesTarget(const llvm::Triple &Triple) { return isARMBareMetal(Triple) || isAArch64Ba

[PATCH] D117611: [Sema] Warn about printf %n on Android and Fuchsia

This revision was automatically updated to reflect the committed changes. Closed by commit rGcd4e600f5f5c: [Sema] Warn about printf %n on Android and Fuchsia (authored by abrachet). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANG

[PATCH] D113718: Don't append the working directory to absolute paths

abrachet added a comment. We're seeing test failures in https://ci.chromium.org/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b8821217427732511185/overview Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113718/new/ https://reviews.llvm.org/D11

<    1   2