abrachet added a comment. I'm seeing libcxx failures after this patch. See https://ci.chromium.org/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b8770673168839783889/overview
# .---command stderr------------ # | /b/s/w/ir/x/w/llvm-llvm-project/libcxx/test/std/ranges/range.adaptors/range.all/range.owning.view/empty.pass.cpp:38:19: error: static assertion failed due to requirement '!HasEmpty<const std::ranges::owning_view<ComparableIters> &>' # | 38 | static_assert(!HasEmpty<const OwningView&>); # | | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ # | /b/s/w/ir/x/w/llvm-llvm-project/libcxx/test/std/ranges/range.adaptors/range.all/range.owning.view/empty.pass.cpp:39:19: error: static assertion failed due to requirement '!HasEmpty<const std::ranges::owning_view<ComparableIters> &&>' # | 39 | static_assert(!HasEmpty<const OwningView&&>); # | | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ # | 2 errors generated. # `----------------------------- I've verified that reverting this patch fixes those errors. Would you mind taking a look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159126/new/ https://reviews.llvm.org/D159126 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
