Author: a.sidorin
Date: Mon May 14 09:12:31 2018
New Revision: 332256
URL: http://llvm.org/viewvc/llvm-project?rev=332256&view=rev
Log:
[ASTImporter] Turn StringRefs back to std::strings to avoid use-after-free
This is a workaround for the issue in buildASTFromCodeWithArgs()
where a local buffer
Author: a.sidorin
Date: Tue May 15 04:09:07 2018
New Revision: 332338
URL: http://llvm.org/viewvc/llvm-project?rev=332338&view=rev
Log:
[ASTImporter] Extend lookup logic in class templates
During import of a class template, lookup may find a forward
declaration and structural match falsely report
Author: a.sidorin
Date: Wed Feb 14 03:18:00 2018
New Revision: 325116
URL: http://llvm.org/viewvc/llvm-project?rev=325116&view=rev
Log:
[ASTImporter] Fix lexical DC for templated decls; support
VarTemplatePartialSpecDecl
Also minor refactoring in related functions was done.
Differential Revisio
Author: a.sidorin
Date: Wed Feb 14 03:39:33 2018
New Revision: 325118
URL: http://llvm.org/viewvc/llvm-project?rev=325118&view=rev
Log:
Quick fix for 325116 buildbots: move template specialization into namespace
Modified:
cfe/trunk/lib/AST/ASTImporter.cpp
Modified: cfe/trunk/lib/AST/ASTImpo
Author: a.sidorin
Date: Sun Dec 17 06:16:17 2017
New Revision: 320942
URL: http://llvm.org/viewvc/llvm-project?rev=320942&view=rev
Log:
[ASTImporter] Support importing FunctionTemplateDecl and
CXXDependentScopeMemberExpr
* Also introduces ImportTemplateArgumentListInfo facility (A. Sidorin)
Pat
.g.
https://logs.chromium.org/v/?s=chromium%2Fbb%2Ftryserver.chromium.win%2Fwin_upload_clang%2F277%2F%2B%2Frecipes%2Fsteps%2Fpackage_clang%2F0%2Fstdout
Please let me know if you have trouble reproducing.
Thanks,
Peter
On Sun, Dec 17, 2017 at 6:16 AM, Aleksei Sidorin via cfe-commits
mailto:cfe-commits@list
Author: a.sidorin
Date: Thu Dec 21 09:41:06 2017
New Revision: 321285
URL: http://llvm.org/viewvc/llvm-project?rev=321285&view=rev
Log:
[ASTImporterTest] Add mandatory testing with '-fdelayed-template-parsing'
* While running ASTImporterTests, we often forget about Windows MSVC
buildbots whic
Author: a.sidorin
Date: Wed Dec 27 09:04:42 2017
New Revision: 321492
URL: http://llvm.org/viewvc/llvm-project?rev=321492&view=rev
Log:
[ASTImporter] Support importing FunctionTemplateDecl and
CXXDependentScopeMemberExpr
* Also introduces ImportTemplateArgumentListInfo facility (A. Sidorin)
Thi
ng%2F0%2Fstdout
Please let me know if you have trouble reproducing.
Thanks,
Peter
On Sun, Dec 17, 2017 at 6:16 AM, Aleksei Sidorin via cfe-commits
mailto:cfe-commits@lists.llvm.org>> wrote:
Author: a.sidorin
Date: Sun Dec 17 06:16:17 2017
New Revision: 320942
URL: http:/
Author: a.sidorin
Date: Tue Jan 9 06:25:05 2018
New Revision: 322079
URL: http://llvm.org/viewvc/llvm-project?rev=322079&view=rev
Log:
[ASTImporter] Fix missing SourceLoc import for ObjCMethodDecl selectors
Patch by Nico Rieck, test case by Sean Callanan!
Differential Revision: https://reviews.
Author: a.sidorin
Date: Tue Jan 9 08:40:40 2018
New Revision: 322091
URL: http://llvm.org/viewvc/llvm-project?rev=322091&view=rev
Log:
[ASTImporter] Support importing CXXUnresolvedConstructExpr and
UnresolvedLookupExpr
* Note: This solution is based on
https://github.com/haoNoQ/clang/blob/su
Author: a.sidorin
Date: Sat Oct 20 07:47:37 2018
New Revision: 344847
URL: http://llvm.org/viewvc/llvm-project?rev=344847&view=rev
Log:
[NFC][Test commit] Fix typos in a comment
Modified:
cfe/trunk/lib/StaticAnalyzer/Core/CheckerManager.cpp
Modified: cfe/trunk/lib/StaticAnalyzer/Core/Checke
Author: a.sidorin
Date: Sat Oct 20 15:49:23 2018
New Revision: 344864
URL: http://llvm.org/viewvc/llvm-project?rev=344864&view=rev
Log:
[AST, analyzer] Transform rvalue cast outputs to lvalues
(fheinous-gnu-extensions)
Despite the fact that cast expressions return rvalues, GCC still
handles such
Author: a.sidorin
Date: Mon Oct 29 14:46:18 2018
New Revision: 345545
URL: http://llvm.org/viewvc/llvm-project?rev=345545&view=rev
Log:
[ASTImporter] Reorder fields after structure import is finished
There are multiple reasons why field structures can be imported
in wrong order. The simplest is t
Author: a.sidorin
Date: Mon Apr 23 08:41:44 2018
New Revision: 330605
URL: http://llvm.org/viewvc/llvm-project?rev=330605&view=rev
Log:
[analyzer] Don't crash on printing ConcreteInt of size >64 bits
Printing of ConcreteInts with size >64 bits resulted in assertion failure
in get[Z|S]ExtValue() b
Author: a.sidorin
Date: Mon Apr 23 09:38:29 2018
New Revision: 330613
URL: http://llvm.org/viewvc/llvm-project?rev=330613&view=rev
Log:
Quick fix for rC330605: specify a target arch for test
Modified:
cfe/trunk/test/Analysis/sval-dump-int128.c
Modified: cfe/trunk/test/Analysis/sval-dump-int
Author: a.sidorin
Date: Tue Apr 24 03:11:53 2018
New Revision: 330704
URL: http://llvm.org/viewvc/llvm-project?rev=330704&view=rev
Log:
[ASTImporter] Allow testing of import sequences; fix import of typedefs for
anonymous decls
This patch introduces the ability to test an arbitrary sequence of i
Author: a.sidorin
Date: Tue May 8 05:45:21 2018
New Revision: 331762
URL: http://llvm.org/viewvc/llvm-project?rev=331762&view=rev
Log:
[ASTImporter] Properly import SourceLocations of Attrs
Patch by Rafael Stahl!
Differential Revision: https://reviews.llvm.org/D46115
Added:
cfe/trunk/test
a.sidorin created this revision.
a.sidorin added reviewers: aaron.ballman, doug.gregor.
a.sidorin added a subscriber: cfe-commits.
I have encountered a segfault when I tried to get sub-expression of serialized
ArrayTypeTraitExpr. The fix is simple but I have no idea about nice test. Maybe
you ha
a.sidorin added a comment.
Don't hurry. The segfault is fixed already and patch waits for approval:
https://reviews.llvm.org/D24807. I'll update this fix in Monday.
https://reviews.llvm.org/D14326
___
cfe-commits mailing list
cfe-commits@lists.llvm
a.sidorin updated the summary for this revision.
a.sidorin added reviewers: ABataev, aaron.ballman.
a.sidorin updated this revision to Diff 72614.
a.sidorin added a comment.
Merge patch https://reviews.llvm.org/D24807 to both fix segmentation fault and
provide a test for it.
https://reviews.llv
a.sidorin updated this revision to Diff 72625.
a.sidorin added a comment.
Address review comments; add accidentally missed file.
https://reviews.llvm.org/D14326
Files:
include/clang/AST/ASTImporter.h
include/clang/AST/DeclFriend.h
lib/AST/ASTImporter.cpp
lib/Serialization/ASTReaderStmt.
Author: a.sidorin
Date: Wed Sep 28 05:16:56 2016
New Revision: 282572
URL: http://llvm.org/viewvc/llvm-project?rev=282572&view=rev
Log:
[ASTImporter] Implement some expression-related AST node import (part 2)
* Some code cleanup
* Add tests not present in http://reviews.llvm.org/D14286
* Integrat
This revision was automatically updated to reflect the committed changes.
Closed by commit rL282572: [ASTImporter] Implement some expression-related AST
node import (part 2) (authored by a.sidorin).
Changed prior to commit:
https://reviews.llvm.org/D14326?vs=72625&id=72791#toc
Repository:
rL
a.sidorin added a comment.
Committed after Aaron's comment were addressed. Big thanks to all reviewers!
Repository:
rL LLVM
https://reviews.llvm.org/D14326
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mail
Author: a.sidorin
Date: Wed Sep 28 05:57:36 2016
New Revision: 282576
URL: http://llvm.org/viewvc/llvm-project?rev=282576&view=rev
Log:
ASTMerge: specify arch for GCCAsmStmt test explicitly to calm non-x86 buildbots
Modified:
cfe/trunk/test/ASTMerge/Inputs/exprs3.cpp
Modified: cfe/trunk/tes
Author: a.sidorin
Date: Wed Sep 28 06:04:42 2016
New Revision: 282578
URL: http://llvm.org/viewvc/llvm-project?rev=282578&view=rev
Log:
ASTMerge: explicitly specify arch for GCCAsmStmt test to calm non-x86 buildbots
This should fix r282572.
Added:
cfe/trunk/test/ASTMerge/Inputs/asm-function.
a.sidorin abandoned this revision.
a.sidorin added a comment.
Merged into https://reviews.llvm.org/D14326 and committed.
https://reviews.llvm.org/D24807
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
a.sidorin added inline comments.
Comment at: test/Analysis/unreachable-code-path.c:201
+static int inlineFunction(const int i) {
+ if (table[i] != 0)
+return 1;
I have a small question. Is it possible to simplify this sample with removing
of table[] array?
a.sidorin accepted this revision.
a.sidorin added a comment.
This patch reduces both the analysis time and the line count. I like it! :)
Did you test Artem's approach?
Repository:
rL LLVM
https://reviews.llvm.org/D25503
___
cfe-commits mailing li
Author: a.sidorin
Date: Sun Nov 26 09:04:06 2017
New Revision: 318998
URL: http://llvm.org/viewvc/llvm-project?rev=318998&view=rev
Log:
[ASTImporter] Support TypeTraitExpr
Patch by Takafumi Kubota!
Differential Revision: https://reviews.llvm.org/D39722
Modified:
cfe/trunk/lib/AST/ASTImport
Author: a.sidorin
Date: Mon Nov 27 02:30:00 2017
New Revision: 319015
URL: http://llvm.org/viewvc/llvm-project?rev=319015&view=rev
Log:
[ASTImporter] Support importing CXXPseudoDestructorExpr
Patch by Peter Szecsi!
Differential Revision: https://reviews.llvm.org/D38843
Modified:
cfe/trunk/
Author: a.sidorin
Date: Sun Dec 3 08:04:07 2017
New Revision: 319632
URL: http://llvm.org/viewvc/llvm-project?rev=319632&view=rev
Log:
[ASTImporter] Add unit tests for UsingDecl and UsingShadowDecl
Patch by Kareem Khazem!
Differential Revision: https://reviews.llvm.org/D27181
Modified:
cf
Author: a.sidorin
Date: Thu Apr 5 08:31:49 2018
New Revision: 329301
URL: http://llvm.org/viewvc/llvm-project?rev=329301&view=rev
Log:
[ASTImporter] Fix for importing unnamed structs
Patch by Peter Szecsi!
Differential Revision: https://reviews.llvm.org/D30876
Modified:
cfe/trunk/lib/AST/
Author: a.sidorin
Date: Tue Nov 21 03:05:28 2017
New Revision: 318750
URL: http://llvm.org/viewvc/llvm-project?rev=318750&view=rev
Log:
[Analyzer] Non-determinism: stable iteration on indirect goto LabelDecl's
CFG wass built in non-deterministic order due to the fact that indirect
goto labels' de
Author: a.sidorin
Date: Tue Nov 21 03:20:07 2017
New Revision: 318753
URL: http://llvm.org/viewvc/llvm-project?rev=318753&view=rev
Log:
[Analyzer] Revert r318750 because incorrect files were added for commit.
Sorry for the noise.
Removed:
cfe/trunk/test/Analysis/cfg-indirect-goto-determinis
Author: a.sidorin
Date: Tue Nov 21 03:27:47 2017
New Revision: 318754
URL: http://llvm.org/viewvc/llvm-project?rev=318754&view=rev
Log:
[Analyzer] Stable iteration on indirect goto LabelDecl's to avoid
non-determinism (attempt 2)
CFG wass built in non-deterministic order due to the fact that ind
Author: a.sidorin
Date: Tue Nov 21 08:08:41 2017
New Revision: 318776
URL: http://llvm.org/viewvc/llvm-project?rev=318776&view=rev
Log:
[ASTImporter] Support new AST nodes:
* UnresolvedUsingType
* EmptyDecl
* NamespaceAliasDecl
* UsingDecl
* UsingShadowDecl
* UsingDirectiveDecl
* Unresolve
a.sidorin added a comment.
Serge, Sean, is this patch OK to commit?
https://reviews.llvm.org/D14326
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
a.sidorin updated this revision to Diff 68987.
a.sidorin added a comment.
Add plist output; give test files meaningful names.
https://reviews.llvm.org/D22090
Files:
lib/StaticAnalyzer/Core/PlistDiagnostics.cpp
test/Analysis/diagnostics/Inputs/include/plist-diagnostics-include-check-macro.d
Author: a.sidorin
Date: Thu Sep 1 06:11:46 2016
New Revision: 280352
URL: http://llvm.org/viewvc/llvm-project?rev=280352&view=rev
Log:
[analyzer][test commit] ExprEngine.cpp: Remove training whitespace; NFC
Modified:
cfe/trunk/lib/StaticAnalyzer/Core/ExprEngineCXX.cpp
Modified: cfe/trunk/li
Author: a.sidorin
Date: Thu Sep 1 07:25:16 2016
New Revision: 280360
URL: http://llvm.org/viewvc/llvm-project?rev=280360&view=rev
Log:
[analyzer] Add more FileIDs to PlistDiagnostic map to avoid assertion
Some FileIDs that may be used by PlistDiagnostics were not added while building
a list of p
This revision was automatically updated to reflect the committed changes.
Closed by commit rL280360: [analyzer] Add more FileIDs to PlistDiagnostic map
to avoid assertion (authored by a.sidorin).
Changed prior to commit:
https://reviews.llvm.org/D22090?vs=68987&id=69993#toc
Repository:
rL LL
Author: a.sidorin
Date: Thu Sep 1 08:55:38 2016
New Revision: 280367
URL: http://llvm.org/viewvc/llvm-project?rev=280367&view=rev
Log:
[analyzer] ExprEngine: remove second call to PreStmt
This patch also introduces AnalysisOrderChecker which is intended for testing
of callback call correctness.
a.sidorin added a comment.
This definitely seems to be useful. However, this patch is pretty big. Some of
its parts are not directly related with the feature being introduced (for
example, changes for copypaste/sub-sequences.cpp). Is it possible to split this
patch? Moreover, as I understand, y
Author: a.sidorin
Date: Mon Jan 23 03:30:36 2017
New Revision: 292776
URL: http://llvm.org/viewvc/llvm-project?rev=292776&view=rev
Log:
ASTImporter: improve support for C++ templates
* Support template partial specialization
* Avoid infinite recursion in IsStructurallyEquivalent for TemplateArg
Author: a.sidorin
Date: Mon Jan 23 03:45:29 2017
New Revision: 292778
URL: http://llvm.org/viewvc/llvm-project?rev=292778&view=rev
Log:
ASTImporter: add forgotten tests for rL292776
Added:
cfe/trunk/test/ASTMerge/class-template-partial-spec/
cfe/trunk/test/ASTMerge/class-template-partial
Author: a.sidorin
Date: Mon Jan 23 04:16:30 2017
New Revision: 292779
URL: http://llvm.org/viewvc/llvm-project?rev=292779&view=rev
Log:
ASTImporter: quick test fix
Differential Revision: https://reviews.llvm.org/D26753
Modified:
cfe/trunk/test/ASTMerge/class-template-partial-spec/test.cpp
M
Author: a.sidorin
Date: Mon Jan 23 04:39:45 2017
New Revision: 292781
URL: http://llvm.org/viewvc/llvm-project?rev=292781&view=rev
Log:
ASTImporter: fix tests on Windows with removing slashed parts of paths
Differential Revision: https://reviews.llvm.org/D26753
Modified:
cfe/trunk/test/ASTMe
Author: a.sidorin
Date: Fri Jan 26 03:36:54 2018
New Revision: 323519
URL: http://llvm.org/viewvc/llvm-project?rev=323519&view=rev
Log:
[ASTImporter] Support LambdaExprs and improve template support
Also, a number of style and bug fixes was done:
* ASTImporterTest: added sanity check for sourc
Author: a.sidorin
Date: Mon Feb 20 03:16:48 2017
New Revision: 295644
URL: http://llvm.org/viewvc/llvm-project?rev=295644&view=rev
Log:
[analyzer] Do not duplicate call graph nodes for functions that have definition
and forward declaration
Patch by Ivan Sidorenko!
Differential Revision: https:/
Author: a.sidorin
Date: Mon Feb 20 05:57:12 2017
New Revision: 295654
URL: http://llvm.org/viewvc/llvm-project?rev=295654&view=rev
Log:
[ASTImporter] Support default argument initialization of ParmVarDecls
Patch by Peter Szecsi!
Differential Revision: https://reviews.llvm.org/D29612
Modified:
Author: a.sidorin
Date: Fri Mar 3 10:58:53 2017
New Revision: 296884
URL: http://llvm.org/viewvc/llvm-project?rev=296884&view=rev
Log:
[Analyzer] Terminate analysis on OpenMP code instead of assertion crash
* ExprEngine assumes that OpenMP statements should never appear in CFG.
However, curren
a.sidorin added a comment.
@spyffe : It seems to be OK.
Repository:
rL LLVM
https://reviews.llvm.org/D26571
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
a.sidorin created this revision.
a.sidorin added reviewers: spyffe, khazem.
a.sidorin added a subscriber: cfe-commits.
- Support template partial specialization
- Avoid infinite recursion in IsStructurallyEquivalent for TemplateArgument
with implementing IsStructurallyEquivalent for TemplateName
a.sidorin updated this revision to Diff 78382.
a.sidorin added a comment.
Address review comments; fix tests.
https://reviews.llvm.org/D26753
Files:
include/clang/AST/TemplateBase.h
lib/AST/ASTImporter.cpp
test/ASTMerge/class-template-partial-spec/Inputs/class-template-partial-spec1.cpp
a.sidorin added a comment.
Thank you! I'll update this review again when I have a test for
NestedNameSpecifierLocs.
Comment at: lib/AST/ASTImporter.cpp:458
+ }
+ return true;
+}
spyffe wrote:
> Is this really an appropriate default result? I would argue for
a.sidorin added a comment.
Personally, I like this change because it makes our assumptions clearer. My
comments are below.
Comment at:
include/clang/StaticAnalyzer/Core/PathSensitive/BasicValueFactory.h:54
+ : store(st), region(r) {
+assert(r->getValueType()->isRecor
a.sidorin added a comment.
Hi Artem!
I like this change mostly but I also have some remarks.
Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h:1279
/// associated element type, index, and super region.
const ElementRegion *getElementRegion(QualType
a.sidorin requested changes to this revision.
a.sidorin added a subscriber: aaron.ballman.
a.sidorin added a comment.
This revision now requires changes to proceed.
Hello Kareem,
Thank you for working on it! You can find my comments below.
Comment at: include/clang/ASTMatchers/
a.sidorin requested changes to this revision.
a.sidorin added a reviewer: a.sidorin.
a.sidorin added a comment.
This revision now requires changes to proceed.
Hi Kareem! I'll be happy to see this changes in upstream. Please see my
comments inline.
Comment at: lib/AST/ASTImport
a.sidorin updated this revision to Diff 79054.
a.sidorin added a comment.
Add a simple test for import of complex `NestedNameSpecifierLoc`s.
https://reviews.llvm.org/D26753
Files:
include/clang/AST/TemplateBase.h
lib/AST/ASTImporter.cpp
test/ASTMerge/class-template-partial-spec/Inputs/cl
a.sidorin added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/IteratorPastEndChecker.cpp:209
+ CheckerContext &C) const {
+ const auto *Func = Call.getDecl()->getAsFunction();
+ if (Func->isOverloadedOperator()) {
---
a.sidorin added a comment.
Thank you for this patch! I like some solutions used in it but I also have some
comments (inline).
https://reviews.llvm.org/D25660
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mail
a.sidorin accepted this revision.
a.sidorin added a comment.
This revision is now accepted and ready to land.
Looks good. But I think it will be good to put the files in Input to a separate
directory.
https://reviews.llvm.org/D26054
___
cfe-commits
a.sidorin added a comment.
Hm. A pretty nice example. But we should check if the initial patch supports
`goto`s; afair, it doesn't.
https://reviews.llvm.org/D19979
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bi
a.sidorin added a comment.
Hi Sean!
I meant that I'd like to have a layout like this:
macro-loc.m
Inputs/macro-loc/macro.modulemap
Inputs/macro-loc/macro1.h
Inputs/macro-loc/macro1.m
Inputs/macro-loc/macro2.m
By the way, I see that we use another workaround for this issue: we use
`getDecomposedE
a.sidorin added a comment.
> Do you think it would be reasonable to take this diff the way it currently it
> is, and start a new one that pulls all the input fiels into test-specific
> subdirectories?
> That way the desired layout of the `Inputs` directory will be clear to
> future developers
a.sidorin added a comment.
Wow, thank you for such a contribution! Did you evaluate this checker on some
real code?
I have some minor inline comments below.
Comment at: lib/StaticAnalyzer/Checkers/CMakeLists.txt:41
IdenticalExprChecker.cpp
+RecursionChecker.cpp
a.sidorin accepted this revision.
a.sidorin added a comment.
This revision is now accepted and ready to land.
Looks good, thank you!
Repository:
rL LLVM
https://reviews.llvm.org/D26571
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:
a.sidorin added a comment.
Hi Krzysztof!
This change seems useful: I can imagine the situation where we want to ask
current `LocationContext` in this callback. The change looks pretty intrusive
but I mostly agree with it. Initially, I have some questions about the
implementation of `getArgSVal
a.sidorin abandoned this revision.
a.sidorin added a comment.
Abandon this change since the patch based on this is committed in
http://reviews.llvm.org/D7905
http://reviews.llvm.org/D3967
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http
a.sidorin added a comment.
Thank you for reply, Jordan.
> I guess the regular pings didn't work, so it was worth trying the gentle one?
> Sorry!
And it worked :)
I'll fix the issues you pointed.
http://reviews.llvm.org/D5102
___
cfe-commits mai
a.sidorin added inline comments.
Comment at: lib/StaticAnalyzer/Core/SimpleConstraintManager.cpp:215-220
@@ +214,8 @@
+ return assumeSymWithinInclusiveRange(State, Sym, From, To, InRange);
+return State;
+ } // end switch
+
+ case nonloc::ConcreteIntKind: {
+const l
a.sidorin updated this revision to Diff 32293.
a.sidorin added a comment.
- Fix review notes
- Add some more tests
- Add a fix and a test for incorrect pruning of trivially unreachable case
statements in CFG for SwitchStmt (accidentially found while writing a test).
http://reviews.llvm.org/D510
a.sidorin updated this revision to Diff 32664.
a.sidorin marked an inline comment as done.
a.sidorin added a comment.
Remove duplicating assertion.
http://reviews.llvm.org/D5102
Files:
include/clang/StaticAnalyzer/Core/PathSensitive/ConstraintManager.h
include/clang/StaticAnalyzer/Core/Path
a.sidorin marked 8 inline comments as done.
a.sidorin added a comment.
http://reviews.llvm.org/D5102
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
a.sidorin added a comment.
I put some suggestions in inline comments.
Comment at: lib/StaticAnalyzer/Checkers/VforkChecker.cpp:47
@@ +46,3 @@
+
+ bool isChildProcess(const ProgramStateRef State) const;
+
I think it's a good idea to make some functions static an
a.sidorin added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/VforkChecker.cpp:47
@@ +46,3 @@
+
+ bool isChildProcess(const ProgramStateRef State) const;
+
ygribov wrote:
> a.sidorin wrote:
> > I think it's a good idea to make some functions static and
a.sidorin created this revision.
a.sidorin added a reviewer: sepavloff.
a.sidorin added a subscriber: cfe-commits.
a.sidorin set the repository for this revision to rL LLVM.
This patch implements some expression-related AST node import. This is the
first patch in a series.
Supported nodes:
GCCAs
a.sidorin created this revision.
a.sidorin added a reviewer: sepavloff.
a.sidorin added a subscriber: cfe-commits.
a.sidorin set the repository for this revision to rL LLVM.
This patch implements some expression-related AST node import (patch #2).
Supported nodes:
ArrayTypeTraitExpr
ExpressionTra
a.sidorin updated this revision to Diff 39198.
a.sidorin added a comment.
Thank you for you reply!
This version contains more radical solution. Also, I took an another look at
the CStringChecker and its way of handling checkDeadSymbols.
Repository:
rL LLVM
http://reviews.llvm.org/D14277
Fi
a.sidorin added inline comments.
Comment at: lib/StaticAnalyzer/Core/SymbolManager.cpp:457
@@ -461,6 +456,3 @@
case SymExpr::MetadataKind:
-KnownLive = MetadataInUse.count(sym) &&
-isLiveRegion(cast(sym)->getRegion());
-if (KnownLive)
- MetadataInUs
a.sidorin marked 7 inline comments as done.
a.sidorin added a comment.
Thank you for your comments. I leaved some replies and will update revision.
Something about lacking tests.
1. We cannot check if expression import is correct until we implement
FunctionDecl body import. I was going to upstre
a.sidorin updated this revision to Diff 39517.
a.sidorin marked an inline comment as done.
a.sidorin added a comment.
Some issues pointed on review were fixed.
Repository:
rL LLVM
http://reviews.llvm.org/D14286
Files:
lib/AST/ASTImporter.cpp
Index: lib/AST/ASTImporter.cpp
a.sidorin added a comment.
Gentle ping.
http://reviews.llvm.org/D5102
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
a.sidorin added a comment.
Adam,
It is not a debug checker. It is UndefinedAssignment checker which correctly
tells us that `Inner.y` is assigned with an uninitialized value while copying.
So I wonder if we are allowed to skip such warnings because these warnings
don't look like false positive
a.sidorin updated this revision to Diff 64663.
a.sidorin added a comment.
An attempt to fix unit test on Windows.
Serge, thank you! Could you please check this patch again?
https://reviews.llvm.org/D14326
Files:
include/clang/AST/ASTImporter.h
include/clang/AST/DeclFriend.h
lib/AST/ASTImp
a.sidorin updated this revision to Diff 64676.
a.sidorin added a comment.
Removed unneeded matcher.
https://reviews.llvm.org/D14326
Files:
include/clang/AST/ASTImporter.h
include/clang/AST/DeclFriend.h
lib/AST/ASTImporter.cpp
test/ASTMerge/Inputs/class3.cpp
test/ASTMerge/Inputs/exprs3
a.sidorin updated this revision to Diff 64704.
a.sidorin added a comment.
Fix signed/unsigned mismatch warning in the loop condition.
https://reviews.llvm.org/D14326
Files:
include/clang/AST/ASTImporter.h
include/clang/AST/DeclFriend.h
lib/AST/ASTImporter.cpp
test/ASTMerge/Inputs/class3
a.sidorin added inline comments.
Comment at: lib/Rewrite/HTMLRewrite.cpp:304
@@ -303,2 +303,3 @@
+ " border-radius:5px; box-shadow:1px 1px 7px #000; "
" -webkit-border-radius:5px; -webkit-box-shadow:1px 1px 7px #000; "
"position: absolute; top: -
a.sidorin created this revision.
a.sidorin added reviewers: xazax.hun, zaks.anna, dcoughlin.
a.sidorin added a subscriber: cfe-commits.
-analyzer-display progress option prints only function names which may be
suspicious. This patch forces AnalysisConsumer to print fully-qualified
function names
a.sidorin added a subscriber: a.sidorin.
a.sidorin added a comment.
Thanks ariccio! Some inline comments are below.
Comment at:
llvm/tools/clang/include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h:1186
@@ +1185,3 @@
+ /// associated with a specified globally stored, n
a.sidorin added inline comments.
Comment at:
llvm/tools/clang/include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h:1186
@@ +1185,3 @@
+ /// associated with a specified globally stored, non-static local, VarDecl.
+ const MemRegion *getMemRegionGloballyStored(const VarDec
a.sidorin added inline comments.
Comment at: llvm/tools/clang/lib/StaticAnalyzer/Core/MemRegion.cpp:800
@@ -803,1 +799,3 @@
+ if (V.is())
+return V.get();
Oops.
Lines above should stay in the caller function or be refactored. Otherwise,
we'll get the subre
a.sidorin added inline comments.
Comment at: llvm/tools/clang/lib/StaticAnalyzer/Core/MemRegion.cpp:792
@@ +791,3 @@
+
+const MemRegion* MemRegionManager::getMemSpaceForLocalVariable(const VarDecl
*D, llvm::PointerUnion &V) {
+ const StackFrameContext *STC = V.get();
---
a.sidorin added a comment.
Hello Alexander,
Yes, types in `static_cast` should be changed. So, you need only to change
return type and types in static_cast, and it should work.
http://reviews.llvm.org/D16873
___
cfe-commits mailing list
cfe-commit
a.sidorin created this revision.
a.sidorin added reviewers: klimek, aaron.ballman.
a.sidorin added a subscriber: cfe-commits.
a.sidorin set the repository for this revision to rL LLVM.
Using re.sub() to replace a sample with '%'s looks strange and causes a format
string error if a matcher descrip
a.sidorin created this revision.
a.sidorin added a reviewer: aaron.ballman.
a.sidorin added a subscriber: cfe-commits.
a.sidorin set the repository for this revision to rL LLVM.
Herald added a subscriber: klimek.
Added matchers:
addrLabelExpr
atomicExpr
binaryConditionalOperator
designatedInitExpr
a.sidorin updated the summary for this revision.
a.sidorin set the repository for this revision to rL LLVM.
a.sidorin updated this revision to Diff 48487.
a.sidorin added a comment.
Herald added a subscriber: aemerson.
Add AST matcher-based unit tests; add some additional nodes to pass the tests.
1 - 100 of 154 matches
Mail list logo
