Re: [PATCH] D14277: [Analyzer] Make referenced SymbolMetadata live even if its region is dead

[Aleksei Sidorin via cfe-commits]

a.sidorin added inline comments.

================
Comment at: lib/StaticAnalyzer/Core/SymbolManager.cpp:457
@@ -461,6 +456,3 @@
   case SymExpr::MetadataKind:
-    KnownLive = MetadataInUse.count(sym) &&
-                isLiveRegion(cast<SymbolMetadata>(sym)->getRegion());
-    if (KnownLive)
-      MetadataInUse.erase(sym);
+    KnownLive = isLiveRegion(cast<SymbolMetadata>(sym)->getRegion());
     break;
----------------
Maybe we should just return false here?


Repository:
  rL LLVM

http://reviews.llvm.org/D14277



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits