Re: r346041 - Diagnose parameter names that shadow the names of inherited fields under -Wshadow-field.

On Tue, Dec 4, 2018 at 7:56 PM George Karpenkov wrote: > > > > > On Dec 4, 2018, at 4:48 PM, Aaron Ballman wrote: > > > > On Tue, Dec 4, 2018 at 7:17 PM George Karpenkov > > wrote: > >> > >> Hi Aaron, > >> > >> Should such

r348399 - Adding tests for -ast-dump; NFC.

Author: aaronballman Date: Wed Dec 5 10:53:57 2018 New Revision: 348399 URL: http://llvm.org/viewvc/llvm-project?rev=348399&view=rev Log: Adding tests for -ast-dump; NFC. This adds tests for various function and class template declarations. Added: cfe/trunk/test/AST/ast-dump-template-decls.

r348400 - Do not check for parameters shadowing fields in function declarations.

Author: aaronballman Date: Wed Dec 5 10:56:57 2018 New Revision: 348400 URL: http://llvm.org/viewvc/llvm-project?rev=348400&view=rev Log: Do not check for parameters shadowing fields in function declarations. We would issue a false-positive diagnostic for parameters in function declarations sha

Re: [cfe-dev] r347339 - [clang][Parse] Diagnose useless null statements / empty init-statements

>>> braces is sort of an implementation detail. >>> >>> Greg Parker has pointed out it’s possible to rewrite the macros using the >>> “do { … } while (0)”, >>> but that is a lot of macros to change, and the resulting code would be >>> arguab

Re: r348408 - Add dump tests for inherited default template parameters

On Wed, Dec 5, 2018 at 3:24 PM Stephen Kelly via cfe-commits wrote: > > Author: steveire > Date: Wed Dec 5 12:21:13 2018 > New Revision: 348408 > > URL: http://llvm.org/viewvc/llvm-project?rev=348408&view=rev > Log: > Add dump tests for inherited default template parameters > > Modified: > cf

Re: r348408 - Add dump tests for inherited default template parameters

On Wed, Dec 5, 2018 at 4:01 PM Stephen Kelly wrote: > > Surely all of the tests specifically about template decls should be moved? If you want to move all of them, feel free. ~Aaron > > On 05/12/2018 20:31, Aaron Ballman wrote: > > On Wed, Dec 5, 2018 at 3:24 PM Stephen Kel

Re: r348469 - Make test resistant to line numbers changing

On Thu, Dec 6, 2018 at 4:25 AM Stephen Kelly via cfe-commits wrote: > > Author: steveire > Date: Thu Dec 6 01:22:12 2018 > New Revision: 348469 > > URL: http://llvm.org/viewvc/llvm-project?rev=348469&view=rev > Log: > Make test resistant to line numbers changing I would prefer to see the line nu

Re: r348471 - Add test for ObjC generics

On Thu, Dec 6, 2018 at 4:26 AM Stephen Kelly via cfe-commits wrote: > > Author: steveire > Date: Thu Dec 6 01:23:59 2018 > New Revision: 348471 > > URL: http://llvm.org/viewvc/llvm-project?rev=348471&view=rev > Log: > Add test for ObjC generics > > Modified: > cfe/trunk/test/AST/ast-dump-decl

r348588 - Adding tests for -ast-dump; NFC.

Author: aaronballman Date: Fri Dec 7 04:35:15 2018 New Revision: 348588 URL: http://llvm.org/viewvc/llvm-project?rev=348588&view=rev Log: Adding tests for -ast-dump; NFC. This adds tests for various statements in C. Modified: cfe/trunk/test/AST/ast-dump-stmt.c Modified: cfe/trunk/test/AST/

Re: r348469 - Make test resistant to line numbers changing

On Thu, Dec 6, 2018 at 5:55 PM Stephen Kelly wrote: > > > On 06/12/2018 12:45, Aaron Ballman wrote: > > On Thu, Dec 6, 2018 at 4:25 AM Stephen Kelly via cfe-commits > > wrote: > >> Author: steveire > >> Date: Thu Dec 6 01:22:12 2018 > >> New

Re: r348471 - Add test for ObjC generics

On Thu, Dec 6, 2018 at 6:29 PM Stephen Kelly wrote: > > > On 06/12/2018 12:48, Aaron Ballman wrote: > > On Thu, Dec 6, 2018 at 4:26 AM Stephen Kelly via cfe-commits > > wrote: > >> Author: steveire > >> Date: Thu Dec 6 01:23:59 2018 > >> New

r348596 - Adding tests for -ast-dump; NFC.

Author: aaronballman Date: Fri Dec 7 06:57:07 2018 New Revision: 348596 URL: http://llvm.org/viewvc/llvm-project?rev=348596&view=rev Log: Adding tests for -ast-dump; NFC. This adds tests for various statements in C++ that are not covered by C. Modified: cfe/trunk/test/AST/ast-dump-stmt.cpp

r348599 - Add an explicit triple to this test to prevent failures due to size_t differences.

Author: aaronballman Date: Fri Dec 7 07:13:51 2018 New Revision: 348599 URL: http://llvm.org/viewvc/llvm-project?rev=348599&view=rev Log: Add an explicit triple to this test to prevent failures due to size_t differences. Modified: cfe/trunk/test/AST/ast-dump-stmt.cpp Modified: cfe/trunk/te

r348613 - Adding an AST dump test for statement expressions; NFC.

Author: aaronballman Date: Fri Dec 7 09:06:40 2018 New Revision: 348613 URL: http://llvm.org/viewvc/llvm-project?rev=348613&view=rev Log: Adding an AST dump test for statement expressions; NFC. Modified: cfe/trunk/test/AST/ast-dump-stmt.c Modified: cfe/trunk/test/AST/ast-dump-stmt.c URL: h

Re: r348713 - Fix InitListExpr test

On Sun, Dec 9, 2018 at 8:16 AM Stephen Kelly via cfe-commits wrote: > > Author: steveire > Date: Sun Dec 9 05:13:41 2018 > New Revision: 348713 > > URL: http://llvm.org/viewvc/llvm-project?rev=348713&view=rev > Log: > Fix InitListExpr test > > Wrong case of Check meant this has no effect. Good c

r348730 - Move the make_const_ptr trait into STLExtras; use add_pointer where possible; NFC.

Author: aaronballman Date: Sun Dec 9 11:53:24 2018 New Revision: 348730 URL: http://llvm.org/viewvc/llvm-project?rev=348730&view=rev Log: Move the make_const_ptr trait into STLExtras; use add_pointer where possible; NFC. Modified: cfe/trunk/include/clang/AST/CommentVisitor.h cfe/trunk/i

Re: r348665 - [tests] Fix the FileManagerTest getVirtualFile test on Windows

On Fri, Dec 7, 2018 at 6:52 PM Stella Stamenova via cfe-commits wrote: > > Author: stella.stamenova > Date: Fri Dec 7 15:50:05 2018 > New Revision: 348665 > > URL: http://llvm.org/viewvc/llvm-project?rev=348665&view=rev > Log: > [tests] Fix the FileManagerTest getVirtualFile test on Windows > > S

Re: r348665 - [tests] Fix the FileManagerTest getVirtualFile test on Windows

(115, 0x73), 't' (116, 0x74) } To be equal to: ExpectedResult Which is: { 'C' (67, 0x43), ':' (58, 0x3A), '/' (47, 0x2F), 't' (116, 0x74), 'm' (109, 0x6D), 'p' (112, 0x70), '\\' (92, 0x5C), 't' (116, 0x74

Re: r348665 - [tests] Fix the FileManagerTest getVirtualFile test on Windows

entation got into a confused state. Sorry for the noise! ~Aaron > > Thanks, > -Stella > > -Original Message- > From: Aaron Ballman > Sent: Monday, December 10, 2018 10:11 AM > To: Stella Stamenova > Cc: cfe-commits > Subject: Re: r348665 - [tests] Fix

r348786 - Adding tests for -ast-dump; NFC.

Author: aaronballman Date: Mon Dec 10 10:37:47 2018 New Revision: 348786 URL: http://llvm.org/viewvc/llvm-project?rev=348786&view=rev Log: Adding tests for -ast-dump; NFC. This adds tests for expressions in C. Added: cfe/trunk/test/AST/ast-dump-expr.c Added: cfe/trunk/test/AST/ast-dump-expr

r348790 - Add an explicit triple to this test to fix failing test bots.

Author: aaronballman Date: Mon Dec 10 11:18:11 2018 New Revision: 348790 URL: http://llvm.org/viewvc/llvm-project?rev=348790&view=rev Log: Add an explicit triple to this test to fix failing test bots. Modified: cfe/trunk/test/AST/ast-dump-expr.c Modified: cfe/trunk/test/AST/ast-dump-expr.c U

Re: r348794 - Change InitListExpr dump to label and pointer

On Mon, Dec 10, 2018 at 4:13 PM Richard Smith via cfe-commits wrote: > > On Mon, 10 Dec 2018 at 12:56, Stephen Kelly via cfe-commits > wrote: >> >> Author: steveire >> Date: Mon Dec 10 12:53:32 2018 >> New Revision: 348794 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=348794&view=rev >> Log

Re: r348858 - Revert "[PowerPC] Make no-PIC default to match GCC - CLANG"

On Tue, Dec 11, 2018 at 10:50 AM Stefan Pintilie via cfe-commits wrote: > > Author: stefanp > Date: Tue Dec 11 07:47:57 2018 > New Revision: 348858 > > URL: http://llvm.org/viewvc/llvm-project?rev=348858&view=rev > Log: > Revert "[PowerPC] Make no-PIC default to match GCC - CLANG" > > This reverts

r348860 - Adding tests for -ast-dump; NFC.

Author: aaronballman Date: Tue Dec 11 08:34:59 2018 New Revision: 348860 URL: http://llvm.org/viewvc/llvm-project?rev=348860&view=rev Log: Adding tests for -ast-dump; NFC. This adds tests for expressions in C++. Added: cfe/trunk/test/AST/ast-dump-expr.cpp Added: cfe/trunk/test/AST/ast-dump-

Re: r348858 - Revert "[PowerPC] Make no-PIC default to match GCC - CLANG"

gt; buried underneath another set of failures on that same buildbot which > initially hid the problem. I'm looking at the failures now and hopefully I'll > have the change back in soon. Ah, thank you for the information. ~Aaron > > Stefan > > > > From:

r348889 - Emit -Wformat properly for bit-field promotions.

Author: aaronballman Date: Tue Dec 11 11:18:01 2018 New Revision: 348889 URL: http://llvm.org/viewvc/llvm-project?rev=348889&view=rev Log: Emit -Wformat properly for bit-field promotions. Only explicitly look through integer and floating-point promotion where the result type is actually a promot

Re: r348889 - Emit -Wformat properly for bit-field promotions.

On Tue, Dec 11, 2018 at 2:21 PM Aaron Ballman via cfe-commits wrote: > > Author: aaronballman > Date: Tue Dec 11 11:18:01 2018 > New Revision: 348889 > > URL: http://llvm.org/viewvc/llvm-project?rev=348889&view=rev > Log: > Emit -Wformat properly for bit-field promotio

r348891 - Stop stripping comments from AST matcher example code.

Author: aaronballman Date: Tue Dec 11 11:30:49 2018 New Revision: 348891 URL: http://llvm.org/viewvc/llvm-project?rev=348891&view=rev Log: Stop stripping comments from AST matcher example code. The AST matcher documentation dumping script was being a bit over-zealous about stripping comment mark

r348892 - Revert r348889; it fails some tests.

Author: aaronballman Date: Tue Dec 11 11:42:04 2018 New Revision: 348892 URL: http://llvm.org/viewvc/llvm-project?rev=348892&view=rev Log: Revert r348889; it fails some tests. http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/40784 Removed: cfe/trunk/test/Se

r355601 - expected-no-diagnostics@ does not make sense, switching to a more idiomatic form; NFC.

Author: aaronballman Date: Thu Mar 7 07:03:06 2019 New Revision: 355601 URL: http://llvm.org/viewvc/llvm-project?rev=355601&view=rev Log: expected-no-diagnostics@ does not make sense, switching to a more idiomatic form; NFC. Modified: cfe/trunk/test/SemaObjCXX/vararg-non-pod.mm Modified: c

Re: r352930 - [WebAssembly] Add an import_field function attribute

On Wed, Feb 6, 2019 at 12:43 AM Dan Gohman wrote: > > > > On Tue, Feb 5, 2019 at 11:20 AM Aaron Ballman wrote: >> >> On Fri, Feb 1, 2019 at 8:27 PM Dan Gohman wrote: >> > >> > >> > Indeed, and the existing import_module attribute needs these t

Re: r352930 - [WebAssembly] Add an import_field function attribute

On Fri, Mar 8, 2019 at 5:06 PM Aaron Ballman wrote: > > On Wed, Feb 6, 2019 at 12:43 AM Dan Gohman wrote: > > > > > > > > On Tue, Feb 5, 2019 at 11:20 AM Aaron Ballman > > wrote: > >> > >> On Fri, Feb 1, 2019 at 8:27 PM Dan Gohman

Re: r352930 - [WebAssembly] Add an import_field function attribute

On Mon, Mar 18, 2019 at 7:08 PM Dan Gohman wrote: > > > > On Fri, Mar 15, 2019 at 10:55 AM Aaron Ballman wrote: >> >> >> Ping. > > > I apologize for the extraordinarily delays here. I've now posted a patch to > address the review comments here: >

r356458 - Ensure that const variables declared at namespace scope correctly have external linkage when marked as dllexport and targeting the MSVC ABI.

Author: aaronballman Date: Tue Mar 19 07:53:52 2019 New Revision: 356458 URL: http://llvm.org/viewvc/llvm-project?rev=356458&view=rev Log: Ensure that const variables declared at namespace scope correctly have external linkage when marked as dllexport and targeting the MSVC ABI. Patch thanks to

r356551 - Correct this attribute group documentation to have a heading, which fixes the docs builder.

Author: aaronballman Date: Wed Mar 20 04:58:38 2019 New Revision: 356551 URL: http://llvm.org/viewvc/llvm-project?rev=356551&view=rev Log: Correct this attribute group documentation to have a heading, which fixes the docs builder. Modified: cfe/trunk/include/clang/Basic/AttrDocs.td Modified

r357579 - Fixing a typo; NFC.

Author: aaronballman Date: Wed Apr 3 06:37:56 2019 New Revision: 357579 URL: http://llvm.org/viewvc/llvm-project?rev=357579&view=rev Log: Fixing a typo; NFC. Modified: cfe/trunk/docs/LibASTMatchersReference.html cfe/trunk/include/clang/ASTMatchers/ASTMatchers.h Modified: cfe/trunk/docs/

r357585 - Add a new attribute documentation category for declarations.

Author: aaronballman Date: Wed Apr 3 07:26:32 2019 New Revision: 357585 URL: http://llvm.org/viewvc/llvm-project?rev=357585&view=rev Log: Add a new attribute documentation category for declarations. This moves documentation for some attributes into new categories that are hopefully a bit more c

r357589 - Whitespace and formatting changes; NFC.

Author: aaronballman Date: Wed Apr 3 07:40:00 2019 New Revision: 357589 URL: http://llvm.org/viewvc/llvm-project?rev=357589&view=rev Log: Whitespace and formatting changes; NFC. Modified: cfe/trunk/include/clang/Basic/AttrDocs.td Modified: cfe/trunk/include/clang/Basic/AttrDocs.td URL: htt

r360147 - Allow field offset lookups in types with incomplete arrays within libclang.

Author: aaronballman Date: Tue May 7 07:00:49 2019 New Revision: 360147 URL: http://llvm.org/viewvc/llvm-project?rev=360147&view=rev Log: Allow field offset lookups in types with incomplete arrays within libclang. Patch thanks to Jorn Vernee Added: cfe/trunk/test/Index/print-type-size.c Mod

r360155 - Add an explicit triple to this test to hopefully appease the build bots.

Author: aaronballman Date: Tue May 7 07:40:37 2019 New Revision: 360155 URL: http://llvm.org/viewvc/llvm-project?rev=360155&view=rev Log: Add an explicit triple to this test to hopefully appease the build bots. Modified: cfe/trunk/test/Index/print-type-size.c Modified: cfe/trunk/test/Index/

r360250 - Allow 'static' storage specifier on an out-of-line class member template declaration in MSVCCompat mode.

Author: aaronballman Date: Wed May 8 06:24:36 2019 New Revision: 360250 URL: http://llvm.org/viewvc/llvm-project?rev=360250&view=rev Log: Allow 'static' storage specifier on an out-of-line class member template declaration in MSVCCompat mode. Patch by Soumi Manna. Modified: cfe/trunk/lib/S

r360254 - Allow test to pass after 2030.

Author: aaronballman Date: Wed May 8 06:42:44 2019 New Revision: 360254 URL: http://llvm.org/viewvc/llvm-project?rev=360254&view=rev Log: Allow test to pass after 2030. Patch by Bernhard M. Wiedemann. Modified: cfe/trunk/test/Modules/fmodules-validate-once-per-build-session.c Modified: cfe

[clang-tools-extra] r360345 - Add the modernize-use-trailing-return check to rewrite function signatures to use trailing return types.

Author: aaronballman Date: Thu May 9 07:48:17 2019 New Revision: 360345 URL: http://llvm.org/viewvc/llvm-project?rev=360345&view=rev Log: Add the modernize-use-trailing-return check to rewrite function signatures to use trailing return types. Patch by Bernhard Manfred Gruber. Added: clang-

[clang-tools-extra] r360346 - Fixing a link in the release notes to appease the Sphinx bot.

Author: aaronballman Date: Thu May 9 08:00:38 2019 New Revision: 360346 URL: http://llvm.org/viewvc/llvm-project?rev=360346&view=rev Log: Fixing a link in the release notes to appease the Sphinx bot. Modified: clang-tools-extra/trunk/docs/ReleaseNotes.rst Modified: clang-tools-extra/trunk/d

[clang-tools-extra] r360348 - Revert r360345 and r360346, as they are not passing the testbots.

Author: aaronballman Date: Thu May 9 08:06:41 2019 New Revision: 360348 URL: http://llvm.org/viewvc/llvm-project?rev=360348&view=rev Log: Revert r360345 and r360346, as they are not passing the testbots. http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/48063/st

Re: r342793 - [Lexer] Add udefined_behavior_sanitizer feature

The reviewer asked you to wait a day so that others might have a chance to review it, so this commit seems premature. I have no technical concerns with the patch, but the sanitizer owners should have had a chance to weigh in. That said, I don't see value in reverting and recommitting later, so if t

[clang-tools-extra] r343415 - Allow clang-tidy to be built without a dependency on the clang static analyzer.

Author: aaronballman Date: Sun Sep 30 10:22:58 2018 New Revision: 343415 URL: http://llvm.org/viewvc/llvm-project?rev=343415&view=rev Log: Allow clang-tidy to be built without a dependency on the clang static analyzer. Patch by Stephen Kelly. Modified: clang-tools-extra/trunk/CMakeLists.txt

[clang-tools-extra] r343418 - Reverting r343415 as it breaks at least one of the bots.

Author: aaronballman Date: Sun Sep 30 10:39:39 2018 New Revision: 343418 URL: http://llvm.org/viewvc/llvm-project?rev=343418&view=rev Log: Reverting r343415 as it breaks at least one of the bots. http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/37336 Modified:

Re: r352930 - [WebAssembly] Add an import_field function attribute

On Fri, Feb 1, 2019 at 5:25 PM Dan Gohman via cfe-commits wrote: > > Author: djg > Date: Fri Feb 1 14:25:23 2019 > New Revision: 352930 > > URL: http://llvm.org/viewvc/llvm-project?rev=352930&view=rev > Log: > [WebAssembly] Add an import_field function attribute > > This is similar to import_modu

Re: r352930 - [WebAssembly] Add an import_field function attribute

On Fri, Feb 1, 2019 at 8:27 PM Dan Gohman wrote: > > > > On Fri, Feb 1, 2019 at 2:31 PM Aaron Ballman wrote: >> >> On Fri, Feb 1, 2019 at 5:25 PM Dan Gohman via cfe-commits >> wrote: >> > >> > Author: djg >> > Date: Fri Feb 1 14

Re: r353718 - Make test actually test something (colons were missing)

On Mon, Feb 11, 2019 at 11:36 AM Nico Weber via cfe-commits wrote: > > Author: nico > Date: Mon Feb 11 08:37:02 2019 > New Revision: 353718 > > URL: http://llvm.org/viewvc/llvm-project?rev=353718&view=rev > Log: > Make test actually test something (colons were missing) Good catch! I wonder if we

r353837 - Fixing a typo; NFC.

Author: aaronballman Date: Tue Feb 12 05:04:11 2019 New Revision: 353837 URL: http://llvm.org/viewvc/llvm-project?rev=353837&view=rev Log: Fixing a typo; NFC. Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td cfe/trunk/lib/Sema/SemaDeclAttr.cpp Modified: cfe/trunk/include/cl

r353838 - Renaming this diagnostic to not conflict with another; NFC.

Author: aaronballman Date: Tue Feb 12 05:13:35 2019 New Revision: 353838 URL: http://llvm.org/viewvc/llvm-project?rev=353838&view=rev Log: Renaming this diagnostic to not conflict with another; NFC. Amends r353837 which renamed the diagnostics to conflict. Modified: cfe/trunk/include/clang/B

r353839 - Renaming yet another diagnostic to not conflict; NFC.

Author: aaronballman Date: Tue Feb 12 05:19:02 2019 New Revision: 353839 URL: http://llvm.org/viewvc/llvm-project?rev=353839&view=rev Log: Renaming yet another diagnostic to not conflict; NFC. Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td cfe/trunk/lib/Sema/SemaDeclAttr.c

Re: r353976 - [Sema] Delay checking whether objc_designated_initializer is being applied to an init method

I'm fine with rolling it into 8.0. ~Aaron On Wed, Feb 13, 2019 at 3:47 PM Erik Pilkington via cfe-commits wrote: > > It isn’t a super common issue, but this is a pretty low-risk fix so I think > it would be nice to have in 8.0. > > On Feb 13, 2019, at 12:40 PM, Shoaib Meenai wrote: > > Should

Re: [clang-tools-extra] r312134 - [clang-tidy] Improve hicpp-exception-baseclass to handle generic code better

On Wed, Aug 30, 2017 at 12:16 PM, Jonas Toth via cfe-commits wrote: > Hello Diana, > > you are right, i did not commit anything earlier, I am really new to the > process, these were my first commits. > > I am sorry that i broke the bots, i thought i would get an automatic mail, > when they find a

r312639 - Replacing "or" with "||" to appease MSVC.

Author: aaronballman Date: Wed Sep 6 08:12:05 2017 New Revision: 312639 URL: http://llvm.org/viewvc/llvm-project?rev=312639&view=rev Log: Replacing "or" with "||" to appease MSVC. Modified: cfe/trunk/unittests/Tooling/LexicallyOrderedRecursiveASTVisitorTest.cpp Modified: cfe/trunk/unittest

Re: [PATCH] D36998: [AST] Traverse templates in LexicallyOrderedRecursiveASTVisitor

On Wed, Sep 6, 2017 at 11:22 AM, Philip Douglas via Phabricator via cfe-commits wrote: > pdouglas added a comment. > > Hi, > > This change is not building on Windows, because the Visual C++ compiler > doesn't support `or` (instead of `||`) by default. (See > https://msdn.microsoft.com/en-us/libr

r312811 - Add some documentation on how to generate the documentation.

Author: aaronballman Date: Fri Sep 8 11:40:39 2017 New Revision: 312811 URL: http://llvm.org/viewvc/llvm-project?rev=312811&view=rev Log: Add some documentation on how to generate the documentation. Modified: cfe/trunk/include/clang/Basic/AttrDocs.td Modified: cfe/trunk/include/clang/Basic/

Re: r312750 - [Sema] -Wtautological-compare: handle comparison of unsigned with 0S.

On Fri, Sep 8, 2017 at 5:49 PM, Hans Wennborg via cfe-commits wrote: > On Fri, Sep 8, 2017 at 2:26 PM, Friedman, Eli wrote: >> On 9/8/2017 2:18 PM, Hans Wennborg via cfe-commits wrote: >>> >>> On Fri, Sep 8, 2017 at 2:09 PM, Roman Lebedev >>> wrote: Interesting. My first thought w

Re: [PATCH] D33826: [clang-tidy] avoid pointer cast to more strict alignment check

On Tue, Sep 12, 2017 at 1:02 PM, Roman Lebedev via Phabricator wrote: > lebedev.ri added a comment. > > In https://reviews.llvm.org/D33826#868185, @aaron.ballman wrote: > >> In https://reviews.llvm.org/D33826#868167, @lebedev.ri wrote: >> >> > In https://reviews.llvm.org/D33826#868085, @aaron.ball

Re: r313747 - [Sema] CheckTautologicalComparisonWithZero(): always complain about enums

On Wed, Sep 20, 2017 at 6:15 AM, Roman Lebedev via cfe-commits wrote: > Author: lebedevri > Date: Wed Sep 20 03:15:27 2017 > New Revision: 313747 > > URL: http://llvm.org/viewvc/llvm-project?rev=313747&view=rev > Log: > [Sema] CheckTautologicalComparisonWithZero(): always complain about enums > >

Re: [PATCH] D37089: [Sema] Error out early for tags defined inside an enumeration.

On Wed, Sep 20, 2017 at 2:17 PM, Volodymyr Sapsai via Phabricator via cfe-commits wrote: > vsapsai added a comment. > > Thanks for following up, Alberto. I haven't expected such a use case. It is > possible to achieve the same with `LSA_SIZEOF_SA = sizeof(((len_and_sockaddr > *)0)->u)` but I don

Re: [PATCH] D54258: [Clang] Fix pretty printing of CUDA address spaces

On Tue, Jun 4, 2019 at 5:37 AM Richard Membarth via Phabricator wrote: > > richardmembarth added a comment. > > Merging in two weeks is fine for me. > > My assumption was that accepted patches are merged into upstream in a timely > manner. > Maybe this is not how it works? Your assumption is cor

Re: AST in JSONFormat

On Sat, Jun 8, 2019 at 5:46 AM Monalisa Rout via cfe-commits wrote: > > Hello, > > I am using LibTooling to dump the clangAST in JSON format which is available > in clang 9. > I need the JSON Schema for that. Is it available ?? > > If not wil you be interested in one ?? The JSON format for AST d

Re: [PATCH] D60455: [SYCL] Implement SYCL device code outlining

I'm out of the office until next week and won't be able to review it until then. If another trusted reviewer accepts, I can always do post commit review. ~Aaron On Tue, Jun 11, 2019, 2:43 PM Mariya Podchishchaeva via Phabricator < revi...@reviews.llvm.org> wrote: > Fznamznon added a comment. > >

Re: [PATCH] D60455: [SYCL] Implement SYCL device code outlining

recommend someone who can be “trusted reviewer” for this change, > please? > > If no, we will wait for your/Anastasia review. > > > > Thanks, > > Alexey > > > > *From:* Aaron Ballman > *Sent:* Tuesday, June 11, 2019 5:04 PM > *To:* reviews+d60455+publi

r363676 - Require commas to separate multiple GNU-style attributes in the same attribute list.

Author: aaronballman Date: Tue Jun 18 05:57:05 2019 New Revision: 363676 URL: http://llvm.org/viewvc/llvm-project?rev=363676&view=rev Log: Require commas to separate multiple GNU-style attributes in the same attribute list. Fixes PR38352. Modified: cfe/trunk/lib/Parse/ParseDecl.cpp cfe/

r363699 - Add test cases for dumping AST decl nodes to JSON; NFC.

Author: aaronballman Date: Tue Jun 18 09:36:49 2019 New Revision: 363699 URL: http://llvm.org/viewvc/llvm-project?rev=363699&view=rev Log: Add test cases for dumping AST decl nodes to JSON; NFC. Added: cfe/trunk/test/AST/ast-dump-decl-json.c Added: cfe/trunk/test/AST/ast-dump-decl-json.c URL

r363709 - Add test cases for dumping AST function decl nodes to JSON; NFC.

Author: aaronballman Date: Tue Jun 18 10:56:50 2019 New Revision: 363709 URL: http://llvm.org/viewvc/llvm-project?rev=363709&view=rev Log: Add test cases for dumping AST function decl nodes to JSON; NFC. Added: cfe/trunk/test/AST/ast-dump-funcs-json.cpp Added: cfe/trunk/test/AST/ast-dump-fun

r363819 - Change the way we output templates for JSON AST dumping and dump information about template arguments.

Author: aaronballman Date: Wed Jun 19 08:24:06 2019 New Revision: 363819 URL: http://llvm.org/viewvc/llvm-project?rev=363819&view=rev Log: Change the way we output templates for JSON AST dumping and dump information about template arguments. Previously, we attempted to write out template paramet

r363820 - Add a script to help generate expected test output for dumping the AST to JSON.

Author: aaronballman Date: Wed Jun 19 08:25:24 2019 New Revision: 363820 URL: http://llvm.org/viewvc/llvm-project?rev=363820&view=rev Log: Add a script to help generate expected test output for dumping the AST to JSON. Patch by Abhishek Bhaskar. Added: cfe/trunk/test/AST/gen_ast_dump_json_te

r363859 - Switching this test to use output generated by script; NFC.

Author: aaronballman Date: Wed Jun 19 12:07:52 2019 New Revision: 363859 URL: http://llvm.org/viewvc/llvm-project?rev=363859&view=rev Log: Switching this test to use output generated by script; NFC. Modified: cfe/trunk/test/AST/ast-dump-if-json.cpp Modified: cfe/trunk/test/AST/ast-dump-if-js

r363866 - Dump the value calculated by a constant expression when dumping the AST to JSON.

Author: aaronballman Date: Wed Jun 19 12:12:22 2019 New Revision: 363866 URL: http://llvm.org/viewvc/llvm-project?rev=363866&view=rev Log: Dump the value calculated by a constant expression when dumping the AST to JSON. Modified: cfe/trunk/include/clang/AST/JSONNodeDumper.h cfe/trunk/lib/

r363869 - Print out the union field being initialized by an InitListExpr when dumping the AST to JSON.

Author: aaronballman Date: Wed Jun 19 12:40:07 2019 New Revision: 363869 URL: http://llvm.org/viewvc/llvm-project?rev=363869&view=rev Log: Print out the union field being initialized by an InitListExpr when dumping the AST to JSON. Modified: cfe/trunk/include/clang/AST/JSONNodeDumper.h c

r363873 - Print whether a generic selection expression is result dependent when dumping the AST to JSON.

Author: aaronballman Date: Wed Jun 19 13:16:55 2019 New Revision: 363873 URL: http://llvm.org/viewvc/llvm-project?rev=363873&view=rev Log: Print whether a generic selection expression is result dependent when dumping the AST to JSON. Modified: cfe/trunk/include/clang/AST/JSONNodeDumper.h

r363932 - Add test cases for explicit casts when dumping the AST to JSON; NFC.

Author: aaronballman Date: Thu Jun 20 08:04:24 2019 New Revision: 363932 URL: http://llvm.org/viewvc/llvm-project?rev=363932&view=rev Log: Add test cases for explicit casts when dumping the AST to JSON; NFC. Added: cfe/trunk/test/AST/multistep-explicit-cast-json.c cfe/trunk/test/AST/multi

r363935 - Removing a helper function that was trivial to inline into its only use; NFC.

Author: aaronballman Date: Thu Jun 20 08:10:45 2019 New Revision: 363935 URL: http://llvm.org/viewvc/llvm-project?rev=363935&view=rev Log: Removing a helper function that was trivial to inline into its only use; NFC. Modified: cfe/trunk/include/clang/AST/TextNodeDumper.h cfe/trunk/lib/AST

r363943 - Dump more information about expressions involving temporaries when dumping the AST to JSON.

Author: aaronballman Date: Thu Jun 20 09:22:35 2019 New Revision: 363943 URL: http://llvm.org/viewvc/llvm-project?rev=363943&view=rev Log: Dump more information about expressions involving temporaries when dumping the AST to JSON. Added: cfe/trunk/test/AST/ast-dump-temporaries-json.cpp Modif

r363966 - Print additional information about @encode expressions when dumping the AST to JSON.

Author: aaronballman Date: Thu Jun 20 12:11:35 2019 New Revision: 363966 URL: http://llvm.org/viewvc/llvm-project?rev=363966&view=rev Log: Print additional information about @encode expressions when dumping the AST to JSON. Modified: cfe/trunk/include/clang/AST/JSONNodeDumper.h cfe/trunk

r365919 - Dump actual line numbers when dumping the AST to JSON.

Author: aaronballman Date: Fri Jul 12 09:53:57 2019 New Revision: 365919 URL: http://llvm.org/viewvc/llvm-project?rev=365919&view=rev Log: Dump actual line numbers when dumping the AST to JSON. The "line" attribute is now the physical line within the source file for the location. A "presumedLine

r366626 - Implement P1301R4, which allows specifying an optional message on the [[nodiscard]] attribute.

Author: aaronballman Date: Sat Jul 20 00:56:34 2019 New Revision: 366626 URL: http://llvm.org/viewvc/llvm-project?rev=366626&view=rev Log: Implement P1301R4, which allows specifying an optional message on the [[nodiscard]] attribute. This also bumps the attribute feature test value and introduce

r366628 - We support P1301R4 in C++2a as of r366626.

Author: aaronballman Date: Sat Jul 20 01:24:56 2019 New Revision: 366628 URL: http://llvm.org/viewvc/llvm-project?rev=366628&view=rev Log: We support P1301R4 in C++2a as of r366626. Modified: cfe/trunk/www/cxx_status.html Modified: cfe/trunk/www/cxx_status.html URL: http://llvm.org/viewvc/l

r366629 - Mark P1301R4 in C++2a as being SVN instead.

Author: aaronballman Date: Sat Jul 20 01:57:08 2019 New Revision: 366629 URL: http://llvm.org/viewvc/llvm-project?rev=366629&view=rev Log: Mark P1301R4 in C++2a as being SVN instead. Modified: cfe/trunk/www/cxx_status.html Modified: cfe/trunk/www/cxx_status.html URL: http://llvm.org/viewvc/

Re: r366628 - We support P1301R4 in C++2a as of r366626.

On Sat, Jul 20, 2019 at 4:54 AM Richard Smith wrote: > > On Sat, 20 Jul 2019 at 10:24, Aaron Ballman via cfe-commits > wrote: >> >> Author: aaronballman >> Date: Sat Jul 20 01:24:56 2019 >> New Revision: 366628 >> >> URL: http://llvm.org/viewvc/l

r366682 - Revert the change to the [[nodiscard]] feature test macro value.

Author: aaronballman Date: Mon Jul 22 05:49:28 2019 New Revision: 366682 URL: http://llvm.org/viewvc/llvm-project?rev=366682&view=rev Log: Revert the change to the [[nodiscard]] feature test macro value. This value only gets bumped once both P1301 and P1771 are implemented. Modified: cfe/tru

Re: r366626 - Implement P1301R4, which allows specifying an optional message on the [[nodiscard]] attribute.

On Sun, Jul 21, 2019 at 7:40 AM Richard Smith wrote: > > On Sat, 20 Jul 2019 at 09:55, Aaron Ballman via cfe-commits > wrote: >> >> Author: aaronballman >> Date: Sat Jul 20 00:56:34 2019 >> New Revision: 366626 >> >> URL: http://llvm.org/v

[clang-tools-extra] r366687 - Update documentation for all CERT checks that correspond to a recommendation.

Author: aaronballman Date: Mon Jul 22 06:22:08 2019 New Revision: 366687 URL: http://llvm.org/viewvc/llvm-project?rev=366687&view=rev Log: Update documentation for all CERT checks that correspond to a recommendation. CERT removed their C++ secure coding recommendations from public view and so th

Re: [PATCH] D59254: [RFC] Implementation of Clang randstruct

On Tue, Jul 23, 2019 at 9:17 PM Connor Kuehl via Phabricator wrote: > > connorkuehl added a comment. > > In D59254#1429401 , @jfb wrote: > > > I find it easier to understand the code by looking at the tests. When you > > add tests, please make sure you tes

r366941 - Fix exporting SARIF files from scan-build on Windows.

Author: aaronballman Date: Wed Jul 24 13:03:27 2019 New Revision: 366941 URL: http://llvm.org/viewvc/llvm-project?rev=366941&view=rev Log: Fix exporting SARIF files from scan-build on Windows. In Perl, -z is defined as checking if a "file has zero size" and makes no mention what it does when giv

Phabricator stability

Just an FYI, but it seems like Phabricator may be having some issues this weekend. When trying to perform reviews, a few folks have noticed they get errors about insufficient space to save various internal tables. Additionally, it seems that emails from submitted reviews are not always being genera

Re: r367193 - Buildbot fix for r367190

On Mon, Jul 29, 2019 at 3:03 PM Galina Kistanova via cfe-commits wrote: > > Hello Gabor , > > It looks like this commit broke tests on couple builders: > > http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/18867/steps/test-check-all/logs/stdio > http://lab.llvm.org:80

r367312 - Add typedef declaration information to the JSON AST dump.

Author: aaronballman Date: Tue Jul 30 06:42:19 2019 New Revision: 367312 URL: http://llvm.org/viewvc/llvm-project?rev=367312&view=rev Log: Add typedef declaration information to the JSON AST dump. When dumping a desugared QualType and the type is a type alias, also print out the id for the type

Re: AST for For loop

On Tue, Aug 6, 2019 at 11:15 AM Monalisa Rout via cfe-commits wrote: > > Hello, > While dumping the AST for For loop, Why do I get <<>> ?? > > Source code: > void func() > { > for (int i = 0; i < 5; i++) > break; > } > > AST > > FunctionDecl 0x4a4ac10 > line:2:6 > func 'void ()' > `-CompoundSt

r369033 - Allow standards-based attributes to have leading and trailing underscores.

Author: aaronballman Date: Thu Aug 15 11:35:44 2019 New Revision: 369033 URL: http://llvm.org/viewvc/llvm-project?rev=369033&view=rev Log: Allow standards-based attributes to have leading and trailing underscores. This gives library implementers a way to use standards-based attributes that do no

r369035 - Rename this file from cx2.c to c2x.c; NFC.

Author: aaronballman Date: Thu Aug 15 11:37:30 2019 New Revision: 369035 URL: http://llvm.org/viewvc/llvm-project?rev=369035&view=rev Log: Rename this file from cx2.c to c2x.c; NFC. Added: cfe/trunk/test/Sema/attr-c2x.c - copied unchanged from r369034, cfe/trunk/test/Sema/attr-cx2.c Rem

r369259 - Don't keep stale pointers to LoopInfos.

Author: aaronballman Date: Mon Aug 19 06:37:41 2019 New Revision: 369259 URL: http://llvm.org/viewvc/llvm-project?rev=369259&view=rev Log: Don't keep stale pointers to LoopInfos. CGLoopInfo was keeping pointers to parent loop LoopInfos, but when the loop info vector grew, it reallocated the stor

r364055 - Add an automated note to files produced by gen_ast_dump_json_test.py.

Author: aaronballman Date: Fri Jun 21 07:37:39 2019 New Revision: 364055 URL: http://llvm.org/viewvc/llvm-project?rev=364055&view=rev Log: Add an automated note to files produced by gen_ast_dump_json_test.py. This also details what filters, if any, were used to generate the test output. Updates

r364067 - Print more type node information when dumping the AST to JSON.

Author: aaronballman Date: Fri Jun 21 09:06:09 2019 New Revision: 364067 URL: http://llvm.org/viewvc/llvm-project?rev=364067&view=rev Log: Print more type node information when dumping the AST to JSON. Added: cfe/trunk/test/AST/ast-dump-types-json.cpp Modified: cfe/trunk/include/clang/AST

r364078 - Ensure that top-level QualType objects also have a "kind" field when dumping the AST to JSON.

Author: aaronballman Date: Fri Jun 21 10:14:25 2019 New Revision: 364078 URL: http://llvm.org/viewvc/llvm-project?rev=364078&view=rev Log: Ensure that top-level QualType objects also have a "kind" field when dumping the AST to JSON. Modified: cfe/trunk/lib/AST/JSONNodeDumper.cpp cfe/trun

<    1   2   3   4   5   6   7   8   9   10   >