[PATCH] D124038: [clang] Prevent folding of non-const compound expr

serge-sans-paille updated this revision to Diff 428317. serge-sans-paille edited the summary of this revision. serge-sans-paille added a comment. Added reg to GCC info page to explain current behavior, and make the test more explicit with respect to that quote. CHANGES SINCE LAST ACTION https

[PATCH] D124038: [clang] Prevent folding of non-const compound expr

serge-sans-paille added inline comments. Comment at: clang/test/SemaCXX/constant-expression-cxx11.cpp:1609 struct X { int a[2]; }; constexpr int *n = (X){1, 2}.a; // expected-warning {{C99}} expected-warning {{temporary}} // expected-error@-1 {{constant expression}} ---

[PATCH] D124038: [clang] Prevent folding of non-const compound expr

serge-sans-paille added a comment. In D124038#3504371 , @efriedma wrote: > I think you're looking at old documentation? Here's what the current page > (https://gcc.gnu.org/onlinedocs/gcc/Compound-Literals.html) has to say: Indeed! I was looking at my l

[PATCH] D124038: [clang] Prevent folding of non-const compound expr

serge-sans-paille updated this revision to Diff 428562. serge-sans-paille added a comment. Update GCC manual quote CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124038/new/ https://reviews.llvm.org/D124038 Files: clang/lib/AST/ExprConstant.cpp clang/test/SemaCXX/constant-expression

[PATCH] D124038: [clang] Prevent folding of non-const compound expr

serge-sans-paille updated this revision to Diff 429156. serge-sans-paille added a comment. Update messed up format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124038/new/ https://reviews.llvm.org/D124038 Files: clang/lib/AST/ExprConstant.cpp clang/test/SemaCXX/constant-expression

[PATCH] D124038: [clang] Prevent folding of non-const compound expr

This revision was automatically updated to reflect the committed changes. Closed by commit rG924acb624f58: [clang] Prevent folding of non-const compound expr (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124038/new/

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

serge-sans-paille updated this revision to Diff 217604. serge-sans-paille added a comment. @Meinersbur patch rebased. I removed the linker trick (which only work for global variables, not function, anyway), as it's no longer needed: target_compile_definitions(${name} PRIVATE LLVM_${name_upper}

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

This revision was automatically updated to reflect the committed changes. Closed by commit rG24ab9b537e61: Generalize the pass registration mechanism used by Polly to any third-party tool (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

serge-sans-paille marked an inline comment as done. serge-sans-paille added a comment. serge-sans-paille added inline comments. Comment at: llvm/test/lit.site.cfg.py.in:6 +def cmake_bool(val): +return val.lower() in (1, "on", "yes", "true", "y",) + thakis wro

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

serge-sans-paille added a comment. In D61446#1805413 , @svenvh wrote: > This change seems to be causing a problem with the nightly packages from > apt.llvm.org. https://reviews.llvm.org/D72255 should do the trick (?) Repository: rG LLVM Github Monor

[PATCH] D71374: Improve support of GNU mempcpy

serge-sans-paille added a comment. @xbolva00 : gentle reminder :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71374/new/ https://reviews.llvm.org/D71374 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D71082: Allow system header to provide their own implementation of some builtin

serge-sans-paille added a comment. @sylvestre.ledru : I'd like a confirmation from @efriedma first! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71082/new/ https://reviews.llvm.org/D71082 ___ cfe-comm

[PATCH] D71374: Improve support of GNU mempcpy

This revision was automatically updated to reflect the committed changes. Closed by commit rGcee4a1c95742: Improve support of GNU mempcpy (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71374/new/ https://reviews.llvm.

[PATCH] D71082: Allow system header to provide their own implementation of some builtin

This revision was automatically updated to reflect the committed changes. Closed by commit rG921f871ac438: Allow system header to provide their own implementation of some builtin (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D68720: Support -fstack-clash-protection for x86

serge-sans-paille updated this revision to Diff 237298. serge-sans-paille added a comment. Take review into account. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68720/new/ https://reviews.llvm.org/D68720 Files: clang/docs/ClangCommandLineRefer

[PATCH] D71566: New checks for fortified sprintf

serge-sans-paille added a comment. @erik.pilkington up? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71566/new/ https://reviews.llvm.org/D71566 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D68720: Support -fstack-clash-protection for x86

serge-sans-paille marked 9 inline comments as done. serge-sans-paille added inline comments. Comment at: clang/lib/CodeGen/CGStmt.cpp:2254 +CGM.getDiags().Report(S.getAsmLoc(), + diag::warn_fe_stack_clash_protection_inline_asm); + } -

[PATCH] D68720: Support -fstack-clash-protection for x86

serge-sans-paille marked 2 inline comments as done. serge-sans-paille added inline comments. Comment at: clang/lib/CodeGen/CGStmt.cpp:2254 +CGM.getDiags().Report(S.getAsmLoc(), + diag::warn_fe_stack_clash_protection_inline_asm); + } -

[PATCH] D68720: Support -fstack-clash-protection for x86

serge-sans-paille updated this revision to Diff 237486. serge-sans-paille added a comment. - update warn_fe_stack_clash_protection_inline_asm location. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68720/new/ https://reviews.llvm.org/D68720 Files:

[PATCH] D65616: Ignore -fsemantic-interposition/-fno-semantic-interposition flag for gcc compatibility

serge-sans-paille added a comment. (back on that one) The default in clang is implicitly `-fno-semantic-interposition`. I think we can safely support it, and either warn or error on `-fsemantic-interposition`. @hfinkel does that seem correct to you? Repository: rG LLVM Github Monorepo CHA

[PATCH] D72724: [Driver] Ignore -fno-semantic-interposition

serge-sans-paille accepted this revision. serge-sans-paille added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72724/new/ https://reviews.llvm.org/D72724 _

[PATCH] D72724: [Driver] Ignore -fno-semantic-interposition

serge-sans-paille added a comment. @MaskRay: is that okay with you if I start implementing -fsemantic-interposition based on `dso_preemptable`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72724/new/ https://reviews.llvm.org/D72724 ___

[PATCH] D65616: Ignore -fsemantic-interposition/-fno-semantic-interposition flag for gcc compatibility

serge-sans-paille added a comment. Obsoleted by https://reviews.llvm.org/D72724, closing. Thanks @Romain-Geissler-1A for triggering that patch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65616/new/ https://reviews.llvm.org/D65616 __

[PATCH] D71082: Allow system header to provide their own implementation of some builtin

serge-sans-paille added a comment. In D71082#1822925 , @akhuang wrote: > This caused a linker error in chromium: > > ld.lld: error: undefined symbol: __warn_memset_zero_len > > > Apparently now that the glibc memset is being used, __warn_memset_zero_len

[PATCH] D71082: Allow system header to provide their own implementation of some builtin

serge-sans-paille added a comment. @akhuang : I've reported https://sourceware.org/bugzilla/show_bug.cgi?id=25399 to glibc. According to me this is more of a glibc problem than this patch, and as we have a workaround with `-fgnuc-version=5.0` I think we could apply the patch back. Repository:

[PATCH] D72829: Implement -fsemantic-interposition

serge-sans-paille created this revision. serge-sans-paille added reviewers: MaskRay, hfinkel. Herald added subscribers: llvm-commits, cfe-commits, haicheng, hiraditya, eraman. Herald added projects: clang, LLVM. serge-sans-paille added a comment. @MaskRay no example yet, I'd like your opinion on

[PATCH] D68720: Support -fstack-clash-protection for x86

serge-sans-paille added a comment. @craig.topper up? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68720/new/ https://reviews.llvm.org/D68720 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D72829: Implement -fsemantic-interposition

serge-sans-paille added a comment. @MaskRay no example yet, I'd like your opinion on the approach first. It has the advantage of being non intrusive to the code base... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72829/new/ https://reviews.llvm.

[PATCH] D71566: New checks for fortified sprintf

serge-sans-paille added a comment. @erik.pilkington up? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71566/new/ https://reviews.llvm.org/D71566 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D85485: Fix quiet mode in git-clang-format

serge-sans-paille accepted this revision. serge-sans-paille added a comment. Sure, thanks for your patience! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85485/new/ https://reviews.llvm.org/D85485 ___ c

[PATCH] D85485: Fix quiet mode in git-clang-format

serge-sans-paille added a comment. I'll need a contact email to preserve authorship information, can you send me one at `sguel...@redhat.com`? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85485/new/ https://reviews.llvm.org/D85485 __

[PATCH] D85485: Fix quiet mode in git-clang-format

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG294e1900f281: Fix quiet mode in git-clang-format (authored by Gvald, committed by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D83984: Explicitly use utf-8 in send_string

serge-sans-paille accepted this revision. serge-sans-paille added a comment. This revision is now accepted and ready to land. LGTM then :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83984/new/ https://reviews.llvm.org/D83984 __

[PATCH] D83984: Explicitly use utf-8 in send_string

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb3205e2ace43: [scan-view] Explicitly use utf-8 in send_string (authored by Tomas Rix , committed by serge-sans-paille). Repositor

[PATCH] D83984: Explicitly use utf-8 in send_string

serge-sans-paille added a comment. Commited on your behalf using what I expect to be your official email address :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83984/new/ https://reviews.llvm.org/D83984

[PATCH] D92245: -fstack-clash-protection: Return an actual error when used on unsupported OS

serge-sans-paille added a comment. @sylvestre.ledru I: double checked and there's nothing in the original advisory against Darwin, but nothing that clearly states it's protected either (unlike Windows-based system). And there's also nothing specific to Darwin in the stack clash protection impl

[PATCH] D92245: -fstack-clash-protection: Return an actual error when used on unsupported OS

serge-sans-paille accepted this revision. serge-sans-paille added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92245/new/ https://reviews.llvm.org/D92245 __

[PATCH] D88990: Update documentation on stage3 cmake build

This revision was automatically updated to reflect the committed changes. Closed by commit rGb4ffc40d622b: Update documentation and implementation of stage3 build (authored by serge-sans-paille). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github M

[PATCH] D68720: Support -fstack-clash-protection for x86

serge-sans-paille added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3009-3010 + + if (!EffectiveTriple.isOSLinux()) +return; + emaste wrote: > Is there anything OS-dependent here? > > I plan to add `EffectiveTriple.isOSFreeBSD()` to F

[PATCH] D74704: Support -fuse-ld=lld for riscv

serge-sans-paille added inline comments. Comment at: clang/test/lit.site.cfg.py.in:50 +if not "@CLANG_DEFAULT_LINKER@": +config.available_features('platform-linker') + thakis wrote: > Why do you need this feature? clang invocations that want to use the platfo

[PATCH] D92245: -fstack-clash-protection: Return an actual error when used on unsupported OS

serge-sans-paille added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:276-277 "-fembed-bitcode is not supported on versions of iOS prior to 6.0">; +def err_drv_stack_clash_protection_unsupported_on_toolchain : Error< + "-fstack-clash-protecti

[PATCH] D92291: clang/test: Remove platform-linker feature

serge-sans-paille added a comment. If that's okay with @leonardchan in terms of RISCV validation, I'm fine with that one. Any branch removed is less path to cover! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92291/new/ https://reviews.llvm.org/D92291

[PATCH] D92245: -fstack-clash-protection: Return an actual error when used on unsupported OS

serge-sans-paille added a comment. In D92245#2425817 , @emaste wrote: >> How do things go wrong on Darwin? I was under the impression that this was >> implemented in LLVM as strictly inline code, no runtime support required. > > That is my impression as w

[PATCH] D89942: Disable LTO and LLD for bootstrap builds on systems unsupported by LLD

serge-sans-paille added inline comments. Comment at: clang/CMakeLists.txt:668 +message(STATUS "Using system linker for stage3 builds on Apple") +set(BOOTSTRAP_LLVM_ENABLE_LLD OFF CACHE BOOL "") + else() Should you also disable LTO here? Repository: r

[PATCH] D89942: Disable LTO and LLD for bootstrap builds on systems unsupported by LLD

serge-sans-paille added a comment. @beanz This patch looks good to me, can you confirm? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89942/new/ https://reviews.llvm.org/D89942 ___ cfe-commits mailing li

[PATCH] D102168: Use an allow list on reserved macro identifiers

serge-sans-paille updated this revision to Diff 344825. serge-sans-paille added a comment. Minor nits as suggested by reviewers + extend the list. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102168/new/ https://reviews.llvm.org/D102168 Files: clang/lib/Lex/PPDirectives.cpp clang/

[PATCH] D102168: Use an allow list on reserved macro identifiers

serge-sans-paille updated this revision to Diff 344840. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102168/new/ https://reviews.llvm.org/D102168 Files: clang/lib/Lex/PPDirectives.cpp clang/test/Preprocessor/macro-reserved.c Index: clang/test/Preprocessor/macro-reserved.c

[PATCH] D102168: Use an allow list on reserved macro identifiers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6045cb89e5e8: Use an allow list on reserved macro identifiers (authored by serge-sans-paille). Herald added a project: clang. Repository: rG LLVM

[PATCH] D60380: Also document -arch as -arch is mac specific

serge-sans-paille added inline comments. Comment at: docs/CommandGuide/clang.rst:319 + + Specify the architecture to build for (Linux and others) To be clear: this is probably misleading and should be `(all platforms)` Repository: rC Clang CHANGES SINCE L

[PATCH] D93095: Introduce -Wreserved-identifier

serge-sans-paille updated this revision to Diff 319929. serge-sans-paille added a comment. Back to the previous version, as suggested by @rsmith . I made a few updates to `NamedDecl::isReserved` which get me close to the expected result, without too much overhead. CHANGES SINCE LAST ACTION h

[PATCH] D93095: Introduce -Wreserved-identifier

serge-sans-paille marked an inline comment as done. serge-sans-paille added inline comments. Comment at: clang/lib/Sema/Sema.cpp:2421-2428 +// Perform a lookup at TUScope. If it succeeds, we're at global scope and a +// single '_' is enough to be reserved. +LookupResu

[PATCH] D94420: [clang-tooling] Prevent llvm::fatal_error on invalid CLI option

This revision was automatically updated to reflect the committed changes. Closed by commit rGd47ee525f9e9: [clang-tooling] Prevent llvm::fatal_error on invalid CLI option (authored by serge-sans-paille). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM

[PATCH] D93095: Introduce -Wreserved-identifier

serge-sans-paille updated this revision to Diff 320212. serge-sans-paille added a comment. Extra test cases CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93095/new/ https://reviews.llvm.org/D93095 Files: clang/include/clang/AST/Decl.h clang/include/clang/Basic/DiagnosticGroups.td

[PATCH] D93095: Introduce -Wreserved-identifier

serge-sans-paille marked an inline comment as done. serge-sans-paille added a comment. @rsmith I did my bet to address your comments. What do you think of current state? Comment at: clang/lib/Sema/SemaDecl.cpp:13640 + warnOnReservedIdentifier(New); + serge-

[PATCH] D109967: Simplify handling of builtin with inline redefinition

serge-sans-paille created this revision. serge-sans-paille added reviewers: rnk, nickdesaulniers, efriedma. serge-sans-paille requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. It is a common practice in glibc header to provide an inline redef

[PATCH] D109967: Simplify handling of builtin with inline redefinition

serge-sans-paille added a comment. @kees this does fix https://bugs.llvm.org/show_bug.cgi?id=50322 , but only if the memcpy "inline definition" is flagged as a `__attribute__((always_inline))` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109967/n

[PATCH] D109967: Simplify handling of builtin with inline redefinition

serge-sans-paille updated this revision to Diff 373801. serge-sans-paille added a comment. Herald added a subscriber: whisperity. Update formatting / extra comments Update test to be more explicit about their intent / run them through update_cc_test_checks CHANGES SINCE LAST ACTION https://r

[PATCH] D109967: Simplify handling of builtin with inline redefinition

serge-sans-paille marked 6 inline comments as done. serge-sans-paille added inline comments. Comment at: clang/test/CodeGen/memcpy-inline-builtin.c:1 +// RUN: %clang_cc1 -triple x86_64-unknown-unknown -S -emit-llvm -o - %s -disable-llvm-passes | FileCheck %s +//

[PATCH] D109967: Simplify handling of builtin with inline redefinition

serge-sans-paille marked 3 inline comments as done. serge-sans-paille added a comment. In D109967#3013552 , @nickdesaulniers wrote: > Looks reasonable. Can you give us some time to test this on the Linux kernel? Sure, who can refuse some extra testing?

[PATCH] D109967: Simplify handling of builtin with inline redefinition

serge-sans-paille updated this revision to Diff 374290. serge-sans-paille added a comment. Set default as suggested by @nickdesaulniers CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109967/new/ https://reviews.llvm.org/D109967 Files: clang/lib/CodeGen/CodeGenFunction.cpp clang/lib/

[PATCH] D109693: Driver: Remove major release version detection for RHEL

serge-sans-paille accepted this revision. serge-sans-paille added a comment. This revision is now accepted and ready to land. LGTM, please reformat the code though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109693/new/ https://reviews.llvm.org/

[PATCH] D110521: Make analyze-cc path discovery sensible to symlinks

serge-sans-paille created this revision. serge-sans-paille added a reviewer: sylvestre.ledru. Herald added a subscriber: whisperity. serge-sans-paille requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix https://bugs.llvm.org/show_bug.cgi?id

[PATCH] D110521: Make analyze-cc path discovery sensible to symlinks

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe45f67f31e22: Make analyze-cc path discovery sensible to symlinks (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D109967: Simplify handling of builtin with inline redefinition

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3d6f49a56995: Simplify handling of builtin with inline redefinition (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D109967: Simplify handling of builtin with inline redefinition

serge-sans-paille added a comment. @kees great, thanks for confirming - I just landed the patch. Can you share a pointer to the missing pieces? I'm interested in implemented the missing parts. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109967/ne

[PATCH] D109967: Simplify handling of builtin with inline redefinition

serge-sans-paille added a comment. for the record: I had to apply that extra patch: bd379915de38a9af3d65e19075a6a64ebbb8d6db which enforces the `always_inline` attribute Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D109967: Simplify handling of builtin with inline redefinition

serge-sans-paille added a comment. @kda : thanks for the builbot reference. The issue you're pointing at occurs *before* bd379915de38a9af3d65e19075a6a64ebbb8d6db which specifically fixes the issue spotted by the buildbot. A

[PATCH] D109967: Simplify handling of builtin with inline redefinition

serge-sans-paille added a comment. @thakis if rG1ecb1bc3e214 doesn't work, I'll revert. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109967/new/ https://reviews.llvm.org/D1099

[PATCH] D109967: Simplify handling of builtin with inline redefinition

serge-sans-paille added a comment. @thakis: fine on OSX: http://45.33.8.238/macm1/18808/summary.html Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109967/new/ https://reviews.llvm.org/D109967 ___ cfe-com

[PATCH] D109967: Simplify handling of builtin with inline redefinition

serge-sans-paille added a comment. And on Windows: http://45.33.8.238/win/46077/summary.html ! Thanks for pointing those. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109967/new/ https://reviews.llvm.org/D109967 _

[PATCH] D111009: Update inline builtin handling to honor gnu inline attribute

serge-sans-paille created this revision. serge-sans-paille added reviewers: kees, nickdesaulniers. serge-sans-paille requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Per the GCC info page: If the function is declared 'extern', then this d

[PATCH] D111009: Update inline builtin handling to honor gnu inline attribute

serge-sans-paille updated this revision to Diff 376790. serge-sans-paille added a comment. + extra test case + avoid Playing with Twines + fix storage of external declaration of inline builtins + minor nits CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111009/new/ https://reviews.llvm.o

[PATCH] D111009: Update inline builtin handling to honor gnu inline attribute

serge-sans-paille updated this revision to Diff 376794. serge-sans-paille added a comment. + fix linkage of generated function CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111009/new/ https://reviews.llvm.org/D111009 Files: clang/lib/AST/Decl.cpp clang/lib/CodeGen/CGExpr.cpp cla

[PATCH] D111009: Update inline builtin handling to honor gnu inline attribute

serge-sans-paille updated this revision to Diff 376812. serge-sans-paille added a comment. + extra test case + use internal linkage instead of available_externally linkage for generated clone CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111009/new/ https://reviews.llvm.org/D111009 Fi

[PATCH] D111009: Update inline builtin handling to honor gnu inline attribute

This revision was automatically updated to reflect the committed changes. Closed by commit rG0f0e31cf511d: Update inline builtin handling to honor gnu inline attribute (authored by serge-sans-paille). Changed prior to commit: https://reviews.llvm.org/D111009?vs=376812&id=377023#toc Repository:

[PATCH] D96400: Reduce the number of attributes attached to each function

This revision was automatically updated to reflect the committed changes. Closed by commit rG3c8bf29f14e4: Reduce the number of attributes attached to each function (authored by serge-sans-paille). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github

[PATCH] D96788: Support standalone build of clang-tidy unittest

This revision was automatically updated to reflect the committed changes. Closed by commit rGf0e461057221: Support standalone build of clang-tidy unittest (authored by serge-sans-paille). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D53014: Add CMAKE_BUILD_TYPE to the list of BOOTSTRAP_DEFAULT_PASSTHROUGH variables

serge-sans-paille accepted this revision. serge-sans-paille added a comment. This revision is now accepted and ready to land. LGTM, sorry for the late review. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53014/new/ https://reviews.llvm.org/D53014 __

[PATCH] D103849: Fix undeduced type when instanciating template member

serge-sans-paille updated this revision to Diff 351191. serge-sans-paille added a comment. Added test + fix suggested by @aaron.ballman CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103849/new/ https://reviews.llvm.org/D103849 Files: clang/lib/AST/Expr.cpp clang/test/CodeGenCXX/aut

[PATCH] D104116: AMD k8 family does not support SSE4.x which are required by x86-64-v2+

This revision was automatically updated to reflect the committed changes. Closed by commit rG092c303955cd: AMD k8 family does not support SSE4.x which are required by x86-64-v2+ (authored by serge-sans-paille). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: r

[PATCH] D104116: AMD k8 family does not support SSE4.x which are required by x86-64-v2+

serge-sans-paille added a comment. In D104116#2816291 , @RKSimon wrote: > This leaves the question - what hardware should we align each of the > CK_x86_64_v* targets with? I'm not quite sure I get it. If I understand correctly, each `CK_x86_64_v*` impl

[PATCH] D104299: Handle interactions between reserved identifier and user-defined suffixes

serge-sans-paille created this revision. serge-sans-paille added reviewers: aaron.ballman, rsmith. Herald added a subscriber: dexonsmith. serge-sans-paille requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project:

[PATCH] D104299: Handle interactions between reserved identifier and user-defined suffixes

serge-sans-paille updated this revision to Diff 352146. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104299/new/ https://reviews.llvm.org/D104299 Files: clang/include/clang/Basic/IdentifierTable.h clang/lib/Basic/IdentifierTable.cpp clang/lib/Parse/ParseExprCXX.cpp clang/test/Se

[PATCH] D104299: Handle interactions between reserved identifier and user-defined suffixes

serge-sans-paille updated this revision to Diff 352423. serge-sans-paille added a comment. Tried another not-so-intrusive approach. @rsmith? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104299/new/ https://reviews.llvm.org/D104299 Files: clang/include/clang/Sema/Sema.h clang/lib/A

[PATCH] D104299: Handle interactions between reserved identifier and user-defined suffixes

serge-sans-paille updated this revision to Diff 352938. serge-sans-paille added a comment. Reviews taken into account, I'm just not 100% sure of the fixit part. The out is the following: a.cpp:4:16: warning: identifier '_Bye' is reserved because it starts with '_' followed by a capital letter

[PATCH] D103849: Fix undeduced type when instanciating template member

serge-sans-paille added a comment. @rsmith : any opinion on that one? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103849/new/ https://reviews.llvm.org/D103849 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D104299: Handle interactions between reserved identifier and user-defined suffixes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. serge-sans-paille marked 2 inline comments as done. Closed by commit rGa0d05ed84899: Handle interactions between reserved identifier and user-defined suffixes (authored

[PATCH] D103849: Fix undeduced type when instanciating template member

serge-sans-paille added a comment. @rsmith : gentle ping ;-) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103849/new/ https://reviews.llvm.org/D103849 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[PATCH] D112059: Fix inline builtin handling in case of redefinition

serge-sans-paille updated this revision to Diff 382337. serge-sans-paille added a comment. - Add a test case to ensure we keep the right behavior for non-intrinsic gnu inline - walk the redecl chain before doing an extra string alloc CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112059/

[PATCH] D112059: Fix inline builtin handling in case of redefinition

serge-sans-paille updated this revision to Diff 382344. serge-sans-paille added a comment. Formatting nits CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112059/new/ https://reviews.llvm.org/D112059 Files: clang/lib/CodeGen/CodeGenFunction.cpp clang/test/CodeGen/strlen-inline-builti

[PATCH] D112059: Fix inline builtin handling in case of redefinition

serge-sans-paille updated this revision to Diff 382671. serge-sans-paille added a comment. - Use a FunctionDecl Attribute to store the shadowed inline redecl status CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112059/new/ https://reviews.llvm.org/D112059 Files: clang/include/clang/A

[PATCH] D112059: Fix inline builtin handling in case of redefinition

serge-sans-paille added inline comments. Comment at: clang/test/CodeGen/user-func-gnu-inline-redecl.c:20 + return some_size(s); +} nickdesaulniers wrote: > this test passes before this patch is applied; I wonder if we have existing > coverage in tree for this c

[PATCH] D112024: [clang] diagnose_as attribute for Fortify diagnosing like builtins.

serge-sans-paille added inline comments. Comment at: clang/include/clang/Basic/Attr.td:3822 +def DiagnoseAs : InheritableAttr { + let Spellings = [Clang<"diagnose_as">]; + let Args = [ExprArgument<"Function">, aaron.ballman wrote: > george.burgess.iv wrote: > >

[PATCH] D112059: Fix inline builtin handling in case of redefinition

serge-sans-paille added a comment. I second @aaron.ballman there. I compiled the sqlite3.c amalgamation, -O0, with both approach, measuring the number of instructions as gathered by `valgrind --tool=callgrind` - when walking redecls:9001630039 instructions, I changed the implementation

[PATCH] D112059: Fix inline builtin handling in case of redefinition

serge-sans-paille updated this revision to Diff 383241. serge-sans-paille added a comment. Re-uploading previous version that walks redef, with a slight change in the walking algorithm. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112059/new/ https://reviews.llvm.org/D112059 Files:

[PATCH] D112913: Misleading bidirectional detection

serge-sans-paille created this revision. Herald added subscribers: carlosgalvezp, mgorny. serge-sans-paille requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. This patch implements detection of incomplete bidirectional sequence wit

[PATCH] D112914: Misleading identifier detection

serge-sans-paille created this revision. Herald added subscribers: carlosgalvezp, mgorny. serge-sans-paille requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Detect identifiers with right-to-left ordering through clang-tidy. It de

[PATCH] D112916: Confusable identifiers detection

serge-sans-paille created this revision. Herald added subscribers: carlosgalvezp, mgrang, mgorny. serge-sans-paille requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. This patch implements detection of confusable identifiers within

[PATCH] D112059: Fix inline builtin handling in case of redefinition

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6bfc85c217e4: Fix inline builtin handling in case of redefinition (authored by serge-sans-paille). Changed prior to commit: https://reviews.llvm.o

[PATCH] D112914: Misleading identifier detection

serge-sans-paille updated this revision to Diff 384006. serge-sans-paille added a comment. - fix formatting - added documentation - *not* doing the extra work wrt. unicode error recovery CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112914/new/ https://reviews.llvm.org/D112914 Files:

<    1   2   3   4   5   6   7   8   9   >