[PATCH] D150499: [AST] Initialized data after TypeSourceInfo

vitalybuka added reviewers: kstoimenov, thurston. vitalybuka added a comment. Oh, I rerun msan bot locally and it looked like issue dissipated, but I probably checked wrong logs. So I enabled -Oz on the bot, to catch more bugs, but the issue is still there https://lab.llvm.org/buildbot/#/builder

[PATCH] D150499: [AST] Initialized data after TypeSourceInfo

This revision was automatically updated to reflect the committed changes. Closed by commit rG4498663f3de0: [AST] Initialized data after TypeSourceInfo (authored by vitalybuka). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150499/new/ https://review

[PATCH] D151593: [MemProf] Clean up MemProf instrumentation pass invocation

vitalybuka added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:995 +// TODO: Consider passing the MemoryProfileOutput to the pass builder via +// the PGOOptions, and set this up there. if this is registerOptimizerLastEPCallback, it can

[PATCH] D151593: [MemProf] Clean up MemProf instrumentation pass invocation

vitalybuka added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:995 +// TODO: Consider passing the MemoryProfileOutput to the pass builder via +// the PGOOptions, and set this up there. tejohnson wrote: > vitalybuka wrote: > > if this is

[PATCH] D151593: [MemProf] Clean up MemProf instrumentation pass invocation

vitalybuka accepted this revision. vitalybuka added a comment. This revision is now accepted and ready to land. Either way is fine Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151593/new/ https://reviews.llvm.org/D151593 _

[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

vitalybuka added a comment. In D122215#4118516 , @asb wrote: > @pmatos and I have tried and failed to reproduce the assert in the stage3 > msan build locally (both of us on separate machines, different environments). > We've reached out to @vitalybuka v

[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

vitalybuka updated this revision to Diff 498550. vitalybuka added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122215/new/ https://reviews.llvm.org/D122215 Files: clang/include/clang/AST/ASTContext.h clang/include/clan

[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG890146b19206: [WebAssembly] Initial support for reference type externref in clang (authored by pmatos, committed by vitalybuka). Repository: rG LL

[PATCH] D142890: [clangd] Add config option for fast diagnostics mode

vitalybuka added subscribers: kstoimenov, vitalybuka. vitalybuka added a comment. One of your patches likely introduced UB https://lab.llvm.org/buildbot/#/builders/85/builds/14558 Can you please take a look? FYI, @kstoimenov Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D143467: [PowerPC] Add target feature requirement to builtins

vitalybuka added a comment. Breaks these bots? https://lab.llvm.org/buildbot/#/builders/18/builds/8898 https://lab.llvm.org/buildbot/#/builders/19/builds/16412 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143467/new/ https://reviews.llvm.org/D1434

[PATCH] D143675: Discussion: Darwin Sanitizers Stable ABI

vitalybuka added inline comments. Comment at: compiler-rt/lib/asan_abi/asan_abi_shim.cpp:62 +void __asan_init(void) { +assert(sizeof(uptr) == 8); +assert(sizeof(u64) == 8); static_assert Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D150492: [AST] Initialized local counter

vitalybuka created this revision. Herald added a project: All. vitalybuka requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. I assume it's optional and ReadAST does not have to set the counter on success. Repository: rG LLVM Github Monorep

[PATCH] D150499: [AST] Initialized data after TypeSourceInfo

vitalybuka created this revision. Herald added a project: All. vitalybuka requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. There is no initialization of the data between allocation and first getBeginLoc call. llvm-project/clang/lib/AST/ASTC

[PATCH] D150499: [AST] Initialized data after TypeSourceInfo

vitalybuka updated this revision to Diff 521847. vitalybuka added a comment. use 0 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150499/new/ https://reviews.llvm.org/D150499 Files: clang/include/clang/AST/Type.h clang/include/clang/AST/TypeLoc

[PATCH] D150504: [AST] Construct Capture objects before use

vitalybuka created this revision. Herald added a project: All. vitalybuka requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Msan reports https://reviews.llvm.org/P8308 So the reason is if PointerIntPair is not properly constructed, setPointer

[PATCH] D150499: [AST] Initialized data after TypeSourceInfo

vitalybuka added a comment. In D150499#4341115 , @rjmccall wrote: > This memory is supposed to be initialized when we copy the `TypeLoc`. Are > you observing that not happening? Yes. There is the msan report in the description. Repository: rG LLVM

[PATCH] D148785: -fsanitize=function: use type hashes instead of RTTI objects

vitalybuka added a comment. Is possible to split the patch into smaller ones? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148785/new/ https://reviews.llvm.org/D148785 ___ cfe-commits mailing list cfe-c

[PATCH] D150492: [AST] Initialize local counter

vitalybuka added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150492/new/ https://reviews.llvm.org/D150492 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D150492: [AST] Initialize local counter

This revision was automatically updated to reflect the committed changes. Closed by commit rGe8cd04624e50: [AST] Initialize local counter (authored by vitalybuka). Changed prior to commit: https://reviews.llvm.org/D150492?vs=521819&id=523292#toc Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D143675: Discussion: Darwin Sanitizers Stable ABI

vitalybuka added a comment. In D143675#4281673 , @rsundahl wrote: > @kcc @eugenis @MaskRay @vitalybuka Ok to go with this? All new functionality > is under the added flag so not expecting any surprises. I don't have reasons to block this. ===

[PATCH] D143675: Discussion: Darwin Sanitizers Stable ABI

vitalybuka accepted this revision. vitalybuka added 2 blocking reviewer(s): eugenis, MaskRay. vitalybuka added a comment. In D143675#4310734 , @rsundahl wrote: > @kcc @eugenis @MaskRay @vitalybuka Ok to go with this? All new functionality > is under the

[PATCH] D152412: [clang/test/CodeGen] Add test coverage for VarBypassDetector handling init statements and condition variables in switch clauses

This revision was automatically updated to reflect the committed changes. Closed by commit rGb03abbb537e5: [clang/test/CodeGen] Add test coverage for VarBypassDetector handling init… (authored by dwang, committed by vitalybuka). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D152650: [docs] Improve UndefinedBehaviorSanitizer.rst

vitalybuka accepted this revision. vitalybuka added inline comments. This revision is now accepted and ready to land. Comment at: clang/docs/UndefinedBehaviorSanitizer.rst:62 + # -fno-sanitize=undefined nullifies the previous -fsanitize=undefined. + % clang -fsanitize=undefined

[PATCH] D139296: [msan][CodeGen] Set noundef for C return value

vitalybuka created this revision. Herald added a project: All. vitalybuka requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Msan needs noundef consistency between interface and implementation. If we call C++ from C we can have noundef on C++

[PATCH] D139296: [msan][CodeGen] Set noundef for C return value

vitalybuka updated this revision to Diff 479992. vitalybuka added a comment. new line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139296/new/ https://reviews.llvm.org/D139296 Files: clang/lib/CodeGen/CGCall.cpp clang/test/CodeGen/cleanup-des

[PATCH] D139296: [msan][CodeGen] Set noundef for C return value

vitalybuka added a comment. In D139296#3972142 , @kda wrote: > Is there a risk of this being too strict for standard C? > > Should there be a test case for our specific problem? (C calling C++) Probably not. It's cross module mismatch. To reproduce we n

[PATCH] D139296: [msan][CodeGen] Set noundef for C return value

vitalybuka updated this revision to Diff 480335. vitalybuka added a comment. remove redundant check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139296/new/ https://reviews.llvm.org/D139296 Files: clang/lib/CodeGen/CGCall.cpp clang/test/CodeG

[PATCH] D139296: [msan][CodeGen] Set noundef for C return value

vitalybuka marked an inline comment as done. vitalybuka added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:1828 !Module.MayDropFunctionReturn(Module.getContext(), RetTy) || Module.getLangOpts().Sanitize.has(SanitizerKind::Memory) || Modu

[PATCH] D139296: [msan][CodeGen] Set noundef for C return value

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. vitalybuka marked an inline comment as done. Closed by commit rG166c8cccde01: [msan][CodeGen] Set noundef for C return value (authored by vitalybuka). Repository: rG

[PATCH] D119621: [SanitizerCoverage] Add instrumentation callbacks for FP cmp instructions

vitalybuka requested changes to this revision. vitalybuka added a comment. This revision now requires changes to proceed. Herald added a subscriber: Enna1. Please update if it's still relevant CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119621/new/ https://reviews.llvm.org/D119621 __

[PATCH] D115103: Leak Sanitizer port to Windows

vitalybuka requested changes to this revision. vitalybuka added a comment. This revision now requires changes to proceed. Herald added a subscriber: Enna1. Is this still relevant? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115103/new/ https://reviews.llvm.org/D115103 ___

[PATCH] D125195: [asan][ARMCXXABI] Added missing asan poison array cookie hooks.

vitalybuka requested changes to this revision. vitalybuka added a comment. This revision now requires changes to proceed. Herald added a subscriber: Enna1. Is this still relevant? If so, I would recommend to split ItaniumCXXABI from asan changes. Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D115103: Leak Sanitizer port to Windows

vitalybuka added a comment. You probably can try to finish pure lsan, and then get back to lsan+asan. So if you continue to work please send smaller and ready pieces for review? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115103/new/ https://reviews.llvm.org/D115103 _

[PATCH] D129448: [CodeGen][Asan] Emit lifetime intrinsic for bypassed label

vitalybuka requested changes to this revision. vitalybuka added a comment. This revision now requires changes to proceed. Abandon? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129448/new/ https://reviews.llvm.org/D129448 _

[PATCH] D15075: No error for conflict between inputs\outputs and clobber list

vitalybuka added a comment. These patches break asan tests: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux/builds/528/steps/check-asan%20in%20gcc%20build/logs/stdio Repository: rL LLVM https://reviews.llvm.org/D15075 ___ cfe-commits ma

[PATCH] D28242: [ubsan] Minimize size of data for type_mismatch (Redo of D19667)

vitalybuka added a comment. LGTM, but I am not the owner. https://reviews.llvm.org/D28242 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42017: Link sanitized programs on NetBSD with -lkvm

vitalybuka accepted this revision. vitalybuka added a comment. This revision is now accepted and ready to land. LGTM, but please update the summary and git/svn patch description Repository: rL LLVM https://reviews.llvm.org/D42017 ___ cfe-commits

[PATCH] D42017: Link sanitized programs on NetBSD with -lkvm

vitalybuka requested changes to this revision. vitalybuka added a comment. This revision now requires changes to proceed. Please update the summary. No need to define kvm. Probably just few example of essential functions needed by sanitizers. Repository: rL LLVM https://reviews.llvm.org/D420

[PATCH] D42680: [ThinLTO] Ignore -fthinlto-index= for non-ThinLTO files

vitalybuka created this revision. vitalybuka added reviewers: pcc, tejohnson. Herald added subscribers: eraman, inglorion, mehdi_amini. Sometimes -flto=thin can produce regular LTO object files. Then backend may receive them with -fthinlto-index= flag. Previous behavior was to report error in this

[PATCH] D42644: [asan] Intercept std::rethrow_exception indirectly.

vitalybuka added a comment. Could you please reformat it? With git I usually use: git clang-format -f --style=file HEAD^ Repository: rCRT Compiler Runtime https://reviews.llvm.org/D42644 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D42644: [asan] Intercept std::rethrow_exception indirectly.

vitalybuka added a comment. I would not worry about cross platform here. You can patch just Linux and whoever have access (and issues) on other platforms can send a patch with similar changes. Mac should use libc++. I'd put the test outside of Posix, and mark failing platforms as "// XFAIL:", t

[PATCH] D42680: [ThinLTO] Ignore -fthinlto-index= for non-ThinLTO files

vitalybuka updated this revision to Diff 132701. vitalybuka added a comment. skip full LTO objects https://reviews.llvm.org/D42680 Files: clang/include/clang/CodeGen/BackendUtil.h clang/lib/CodeGen/BackendUtil.cpp clang/lib/CodeGen/CodeGenAction.cpp clang/test/CodeGen/thinlto_backend.ll

[PATCH] D42680: [ThinLTO] Ignore object files with no ThinLTO modules if -fthinlto-index= is set

vitalybuka added a comment. PTAL https://reviews.llvm.org/D42680 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42680: [ThinLTO] Ignore object files with no ThinLTO modules if -fthinlto-index= is set

vitalybuka updated this revision to Diff 132702. vitalybuka marked an inline comment as done. vitalybuka added a comment. comment https://reviews.llvm.org/D42680 Files: clang/include/clang/CodeGen/BackendUtil.h clang/lib/CodeGen/BackendUtil.cpp clang/lib/CodeGen/CodeGenAction.cpp clang/

[PATCH] D27420: Fix stack-use-after-scope in EvaluateImplicitExceptionSpec

vitalybuka created this revision. vitalybuka added a reviewer: rsmith. vitalybuka added subscribers: cfe-commits, aizatsky. getExceptionSpec returns structure with pointers to temporarily object created by computeImplicitExceptionSpec. https://reviews.llvm.org/D27420 Files: lib/Sema/SemaDeclC

[PATCH] D27420: Fix stack-use-after-scope in EvaluateImplicitExceptionSpec

This revision was automatically updated to reflect the committed changes. Closed by commit rL288685: Fix stack-use-after-scope in EvaluateImplicitExceptionSpec (authored by vitalybuka). Changed prior to commit: https://reviews.llvm.org/D27420?vs=80290&id=80292#toc Repository: rL LLVM https:

[PATCH] D27422: Fix stack-use-after-scope in CheckExplicitlyDefaultedMemberExceptionSpec

vitalybuka created this revision. vitalybuka added a reviewer: rsmith. vitalybuka added subscribers: cfe-commits, aizatsky. Similar to r288685. getExceptionSpec returned structure with pointers to temporarily object created by computeImplicitExceptionSpec. https://reviews.llvm.org/D27422 Files:

[PATCH] D27422: Fix stack-use-after-scope in CheckExplicitlyDefaultedMemberExceptionSpec

This revision was automatically updated to reflect the committed changes. Closed by commit rL288689: Fix stack-use-after-scope in CheckExplicitlyDefaultedMemberExceptionSpec (authored by vitalybuka). Changed prior to commit: https://reviews.llvm.org/D27422?vs=80299&id=80300#toc Repository: r

[PATCH] D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default

vitalybuka added a comment. In D105169#3248124 , @sammccall wrote: > Ah, this seems to be coming from the buildbot configuration. > > https://github.com/llvm/llvm-zorg/blob/38ab06456f7302b4eab53e5b6f1e2eaf4f127132/zorg/buildbot/builders/sanitizers/buildbo

[PATCH] D117622: cleanups from 1b1c8d83d3567a60280291c0adb95d1d60335509

vitalybuka added a comment. I recommend to delay this from some time until we sure it's not going to be reverted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117622/new/ https://reviews.llvm.org/D117622 _

[PATCH] D117622: cleanups from 1b1c8d83d3567a60280291c0adb95d1d60335509

vitalybuka added inline comments. Comment at: compiler-rt/test/msan/noundef_analysis.cpp:5 // RUN: FileCheck %s < %t.out -// RUN: %clangxx_msan %s -disable-noundef-analysis -s -fsanitize-memory-param-retval -o %t && not %run %t >%t.out 2>&1 +// RUN: %clangxx_msan %s -disable-no

[PATCH] D118361: clang-format: [JS] sort import aliases.

vitalybuka added a comment. After this patch https://lab.llvm.org/buildbot/#/builders/74/builds/9049/steps/15/logs/stdio Note: Google Test filter = SortImportsTestJS.ImportEqAliases [==] Running 1 test from 1 test suite. [--] Global test environment set-up. [--] 1

[PATCH] D118361: clang-format: [JS] sort import aliases.

vitalybuka added a comment. reverted with f750c3d95a0c8bf1d21380ae753fce12010a7561 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118361/new/ https://reviews.llvm.org/D118361 __

[PATCH] D101214: Disable deprecated-copy warnings on various LLVM code to bring the bot back to green

This revision was automatically updated to reflect the committed changes. Closed by commit rG504eee28fe0f: Disable deprecated-copy warnings on various LLVM code to bring the bot back to… (authored by nemanjai, committed by vitalybuka). Changed prior to commit: https://reviews.llvm.org/D101214?

[PATCH] D99381: [compiler-rt][hwasan] Add Fuchsia-specific sanitizer platform limits

vitalybuka added inline comments. Comment at: compiler-rt/lib/hwasan/hwasan_interceptors.cpp:28 +#if SANITIZER_POSIX #include "sanitizer_common/sanitizer_platform_limits_posix.h" +#endif we usually include them unconditionaly and .h itself has guards against un

[PATCH] D101122: introduce flag -fsanitize-address-detect-stack-use-after-return-mode. No functional change.

vitalybuka added a subscriber: delcypher. vitalybuka added a comment. In D101122#2711962 , @joerg wrote: > There are two approaches that work for reviewing: starting from clang and > going down or starting from compiler-rt and going up the layers. I'd pr

[PATCH] D92078: [asan] Default to -asan-use-private-alias=1

vitalybuka requested changes to this revision. vitalybuka added a comment. This revision now requires changes to proceed. I assume we are not moving forward with this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92078/new/ https://reviews.l

[PATCH] D96203: [clang][patch] Modify sanitizer options names: renaming blacklist to blocklist

vitalybuka requested changes to this revision. vitalybuka added a comment. This revision now requires changes to proceed. Is this abandoned patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96203/new/ https://reviews.llvm.org/D96203 ___

[PATCH] D101122: introduce flag -fsanitize-address-detect-stack-use-after-return-mode. No functional change.

vitalybuka added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.def:225-228 +ENUM_CODEGENOPT(SanitizeAddressDetectStackUseAfterReturnMode, +llvm::AsanDetectStackUseAfterReturnMode, 2, +llvm::AsanDetectStackUseAfterReturnMode:

[PATCH] D99381: [compiler-rt][hwasan] Add Fuchsia-specific sanitizer platform limits

vitalybuka added a comment. In D99381#2721619 , @phosek wrote: > What I think @vitalybuka meant is keeping > `sanitizer_platform_limits_fuchsia.h` as you had it, but including it > unconditionally. Since the entire file is wrapped in `#if SANITIZER_FUCHS

[PATCH] D101491: [ASan] Rename `-fsanitize-address-destructor-kind=` to drop the `-kind` suffix.

vitalybuka accepted this revision. vitalybuka added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang/docs/ClangCommandLineReference.rst:873 -.. option:: -fsanitize-address-destructor-kind= +.. option:: -fsanitize-address-destructor=

[PATCH] D116634: enable msan-eager-checks with -fsanitize-memory-param-retval.

vitalybuka added a comment. this patch depends on D116633 , but D116633 is useless without this one a better patch order is : 1. llvm 2. clang 3. compiler-rt (but if it's just test which uses clang flag it should be OK merge w

[PATCH] D116633: Add -fsanitize-address-param-retval to clang.

vitalybuka added a subscriber: eugenis. vitalybuka added inline comments. Comment at: clang/include/clang/Driver/Options.td:1675 + PosFlag, NegFlag, + BothFlags<[], "eager param-retval uninitialized use detection in MemorySanitizer">>, +Group; Mayb

[PATCH] D116633: Add -fsanitize-address-param-retval to clang.

vitalybuka added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2384 +if ((CodeGenOpts.EnableNoundefAttrs || + CodeGenOpts.SanitizeMemoryParamRetval) && +ArgNoUndef) vitalybuka wrote: > @eugenis Would be better to force CodeGenOpts.

[PATCH] D116701: Respect -fsanitize-memory-param-retval flag.

vitalybuka added a comment. >> Implementation of flag introduced in https://reviews.llvm.org/D116633 It's not implementation, the goal of -sanitize-memory-param-retval to setup Msan pass with proper parameters This part usability improvement to avoid one flag, which I slightly like, but @eugeni

[PATCH] D116633: Add -fsanitize-address-param-retval to clang.

vitalybuka added a comment. we probably should to move clang parts from D116634 into this patch? Comment at: clang/include/clang/Basic/CodeGenOptions.def:234 ///< destructors are emitted. +CODEGEN

[PATCH] D116633: Add -fsanitize-address-param-retval to clang.

vitalybuka added a comment. I don't think we need -Xclang? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116633/new/ https://reviews.llvm.org/D116633 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D116827: Don't pass uninitialized QueryKind

vitalybuka created this revision. vitalybuka added reviewers: kda, eugenis. Herald added subscribers: usaxena95, kadircet, arphaman. vitalybuka requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Even if findImplementors does not us

[PATCH] D116828: Initialize HighlightingsBuilder::Resolver

vitalybuka created this revision. vitalybuka added reviewers: kda, eugenis. Herald added subscribers: usaxena95, kadircet, arphaman. vitalybuka requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Detected by msan with: -Xclang -enab

[PATCH] D116827: Don't pass uninitialized QueryKind

vitalybuka added a comment. In D116827#3228524 , @kda wrote: > This seems to introduce a new branch, should there be a new unit test in: > XRefsTests.cpp? It's not functional change, test should not be able to see a difference after this patch.

[PATCH] D116827: Don't pass uninitialized QueryKind

vitalybuka added a comment. In D116827#3228594 , @vitalybuka wrote: > In D116827#3228524 , @kda wrote: > >> This seems to introduce a new branch, should there be a new unit test in: >> XRefsTests.cpp? > > It's n

[PATCH] D116827: Don't pass uninitialized QueryKind

vitalybuka added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:311 llvm::StringRef MainFilePath) { if (IDs.empty() || !Index) return {}; here Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D116828: Initialize HighlightingsBuilder::Resolver

This revision was automatically updated to reflect the committed changes. Closed by commit rG669eb6004670: Initialize HighlightingsBuilder::Resolver (authored by vitalybuka). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116828/new/ https://reviews.

[PATCH] D116827: Don't pass uninitialized QueryKind

vitalybuka updated this revision to Diff 398271. vitalybuka added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116827/new/ https://reviews.llvm.org/D116827 Files: clang-tools-extra/clangd/XRefs.cpp Index: clang-tools-extra/c

[PATCH] D116827: Don't pass uninitialized QueryKind

This revision was automatically updated to reflect the committed changes. Closed by commit rG244dd2913a43: Don't pass uninitialized QueryKind (authored by vitalybuka). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116827/new/ https://reviews.llvm.or

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

vitalybuka added a comment. In D114639#3228704 , @rnk wrote: > In D114639#3199458 , @RKSimon wrote: > >> @rnk I'm not certain but I think the only buildbot still using VS2017 is >> windows-gcebot2 ? > > Yes, it p

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

vitalybuka added a comment. >> https://lab.llvm.org/buildbot/#/builders/sanitizer-windows >> https://lab.llvm.org/buildbot/#/builders/clang-x64-windows-msvc Actually these were already on VS2019, version 16.8, so I only updated them both to 16.11. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D117078: Minor adjustment in order of noundef analysis to be a bit more optimal (when disabled).

vitalybuka accepted this revision. vitalybuka added a comment. This revision is now accepted and ready to land. my editor recommends me to keep git titles <50 chars Maybe something shorter with exactly the same meaning "[NFC] Optimize noundef analysis condition" Comment at: cla

[PATCH] D116633: Add -fsanitize-address-param-retval to clang.

vitalybuka accepted this revision. vitalybuka added a comment. This revision is now accepted and ready to land. LGTM with few nits Comment at: clang/lib/CodeGen/BackendUtil.cpp:362 + MemorySanitizerOptions{TrackOrigins, Recover, CompileKernel, +

[PATCH] D117293: enable noundef analysis with -fsanitize-memory-param-retval

vitalybuka accepted this revision. vitalybuka added a comment. This revision is now accepted and ready to land. Nice! >> This completes the work found in: It's too late for this set of patches, but phabricator supports "Depends on" comments (I guess only of the first patch upload), and manual

[PATCH] D117293: enable noundef analysis with -fsanitize-memory-param-retval

vitalybuka added a comment. Just noticed, -enable-noundef-analysis is missing tests undef llvm/llvm-project/clang/test/Driver/ Can you add few near maybe before llvm-project/clang/test/Driver/clang_f_opts.c:531 (just before discard-value-names tests) Repository: rG LLVM Github Monorepo CHA

[PATCH] D117293: enable noundef analysis with -fsanitize-memory-param-retval

vitalybuka added a comment. In D117293#3243772 , @vitalybuka wrote: > Just noticed, -enable-noundef-analysis is missing tests undef > llvm/llvm-project/clang/test/Driver/ > Can you add few near maybe before > llvm-project/clang/test/Driver/clang_f_opts

[PATCH] D116633: Add -fsanitize-address-param-retval to clang.

vitalybuka added inline comments. Comment at: clang/test/Driver/fsanitize-memory-param-retval.c:8-9 + +// RUN: %clang -target aarch64-linux-gnu -fsyntax-only %s -fsanitize=memory -fsanitize-memory-param-retval -c -### 2>&1 | FileCheck --check-prefix=11 %s +// 11: "-fsanitize-mem

[PATCH] D117293: enable noundef analysis with -fsanitize-memory-param-retval

vitalybuka added a comment. In D117293#3244668 , @kda wrote: > In D117293#3243735 , @vitalybuka > wrote: > >> Nice! >> This completes the work found in: >> >> It's too late for this set of patches, but phabr

[PATCH] D117293: enable noundef analysis with -fsanitize-memory-param-retval

vitalybuka added a comment. To clarify: LGTM as-is, I don't expect any changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117293/new/ https://reviews.llvm.org/D117293 ___ cfe-commits mailing list cfe

[PATCH] D113620: Skip exception cleanups when the innermost scope is EHTerminateScope.

vitalybuka added a comment. Is this from the patch https://lab.llvm.org/buildbot/#/builders/127/builds/22789/steps/8/logs/stdio FAILED: projects/compiler-rt/lib/sanitizer_common/tests/SANITIZER_TEST_OBJECTS.sanitizer_leb128_test.cpp.x86_64.o cmd.exe /C "cd /D C:\b\slave\sanitizer-windows

[PATCH] D99484: [cmake] Use `GNUInstallDirs` to support custom installation dirs.

vitalybuka added a comment. It breaks multiple bots. https://lab.llvm.org/buildbot/#/builders/37/builds/9960 https://lab.llvm.org/buildbot/#/builders/77/builds/13245 https://lab.llvm.org/buildbot/#/builders/169/builds/5409 https://lab.llvm.org/buildbot/#/builders/105/builds/19941 Can you please f

[PATCH] D115103: Leak Sanitizer port to Windows

vitalybuka added a reviewer: rnk. vitalybuka added a subscriber: rnk. vitalybuka added a comment. LGTM in general, but it can be cut into smaller patches. + @rnk for Windows suff Comment at: compiler-rt/lib/lsan/lsan.h:20 +#elif SANITIZER_WINDOWS +# include "lsan_win.h" #end

[PATCH] D115103: Leak Sanitizer port to Windows

vitalybuka added a comment. In D115103#3176852 , @clemenswasser wrote: > Split this patch up into multiple smaller ones: > > - D115186 > - D115204 > - D115262

[PATCH] D110215: [C++2a] [Module] Support extern C/C++ semantics

vitalybuka added a comment. llvm-project/clang/lib/Sema/SemaModule.cpp:715:70: warning: missing field 'OuterVisibleModules' initializer [-Wmissing-field-initializers] ^ Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

vitalybuka added a comment. > I still don't see a need for them to be updated in lock step, especially for > Visual Studio which tends to be quite different from other toolchains, but I > can see the use of the bumps occurring within the same release version of > llvm if its feasible. It's bet

[PATCH] D115103: Leak Sanitizer port to Windows

vitalybuka added inline comments. Comment at: compiler-rt/lib/lsan/lsan_allocator.h:52-53 -#if defined(__mips64) || defined(__aarch64__) || defined(__i386__) || \ -defined(__arm__) || SANITIZER_RISCV64 || defined(__hexagon__) +#if defined(__mips64) || defined(__aarch64__) |

[PATCH] D116064: [WIP] Test for noundef ignore list

vitalybuka created this revision. vitalybuka added a reviewer: kda. vitalybuka requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D116064 Files: clang/test/CodeGen/attr-noundef

[PATCH] D116066: [WIP] Ignore list for noundef

vitalybuka created this revision. vitalybuka added a reviewer: kda. Herald added a subscriber: dexonsmith. vitalybuka requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Depends on D116064 . Repository: rG

[PATCH] D116066: [WIP] Ignore list for noundef

vitalybuka planned changes to this revision. vitalybuka added a comment. Not ready for review, we probably don't needs this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116066/new/ https://reviews.llvm.org/D116066 _

[PATCH] D115103: Leak Sanitizer port to Windows

vitalybuka added a comment. In D115103#3207150 , @clemenswasser wrote: > @vitalybuka could you or someone else help me get the lsan tests running on > Windows? > For example lets look at > `compiler-rt\test\lsan\TestCases\leak_check_at_exit.cpp` (and b

[PATCH] D116182: [ASan] Moved optimized callbacks into a separate library.

vitalybuka accepted this revision. vitalybuka added a comment. This revision is now accepted and ready to land. I suspect Driver part is going to be reverted a couple of time. Maybe extract it into a separate patch? Comment at: compiler-rt/lib/asan/CMakeLists.txt:167 if(APP

[PATCH] D115103: Leak Sanitizer port to Windows

vitalybuka added a comment. In D115103#3207210 , @clemenswasser wrote: > The problem is, that `LSAN_BASE` is not always `use_stacks=0:use_registers=0`. Off-cause , I am asking to replace with correct value each test. > Also there are many test cases, w

[PATCH] D115103: Leak Sanitizer port to Windows

vitalybuka added a comment. In D115103#3207867 , @clemenswasser wrote: > @vitalybuka I have now removed all `LSAN_BASE` occurrences. > However the invocations of the compiled test executables don't seem to work > either. > This doesn't work: > `// RUN:

[PATCH] D115103: Leak Sanitizer port to Windows

vitalybuka added a comment. In D115103#3209326 , @clemenswasser wrote: > @vitalybuka > No `check-asan` **doesn't work** for me. It just hangs forever and does > absolutely nothing. No output, nothing showing up in Task Manager with high > CPU usage or

<    2   3   4   5   6   7   8   >