vitalybuka accepted this revision.
vitalybuka added a comment.
This revision is now accepted and ready to land.
LGTM with few nits
================
Comment at: clang/lib/CodeGen/BackendUtil.cpp:362
+ MemorySanitizerOptions{TrackOrigins, Recover, CompileKernel,
+ CGOpts.SanitizeMemoryParamRetval != 0}));
----------------
we use implicit cast mostly, e.g. addAddressSanitizerPasses
================
Comment at: clang/test/CodeGen/param-retval-eager-checks.c:1
+// RUN: %clang -target x86_64-linux-gnu -S -emit-llvm -fsanitize=memory -o -
%s | \
+// RUN: FileCheck %s --check-prefix=CLEAN
----------------
Would you like to remove "| \" ?
80 char limit is not enforced on tests, multi line RUN: is even harder to read
then long line
================
Comment at: clang/test/CodeGen/param-retval-eager-checks.c:1
+// RUN: %clang -target x86_64-linux-gnu -S -emit-llvm -fsanitize=memory -o -
%s | \
+// RUN: FileCheck %s --check-prefix=CLEAN
----------------
vitalybuka wrote:
> Would you like to remove "| \" ?
> 80 char limit is not enforced on tests, multi line RUN: is even harder to
> read then long line
This dir contains tests for a lot of different componets
can you please add msan in name
e.g. "msan-param-retval.c"
================
Comment at: clang/test/CodeGen/param-retval-eager-checks.c:5
+// RUN: FileCheck %s --check-prefixes=NOUNDEF,NOUNDEF_ONLY
+// RUN: %clang -target x86_64-linux-gnu -S -emit-llvm -fsanitize=memory
-Xclang -enable-noundef-analysis -mllvm -msan-eager-checks -o - %s | \
+// RUN: FileCheck %s --check-prefixes=NOUNDEF,EAGER
----------------
we probably don't need mllvm test here
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116633/new/
https://reviews.llvm.org/D116633
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
