[PATCH] D118050: [analyzer] Different address spaces cannot overlap

vabridgers planned changes to this revision. vabridgers added a comment. I need to make a few changes. Please hold off any comments until the next patch, coming soon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118050/new/ https://reviews.llvm.o

[PATCH] D118050: [analyzer] Different address spaces cannot overlap

vabridgers updated this revision to Diff 419462. vabridgers added a comment. This revision is now accepted and ready to land. make assert function void, update summary Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118050/new/ https://reviews.llvm.o

[PATCH] D122841: [analyzer] Consider all addrspaces in null dereference check

vabridgers created this revision. vabridgers added reviewers: NoQ, steakhal, martong. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a project: All. vabridgers requested review

[PATCH] D122841: [analyzer] Consider all addrspaces in null dereference check

vabridgers added a comment. @steakhal, good question. Digging into the change archaeology, I see this change was made by Anna Zaks in Jan 2016 - see commit header below. There's no reference to a review with comments, and I don't know how to find those if they exist, perhaps @NoQ could help wit

[PATCH] D122841: [analyzer] Consider all addrspaces in null dereference check

vabridgers added a comment. Ahhh, I see - thanks for the references and discussion. I'll craft a patch to comprehend the use case and user-facing option, and post for review. We'll see how it goes :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D105974: [analyzer] Do not assume that all pointers have the same bitwidth as void*

vabridgers updated this revision to Diff 358792. vabridgers added a comment. address comments, add test case suggested by @bjope Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105974/new/ https://reviews.llvm.org/D105974 Files: clang/lib/StaticAn

[PATCH] D105974: [analyzer] Do not assume that all pointers have the same bitwidth as void*

vabridgers added a comment. Thanks for the updates, comments and the reproducer. I've added those in this update. If possible, I'd like to get this change accepted to avoid the crash we currently see, and I'll immediately follow up with the FIXMEs. Otherwise, I'll iterate quickly on the FIXMEs.

[PATCH] D105974: [analyzer] Do not assume that all pointers have the same bitwidth as void*

vabridgers updated this revision to Diff 358869. vabridgers added a comment. update test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105974/new/ https://reviews.llvm.org/D105974 Files: clang/lib/StaticAnalyzer/Core/SValBuilder.cpp clang

[PATCH] D105974: [analyzer] Do not assume that all pointers have the same bitwidth as void*

vabridgers updated this revision to Diff 359163. vabridgers added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105974/new/ https://reviews.llvm.org/D105974 Files: clang/lib/StaticAnalyzer/Core/SValBuilder.cpp clang/test/Anal

[PATCH] D106361: [clang-tidy] Fix crash and handle AttributedTypes in 'bugprone-easily-swappable-parameters'

vabridgers added a comment. This change fixed the downstream crash. Thanks for the quick turnaround! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106361/new/ https://reviews.llvm.org/D106361 ___ cfe-com

[PATCH] D119601: [analyzer] Refactor makeNull to makeNullWithWidth (NFC)

vabridgers added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/SValBuilder.h:378 +type = type->isReferenceType() + ? Context.getPointerType(type->getPointeeType()) + : type; NoQ wrote: > How do

[PATCH] D119601: [analyzer] Refactor makeNull to makeNullWithWidth (NFC)

vabridgers added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/SValBuilder.h:378 +type = type->isReferenceType() + ? Context.getPointerType(type->getPointeeType()) + : type; NoQ wrote: > vabrid

[PATCH] D119601: [analyzer] Refactor makeNull to makeNullWithWidth (NFC)

vabridgers updated this revision to Diff 416735. vabridgers marked an inline comment as not done. vabridgers added a comment. add updated test cases per comments from NoQ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119601/new/ https://reviews.llv

[PATCH] D119601: [analyzer] Refactor makeNull to makeNullWithWidth (NFC)

vabridgers added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/SValBuilder.h:378 +type = type->isReferenceType() + ? Context.getPointerType(type->getPointeeType()) + : type; vabridgers wrote: >

[PATCH] D120134: [analyzer] refactor makeIntValWithPtrWidth, remove getZeroWithPtrWidth (NFC)

vabridgers updated this revision to Diff 417300. vabridgers added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120134/new/ https://reviews.llvm.org/D120134 Files: clang/include/clang/StaticAnalyzer/Core/PathSensitive/BasicValu

[PATCH] D120134: [analyzer] refactor makeIntValWithPtrWidth, remove getZeroWithPtrWidth (NFC)

vabridgers added a comment. ping! @steakhal accepted, should we wait for @NoQ before landing? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120134/new/ https://reviews.llvm.org/D120134 ___ cfe-co

[PATCH] D120134: [analyzer] refactor makeIntValWithPtrWidth, remove getZeroWithPtrWidth (NFC)

vabridgers updated this revision to Diff 417415. vabridgers added a comment. update per @NoQ's latest comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120134/new/ https://reviews.llvm.org/D120134 Files: clang/include/clang/StaticAnalyzer/C

[PATCH] D120134: [analyzer] refactor makeIntValWithPtrWidth, remove getZeroWithPtrWidth (NFC)

vabridgers marked an inline comment as done. vabridgers added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/MallocChecker.cpp:2570 + State, TotalSize.castAs(), + svalBuilder.makeIntValWithPtrWidth(Arg1->getType(), 0)); NoQ wrote: > st

[PATCH] D122277: [analyzer] Fix crash in RangedConstraintManager.cpp

vabridgers created this revision. vabridgers added reviewers: martong, NoQ. Herald added subscribers: manas, steakhal, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a project: All. vabridgers requested revie

[PATCH] D122277: [analyzer] Fix crash in RangedConstraintManager.cpp

vabridgers updated this revision to Diff 417450. vabridgers added a comment. remove assert that was commented out Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122277/new/ https://reviews.llvm.org/D122277 Files: clang/lib/StaticAnalyzer/Core/Ran

[PATCH] D122277: [analyzer] Fix crash in RangedConstraintManager.cpp

vabridgers updated this revision to Diff 417525. vabridgers added a comment. update comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122277/new/ https://reviews.llvm.org/D122277 Files: clang/lib/StaticAnalyzer/Core/RangedConstraintManager.c

[PATCH] D122841: [analyzer] Consider all addrspaces in null dereference check

vabridgers updated this revision to Diff 421519. vabridgers added a comment. add option, retain legacy behavior per comments. update rst Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122841/new/ https://reviews.llvm.org/D122841 Files: clang/docs

[PATCH] D122841: [analyzer] Add option for AddrSpace in core.NullDereference check

vabridgers updated this revision to Diff 421521. vabridgers edited the summary of this revision. vabridgers added a comment. clean up a few debug edits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122841/new/ https://reviews.llvm.org/D122841 File

[PATCH] D122841: [analyzer] Add option for AddrSpace in core.NullDereference check

vabridgers added a comment. I'll address, thanks for the comments. Comment at: clang/docs/analyzer/checkers.rst:69-74 +Check for dereferences of null pointers. This checker specifically does +not report null pointer dereferences for x86 and x86-64 targets when the +address spac

[PATCH] D122841: [analyzer] Add option for AddrSpace in core.NullDereference check

vabridgers updated this revision to Diff 421706. vabridgers added a comment. update per @steakhal's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122841/new/ https://reviews.llvm.org/D122841 Files: clang/docs/analyzer/checkers.rst cla

[PATCH] D122841: [analyzer] Add option for AddrSpace in core.NullDereference check

vabridgers marked 3 inline comments as done. vabridgers added a comment. I believe all points have been addressed. Thanks for the comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122841/new/ https://reviews.llvm.org/D122841

[PATCH] D122841: [analyzer] Add option for AddrSpace in core.NullDereference check

vabridgers planned changes to this revision. vabridgers added a comment. Thanks for the the comments. I'll make the changes and resubmit. Please let me know your preferences for the test case (default vs pinned x86 or same). Best! Comment at: clang/lib/StaticAnalyzer/Checkers

[PATCH] D122841: [analyzer] Add option for AddrSpace in core.NullDereference check

vabridgers updated this revision to Diff 421759. vabridgers added a comment. This revision is now accepted and ready to land. update per @steakhal's latest comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122841/new/ https://reviews.llvm.org/

[PATCH] D122841: [analyzer] Add option for AddrSpace in core.NullDereference check

vabridgers marked 3 inline comments as done. vabridgers added a comment. The two small issues are addressed, I think the only outstanding issue is the question about the test case. Please let me know a preference and I'll implement accordingly. Best! Repository: rG LLVM Github Monorepo CHAN

[PATCH] D123464: [analyzer] Clean checker options from bool to DefaultBool (NFC)

vabridgers created this revision. vabridgers added reviewers: NoQ, steakhal. Herald added subscribers: manas, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: All. vabridgers requested review of this r

[PATCH] D119601: [analyzer] Refactor makeNull to makeNullWithWidth

vabridgers created this revision. vabridgers added reviewers: NoQ, martong. Herald added subscribers: manas, steakhal, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. vabridgers requested review of this revision. Herald ad

[PATCH] D118050: [analyzer] Different address spaces cannot overlap

vabridgers updated this revision to Diff 408104. vabridgers added a comment. Update after makeNull fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118050/new/ https://reviews.llvm.org/D118050 Files: clang/lib/StaticAnalyzer/Checkers/CStringC

[PATCH] D119601: [analyzer] Refactor makeNull to makeNullWithWidth

vabridgers added a comment. Thanks for the comments. I'll address and revert back soon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119601/new/ https://reviews.llvm.org/D119601 ___ cfe-commits mailing

[PATCH] D119601: [analyzer] Refactor makeNull to makeNullWithWidth

vabridgers added a comment. In D119601#3317317 , @NoQ wrote: >> steakhal performed systems testing across a large set of open source >> projects. > > I'm curious if any findings there caused you to make changes in the patch. If > so it'd be great to red

[PATCH] D119601: [analyzer] Refactor makeNull to makeNullWithWidth

vabridgers added a comment. I explored some test cases, and the rabbit hole gets deeper :) Continuing to explore. Best Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119601/new/ https://reviews.llvm.org/D119601 ___

[PATCH] D119601: [analyzer] Refactor makeNull to makeNullWithWidth

vabridgers updated this revision to Diff 409750. vabridgers added a comment. Address NoQ comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119601/new/ https://reviews.llvm.org/D119601 Files: clang/include/clang/StaticAnalyzer/Core/PathSensi

[PATCH] D122841: [analyzer] Add option for AddrSpace in core.NullDereference check

vabridgers updated this revision to Diff 424711. vabridgers added a comment. Update test cases, address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122841/new/ https://reviews.llvm.org/D122841 Files: clang/docs/analyzer/checkers.rst

[PATCH] D122841: [analyzer] Add option for AddrSpace in core.NullDereference check

vabridgers marked an inline comment as done. vabridgers added a comment. I believe all comments have been addressed. After discussion with @steakhal, we're leaning towards removing the DefaultBool class and refactoring in favor of the language native bool type - mainly because DefaultBool doesn'

[PATCH] D123464: [analyzer] Clean checker options from bool to DefaultBool (NFC)

vabridgers updated this revision to Diff 424720. vabridgers added a comment. refactor patch to remove DefaultBool, replace with bool as suggested Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123464/new/ https://reviews.llvm.org/D123464 Files: c

[PATCH] D123464: [analyzer] Clean checker options from bool to DefaultBool (NFC)

vabridgers added a comment. Hi @steakhal, I believe I've addressed the comments. Please have a look and let me know if this is what you were after. Best! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123464/new/ https://reviews.llvm.org/D123464 _

[PATCH] D122841: [analyzer] Add option for AddrSpace in core.NullDereference check

vabridgers updated this revision to Diff 424752. vabridgers added a comment. add back amdgcn cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122841/new/ https://reviews.llvm.org/D122841 Files: clang/docs/analyzer/checkers.rst clang/include

[PATCH] D124349: [analyzer] Get direct binding for specific punned case

vabridgers created this revision. vabridgers added reviewers: NoQ, steakhal. Herald added subscribers: manas, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: All. vabridgers requested review of this r

[PATCH] D124349: [analyzer] Get direct binding for specific punned case

vabridgers updated this revision to Diff 424796. vabridgers added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124349/new/ https://reviews.llvm.org/D124349 Files: clang/lib/StaticAnalyzer/Core/RegionStore.cpp clang/tes

[PATCH] D124349: [analyzer] Get direct binding for specific punned case

vabridgers added inline comments. Comment at: clang/test/Analysis/array-struct-region.c:362-366 +int array_struct_bitfield_1() { + BITFIELD_CAST ff = {0}; + BITFIELD_CAST *pff = &ff; + return *((int *)pff + 1); +} steakhal wrote: > ```lang=c > void array_struc

[PATCH] D124349: [analyzer] Get direct binding for specific punned case

vabridgers updated this revision to Diff 424844. vabridgers added a comment. update LIT per comments from @steakhal Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124349/new/ https://reviews.llvm.org/D124349 Files: clang/lib/StaticAnalyzer/Core/R

[PATCH] D124349: [analyzer] Get direct binding for specific punned case

vabridgers added a comment. polite ping to @NoQ and/or @martong. @steakhal is ok with this change, are you ok if I land this? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124349/new/ https://reviews.llvm.org/D124349 _

[PATCH] D124349: [analyzer] Get direct binding for specific punned case

vabridgers added a comment. Thanks for the comments! Per our discussion, I'll create a different test case with a pinned target and add the additional test case to be sure we see expected behavior. Best! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D124349: [analyzer] Get direct binding for specific punned case

vabridgers updated this revision to Diff 427106. vabridgers added a comment. Address comments from @martong Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124349/new/ https://reviews.llvm.org/D124349 Files: clang/lib/StaticAnalyzer/Core/RegionSto

[PATCH] D124349: [analyzer] Get direct binding for specific punned case

vabridgers updated this revision to Diff 427246. vabridgers added a comment. fix a stupid leftover cut/paste mistake in the test case :/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124349/new/ https://reviews.llvm.org/D124349 Files: clang/lib/

[PATCH] D124349: [analyzer] Get direct binding for specific punned case

vabridgers marked an inline comment as done. vabridgers added a comment. Thanks @martong. I fixed the "typo" :/, landing. Best! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124349/new/ https://reviews.llvm.org/D124349

[PATCH] D129269: [analyzer] Fix use of length in CStringChecker

vabridgers added a comment. Thanks @martong , I understand. I'll make the changes and resubmit. Best! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129269/new/ https://reviews.llvm.org/D129269 ___ cfe-co

[PATCH] D129269: [analyzer] Fix use of length in CStringChecker

vabridgers updated this revision to Diff 443658. vabridgers edited the summary of this revision. vabridgers added a comment. update per comments from @martong Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129269/new/ https://reviews.llvm.org/D12926

[PATCH] D86743: [analyzer] Ignore VLASizeChecker case that could cause crash

vabridgers created this revision. vabridgers added reviewers: balazske, NoQ, martong, baloghadamsoftware, Szelethus, gamesh411. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, xazax.hun. Herald added a project: clang. vabri

[PATCH] D86743: [analyzer] Ignore VLASizeChecker case that could cause crash

vabridgers added a comment. Thanks Balazs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86743/new/ https://reviews.llvm.org/D86743 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D93595: [analyzer] Prototype change to fix type punning of known SVals

vabridgers created this revision. Herald added subscribers: steakhal, ASDenysPetrov, martong, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun, whisperity. vabridgers requested review of this revision. Herald added a project: clang. Herald

[PATCH] D93595: [analyzer] Prototype change to fix type punning of known SVals

vabridgers updated this revision to Diff 312976. vabridgers added a comment. Clean up a few typos Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93595/new/ https://reviews.llvm.org/D93595 Files: clang/lib/StaticAnalyzer/Core/RegionStore.cpp cla

[PATCH] D93595: [analyzer] Prototype change to fix type punning of known SVals

vabridgers updated this revision to Diff 312977. vabridgers added a comment. Update commit header. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93595/new/ https://reviews.llvm.org/D93595 Files: clang/lib/StaticAnalyzer/Core/RegionStore.cpp cl

[PATCH] D93595: [analyzer] Fix extraction of punned and known SVals

vabridgers added a comment. This proposed change seems to address the referenced issues (https://bugs.llvm.org/show_bug.cgi?id=39032 and https://bugs.llvm.org/show_bug.cgi?id=44114). I believe the scalars test cases to be mostly complete, and the structures test cases to be at most a baseline

[PATCH] D93595: [analyzer] Fix extraction of punned and known SVals

vabridgers updated this revision to Diff 312996. vabridgers added a comment. Reduce scope of this initial change to just scalars Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93595/new/ https://reviews.llvm.org/D93595 Files: clang/lib/StaticAnal

[PATCH] D93595: [analyzer] Fix extraction of punned and known scalar SVals

vabridgers added a comment. Based on a suggestion from Balazs, I reduced the scope of the initial change to just scalars. There is one issue I'd like to hear comments on, and that's how to handle the case of extracting a bit field outside of the represented APInt. Currently, I'm returning Unkno

[PATCH] D93787: [analyzer] Fix crash caused by accessing empty map

vabridgers created this revision. vabridgers added a reviewer: Szelethus. Herald added subscribers: steakhal, ASDenysPetrov, martong, Charusso, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun, whisperity. vabridgers requested review of this revision. Herald a

[PATCH] D86743: [analyzer] Ignore VLASizeChecker case that could cause crash

vabridgers added a comment. @baloghadamsoftware , these changes do seem to help the case described. This patch isn't quite up to date, and needs to be integrated with changes from @balazske (my integration is hacky and needs to be cleaned up). I'll continue working on this, and get back to you.

[PATCH] D69726: [analyzer] DynamicSize: Store the dynamic size

vabridgers added subscribers: balazske, vabridgers. vabridgers added a comment. I was referred to this patch from https://reviews.llvm.org/D86743. I pulled this patch under review, brought it up to date and pushed to github at https://github.com/vabridgers/llvm-project-dev.git, branch: vla-fam-f

[PATCH] D86743: [analyzer] Ignore VLASizeChecker case that could cause crash

vabridgers added a comment. I pulled https://reviews.llvm.org/D69726, brought it up to date and pushed to github at https://github.com/vabridgers/llvm-project-dev.git, branch: vla-fam-fixes. Everything seems ok on this branch (LITs pass, reproducers from https://bugs.llvm.org/show_bug.cgi?id=47

[PATCH] D93595: [analyzer] Fix extraction of punned and known scalar SVals

vabridgers added a comment. Thanks for the comments, @NoQ . I'll carefully review and update. BTW, I found an old Bugzilla case that seems to relate to this change directly -> https://bugs.llvm.org/show_bug.cgi?id=2820. Once this change is evolved and accepted, I'll update that Bugzilla issue a

[PATCH] D93787: [analyzer] Fix crash caused by accessing empty map

vabridgers added a comment. Thanks @steakhal , I found your Bugzilla bug only after I submitted this patch. I'll revise based on your comments and resubmit. Best! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93787/new/ https://reviews.llvm.org/D9

[PATCH] D93787: [analyzer] Fix crash caused by accessing empty map

vabridgers added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/PlistDiagnostics.cpp:1241 if (TheTok.getIdentifierInfo() == VariadicParamII) { -TStream.injectRange(PrevParamMap.at(VariadicParamII)); +if (PrevParamMap.find(VariadicPar

[PATCH] D71714: [Sema] Fix -Warray-bounds false negative when casting an out-of-bounds array item

vabridgers added a subscriber: lattner. vabridgers added a comment. Gentle and polite ping :) Could someone have a look at this? @rsmith , or @lattner ? Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71714/new/ https://reviews.llvm.org/D71

[PATCH] D71714: [Sema] Fix -Warray-bounds false negative when casting an out-of-bounds array item

vabridgers added a comment. Thanks @rsmith, will do. Best! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71714/new/ https://reviews.llvm.org/D71714 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D93787: [analyzer] Fix crash caused by accessing empty map

vabridgers added a comment. Abandoning this change request in favor of @steakhal 's more comprehensive change @ https://reviews.llvm.org/D93222 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93787/new/ https://reviews.llvm.org/D93787 ___

[PATCH] D93787: [analyzer] Fix crash caused by accessing empty map

vabridgers abandoned this revision. vabridgers added a comment. Abandoning. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93787/new/ https://reviews.llvm.org/D93787 ___ cfe-commits mailing list cfe-commi

[PATCH] D110625: [analyzer] canonicalize special case of structure/pointer deref

vabridgers created this revision. vabridgers added reviewers: steakhal, martong. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity. vabridgers requested review of this revision. He

[PATCH] D110625: [analyzer] canonicalize special case of structure/pointer deref

vabridgers added a comment. Just an initial push to get this patch out there for review. I think this is pretty close. Thanks @steakhal and @martong for the debug session! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110625/new/ https://reviews.l

[PATCH] D110625: [analyzer] canonicalize special case of structure/pointer deref

vabridgers planned changes to this revision. vabridgers added a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110625/new/ https://reviews.llvm.org/D110625 ___ cfe-commits mailing list cfe-commi

[PATCH] D110625: [analyzer] canonicalize special case of structure/pointer deref

vabridgers updated this revision to Diff 375640. vabridgers added a comment. update test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110625/new/ https://reviews.llvm.org/D110625 Files: clang/lib/StaticAnalyzer/Core/Store.cpp clang/test/

[PATCH] D110625: [analyzer] canonicalize special case of structure/pointer deref

vabridgers added a comment. @martong, Thanks for yes for sure! I'll post an update soon with a few minor test improvements. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110625/new/ https://reviews.llvm.org/D110625 ___

[PATCH] D110625: [analyzer] canonicalize special case of structure/pointer deref

vabridgers updated this revision to Diff 375727. vabridgers added a comment. improve test cases per @martong Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110625/new/ https://reviews.llvm.org/D110625 Files: clang/lib/StaticAnalyzer/Core/Store.cp

[PATCH] D110625: [analyzer] canonicalize special case of structure/pointer deref

vabridgers updated this revision to Diff 375810. vabridgers added a comment. updates per @steakhal comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110625/new/ https://reviews.llvm.org/D110625 Files: clang/lib/StaticAnalyzer/Core/Store.cpp

[PATCH] D110625: [analyzer] canonicalize special case of structure/pointer deref

vabridgers marked 3 inline comments as done. vabridgers added a comment. Thanks @steakhal and @martong for the comments! The patch has been updated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110625/new/ https://reviews.llvm.org/D110625 ___

[PATCH] D110625: [analyzer] canonicalize special case of structure/pointer deref

vabridgers updated this revision to Diff 376374. vabridgers added a comment. update per comments from Denys Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110625/new/ https://reviews.llvm.org/D110625 Files: clang/lib/StaticAnalyzer/Core/Store.cpp

[PATCH] D110625: [analyzer] canonicalize special case of structure/pointer deref

vabridgers added a comment. @ASDenysPetrov , thank you for the comment. I added a test case per your suggestion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110625/new/ https://reviews.llvm.org/D110625 __

[PATCH] D110625: [analyzer] canonicalize special case of structure/pointer deref

vabridgers updated this revision to Diff 376450. vabridgers added a comment. added typedef case to C file for comparison, discussion Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110625/new/ https://reviews.llvm.org/D110625 Files: clang/lib/Stat

[PATCH] D110625: [analyzer] canonicalize special case of structure/pointer deref

vabridgers updated this revision to Diff 376452. vabridgers added a comment. move test case from cpp file to c file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110625/new/ https://reviews.llvm.org/D110625 Files: clang/lib/StaticAnalyzer/Core/S

[PATCH] D110625: [analyzer] canonicalize special case of structure/pointer deref

vabridgers updated this revision to Diff 376453. vabridgers added a comment. add const test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110625/new/ https://reviews.llvm.org/D110625 Files: clang/lib/StaticAnalyzer/Core/Store.cpp clang/te

[PATCH] D110625: [analyzer] canonicalize special case of structure/pointer deref

vabridgers added a comment. I moved the test cases from ptr-arith.cpp to ptr-arith - using to typedef, and created an extra test case that uses const. I believe this may address all concerns discussed thus far? Please let me know if we need anything more and I'll get it done. Best! Repository

[PATCH] D110625: [analyzer] canonicalize special case of structure/pointer deref

vabridgers updated this revision to Diff 376526. vabridgers added a comment. Use canonical types for comparison Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110625/new/ https://reviews.llvm.org/D110625 Files: clang/lib/StaticAnalyzer/Core/Store

[PATCH] D71714: [Sema] Fix -Warray-bounds false negative when casting an out-of-bounds array item

vabridgers added a comment. Thanks @thakis, per @rsmith 's suggestion in the review, I'll revert this. Apologies for the inconvenience. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71714/new/ https://reviews.llvm.org/D71714 _

[PATCH] D96905: Add missing fixed point literal CursorKind to cindex.py

vabridgers created this revision. Herald added a subscriber: arphaman. vabridgers requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Experimenting with parsing AST from Python using cindex.py, I discovered that a CursorKind defintion for fixed

[PATCH] D96905: Add missing fixed point literal CursorKind to cindex.py

vabridgers updated this revision to Diff 324470. vabridgers added a comment. Add test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96905/new/ https://reviews.llvm.org/D96905 Files: clang/bindings/python/clang/cindex.py clang/bindings/pyt

[PATCH] D96905: [libclang] Add missing fixed point literal CursorKind to cindex.py

vabridgers updated this revision to Diff 324473. vabridgers added a comment. Remove extraneous line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96905/new/ https://reviews.llvm.org/D96905 Files: clang/bindings/python/clang/cindex.py clang/bin

[PATCH] D96905: [libclang] Add missing fixed point literal CursorKind to cindex.py

vabridgers added a comment. Polite ping. This is a small and simple change, my only doubt is the test coverage. But frankly I see none of the literals are covered in any of the test cases (unless I'm missing something). Could I get some guidance on required test coverage for this simple change,

[PATCH] D107720: [analyzer] Cleanup a FIXME in SValBuilder.cpp

vabridgers created this revision. vabridgers added reviewers: NoQ, vsavchenko, ASDenysPetrov, steakhal, martong. Herald added subscribers: manas, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity. vabridgers requested review of

[PATCH] D107720: [analyzer] Cleanup a FIXME in SValBuilder.cpp

vabridgers added a comment. I'll add a test and repost. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107720/new/ https://reviews.llvm.org/D107720 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D107720: [analyzer] Cleanup a FIXME in SValBuilder.cpp

vabridgers updated this revision to Diff 365310. vabridgers added a comment. Add missing test case :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107720/new/ https://reviews.llvm.org/D107720 Files: clang/lib/StaticAnalyzer/Core/SValBuilder.cpp

[PATCH] D107720: [analyzer] Cleanup a FIXME in SValBuilder.cpp

vabridgers updated this revision to Diff 365546. vabridgers added a comment. add test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107720/new/ https://reviews.llvm.org/D107720 Files: clang/lib/StaticAnalyzer/Core/SValBuilder.cpp clang/te

[PATCH] D107720: [analyzer] Cleanup a FIXME in SValBuilder.cpp

vabridgers updated this revision to Diff 365582. vabridgers added a comment. only need the one test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107720/new/ https://reviews.llvm.org/D107720 Files: clang/lib/StaticAnalyzer/Core/SValBuilder.

[PATCH] D105974: [analyzer] Fix assertion in state split code path

vabridgers created this revision. vabridgers added reviewers: martong, steakhal. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity. vabridgers requested review of this revision. He

[PATCH] D105974: [analyzer] Fix assertion in state split code path

vabridgers updated this revision to Diff 358573. vabridgers added a comment. update commit header Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105974/new/ https://reviews.llvm.org/D105974 Files: clang/lib/StaticAnalyzer/Core/SValBuilder.cpp I

[PATCH] D105974: [analyzer] Do not assume that all pointers have the same bitwidth as void*

vabridgers added a comment. Thanks all for the updates and comments. I'll address promptly and resubmit. Best! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105974/new/ https://reviews.llvm.org/D105974

[PATCH] D136886: [ASTImporter] RFC: Correct importer to not duplicate sugared types

vabridgers created this revision. vabridgers added a reviewer: mizvekov. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: All. vabridgers requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. I'm not su

<    1   2   3   >