[PATCH] D109693: Driver: Remove major release version detection for RHEL

tstellar updated this revision to Diff 509912. tstellar added a comment. Herald added a subscriber: MaskRay. Herald added a project: All. Rebase and fix formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109693/new/ https://reviews.llvm.org/

[PATCH] D141907: [CMake] Ensure `CLANG_RESOURCE_DIR` is respected

tstellar added a comment. In D141907#4355229 , @paperchalice wrote: > In D141907#4355228 , @tstellar > wrote: > >> @paperchalice Do you need someone to commit this for you? > > Sure, I don't have the commit acce

[PATCH] D150723: clang/openmp: Fix alignment for ThreadID Address variables

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe88fe8181e36: clang/openmp: Fix alignment for ThreadID Address variables (authored by tstellar). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D152051: libclang-cpp: Add external visibility attribute to all classes

tstellar created this revision. Herald added subscribers: cfe-commits, PiotrZSL, luke, steakhal, carlosgalvezp, frasercrmck, wenlei, luismarques, apazos, sameer.abuasal, s.egerton, Jim, mstorsjo, jocewei, PkmX, arphaman, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, n

[PATCH] D152051: libclang-cpp: Add external visibility attribute to all classes

tstellar added a comment. I was not sure what to do with inline functions and also functions that were implemented in the headers, so I did not add the LLVM_EXTERNAL_VISIBILITY macro to most of those functions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D143306: [Driver] Default to -fno-openmp-implicit-rpath

tstellar added a comment. FWIW, I'm in favor of this patch. System directory rpaths (e.g. /usr/lib64) are not allowed in Fedora Linux. The current default makes building packages with clang+openmp more difficult. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D143306: [Driver] Default to -fno-openmp-implicit-rpath

tstellar added a comment. In D143306#4142023 , @JonChesterfield wrote: > I don't mind hugely what mechanism is used but would really like clang++ > -fopenmp foo.cpp to build a program that runs. How can we preserve that > 'works' feature without settin

[PATCH] D143306: [Driver] Default to -fno-openmp-implicit-rpath

tstellar added a comment. In D143306#4145432 , @MaskRay wrote: > This is the point. Specifying a driver option to use > libc++/libc++abi/libunwind doesn't magically change `DT_RUNPATH`. This is > exactly the behavior a user wants for a system Clang. > I

[PATCH] D143306: [Driver] Default to -fno-openmp-implicit-rpath

tstellar added a comment. @JonChesterfield I don't think we should be putting any Fedora specific logic into clang's build system or the driver, if that's what you are suggesting. Fedora can always patch the compiler or install a config file to change the default behavior, even though this is

[PATCH] D141907: [CMake] Ensure `CLANG_RESOURCE_DIR` is respected

tstellar added inline comments. Herald added subscribers: ekilmer, jplehr. Comment at: cmake/Modules/GetClangResourceDir.cmake:13 + if(DEFINED CLANG_RESOURCE_DIR AND NOT CLANG_RESOURCE_DIR STREQUAL "") +set(ret_dir bin/${CLANG_RESOURCE_DIR}) + else() Why is

[PATCH] D141907: [CMake] Ensure `CLANG_RESOURCE_DIR` is respected

tstellar added inline comments. Comment at: cmake/Modules/GetClangResourceDir.cmake:13 + if(DEFINED CLANG_RESOURCE_DIR AND NOT CLANG_RESOURCE_DIR STREQUAL "") +set(ret_dir bin/${CLANG_RESOURCE_DIR}) + else() paperchalice wrote: > tstellar wrote: > > Why is

[PATCH] D141907: [CMake] Ensure `CLANG_RESOURCE_DIR` is respected

tstellar added inline comments. Comment at: cmake/Modules/GetClangResourceDir.cmake:13 + if(DEFINED CLANG_RESOURCE_DIR AND NOT CLANG_RESOURCE_DIR STREQUAL "") +set(ret_dir bin/${CLANG_RESOURCE_DIR}) + else() tstellar wrote: > paperchalice wrote: > > tstella

[PATCH] D141907: [CMake] Ensure `CLANG_RESOURCE_DIR` is respected

tstellar added inline comments. Comment at: cmake/Modules/GetClangResourceDir.cmake:13 + if(DEFINED CLANG_RESOURCE_DIR AND NOT CLANG_RESOURCE_DIR STREQUAL "") +set(ret_dir bin/${CLANG_RESOURCE_DIR}) + else() tstellar wrote: > tstellar wrote: > > paperchalic

[PATCH] D141907: [CMake] Ensure `CLANG_RESOURCE_DIR` is respected

tstellar accepted this revision. tstellar added a comment. This revision is now accepted and ready to land. Thanks for the patch. I've tested this and it works for my build configuration. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141907

[PATCH] D149809: [Clang][Docs] Fix man page build

tstellar accepted this revision. tstellar added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149809/new/ https://reviews.llvm.org/D149809 __

[PATCH] D150723: clang/openmp: Fix alignment for ThreadID Address variables

tstellar created this revision. tstellar added a reviewer: jlpeyton. Herald added subscribers: sunshaoce, guansong, yaxunl. Herald added a project: All. tstellar requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, jplehr, sstefan1. Herald ad

[PATCH] D150723: clang/openmp: Fix alignment for ThreadID Address variables

tstellar updated this revision to Diff 522853. tstellar added a comment. Add test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150723/new/ https://reviews.llvm.org/D150723 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/test/OpenMP/f

[PATCH] D141907: [CMake] Ensure `CLANG_RESOURCE_DIR` is respected

tstellar added a comment. @paperchalice Do you need someone to commit this for you? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141907/new/ https://reviews.llvm.org/D141907 ___ cfe-commits mailing list

[PATCH] D149809: [Clang][Docs] Fix man page build

tstellar added a comment. I think we could remove some of the duplication by making the docs_target parameter into a list and passing both docs-clang-html and docs-clang-man to it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149809/new/ https://

[PATCH] D149809: [Clang][Docs] Fix man page build

tstellar added a comment. In D149809#4317763 , @aidengrossman wrote: > In D149809#4317610 , @tstellar > wrote: > >> I think we could remove some of the duplication by making the docs_target >> parameter into a

[PATCH] D105765: Prepare Compiler-RT for GnuInstallDirs, matching libcxx, document all

tstellar added inline comments. Herald added a subscriber: Enna1. Herald added a project: All. Comment at: compiler-rt/cmake/base-config-ix.cmake:126 +set(COMPILER_RT_INSTALL_DATA_DIR "${default_install_path}" CACHE PATH + "Path where compiler-rt data files should be installed."

[PATCH] D152051: libclang-cpp: Add external visibility attribute to all classes

tstellar added a comment. > ! In D152051#4403167 , @compnerd > wrote: > Please do not use LLVM_EXTERNAL_VISIBILITY but rather introduce a new macro > (this will prevent the use on Windows). OK, so should I create a clang specific macro for this? And s

[PATCH] D152051: libclang-cpp: Add external visibility attribute to all classes

tstellar added a comment. I chatted with @compnerd on Discord, and I'm going to try to update D109192 and get that committed and then come back to this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152051/

[PATCH] D141907: [CMake] Ensure `CLANG_RESOURCE_DIR` is respected

tstellar added a comment. In D141907#4409973 , @MaskRay wrote: > In D141907#4094748 , @MaskRay wrote: > >> [...] >> edeaf16f2c2f02d6e43312d48d26d354d87913f3 (2011) added the CMake variable >> `CLANG_RESOURCE_DIR`

[PATCH] D31210: [AMDGPU] Add new address space mapping

tstellar added inline comments. Comment at: lib/Basic/Targets.cpp:2029-2040 + if (UseNew) { +Generic = 0; +Global= 1; +Local = 3; +Constant = 4; +Private = 5; + } else { What are these values used for

[PATCH] D29651: [OpenMP] Consider LIBRARY_PATH when selecting library paths for NVPTX targets in OpenMP mode.

tstellar added a comment. Why is this necessary? Repository: rL LLVM https://reviews.llvm.org/D29651 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34848: Driver: Don't mix system tools with devtoolset tools on RHEL

tstellar created this revision. On RHEL, devtoolset provides a more up-to-date toolchain than the base install, and we want to make sure all the tools use are from the same toolchain. https://reviews.llvm.org/D34848 Files: lib/Driver/ToolChains/Linux.cpp Index: lib/Driver/ToolChains/Linux.c

[PATCH] D42593: GCC compatibility: Ignore -fstack-clash-protection

tstellar created this revision. tstellar added a reviewer: sylvestre.ledru. Repository: rC Clang https://reviews.llvm.org/D42593 Files: include/clang/Driver/Options.td test/Driver/clang_f_opts.c Index: test/Driver/clang_f_opts.c ===

[PATCH] D42608: Driver: Prefer vendor supplied gcc toolchain

tstellar created this revision. Herald added a subscriber: srhines. This patch fixes an issue on Fedora where if you had the x86_64 cross compiler installed on your x86_64 system, then clang would use that compiler as the default toolchain. This was happening because the cross compiler is install

[PATCH] D32595: CMakeLists: Don't set LLVM_MAIN_SRC_DIR when building stand-alone clang

tstellar created this revision. clang was using LLVM_MAIN_SRC_DIR to search for lit.py to use for running clang's lit tests. This was dangerous though, because LLVM_MAIN_SRC_DIR was determined by using llvm-config --src-root and this directory may have been modified since llvm-config was built (e

[PATCH] D32604: CMakeLists: Deprecate using llvm-config to find llvm install path

tstellar created this revision. You can still specify an llvm-config to use by configuring with -DLLVM_CONFIG=/path/to/llvm/config, but this method is now deprecated and may be remove. Users should be setting CMAKE_PREFIX_PATH to the install prefix for their llvm install. Unless you are using th

[PATCH] D32595: CMakeLists: Don't set LLVM_MAIN_SRC_DIR when building stand-alone clang

tstellar added a comment. In https://reviews.llvm.org/D32595#740222, @chapuni wrote: > Let me know steps for testing that you suppose. > I guess; > > - Use installed version of lit via virtualenv. Not necessarily via virtualenv, either by installing the lit pypi package or using a distro pack

[PATCH] D32499: Further delay calling DeclMustBeEmitted until it's safe.

tstellar added a comment. This is mentioned as a fix for PR31863, which is a blocker for the 4.0.1 release, is there any reason this hasn't been committed to trunk yet? https://reviews.llvm.org/D32499 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D32248: CodeGen: Cast alloca to expected address space

tstellar added inline comments. Comment at: cfe/trunk/lib/Basic/Targets.cpp:2037-2038 -static const LangAS::Map AMDGPUPrivateIsZeroMap = { -4, // Default -1, // opencl_global -3, // opencl_local -2, // opencl_constant -4, // opencl_generic -1, // c

[PATCH] D33445: [AMDGPU] Do not require opencl triple environment for OpenCL

tstellar accepted this revision. tstellar added a comment. This revision is now accepted and ready to land. Thanks! Comment at: test/CodeGenOpenCL/amdgpu-alignment.cl:2 // REQUIRES: amdgpu-registered-target -// RUN: %clang_cc1 -triple amdgcn-unknown-unknown-opencl -S -disable

[PATCH] D117616: GCC ABI Compatibility: Preserve alignment of non-pod members in packed structs

tstellar added a comment. So to summarize: this will change the ABI of clang built objects from clang13 -> clang14 in order to make clang14 compatible with gcc? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117616/new/ https://reviews.llvm.org/D11

[PATCH] D117616: GCC ABI Compatibility: Preserve alignment of non-pod members in packed structs

tstellar added a comment. Can you add a release note to go along with this change? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117616/new/ https://reviews.llvm.org/D117616 ___ cfe-commits mailing list

[PATCH] D112181: [docs] Remove hard-coded version numbers from sphinx configs

This revision was automatically updated to reflect the committed changes. Closed by commit rGe80c52986e1b: [docs] Remove hard-coded version numbers from sphinx configs (authored by tstellar). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112181/new/

[PATCH] D120301: clang-tools-extra: Make test dependency on LLVMHello optional

tstellar created this revision. tstellar added a reviewer: vtjnash. Herald added a subscriber: mgorny. tstellar requested review of this revision. Herald added a project: clang-tools-extra. This fixes clang + clang-tools-extra standalone build after 36892727e4f19a60778e371d78f8fb09d8122c85

[PATCH] D111100: enable plugins for clang-tidy

tstellar added a comment. I've proposed a fix for the standalone builds here D120301 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D00/new/ https://reviews.llvm.org/D00 __

[PATCH] D120454: clang/www: Add links to tracking issues for C++20 features

tstellar created this revision. tstellar requested review of this revision. Herald added a project: clang. Also add some javascript to automatically change that status to "In Progress" when the issue is assigned to someone, and "Clang ToT" when the issue is closed. Note that the feature entries w

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

tstellar added a comment. In D120305#3346880 , @MaskRay wrote: > In D120305#3346787 , @nemanjai > wrote: > >> In D120305#3346144 , @MaskRay >> wrote: >> >>> In D120305#3

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

tstellar added a comment. In D120305#3347058 , @nemanjai wrote: > In D120305#3346880 , @MaskRay wrote: > >> While I feel sorry for leaving clang-ppc64le-rhel red for some time and am >> willing to fix issues if I

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

tstellar added a comment. In D120305#3347108 , @MaskRay wrote: > In D120305#3347103 , @tstellar > wrote: > >> In D120305#3347058 , @nemanjai >> wrote: >> >>> In D120305#

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

tstellar added a comment. In D120305#3347139 , @MaskRay wrote: > In D120305#3347109 , @tstellar > wrote: > >> [...] >> The issue here has nothing to do with the technical merits of the patch or >> what the root

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

tstellar added a comment. In D120305#3347143 , @MaskRay wrote: > In D120305#3347142 , @tstellar > wrote: > >> In D120305#3347139 , @MaskRay >> wrote: >> >>> In D120305#3

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

tstellar added a comment. In D120305#3347148 , @MaskRay wrote: > In D120305#3347145 , @tstellar > wrote: > >> In D120305#3347143 , @MaskRay >> wrote: >> >>> In D120305#3

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

tstellar added a comment. In D120305#3347151 , @xbolva00 wrote: >>> Given that the bot does not have a high success rate (track record) for at >>> least the past month, I am unsure I am supposed to revert my change. > > What is interesting that always th

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

tstellar added a comment. In D120305#3347161 , @MaskRay wrote: > In D120305#3347160 , @nikic wrote: > >> @MaskRay Please revert the change and all dependent changes you have made. A >> revert is not a personal af

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

tstellar added a comment. In D120305#3347177 , @nikic wrote: > Yes, because you reverted the change for that one buildbot, of course it is > green now. You could have also made the buildbot green by disabling tests on > that bot. Or disabling sanitizers

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

tstellar added a comment. I have reverted the buildbot configuration change as well: https://github.com/llvm/llvm-zorg/commit/c01d0787c4a11e40d0fed81b0df6841bebc16f7f Now that everything is back to the original state, we can discuss how to proceed. Repository: rG LLVM Github Monorepo CHAN

[PATCH] D120301: clang-tools-extra: Make test dependency on LLVMHello optional

tstellar added a comment. Herald added a project: All. @vtjnash There hasn't been consensus on removing support for standalone builds yet, and I'm in favor of keeping them as are some other distribution maintainers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D118511: Add a warning for not packing non-POD members in packed structs

tstellar added a comment. Herald added a project: All. Should we backport this to the release/14.x branch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118511/new/ https://reviews.llvm.org/D118511 ___ c

[PATCH] D102090: [CMake][ELF] Add -fno-semantic-interposition and -Bsymbolic-functions

tstellar added a comment. Does this change mean that LD_PRELOAD will no longer work? Are there any other downsides to adding these flags? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102090/new/ https://reviews.llvm.org/D102090

[PATCH] D102090: [CMake][ELF] Add -fno-semantic-interposition and -Bsymbolic-functions

tstellar added a comment. I was originally skeptical of this change, because of some negative feedback about these flags in the past on the Fedora development list. However, the people I've talked to more recently seem to be in favor of this change, so no objection from me. Repository: rG

[PATCH] D116272: [Clang][Sema] Avoid crashing for va_arg expressions with bool argument

tstellar added a comment. We may have time to fit it in to the release, but no guarantees. Can you file an issue for this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116272/new/ https://reviews.llvm.org/D116272 ___

[PATCH] D77574: [OpenMP] Fix layering problem with FrontendOpenMP

tstellar added inline comments. Herald added a reviewer: bollu. Herald added a subscriber: sstefan1. Herald added a project: clang-tools-extra. Comment at: clang/lib/ASTMatchers/CMakeLists.txt:17-18 ) + +target_link_libraries(clangASTMatchers PUBLIC LLVMFrontendOpenMP) ---

[PATCH] D94941: Add minor version to libclang.so and libclang-cpp.so SONAME

tstellar created this revision. tstellar added a reviewer: sylvestre.ledru. Herald added a subscriber: mgorny. tstellar requested review of this revision. Herald added a project: clang. This patch is for the release/11.x branch. We need to bump the SONAME, because the ABI of the shared library is

[PATCH] D94941: Add minor version to libclang.so and libclang-cpp.so SONAME

tstellar added a comment. In D94941#2509829 , @sylvestre.ledru wrote: > I might be wrong but if the ABI is incompatible, are we not supposed to > update the SONAME itself? That's what this patch does, it updates the SONAME from *-11 to *-11.1. Reposit

[PATCH] D94941: Add minor version to libclang.so and libclang-cpp.so SONAME

tstellar added inline comments. Comment at: clang/tools/clang-shlib/CMakeLists.txt:54 + PROPERTIES + SOVERSION ${LIBCLANG_LIBRARY_VERSION}) cuviper wrote: > I think you also need `VERSION` here, or else it symlinks back to `.so.11`. I think add_clang_li

[PATCH] D94941: Add minor version to libclang.so and libclang-cpp.so SONAME

tstellar added inline comments. Comment at: clang/tools/clang-shlib/CMakeLists.txt:54 + PROPERTIES + SOVERSION ${LIBCLANG_LIBRARY_VERSION}) cuviper wrote: > tstellar wrote: > > cuviper wrote: > > > I think you also need `VERSION` here, or else it symlin

[PATCH] D94941: Add minor version to libclang.so and libclang-cpp.so SONAME

tstellar updated this revision to Diff 318003. tstellar added a comment. Fix shared object symlinks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94941/new/ https://reviews.llvm.org/D94941 Files: clang/CMakeLists.txt clang/tools/clang-shlib/C

[PATCH] D109727: [Driver] Remove unneeded *-suse-* triples

tstellar added a comment. This patch should depend on D109837 , otherwise clang builds will be broken on SUSE if you don't pass -DLLVM_DEFAULT_TARGET_TRIPLE to cmake when configuring, and I don't think we should require users to pass this option. Repository:

[PATCH] D111207: Driver: Add a gcc equivalent triple to the list of triples to search

tstellar created this revision. tstellar added reviewers: aaronpuchert, hvdijk, MaskRay. Herald added a subscriber: pengfei. tstellar requested review of this revision. Herald added a project: clang. There are some gcc triples, like x86_64-redhat-linux, that provide the same behavior as a clang tr

[PATCH] D111367: [Driver] Change -dumpmachine to respect --target/LLVM_DEFAULT_TARGET_TRIPLE verbatim

tstellar added a comment. In D111367#3049772 , @MaskRay wrote: > In D111367#3049700 , @hvdijk wrote: > >> Does Red Hat actually use `x86_64-redhat-linux` with LLVM (other than for >> finding the GCC installation)

[PATCH] D112030: [docs] Remove Makefile.sphinx files

tstellar created this revision. tstellar added reviewers: sylvestre.ledru, pcc, silvas. tstellar requested review of this revision. Herald added projects: clang, libc++, LLVM. Herald added subscribers: libcxx-commits, cfe-commits. Herald added a reviewer: libc++. Does anyone still use these? I wa

[PATCH] D112030: [docs] Remove Makefile.sphinx files

tstellar added a comment. In D112030#3071393 , @sylvestre.ledru wrote: > I am using them but I can move to sphinx calls. How much time do you need to transition? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D112181: [docs] Remove hard-coded version numbers from sphinx configs

tstellar created this revision. Herald added a subscriber: mgorny. Herald added a reviewer: bollu. Herald added a reviewer: MaskRay. tstellar requested review of this revision. Herald added projects: clang, LLVM, clang-tools-extra. Herald added a subscriber: cfe-commits. This updates all the non-r

[PATCH] D112030: [docs] Remove Makefile.sphinx files

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc16655f138b1: [docs] Remove Makefile.sphinx files (authored by tstellar). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D108085: Use installed llvm-lit.py instead of lit.py PR-51072

tstellar added inline comments. Comment at: clang/test/utils/update_cc_test_checks/lit.local.cfg:24 +# Windows: llvm-lit.py, Linux: llvm-lit +llvm_lit = glob.glob(os.path.join(config.llvm_tools_dir, 'llvm-lit*'))[0] +lit = config.llvm_external_lit if config.llvm_external_lit else

[PATCH] D109000: [llvm-lit] unbreak clang-only builds by not assuming llvm-lit in build dir

tstellar accepted this revision. tstellar added a comment. This revision is now accepted and ready to land. LGTM, thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109000/new/ https://reviews.llvm.org/D109000 ___

[PATCH] D109023: libclang: Document the soname change in the release notes

tstellar accepted this revision. tstellar added a comment. LGTM, thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109023/new/ https://reviews.llvm.org/D109023 ___ cfe-commits mailing list cfe-com

[PATCH] D109693: Driver: Remove major release version detection for RHEL

tstellar created this revision. tstellar added a reviewer: serge-sans-paille. tstellar requested review of this revision. Herald added a project: clang. We treat all release of RHEL the same in the driver, so we don't need to detect the RHEL major release version. Repository: rG LLVM Github Mo

[PATCH] D109694: Driver: Add preferred gcc triples for Red Hat operating systems

tstellar created this revision. tstellar added reviewers: serge-sans-paille, MaskRay, mgorny. Herald added a subscriber: pengfei. tstellar requested review of this revision. Herald added a project: clang. The GCCInstallationDetector has a list of gcc triples to search for when trying to find a val

[PATCH] D109812: [compiler-rt] Move -fno-omit-frame-pointer check to common config-ix

tstellar accepted this revision. tstellar added a comment. This revision is now accepted and ready to land. LGTM. Thank you. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109812/new/ https://reviews.llvm.org/D109812 ___ cfe-commits mailing l

<    1   2   3   4