[PATCH] D98852: [test] Fix variable definition in acle_sve_ld1.sh

This revision was automatically updated to reflect the committed changes. Closed by commit rGe5cd5b352ff4: [test] Fix variable definition in acle_sve_ld1.sh (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98852/new/ https://revie

[PATCH] D99770: [OpenMP, test] Fix uses of undef S*VAR FileCheck var

thopre created this revision. thopre added reviewers: ABataev, MaskRay, jdoerfert. Herald added subscribers: guansong, yaxunl. thopre requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Fix the many cases of use of undefined SIVAR/SVAR

[PATCH] D99771: [OpenMP, test] Fix use of undef DECL FileCheck var

thopre created this revision. thopre added reviewers: cchen, ABataev, MaskRay. Herald added subscribers: guansong, yaxunl. thopre requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. OpenMP test targe

[PATCH] D99770: [OpenMP, test] Fix uses of undef S*VAR FileCheck var

thopre updated this revision to Diff 334846. thopre added a comment. Fix one more testcase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99770/new/ https://reviews.llvm.org/D99770 Files: clang/test/OpenMP/for_firstprivate_codegen.cpp clang/tes

[PATCH] D99775: [OpenMP, test] Fix use of undef VAR_PRIV FileCheck var

thopre created this revision. thopre added reviewers: ABataev, mikerice, jdoerfert, MaskRay. Herald added subscribers: guansong, yaxunl. thopre requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Remove the CHECK-NOT directive referrin

[PATCH] D99770: [OpenMP, test] Fix uses of undef S*VAR FileCheck var

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd222a07d3023: [OpenMP, test] Fix uses of undef S*VAR FileCheck var (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D99771: [OpenMP, test] Fix use of undef DECL FileCheck var

This revision was automatically updated to reflect the committed changes. Closed by commit rG58e458935ba6: [OpenMP, test] Fix use of undef DECL FileCheck var (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99771/new/ https://revi

[PATCH] D99775: [OpenMP, test] Fix use of undef VAR_PRIV FileCheck var

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2c3db73341ae: [OpenMP, test] Fix use of undef VAR_PRIV FileCheck var (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D99821: [PGO, test] Fix typo in FileCheck var

thopre created this revision. thopre added reviewers: bogner, xur, davidxl. Herald added a subscriber: wenlei. thopre requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D99821 Fi

[PATCH] D99821: [PGO, test] Fix typo in FileCheck var

This revision was automatically updated to reflect the committed changes. Closed by commit rG95f448aa86cd: [PGO, test] Fix typo in FileCheck var (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99821/new/ https://reviews.llvm.org/

[PATCH] D99830: [DebugInfo, CallSites, test] Fix use of undef FileCheck var

thopre created this revision. thopre added reviewers: djtodoro, vsk. thopre requested review of this revision. Herald added a project: clang. Clang test CodeGen/debug-info-extern-call.c tries to check for the absence of a sequence of instructions with several CHECK-NOT with one of those directives

[PATCH] D99831: [HIP-Clang, test] Fix use of undef FileCheck var

thopre created this revision. thopre added reviewers: ashi1, yaxunl, MaskRay, hliao, pcc. thopre requested review of this revision. Herald added a project: clang. Commit 8129521318accc44c2a009647572f6ebd3fc56dd changed a line defining PREFIX in clang test CodeGenCUDA/device-stub.cu into a CHECK-NO

[PATCH] D99832: [HIP, test] Fix use of undef FileCheck var

thopre created this revision. thopre added reviewers: yaxunl, ashi1, MaskRay, hliao, pcc. thopre requested review of this revision. Herald added a project: clang. Clang test CodeGenCUDA/kernel-stub-name.cu uses never defined DKERN variable in a CHECK-NOT directive. This commit replace the variable

[PATCH] D99838: [C++20, test] Fix use of undef FileCheck variable

thopre created this revision. thopre added reviewers: rsmith, EricWF, akhuang. thopre requested review of this revision. Herald added a project: clang. Commit f495de43bd5da50286da6020e508d106cfc60f57 forgot two lines when remo

[PATCH] D99839: [C++, test] Fix typo in NSS* vars

thopre created this revision. thopre added reviewers: respindola, pcc, EricWF. thopre requested review of this revision. Herald added a project: clang. The NSS FileCheck variables at the end of the CodeGenCXX/split-stacks.cpp clang testcase are off by 1, resulting in the use of an undefined variab

[PATCH] D99838: [C++20, test] Fix use of undef FileCheck variable

This revision was automatically updated to reflect the committed changes. Closed by commit rG1cc9d949a123: [C++20, test] Fix use of undef FileCheck variable (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99838/new/ https://revie

[PATCH] D99857: [OpenCL, test] Fix use of undef FileCheck var

thopre created this revision. thopre added reviewers: hliao, craig.topper, neil.hickey, yaxunl, baldrick. Herald added subscribers: ldrumm, Anastasia. thopre requested review of this revision. Herald added a project: clang. Clang test CodeGenOpenCL/fpmath.cl uses a variable defined in an earlier C

[PATCH] D99831: [HIP-Clang, test] Fix use of undef FileCheck var

This revision was automatically updated to reflect the committed changes. Closed by commit rGa41b5100e438: [HIP-Clang, test] Fix use of undef FileCheck var (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99831/new/ https://review

[PATCH] D99832: [HIP, test] Fix use of undef FileCheck var

This revision was automatically updated to reflect the committed changes. Closed by commit rG292726b6443c: [HIP, test] Fix use of undef FileCheck var (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99832/new/ https://reviews.llvm

[PATCH] D99830: [DebugInfo, CallSites, test] Fix use of undef FileCheck var

This revision was automatically updated to reflect the committed changes. Closed by commit rG4dd3e0feca92: [DebugInfo, CallSites, test] Fix use of undef FileCheck var (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99830/new/ htt

[PATCH] D99857: [OpenCL, test] Fix use of undef FileCheck var

This revision was automatically updated to reflect the committed changes. Closed by commit rG828ec9e9e5da: [OpenCL, test] Fix use of undef FileCheck var (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99857/new/ https://reviews.l

[PATCH] D99898: [clang, test] Fix use of undef FileCheck var

thopre created this revision. thopre added reviewers: ddunbar, MaskRay, rjmccall, spatel, arsenm, hfinkel, void, mcrosier. thopre requested review of this revision. Herald added a subscriber: wdng. Herald added a project: clang. Clang test CodeGen/libcalls.c contains CHECK-NOT directives using a

[PATCH] D99898: [clang, test] Fix use of undef FileCheck var

thopre updated this revision to Diff 335618. thopre added a comment. Change attribute check to a positive match Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99898/new/ https://reviews.llvm.org/D99898 Files: clang/test/CodeGen/libcalls.c Index

[PATCH] D99898: [clang, test] Fix use of undef FileCheck var

thopre updated this revision to Diff 335640. thopre added a comment. Rename NUW_RN for CHECK-YES to NUW Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99898/new/ https://reviews.llvm.org/D99898 Files: clang/test/CodeGen/libcalls.c Index: clang/

[PATCH] D99898: [clang, test] Fix use of undef FileCheck var

This revision was automatically updated to reflect the committed changes. Closed by commit rGe018698bec36: [clang, test] Fix use of undef FileCheck var (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99898/new/ https://reviews.ll

[PATCH] D99839: [C++, test] Fix typo in NSS* vars

thopre added a comment. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99839/new/ https://reviews.llvm.org/D99839 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[PATCH] D99839: [C++, test] Fix typo in NSS* vars

thopre added a comment. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99839/new/ https://reviews.llvm.org/D99839 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[PATCH] D99839: [C++, test] Fix typo in NSS* vars

thopre added inline comments. Comment at: clang/test/CodeGenCXX/split-stacks.cpp:30 // CHECK-NOSEGSTK: define dso_local i32 @_Z7nosplitv() [[NSS1:#[0-9]+]] { // CHECK-NOSEGSTK: define linkonce_odr dso_local i32 @_Z8tnosplitIiEiv() [[NSS2:#[0-9]+]] comdat { +// CHECK-NOSEGSTK-N

[PATCH] D99839: [C++, test] Fix typo in NSS* vars

thopre added inline comments. Comment at: clang/test/CodeGenCXX/split-stacks.cpp:30 // CHECK-NOSEGSTK: define dso_local i32 @_Z7nosplitv() [[NSS1:#[0-9]+]] { // CHECK-NOSEGSTK: define linkonce_odr dso_local i32 @_Z8tnosplitIiEiv() [[NSS2:#[0-9]+]] comdat { +// CHECK-NOSEGSTK-N

[PATCH] D99839: [C++, test] Fix typo in NSS* vars

thopre updated this revision to Diff 338811. thopre marked an inline comment as done. thopre added a comment. Remove NSS2 variable since _Z8tnosplitIiEiv uses the same attribute as _Z3foov Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99839/new/ ht

[PATCH] D99839: [C++, test] Fix typo in NSS* vars

thopre marked 2 inline comments as done. thopre added inline comments. Comment at: clang/test/CodeGenCXX/split-stacks.cpp:30 // CHECK-NOSEGSTK: define dso_local i32 @_Z7nosplitv() [[NSS1:#[0-9]+]] { // CHECK-NOSEGSTK: define linkonce_odr dso_local i32 @_Z8tnosplitIiEiv() [[NSS

[PATCH] D99839: [C++, test] Fix typo in NSS* vars

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8cee150e9ac4: [C++, test] Fix typo in NSS* vars (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D92409: [AST][NFC] Silence GCC warning about multiline comments

thopre added a comment. In D92409#2450897 , @thopre wrote: > In D92409#2450690 , @rsmith wrote: > >> In D92409#2450550 , @thopre wrote: >> >>> In D92409#2426196

[PATCH] D92409: [AST][NFC] Silence GCC warning about multiline comments

thopre updated this revision to Diff 315080. thopre added a comment. Change approach to remove continuation line instead Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92409/new/ https://reviews.llvm.org/D92409 Files: clang/include/clang/AST/Decl

[PATCH] D92409: [AST][NFC] Silence GCC warning about multiline comments

thopre added a comment. In D92409#2481300 , @rjmccall wrote: > People can't actually just copy/paste from the comment anyway because of the > comment characters on the line, and I don't think anyone will misunderstand > the example if the backslash is mi

[PATCH] D92409: [AST][NFC] Silence GCC warning about multiline comments

This revision was automatically updated to reflect the committed changes. Closed by commit rGacbb3652931a: [AST][NFC] Silence GCC warning about multiline comments (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92409/new/ https:/

[PATCH] D93347: [Test] Fix undef var in attr-speculative-load-hardening.c

thopre added a comment. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93347/new/ https://reviews.llvm.org/D93347 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[PATCH] D94396: Fix macos target assumption in test

thopre created this revision. thopre added a reviewer: arphaman. thopre requested review of this revision. Herald added a project: clang. Clang test Driver/macos-apple-silicon-slice-link-libs-darwin-only.cpp assumes the target is darwin when the host is darwin which is not necessarily the case, ca

[PATCH] D104854: Introduce intrinsic llvm.isnan

thopre added a comment. In D104854#2957735 , @kpn wrote: > In D104854#2957490 , @lebedev.ri > wrote: > >> In D104854#2957471 , @sepavloff >> wrote: >> >>> In D104854#295

[PATCH] D104854: Introduce intrinsic llvm.isnan

thopre added a comment. Ah fair enough. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104854/new/ https://reviews.llvm.org/D104854 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[PATCH] D109345: MemoryBuffer: Migrate to Expected/llvm::Error from ErrorOr/std::error_code

thopre added a comment. Is there no way to split this patch further? It's going to be hard finding someone who can review something so big. If there's no way to split it in incremental changes, you could perhaps split per subsystem only for review and refer to this diff for CI as well as when l

[PATCH] D109234: [PGO] Change ThinLTO test for targets with loop unrolling disabled

thopre added inline comments. Comment at: clang/test/CodeGen/pgo-sample-thinlto-summary.c:3-4 +// RUN: %clang_cc1 -mllvm -debug-pass=Structure -O2 -fno-experimental-new-pass-manager -fprofile-sample-use=%S/Inputs/pgo-sample-thinlto-summary.prof %s -emit-llvm -flto=thin -o - 2>

<    1   2