thopre created this revision.
thopre added reviewers: cchen, ABataev, MaskRay.
Herald added subscribers: guansong, yaxunl.
thopre requested review of this revision.
Herald added a reviewer: jdoerfert.
Herald added subscribers: cfe-commits, sstefan1.
Herald added a project: clang.
OpenMP test target_data_use_device_ptr_if_codegen contains a CHECK-NOT
directive using an undefined DECL FileCheck variable. It seems copied
from target_data_use_device_ptr_codegen where there's a CHECK for a load
that defined the variable. Since there is no corresponding load in this
testcase, the simplest is to simply forbid any store and get rid of the
variable altogether.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D99771
Files:
clang/test/OpenMP/target_data_use_device_ptr_if_codegen.cpp
Index: clang/test/OpenMP/target_data_use_device_ptr_if_codegen.cpp
===================================================================
--- clang/test/OpenMP/target_data_use_device_ptr_if_codegen.cpp
+++ clang/test/OpenMP/target_data_use_device_ptr_if_codegen.cpp
@@ -29,7 +29,7 @@
// CK1: store float* [[B_ADDR:%.+]], float** [[CBP]]
// CK1: call void @__tgt_target_data_begin{{.+}}[[MTYPE00]]
// CK1: [[VAL:%.+]] = load float*, float** [[CBP]],
- // CK1-NOT: store float* [[VAL]], float** [[DECL]],
+ // CK1-NOT: store float* [[VAL]], float** {{%.+}},
// CK1: store float* [[VAL]], float** [[PVT:%.+]],
// CK1: [[TT:%.+]] = load float*, float** [[PVT]],
// CK1: call i32 @__tgt_target{{.+}}[[MTYPE01]]
Index: clang/test/OpenMP/target_data_use_device_ptr_if_codegen.cpp
===================================================================
--- clang/test/OpenMP/target_data_use_device_ptr_if_codegen.cpp
+++ clang/test/OpenMP/target_data_use_device_ptr_if_codegen.cpp
@@ -29,7 +29,7 @@
// CK1: store float* [[B_ADDR:%.+]], float** [[CBP]]
// CK1: call void @__tgt_target_data_begin{{.+}}[[MTYPE00]]
// CK1: [[VAL:%.+]] = load float*, float** [[CBP]],
- // CK1-NOT: store float* [[VAL]], float** [[DECL]],
+ // CK1-NOT: store float* [[VAL]], float** {{%.+}},
// CK1: store float* [[VAL]], float** [[PVT:%.+]],
// CK1: [[TT:%.+]] = load float*, float** [[PVT]],
// CK1: call i32 @__tgt_target{{.+}}[[MTYPE01]]
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
