[libclc] [libclc] Move fma to the CLC library (PR #126052)

2025-02-23 Thread Romaric Jodin via cfe-commits
rjodinchr wrote: > FYI @rjodinchr this breaks downstream clspv testing. > > ``` > # | declare !kernel_arg_name !7 float @llvm.fma.f32(float, float, float) #2 > # | Unsupported llvm intrinsic > # | UNREACHABLE executed at /clspv/lib/SPIRVProducerPass.cpp:2390! > ``` > > I was wondering if clspv

[libclc] [libclc] Fix int<->float conversion builtins (PR #126905)

2025-02-23 Thread Romaric Jodin via cfe-commits
https://github.com/rjodinchr approved this pull request. https://github.com/llvm/llvm-project/pull/126905 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] [libclc] Move fma to the CLC library (PR #126052)

2025-02-24 Thread Romaric Jodin via cfe-commits
rjodinchr wrote: > > > FYI @rjodinchr this breaks downstream clspv testing. > > > ``` > > > # | declare !kernel_arg_name !7 float @llvm.fma.f32(float, float, float) > > > #2 > > > # | Unsupported llvm intrinsic > > > # | UNREACHABLE executed at /clspv/lib/SPIRVProducerPass.cpp:2390! > > > ``` >

[libclc] [libclc] Remove clspv-specific clc conversions (PR #128500)

2025-02-26 Thread Romaric Jodin via cfe-commits
rjodinchr wrote: In fact, I missed that I had to modify some build files in Google infra for that change. So it's all good. Also, would you have a 15min slot in the coming days to talk about all your libclc work? https://github.com/llvm/llvm-project/pull/128500 __

[libclc] [libclc] Remove clspv-specific clc conversions (PR #128500)

2025-02-26 Thread Romaric Jodin via cfe-commits
rjodinchr wrote: This commit is causing regressions on the OpenCL-CTS with `clvk/clspv`. I need more time to understand what the issue is exactly. https://github.com/llvm/llvm-project/pull/128500 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[libclc] [libclc]: clspv: add a dummy implememtation for mul_hi (PR #134094)

2025-04-03 Thread Romaric Jodin via cfe-commits
https://github.com/rjodinchr updated https://github.com/llvm/llvm-project/pull/134094 >From 46d4e40a3142b36811b85ac3d2ececf46d5b8e7c Mon Sep 17 00:00:00 2001 From: Romaric Jodin Date: Wed, 2 Apr 2025 17:12:17 +0200 Subject: [PATCH 1/2] [libclc]: clspv: add a dummy implememtation for mul_hi cls

[libclc] [libclc] Reduce bithacking in CLC frexp (PR #129871)

2025-03-20 Thread Romaric Jodin via cfe-commits
rjodinchr wrote: I tend to agree. let's keep it that way. https://github.com/llvm/llvm-project/pull/129871 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] [libclc]: clspv: add a dummy implememtation for mul_hi (PR #134094)

2025-04-02 Thread Romaric Jodin via cfe-commits
rjodinchr wrote: For the record, clspv implementation is based on OpMulExtended which is SPIR-V specific and not accessible from C. https://github.com/llvm/llvm-project/pull/134094 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[libclc] [libclc]: clspv: add a dummy implememtation for mul_hi (PR #134094)

2025-04-02 Thread Romaric Jodin via cfe-commits
rjodinchr wrote: @frasercrmck could you please review? https://github.com/llvm/llvm-project/pull/134094 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] [libclc]: clspv: add a dummy implememtation for mul_hi (PR #134094)

2025-04-04 Thread Romaric Jodin via cfe-commits
https://github.com/rjodinchr created https://github.com/llvm/llvm-project/pull/134094 clspv uses a better implementation that is not using a bigger side when not available. Add a dummy implementation for mul_hi to avoid to override the implementation of clspv with the one in libclc. >From 46d

[libclc] libclc: clspv: do not set generic_addrspace_val (PR #141912)

2025-05-29 Thread Romaric Jodin via cfe-commits
https://github.com/rjodinchr created https://github.com/llvm/llvm-project/pull/141912 This is breaking clspv: https://github.com/google/clspv/issues/1493 >From 3599980d914b003688bf3d8786b9e7ad4e513179 Mon Sep 17 00:00:00 2001 From: Romaric Jodin Date: Thu, 29 May 2025 10:24:49 +0200 Subject: [

[libclc] libclc: clspv: do not set generic_addrspace_val (PR #141912)

2025-05-29 Thread Romaric Jodin via cfe-commits
rjodinchr wrote: @frasercrmck could you please review? https://github.com/llvm/llvm-project/pull/141912 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

<    1   2