rjodinchr wrote: > > > FYI @rjodinchr this breaks downstream clspv testing. > > > ``` > > > # | declare !kernel_arg_name !7 float @llvm.fma.f32(float, float, float) > > > #2 > > > # | Unsupported llvm intrinsic > > > # | UNREACHABLE executed at /clspv/lib/SPIRVProducerPass.cpp:2390! > > > ``` > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > I was wondering if clspv should be translating `llvm.fma` to `OpExtInst > > > fma` as `llvm-spirv` does. > > > > > > I guess it would just be a question of adding `llvm.fma` here: > > https://github.com/google/clspv/blob/0878df110af85e84d0c336e6571767278ad5eec8/lib/Builtins.cpp#L703 > > With that change, `check-spirv` does indeed pass. Does that mean this PR is > good to go, do you think?
Yes, I'll update `clspv` when it is needed. https://github.com/llvm/llvm-project/pull/126052 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
