[PATCH] D38678: [Sema] Warn about unused variables if we can constant evaluate the initializer.

2017-10-13 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL315787: [Sema] Warn about unused variables if we can constant evaluate the initializer. (authored by d0k). Repository: rL LLVM https://reviews.llvm.org/D38678 Files: cfe/trunk/lib/Sema/SemaDecl.cpp

[PATCH] D38101: [Sema] Diagnose tautological comparison with type's min/max values

2017-10-15 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL315875: [Sema] Re-land: Diagnose tautological comparison with type's min/max values (authored by lebedevri). Changed prior to commit: https://reviews.llvm.org/D38101?vs=118835&id=119095#toc Repository:

[PATCH] D38943: [ASTImporter] import SubStmt of CaseStmt

2017-10-18 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL316069: [ASTImporter] Import SubStmt of CaseStmt (authored by xazax). Changed prior to commit: https://reviews.llvm.org/D38943?vs=119162&id=119444#toc Repository: rL LLVM https://reviews.llvm.org/D3

[PATCH] D39048: Dump signed integers in SymIntExpr and IntSymExpr correctly

2017-10-19 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL316157: [analyzer] Dump signed integers in SymIntExpr and IntSymExpr correctly (authored by xazax). Changed prior to commit: https://reviews.llvm.org/D39048?vs=119466&id=119569#toc Repository: rL LLV

[PATCH] D38578: [preamble] Also record the "skipping" state of the preprocessor

2017-10-19 Thread Cameron via Phabricator via cfe-commits
cameron314 added a comment. @nik, pretty sure this fix I submitted ages ago fixes that. Been using it in production a couple years. Would be nice if someone reviewed it so we could finally upstream it. https://reviews.llvm.org/D38578 ___

[PATCH] D39105: Patch bug 27628 (clang-tidy should exit with a failure code when there are errors)

2017-10-19 Thread Antoni via Phabricator via cfe-commits
antoyo created this revision. Update clang-tidy to return 1 when there's an error. https://reviews.llvm.org/D39105 Files: clang-tidy/tool/ClangTidyMain.cpp Index: clang-tidy/tool/ClangTidyMain.cpp === --- clang-tidy/tool/ClangT

[PATCH] D39122: [Sema] Fixes for enum handling for tautological comparison diagnostics

2017-10-21 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL316268: [Sema] Fixes for enum handling for tautological comparison diagnostics (authored by lebedevri). Changed prior to commit: https://reviews.llvm.org/D39122?vs=119759&id=119760#toc Repository: rL

[PATCH] D38720: [clangd] Report proper kinds for 'Keyword' and 'Snippet' completion items.

2017-10-22 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL316311: [clangd] Report proper kinds for 'Keyword' and 'Snippet' completion items. (authored by ibiryukov). Repository: rL LLVM https://reviews.llvm.org/D38720 Files: clang-tools-extra/trunk/clangd/

[PATCH] D38731: [clangd] Allow to pass code completion opts to ClangdServer.

2017-10-23 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL316327: [clangd] Allow to pass code completion opts to ClangdServer. (authored by ibiryukov). Changed prior to commit: https://reviews.llvm.org/D38731?vs=118385&id=119849#toc Repository: rL LLVM htt

[PATCH] D38683: [X86][AVX512] lowering broadcastm intrinsic - clang part

2017-10-23 Thread jina via Phabricator via cfe-commits
jina.nahias added inline comments. Comment at: test/CodeGen/avx512cdintrin.c:106 + // CHECK: insertelement <16 x i32> %{{.*}}, i32 %{{.*}} + return _mm512_broadcastmw_epi32(_mm512_cmpeq_epi32_mask ( a, b)); } RKSimon wrote: > Any reason why you can't use the

[PATCH] D38939: [clangd] Handle exit notification (proper shutdown)

2017-10-25 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL316564: [clangd] Handle exit notification (proper shutdown) (authored by ibiryukov). Changed prior to commit: https://reviews.llvm.org/D38939?vs=119941&id=120210#toc Repository: rL LLVM https://revi

[PATCH] D38629: [clangd] Added a callback-based codeComplete in clangd.

2017-10-25 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL316565: [clangd] Added a callback-based codeComplete in clangd. (authored by ibiryukov). Changed prior to commit: https://reviews.llvm.org/D38629?vs=119813&id=120218#toc Repository: rL LLVM https://

[PATCH] D37624: add support for -fno-instrument-functions and -finstrument-functions-exclude-{file, function}-list= to match gcc options.

2017-10-25 Thread kchoi via Phabricator via cfe-commits
choikwa updated this revision to Diff 120252. choikwa added a comment. rebase to trunk https://reviews.llvm.org/D37624 Files: docs/ClangCommandLineReference.rst include/clang/Driver/Options.td include/clang/Frontend/CodeGenOptions.h lib/CodeGen/CodeGenFunction.cpp lib/CodeGen/CodeGenF

[PATCH] D50768: [analyzer] Delete SMTContext. NFC.

2018-08-23 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC340532: [analyzer] Delete SMTContext. NFC. (authored by mramalho, committed by ). Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D50768 Files: include/clang/St

[PATCH] D50773: [analyzer] added cache for SMT queries in the SMTConstraintManager

2018-08-23 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC340535: [analyzer] added cache for SMT queries in the SMTConstraintManager (authored by mramalho, committed by ). Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D

[PATCH] D51172: [libcxx] Comment out #define __cpp_lib_node_extract, we only support half of that functionality

2018-08-23 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rCXX340544: Comment out #define __cpp_lib_node_extract, we only support half of that… (authored by epilk, committed by ). Changed prior to commit: https://reviews.llvm.org/D51172?vs=162208&id=162215#toc

[PATCH] D50043: [RISCV] RISC-V using -fuse-init-array by default

2018-08-23 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL340595: [RISCV] RISC-V using -fuse-init-array by default (authored by kito, committed by ). Herald added subscribers: llvm-commits, jrtc27. Changed prior to commit: https://reviews.llvm.org/D50043?vs=16

[PATCH] D51164: [Tooling] Add a isSingleProcess() helper to ToolExecutor

2018-08-24 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC340599: [Tooling] Add a isSingleProcess() helper to ToolExecutor (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D51164?vs=162182&id=162345#toc Repository: r

[PATCH] D51155: [clangd] Allow to merge symbols on-the-fly in global-symbol-builder

2018-08-24 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL340600: [clangd] Allow to merge symbols on-the-fly in global-symbol-builder (authored by ibiryukov, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org

[PATCH] D50993: [clangd] Increase stack size of the new threads on macOS

2018-08-24 Thread Dmitry via Phabricator via cfe-commits
Dmitry.Kozhevnikov added a comment. In https://reviews.llvm.org/D50993#1212130, @ilya-biryukov wrote: > @Dmitry.Kozhevnikov, do you need us to land the patch? > Any last changes you'd like to make? It’s blocked by the llvm review, which has some valid comments I’ll address today. After that,

[PATCH] D49851: [clang-tidy] run-clang-tidy add synchronisation to the output

2018-08-24 Thread Andi via Phabricator via cfe-commits
Abpostelnicu added a comment. In https://reviews.llvm.org/D49851#1203676, @JonasToth wrote: > In https://reviews.llvm.org/D49851#1202764, @Abpostelnicu wrote: > > > Strangely I haven't had those kind of issues but since you propose those > > modifications I would do one more modification, let's

[PATCH] D49851: [clang-tidy] run-clang-tidy add synchronisation to the output

2018-08-24 Thread Andi via Phabricator via cfe-commits
Abpostelnicu updated this revision to Diff 162387. https://reviews.llvm.org/D49851 Files: clang-tidy/tool/run-clang-tidy.py Index: clang-tidy/tool/run-clang-tidy.py === --- clang-tidy/tool/run-clang-tidy.py +++ clang-tidy/tool/ru

[PATCH] D51220: [clang-tidy] run-clang-tidy fails using python 3.7

2018-08-24 Thread Andi via Phabricator via cfe-commits
Abpostelnicu updated this revision to Diff 162391. https://reviews.llvm.org/D51220 Files: clang-tidy/tool/run-clang-tidy.py Index: clang-tidy/tool/run-clang-tidy.py === --- clang-tidy/tool/run-clang-tidy.py +++ clang-tidy/tool/ru

[PATCH] D51220: [clang-tidy] run-clang-tidy fails using python 3.7

2018-08-24 Thread Andi via Phabricator via cfe-commits
Abpostelnicu added a comment. In https://reviews.llvm.org/D51220#1212463, @JonasToth wrote: > I don't know a lot about how to write portable code! > > But wouldn't this be out usecase? > http://python-future.org/compatible_idioms.html#file-io-with-open > Using the `decode` is supposed to work i

[PATCH] D51220: [clang-tidy] run-clang-tidy fails using python 3.7

2018-08-24 Thread Andi via Phabricator via cfe-commits
Abpostelnicu added a comment. I can confirm tested on: 2.7.15 3.7.0 On both it worked. - F7047650: signature.asc https://reviews.llvm.org/D51220 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lis

[PATCH] D33029: [clang-format] add option for dangling parenthesis

2018-08-25 Thread Thomas via Phabricator via cfe-commits
zroug added a comment. I'd also like to note that this is the code style preferred by most modern code formatters that I know of and use: - rustfmt for rust code - prettier for javascript code - black for python code https://reviews.llvm.org/D33029 __

[PATCH] D50101: [asan] Update a vector's storage annotation during destruction.

2018-08-25 Thread Ben via Phabricator via cfe-commits
bobsayshilol added a comment. Pinging this as it's been "Ready to Land" for a while and I want to check that that's not because I've forgotten to do something? Repository: rCXX libc++ https://reviews.llvm.org/D50101 ___ cfe-commits mailing list

[PATCH] D50455: Continue emitting diagnostics after a fatal error

2018-08-26 Thread Dmitry via Phabricator via cfe-commits
Dmitry.Kozhevnikov marked an inline comment as done. Dmitry.Kozhevnikov added a comment. In https://reviews.llvm.org/D50455#1193468, @ilya-biryukov wrote: > Nevertheless, I think this is moving clangd in the right direction and if we > see too many irrelevant errors, we should look into improvin

[PATCH] D50462: Try building complete AST after a fatal error was emitted if further diagnostics are expected

2018-08-27 Thread Dmitry via Phabricator via cfe-commits
Dmitry.Kozhevnikov added a comment. When lookin through the list of the fatal errors, I think there are different categories: 1. "Scary" ones - "module was relocated", "invalid vfs overlay file", we probably shouldn't try to recover from it 2. "User" errors (include not found, too many errors)

[PATCH] D51312: [OpenMP][NVPTX] Use appropriate _CALL_ELF macro when offloading

2018-08-27 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC340772: [OpenMP][NVPTX] Use appropriate _CALL_ELF macro when offloading (authored by gbercea, committed by ). Changed prior to commit: https://reviews.llvm.org/D51312?vs=162708&id=162734#toc Repository

[PATCH] D51314: Parse compile commands lazily in InterpolatingCompilationDatabase

2018-08-28 Thread Phabricator via Phabricator via cfe-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL340838: Parse compile commands lazily in InterpolatingCompilationDatabase (authored by ibiryukov, committed by ). Herald a

[PATCH] D51239: [ubsan] Enable -fsanitize=vptr on Apple devices and simulators

2018-08-28 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL340849: [ubsan] Enable -fsanitize=vptr on Apple devices and simulators (authored by vedantk, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D5

[PATCH] D51212: [OpenCL][Docs] Release notes for OpenCL in Clang

2018-08-29 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL340910: [Docs] Release notes for OpenCL (authored by stulova, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D51212?vs=162362&id=163034#toc R

[PATCH] D51093: [ARM] Set __ARM_FEATURE_SIMD32 for +dsp cores

2018-08-29 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL340911: [ARM] Set __ARM_FEATURE_SIMD32 for +dsp cores (authored by sam_parker, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D51093?vs=161925

[PATCH] D49916: [CodeGen] Add to emitted DebugLoc information about coverage when it's required

2018-08-29 Thread calixte via Phabricator via cfe-commits
calixte updated this revision to Diff 163062. calixte added a comment. - Use ImplicitCode instead of Covered - Set Artificial location as ImplicitCode to avoid coverage on landing pads Repository: rC Clang https://reviews.llvm.org/D49916 Files: lib/CodeGen/CGDebugInfo.cpp lib/CodeGen/CGD

[PATCH] D51407: [Tooling] Do not restore working dir in ClangTool

2018-08-29 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL340937: [Tooling] Do not restore working dir in ClangTool (authored by ibiryukov, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D51407 Files:

[PATCH] D51407: [Tooling] Do not restore working dir in ClangTool

2018-08-29 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC340937: [Tooling] Do not restore working dir in ClangTool (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D51407?vs=163122&id=163127#toc Repository: rC Clang

[PATCH] D50824: [CFG] [analyzer] pr37769: Disable argument construction contexts for variadic functions.

2018-08-29 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL340975: [CFG] [analyzer] Disable argument construction contexts for variadic functions. (authored by dergachev, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://

[PATCH] D50855: [analyzer] pr37578: Fix lvalue/rvalue problem in field-of-temporary adjustments.

2018-08-29 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL340977: [CFG] [analyzer] Disable argument construction contexts for variadic functions. (authored by dergachev, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://

[PATCH] D50866: [analyzer] CFRetainReleaseChecker: Avoid checking C++ methods with the same name.

2018-08-29 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC340982: [analyzer] CFRetainReleaseChecker: Don't check C++ methods with the same name. (authored by dergachev, committed by ). Repository: rC Clang https://reviews.llvm.org/D50866 Files: lib/StaticA

[PATCH] D51191: [analyzer] Support modelling no-op BaseToDerived casts in ExprEngine

2018-08-29 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC340984: [analyzer] Support modeling no-op BaseToDerived casts in ExprEngine. (authored by dergachev, committed by ). Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.or

[PATCH] D51436: [CodeComplete] Report location of opening parens for signature help

2018-08-30 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL341063: [CodeComplete] Report location of opening parens for signature help (authored by ibiryukov, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org

[PATCH] D51437: [clangd] Report position of opening paren in singature help

2018-08-30 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rCTE341065: [clangd] Report position of opening paren in singature help (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D51437?vs=163286&id=163317#toc Repository

[PATCH] D51385: [analyzer] InnerPointerChecker: Fix a segfault.

2018-08-30 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC341092: [analyzer] InnerPointerChecker: Fix a segfault when checking symbolic strings. (authored by dergachev, committed by ). Changed prior to commit: https://reviews.llvm.org/D51385?vs=162963&id=16338

[PATCH] D50564: Add support for SEH unwinding on Windows.

2018-08-30 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL341125: Add support for SEH unwinding on Windows. (authored by cdavis, committed by ). Repository: rL LLVM https://reviews.llvm.org/D50564 Files: libunwind/trunk/include/__libunwind_config.h libun

[PATCH] D51509: [AddressSpace] Use the macro to set hidden visibility on LocalAddressSpace.

2018-08-31 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL341210: [AddressSpace] Use the macro to set hidden visibility on LocalAddressSpace. (authored by cdavis, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llv

[PATCH] D51508: Export public functions implemented in assembly on Windows.

2018-08-31 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL341232: Export public functions implemented in assembly on Windows. (authored by cdavis, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D51508 Fi

[PATCH] D51598: [clangd] Avoid crashes in override completions

2018-09-03 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL341322: [clangd] Avoid crashes in override completions (authored by ibiryukov, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D51598 Files: cla

[PATCH] D45050: [clang-tidy] New checker for not null-terminated result caused by strlen(), size() or equal length

2018-09-04 Thread Whisperity via Phabricator via cfe-commits
whisperity added a comment. Whew, this is a big one. Generally looks good, although I would separate implementation detail functions a bit better, with perhaps more comments to move them apart a bit, it is really harsh to scroll through. Could you please re-run the findings on the projects? The

[PATCH] D45050: [clang-tidy] New checker for not null-terminated result caused by strlen(), size() or equal length

2018-09-04 Thread Whisperity via Phabricator via cfe-commits
whisperity added a comment. Generally grammar / phrasing things that have caught my eye. The rest of the code looks okay, bar my previous comment about better commenting / separating chunks of helper functions. Comment at: clang-tidy/bugprone/NotNullTerminatedResultCheck.cpp:

[PATCH] D50488: [Analyzer] Checker for non-determinism caused by sorting of pointer-like keys

2018-09-04 Thread Whisperity via Phabricator via cfe-commits
whisperity added a comment. Minor comments in-line, looking good on first glance. I'm not sure if we discussed, has this checker been tried on some in-the-wild examples? To see if there are some real findings or crashes? There is a good selection of projects here in this tool: https://github.co

[PATCH] D50488: [Analyzer] Checker for non-determinism caused by sorting of pointer-like keys

2018-09-04 Thread Whisperity via Phabricator via cfe-commits
whisperity added a project: clang. whisperity added a comment. @Szelethus `clang-query` seems to sometimes not include matcher functions that are perfectly available in the code... I recently had some issue with using `isUserDefined()`, it was available in my code, but `clang-query` always reje

[PATCH] D46081: [analyzer] Expand conversion check to check more expressions for overflow and underflow

2018-09-04 Thread Whisperity via Phabricator via cfe-commits
whisperity added a comment. Ping. Shouldn't let this thing go to waste. https://reviews.llvm.org/D46081 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D51359: Adding HardLink Support to VirtualFileSystem.

2018-09-04 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL341366: Adding HardLink Support to VirtualFileSystem. (authored by ibiryukov, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D51359?vs=163785&

[PATCH] D51644: [CMake] Remove variable reference that isn't used.

2018-09-04 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL341388: [CMake] Remove variable reference that isn't used. (authored by cdavis, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D51644 Files: li

[PATCH] D51635: clang-cl: Pass /Brepro to linker if it was passed to the compiler

2018-09-04 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC341390: clang-cl: Pass /Brepro to linker if it was passed to the compiler (authored by nico, committed by ). Changed prior to commit: https://reviews.llvm.org/D51635?vs=163829&id=163870#toc Repository:

[PATCH] D51645: [CMake] Don't use -rtlib=compiler-rt with -nodefaultlibs.

2018-09-04 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rUNW341404: [CMake] Don't use -rtlib=compiler-rt with -nodefaultlibs. (authored by cdavis, committed by ). Changed prior to commit: https://reviews.llvm.org/D51645?vs=163864&id=163907#toc Repository: r

[PATCH] D50488: [Analyzer] Checker for non-determinism caused by sorting of pointer-like elements

2018-09-05 Thread Whisperity via Phabricator via cfe-commits
whisperity added a subscriber: martong. whisperity added a comment. Make sure you use only the C++ projects like BitCoin, LLVM/Clang, ProtoBuf and such from the Xazax CSA Test suite because this checker is not really applicable to C projects. Generally I like the idea (personally I've ran into

[PATCH] D51649: [Sema] Don't warn about omitting unavailable enum constants in a switch

2018-09-05 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL341490: [Sema] Don't warn about omitting unavailable enum constants in a switch (authored by epilk, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm

[PATCH] D50488: [Analyzer] Checker for non-determinism caused by sorting of pointer-like elements

2018-09-06 Thread Whisperity via Phabricator via cfe-commits
whisperity added a comment. In https://reviews.llvm.org/D50488#1225064, @george.karpenkov wrote: > Why explicitly skip C projects? We would not be able to match `std::X` > functions anyway. Why spend time constructing matchers and running on the AST when we are sure that generating any resul

[PATCH] D51697: [Sema] Clean up some __builtin_*_chk diagnostics

2018-09-06 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL341566: [Sema] Clean up some __builtin_*_chk diagnostics (authored by epilk, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D51697?vs=164087&i

[PATCH] D45050: [clang-tidy] New checker for not null-terminated result caused by strlen(), size() or equal length

2018-09-07 Thread Whisperity via Phabricator via cfe-commits
whisperity added a comment. https://reviews.llvm.org/D50353 has landed, so after a rebase this patch will not compile. https://reviews.llvm.org/D45050 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/lis

[PATCH] D51782: [CodeComplete] Clearly distinguish signature help and code completion.

2018-09-07 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC341660: [CodeComplete] Clearly distinguish signature help and code completion. (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D51782?vs=164398&id=164415#toc R

[PATCH] D51771: [X86] Modify addcarry/subborrow builtins to emit an 2 result and intrinsic and an store instruction.

2018-09-07 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC341678: [X86] Modify addcarry/subborrow builtins to emit an 2 result and intrinsic and… (authored by ctopper, committed by ). Changed prior to commit: https://reviews.llvm.org/D51771?vs=164357&id=164452

[PATCH] D51805: [X86] Custom emit __builtin_rdtscp so we can emit an explicit store for the out parameter

2018-09-07 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL341699: [X86] Custom emit __builtin_rdtscp so we can emit an explicit store for the out… (authored by ctopper, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://r

[PATCH] D51784: ms: Insert $$Z in mangling between directly consecutive parameter packs.

2018-09-08 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC341755: ms: Insert $$Z in mangling between directly consecutive parameter packs. (authored by nico, committed by ). Changed prior to commit: https://reviews.llvm.org/D51784?vs=164402&id=164577#toc Repo

[PATCH] D51378: [OPENMP] Add support for nested 'declare target' directives

2018-09-09 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC341766: [OpenMP] Add support for nested 'declare target' directives (authored by kli, committed by ). Changed prior to commit: https://reviews.llvm.org/D51378?vs=164037&id=164596#toc Repository: rC C

[PATCH] D51807: Remove all uses of DIFlagBlockByrefStruct from Clang

2018-09-10 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL341842: Remove all uses of DIFlagBlockByrefStruct (authored by adrian, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D51807?vs=164475&id=1646

[PATCH] D51884: [clang-tidy] ExprMutationAnalyzer: construct from references. Fixes PR38888

2018-09-10 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rCTE341854: [clang-tidy] ExprMutationAnalyzer: construct from references. Fixes PR3 (authored by lebedevri, committed by ). Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51884 Files:

[PATCH] D51189: [Sema][ObjC] Infer availability of +new from availability of -init

2018-09-10 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL341874: [Sema][ObjC] Infer availability of +new from availability of -init. (authored by epilk, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org

[PATCH] D51864: [Tooling] Restore working dir in ClangTool.

2018-09-11 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC341910: [Tooling] Restore working dir in ClangTool. (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D51864?vs=164686&id=164816#toc Repository: rC Clang http

[PATCH] D49916: [CodeGen] Add to emitted DebugLoc information about coverage when it's required

2018-09-11 Thread calixte via Phabricator via cfe-commits
calixte updated this revision to Diff 164851. calixte added a comment. - Add some ImplicitCode when there is some stuff at the end of a function - Fix the tests Repository: rC Clang https://reviews.llvm.org/D49916 Files: lib/CodeGen/CGDebugInfo.cpp lib/CodeGen/CGDebugInfo.h lib/CodeGen

[PATCH] D49916: [CodeGen] Add to emitted DebugLoc information about coverage when it's required

2018-09-11 Thread calixte via Phabricator via cfe-commits
calixte updated this revision to Diff 164860. calixte added a comment. - only put an ImplicitCode for EmitLandingPad - fix tests (were broken with clanf-format-diff) Repository: rC Clang https://reviews.llvm.org/D49916 Files: lib/CodeGen/CGDebugInfo.cpp lib/CodeGen/CGDebugInfo.h lib/Co

[PATCH] D51926: [scan-build-py] Prevent crashes of CTU analysis by suppressing warnings

2018-09-11 Thread Whisperity via Phabricator via cfe-commits
whisperity added a comment. Will this properly synergise across compilers with user-specified warning options, such as `-Wall -Werror`? Repository: rC Clang https://reviews.llvm.org/D51926 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D51945: [Clang] Fix test to followup https://reviews.llvm.org/rL341977

2018-09-11 Thread calixte via Phabricator via cfe-commits
calixte created this revision. calixte added a reviewer: vsk. Herald added a subscriber: cfe-commits. In the previous patch, __llvm_gcov_indirect_counter_increment has been removed. Repository: rC Clang https://reviews.llvm.org/D51945 Files: test/CodeGen/code-coverage.c Index: test/CodeG

[PATCH] D51945: [Clang] Fix test to followup https://reviews.llvm.org/rL341977

2018-09-11 Thread calixte via Phabricator via cfe-commits
calixte added a comment. My bad, I missed that Repository: rC Clang https://reviews.llvm.org/D51945 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D51987: [clangd] Rename global-symbol-builder to clangd-indexer.

2018-09-13 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL342123: [clangd] Rename global-symbol-builder to clangd-indexer. (authored by ibiryukov, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D51987

[PATCH] D52034: [Clang] Add options -Xclang -coverage-filter and -Xclang -coverage-exclude to filter the files to instrument with gcov

2018-09-13 Thread calixte via Phabricator via cfe-commits
calixte created this revision. calixte added reviewers: marco-c, vsk. Herald added a subscriber: cfe-commits. These options are taking regex separated by colons to filter files. - if both are empty then all files are instrumented - if -coverage-filter is empty then all the filenames matching any

[PATCH] D52034: [Clang] Add options -Xclang -coverage-filter and -Xclang -coverage-exclude to filter the files to instrument with gcov

2018-09-13 Thread calixte via Phabricator via cfe-commits
calixte added inline comments. Comment at: include/clang/Driver/CC1Options.td:236 +def coverage_exclude_EQ : Joined<["-"], "coverage-exclude=">, + Alias; def coverage_exit_block_before_body : Flag<["-"], "coverage-exit-block-before-body">, vsk wrote: > Have yo

[PATCH] D50927: [Sema] Remove location from implicit capture init expr

2018-09-13 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC342194: [Sema] Remove location from implicit capture init expr (authored by vedantk, committed by ). Changed prior to commit: https://reviews.llvm.org/D50927?vs=162918&id=165400#toc Repository: rL LL

[PATCH] D50927: [Sema] Remove location from implicit capture init expr

2018-09-13 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL342194: [Sema] Remove location from implicit capture init expr (authored by vedantk, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D50927?vs=

[PATCH] D49360: [analyzer] Add support for more basic_string API in DanglingInternalBufferChecker

2018-07-19 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC337463: [analyzer] Add support for more basic_string API in (authored by rkovacs, committed by ). Repository: rC Clang https://reviews.llvm.org/D49360 Files: lib/StaticAnalyzer/Checkers/DanglingInte

[PATCH] D49112: [Sema] Implement -Wmemset-transposed-args

2018-07-19 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC337470: [Sema] Add a new warning, -Wmemset-transposed-args (authored by epilk, committed by ). Changed prior to commit: https://reviews.llvm.org/D49112?vs=156178&id=156298#toc Repository: rC Clang h

[PATCH] D49232: [analyzer] Memoize complexity of SymExpr

2018-07-19 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC337472: [analyzer] Memoize complexity of SymExpr (authored by mramalho, committed by ). Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D49232 Files: include/cl

[PATCH] D49085: [Sema] Emit a diagnostic for an invalid dependent function template specialization

2018-07-19 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL337497: [Sema] Diagnose an invalid dependent function template specialization (authored by epilk, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.o

[PATCH] D49553: [analyzer] Rename DanglingInternalBufferChecker to InnerPointerChecker

2018-07-20 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL337559: [analyzer] Rename DanglingInternalBufferChecker to InnerPointerChecker. (authored by rkovacs, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.ll

[PATCH] D49302: [AST] Various micro-optimizations in CXXInheritance

2018-07-20 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL337607: [AST] Various micro-optimizations in CXXInheritance (authored by d0k, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D49302?vs=155392&

[PATCH] D48873: [AST] Use llvm::TrailingObjects in CXXTryStmt

2018-07-23 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL337688: [AST] Use llvm::TrailingObjects in CXXTryStmt (authored by d0k, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D48873?vs=155564&id=156

[PATCH] D48873: [AST] Use llvm::TrailingObjects in CXXTryStmt

2018-07-23 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC337688: [AST] Use llvm::TrailingObjects in CXXTryStmt (authored by d0k, committed by ). Changed prior to commit: https://reviews.llvm.org/D48873?vs=155564&id=156759#toc Repository: rL LLVM https://r

[PATCH] D49688: [Sema] Fix a crash when a BlockExpr appears in a default-member-initializer of a class template

2018-07-23 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC337766: [Sema] Fix crash on BlockExprs in a default member initializers (authored by epilk, committed by ). Changed prior to commit: https://reviews.llvm.org/D49688?vs=156848&id=156906#toc Repository:

[PATCH] D49703: [analyzer] pr38273: Admit that we can't handle the newly produced Loc<>NonLoc comparisons.

2018-07-23 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC337769: [analyzer] pr38273: Legalize Loc<>NonLoc comparison symbols. (authored by dergachev, committed by ). Repository: rC Clang https://reviews.llvm.org/D49703 Files: lib/StaticAnalyzer/Core/Range

[PATCH] D40526: [WebAssembly] Change size_t to `unsigned long`

2018-07-23 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC337783: [WebAssembly] Change size_t to `unsigned long`. (authored by djg, committed by ). Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D40526 Files: lib/Basi

[PATCH] D46230: For x86_64, gcc 7.2 under Amazon Linux AMI sets its paths to x86_64-amazon-linux

2018-07-23 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL337811: For x86_64, gcc 7.2 under Amazon Linux AMI sets its path to x86_64-amazon-linux. (authored by jiadinggai, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https:

[PATCH] D49508: [Sema] Mark implicitly-inserted ICE's as being part of explicit cast (PR38166)

2018-07-24 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC337815: [Sema] Mark implicitly-inserted ICE's as being part of explicit cast (PR38166) (authored by lebedevri, committed by ). Repository: rC Clang https://reviews.llvm.org/D49508 Files: include/cla

[PATCH] D49508: [Sema] Mark implicitly-inserted ICE's as being part of explicit cast (PR38166)

2018-07-24 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL337815: [Sema] Mark implicitly-inserted ICE's as being part of explicit cast (PR38166) (authored by lebedevri, committed by ). Changed prior to commit: https://reviews.llvm.org/D49508?vs=156705&id=15697

[PATCH] D45094: [LibTooling] Make interface of VFS injection into ClangTool more user-friendly

2018-07-25 Thread Whisperity via Phabricator via cfe-commits
whisperity added a comment. Softly pinging this. Perhaps we could discuss this and get it in before Clang7 rides off into the sunset? https://reviews.llvm.org/D45094 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-

[PATCH] D45095: [clang-tidy] Align usage of ClangTool interface with new VFS injection

2018-07-25 Thread Whisperity via Phabricator via cfe-commits
whisperity added a comment. Akin to https://reviews.llvm.org/D45094, pinging this too. 🙂 https://reviews.llvm.org/D45095 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D49236: [analyzer] Moved static Context to class member

2018-07-25 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC337915: [analyzer] Moved static Context to class member (authored by mramalho, committed by ). Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D49236 Files: lib

[PATCH] D49668: [analyzer] Moved non solver specific code from Z3ConstraintManager to SMTConstraintManager

2018-07-25 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC337919: [analyzer] Moved non solver specific code from Z3ConstraintManager to… (authored by mramalho, committed by ). Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.o

[PATCH] D49768: [analyzer] Removed API used by the Refutation Manager from SMTConstraintManager and replace by proper calls to SMTSolver

2018-07-25 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC337922: [analyzer] Removed API used by the Refutation Manager from SMTConstraintManager… (authored by mramalho, committed by ). Herald added a subscriber: cfe-commits. Repository: rC Clang https://revi

<    3   4   5   6   7   8   9   10   11   12   >