[PATCH] D67888: [clang-format] NFC clang-format the clang-format unit tests

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: klimek, owenpan, timwoj. MyDeveloperDay added a project: clang-tools-extra. Herald added a project: clang. It is annoying that the clang-format tests aren't themselves clang-formatted, if you use a format on save option in VS o

[PATCH] D67888: [clang-format] NFC clang-format the clang-format unit tests

MyDeveloperDay updated this revision to Diff 221214. MyDeveloperDay added a comment. wrong patch file CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67888/new/ https://reviews.llvm.org/D67888 Files: clang/unittests/Format/FormatTest.cpp Index: clang/unittests/Format/FormatTest.cpp ==

[PATCH] D67889: [clang] fixing conditional explicit for out-of-line definition PR42980

Tyker created this revision. Tyker added reviewers: rsmith, aaron.ballman. Herald added a project: clang. Herald added a subscriber: cfe-commits. not every read in CXXConstructorDecl::getExplicitSpecifierInternal() was made on the canonical declaration. Repository: rC Clang https://reviews.l

[PATCH] D67883: [CLANG][BPF] permit any argument type for __builtin_preserve_access_index()

This revision was automatically updated to reflect the committed changes. Closed by commit rL372516: [CLANG][BPF] permit any argument type for __builtin_preserve_access_index() (authored by yhs, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior t

[PATCH] D67889: [clang] fixing conditional explicit for out-of-line definition PR42980

This revision was automatically updated to reflect the committed changes. Closed by commit rL372530: [clang] fixing conditional explicit for out-of-line definition PR42980 (authored by Tyker, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to c

[PATCH] D67888: [clang-format] NFC clang-format the clang-format unit tests

MyDeveloperDay added a comment. In D67888#1678465 , @owenpan wrote: > I suppose the .clang-format file you used only had `BasedOnStyle: LLVM` in > it. Did you run clang-format the second time to ensure that the formatted > file was stable? it used the

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

serge-sans-paille updated this revision to Diff 221321. serge-sans-paille added a comment. Updates: - fix typo in documentation - take into account @andwar advices - improve shared/static build automation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D67843: DisableFormat also now disables SortIncludes

MyDeveloperDay added a subscriber: klimek. MyDeveloperDay added a comment. I basically agree with all the comments, I agree with you that I doubt its ever used in SortIncludes:true and DisableFormat:true, I just saw this as a hole that probably based on Myrums Law (https://www.hyrumslaw.com/) m

[PATCH] D38446: update comments in clang-format.py for python3 compatibility

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. I'm not python expert but as this is a comment I don't see any issue. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D38446/new/ https://rev

[PATCH] D63640: [clang] Improve Serialization/Imporing/Dumping of APValues

Tyker added inline comments. Comment at: clang/include/clang/AST/APValue.h:618 } + const CXXRecordDecl **getMemberPointerPathPtr(); }; aaron.ballman wrote: > We're horribly inconsistent in this class, but because the other private > member functions go with

[PATCH] D63640: [clang] Improve Serialization/Imporing/Dumping of APValues

Tyker updated this revision to Diff 221384. Tyker marked 12 inline comments as done. Tyker retitled this revision from "[clang] Improve Serialization/Imporing of APValues" to "[clang] Improve Serialization/Imporing/Dumping of APValues". Tyker edited the summary of this revision. Tyker added a comm

[PATCH] D67613: [DWARF-5] Support for DWARF-5 C++ language tags

This revision was automatically updated to reflect the committed changes. Closed by commit rL372663: Support for DWARF-5 C++ language tags. (authored by adrian, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.o

[PATCH] D67888: [clang-format] NFC clang-format the clang-format unit tests

This revision was automatically updated to reflect the committed changes. Closed by commit rL372689: [clang-format] NFC clang-format the clang-format unit tests (authored by paulhoad, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D67949: [clang-format] [PR36858] Add missing .hh and .cs extensions from python support utilities

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: pseyfert, klimek, owenpan. MyDeveloperDay added a project: clang-tools-extra. Herald added a project: clang. https://bugs.llvm.org/show_bug.cgi?id=36858 identifies .hh as a missing C++ header extension file while making this ch

[PATCH] D67949: [clang-format] [PR36858] Add missing .hh and .cs extensions from python support utilities

This revision was automatically updated to reflect the committed changes. Closed by commit rL372760: [clang-format] [PR36858] Add missing .hh and .cs extensions from python support… (authored by paulhoad, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Chang

[PATCH] D63640: [clang] Improve Serialization/Imporing/Dumping of APValues

Tyker updated this revision to Diff 221568. Tyker marked 7 inline comments as done. Tyker added a comment. fixed most comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63640/new/ https://reviews.llvm.org/D63640 Files: clang/include/clang/AST/APValue.h clang/include/clang/AST/A

[PATCH] D63640: [clang] Improve Serialization/Imporing/Dumping of APValues

Tyker added inline comments. Comment at: clang/lib/AST/APValue.cpp:599 Out << '[' << Path[I].getAsArrayIndex() << ']'; -ElemTy = Ctx.getAsArrayType(ElemTy)->getElementType(); +ElemTy = cast(ElemTy)->getElementType(); } aaron.ballma

[PATCH] D44609: [Clang-Format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style)

MyDeveloperDay added a comment. Thanks for the patch, so sorry its taking a long time, its patches like this why I'm about to make a phabricator project for #clang-format alone so that we can ensure all clang-format patches can be see in isolation. I think we need to get this patches rebased to

[PATCH] D60199: [clang-format] Do not emit replacements while regrouping if Cpp includes are OK

MyDeveloperDay added a comment. Possible fix for PR43372 (https://bugs.llvm.org/show_bug.cgi?id=43372) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60199/new/ https://reviews.llvm.org/D60199 ___ cfe-commits mailing

[PATCH] D67826: [clangd] A helper to find explicit references and their names

This revision was automatically updated to reflect the committed changes. Closed by commit rL372859: [clangd] A helper to find explicit references and their names (authored by ibiryukov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit

[PATCH] D67825: [AST] Extract Decl::printNestedNameSpecifier helper from Decl::printQualifiedName

This revision was automatically updated to reflect the committed changes. Closed by commit rL372863: [AST] Extract Decl::printNestedNameSpecifier helper from Decl… (authored by ibiryukov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commi

[PATCH] D67774: [Mangle] Add flag to asm labels to disable '\01' prefixing

This revision was automatically updated to reflect the committed changes. Closed by commit rL372903: [Mangle] Add flag to asm labels to disable '\01' prefixing (authored by vedantk, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: h

[PATCH] D64695: [clang-format] Modified SortIncludes and IncludeCategories to priority for sorting #includes within the Group Category.

This revision was automatically updated to reflect the committed changes. Closed by commit rL372919: [clang-format] Modified SortIncludes and IncludeCategories to priority for… (authored by paulhoad, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed pr

[PATCH] D63062: [clang-format] Added New Style Rule: BitFieldDeclarationsOnePerLine

MyDeveloperDay added inline comments. Comment at: lib/Format/FormatToken.h:524 +T = T->getPreviousNonComment(); +return (T->Tok.is(tok::comma) && Tok.is(tok::identifier) && +T->Next->Tok.is(tok::colon)); Manikishan wrote: > MyDeveloperDay wrot

[PATCH] D68072: Reference qualifiers in member templates causing extra indentation.

This revision was automatically updated to reflect the committed changes. Closed by commit rL373056: [clang-format] Reference qualifiers in member templates causing extra… (authored by ibiryukov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[PATCH] D68118: [clangd] Support OverloadExpr in findExplicitReferences

This revision was automatically updated to reflect the committed changes. Closed by commit rL373057: [clangd] Support OverloadExpr in findExplicitReferences (authored by ibiryukov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: ht

[PATCH] D68120: [clangd] Handle type template parameters in findExplicitReferences

This revision was automatically updated to reflect the committed changes. Closed by commit rL373067: [clangd] Handle type template parameters in findExplicitReferences (authored by ibiryukov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to c

[PATCH] D68132: clang-tidy: Don't repeat list of all checks in three places.

This revision was automatically updated to reflect the committed changes. Closed by commit rL373082: clang-tidy: Don't repeat list of all checks in three places. (authored by nico, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: ht

[PATCH] D63640: [clang] Improve Serialization/Imporing/Dumping of APValues

Tyker updated this revision to Diff 222169. Tyker marked 3 inline comments as done. Tyker added a comment. made renamings CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63640/new/ https://reviews.llvm.org/D63640 Files: clang/include/clang/AST/APValue.h clang/include/clang/AST/ASTCon

[PATCH] D68147: [MC][ELF] Prevent globals with an explicit section from being mergeable by default and add a safe option to allow mergeable

bd1976llvm created this revision. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. Alternative to https://reviews.llvm.org/D68101 Prevents globals with an explicit section from being mergeable by default (as in D68101

[PATCH] D68124: [clangd] Fix template type aliases in findExplicitReference

This revision was automatically updated to reflect the committed changes. Closed by commit rL373104: [clangd] Fix template type aliases in findExplicitReference (authored by ibiryukov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D68072: Reference qualifiers in member templates causing extra indentation.

MyDeveloperDay added a comment. As the number of clauses is vast, I think sometimes its worth just putting a one-line comment in to explain what construct you are matching, just to help future maintainers Comment at: clang/lib/Format/TokenAnnotator.cpp:1375 +} + // L

[PATCH] D60748: Fix i386 struct and union parameter alignment

LiuChen3 added a comment. In D60748#1681178 , @kib wrote: > In fact, can we have an option controlling this ? Does it have anything to > do with -malign-data gcc switch ? > > We do want to be able to optionally generate code ABI-compatible with modern >

[PATCH] D68072: [clang-format] Reference qualifiers in member templates causing extra indentation.

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. LG CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68072/new/ https://reviews.llvm.org/D68072 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D68072: [clang-format] Reference qualifiers in member templates causing extra indentation.

This revision was automatically updated to reflect the committed changes. Closed by commit rL373165: [clang-format] Reference qualifiers in member templates causing extra… (authored by paulhoad, committed by ). Changed prior to commit: https://reviews.llvm.org/D68072?vs=99&id=222322#toc Re

[PATCH] D68227: [clang-format] [PR43372] - clang-format shows replacements in DOS files when no replacement is needed

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: krasimir, klimek, owenpan, ioeric. MyDeveloperDay added a project: clang-format. Herald added a project: clang. MyDeveloperDay edited the summary of this revision. This is a patch to fix PR43372 (https://bugs.llvm.org/show_bug.c

[PATCH] D68227: [clang-format] [PR43372] - clang-format shows replacements in DOS files when no replacement is needed

MyDeveloperDay added a comment. Through experiments, I notice that both result and the Code contains "\r\n", because although we construct the results with "\n" the actual text of the include has I believe trailing "\r" or "\r\n", I notice this when I thought one fix I tried was to trim the inc

[PATCH] D68242: [clang-format] [PR42417] clang-format inserts a space after '->' for operator->() overloading

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: klimek, owenpan, byoungyoung. MyDeveloperDay added a project: clang-format. Herald added a project: clang. https://bugs.llvm.org/show_bug.cgi?id=42417 This revision removes the extra space between the opertor-> and the parens (

[PATCH] D68227: [clang-format] [PR43372] - clang-format shows replacements in DOS files when no replacement is needed

MyDeveloperDay updated this revision to Diff 222498. MyDeveloperDay added a comment. Being specific about replacing "\r\n"'s with "\n"'s rather than removing just \r's CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68227/new/ https://reviews.llvm.org/D68227 Files: clang/lib/Format/Fo

[PATCH] D68119: [clangd] Handle OverloadExpr in targetDecl

This revision was automatically updated to reflect the committed changes. Closed by commit rL373305: [clangd] Handle OverloadExpr in targetDecl (authored by ibiryukov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews

[PATCH] D68260: Decrease the verbosity of the -ftime-trace optionAnd move the relevant information in the doc.

This revision was automatically updated to reflect the committed changes. Closed by commit rL373308: Decrease the verbosity of the -ftime-trace option (authored by sylvestre, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINC

[PATCH] D14484: [clang-format] Formatting constructor initializer lists by putting them always on different lines

MyDeveloperDay requested changes to this revision. MyDeveloperDay added a comment. This revision now requires changes to proceed. Looking at this I'm wondering if this Isn't at least partially handled by the `BreakConstructorInitializersStyle` in combination with `ConstructorInitializerAllOnOne

[PATCH] D50078: clang-format: support aligned nested conditionals formatting

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. Thank you for this patch, (and by your patience ;-) ) This LGTM, Were there any objections from anyone else? otherwise I'd say this was ok. Repository: rC Clang CHANGES S

[PATCH] D68137: [clangd] Handle template arguments in findExplicitReferences

This revision was automatically updated to reflect the committed changes. Closed by commit rL373318: [clangd] Handle template arguments in findExplicitReferences (authored by ibiryukov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D68227: [clang-format] [PR43372] - clang-format shows replacements in DOS files when no replacement is needed

MyDeveloperDay updated this revision to Diff 222665. MyDeveloperDay set the repository for this revision to rC Clang. MyDeveloperDay added a project: clang-tools-extra. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68227/new/ https://reviews.llvm.org/D68227 Files:

[PATCH] D68227: [clang-format] [PR43372] - clang-format shows replacements in DOS files when no replacement is needed

This revision was automatically updated to reflect the committed changes. Closed by commit rL373388: [clang-format] [PR43372] - clang-format shows replacements in DOS files when no… (authored by paulhoad, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Chang

[PATCH] D68296: clang-format: Add ability to wrap braces after multi-line control statements

mitchell-stellar created this revision. mitchell-stellar added reviewers: sammccall, owenpan, reuk. mitchell-stellar added a project: clang-format. Herald added a project: clang. Herald added a subscriber: cfe-commits. Change the BraceWrappingFlags' AfterControlStatement from a bool to an enum wi

[PATCH] D68296: clang-format: Add ability to wrap braces after multi-line control statements

MyDeveloperDay requested changes to this revision. MyDeveloperDay added a comment. This revision now requires changes to proceed. Firstly thank you for the patch.. Prior authors have pointed out that new styles need to be supported by a large public style guide as evidence as to why clang-format

[PATCH] D68332: [clang-format] [PR43531] clang-format damages "alternative representations" for operators

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: klimek, reuk, owenpan, mitchell-stellar, STL_MSFT. MyDeveloperDay added projects: clang-format, clang-tools-extra. Herald added a project: clang. https://bugs.llvm.org/show_bug.cgi?id=43531 Fix for clang-format incorrectly han

[PATCH] D68296: clang-format: Add ability to wrap braces after multi-line control statements

mitchell-stellar updated this revision to Diff 222835. mitchell-stellar edited the summary of this revision. mitchell-stellar added a comment. Thanks for the review. I have added documentation updates. I do not have a public style guide to reference. My company just switched to auto-clang-format

[PATCH] D68296: clang-format: Add ability to wrap braces after multi-line control statements

MyDeveloperDay added a comment. As I mentioned, its worth getting evidence from a large public project... https://wiki.blender.org/index.php/Dev:Doc/Code_Style Blender public repo on github.com has 90 Forks, 299 * and 90,000 commits From their style guide Exceptions to Braces on Same Line

[PATCH] D68346: [clang-format] Add new option to add spaces around conditions

MyDeveloperDay requested changes to this revision. MyDeveloperDay added inline comments. This revision now requires changes to proceed. Comment at: clang/include/clang/Format/Format.h:1950 + /// similar) conditions. + bool SpacesAroundConditions; + its position

[PATCH] D68296: [clang-format] Add ability to wrap braces after multi-line control statements

MyDeveloperDay added a comment. @klimek thanks for offering for me to make the decision. I think given the fact that blender has it in their style guide and that they are clearly working around clang-formats inability to handle this case, I'm minded to LGTM this revision I hope you are ok with

[PATCH] D68296: [clang-format] Add ability to wrap braces after multi-line control statements

mitchell-stellar added a comment. @MyDeveloperDay I am not wedded to "OnlyMultiLine". I picked it, as it seemed reasonable to me, but if you think another string expresses the intent better, then feel free to use it. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D68296: [clang-format] Add ability to wrap braces after multi-line control statements

MyDeveloperDay requested changes to this revision. MyDeveloperDay added a comment. This revision now requires changes to proceed. Looks good but I think the option would be better as just `MultiLine`, remember to mark the comments "Done" when you are complete Comment at: clang

[PATCH] D68296: [clang-format] Add ability to wrap braces after multi-line control statements

mitchell-stellar updated this revision to Diff 222907. mitchell-stellar added a comment. Renamed "OnlyMultiLine" option to "MultiLine", per reviewer request. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68296/new/ https://reviews.llvm.org/D68296 Files: clang/

[PATCH] D68296: [clang-format] Add ability to wrap braces after multi-line control statements

mitchell-stellar marked 4 inline comments as done. mitchell-stellar added inline comments. Comment at: clang/lib/Format/Format.cpp:643 +true}; switch (Style.BreakBeforeBraces) { case FormatStyle::BS_Linux: MyDeveloperDay wrote: >

[PATCH] D68296: [clang-format] Add ability to wrap braces after multi-line control statements

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM and Thank you. Comment at: clang/lib/Format/Format.cpp:643 +true}; switch (Style.BreakBeforeBraces) { case FormatStyle:

[PATCH] D63960: [C++20] Add consteval-specific semantic for functions

Tyker updated this revision to Diff 223021. Tyker marked 16 inline comments as done. Tyker added a comment. i addressed almost all comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63960/new/ https://reviews.llvm.org/D63960 Files: clang/include/clang/AST/DeclCXX.h clang/inclu

[PATCH] D63960: [C++20] Add consteval-specific semantic for functions

Tyker added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:11188-11189 + ConstexprSpecKind ConstexprKind = DetermineSpecialMemberConstexprKind( + Constexpr, ClassDecl->hasDefaultedConstevalDefaultCtor()); + rsmith wrote: > I don't think this

[PATCH] D68296: [clang-format] Add ability to wrap braces after multi-line control statements

mitchell-stellar updated this revision to Diff 223058. mitchell-stellar added a comment. Rebased against master, and also added test case for 'do' statements. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68296/new/ https://reviews.llvm.org/D68296 Files: clang

[PATCH] D68242: [clang-format] [PR42417] clang-format inserts a space after '->' for operator->() overloading

mitchell-stellar added a comment. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68242/new/ https://reviews.llvm.org/D68242 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/m

[PATCH] D68296: [clang-format] Add ability to wrap braces after multi-line control statements

This revision was automatically updated to reflect the committed changes. Closed by commit rL373647: [clang-format] Add ability to wrap braces after multi-line control statements (authored by paulhoad, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[PATCH] D67660: [clang-format] [PR43338] C# clang format has space issues betweern C# only keywords

mitchell-stellar accepted this revision. mitchell-stellar added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67660/new/ https://reviews.llvm.org/D67660 __

[PATCH] D67629: [clang-format] [PR43333] Fix C# breaking before function name when using Attributes

mitchell-stellar accepted this revision. mitchell-stellar added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67629/new/ https://reviews.llvm.org/D67629 __

[PATCH] D68415: [clang-format] C++11 braced lists should respect the SpacesInParentheses setting

mitchell-stellar created this revision. mitchell-stellar added reviewers: MyDeveloperDay, reuk, owenpan. mitchell-stellar added a project: clang-format. Herald added a project: clang. Herald added a subscriber: cfe-commits. According to the clang-format documentation, "Fundamentally, C++11 braced

[PATCH] D68332: [clang-format] [PR43531] clang-format damages "alternative representations" for operators

mitchell-stellar requested changes to this revision. mitchell-stellar added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Format/TokenAnnotator.cpp:2892 + if (Left.is(TT_UnaryOperator)) { +// Don't combine the unary operators !~ into "

[PATCH] D68415: [clang-format] C++11 braced lists should respect the SpacesInParentheses setting

MyDeveloperDay added a comment. Should we have `SpacesInBraces`? as a first class formatting option, given that we have? SpaceBetweenBraces.SpacesInAngles = true; SpaceBetweenBraces.SpacesInParentheses = true; SpaceBetweenBraces.SpacesInSquareBrackets = true; Repository: rC Clang CH

[PATCH] D68415: [clang-format] C++11 braced lists should respect the SpacesInParentheses setting

mitchell-stellar added a comment. I don't think that's a good idea, considering the fact that braces can mean different things in different contexts, and it would cause trouble for existing clang-format settings. If a hypothetical `SpacesInBraces` were `false` by default, then you could have c

[PATCH] D68415: [clang-format] C++11 braced lists should respect the SpacesInParentheses setting

mitchell-stellar updated this revision to Diff 223077. mitchell-stellar added a comment. Added additional unit tests to verify that the `SpaceInEmptyParentheses` setting is also correctly adhered to. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68415/new/ https

[PATCH] D68346: [clang-format] Add new option to add spaces around conditions

mitchell-stellar requested changes to this revision. mitchell-stellar added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:2290 +**SpacesAroundConditions** (``bool``) + If ``true``, spaces will be inserted around if/for/while (and similar) conditions. ---

[PATCH] D68415: [clang-format] C++11 braced lists should respect the SpacesInParentheses setting

MyDeveloperDay added a comment. what if you have this vector{1, 2, 3}; new int[3]{1, 2, 3}; foo(int f); but want this: vector{ 1, 2, 3 }; new int[3]{ 1, 2, 3 }; foo(int f); wouldn't turning on `SpacesInParentheses: true` now mean you get vector{ 1, 2, 3 }; new int[3]{ 1, 2, 3

[PATCH] D68415: [clang-format] C++11 braced lists should respect the SpacesInParentheses setting

mitchell-stellar added a comment. If you want spaces in your C++11 initializers and nothing else, then you don't want the `Cpp11BracedListStyle` setting enabled. Turning it off gives you spaces inside without affecting anything else. Repository: rC Clang CHANGES SINCE LAST ACTION https://

[PATCH] D68415: [clang-format] C++11 braced lists should respect the SpacesInParentheses setting

MyDeveloperDay added a comment. understood, ok LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68415/new/ https://reviews.llvm.org/D68415 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D68415: [clang-format] C++11 braced lists should respect the SpacesInParentheses setting

mitchell-stellar added a comment. Thanks. Please commit on my behalf when you have a chance. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68415/new/ https://reviews.llvm.org/D68415 ___ cfe-commits mailing list cfe-c

[PATCH] D67629: [clang-format] [PR43333] Fix C# breaking before function name when using Attributes

This revision was automatically updated to reflect the committed changes. Closed by commit rL373707: [clang-format] [PR4] Fix C# breaking before function name when using… (authored by paulhoad, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prio

[PATCH] D67660: [clang-format] [PR43338] C# clang format has space issues betweern C# only keywords

This revision was automatically updated to reflect the committed changes. Closed by commit rL373709: [clang-format] [PR43338] C# clang format has space issues betweern C# only… (authored by paulhoad, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed pr

[PATCH] D68335: [CodeComplete] Ensure object is the same in compareOverloads()

This revision was automatically updated to reflect the committed changes. Closed by commit rL373710: [CodeComplete] Ensure object is the same in compareOverloads() (authored by ibiryukov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commi

[PATCH] D45532: [StaticAnalyzer] Checker to find uninitialized fields after a constructor call

whisperity added a comment. @NoQ Do you reckon these tests files are too long? Perhaps the one about this inheritance, that inheritance, diamond inheritance, etc. could be split into multiple files. Comment at: include/clang/StaticAnalyzer/Checkers/Checkers.td:317 +def Ctor

[PATCH] D45532: [StaticAnalyzer] Checker to find uninitialized fields after a constructor call

whisperity requested changes to this revision. whisperity added subscribers: gsd, dkrupp, o.gyorgy. whisperity added a comment. This revision now requires changes to proceed. Sorry, one comment has gone missing meanwhile, I'm still getting used to this interface and hit //Submit// early. =

[PATCH] D44602: [clang-tidy] readability-function-size: add VariableThreshold param.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE329902: [clang-tidy] readability-function-size: add VariableThreshold param. (authored by lebedevri, committed by ). Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44602 Files: clang

[PATCH] D45363: [OpenCL] Added -std/-cl-std=CL2.2/CLC++

This revision was automatically updated to reflect the committed changes. Closed by commit rL329911: [OpenCL] Added -std/-cl-std=c++ (authored by stulova, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D45363?vs=141975&id=142171#toc R

[PATCH] D45363: [OpenCL] Added -std/-cl-std=CL2.2/CLC++

This revision was automatically updated to reflect the committed changes. Closed by commit rC329911: [OpenCL] Added -std/-cl-std=c++ (authored by stulova, committed by ). Repository: rC Clang https://reviews.llvm.org/D45363 Files: include/clang/Basic/DiagnosticSemaKinds.td include/clang/B

[PATCH] D45482: [clangd] Match AST and Index label for template Symbols

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE330004: [clangd] Match AST and Index label for template Symbols (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D45482?vs=142372&id=142373#toc Repository:

[PATCH] D45482: [clangd] Match AST and Index label for template Symbols

This revision was automatically updated to reflect the committed changes. Closed by commit rL330004: [clangd] Match AST and Index label for template Symbols (authored by ibiryukov, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D45482 Fil

[PATCH] D45564: [analyzer] Fix null deref in AnyFunctionCall::getRuntimeDefinition

This revision was automatically updated to reflect the committed changes. Closed by commit rC330009: [analyzer] Fix null deref in AnyFunctionCall::getRuntimeDefinition (authored by xazax, committed by ). Repository: rC Clang https://reviews.llvm.org/D45564 Files: lib/StaticAnalyzer/Core/Cal

[PATCH] D45491: [analyzer] Do not invalidate the `this` pointer.

This revision was automatically updated to reflect the committed changes. Closed by commit rC330095: [analyzer] Do not invalidate the `this` pointer. (authored by henrywong, committed by ). Repository: rC Clang https://reviews.llvm.org/D45491 Files: lib/StaticAnalyzer/Core/LoopWidening.cpp

[PATCH] D45407: [StaticAnalyzer] Added notes to the plist output

whisperity added a comment. @NoQ The problem with emitting notes as events is that we lose the information that the node was a `node`. How does Xcode behave with these notes? Does it ignore them, or can read them from the command-line output of the analyser? Repository: rC Clang https://rev

[PATCH] D45713: [libclang] Fix the type of 'int (Foo);'

strager created this revision. strager added a reviewer: cfe-commits. libclang exposes the type of 'int (Foo);' (a global variable of type int called Foo) as CXType_Unexposed. This is because Clang represents Foo's type as ParenType{BuiltinType{Int}}, and libclang does not handle ParenType. Make

[PATCH] D45716: [XRay] Add clang builtin for xray typed events.

kpw created this revision. kpw added reviewers: dberris, pelikan, rnk, eizan. A clang builtin for xray typed events. Differs from __xray_customevent(...) by the presence of a type tag that is vended by compiler-rt in typical usage. This allows xray handlers to expand logged events with their type

[PATCH] D45716: [XRay] Add clang builtin for xray typed events.

kpw updated this revision to Diff 142735. kpw added a comment. Adding a comment to the test to encourage getting the event types from compiler-rt Repository: rC Clang https://reviews.llvm.org/D45716 Files: include/clang/Basic/Builtins.def lib/CodeGen/CGBuiltin.cpp test/CodeGen/xray-typ

[PATCH] D45716: [XRay] Add clang builtin for xray typed events.

kpw added inline comments. Comment at: test/CodeGen/xray-typedevent.cpp:10 + __xray_typedevent(EventType, kPhase, 10); + // CHECK: call void @llvm.xray.typedevent(i16 {{.*}}, i8*{{.*}}, i32 10) +} FYI: It would be involved to match on more than * for the event

[PATCH] D45716: [XRay] Add clang builtin for xray typed events.

kpw updated this revision to Diff 142737. kpw added a comment. Added flags and bundle options. Repository: rC Clang https://reviews.llvm.org/D45716 Files: include/clang/Basic/Builtins.def include/clang/Basic/LangOptions.def include/clang/Basic/XRayInstr.h include/clang/Driver/Options

[PATCH] D45716: [XRay] Add clang builtin for xray typed events.

kpw added a comment. My editor got a bit carried away with automatically clang-formatting lib/CodeGen/CodeGenFunction.cpp. I'll fix that so that I'm not messing up the revision history. Repository: rC Clang https://reviews.llvm.org/D45716 ___ c

[PATCH] D45532: [StaticAnalyzer] Checker to find uninitialized fields after a constructor call

whisperity added a comment. In https://reviews.llvm.org/D45532#1068700, @Szelethus wrote: > In https://reviews.llvm.org/D45532#1068647, @dkrupp wrote: > > > This bug report also mentions assignment operator. But for that a warning > > may be not so useful. In that case the members of the assigne

[PATCH] D45532: [StaticAnalyzer] Checker to find uninitialized fields after a constructor call

whisperity requested changes to this revision. whisperity added a comment. This revision now requires changes to proceed. There is something that came up in my mind: Consider a construct like this: class A { A() { memset(X, 0, 10 * sizeof(int)); } int X[10]; }; I

[PATCH] D45716: [XRay] Add clang builtin for xray typed events.

kpw updated this revision to Diff 142790. kpw added a comment. Undoing formatting change. Repository: rC Clang https://reviews.llvm.org/D45716 Files: include/clang/Basic/Builtins.def include/clang/Basic/LangOptions.def include/clang/Basic/XRayInstr.h include/clang/Driver/Options.td

[PATCH] D45716: [XRay] Add clang builtin for xray typed events.

This revision was automatically updated to reflect the committed changes. Closed by commit rC330220: [XRay] Add clang builtin for xray typed events. (authored by kpw, committed by ). Changed prior to commit: https://reviews.llvm.org/D45716?vs=142790&id=142836#toc Repository: rC Clang https:

[PATCH] D45716: [XRay] Add clang builtin for xray typed events.

This revision was automatically updated to reflect the committed changes. Closed by commit rL330220: [XRay] Add clang builtin for xray typed events. (authored by kpw, committed by ). Repository: rC Clang https://reviews.llvm.org/D45716 Files: cfe/trunk/include/clang/Basic/Builtins.def cfe

[PATCH] D45779: [ARM] Remove redundant #if in test

strager created this revision. strager added a reviewer: cfe-commits. Herald added subscribers: chrib, kristof.beyls, javed.absar. Both sides of this #if #include the same file. Drop the #if, leaving only the #include. This commit should not change behaviour. Repository: rC Clang https://re

<    23   24   25   26   27   28   29   30   31   32   >