[PATCH] D62557: [analyzer] Modernize CStringChecker to use CallDescriptions.

2019-07-01 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL364868: [analyzer] CStringChecker: Modernize to use CallDescriptions. (authored by dergachev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit

[PATCH] D63956: [analyzer] NonnullGlobalConstants: Don't be confused with a _Nonnull attribute.

2019-07-01 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL364869: [analyzer] NonnullGlobalConstants: Don't be confused by a _Nonnull attribute. (authored by dergachev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[PATCH] D63968: [analyzer] Fix target region invalidation when returning into a ctor initializer.

2019-07-01 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL364870: [analyzer] Fix invalidation when returning into a ctor initializer. (authored by dergachev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D64051: [analyzer] exploded-graph-rewriter: Improve program point dumps.

2019-07-01 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL364881: [analyzer] exploded-graph-rewriter: Improve program point dumps. (authored by dergachev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to com

[PATCH] D64047: [analyzer] exploded-graph-rewriter: Add support for objects under construction.

2019-07-01 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL364880: [analyzer] exploded-graph-rewriter: Add support for objects under construction. (authored by dergachev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Chang

[PATCH] D64056: [analyzer] exploded-graph-rewriter: Implement a dark color scheme.

2019-07-01 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL364882: [analyzer] exploded-graph-rewriter: Implement a dark color scheme. (authored by dergachev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to c

[PATCH] D64044: [clang][Driver][ARM] NFC: Remove unused function parameter

2019-07-02 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL364895: [clang][Driver][ARM] NFC: Remove unused function parameter (authored by alelab01, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

2019-07-02 Thread LingVu via Phabricator via cfe-commits
LingDev added a comment. We need this feature as well, we are also waiting for it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D28462/new/ https://reviews.llvm.org/D28462 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D62825: [C++2a] Add __builtin_bit_cast, used to implement std::bit_cast

2019-07-02 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL364954: [C++2a] Add __builtin_bit_cast, used to implement std::bit_cast (authored by epilk, committed by ). Changed prior to commit: https://reviews.llvm.org/D62825?vs=206304&id=207596#toc Repository:

[PATCH] D64100: [analyzer] exploded-graph-rewriter: Implement checker messages.

2019-07-02 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL364989: [analyzer] exploded-graph-rewriter: Implement checker messages. (authored by dergachev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to comm

[PATCH] D64110: [analyzer] exploded-graph-rewriter: Implement bug nodes and sink nodes.

2019-07-02 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL364992: [analyzer] exploded-graph-rewriter: Implement bug nodes and sink nodes. (authored by dergachev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[PATCH] D64104: [analyzer] exploded-graph-rewriter: Collapse large statement pretty-prints.

2019-07-02 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL364990: [analyzer] exploded-graph-rewriter: Collapse very long statement pretty-prints. (authored by dergachev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Chang

[PATCH] D64129: [clang-scan-view] Force utf-8 when handling report (python2 only)

2019-07-03 Thread serge via Phabricator via cfe-commits
serge-sans-paille created this revision. serge-sans-paille added a reviewer: michaelplatings. Herald added a project: clang. Herald added a subscriber: cfe-commits. If the report file contains unicode characters, under Python2, opening the file does not decode it to utf-8 by default. Repository

[PATCH] D64153: [analyzer] exploded-graph-rewriter: Add a grayscale mode.

2019-07-03 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL365085: [analyzer] exploded-graph-rewriter: Implement a black-and-white color scheme. (authored by dergachev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[PATCH] D63640: [clang] Improve Serialization/Imporing of APValues

2019-07-04 Thread Tyker via Phabricator via cfe-commits
Tyker updated this revision to Diff 207977. Tyker marked 2 inline comments as done. Tyker set the repository for this revision to rC Clang. Tyker added a comment. fixed comment typo. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63640/new/ https://reviews.llvm.or

[PATCH] D63640: [clang] Improve Serialization/Imporing of APValues

2019-07-04 Thread Tyker via Phabricator via cfe-commits
Tyker added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:8503 +llvm::Expected ASTImporter::Import(const APValue &FromValue) { + APValue Result; martong wrote: > Looks okay, but could we have unit tests for this in ASTImporterTest.cpp? I tested im

[PATCH] D63640: [clang] Improve Serialization/Imporing of APValues

2019-07-04 Thread Tyker via Phabricator via cfe-commits
Tyker updated this revision to Diff 208015. Tyker added a comment. fixed the comment for good, sorry for that. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63640/new/ https://reviews.llvm.org/D63640 Files: clang/include/clang/AST/APValue.h clang/include/clang/AST/ASTContext.h cl

[PATCH] D63640: [clang] Improve Serialization/Imporing of APValues

2019-07-04 Thread Tyker via Phabricator via cfe-commits
Tyker marked 2 inline comments as done. Tyker added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:8503 +llvm::Expected ASTImporter::Import(const APValue &FromValue) { + APValue Result; martong wrote: > Tyker wrote: > > martong wrote: > > > Looks o

[PATCH] D64156: Make joined instances of JoinedOrSeparate flags point to the unaliased args, like all other arg types do

2019-07-05 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL365186: Make joined instances of JoinedOrSeparate flags point to the unaliased args… (authored by nico, committed by ). Changed prior to commit: https://reviews.llvm.org/D64156?vs=207873&id=208146#toc

[PATCH] D63960: [C++20] Add consteval-specifique semantic

2019-07-07 Thread Tyker via Phabricator via cfe-commits
Tyker added a comment. ping @rsmith Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63960/new/ https://reviews.llvm.org/D63960 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mail

[PATCH] D61681: [clangd] A code tweak to expand a macro

2019-07-08 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL365331: [clangd] A code tweak to expand a macro (authored by ibiryukov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.ll

[PATCH] D63856: [ObjC] Add a -Wtautological-compare warning for BOOL

2019-07-08 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL365408: [ObjC] Add a -Wtautological-compare warning for BOOL (authored by epilk, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://r

[PATCH] D64263: [analyzer] exploded-graph-rewriter: Implement a single-path mode.

2019-07-08 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL365409: [analyzer] exploded-graph-rewriter: Implement a single-path mode. (authored by dergachev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to co

[PATCH] D64264: [analyzer] exploded-graph-rewriter: Implement a topology-only mode.

2019-07-08 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL365410: [analyzer] exploded-graph-rewriter: Implement a topology-only mode. (authored by dergachev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D64349: clang-cl: Port cl.exe's C4659 to clang-cl

2019-07-08 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL365411: clang-cl: Port cl.exe's C4659 to clang-cl (authored by nico, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.

[PATCH] D64301: Use `ln -n` to prevent forming a symlink cycle, instead of rm'ing the source

2019-07-08 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL365414: Use `ln -n` to prevent forming a symlink cycle, instead of rm'ing the source (authored by nico, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[PATCH] D64253: Let unaliased Args track which Alias they were created from, and use that in Arg::getAsString() for diagnostics

2019-07-08 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL365413: Let unaliased Args track which Alias they were created from, and use that in… (authored by nico, committed by ). Changed prior to commit: https://reviews.llvm.org/D64253?vs=208192&id=208553#toc

[PATCH] D61809: [BPF] Preserve debuginfo array/union/struct type/access index

2019-07-08 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL365438: [BPF] Preserve debuginfo array/union/struct type/access index (authored by yhs, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: ht

[PATCH] D63912: [ObjC] Add a warning for implicit conversions of a constant non-boolean value to BOOL

2019-07-09 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL365518: [ObjC] Add a warning for implicit conversions of a constant non-boolean value… (authored by epilk, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed pr

[PATCH] D62105: [CommandLine] Remove OptionCategory and SubCommand caches from the Option class.

2019-07-10 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL365675: Recommit "[CommandLine] Remove OptionCategory and SubCommand caches from the… (authored by dhinton, committed by ). Herald added a subscriber: ilya-biryukov. Changed prior to commit: https://rev

[PATCH] D64527: driver: Don't warn about assembler flags being unused when not assembling

2019-07-10 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL365703: driver: Don't warn about assembler flags being unused when not assembling (authored by nico, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D64506: clang-cl: Remove -O0 option

2019-07-10 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL365724: clang-cl: Remove -O0 option (authored by nico, committed by ). Herald added a subscriber: delcypher. Changed prior to commit: https://reviews.llvm.org/D64506?vs=209092&id=209111#toc Repository:

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

2019-05-10 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added a comment. When I spoke with one of the code owners, they seemed to have a problem accepting this review based on there not being a general description/understanding of how this algorithm works. Having said that, all of the "AlignToken" based functions (alignConsecutiveXXX

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

2019-05-10 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. @klimek responded via the mailing list http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20190506/270976.html CHANGES SINCE LAST ACTION https://reviews.llvm.org/D2846

[PATCH] D61790: [C++20] add consteval specifier

2019-05-10 Thread Tyker via Phabricator via cfe-commits
Tyker created this revision. Tyker added a reviewer: rsmith. Herald added a reviewer: martong. Herald added a reviewer: shafik. Herald added a project: clang. Herald added a subscriber: cfe-commits. this revision adds the consteval specifier as specified by http://www.open-std.org/jtc1/sc22/wg21/

[PATCH] D61165: Fix a crash where a [[no_destroy]] destructor was not emitted in an array

2019-05-10 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL360446: [Sema] Mark array element destructors referenced during initialization (authored by epilk, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to c

[PATCH] D60629: [clang-tidy] Change the namespace for llvm checkers from 'llvm' to 'llvm_check'

2019-05-10 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rCTE360450: [clang-tidy] Change the namespace for llvm checkers from 'llvm' to 'llvm_check' (authored by dhinton, committed by ). Changed prior to commit: https://reviews.llvm.org/D60629?vs=196531&id=199

[PATCH] D61765: [OpenMP][Clang][BugFix] Split declares and math functions inclusion.

2019-05-13 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC360626: [OpenMP][Clang][BugFix] Split declares and math functions inclusion. (authored by gbercea, committed by ). Changed prior to commit: https://reviews.llvm.org/D61765?vs=199304&id=199340#toc Repos

[PATCH] D61788: Make getObjCEncodingForTypeImpl() take a bitmask instead of 8 bools

2019-05-14 Thread Phabricator via Phabricator via cfe-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL360668: Make getObjCEncodingForTypeImpl() take a bitmask instead of 8 bools (authored by nico, committed by ). Herald adde

[PATCH] D61742: [Driver][Windows] Add dependent lib argument for profile instr generate

2019-05-14 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC360674: [Driver][Windows] Add dependent lib argument for profile instr generate (authored by russell_gallop, committed by ). Changed prior to commit: https://reviews.llvm.org/D61742?vs=199016&id=199436#

[PATCH] D61281: [clang-format] Fixed self assignment

2019-05-14 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay requested changes to this revision. MyDeveloperDay added a comment. This revision now requires changes to proceed. please simply remove line 249 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61281/new/ https://reviews.llvm.org/D61281 ___

[PATCH] D61925: [analyzer] MIGChecker: Add support for os_ref_retain().

2019-05-14 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC360737: [analyzer] MIGChecker: Add support for os_ref_retain(). (authored by dergachev, committed by ). Changed prior to commit: https://reviews.llvm.org/D61925?vs=199537&id=199543#toc Repository: rC

[PATCH] D61281: [clang-format] Fixed self assignment

2019-05-15 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61281/new/ https://reviews.llvm.org/D61281 ___ cfe-commits mailing li

[PATCH] D59413: Fix isInSystemMacro in presence of macro and pasted token

2019-05-15 Thread serge via Phabricator via cfe-commits
serge-sans-paille updated this revision to Diff 199585. serge-sans-paille added a comment. Updated with clang-formated diff CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59413/new/ https://reviews.llvm.org/D59413 Files: clang/include/clang/Basic/SourceManager.h clang/test/Misc/no-w

[PATCH] D61827: [clang-tidy] modernize-loop-convert: impl const cast iter

2019-05-15 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rCTE360785: [clang-tidy] modernize-loop-convert: impl const cast iter (authored by dhinton, committed by ). Changed prior to commit: https://reviews.llvm.org/D61827?vs=199496&id=199631#toc Repository:

[PATCH] D61958: [analyzer] RetainCount: Fix a crash when os_returns_retained_on_zero (_nonzero) is applied to functions that return weird stuff.

2019-05-15 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC360790: [analyzer] RetainCount: Fix os_returns_retained_on_zero with weird return types. (authored by dergachev, committed by ). Changed prior to commit: https://reviews.llvm.org/D61958?vs=199647&id=19

[PATCH] D61957: [CodeGenObjC] invoke objc_autorelease, objc_retain when necessary

2019-05-15 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC360802: [CodeGenObjC] invoke objc_autorelease, objc_retain when necessary (authored by epilk, committed by ). Changed prior to commit: https://reviews.llvm.org/D61957?vs=199640&id=199666#toc Repository

[PATCH] D61949: [OpenMP][bugfix] Fix issues with C++ 17 compilation when handling math functions

2019-05-15 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC360804: [OpenMP][bugfix] Fix issues with C++ 17 compilation when handling math functions (authored by gbercea, committed by ). Changed prior to commit: https://reviews.llvm.org/D61949?vs=199662&id=19966

[PATCH] D61959: [OpenMP][Bugfix] Move double and float versions of abs under c++ macro

2019-05-15 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC360809: [OpenMP][Bugfix] Move double and float versions of abs under c++ macro (authored by gbercea, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61959/new

[PATCH] D59413: Fix isInSystemMacro in presence of macro and pasted token

2019-05-16 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC360885: Fix isInSystemMacro in presence of macro and pasted token (authored by serge_sans_paille, committed by ). Changed prior to commit: https://reviews.llvm.org/D59413?vs=199585&id=199801#toc Reposi

[PATCH] D62009: [clang] perform semantic checking in constant context

2019-05-16 Thread Tyker via Phabricator via cfe-commits
Tyker updated this revision to Diff 199830. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62009/new/ https://reviews.llvm.org/D62009 Files: clang/include/clang/AST/Expr.h clang/include/clang/AST/Stmt.h clang/lib/AST/ExprConstant.cpp clang/lib/Sema/SemaDecl.cpp clang/lib/Sema/Se

[PATCH] D62010: [CodeComplete] Complete enumerators when preferred type is an enum

2019-05-16 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL360912: [CodeComplete] Complete enumerators when preferred type is an enum (authored by ibiryukov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to c

[PATCH] D62009: [clang] perform semantic checking in constant context

2019-05-16 Thread Tyker via Phabricator via cfe-commits
Tyker added a comment. i added this bit because when we eventually store the result of evaluation in ConstantExpr we will probably want to trail-allocate the APValue's possible representations separately to limit memory consumption. but if we do this the ConstantExpr node will need to be create

[PATCH] D61909: Add Clang shared library with C++ exports

2019-05-16 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC360946: Add Clang shared library with C++ exports (authored by cbieneman, committed by ). Changed prior to commit: https://reviews.llvm.org/D61909?vs=199508&id=199912#toc Repository: rC Clang CHANGE

[PATCH] D60274: [ELF] Implement Dependent Libraries Feature

2019-05-16 Thread ben via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rLLD360984: [ELF] Implement Dependent Libraries Feature (authored by bd1976llvm, committed by ). Changed prior to commit: https://reviews.llvm.org/D60274?vs=195495&id=199972#toc Repository: rLLD LLVM L

[PATCH] D60763: Prototype OpenCL BIFs using Tablegen

2019-05-17 Thread Pierre via Phabricator via cfe-commits
Pierre updated this revision to Diff 18. Pierre marked 14 inline comments as done. Pierre added a comment. Corrections from the comments on the previous version. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60763/new/ https://reviews.llvm.org/D60763 Files: clang/include/clang/Ba

[PATCH] D60763: Prototype OpenCL BIFs using Tablegen

2019-05-17 Thread Pierre via Phabricator via cfe-commits
Pierre added inline comments. Comment at: clang/include/clang/Basic/OpenCLBuiltins.td:17 +// +// Builtin functions are instances of the Builtin class. +// Prototypes are defined as a list of Type classes (or its subclasses). Anastasia wrote: > Can you explain thi

[PATCH] D59885: [Lex] Allow to consume tokens while preprocessing

2019-05-17 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC361007: [Lex] Allow to consume tokens while preprocessing (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D59885?vs=11&id=22#toc Repository: rC Clang

[PATCH] D62009: [clang] perform semantic checking in constant context

2019-05-17 Thread Tyker via Phabricator via cfe-commits
Tyker added a comment. I checked how we can propagate the information about constant context through semantic checking. there are issues with using ConstantExpr to mark expressions as constant for semantic checking: - #1 multpile Expr::Ignore* operation remove ConstantExpr from the expression.

[PATCH] D62046: [OpenMP][bugfix] Add missing math functions variants for log and abs.

2019-05-17 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC361066: [OpenMP][bugfix] Add missing math functions variants for log and abs. (authored by gbercea, committed by ). Changed prior to commit: https://reviews.llvm.org/D62046?vs=200048&id=200076#toc Repo

[PATCH] D62009: [clang] perform semantic checking in constant context

2019-05-20 Thread Tyker via Phabricator via cfe-commits
Tyker updated this revision to Diff 200231. Tyker edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62009/new/ https://reviews.llvm.org/D62009 Files: clang/include/clang/AST/Expr.h clang/include/clang/Sema/Sema.h clang/lib/AST/ExprConstant.cpp cla

[PATCH] D59887: [Syntax] Introduce TokenBuffer, start clangToolingSyntax library

2019-05-20 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC361148: [Syntax] Introduce TokenBuffer, start clangToolingSyntax library (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D59887?vs=200213&id=200260#toc Reposit

[PATCH] D62143: [clangd] Make it possible to use VFS from parsing for getting tidy options

2019-05-20 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL361178: [clangd] Make it possible to use VFS from parsing for getting tidy options (authored by ibiryukov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed pr

[PATCH] D62009: [clang] perform semantic checking in constant context

2019-05-20 Thread Tyker via Phabricator via cfe-commits
Tyker added a comment. I changed the approach in the last revision. the information is now propagated using the expression evaluation context and then via booleans. I should have added a comment to make it clear. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62009/new/ https://reviews

[PATCH] D50993: [clangd] Increase stack size of the new threads on macOS

2019-05-21 Thread Dmitry via Phabricator via cfe-commits
Dmitry.Kozhevnikov updated this revision to Diff 200432. Dmitry.Kozhevnikov changed the repository for this revision from rCTE Clang Tools Extra to rG LLVM Github Monorepo. Dmitry.Kozhevnikov added a comment. moved to the monorepo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D60763: Prototype OpenCL BIFs using Tablegen

2019-05-21 Thread Pierre via Phabricator via cfe-commits
Pierre marked an inline comment as done. Pierre added inline comments. Comment at: clang/include/clang/Basic/OpenCLBuiltins.td:298-302 +def write_imagef : Builtin<"write_imagef", +[void_t, + image2d_WO_t, +

[PATCH] D60763: Prototype OpenCL BIFs using Tablegen

2019-05-21 Thread Pierre via Phabricator via cfe-commits
Pierre added a comment. The wrong patch was uploaded. Sorry for this. Comment at: clang/utils/TableGen/ClangOpenCLBuiltinEmitter.cpp:107 + //<, 35>. + // TODO: Check the other types of vector available for performance purpose + std::vector, unsigned>> SignatureSet; -

[PATCH] D60763: Prototype OpenCL BIFs using Tablegen

2019-05-21 Thread Pierre via Phabricator via cfe-commits
Pierre updated this revision to Diff 200499. Pierre marked 9 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60763/new/ https://reviews.llvm.org/D60763 Files: clang/include/clang/Basic/CMakeLists.txt clang/include/clang/Basic/LangOptions.def clang/include/cla

[PATCH] D61386: [clang-tidy] Add support writing a check as a Transformer rewrite rule.

2019-05-21 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added a comment. Just a passing comment, Is this: a) a different type of check that would be used for a different type of check than previous clang-tidy checks b) or is this a replacement on the previous style? Is there any documentation about the benefits of this method vs the o

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

2019-05-21 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL361298: [OpenMP] Add support for registering requires directives with the runtime (authored by gbercea, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository:

[PATCH] D62138: [Docs] Increase Doxygen cache size

2019-05-21 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC361343: [Docs] Increase Doxygen cache size (authored by dhinton, committed by ). Changed prior to commit: https://reviews.llvm.org/D62138?vs=200261&id=200617#toc Repository: rC Clang CHANGES SINCE L

[PATCH] D61747: [clang-tidy] remove default header-filter for run-clang-tidy

2019-05-21 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rCTE361344: [clang-tidy] remove default header-filter for run-clang-tidy (authored by dhinton, committed by ). Changed prior to commit: https://reviews.llvm.org/D61747?vs=198877&id=200620#toc Repository:

[PATCH] D62225: [clang][NewPM] Fixing -O0 tests that are broken under new PM

2019-05-21 Thread serge via Phabricator via cfe-commits
serge-sans-paille added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:1104-1105 // which is just that always inlining occurs. - MPM.addPass(AlwaysInlinerPass()); + // We always pass false here since according to the legacy PM logic for + //

[PATCH] D62009: [clang] perform semantic checking in constant context

2019-05-22 Thread Tyker via Phabricator via cfe-commits
Tyker updated this revision to Diff 200662. Tyker added a comment. most comments were fixed. but there is a few point on which the direction isn't clear. > I think all of the new warnings in the test cases here are undesirable (they > duplicate errors produced by the constant evaluator) in the

[PATCH] D62200: [Driver][Windows] Add dependent lib argument for -fprofile-generate and -fcs-profile-generate

2019-05-22 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL361368: [Driver][Windows] Add dependent lib argument for -fprofile-generate and -fcs… (authored by russell_gallop, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Ch

[PATCH] D62137: [Frontend] Return an error on bad inputs to PrecompiledPreabmle

2019-05-22 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC361376: [Frontend] Return an error on bad inputs to PrecompiledPreabmle (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D62137?vs=200253&id=200713#toc Reposito

[PATCH] D62238: [CodeComplete] Complete a lambda when preferred type is a function

2019-05-23 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL361461: [CodeComplete] Complete a lambda when preferred type is a function (authored by ibiryukov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to c

[PATCH] D60763: Prototype OpenCL BIFs using Tablegen

2019-05-23 Thread Pierre via Phabricator via cfe-commits
Pierre updated this revision to Diff 200961. Pierre marked 4 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60763/new/ https://reviews.llvm.org/D60763 Files: clang/include/clang/Basic/CMakeLists.txt clang/include/clang/Basic/LangOptions.def clang/include/cla

[PATCH] D62303: [Index] Fix reported references in presence of template type aliases

2019-05-23 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL361511: [Index] Fix reported references in presence of template type aliases (authored by ibiryukov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D62276: lld-link, clang: Treat non-existent input files as possible spellos for option flags

2019-05-23 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rLLD361518: lld-link, clang: Treat non-existent input files as possible spellos for option… (authored by nico, committed by ). Changed prior to commit: https://reviews.llvm.org/D62276?vs=200845&id=201017#

[PATCH] D61814: [CFG] NFC: Remove implicit conversion from CFGTerminator to Stmt *, make it a variant class instead.

2019-05-23 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL361586: [CFG] NFC: Remove implicit conversion from CFGTerminator to Stmt *. (authored by dergachev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D61815: [CFG] NFC: Modernize test/Analysis/initializers-cfg-output.cpp.

2019-05-23 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC361587: [CFG] NFC: Modernize a test file for constructor initializer CFGs. (authored by dergachev, committed by ). Changed prior to commit: https://reviews.llvm.org/D61815?vs=199118&id=201113#toc Repos

[PATCH] D62298: [CodeComplete] Filter override completions by function name

2019-05-24 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rCTE361623: [CodeComplete] Filter override completions by function name (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D62298?vs=201168&id=201178#toc Repository

[PATCH] D62372: [clangd] Limit the size of synthesized fix message

2019-05-24 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rCTE361625: [clangd] Limit the size of synthesized fix message (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D62372?vs=201179&id=201181#toc Repository: rCTE

[PATCH] D62399: [clang] Add storage for APValue in ConstantExpr

2019-05-24 Thread Tyker via Phabricator via cfe-commits
Tyker created this revision. Tyker added a reviewer: rsmith. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith, hiraditya. Herald added a reviewer: martong. Herald added a reviewer: shafik. Herald added projects: clang, LLVM. When using ConstantExpr we often need the result of the ex

[PATCH] D62406: [WebAssembly] Use "linker" as linker shortname.

2019-05-24 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL361651: [WebAssembly] Use "linker" as linker shortname. (authored by sbc, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.

[PATCH] D62407: [OpenMP] Add test for requires and unified shared memory clause with declare target link

2019-05-24 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC361658: [OpenMP] Add test for requires and unified shared memory clause with declare… (authored by gbercea, committed by ). Changed prior to commit: https://reviews.llvm.org/D62407?vs=201275&id=201298#t

[PATCH] D62343: [cmake] Remove old unused version of FindZ3.cmake from clang [NFC]

2019-05-24 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC361663: [cmake] Remove old unused version of FindZ3.cmake from clang [NFC] (authored by dhinton, committed by ). Changed prior to commit: https://reviews.llvm.org/D62343?vs=201058&id=201308#toc Reposit

[PATCH] D61816: [CFG] [analyzer] pr41300: Add a branch to skip virtual base initializers when they are handled by the superclass.

2019-05-24 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL361681: [CFG] Add branch to skip vbase inits when they're handled by superclass. (authored by dergachev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prio

[PATCH] D61817: [analyzer] Add a prunable note for skipping virtual base initializers in subclasses.

2019-05-24 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC361682: [analyzer] Add a prunable note for skipping vbase inits in subclasses. (authored by dergachev, committed by ). Changed prior to commit: https://reviews.llvm.org/D61817?vs=201359&id=201364#toc R

[PATCH] D62420: Rename clangToolingRefactor to clangToolingRefactoring for consistency with its directory

2019-05-24 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rCTE361684: Rename clangToolingRefactor to clangToolingRefactoring for consistency with its… (authored by nico, committed by ). Herald added a project: clang. Changed prior to commit: https://reviews.llv

[PATCH] D61472: [X86FixupLEAs] Turn optIncDec into a generic two address LEA optimizer. Support LEA64_32r properly.

2019-05-24 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL361691: [X86FixupLEAs] Turn optIncDec into a generic two address LEA optimizer. Support… (authored by ctopper, committed by ). Herald added a subscriber: qcolombet. Changed prior to commit: https://revi

[PATCH] D62391: [CodeComplete] Complete 'return true/false' in boolean functions

2019-05-27 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC361753: [CodeComplete] Complete 'return true/false' in boolean functions (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D62391?vs=201240&id=201489#toc Reposit

[PATCH] D61790: [C++20] add Basic consteval specifier

2019-05-27 Thread Tyker via Phabricator via cfe-commits
Tyker updated this revision to Diff 201535. Tyker marked 13 inline comments as done. Tyker retitled this revision from "[C++20] add consteval specifier" to "[C++20] add Basic consteval specifier". Tyker edited the summary of this revision. Tyker added a comment. Herald added a subscriber: eraman.

[PATCH] D61790: [C++20] add Basic consteval specifier

2019-05-27 Thread Tyker via Phabricator via cfe-commits
Tyker added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:10471 + bool IsConstantContext = S.ExprEvalContexts.back().isConstantEvaluated(); + rsmith wrote: > Are the changes to this file really specific to `consteval` evaluation? They > look mo

[PATCH] D62445: [test] Fix plugin tests

2019-05-27 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC361790: [test] Fix plugin tests (authored by dhinton, committed by ). Changed prior to commit: https://reviews.llvm.org/D62445?vs=201391&id=201614#toc Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D62515: [clangd] Compute expected type for templates

2019-05-28 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rCTE361823: [clangd] Compute expected type for templates (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D62515?vs=201632&id=201656#toc Repository: rCTE Clang

[PATCH] D62523: Add release note entries for recent typo correction changes

2019-05-28 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rLLD361824: Add release note entries for recent typo correction changes (authored by nico, committed by ). Changed prior to commit: https://reviews.llvm.org/D62523?vs=201657&id=201659#toc Repository: r

[PATCH] D62405: [CodeComplete] Consistently break after '{' in multi-line patterns

2019-05-28 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC361829: [CodeComplete] Consistently break after '{' in multi-line patterns (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D62405?vs=201274&id=201666#toc Repos

[PATCH] D62514: [CodeComplete] Set preferred type for qualified-id

2019-05-28 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL361838: [CodeComplete] Set preferred type for qualified-id (authored by ibiryukov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https:/

<    20   21   22   23   24   25   26   27   28   29   >