serge-sans-paille added inline comments.
================
Comment at: clang/lib/CodeGen/BackendUtil.cpp:1104-1105
// which is just that always inlining occurs.
- MPM.addPass(AlwaysInlinerPass());
+ // We always pass false here since according to the legacy PM logic for
+ // enabling lifetime intrinsics, we should not be compiling with O0.
+ MPM.addPass(AlwaysInlinerPass(/*InsertLifetimeIntrinsics=*/false));
----------------
echristo wrote:
> Can you elaborate more here? We do turn on the always inliner at O0 which
> makes this comment a bit confusing.
I guess he means
We always pass false here since according to the legacy PM logic for
enabling lifetime intrinsics, they are not required with O0
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62225/new/
https://reviews.llvm.org/D62225
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
