[PATCH] D62623: Reduce memory consumption of coverage dumps

2019-06-04 Thread serge via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG4cd07dbeec98: Reduce memory consumption of coverage dumps (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62623/new/ https://

[PATCH] D60763: Prototype OpenCL BIFs using Tablegen

2019-06-05 Thread Pierre via Phabricator via cfe-commits
Pierre added a comment. In D60763#1529279 , @Nicola wrote: > A bit late to the review, but I've noticed a couple of issues with some of > the implemented builtins: > > - The fmin/fmax builtins are defined twice for scalar types, does this create > proble

[PATCH] D61552: [clang] Adapt ASTMatcher to explicit(bool) specifier

2019-06-05 Thread Tyker via Phabricator via cfe-commits
Tyker updated this revision to Diff 203115. Tyker marked an inline comment as done. Tyker edited the summary of this revision. Tyker added a comment. changed as requested. hasExplicitSpecifier now gives access to the expression if present. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6

[PATCH] D61318: [Sema] Prevent binding references with mismatching address spaces to temporaries

2019-06-05 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL362604: [Sema] Prevent binding incompatible addr space ref to temporaries (authored by stulova, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to comm

[PATCH] D62591: [OpenCL][PR42031] Prevent deducing addr space in type alias.

2019-06-05 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL362611: [OpenCL][PR42031] Prevent deducing addr space in type alias. (authored by stulova, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D54258: [Clang] Fix pretty printing of CUDA address spaces

2019-06-05 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL362623: [Clang] Fix pretty printing of CUDA address spaces (authored by stulova, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://r

[PATCH] D62279: Use LTO capable linker

2019-06-05 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL362624: Use LTO capable linker (authored by cbieneman, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D62279?vs=

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

2019-06-05 Thread serge via Phabricator via cfe-commits
serge-sans-paille added a comment. @Meinersbur Itested with the following configuration cmake3 ../llvm -DLLVM_EXTERNAL_PROJECTS=bye -DBUILD_SHARED_LIBS=ON -DCMAKE_BUILD_TYPE=Release -DLLVM_TARGETS_TO_BUILD=X86 cmake3 ../llvm -DLLVM_EXTERNAL_PROJECTS=bye -DBUILD_SHARED_LIBS=ON -DCMAKE_BU

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

2019-06-06 Thread serge via Phabricator via cfe-commits
serge-sans-paille added a comment. In D61446#1532848 , @Meinersbur wrote: > Just an idea: We could avoid the explicit calls to 'initializeXYZPass' in > opt/bugpoint/clang by adding Polly.cpp as a source file or object library to > the executables. This w

[PATCH] D62850: [X86] Fix builtins-x86.c test where it wasn't using immediates. NFC

2019-06-07 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL362786: [X86][test] Add test cases using immediates to builtins-x86.c (authored by russell_gallop, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to c

[PATCH] D62998: [ARM] Fix bugs introduced by the fp64/d32 rework.

2019-06-07 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL362791: [ARM] Fix bugs introduced by the fp64/d32 rework. (authored by statham, committed by ). Herald added a subscriber: kristina. Changed prior to commit: https://reviews.llvm.org/D62998?vs=203526&id

[PATCH] D61790: [C++20] add Basic consteval specifier

2019-06-07 Thread Tyker via Phabricator via cfe-commits
Tyker added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:2491 + if (DS.hasConstexprSpecifier() && DSC != DeclSpecContext::DSC_condition) { Diag(DS.getConstexprSpecLoc(), diag::err_typename_invalid_constexpr); DS.ClearConstexprSpec(); rsmi

[PATCH] D61790: [C++20] add Basic consteval specifier

2019-06-07 Thread Tyker via Phabricator via cfe-commits
Tyker updated this revision to Diff 203551. Tyker marked 9 inline comments as done. Tyker added a comment. fixed requested changes except some i commented upon. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61790/new/ https://reviews.llvm.org/D61790 Files: clang/include/clang/AST/Dec

[PATCH] D62009: [clang] perform semantic checking in constant context

2019-06-07 Thread Tyker via Phabricator via cfe-commits
Tyker added a comment. @rsmith ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62009/new/ https://reviews.llvm.org/D62009 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[PATCH] D62999: [clangd] Return empty results on spurious completion triggers

2019-06-07 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL362811: [clangd] Return empty results on spurious completion triggers (authored by ibiryukov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit

[PATCH] D62885: [analyzer] Add werror flag for analyzer warnings

2019-06-07 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL362855: [analyzer] Add werror flag for analyzer warnings (authored by kfischer, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://re

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

2019-06-08 Thread serge via Phabricator via cfe-commits
serge-sans-paille updated this revision to Diff 203697. serge-sans-paille added a comment. Using @beanz idea, provide an option to `add_llvm_executable` to declare it as receiving plugins, which provides lower coupling with actual plugins Tested with four configurations: `BUILD_SHARED_LIBS` ON/O

[PATCH] D62399: [clang] Add storage for APValue in ConstantExpr

2019-06-09 Thread Tyker via Phabricator via cfe-commits
Tyker updated this revision to Diff 203723. Tyker marked 4 inline comments as done. Tyker edited the summary of this revision. Tyker added a comment. fixed requested changes. i will commit it when i have access. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62399/new/ https://reviews.ll

[PATCH] D61790: [C++20] add Basic consteval specifier

2019-06-09 Thread Tyker via Phabricator via cfe-commits
Tyker updated this revision to Diff 203725. Tyker marked 5 inline comments as done. Tyker added a comment. fixed requested changes. also adapted lldb to AST change. I will commit this when i have access. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61790/new/ https://reviews.llvm.org/D

[PATCH] D63062: [clang-format] Added New Style Rule: BitFieldDeclsOnSeparateLines

2019-06-09 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay requested changes to this revision. MyDeveloperDay added a comment. This revision now requires changes to proceed. You need to add a unit test in clang/unittests Comment at: docs/ClangFormatStyleOptions.rst:195 +**BitFieldDeclsOnSeparateLines** (``bool``) + If `

[PATCH] D63072: [clang] Fixing incorrect implicit deduction guides (PR41549)

2019-06-10 Thread Tyker via Phabricator via cfe-commits
Tyker created this revision. Tyker added a reviewer: rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. bug report Before this patch, implicit deduction guides were generated from the first declaration found by lookup. Wit

[PATCH] D63081: [WebAssembly] Cleanup toolchain test files. NFC.

2019-06-10 Thread Phabricator via Phabricator via cfe-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL362959: [WebAssembly] Cleanup toolchain test files. NFC. (authored by sbc, committed by ). Herald added a project: LLVM. H

[PATCH] D63018: [X86] Attempt to make the Intel core CPU inheritance a little more readable and maintainable

2019-06-10 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL362965: [X86] Attempt to make the Intel core CPU inheritance a little more readable and… (authored by ctopper, committed by ). Herald added a project: LLVM. Changed prior to commit: https://reviews.llvm

[PATCH] D63072: [clang] Fixing incorrect implicit deduction guides (PR41549)

2019-06-10 Thread Tyker via Phabricator via cfe-commits
Tyker updated this revision to Diff 203862. Tyker added a comment. fixed the issue. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63072/new/ https://reviews.llvm.org/D63072 Files: clang/lib/Sema/SemaTemplate.cpp clang/test/SemaCXX/cxx1z-class-template-argument-deduction.cpp Index

[PATCH] D63062: [clang-format] Added New Style Rule: BitFieldDeclsOnSeparateLines

2019-06-10 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay requested changes to this revision. MyDeveloperDay added inline comments. This revision now requires changes to proceed. Comment at: docs/ClangFormatStyleOptions.rst:194 +**BitFieldDeclsOnSeparateLines** (``bool``) + If ``true``, Align Bitfield Declarations on s

[PATCH] D63134: [clang] improving diagnotics for invalid constexpr defaulted special membres

2019-06-11 Thread Tyker via Phabricator via cfe-commits
Tyker created this revision. Tyker added a reviewer: rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. this patch improves diagnostic for invalid constexpr defaulted special members by adding notes explaining why the special member cannot be constexpr. example input:

[PATCH] D63134: [clang] improving diagnotics for invalid constexpr defaulted special membres

2019-06-11 Thread Tyker via Phabricator via cfe-commits
Tyker updated this revision to Diff 204041. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63134/new/ https://reviews.llvm.org/D63134 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Sema/SemaDeclCXX.cpp Index: clang/lib/Sema/SemaDeclCXX.cpp =

[PATCH] D63062: [clang-format] Added New Style Rule: BitFieldDeclsOnSeparateLines

2019-06-11 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added a comment. mark sure you mark off the comments as you consider them done. Comment at: lib/Format/FormatToken.h:519 +/// Returns whether the token is a Bit field, and checks whether +/// the Style is C / C++. this looks like it needs a cla

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

2019-06-11 Thread serge via Phabricator via cfe-commits
serge-sans-paille updated this revision to Diff 204073. serge-sans-paille marked 3 inline comments as done. serge-sans-paille added a comment. @beanz : In addition to your suggested changes, I've renamed the cmake utility into `add_llvm_pass_plugin` to match other functions from `AddLLVM.cmake`

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

2019-06-11 Thread serge via Phabricator via cfe-commits
serge-sans-paille added inline comments. Comment at: polly/lib/Support/RegisterPasses.cpp:727 +extern "C" ::llvm::PassPluginLibraryInfo LLVM_ATTRIBUTE_WEAK +llvmGetPassPluginInfo() { + return getPassPluginInfo(); Meinersbur wrote: > [serious] Unfortunately, the

[PATCH] D63140: [clangd] Return TextEdits from ClangdServer::applyTweak

2019-06-12 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL363150: [clangd] Return TextEdits from ClangdServer::applyTweak (authored by ibiryukov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: ht

[PATCH] D63062: [clang-format] Added New Style Rule: OnePerLineBitFieldDecl

2019-06-12 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added a comment. Nit: if you going for "OnePerLine" in the name rather than "Break" can you keep it consistent with `ConstructorInitializerAllOnOneLineOrOnePerLine` and put the type first and then the operation i.e. `BitFieldOnePerLine` (this will help keep all BitField options

[PATCH] D63245: clang-scan-deps: Fix -DBUILD_SHARED_LIBS=ON build

2019-06-13 Thread Phabricator via Phabricator via cfe-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL363238: [clang-scan-deps] Fix -DBUILD_SHARED_LIBS=ON build (authored by sbc, committed by ). Herald added a project: LLVM.

[PATCH] D63030: [WebAssembly] Modernize include path handling

2019-06-13 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL363241: [WebAssembly] Modernize include path handling (authored by sbc, committed by ). Herald added subscribers: llvm-commits, ormris. Herald added a project: LLVM. Changed prior to commit: https://rev

[PATCH] D61697: [lit] Disable test on darwin when building shared libs.

2019-06-13 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL363298: [lit] Disable test on darwin when building shared libs. (authored by dhinton, committed by ). Changed prior to commit: https://reviews.llvm.org/D61697?vs=198720&id=204602#toc Repository: rL L

[PATCH] D63062: [clang-format] Added New Style Rule: BitFieldDeclarationsOnePerLine

2019-06-13 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added inline comments. Comment at: lib/Format/FormatToken.h:524 +T = T->getPreviousNonComment(); +return (T->Tok.is(tok::comma) && Tok.is(tok::identifier) && +T->Next->Tok.is(tok::colon)); do you think you might need (T && T->T

[PATCH] D60523: [clang] Don't segfault on incorrect using directive (PR41400)

2019-06-14 Thread Tyker via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL363360: [clang] Don't segfault on incorrect using directive (PR41400) (authored by Tyker, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D63072: [clang] Fixing incorrect implicit deduction guides (PR41549)

2019-06-14 Thread Tyker via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL363361: [clang] Fixing incorrect implicit deduction guides (PR41549) (authored by Tyker, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: h

[PATCH] D61790: [C++20] add Basic consteval specifier

2019-06-14 Thread Tyker via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL363362: [C++20] add Basic consteval specifier (authored by Tyker, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org

[PATCH] D60883: [OpenMP] Avoid emitting maps for target link variables when unified memory is used

2019-06-14 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL363435: [OpenMP] Avoid emitting maps for target link variables when unified memory is… (authored by gbercea, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Reposito

[PATCH] D63010: [OpenMP] Add task alloc function

2019-06-14 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL363449: [OpenMP] Add task alloc function (authored by gbercea, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION htt

[PATCH] D63009: [OpenMP] Add target task alloc function with device ID

2019-06-14 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL363451: [OpenMP] Add target task alloc function with device ID (authored by gbercea, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES S

[PATCH] D62009: [clang] perform semantic checking in constant context

2019-06-15 Thread Tyker via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL363488: [clang] perform semantic checking in constant context (authored by Tyker, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://

[PATCH] D62399: [clang] Add storage for APValue in ConstantExpr

2019-06-15 Thread Tyker via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL363493: [clang] Add storage for APValue in ConstantExpr (authored by Tyker, committed by ). Herald added a subscriber: kristina. Changed prior to commit: https://reviews.llvm.org/D62399?vs=203723&id=204

[PATCH] D63376: [clang] Small improvments after Adding APValue to ConstantExpr

2019-06-15 Thread Tyker via Phabricator via cfe-commits
Tyker created this revision. Tyker added a reviewer: rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. this patch has multiple small improvements related to the APValue in ConstantExpr. changes: - APValue in ConstantExpr are now cleaned up using ASTContext::addDestr

[PATCH] D63376: [clang] Small improvments after Adding APValue to ConstantExpr

2019-06-15 Thread Tyker via Phabricator via cfe-commits
Tyker updated this revision to Diff 204916. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63376/new/ https://reviews.llvm.org/D63376 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/AST/Expr.h clang/include/clang/AST/Stmt.h clang/include/clang/Sema/Sema.h clang/l

[PATCH] D63376: [clang] Small improvments after Adding APValue to ConstantExpr

2019-06-17 Thread Tyker via Phabricator via cfe-commits
Tyker updated this revision to Diff 204992. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63376/new/ https://reviews.llvm.org/D63376 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/AST/Expr.h clang/include/clang/AST/Stmt.h clang/include/clang/Sema/Sema.h clang/l

[PATCH] D63387: clang: Promote -fdebug-compilation-dir from cc1 flag to driver-level flag

2019-06-17 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL363548: Promote -fdebug-compilation-dir from a cc1 flag to clang and clang-cl driver… (authored by nico, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prio

[PATCH] D63039: Various improvements to Clang MSVC Visualizers

2019-06-17 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL363574: Various improvements to Clang MSVC Visualizer (authored by mps, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.ll

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

2019-06-18 Thread serge via Phabricator via cfe-commits
serge-sans-paille updated this revision to Diff 205298. serge-sans-paille added a comment. Mostly documentation update + helper function renaming. @meinersbur, I've tested the setup with static and dynamic builds on Linux, please let me know your thoughts on this. CHANGES SINCE LAST ACTION h

[PATCH] D62954: [Syntax] Add a helper to find expansion by its first spelled token

2019-06-18 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL363698: [Syntax] Add a helper to find expansion by its first spelled token (authored by ibiryukov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to c

[PATCH] D60764: Add clang cc1 option to generate OpenCL builtin functions

2019-06-18 Thread Pierre via Phabricator via cfe-commits
Pierre closed this revision. Pierre added a comment. The changes are part of https://reviews.llvm.org/D60763 which was merged. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60764/new/ https://reviews.llvm.org/D60764 ___ cfe-commits mailing

[PATCH] D62915: git-clang-format: Remove trailing whitespace in docstring. NFC.

2019-06-18 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL363759: git-clang-format: Remove trailing whitespace in docstring. NFC. (authored by sbc, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D63376: [clang] Small improvments after Adding APValue to ConstantExpr

2019-06-19 Thread Tyker via Phabricator via cfe-commits
Tyker marked an inline comment as done. Tyker added inline comments. Comment at: clang/include/clang/Sema/Sema.h:10298 + bool AllowFold = true, + bool StoreResult = true); ExprResult Verify

[PATCH] D61552: [clang] Adapt ASTMatcher to explicit(bool) specifier

2019-06-19 Thread Tyker via Phabricator via cfe-commits
Tyker updated this revision to Diff 205559. Tyker marked 3 inline comments as done. Tyker added a comment. fixed requested changes. > Are you getting errors from running it, or just incorrect output? the issue happens to me even on master so i suppose the input is correct. here is the error repo

[PATCH] D62956: [clangd] Collect tokens of main files when building the AST

2019-06-19 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL363803: [clangd] Collect tokens of main files when building the AST (authored by ibiryukov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D63454: [OpenMP] Strengthen regression tests for task allocation under nowait depend clauses NFC

2019-06-19 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL363809: [OpenMP] Strengthen regression tests for task allocation under nowait depend… (authored by gbercea, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repositor

[PATCH] D61552: [clang] Adapt ASTMatcher to explicit(bool) specifier

2019-06-19 Thread Tyker via Phabricator via cfe-commits
Tyker updated this revision to Diff 205602. Tyker added a comment. i was confuse because the log seemed like an error and it was happening in python2.7 and python3.7 but the actual error that was preventing generating the documentation only occurs in 3.7. it works in python2.7. CHANGES SINCE

[PATCH] D61552: [clang] Adapt ASTMatcher to explicit(bool) specifier

2019-06-19 Thread Tyker via Phabricator via cfe-commits
Tyker added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:6190 +/// cxxDeductionGuideDecl(isExplicit()) will match #6, but not #5. +/// cxxConstructorDecl(isExplicit()) will match #8, but not #7 or #9. +AST_POLYMORPHIC_MATCHER(isExplicit, AST_POLYMORP

[PATCH] D61552: [clang] Adapt ASTMatcher to explicit(bool) specifier

2019-06-19 Thread Tyker via Phabricator via cfe-commits
Tyker marked an inline comment as done. Tyker added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:6190 +/// cxxDeductionGuideDecl(isExplicit()) will match #6, but not #5. +/// cxxConstructorDecl(isExplicit()) will match #8, but not #7 or #9. +AST_POLY

[PATCH] D63562: [clangd] Format changes produced by rename

2019-06-19 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL363843: [clangd] Format changes produced by rename (authored by ibiryukov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews

[PATCH] D61552: [clang] Adapt ASTMatcher to explicit(bool) specifier

2019-06-19 Thread Tyker via Phabricator via cfe-commits
Tyker updated this revision to Diff 205645. Tyker marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61552/new/ https://reviews.llvm.org/D61552 Files: clang/docs/LibASTMatchersReference.html clang/include/clang/AST/DeclCXX.h clang/include/clang/ASTMatch

[PATCH] D61552: [clang] Adapt ASTMatcher to explicit(bool) specifier

2019-06-19 Thread Tyker via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL363855: [clang] Adapt ASTMatcher to explicit(bool) specifier (authored by Tyker, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://r

[PATCH] D63117: [analyzer] RetainCount: Add support for OSRequiredCast().

2019-06-19 Thread Phabricator via Phabricator via cfe-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL363891: [analyzer] RetainCount: Add support for OSRequiredCast(). (authored by dergachev, committed by ). Herald added a p

[PATCH] D63118: [analyzer] DeadStores: Add a crude suppression files generated by DriverKit IIG.

2019-06-19 Thread Phabricator via Phabricator via cfe-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL363892: [analyzer] DeadStores: Add a crude suppression files generated by DriverKit IIG. (authored by dergachev, committed

[PATCH] D62440: [analyzer] NFC: Change evalCall() to provide a CallEvent.

2019-06-19 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL363893: [analyzer] NFC: Change evalCall() to provide a CallEvent. (authored by dergachev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D62716: [analyzer] Fix JSON dumps for dynamic types, add test.

2019-06-19 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL363894: [analyzer] Fix JSON dumps for dynamic type information. (authored by dergachev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: ht

[PATCH] D63362: [analyzer] Fix JSON dumps for store clusters.

2019-06-19 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL363896: [analyzer] Fix JSON dumps for store clusters. (authored by dergachev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://revi

[PATCH] D62754: [analyzer] Fix JSON dumps for location contexts.

2019-06-19 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL363895: [analyzer] Fix JSON dumps for location contexts. (authored by dergachev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://r

[PATCH] D63519: [analyzer] exploded-graph-rewriter: Fix escaping and unescaping of StringRegions.

2019-06-19 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL363897: [analyzer] exploded-graph-rewriter: Fix escaping StringRegions. (authored by dergachev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to comm

[PATCH] D62761: [analyzer] exploded-graph-rewriter: Implement a --diff mode.

2019-06-19 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL363898: [analyzer] exploded-graph-rewriter: Implement a --diff mode. (authored by dergachev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D62156: [Sema][PR41730] Diagnose addr space mismatch while constructing objects

2019-06-20 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL363944: [Sema] Diagnose addr space mismatch while constructing objects (authored by stulova, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D63613: [clang-tidy] Fail gracefully upon empty database fields

2019-06-20 Thread serge via Phabricator via cfe-commits
serge-sans-paille created this revision. serge-sans-paille added a reviewer: alexfh. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. fix https://bugs.llvm.org/show_bug.cgi?id=42281 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D63613 Files: c

[PATCH] D63108: [OpenMP] Add support for handling declare target to clause when unified memory is required

2019-06-20 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL363959: [OpenMP] Add support for handling declare target to clause when unified memory… (authored by gbercea, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Reposit

[PATCH] D63613: [clang-tidy] Fail gracefully upon empty database fields

2019-06-20 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL363975: [clang-tidy] Fail gracefully upon empty database fields (authored by serge_sans_paille, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to comm

[PATCH] D63613: [clang-tidy] Fail gracefully upon empty database fields

2019-06-20 Thread serge via Phabricator via cfe-commits
serge-sans-paille added a comment. Thanks @jkorous for the fast review o/ Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63613/new/ https://reviews.llvm.org/D63613 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D64540: [CGDebugInfo] Simplfiy EmitFunctionDecl parameters, NFC

2019-07-11 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL365809: [CGDebugInfo] Simplify EmitFunctionDecl parameters, NFC (authored by vedantk, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: http

[PATCH] D64278: Rename libclang_shared to libclang-cpp

2019-07-11 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL365831: Rename libclang_shared to libclang-cpp (authored by sylvestre, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llv

[PATCH] D64526: [NFC] Unforget a colon in a few CHECK: directives.

2019-07-11 Thread Phabricator via Phabricator via cfe-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL365863: NFC: Unforget a colon in a few CHECK: directives. (authored by dergachev, committed by ). Herald added a subscribe

[PATCH] D64062: Remove __VERSION__

2019-07-12 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL365962: Remove __VERSION__ (authored by sylvestre, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D64062?vs=2094

[PATCH] D64695: [clang-format] Added new style rule: SortNetBSDIncludes

2019-07-14 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added a comment. Do you think there is anything about this algorithm that could be parameterized so that other projects could utilize it? I guess its not completely clear how this differs from just using the IncludeCategories? Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D64695: [clang-format] Added new style rule: SortNetBSDIncludes

2019-07-14 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added a comment. There also seems like alot of duplication between the existing sortCppIncludes I think the only difference here is really just SmallVector Indices; SmallVector Includes_p; for (unsigned i = 0, e = Includes.size(); i != e; ++i) { unsigned pl = getNe

[PATCH] D63936: [clang][Driver][ARM] Favor -mfpu over default CPU features

2019-07-14 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL366027: [clang][Driver][ARM] Favor -mfpu over default CPU features (authored by alelab01, committed by ). Herald added a subscriber: kristina. Changed prior to commit: https://reviews.llvm.org/D63936?vs

[PATCH] D64048: [TargetParser][ARM] Account dependencies when processing target features

2019-07-14 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL366031: [TargetParser][ARM] Account dependencies when processing target features (authored by alelab01, committed by ). Herald added a subscriber: kristina. Changed prior to commit: https://reviews.llvm

[PATCH] D64695: [clang-format] Added new style rule: SortNetBSDIncludes

2019-07-15 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added a comment. In D64695#1584740 , @Manikishan wrote: > In D64695#1584706 , @MyDeveloperDay > wrote: > > > There also seems like alot of duplication between the existing > > sortCppIncludes > > >

[PATCH] D64695: [clang-format] Added new style rule: SortNetBSDIncludes

2019-07-15 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added inline comments. Comment at: unittests/Format/SortIncludesTest.cpp:709 + "#include \"pathnames.h\"\n", + sort("#include \n" + "#include \n" should you add a test which has groups defined already, I'm un

[PATCH] D62413: [OpenCL][PR41727] Prevent ICE on global dtors

2019-07-15 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL366059: [OpenCL][PR41727] Prevent ICE on global dtors (authored by stulova, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://review

[PATCH] D64400: [OpenCL][PR42390] Deduce addr space for templ specialization

2019-07-15 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL366063: [OpenCL] Deduce addr space for pointee of dependent types in instantiation. (authored by stulova, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed pri

[PATCH] D63048: Update __VERSION__ to remove the hardcoded 4.2.1 version

2019-07-15 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL366091: Update __VERSION__ to remove the hardcoded 4.2.1 version (authored by sylvestre, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANG

[PATCH] D64695: [clang-format] Added new style rule: SortNetBSDIncludes

2019-07-15 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added a comment. I appreciate what you've done to make this patch less duplicated code..but now you've almost got to the point where being able to control it all via configuration. I'm with @rdwampler I think you should be able to extend the include categories...and then this be

[PATCH] D63062: [clang-format] Added New Style Rule: BitFieldDeclarationsOnePerLine

2019-07-15 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added inline comments. Comment at: unittests/Format/FormatTest.cpp:3671 + ); +} MyDeveloperDay wrote: > please add a test with comments (it will get logged) > > > ``` > unsigned int baz : 11, /*motor control flags*/ > add

[PATCH] D64129: [clang-scan-view] Force utf-8 when handling report (python2 only)

2019-07-16 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL366194: [clang-scan-view] Force utf-8 when handling report (python2 only) (authored by serge_sans_paille, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed pri

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

2019-07-17 Thread serge via Phabricator via cfe-commits
serge-sans-paille updated this revision to Diff 210273. serge-sans-paille marked 5 inline comments as done and 2 inline comments as done. serge-sans-paille added a comment. Added a `Bye` project in examples/ Fixed linking of plugins into core tools Fixed dependency issue Repository: rG LLVM G

[PATCH] D64861: [clang-tidy] Adjust location of namespace comment diagnostic

2019-07-17 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL366337: [clang-tidy] Adjust location of namespace comment diagnostic (authored by ibiryukov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D64418: [Docs][OpenCL] Documentation of C++ for OpenCL mode

2019-07-17 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL366351: [Docs][OpenCL] Documentation of C++ for OpenCL mode (authored by stulova, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://

[PATCH] D63852: [Clang] Move assembler into a separate file

2019-07-17 Thread Ayke via Phabricator via cfe-commits
aykevl added a comment. ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63852/new/ https://reviews.llvm.org/D63852 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D64850: Remove use of malloc in PPC mm_malloc.

2019-07-17 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL366406: [PowerPC][Clang] Remove use of malloc in mm_malloc (authored by chaofan, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://r

[PATCH] D62584: [OpenCL][PR42033] Deducing addr space with template parameter types

2019-07-18 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL366417: [OpenCL][PR42033] Fix addr space deduction with template parameters (authored by stulova, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to co

[PATCH] D64867: [OpenCL] Update comments/diagnostics to refer to C++ for OpenCL mode

2019-07-18 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL366421: [OpenCL] Update comments/diagnostics to refer to C++ for OpenCL (authored by stulova, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit

[PATCH] D64918: [ASTUnit] Fix a regression in cached completions

2019-07-18 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL366448: [ASTUnit] Fix a regression in cached completions (authored by ibiryukov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://r

<    18   19   20   21   22   23   24   25   26   27   >