[PATCH] D71991: Fix external-names.c test when separator is \\

miyuki accepted this revision. miyuki added a comment. This revision is now accepted and ready to land. LGTM. Let's wait for someone else to approve (or commit after holidays if no one objects). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71991/n

[PATCH] D88164: [clang][Sema] Use enumerator instead of hard-coded constant

miyuki created this revision. miyuki added reviewers: compnerd, aaron.ballman. Herald added a project: clang. Herald added a subscriber: cfe-commits. miyuki requested review of this revision. Sema::DiagnoseSwiftName uses the constant 12 instead of the corresponding enumerator ExpectedFunctionWithP

[PATCH] D88164: [clang][Sema] Use enumerator instead of hard-coded constant

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8cc842a95072: [clang][Sema] Use enumerator instead of hard-coded constant (authored by miyuki). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D86146: [ARM][BFloat16] Change types of some Arm and AArch64 bf16 intrinsics

miyuki added a comment. In D86146#2226702 , @dmgreen wrote: > Do we need to upgrade the old bfmmla to the new signatures? What is the old bfmmla? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86146/new/ ht

[PATCH] D86146: [ARM][BFloat16] Change types of some Arm and AArch64 bf16 intrinsics

miyuki updated this revision to Diff 286761. miyuki added a comment. Keep the second vbfmlaltq_laneq_f32 test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86146/new/ https://reviews.llvm.org/D86146 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/test/CodeGen/aarch64-bf16-dotprod-intr

[PATCH] D41179: [Sema] Diagnose template specializations with C linkage

miyuki abandoned this revision. miyuki added a comment. Abandoning in favour of: commit a64883431369f28f3fac311c496a4dfad480058f Author: Richard Smith Date: Wed Jul 29 16:49:05 2020 -0700 PR46729: Reject explicit and par

[PATCH] D86146: [ARM][BFloat16] Change types of some Arm and AArch64 bf16 intrinsics

miyuki updated this revision to Diff 288068. miyuki edited the summary of this revision. miyuki set the repository for this revision to rG LLVM Github Monorepo. miyuki added a comment. Herald added a subscriber: wenlei. 1. Also update bfdot 2. Add auto-upgrade for old intrinsics Repository: rG

[PATCH] D86146: [ARM][BFloat16] Change types of some Arm and AArch64 bf16 intrinsics

miyuki added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsAArch64.td:473 def int_aarch64_neon_bfdot : AdvSIMD_Dot_Intrinsic; - def int_aarch64_neon_bfmmla : AdvSIMD_MatMul_Intrinsic; - def int_aarch64_neon_bfmlalb : AdvSIMD_FML_Intrinsic; - def int_aarch64_ne

[PATCH] D86146: [ARM][BFloat16] Change types of some Arm and AArch64 bf16 intrinsics

miyuki updated this revision to Diff 288373. miyuki added a comment. Small refactoring of bitcode updater tests (use `some-name.ll.bc` names for bitcode files in order to be able to refer to them as `%s.bc` from `some-name.ll`) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D86146: [ARM][BFloat16] Change types of some Arm and AArch64 bf16 intrinsics

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGae1396c7d4d8: [ARM][BFloat16] Change types of some Arm and AArch64 bf16 intrinsics (authored by miyuki). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D93022: [ARM][AArch64] Add Cortex-A78C Support for Clang and LLVM

miyuki added inline comments. Comment at: llvm/unittests/Support/TargetParserTest.cpp:47 +if (!pass) + std::cout << "ExpectedFlags = 0x" << std::hex << ExpectedFlags +<< " do not equal ExtKind = 0x" << std::hex << ExtKind I suggest using LLVM I/O

[PATCH] D89705: [clang] Use SourceLocation as key in std::map, NFCI

miyuki created this revision. miyuki added a reviewer: dexonsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. miyuki requested review of this revision. SourceLocation implements `operator<`, so `SourceLocation`-s can be used as keys in `std::map` directly, there is no n

[PATCH] D69840: [Basic] Make SourceLocation usable as key in hash maps, NFCI

miyuki added a comment. Yes, I am still interested in working on this. For now, I've split out some changes that don't require any modifications in `SourceLocation` into https://reviews.llvm.org/D89705. > A general comment is that there are a couple of functional changes in this > patch, where

[PATCH] D89705: [clang] Use SourceLocation as key in std::map, NFCI

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa3c16039b3f1: [clang] Use SourceLocation as key in std::map, NFCI (authored by miyuki). Changed prior to commit: https://reviews.llvm.org/D89705?v

[PATCH] D89719: [clang][Basic] Make SourceLocation usable as key in hash maps, NFCI

miyuki created this revision. miyuki added a reviewer: dexonsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. miyuki requested review of this revision. This change creates a `DenseMapInfo` trait specialization for the SourceLocation class. The empty key, the tombstone k

[PATCH] D69840: [clang] Use SourceLocation as key in hash maps, NFCI

miyuki updated this revision to Diff 299126. miyuki edited the summary of this revision. miyuki added a comment. Split out the refactoring part. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69840/new/ https://reviews.llvm.org/D69840 Files: clang-tools-extra/clang-tidy/cppcoreguideli

[PATCH] D89719: [clang][Basic] Make SourceLocation usable as key in hash maps, NFCI

miyuki updated this revision to Diff 299340. miyuki edited the summary of this revision. miyuki added a comment. Added an example of usage. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89719/new/ https://reviews.llvm.org/D89719 Files: clang-too

[PATCH] D89719: [clang][Basic] Make SourceLocation usable as key in hash maps, NFCI

miyuki added a comment. The build failure is unrelated (see D89463 ) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89719/new/ https://reviews.llvm.org/D89719 ___ cfe-comm

[PATCH] D89719: [clang][Basic] Make SourceLocation usable as key in hash maps, NFCI

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG234c47ae2a8e: [clang][Basic] Make SourceLocation usable as key in hash maps, NFCI (authored by miyuki). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D69840: [clang] Use SourceLocation as key in hash maps, NFCI

This revision was automatically updated to reflect the committed changes. Closed by commit rG781941183700: [clang] Use SourceLocation as key in hash maps, NFCI (authored by miyuki). Changed prior to commit: https://reviews.llvm.org/D69840?vs=299126&id=299366#toc Repository: rG LLVM Github Mo

[PATCH] D69903: [Basic] Introduce PODSourceLocation, NFCI

miyuki added a comment. In D69903#2340020 , @dexonsmith wrote: > An alternative would be to update the unions to an `AlignedCharArrayUnion` > and use `SourceLocation` directly. WDYT? So, say, in `DeclarationNameLoc`, I would add `AlignedCharArrayUnion` a

[PATCH] D69844: [clang][Basic] Integrate SourceLocation with FoldingSet, NFCI

miyuki updated this revision to Diff 300044. miyuki retitled this revision from "[Basic] Integrate SourceLocation and SourceRange with FoldingSet, NFCI" to "[clang][Basic] Integrate SourceLocation with FoldingSet, NFCI". miyuki edited the summary of this revision. miyuki added a comment. Address

[PATCH] D69844: [clang][Basic] Integrate SourceLocation with FoldingSet, NFCI

miyuki updated this revision to Diff 300049. miyuki added a comment. Reverted accidentally removed chunk. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69844/new/ https://reviews.llvm.org/D69844 Files: clang/include/clang/Basic/SourceLocation.h

[PATCH] D69844: [clang][Basic] Integrate SourceLocation with FoldingSet, NFCI

miyuki updated this revision to Diff 300214. miyuki added a comment. Fixed linter errors. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69844/new/ https://reviews.llvm.org/D69844 Files: clang/include/clang/Basic/SourceLocation.h clang/lib/Anal

[PATCH] D69844: [clang][Basic] Integrate SourceLocation with FoldingSet, NFCI

miyuki added inline comments. Comment at: clang/lib/Analysis/PathDiagnostic.cpp:1088 + ID.Add(Range.getEnd()); + ID.Add(static_cast(Loc)); } dexonsmith wrote: > I'm surprised you need this `static_cast`, can you explain why it was > necessary? `Loc` is an obj

[PATCH] D69844: [clang][Basic] Integrate SourceLocation with FoldingSet, NFCI

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG443ab4d2e012: [clang][Basic] Integrate SourceLocation with FoldingSet, NFCI (authored by miyuki). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D94599: [clang][Tooling] Get rid of a hack in SymbolOccurrences, NFCI

This revision was automatically updated to reflect the committed changes. Closed by commit rGa0e30914f8c8: [clang][Tooling] Get rid of a hack in SymbolOccurrences, NFCI (authored by miyuki). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94599/new/ h

[PATCH] D94596: [clang][AST] Encapsulate DeclarationNameLoc, NFCI

This revision was automatically updated to reflect the committed changes. Closed by commit rG30d9ca1bd9de: [clang][AST] Encapsulate DeclarationNameLoc, NFCI (authored by miyuki). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94596/new/ https://revie

[PATCH] D97204: [RFC] Clang 64-bit source locations

miyuki created this revision. miyuki added a reviewer: rsmith. Herald added subscribers: dexonsmith, lebedev.ri, martong, arphaman, kbarton, hiraditya, mgorny, nemanjai. Herald added a reviewer: lebedev.ri. miyuki requested review of this revision. Herald added projects: clang, LLVM. Herald added

[PATCH] D97204: [RFC] Clang 64-bit source locations

miyuki added a comment. In D97204#2580490 , @akyrtzi wrote: > Hi @miyuki, > >> A major thing worth noting is that 64-bit source locations will >> require an ABI breakage in libclang. This patch changes the bit width >> in libclang unconditionally, rather t

[PATCH] D97204: [RFC] Clang 64-bit source locations

miyuki updated this revision to Diff 325762. miyuki edited the summary of this revision. miyuki added a comment. Fixed python bindings and formatting. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97204/new/ https://reviews.llvm.org/D97204 Files: clang-tools-extra/clang-tidy/readabil

[PATCH] D97204: [RFC] Clang 64-bit source locations

miyuki added a comment. In D97204#2586111 , @rsmith wrote: > Thanks for doing this! > > The 8-9% memory hit is better than I'd feared, but still seems uncomfortably > large. I've left comments on a couple of places where I think we could > substantially

[PATCH] D104442: [libclang] Fix error handler in translateSourceLocation.

miyuki accepted this revision. miyuki added a comment. This revision is now accepted and ready to land. This change is pretty obvious. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104442/new/ https://reviews.llvm.org/D104442 ___

[PATCH] D105490: Remove unused parameter from parseMSInlineAsm.

miyuki accepted this revision. miyuki added a comment. This revision is now accepted and ready to land. This change is not part of my original D97204 patch (in D97204 , I replaced `void *AsmLoc` with `uint64_t AsmLoc`), so I thin

[PATCH] D105493: [clang] Change set type used for SourceLocation.

miyuki added inline comments. Comment at: clang/include/clang/Basic/SourceLocation.h:19 #include "llvm/ADT/StringRef.h" #include "llvm/Support/PointerLikeTypeTraits.h" #include Can this `#include` be removed? Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D112431: [ARM][clang] Define feature test macro for the PACBTI-M extension

miyuki added inline comments. Comment at: clang/lib/Basic/Targets/ARM.cpp:897 +Builder.defineMacro("__ARM_FEATURE_PAUTH", "1"); +Builder.defineMacro("__ARM_FEATURE_BTI", "1"); + } Since we decided to have two separate flags, I think this line should be i

[PATCH] D142932: Multilib YAML parsing

miyuki added inline comments. Comment at: clang/lib/Driver/Multilib.cpp:82 + for (const Matcher &M : Matchers) { +const std::regex Regex(M.Regex); +if (std::find_if(InFlags.begin(), InFlags.end(), Please use the LLVM regular expression engine (llvm/Suppo

[PATCH] D142932: Multilib YAML parsing

miyuki added inline comments. Comment at: clang/lib/Driver/Multilib.cpp:83 +const std::regex Regex(M.Regex); +if (std::find_if(InFlags.begin(), InFlags.end(), + [&Regex](const std::string &F) { Please use `llvm::find_if(InFlags, ...)`

[PATCH] D126061: [clang] Reject non-declaration C++11 attributes on declarations

miyuki added a comment. Hi Martin, I think this patch caused a regression. Clang used to warn about the following code: struct X { [[deprecated]] struct Y {}; }; $ clang -std=c++17 -Wall test.cpp :2:7: warning: attribute 'deprecated' is ignored, place it after "struct" to appl

[PATCH] D138679: [clang][CodeGen] Add default attributes to __clang_call_terminate

miyuki added a comment. The CI failures look related to this change: https://buildkite.com/llvm-project/premerge-checks/builds/123301#0184aa94-1b82-44a9-9c25-4074e026d266 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138679/new/ https://reviews.ll

[PATCH] D76610: [ARM,CDE] Implement predicated Q-register CDE intrinsics

miyuki created this revision. miyuki added reviewers: simon_tatham, MarkMurrayARM, ostannard, dmgreen. Herald added subscribers: cfe-commits, danielkiss, hiraditya, kristof.beyls. Herald added a project: clang. This patch implements the following CDE intrinsics: T __arm_vcx1q_m(int coproc, T in

[PATCH] D76714: [ARM,MVE] Add missing tests for vqdmlash intrinsics.

miyuki accepted this revision. miyuki added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76714/new/ https://reviews.llvm.org/D76714 ___

[PATCH] D76610: [ARM,CDE] Implement predicated Q-register CDE intrinsics

This revision was automatically updated to reflect the committed changes. Closed by commit rGbb4da94e5b5f: [ARM,CDE] Implement predicated Q-register CDE intrinsics (authored by miyuki). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76610/new/ https:

[PATCH] D76927: [ARM,CDE] Improve CDE intrinsics testing

miyuki created this revision. miyuki added reviewers: simon_tatham, MarkMurrayARM, ostannard, dmgreen. Herald added subscribers: cfe-commits, kristof.beyls. Herald added a project: clang. This patch: - adds tests for vreinterpret intinsics in big-endian mode - adds C++ runs to the CDE+MVE header

[PATCH] D76927: [ARM,CDE] Improve CDE intrinsics testing

This revision was automatically updated to reflect the committed changes. Closed by commit rGbd722ef63f18: [ARM,CDE] Improve CDE intrinsics testing (authored by miyuki). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76927/new/ https://reviews.llvm.o

[PATCH] D74838: [ARM,MVE] Fix predicate types of some intrinsics

miyuki created this revision. miyuki added reviewers: simon_tatham, dmgreen, ostannard, MarkMurrayARM. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. Some predicated MVE intrinsics return a vector with element size different from

[PATCH] D74838: [ARM,MVE] Fix predicate types of some intrinsics

miyuki added a comment. The test failure is unrelated Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74838/new/ https://reviews.llvm.org/D74838 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D74838: [ARM,MVE] Fix predicate types of some intrinsics

This revision was automatically updated to reflect the committed changes. Closed by commit rG461fd94f004c: [ARM,MVE] Fix predicate types of some intrinsics (authored by miyuki). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74838/new/ https://review

[PATCH] D74845: [ARM,MVE] Add vqdmull[b,t]q intrinsic families

miyuki created this revision. miyuki added reviewers: simon_tatham, MarkMurrayARM, dmgreen, ostannard. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. This patch adds two families of ACLE intrinsics: vqdmullbq and vqdmulltq (includ

[PATCH] D74845: [ARM,MVE] Add vqdmull[b,t]q intrinsic families

miyuki added a comment. The Windows failure is similar to https://github.com/google/llvm-premerge-checks/issues/132, it looks like an infrastructure issue to me, so I am going to ignore it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74845/new/

[PATCH] D74845: [ARM,MVE] Add vqdmull[b,t]q intrinsic families

This revision was automatically updated to reflect the committed changes. Closed by commit rGf4fd7dbf85e2: [ARM,MVE] Add vqdmull[b,t]q intrinsic families (authored by miyuki). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74845/new/ https://reviews.

[PATCH] D75038: [ARM,MVE] Remove 64-bit variants of vbrsrq* intrinsics

miyuki created this revision. miyuki added reviewers: simon_tatham, dmgreen, MarkMurrayARM, ostannard. Herald added subscribers: cfe-commits, kristof.beyls. Herald added a project: clang. According to the ACLE the vbrsrq* intrinsics don't accept vectors with 64-bit elements (and neither does the c

[PATCH] D75038: [ARM,MVE] Remove 64-bit variants of vbrsrq* intrinsics

This revision was automatically updated to reflect the committed changes. Closed by commit rG12fed51c0807: [ARM,MVE] Remove 64-bit variants of vbrsrq* intrinsics (authored by miyuki). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75038/new/ https://

[PATCH] D75254: [ARM,MVE] Add ACLE intrinsics for VCVT.F32.F16 family.

miyuki accepted this revision. miyuki added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75254/new/ https://reviews.llvm.org/D75254 ___

[PATCH] D75444: [ARM,MVE] Add the `vsbciq` intrinsics.

miyuki accepted this revision. miyuki added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75444/new/ https://reviews.llvm.org/D75444 ___

[PATCH] D75445: [ARM,MVE] Add the `vshlcq` intrinsics.

miyuki added a comment. FYI: I have raised https://github.com/google/llvm-premerge-checks/issues/141 (the premerge check machinery failed to apply the patch, but this is not reflected in the build status). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D75445: [ARM,MVE] Add the `vshlcq` intrinsics.

miyuki accepted this revision. miyuki added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75445/new/ https://reviews.llvm.org/D75445 ___

[PATCH] D69840: [Basic] Make SourceLocation usable as key in hash maps, NFCI

miyuki created this revision. miyuki added reviewers: aprantl, rsmith, faisalv. Herald added a reviewer: jdoerfert. Herald added a project: clang. Herald added a subscriber: cfe-commits. miyuki edited reviewers, added: JDevlieghere; removed: jdoerfert. Herald added a reviewer: jdoerfert. This chan

[PATCH] D69844: [Basic] Integrate SourceLocation with FoldingSet, NFCI

miyuki created this revision. miyuki added reviewers: aprantl, faisalv, rsmith, JDevlieghere. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch removes the necessity to access the SourceLocation internal representation in several places which use FoldingSet objects.

[PATCH] D69840: [Basic] Make SourceLocation usable as key in hash maps, NFCI

miyuki updated this revision to Diff 227894. miyuki added a comment. Changed getRawEncoding -> getHashValue in Sema.h CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69840/new/ https://reviews.llvm.org/D69840 Files: clang/include/clang/Basic/SourceLocation.h clang/include/clang/Edit/

[PATCH] D69840: [Basic] Make SourceLocation usable as key in hash maps, NFCI

miyuki added a comment. The motivation is to be able to make source locations' underlying type configurable. Richard Smith suggested that this might be feasible: http://lists.llvm.org/pipermail/cfe-dev/2019-October/063515.html So, the first step is to get rid of getRawEncoding where possible. I

[PATCH] D69903: [Basic] Introduce PODSourceLocation, NFCI

miyuki created this revision. miyuki added reviewers: faisalv, rsmith, aprantl, JDevlieghere. Herald added subscribers: cfe-commits, jfb, arphaman. Herald added a project: clang. miyuki added a parent revision: D69840: [Basic] Make SourceLocation usable as key in hash maps, NFCI. miyuki edited par

[PATCH] D70183: Detect source location overflow due includes

miyuki added inline comments. Comment at: clang/lib/Basic/SourceManager.cpp:587 +Diag.Report(IncludePos, diag::err_include_too_large); +exit(1); + } dnsampaio wrote: > For debug builds, I could not find any other way to not reach an assert > failure oth

[PATCH] D70183: Detect source location overflow due includes

miyuki added inline comments. Comment at: clang/include/clang/Basic/DiagnosticCommonKinds.td:288 + " Clang to process. This may by a result from multiple" + " inclusions of unguarded header files.">; def err_unsupported_bom : Error<"%0 byte order mark detected in '%1', but " -

[PATCH] D70183: Detect source location overflow due includes

miyuki added inline comments. Comment at: clang/lib/Basic/SourceManager.cpp:587 +Diag.Report(IncludePos, diag::err_include_too_large); +exit(1); + } dnsampaio wrote: > miyuki wrote: > > dnsampaio wrote: > > > For debug builds, I could not find any other

[PATCH] D69840: [Basic] Make SourceLocation usable as key in hash maps, NFCI

miyuki added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69840/new/ https://reviews.llvm.org/D69840 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D70183: Detect source location overflow due includes

miyuki added inline comments. Comment at: clang/lib/Basic/SourceManager.cpp:587 +Diag.Report(IncludePos, diag::err_include_too_large); +exit(1); + } dnsampaio wrote: > miyuki wrote: > > dnsampaio wrote: > > > miyuki wrote: > > > > dnsampaio wrote: > > >

[PATCH] D70183: Detect source location overflow due includes

miyuki added a comment. In D70183#1751552 , @dnsampaio wrote: > Yes. It does return a non-valid FileID, and in builds without assert you get > the expected error message. I was asking about "It will still reach an false assert in builds that enable the

[PATCH] D70183: Detect source location overflow due includes

miyuki requested changes to this revision. miyuki added a comment. This revision now requires changes to proceed. This essentially means that if there is a problem related to this change, say something goes wrong after `return FileID();` it would be impossible to debug until the corresponding as

[PATCH] D70183: Detect source location overflow due includes

miyuki added a comment. In D70183#1751813 , @dnsampaio wrote: > Git diff 979ae80af7ec49624b932954d22cb91900f17121 did not send a test as > well. Feel free to send me a reasonable sized reproducer, the one I have is > about 36MB. Don't think it will be th

[PATCH] D69840: [Basic] Make SourceLocation usable as key in hash maps, NFCI

miyuki added a comment. ping^2 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69840/new/ https://reviews.llvm.org/D69840 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D69840: [Basic] Make SourceLocation usable as key in hash maps, NFCI

miyuki added a comment. ping^3 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69840/new/ https://reviews.llvm.org/D69840 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D70183: Detect source location overflow due includes

miyuki added a comment. > clang shall either die due an assert in debug [...] I think I have already mentioned the reasons why I don't think this is acceptable: - it would break tests, as they are usually run with enabled assertions (and since this diagnostic is quite easy to test, it should b

[PATCH] D71066: [ARM][MVE][Intrinsics] Add VMULL[BT]Q_(INT|POLY) intrinsics.

miyuki added inline comments. Comment at: llvm/lib/Target/ARM/ARMInstrMVE.td:286 + // The LLVM ValueType representing the vector double the size of Vec, + // so we can use it in ISel patterns. As I understand from the code below, the comment should say that t

[PATCH] D71245: [ARM][MVE] Refactor complex vector intrinsics [NFCI]

miyuki created this revision. miyuki added reviewers: dmgreen, ostannard, simon_tatham, MarkMurrayARM. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. This patch refactors instruction selection of the complex vector addition, multi

[PATCH] D71245: [ARM][MVE] Refactor complex vector intrinsics [NFCI]

This revision was automatically updated to reflect the committed changes. Closed by commit rGe6d3261c67ec: [ARM][MVE] Refactor complex vector intrinsics [NFCI] (authored by miyuki). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71245/new/ https://re

[PATCH] D71335: [ARM][MVE] Factor out an IntrinsicMX multiclass.

miyuki accepted this revision. miyuki added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71335/new/ https://reviews.llvm.org/D71335 ___

[PATCH] D71062: [ARM][MVE] Add vector reduction intrinsics with two vector operands

miyuki marked an inline comment as done. miyuki added inline comments. Comment at: clang/include/clang/Basic/arm_mve.td:845 + +let params = [s16, s32] in { +defm vmlaldav : MVEBinaryVectorHoriz64; MarkMurrayARM wrote: > Types again? I don't it's worth adding a ne

[PATCH] D75843: [ARM,CDE] Implement CDE feature test macros

miyuki created this revision. miyuki added reviewers: simon_tatham, dmgreen, ostannard, MarkMurrayARM. Herald added subscribers: cfe-commits, danielkiss, kristof.beyls. Herald added a project: clang. This patch implements feature test macros for the CDE extension according to the upcoming ACLE spe

[PATCH] D75843: [ARM,CDE] Implement CDE feature test macros

miyuki updated this revision to Diff 249103. miyuki added a comment. Fixed typos and formatting. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75843/new/ https://reviews.llvm.org/D75843 Files: clang/include/clang/Basic/TargetInfo.h clang/lib/Basic/TargetInfo.cpp clang/lib/Basic/T

[PATCH] D75850: [ARM, CDE] Generalize MVE intrinsics infrastructure to support CDE

miyuki created this revision. miyuki added reviewers: simon_tatham, MarkMurrayARM, ostannard, dmgreen. Herald added subscribers: llvm-commits, cfe-commits, danielkiss, kristof.beyls, mgorny. Herald added projects: clang, LLVM. miyuki added a parent revision: D75843: [ARM,CDE] Implement CDE feature

[PATCH] D75843: [ARM,CDE] Implement CDE feature test macros

miyuki marked an inline comment as done. miyuki added inline comments. Comment at: clang/lib/Basic/Targets/ARM.cpp:492 HW_FP |= HW_FP_SP | HW_FP_HP; +} else if (Feature >= "+cdecp0" && Feature <= "+cdecp7") { + unsigned Coproc = Feature.back() - '0'; -

[PATCH] D75843: [ARM,CDE] Implement CDE feature test macros

miyuki updated this revision to Diff 249115. miyuki added a comment. Fix condition check CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75843/new/ https://reviews.llvm.org/D75843 Files: clang/include/clang/Basic/TargetInfo.h clang/lib/Basic/TargetInfo.cpp clang/lib/Basic/Targets/A

[PATCH] D75843: [ARM,CDE] Implement CDE feature test macros

This revision was automatically updated to reflect the committed changes. Closed by commit rGcdeeb548bbeb: [ARM,CDE] Implement CDE feature test macros (authored by miyuki). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75843/new/ https://reviews.llv

[PATCH] D75850: [ARM, CDE] Generalize MVE intrinsics infrastructure to support CDE

miyuki updated this revision to Diff 249140. miyuki added a comment. Fix linter and formatter warnings CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75850/new/ https://reviews.llvm.org/D75850 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/AttrDocs.td clang/inc

[PATCH] D75470: [SVE] Auto-generate builtins and header for svld1.

miyuki added a comment. In D75470#1910071 , @sdesmalen wrote: > The SVE implementation now does more or less the same thing the MVE > implementation; `arm_sve.h` also uses `__attribute__((overloadable))` and > `__attribute__((arm_sve_alias("__builtin_...

[PATCH] D75850: [ARM, CDE] Generalize MVE intrinsics infrastructure to support CDE

miyuki added a comment. In D75850#1912810 , @sdesmalen wrote: > but am happy to update my patch to reuse the generic > `__clang_arm_builtin_alias`! Please do. It would be nicer to have a single attribute than 2 or 3 distinct ones which serve essentia

[PATCH] D75850: [ARM, CDE] Generalize MVE intrinsics infrastructure to support CDE

miyuki updated this revision to Diff 249362. miyuki added a comment. Address review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75850/new/ https://reviews.llvm.org/D75850 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/AttrDocs.td clang/include/clang

[PATCH] D75850: [ARM, CDE] Generalize MVE intrinsics infrastructure to support CDE

This revision was automatically updated to reflect the committed changes. Closed by commit rG47edf5bafb8e: [ARM,CDE] Generalize MVE intrinsics infrastructure to support CDE (authored by miyuki). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75850/new

[PATCH] D75861: [SVE] Generate overloaded functions for ACLE intrinsics.

miyuki added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:5002 if (!ArmMveAliasValid(BuiltinID, AliasName) && + !ArmCdeAliasValid(BuiltinID, AliasName) && I would suggest splitting the check into Arm-specific and AArch64-specific checks

[PATCH] D75861: [SVE] Generate overloaded functions for ACLE intrinsics.

miyuki added a comment. The clang attribute part LGTM, but I want someone else to check the rest. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75861/new/ https://reviews.llvm.org/D75861 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D75850: [ARM, CDE] Generalize MVE intrinsics infrastructure to support CDE

miyuki marked an inline comment as done. miyuki added a comment. Should compile without warnings now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75850/new/ https://reviews.llvm.org/D75850 ___ cfe-co

[PATCH] D69840: [Basic] Make SourceLocation usable as key in hash maps, NFCI

miyuki updated this revision to Diff 249443. miyuki added a comment. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, kbarton, nemanjai. Rebased, updated several more hash map occurrences. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69840/new/ https://reviews.llvm.or

[PATCH] D69903: [Basic] Introduce PODSourceLocation, NFCI

miyuki updated this revision to Diff 249447. miyuki added a comment. Rebased CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69903/new/ https://reviews.llvm.org/D69903 Files: clang/include/clang/AST/DeclObjC.h clang/include/clang/AST/DeclarationName.h clang/include/clang/AST/Depend

[PATCH] D69844: [Basic] Integrate SourceLocation and SourceRange with FoldingSet, NFCI

miyuki updated this revision to Diff 249444. miyuki retitled this revision from "[Basic] Integrate SourceLocation with FoldingSet, NFCI" to "[Basic] Integrate SourceLocation and SourceRange with FoldingSet, NFCI". miyuki added a comment. Herald added a subscriber: martong. Rebased, added similar

[PATCH] D75997: [ARM,MVE] Fix user-namespace violation in arm_mve.h.

miyuki accepted this revision. miyuki added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75997/new/ https://reviews.llvm.org/D75997 ___

[PATCH] D76123: [ARM,MVE] Add intrinsics for the VQDMLAH family.

miyuki accepted this revision. miyuki added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76123/new/ https://reviews.llvm.org/D76123 ___

[PATCH] D76296: [ARM,CDE] Implement GPR CDE intrinsics

miyuki created this revision. miyuki added reviewers: simon_tatham, MarkMurrayARM, dmgreen, ostannard. Herald added subscribers: cfe-commits, danielkiss, hiraditya, kristof.beyls. Herald added a project: clang. miyuki added a parent revision: D76298: [ARM,CDE] Implement CDE S and D-register intrin

[PATCH] D76298: [ARM,CDE] Implement CDE S and D-register intrinsics

miyuki created this revision. miyuki added reviewers: simon_tatham, MarkMurrayARM, ostannard, dmgreen. Herald added subscribers: cfe-commits, danielkiss, hiraditya, kristof.beyls. Herald added a project: clang. miyuki added a child revision: D76296: [ARM,CDE] Implement GPR CDE intrinsics. miyuki re

[PATCH] D76299: [ARM,CDE] Implement CDE unpredicated Q-register intrinsics

miyuki created this revision. miyuki added reviewers: simon_tatham, MarkMurrayARM, dmgreen, ostannard. Herald added subscribers: cfe-commits, danielkiss, hiraditya, kristof.beyls. Herald added a project: clang. miyuki added a parent revision: D76298: [ARM,CDE] Implement CDE S and D-register intrin

<    1   2   3   >