miyuki added inline comments.

================
Comment at: clang/lib/Basic/Targets/ARM.cpp:897
+    Builder.defineMacro("__ARM_FEATURE_PAUTH", "1");
+    Builder.defineMacro("__ARM_FEATURE_BTI", "1");
+  }
----------------
Since we decided to have two separate flags, I think this line should be in a 
separate if statement: `if (HasBTI)`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112431/new/

https://reviews.llvm.org/D112431

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to