[PATCH] D151834: Include math-errno with fast-math

uabelho added a comment. In D151834#4644692 , @zahiraam wrote: > [...] >> I think the issue comes from here: >> https://github.com/llvm/llvm-project/blob/main/clang/lib/CodeGen/CGBuiltin.cpp#L2365 > > This looks like it's happening only for -Oi (i>=1)

[PATCH] D151834: Include math-errno with fast-math

uabelho added a comment. What's the way forward here? Revert if it's unclear what to do? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151834/new/ https://reviews.llvm.org/D151834 ___ cfe-commits mailing

[PATCH] D151834: Include math-errno with fast-math

uabelho added a comment. In D151834#4645910 , @zahiraam wrote: > In D151834#4645866 , @uabelho wrote: > >> What's the way forward here? Revert if it's unclear what to do? > > We have a fix for it. By eod a PR will

[PATCH] D153366: [dataflow] Add dedicated representation of boolean formulas

uabelho added a comment. Failed Tests (6): Clang-Unit :: Analysis/FlowSensitive/./ClangAnalysisFlowSensitiveTests/BoolValueDebugStringTest/ComplexBooleanWithSomeNames Clang-Unit :: Analysis/FlowSensitive/./ClangAnalysisFlowSensitiveTests/BoolValueDebugStringTest/Conjunction Clang-U

[PATCH] D153469: [dataflow] Replace most BoolValue subclasses with references to Formula (and AtomicBoolValue => Atom and BoolValue => Formula where appropriate)

uabelho added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowEnvironment.h:532 + void addToFlowCondition(const Formula &); + LLVM_DEPRECATED("Use Formula version instead", "") void addToFlowCondition(BoolValue &Val); There ar

[PATCH] D153469: [dataflow] Replace most BoolValue subclasses with references to Formula (and AtomicBoolValue => Atom and BoolValue => Formula where appropriate)

uabelho added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowEnvironment.h:532 + void addToFlowCondition(const Formula &); + LLVM_DEPRECATED("Use Formula version instead", "") void addToFlowCondition(BoolValue &Val); sammccal

[PATCH] D153469: [dataflow] Replace most BoolValue subclasses with references to Formula (and AtomicBoolValue => Atom and BoolValue => Formula where appropriate)

uabelho added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowEnvironment.h:532 + void addToFlowCondition(const Formula &); + LLVM_DEPRECATED("Use Formula version instead", "") void addToFlowCondition(BoolValue &Val); sammccal

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

uabelho added a comment. I've no idea what's happening but it seems like linking compiler-rt/lib/memprof/tests/MemProfUnitTests fails with this commit: [17/17] Linking CXX executable compiler-rt/lib/memprof/tests/MemProfUnitTests FAILED: compiler-rt/lib/memprof/tests/MemProfUnitTests : &&

[PATCH] D158715: [Driver] Cleanup last vestiges of Minix / Contiki support

uabelho added inline comments. Comment at: clang/lib/Lex/InitHeaderSearch.cpp:336 - case llvm::Triple::Minix: -AddGnuCPlusPlusIncludePaths("/usr/gnu/include/c++/4.4.3", -"", "", "", triple); @brad : I think this was the last u

[PATCH] D158715: [Driver] Cleanup last vestiges of Minix / Contiki support

uabelho added inline comments. Comment at: clang/lib/Lex/InitHeaderSearch.cpp:336 - case llvm::Triple::Minix: -AddGnuCPlusPlusIncludePaths("/usr/gnu/include/c++/4.4.3", -"", "", "", triple); brad wrote: > uabelho wrote: > > @b

[PATCH] D76856: Fix TBAA for unsigned fixed-point types

This revision was automatically updated to reflect the committed changes. Closed by commit rG7d482e921353: Fix TBAA for unsigned fixed-point types (authored by uabelho). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76856/new/ https://reviews.llvm.o

[PATCH] D69935: [DeclCXX] Remove unknown external linkage specifications

uabelho added a comment. Don't you need to also remove case LinkageSpecDecl::lang_cxx_11: case LinkageSpecDecl::lang_cxx_14: from VisitLinkageSpecDecl in clang-tools-extra/modularize/Modularize.cpp? (added in r372714 / e07376a320d to silence a clang warning). I can't see how that code would

[PATCH] D69935: [DeclCXX] Remove unknown external linkage specifications

uabelho added a comment. In D69935#1739235 , @dblaikie wrote: > In D69935#1738273 , @uabelho wrote: > > > Don't you need to also remove > > > > case LinkageSpecDecl::lang_cxx_11: > > case LinkageSpecDecl::lang_c

[PATCH] D146003: [StandardInstrumentations] Verify function doesn't change if analyses are preserved

uabelho added a comment. The improved verification found this: https://github.com/llvm/llvm-project/issues/61574 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146003/new/ https://reviews.llvm.org/D146003 __

[PATCH] D136497: [Clang] support for outputs along indirect edges of asm goto

uabelho added a comment. I noticed that gvn-hoist doesn't handle this very nicely, I just wrote https://github.com/llvm/llvm-project/issues/61023 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136497/new/ https://reviews.llvm.org/D136497 _

[PATCH] D151938: [clang][index] NFCI: Make `CXFile` a `FileEntryRef`

uabelho added inline comments. Comment at: clang/tools/libclang/CXFile.h:18 +inline CXFile makeCXFile(OptionalFileEntryRef FE) { + return CXFile(FE ? &FE->getMapEntry() : nullptr); +} Gcc warns here: ``` ../../clang/tools/libclang/CXFile.h:18:50: warning: cast f

[PATCH] D146987: [Assignment Tracking] Enable by default

uabelho added a comment. We've also seen crashes with this patch, e.g. clang -cc1 -triple x86_64-unknown-linux -emit-obj -debug-info-kind=constructor -O1 bbi-80938.c crashes with clang: ../include/llvm/ADT/IntervalMap.h:1187: bool llvm::IntervalMap >::overlaps(KeyT, KeyT) const [KeyT =

[PATCH] D147731: [3/11][POC][Clang][RISCV] Add typedef of the tuple type and define tuple type variant of vlseg2e32

uabelho added inline comments. Comment at: clang/include/clang/Support/RISCVVIntrinsicUtils.h:384 Policy PolicyAttrs; + bool IsTuple = false; ``` /home/buildbots/docker-RHEL84-buildbot/SetupBot/worker_env/ppc64le-clang-rhel-test/clang-ppc64le-rhel/llvm-proj

[PATCH] D137527: [C++20] [Modules] [ClangScanDeps] Add ClangScanDeps support for C++20 Named Modules in P1689 format (2/4)

uabelho added a comment. Hi, There seems to be something funny going on with the ClangScanDeps/P1689 .cppm testcase added in this patch. It fails randomly for me on top of tree (4ad8f7a189570 )

[PATCH] D143096: [clangd] Provide patched diagnostics with preamble patch

uabelho added a comment. Hello, I noticed that if I compile the compiler with ubsan, then lots of Clangd tests start failing with this patch: Failed Tests (165): Clangd :: ast-no-range.test Clangd :: ast.test Clangd :: call-hierarchy.test Clangd :: check-lines.test Clangd

[PATCH] D149718: [NFC][Clang] Fix Coverity issues of copy without assign

uabelho added a comment. Compiling with clang 15.0.5 I get the following warning/error with this patch: ../../clang/include/clang/Sema/ParsedAttr.h:705:18: error: explicitly defaulted move assignment operator is implicitly deleted [-Werror,-Wdefaulted-function-deleted] AttributePool &oper

[PATCH] D149718: [NFC][Clang] Fix Coverity issues of copy without assign

uabelho added a comment. In D149718#4341052 , @uabelho wrote: > Compiling with clang 15.0.5 I get the following warning/error with this patch: > > ../../clang/include/clang/Sema/ParsedAttr.h:705:18: error: explicitly > defaulted move assignment operato

[PATCH] D149718: [NFC][Clang] Fix Coverity issues of copy without assign

uabelho added a comment. In D149718#4342320 , @Manna wrote: > In D149718#4341384 , @uabelho wrote: > >> In D149718#4341052 , @uabelho >> wrote: >> >>> Compiling with clan

[PATCH] D150352: [clang][dataflow] Don't analyze templated declarations.

uabelho added a comment. Hello, ../../clang-tools-extra/clang-tidy/bugprone/UncheckedOptionalAccessCheck.cpp:43:27: error: 'build' is deprecated: Use the version that takes a const Decl & instead [-Werror,-Wdeprecated-declarations] ControlFlowContext::build(&FuncDecl, *FuncDecl.getBo

[PATCH] D148827: -fsanitize=function: support C

uabelho added a comment. Hi, A question: it seems like this messes with alignment on functions? So with input program al.c: __attribute__((aligned(64))) void alignedfn(void) { __asm("nop"); } void alignedfn2(void) { __asm("nop"); } int main(void){} if we compile with -fsanit

[PATCH] D28983: clang-format: remove tests that assume no config file will be found as this is not always the case

uabelho added a comment. Great! This patch solves the problems we saw. Thanks! https://reviews.llvm.org/D28983 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D79714: [Diagnostics] Restore -Wdeprecated warning when user-declared copy assignment operator is defined as deleted (PR45634)

uabelho added a comment. Hi, With this commit I get failures in the following testcases when building check-runtimes on trunk: Failed Tests (29): libc++ :: libcxx/debug/containers/db_sequence_container_iterators.pass.cpp libc++ :: libcxx/gdb/gdb_pretty_printer_test.sh.cpp libc++ :

[PATCH] D79714: [Diagnostics] Restore -Wdeprecated warning when user-declared copy assignment operator is defined as deleted (PR45634)

uabelho added a comment. In D79714#2711898 , @xbolva00 wrote: > Can you try this fix? > > diff --git a/libcxx/utils/libcxx/test/params.py > b/libcxx/utils/libcxx/test/params.py > index ddf277dea246..abf712e78a61 100644 > --- a/libcxx/utils/libcxx/te

[PATCH] D79714: [Diagnostics] Restore -Wdeprecated warning when user-declared copy assignment operator is defined as deleted (PR45634)

uabelho added a comment. In D79714#2713610 , @xbolva00 wrote: > I pushed a fix to just disable this warning for googlemock/gtest. Unfortunately that fix breaks compiling llvm with clang8. I commented in https://reviews.llvm.org/rG9658d045926545e62cc3f963

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

uabelho added a comment. I noticed that with this patch libcxx/test/std/strings/basic.string/string.cons/iter_alloc_deduction.fail.cpp fails: error: 'warning' diagnostics seen but not expected: File /repo/uabelho/master-github/libcxx/test/std/strings/basic.string/string.cons/iter_alloc_d

[PATCH] D98278: [test] Add ability to get error messages from CMake for errc substitution

uabelho added a comment. Hi, I'm seeing a problem with this. Compiling with gcc 9.3.0 the compilation of the test program works, but then when I run it I get /repo/uabelho/master-github/llvm/build-all-bbigcc/CMakeFiles/CMakeTmp/cmTC_00188: /lib64/libstdc++.so.6: version `GLIBCXX_3.4.21' not

[PATCH] D98278: [test] Add ability to get error messages from CMake for errc substitution

uabelho added a comment. In D98278#2628482 , @zero9178 wrote: > In D98278#2628477 , @uabelho wrote: > >> so perhaps there should be some additional error handling when running the >> compiled program doesn't work?

[PATCH] D87163: [DSE] Switch to MemorySSA-backed DSE by default.

uabelho added a comment. I wrote https://bugs.llvm.org/show_bug.cgi?id=49859 about a miscompile that started occuring when turning on memoryssa again in DSE. I suspect that licm doesn't keep memoryssa updated properly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D91927: [X86] Add x86_amx type for intel AMX.

uabelho added inline comments. Comment at: llvm/include/llvm/IR/Type.h:68 X86_MMXTyID, ///< MMX vectors (64 bits, X86 specific) +X86_AMXTyID, ///< AMX vectors (8192 bits, X86 specific) TokenTyID, ///< Tokens This addition causes a compilatio

[PATCH] D91927: [X86] Add x86_amx type for intel AMX.

uabelho added inline comments. Comment at: llvm/include/llvm/IR/Type.h:68 X86_MMXTyID, ///< MMX vectors (64 bits, X86 specific) +X86_AMXTyID, ///< AMX vectors (8192 bits, X86 specific) TokenTyID, ///< Tokens pengfei wrote: > uabelho wrote: >

[PATCH] D108696: [Coroutines] [Frontend] Lookup in std namespace first

uabelho added a comment. This patch makes several libcxx tests fail due to the new warning. See e.g. http://lab.llvm.org:8011/#/builders/60/builds/4632 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108696/new/ https://reviews.llvm.org/D108696 ___

[PATCH] D108695: [analyzer][NFCI] Allow clients of NoStateChangeFuncVisitor to check entire function calls, rather than each ExplodedNode in it

uabelho added a comment. Hi @Szelethus A couple of tests fail for me on trunk with this patch: Failed Tests (3): Clang-Unit :: StaticAnalyzer/./StaticAnalysisTests/FalsePositiveRefutationBRVisitorTestBase.UnSatAtErrorNodeDueToRefinedConstraintNoReport Clang-Unit :: StaticAnalyzer/./S

[PATCH] D108695: [analyzer][NFCI] Allow clients of NoStateChangeFuncVisitor to check entire function calls, rather than each ExplodedNode in it

uabelho added a comment. In D108695#2999432 , @steakhal wrote: > In D108695#2999378 , @uabelho wrote: > >> Hi @Szelethus >> A couple of tests fail for me on trunk with this patch > > Uh, that's my unittest :D > I

[PATCH] D108695: [analyzer][NFCI] Allow clients of NoStateChangeFuncVisitor to check entire function calls, rather than each ExplodedNode in it

uabelho added a comment. In D108695#2999677 , @Szelethus wrote: > rGfb4d590a622f4031900516360c07ee6ace01c5e6 > should > sort this out! Yes now it works. Thank you! Repository: rG

<    1   2