uabelho added a comment.
Hello,
I noticed that if I compile the compiler with ubsan, then lots of Clangd tests
start failing with this patch:
Failed Tests (165):
Clangd :: ast-no-range.test
Clangd :: ast.test
Clangd :: call-hierarchy.test
Clangd :: check-lines.test
Clangd :: check.test
Clangd :: code-action-request.test
Clangd :: completion-auto-trigger.test
Clangd :: completion-snippets.test
Clangd :: completion.test
Clangd :: config.test
Clangd :: crash-parse.test
Clangd :: dependency-output.test
Clangd :: diagnostic-category.test
Clangd :: diagnostics-no-tidy.test
Clangd :: diagnostics-notes.test
Clangd :: diagnostics-tidy.test
Clangd :: did-change-configuration-params.test
Clangd :: execute-command.test
Clangd :: filestatus.test
Clangd :: fixits-codeaction.test
Clangd :: fixits-command.test
Clangd :: fixits-embed-in-diagnostic.test
Clangd :: folding-range.test
Clangd :: formatting.test
Clangd :: hover.test
Clangd :: implementations.test
Clangd :: inlayHints.test
Clangd :: memory_tree.test
Clangd :: metrics.test
Clangd :: protocol.test
Clangd :: references-container.test
Clangd :: references.test
Clangd :: rename.test
Clangd :: request-reply.test
Clangd :: selection-range.test
Clangd :: semantic-tokens-refresh.test
Clangd :: semantic-tokens.test
Clangd :: signature-help-with-offsets.test
Clangd :: signature-help.test
Clangd :: symbol-info.test
Clangd :: symbols.test
Clangd :: target_info.test
Clangd :: test-uri-posix.test
Clangd :: textdocument-didchange-fail.test
Clangd :: trace.test
Clangd :: tweaks-format.test
Clangd :: type-definition.test
Clangd :: type-hierarchy-ext.test
Clangd :: type-hierarchy.test
Clangd :: unsupported-method.test
Clangd :: utf8.test
Clangd :: version.test
Clangd :: xrefs.test
Clangd Unit Tests :: ./ClangdTests/0/146
[...]
Clangd Unit Tests :: ./ClangdTests/99/146
Testing Time: 362.21s
Skipped : 47
Unsupported : 1094
Passed : 89208
Expectedly Failed: 192
Failed : 165
Not sure if all fail the same way but there are a lot of ubsan complaints like
this
07:38:09 ../lib/Support/MemoryBuffer.cpp:138:33: runtime error: null pointer
passed as argument 2, which is declared to never be null
07:38:09 /usr/include/string.h:43:28: note: nonnull attribute specified here
07:38:09 SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior
../lib/Support/MemoryBuffer.cpp:138:33 in
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143096/new/
https://reviews.llvm.org/D143096
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
