[PATCH] D48734: [Sema] Consider all format_arg attributes.

Meinersbur added inline comments. Comment at: lib/Sema/SemaChecking.cpp:5534 + if (!IsFirst) +return CommonResult; + Not sure what should be returned here; To minimize surprises, this returns what the current version would have returned. Repositor

[PATCH] D48734: [Sema] Consider all format_arg attributes.

Meinersbur updated this revision to Diff 153642. Meinersbur added a comment. - Address Aaron's remarks Repository: rC Clang https://reviews.llvm.org/D48734 Files: lib/Sema/SemaChecking.cpp test/Sema/attr-format_arg.c Index: test/Sema/attr-format_arg.c ==

[PATCH] D48734: [Sema] Consider all format_arg attributes.

Meinersbur updated this revision to Diff 153643. Meinersbur added a comment. - Reinsert test for the change in this patch Repository: rC Clang https://reviews.llvm.org/D48734 Files: lib/Sema/SemaChecking.cpp test/Sema/attr-format_arg.c Index: test/Sema/attr-format_arg.c ===

[PATCH] D48808: [CodeGen] Emit parallel_loop_access for each loop in the loop stack.

Meinersbur created this revision. Meinersbur added reviewers: ABataev, hfinkel. Emit !llvm.mem.parallel_loop_access metadata for memory accesses even if the parallel loop is not the top on the loop stack. Fixes llvm.org/PR37558. Repository: rC Clang https://reviews.llvm.org/D48808 Files:

[PATCH] D48808: [CodeGen] Emit parallel_loop_access for each loop in the loop stack.

Meinersbur added a comment. In https://reviews.llvm.org/D48808#1149534, @ABataev wrote: > I don't think that this is the intended behavior of the `#pragma clang loop`. > it is better to ask the author of this pragma is this correct or not. I understand it as the intended behavior of the `assum

[PATCH] D48808: [CodeGen] Emit parallel_loop_access for each loop in the loop stack.

Meinersbur added a comment. In https://reviews.llvm.org/D48808#1149549, @hfinkel wrote: > In https://reviews.llvm.org/D48808#1149534, @ABataev wrote: > > > > > > Michael, can you please add a test with two inner loops, one where more than > one is annotated, and one where only the outer loop is

[PATCH] D48808: [CodeGen] Emit parallel_loop_access for each loop in the loop stack.

Meinersbur added a comment. In https://reviews.llvm.org/D48808#1149845, @hfinkel wrote: > We specifically defined the metadata to support nested loops. The LangRef > says, "The llvm.mem.parallel_loop_access metadata refers to a loop > identifier, or metadata containing a list of loop identifier

[PATCH] D48808: [CodeGen] Emit parallel_loop_access for each loop in the loop stack.

Meinersbur updated this revision to Diff 153769. Meinersbur added a comment. - Allow multiple parallel annotations Repository: rC Clang https://reviews.llvm.org/D48808 Files: lib/CodeGen/CGLoopInfo.cpp test/CodeGenCXX/pragma-loop-safety-nested.cpp test/CodeGenCXX/pragma-loop-safety-out

[PATCH] D48808: [CodeGen] Emit parallel_loop_access for each loop in the loop stack.

Meinersbur updated this revision to Diff 153803. Meinersbur added a comment. - Adapt test file message. Repository: rC Clang https://reviews.llvm.org/D48808 Files: lib/CodeGen/CGLoopInfo.cpp test/CodeGenCXX/pragma-loop-safety-nested.cpp test/CodeGenCXX/pragma-loop-safety-outer.cpp In

[PATCH] D48734: [Sema] Consider all format_arg attributes.

This revision was automatically updated to reflect the committed changes. Closed by commit rC336239: [Sema] Consider all format_arg attributes. (authored by Meinersbur, committed by ). Changed prior to commit: https://reviews.llvm.org/D48734?vs=153643&id=154038#toc Repository: rC Clang http

[PATCH] D48808: [CodeGen] Emit parallel_loop_access for each loop in the loop stack.

Meinersbur updated this revision to Diff 155288. Meinersbur added a comment. - Hoist I->mayReadOrWriteMemory() condition. Repository: rC Clang https://reviews.llvm.org/D48808 Files: lib/CodeGen/CGLoopInfo.cpp test/CodeGenCXX/pragma-loop-safety-nested.cpp test/CodeGenCXX/pragma-loop-saf

[PATCH] D48808: [CodeGen] Emit parallel_loop_access for each loop in the loop stack.

Meinersbur added a comment. ping Repository: rC Clang https://reviews.llvm.org/D48808 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D68551: [clang-format] [NFC] Ensure clang-format is itself clang-formatted.

Meinersbur added a comment. In D68551#1697842 , @mitchell-stellar wrote: > I agree that a system in place that either enforces clang-formatting on > commit or after the fact would be ideal. Otherwise, I don't see a need to > have to approve these NFC co

[PATCH] D68551: [clang-format] [NFC] Ensure clang-format is itself clang-formatted.

Meinersbur added a comment. We should seek having only one formatting policy for the entire project, it's too confusing otherwise (e.g. LLVMSupport/ADT is also used by clang-format, are they force-formatted as well? What about the tools/utils subdirectories?). If you would like to gradually mov

[PATCH] D69088: [Lex] #pragma clang transform

Meinersbur created this revision. Meinersbur added reviewers: hfinkel, kbarton, SjoerdMeijer, aaron.ballman, ABataev, fhahn, hsaito, hans, greened, dmgreen, reames, Ayal, asavonic, rtrieu, dorit, rsmith, tyler.nowicki. Herald added a reviewer: bollu. Herald added a reviewer: jdoerfert. Herald add

[PATCH] D69089: [Parser] #pragma clang transform

Meinersbur created this revision. Meinersbur added reviewers: hfinkel, kbarton, SjoerdMeijer, aaron.ballman, ABataev, fhahn, hsaito, hans, greened, dmgreen, reames, Ayal, asavonic, rtrieu, dorit, rsmith, tyler.nowicki. Herald added a subscriber: mgorny. Herald added a reviewer: jdoerfert. Parse

[PATCH] D69088: [Lex] #pragma clang transform

Meinersbur added a comment. In D69088#1713147 , @ABataev wrote: > Why not try to improve the existing #pragma clang loop rather than add a new > pragma with almost the same behavior? The behavior and syntax is different. #pragma clang loop ignores the o

[PATCH] D69088: [Lex] #pragma clang transform

Meinersbur added a comment. In D69088#1713623 , @hsaito wrote: > @Meinersbur, if I remember correctly, there was an RFC discussion on this > topic, right? If yes, would you post the pointer to that? I need a refresher > on what has been discussed/settled

[PATCH] D69088: [Lex] #pragma clang transform

Meinersbur added a comment. In D69088#1713831 , @tyler.nowicki wrote: > In D69088#1713648 , @Meinersbur > wrote: > > > In D69088#1713623 , @hsaito wrote: > > > > > @Meiners

[PATCH] D69088: [Lex] #pragma clang transform

Meinersbur added a comment. In D69088#1713831 , @tyler.nowicki wrote: > That approach would avoid the inevitable conflicts of having both loop and > transform pragmas on the same loop. I fear it will give us far worse ambiguities. Consider: #pragma

[PATCH] D69088: [Lex] #pragma clang transform

Meinersbur added a comment. In D69088#1713915 , @ABataev wrote: > Just do not allow this form with respect_order clause. What exactly would be the rules what is allowed and what isn't? We can just not allow not mixing `#pragma clang loop` and `#pragma c

[PATCH] D69088: [Lex] #pragma clang transform

Meinersbur added a comment. In D69088#1713933 , @hsaito wrote: > Have we established general consensus for the desire to have the flexible > enough loop optimization pass ordering to accomplish the outcome of the new > directive, and shared vision for th

[PATCH] D69088: [Lex] #pragma clang transform

Meinersbur added a comment. In D69088#1714020 , @hsaito wrote: > Personally, I like the intent. I don't foresee a clear (enough) path to get > there. This leads to hesitation of adding a new non-experimental pragma and > present it to programmers. If you

[PATCH] D69088: [Lex] #pragma clang transform

Meinersbur added a comment. In D69088#1713623 , @hsaito wrote: > @Meinersbur, if I remember correctly, there was an RFC discussion on this > topic, right? If yes, would you post the pointer to that? I need a refresher > on what has been discussed/settled

[PATCH] D69088: [Lex] #pragma clang transform

Meinersbur added a comment. In D69088#1715038 , @hsaito wrote: > If there is a precedence, just follow that. Else, how to spell an > experimental clang pragma would be a good discussion topic by itself. If I > need to provide a discussion starter, I'd sa

[PATCH] D76342: [OpenMP] Implement '#pragma omp tile'

Meinersbur added a comment. Herald added a subscriber: sstefan1. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76342/new/ https://reviews.llvm.org/D76342 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D83261: [OPENMP]Redesign of OMPExecutableDirective representation.

Meinersbur added a comment. AFAICS this extract out the handling of subnodes of OMPExecutableDirectives into the OMPChildren class which is made optional since `OMPChildren *OMPExecutableDirectives::Data` can be nullptr. However, since it also stores clauses, it seems that about every executabl

[PATCH] D67833: [OpenMP 5.0] Codegen support to pass user-defined mapper functions to runtime

Meinersbur added a comment. Seems that it already has been applied ;-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67833/new/ https://reviews.llvm.org/D67833 ___ cfe-commits mailing list cfe-commits@

[PATCH] D83261: [OPENMP]Redesign of OMPExecutableDirective representation.

Meinersbur added a comment. In D83261#2162561 , @ABataev wrote: > 1. OMPChildren class uses standard TrailingObjects harness instead of manual > calculation. I was going to argue that OMPExecutableDirective could derive from TrailingObjects as well, bu

[PATCH] D83261: [OPENMP]Redesign of OMPExecutableDirective representation.

Meinersbur added a comment. In D83261#2162561 , @ABataev wrote: > 1. OMPChildren class uses standard TrailingObjects harness instead of manual > calculation. Note that that having a separate object defeats the purpose of `TrailingObjects` of having jus

[PATCH] D84038: On Windows build, making the /bigobj flag global , instead of passing it per file.

This revision was automatically updated to reflect the committed changes. Closed by commit rG80bd6ae13ea2: On Windows build, making the /bigobj flag global , instead of passing it per… (authored by zahiraam, committed by Meinersbur). Herald added projects: clang, LLDB. Herald added subscribers: l

[PATCH] D77058: [Clang] Add llvm.loop.unroll.disable to loops with -fno-unroll-loops.

Meinersbur added a comment. Note that loop-metadata is best-effort only and may be forgotten in the optimization pipeline. Do we also need an equivalent to `-Xclang -disable-O0-optnone`? Personally, I don't like to the `optnone` approach: There have been many post on llvm-dev using `clang -emi

[PATCH] D69088: [Lex] #pragma clang transform

Meinersbur added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69088/new/ https://reviews.llvm.org/D69088 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D76342: [OpenMP] Implement '#pragma omp tile'

Meinersbur added a comment. Herald added a subscriber: yaxunl. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76342/new/ https://reviews.llvm.org/D76342 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D77058: [Clang] Add llvm.loop.unroll.disable to loops with -fno-unroll-loops.

Meinersbur added a comment. LGTM, since it continues current practice. `optnone` will always be the more annoying. In D77058#1964714 , @fhahn wrote: > IIUC we don't need a patch similar like this one for optnone, as it already > gets added to the functi

[PATCH] D76342: [OpenMP] Implement '#pragma omp tile'

Meinersbur added a comment. pong Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76342/new/ https://reviews.llvm.org/D76342 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D69088: [Lex] #pragma clang transform

Meinersbur added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69088/new/ https://reviews.llvm.org/D69088 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D76342: [OpenMP] Implement '#pragma omp tile'

Meinersbur marked an inline comment as done. Meinersbur added inline comments. Comment at: clang/include/clang/AST/StmtOpenMP.h:4781-4784 +/// This represents the '#pragma omp tile' loop transformation directive. +class OMPTileDirective final +: public OMPLoopDirective, +

[PATCH] D76342: [OpenMP] Implement '#pragma omp tile'

Meinersbur added a comment. ping @ABataev Have you checked the alternative scheme? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76342/new/ https://reviews.llvm.org/D76342 ___ cfe-commits mailing list

[PATCH] D69088: [Lex] #pragma clang transform

Meinersbur added a comment. Herald added a subscriber: sstefan1. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69088/new/ https://reviews.llvm.org/D69088 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D76342: [OpenMP] Implement '#pragma omp tile'

Meinersbur added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76342/new/ https://reviews.llvm.org/D76342 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D76342: [OpenMP] Implement '#pragma omp tile'

Meinersbur marked an inline comment as done. Meinersbur added inline comments. Comment at: clang/include/clang/AST/StmtOpenMP.h:4781-4784 +/// This represents the '#pragma omp tile' loop transformation directive. +class OMPTileDirective final +: public OMPLoopDirective, +

[PATCH] D76342: [OpenMP] Implement '#pragma omp tile'

Meinersbur marked an inline comment as done. Meinersbur added inline comments. Comment at: clang/include/clang/AST/StmtOpenMP.h:4781-4784 +/// This represents the '#pragma omp tile' loop transformation directive. +class OMPTileDirective final +: public OMPLoopDirective, +

[PATCH] D78192: Support compiler extensions as a normal component

Meinersbur added a comment. Is this ready to try out? In D78192#1996859 , @serge-sans-paille wrote: > Note that this should solve in an elegant (?) way the multiple link errors > found when linking clang with LLVM_DYLIB. Aren't these fixed already?

[PATCH] D78192: Support compiler extensions as a normal component

Meinersbur added a comment. I looks to work fine under my Windows and Linux configuration. One Point though: llvm-config --libs Extensions returns [...] -lPollyPPCG -lPollyISL -lPolly I think `-lPolly` must be first to work with bfd.ld order semantics. See https://stackoverflow.com/questi

[PATCH] D78192: Support compiler extensions as a normal component

Meinersbur accepted this revision. Meinersbur added a comment. This revision is now accepted and ready to land. LGTM. As with every change to the build system, please look out broken configurations after committing. You will have noticed already that there is a lot of variety in how others buil

[PATCH] D84780: Setting the /bigobj option globally for Windows debug build. https://bugs.llvm.org/show_bug.cgi?id=46733

Meinersbur added a comment. Hasn't this already been done in 80bd6ae13ea23d453a1f45d6ccdbfc7d0c877bb0 ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84780/new/ https://reviews.l

[PATCH] D83261: [OPENMP]Redesign of OMPExecutableDirective representation.

Meinersbur added a comment. I think the ActOnOpenMPDeclareMapperDirective changes should be separated into its own patch. Otherwise, LGTM. Comment at: clang/lib/Sema/SemaTemplateInstantiateDecl.cpp:3329 } - OMPDeclareMapperDecl *NewDMD = SemaRef.ActOnOpenMPDeclareMapperDi

[PATCH] D69088: [Lex] #pragma clang transform

Meinersbur added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69088/new/ https://reviews.llvm.org/D69088 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D76342: [OpenMP] Implement '#pragma omp tile'

Meinersbur added a comment. Herald added a reviewer: DavidTruby. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76342/new/ https://reviews.llvm.org/D76342 ___

[PATCH] D69088: [Lex] #pragma clang transform

Meinersbur added a comment. In D69088#2023114 , @kbarton wrote: > @Meinersbur I missed the RFC and discussion on the cfe-dev mailing list. > Could you post a link here so that it's included in the history? See the collection of links in a previous comme

[PATCH] D129149: [OMPIRBuilder] Add support for simdlen clause

Meinersbur added a comment. Why not have `simdlen` an argument to `applySimd` (which can be null if not used)? In this case it happens to be just adding some metadata, but for others such as `unrollLoopPartial` it does not make sense to have the unroll factor set by a different method. It would

[PATCH] D129149: [OMPIRBuilder] Add support for simdlen clause

Meinersbur accepted this revision. Meinersbur added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129149/new/ https://reviews.llvm.org/D129149 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D33774: [CodeGen] Make __attribute__(const) calls speculatable

Meinersbur requested changes to this revision. Meinersbur added a comment. This revision now requires changes to proceed. Herald added a project: All. `speculable` implies no undefined behavior (so it can even be speculatively executed with arguments when the source code would not, but its result

[PATCH] D117835: [OpenMPIRBuilder] Detect and fix ambiguous InsertPoints for createSections.

Meinersbur added a comment. Herald added a project: All. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117835/new/ https://reviews.llvm.org/D117835 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D118409: [OpenMPIRBuilder] Remove ContinuationBB argument from Body callback.

Meinersbur added a comment. Herald added a project: All. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118409/new/ https://reviews.llvm.org/D118409 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D117835: [OpenMPIRBuilder] Detect and fix ambiguous InsertPoints for createSections.

Meinersbur marked an inline comment as done. Meinersbur added inline comments. Comment at: mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp:74-75 + // for the allocs. + // TODO: Create a dedicated alloca BasicBlock at function creation such that + // we do

[PATCH] D117835: [OpenMPIRBuilder] Detect and fix ambiguous InsertPoints for createSections.

Meinersbur updated this revision to Diff 420371. Meinersbur marked an inline comment as done. Meinersbur added a comment. - Rebase - Fix convertOmpAtomicUpdate, convertOmpAtomicCapture, and convertOmpOrdered Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D117835: [OpenMPIRBuilder] Detect and fix ambiguous InsertPoints for createSections.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc082ca16f123: [OpenMPIRBuilder] Detect and fix ambiguous InsertPoints for createSections. (authored by Meinersbur). Repository: rG LLVM Github Mon

[PATCH] D129131: Remove uses of llvm_shutdown

Meinersbur added inline comments. Comment at: polly/lib/External/isl/interface/extract_interface.cc:590 delete Clang; - llvm::llvm_shutdown(); This file is imported from the upstream project (https://repo.or.cz/isl.git/blob/295cf91923295ca694e9e4

[PATCH] D131526: [OMPIRBuilder] Add support for safelen clause

Meinersbur added inline comments. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:3029-3032 +addLoopMetadata( +CanonicalLoop, +MDNode::get(Ctx, {MDString::get(Ctx, "llvm.loop.parallel_accesses"), + AccessGroup})); ---

[PATCH] D104601: [Preprocessor] Implement -fnormalize-whitespace.

Meinersbur marked an inline comment as done. Meinersbur added a comment. In D104601#2877855 , @aaron.ballman wrote: > In D104601#2848366 , @Meinersbur > wrote: > >> In D104601#2847400

[PATCH] D104601: [Preprocessor] Implement -fnormalize-whitespace.

Meinersbur updated this revision to Diff 359666. Meinersbur marked an inline comment as done. Meinersbur added a comment. - Rename -fnormalize-whitespace to -felide-unnecessary-whitespace - error when used without -E - Reabse Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D104601: [Preprocessor] Implement -fnormalize-whitespace.

Meinersbur updated this revision to Diff 360278. Meinersbur added a comment. - Rename -felide-unnecessary-whitespace to -fminimize-whitespace - Add -fminimize-whitespace only vlid to be used to docs - Adjust some code comments - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D104601: [Preprocessor] Implement -fnormalize-whitespace.

Meinersbur added a comment. In D104601#2831746 , @dblaikie wrote: > but for my money this seems pretty problematic - will make quoted text in > compiler diagnostics weird/difficult to read, etc. FWIW, clang has a line length limit of 4096

[PATCH] D104601: [Preprocessor] Implement -fminimize-whitespace.

Meinersbur updated this revision to Diff 360745. Meinersbur marked 2 inline comments as done. Meinersbur added a comment. - Error if -fminimize-whitespace is applied to asm files - Join lines with escaped newlines - Added some FIXMEs for grandfathered bugs Repository: rG LLVM Github Monorepo

[PATCH] D104601: [Preprocessor] Implement -fminimize-whitespace.

Meinersbur added a comment. I compiled the Linux kernel (default config, excludes most drivers. Takes ~18mins to compile) and indeed found two problems: 1. Linux contains `assembler-with-cpp` files. When compiling with clang, it processes it with `-E` before passing the result to `as`. There ar

[PATCH] D104601: [Preprocessor] Implement -fminimize-whitespace.

Meinersbur updated this revision to Diff 360753. Meinersbur added a comment. - Revert test changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104601/new/ https://reviews.llvm.org/D104601 Files: clang/docs/ClangCommandLineReference.rst clang

[PATCH] D104601: [Preprocessor] Implement -fminimize-whitespace.

Meinersbur added a comment. In D104601#2896091 , @aaron.ballman wrote: > I think there is, but I'm an eternal optimist. :-) This LGTM, but you should > wait a day or two before landing it in case @dblaikie or @rsmith have > concerns. Of course. ===

[PATCH] D104601: [Preprocessor] Implement -fminimize-whitespace.

Meinersbur updated this revision to Diff 360977. Meinersbur added a comment. - Introduce types::isDerivedFromC - Print input type in error message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104601/new/ https://reviews.llvm.org/D104601 Files:

[PATCH] D104601: [Preprocessor] Implement -fminimize-whitespace.

Meinersbur added a comment. Because of how large the switch construct would have been, I created a new function `types::isDerivedFromC` together with the other functions. These commonly have default-cases so compilers would not warn when `Types.def` is amended, but `isDerivedFromC` can be found

[PATCH] D104601: [Preprocessor] Implement -fminimize-whitespace.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGae6b4238: [Preprocessor] Implement -fminimize-whitespace. (authored by Meinersbur). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D104601: [Preprocessor] Implement -fminimize-whitespace.

Meinersbur added a comment. Looking into it... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104601/new/ https://reviews.llvm.org/D104601 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[PATCH] D106924: [Preprocessor] -E -P: Ensure newline after 8 skipped lines.

Meinersbur created this revision. Meinersbur added reviewers: aaron.ballman, mstorsjo, dblaikie. Meinersbur added a project: clang. Meinersbur requested review of this revision. The implementation of -fminimize-whitespace (D104601 ) revised the logic when to emit

[PATCH] D104601: [Preprocessor] Implement -fminimize-whitespace.

Meinersbur added a comment. Proposed fix here: D106924 The reproducer had another whitespace difference before and after D104601 : " typedef __builtin_va_list __gnuc_va_list;" instead of " typedef __builtin_va_list __gnuc_va_

[PATCH] D106924: [Preprocessor] -E -P: Ensure newline after 8 skipped lines.

Meinersbur updated this revision to Diff 362611. Meinersbur added a comment. - Fix embrassing mistakes in skip-empty-lines test (misspelled "LINEMARKES", MINWS<->MINCOL, absolute path) - Skip-empty-lines now also checks leading whitespace behavior - Fix typos in comments Repository: rG LLVM G

[PATCH] D106924: [Preprocessor] -E -P: Ensure newline after 8 skipped lines.

Meinersbur updated this revision to Diff 362612. Meinersbur added a comment. - Use correct base commit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106924/new/ https://reviews.llvm.org/D106924 Files: clang/lib/Frontend/PrintPreprocessedOutput.c

[PATCH] D106924: [Preprocessor] -E -P: Ensure newline after 8 skipped lines.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc6b0b16c0f55: [Preprocessor] -E -P: Ensure newline after 8 skipped lines. (authored by Meinersbur). Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D106924: [Preprocessor] -E -P: Ensure newline after 8 skipped lines.

Meinersbur added a comment. In D106924#2911145 , @mstorsjo wrote: > @Meinersbur After landing this, can you coordinate with @tstellar to get an > ack for backporting this to the 13.x release branch, which also suffers from > the regression? Release blo

[PATCH] D123403: [OpenMP] Refactor OMPScheduleType enum.

Meinersbur created this revision. Meinersbur added reviewers: peixin, tianshilei1992, jdoerfert, sriharikrishna, Leporacanthicus, kiranchandramohan, clementval. Meinersbur added a project: OpenMP. Herald added subscribers: awarzynski, sdasgup3, wenzhicui, wrengr, Chia-hungDuan, ormris, dcaballe,

[PATCH] D123403: [OpenMP] Refactor OMPScheduleType enum.

Meinersbur marked 7 inline comments as done. Meinersbur added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPConstants.h:135 + UnorderedGuidedSimd = BaseGuidedSimd | ModifierUnordered, // (46) + UnorderedRuntimeSimd = BaseRuntimeSimd | ModifierUnordered, //

[PATCH] D123403: [OpenMP] Refactor OMPScheduleType enum.

Meinersbur updated this revision to Diff 422862. Meinersbur added a comment. - address review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123403/new/ https://reviews.llvm.org/D123403 Files: clang/lib/CodeGen/CGStmtOpenMP.cpp clang/test/OpenM

[PATCH] D123403: [OpenMP] Refactor OMPScheduleType enum.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9ec501da76fc: [OpenMP] Refactor OMPScheduleType enum. (authored by Meinersbur). Changed prior to commit: https://reviews.llvm.org/D123403?vs=42286

[PATCH] D118409: [OpenMPIRBuilder] Remove ContinuationBB argument from Body callback.

Meinersbur added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118409/new/ https://reviews.llvm.org/D118409 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D118944: [OpenMP] Add Cuda path to linker wrapper tool

Meinersbur added a comment. Thanks for the fix Comment at: clang/lib/Driver/ToolChains/Clang.cpp:8151-8152 const char *LinkingOutput) const { + const auto &D = getToolChain().getDriver(); + const auto TheTriple = getToolChain().getTriple(); +

[PATCH] D118409: [OpenMPIRBuilder] Remove ContinuationBB argument from Body callback.

Meinersbur added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:5571-5579 + { +OMPBuilderCBHelpers::InlinedRegionBodyRAII IRB(*this, AllocaIP, + *FiniBB); +EmitStmt(CS->get

[PATCH] D118409: [OpenMPIRBuilder] Remove ContinuationBB argument from Body callback.

Meinersbur added a comment. In D118409#3474131 , @kiranchandramohan wrote: > I think the CI is complaining about some clang-format issue in > clang/test/OpenMP/critical_codegen_attr.cpp clang-format should not be applied on Clang tests, many of them h

[PATCH] D124563: Renormalize line endings after ac5f7be6a8688955a282becf00eebc542238a86b

Meinersbur added a comment. Regarding `crlf.cpp`(`.expected`), adding the modified changes to a commit indeed solved the problem I described in https://reviews.llvm.org/rGac5f7be6a8688955a282becf00eebc542238a86b#1080897 and I was working with that so far. Still don't know why Linux git doesn't

[PATCH] D124563: Renormalize line endings after ac5f7be6a8688955a282becf00eebc542238a86b

Meinersbur added a comment. In D124563#3478625 , @smeenai wrote: > I *think* this would mean that if you're on Windows and have `core.autocrlf` > set to `input`, when you commit changes to this files, Git will convert them > back to LF line endings. Not

[PATCH] D124563: Renormalize line endings after ac5f7be6a8688955a282becf00eebc542238a86b

Meinersbur added a comment. In D124563#3478627 , @smeenai wrote: > If I check out this commit and then check out the previous commit, > `clang-tools-extra/test/clang-apply-replacements/Inputs/crlf/crlf.cpp` and > `clang-tools-extra/test/clang-apply-repl

[PATCH] D124606: Use `-text` git attribute instead of `text eol=...'

Meinersbur added a comment. In D124606#3479793 , @ilya-biryukov wrote: > LGTM This and the commit (@MForster ) was too hasty. There should have been time for people discussing D124563 and D97625

[PATCH] D129992: [clang][OpenMP] Add IRBuilder support for taskgroup

Meinersbur added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:5209 + OMPLexicalScope Scope(*this, S, OMPD_unknown); + if (CGM.getLangOpts().OpenMPIRBuilder && S.clauses().size() == 0) { +llvm::OpenMPIRBuilder &OMPBuilder = CGM.getOpenMPRuntime().getOMPBui

[PATCH] D129992: [clang][OpenMP] Add IRBuilder support for taskgroup

Meinersbur accepted this revision. Meinersbur added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:5207-5209 + if (T.clauses().size() > 0) +return false; + return true; simplification Repo

[PATCH] D66796: [clang] Loop pragma vectorize(disable)

Meinersbur added a comment. Therefore, `vectorize(disable)` would also disable interleaving? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66796/new/ https://reviews.llvm.org/D66796 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

Meinersbur added a comment. Sorry for the break. Unfortunately the patch does not apply cleanly anymore. Can you rebase to latest trunk? I surprisingly did not know about `__declspec(selectany)`. I still think having the symbol only defined in that loadable module, but not in the statically li

[PATCH] D76342: [OpenMP] Implement '#pragma omp tile'

Meinersbur added a comment. Thank you Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76342/new/ https://reviews.llvm.org/D76342 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D90159: [DDG] Data Dependence Graph - DOT printer

Meinersbur accepted this revision. Meinersbur added a comment. This revision is now accepted and ready to land. Thanks, LGTM. Comment at: llvm/include/llvm/Analysis/DDG.h:489 + }, + [&] { OS << ", "; }); + return OS.str(); `llvm::interleaveComma` doe

[PATCH] D90159: [DDG] Data Dependence Graph - DOT printer

Meinersbur accepted this revision. Meinersbur added a comment. Thanks. Still LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90159/new/ https://reviews.llvm.org/D90159 ___ cfe-commits mailing list cf

[PATCH] D90159: [DDG] Data Dependence Graph - DOT printer

Meinersbur added a comment. Can I help fixing the Windows build problem? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90159/new/ https://reviews.llvm.org/D90159 ___ cfe-commits mailing list cfe-commits@

[PATCH] D91054: [Clang][OpenMP] Frontend work for sections - D89671

Meinersbur added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:3552-3554 +using BodyGenCallbackTy = +llvm::function_ref; Instead of duplicating it here, why not using `OpenMPIRBuilder::BodyGenCallbackTy`? Comment

<    1   2   3   4   5   >