[libcxx] r279008 - make the associative containers do the right thing for propogate_on_container_assignment. Fixes bug #29001. Tests are only for right now - more complete tests will come when w

2016-08-17 Thread Marshall Clow via cfe-commits
Author: marshall Date: Wed Aug 17 18:24:02 2016 New Revision: 279008 URL: http://llvm.org/viewvc/llvm-project?rev=279008&view=rev Log: make the associative containers do the right thing for propogate_on_container_assignment. Fixes bug #29001. Tests are only for right now - more complete tests w

Re: [libcxx] r278904 - Support allocators with explicit conversion constructors. Fixes bug #29000

2016-08-17 Thread Marshall Clow via cfe-commits
On Wed, Aug 17, 2016 at 3:14 PM, Hans Wennborg wrote: > I'd rather not take this actually, as it looks like a large change, > isn't fixing a regression, and it's time to start wrapping up the > release. > > This is actually a pretty small change - almost all the changes are in the tests. I'd lik

Please take r279008 for the release

2016-08-17 Thread Marshall Clow via cfe-commits
Unlike the #278904, this does fix a bug - and a non-trivial one at that. -- Marshall ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21968: [libcxx] Externally threaded libc++ variant - Take 2

2016-08-22 Thread Marshall Clow via cfe-commits
mclow.lists added inline comments. Comment at: include/__external_threading:26 @@ +25,3 @@ + +#if !defined(_LIBCPP_MUTEX_T) || \ +!defined(_LIBCPP_MUTEX_INITIALIZER) || \ bcraig wrote: > So users of external pthreading (or their compiler driver) would need to

[libcxx] r279453 - Add missing include that caused a test failure on Windows. Thanks to STL for the patch. No functional change.

2016-08-22 Thread Marshall Clow via cfe-commits
Author: marshall Date: Mon Aug 22 13:45:31 2016 New Revision: 279453 URL: http://llvm.org/viewvc/llvm-project?rev=279453&view=rev Log: Add missing include that caused a test failure on Windows. Thanks to STL for the patch. No functional change. Modified: libcxx/trunk/test/std/containers/ass

Re: [PATCH] D23685: [libcxx] [test] Include the iterator header for back_inserter.

2016-08-22 Thread Marshall Clow via cfe-commits
mclow.lists accepted this revision. mclow.lists added a comment. This revision is now accepted and ready to land. Committed as revision 279453 https://reviews.llvm.org/D23685 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.

Re: [PATCH] D22834: Added 'inline' attribute to basic_string's destructor

2016-08-22 Thread Marshall Clow via cfe-commits
mclow.lists added a comment. Eric - did you want to see a benchmark as part of this commit? https://reviews.llvm.org/D22834 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22584: constexpr array support C++1z (P0031)

2016-08-24 Thread Marshall Clow via cfe-commits
mclow.lists added a comment. This diff no longer applies cleanly, and I've added some formatting concerns. However, the //content// looks fine to me. Comment at: include/array:176 @@ -175,3 +175,3 @@ _LIBCPP_INLINE_VISIBILITY -const_iterator cend() const _NOEXCEPT {re

[PATCH] D23855: Make exception-throwing from a noexcept build `abort()`.

2016-08-24 Thread Marshall Clow via cfe-commits
mclow.lists created this revision. mclow.lists added reviewers: EricWF, hiraditya, kparzysz. mclow.lists added a subscriber: cfe-commits. This is a follow on to D21232, which marked a bunch of exception-throwing helper routines as `noreturn`. Now, make them really never return. Either they thro

Re: [PATCH] D23855: Make exception-throwing from a noexcept build `abort()`.

2016-08-24 Thread Marshall Clow via cfe-commits
mclow.lists updated this revision to Diff 69201. mclow.lists added a comment. I like this revision better; I need to check, but I think this hits all the exception classes. Goal: Every exception class in the standard should have a `VSTD::__throw_XXX` function, marked `_LIBCPP_NORETURN inline _L

Re: [PATCH] D23855: Make exception-throwing from a noexcept build `abort()`.

2016-08-24 Thread Marshall Clow via cfe-commits
mclow.lists added inline comments. Comment at: include/stdexcept:174 @@ -173,1 +173,3 @@ +// in the dylib +_LIBCPP_BEGIN_NAMESPACE_STD This comment belongs to `__throw_runtime_error` https://reviews.llvm.org/D23855 __

Re: [PATCH] D23855: Make exception-throwing from a noexcept build `abort()`.

2016-08-24 Thread Marshall Clow via cfe-commits
mclow.lists added inline comments. Comment at: src/thread.cpp:59 @@ -58,1 +58,3 @@ throw system_error(error_code(ec, system_category()), "thread::join failed"); +#else +if (ec) Need to fix these, too. https://reviews.llvm.org/D23855

[libcxx] r279744 - Add an _LIBCPP_NORETURN inline function named __throw_XXX for each exception type we define. They either construct and throw the exception, or abort() (if exceptions are disabled).

2016-08-25 Thread Marshall Clow via cfe-commits
Author: marshall Date: Thu Aug 25 10:09:01 2016 New Revision: 279744 URL: http://llvm.org/viewvc/llvm-project?rev=279744&view=rev Log: Add an _LIBCPP_NORETURN inline function named __throw_XXX for each exception type we define. They either construct and throw the exception, or abort() (if except

Re: [PATCH] D23855: Make exception-throwing from a noexcept build `abort()`.

2016-08-25 Thread Marshall Clow via cfe-commits
mclow.lists closed this revision. mclow.lists added a comment. Committed as revision 279744 https://reviews.llvm.org/D23855 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r279746 - Remove duplicate inline

2016-08-25 Thread Marshall Clow via cfe-commits
Author: marshall Date: Thu Aug 25 10:56:55 2016 New Revision: 279746 URL: http://llvm.org/viewvc/llvm-project?rev=279746&view=rev Log: Remove duplicate inline Modified: libcxx/trunk/include/experimental/any Modified: libcxx/trunk/include/experimental/any URL: http://llvm.org/viewvc/llvm-pro

[libcxx] r279763 - Followon to r279744. Find the other exception types and make __throw_XXX routines (and call them). Remove the generic __libcpp_throw routine, since no one uses it anymore.

2016-08-25 Thread Marshall Clow via cfe-commits
Author: marshall Date: Thu Aug 25 12:47:09 2016 New Revision: 279763 URL: http://llvm.org/viewvc/llvm-project?rev=279763&view=rev Log: Followon to r279744. Find the other exception types and make __throw_XXX routines (and call them). Remove the generic __libcpp_throw routine, since no one uses

Re: [PATCH] D22584: constexpr array support C++1z (P0031)

2016-08-31 Thread Marshall Clow via cfe-commits
mclow.lists added a comment. Other than the iterator.primitives/iterator.operations/prev.pass.cpp test, I think this is good to go. Comment at: test/std/iterators/iterator.primitives/iterator.operations/prev.pass.cpp:47 @@ +46,3 @@ + +{ +constexpr const char* s = "

Re: [PATCH] D23926: [libcxx] Don't use C99 math ops in -std=c++03 mode

2016-09-03 Thread Marshall Clow via cfe-commits
mclow.lists added a comment. > We have quite a strict C library which is picky about what it exposes under > different standards. For example, it won't expose C99 math ops if it is being > used under `__cplusplus < 201103L` ... That sounds .. odd to me, having the behavior of the C library dep

[libcxx] r280605 - Mark test as XFAIL for C++03, rather than providing a dummy pass.

2016-09-03 Thread Marshall Clow via cfe-commits
Author: marshall Date: Sat Sep 3 19:37:06 2016 New Revision: 280605 URL: http://llvm.org/viewvc/llvm-project?rev=280605&view=rev Log: Mark test as XFAIL for C++03, rather than providing a dummy pass. Modified: libcxx/trunk/test/std/iterators/iterator.range/begin-end.pass.cpp Modified: libcx

[libcxx] r280643 - Fix Bug 30240 - std::string: append(first, last) error when aliasing. Add test cases for append/insert/assign/replace while we're at it, and fix a similar bug in insert.

2016-09-04 Thread Marshall Clow via cfe-commits
Author: marshall Date: Sun Sep 4 20:54:30 2016 New Revision: 280643 URL: http://llvm.org/viewvc/llvm-project?rev=280643&view=rev Log: Fix Bug 30240 - std::string: append(first, last) error when aliasing. Add test cases for append/insert/assign/replace while we're at it, and fix a similar bug i

[libcxx] r280779 - Fix PR#30303 - no matching function for call to '__ptr_in_range'

2016-09-06 Thread Marshall Clow via cfe-commits
Author: marshall Date: Tue Sep 6 22:32:06 2016 New Revision: 280779 URL: http://llvm.org/viewvc/llvm-project?rev=280779&view=rev Log: Fix PR#30303 - no matching function for call to '__ptr_in_range' Modified: libcxx/trunk/include/string libcxx/trunk/test/std/strings/basic.string/string.

Re: [PATCH] D21968: [libcxx] Externally threaded libc++ variant - Take 2

2016-09-06 Thread Marshall Clow via cfe-commits
mclow.lists added a comment. The patch (again) doesn't apply cleanly (test/CMakeLists.txt), so I applied it manually. After that, it builds w/o errors, and passes all the tests. After addressing @EricWF's concerns, I think this is ready to land. https://reviews.llvm.org/D21968 _

Re: [PATCH] D24372: [libcxx] Sprinkle constexpr over compressed_pair

2016-09-09 Thread Marshall Clow via cfe-commits
mclow.lists added a comment. This all looks good to me - but with a couple nits. Comment at: include/memory:2137 @@ -2132,3 +2136,3 @@ -_LIBCPP_INLINE_VISIBILITY +_LIBCPP_INLINE_VISIBILITY _LIBCPP_CONSTEXPR __libcpp_compressed_pair_imp& operator=(__libcpp_compress

Re: [PATCH] D24446: Implement revision to LWG#2758

2016-09-11 Thread Marshall Clow via cfe-commits
mclow.lists added inline comments. Comment at: include/string:615 @@ +614,3 @@ + +// template +// struct __can_be_converted_to_string_view : public _LIBCPP_BOOL_CONSTANT( These bits will be removed. Comment at: test/std/strings/basic.string/str

Re: [PATCH] D24372: [libcxx] Sprinkle constexpr over compressed_pair

2016-09-13 Thread Marshall Clow via cfe-commits
mclow.lists added inline comments. Comment at: include/memory:2137 @@ -2132,3 +2136,3 @@ -_LIBCPP_INLINE_VISIBILITY +_LIBCPP_INLINE_VISIBILITY _LIBCPP_CONSTEXPR __libcpp_compressed_pair_imp& operator=(__libcpp_compressed_pair_imp&& __p) loladiro wro

Re: [PATCH] D24562: [libcxx] Recover no-exceptions XFAILs

2016-09-14 Thread Marshall Clow via cfe-commits
mclow.lists added a comment. What an awful test. I wonder who wrote such a steaming pile. Probably me. https://reviews.llvm.org/D24562 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

Re: [PATCH] D24599: Add 'inline' but not _LIBCPP_INLINE_VISIBILITY to basic_string's destructor

2016-09-15 Thread Marshall Clow via cfe-commits
mclow.lists added a comment. Any reason we shouldn't just revert r280944, wait for the LLVM bug to be fixed, and then re-apply it? https://reviews.llvm.org/D24599 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin

[libcxx] r297752 - Implement LWG2784, and mark 2786, 2795, 2804, 2812, 2826, 2834, 2837 and 2838 as complete - since we do them already

2017-03-14 Thread Marshall Clow via cfe-commits
Author: marshall Date: Tue Mar 14 12:08:47 2017 New Revision: 297752 URL: http://llvm.org/viewvc/llvm-project?rev=297752&view=rev Log: Implement LWG2784, and mark 2786, 2795, 2804, 2812, 2826, 2834, 2837 and 2838 as complete - since we do them already Modified: libcxx/trunk/include/exception

[libcxx] r297753 - Also mark LWG#2785 as complete, because we already implemented that

2017-03-14 Thread Marshall Clow via cfe-commits
Author: marshall Date: Tue Mar 14 12:24:29 2017 New Revision: 297753 URL: http://llvm.org/viewvc/llvm-project?rev=297753&view=rev Log: Also mark LWG#2785 as complete, because we already implemented that Modified: libcxx/trunk/www/cxx1z_status.html Modified: libcxx/trunk/www/cxx1z_status.html

[libcxx] r297758 - Mark LWG issues 2868, 2872, and 2890 as complete. There's nothing we need to do for them.

2017-03-14 Thread Marshall Clow via cfe-commits
Author: marshall Date: Tue Mar 14 12:35:56 2017 New Revision: 297758 URL: http://llvm.org/viewvc/llvm-project?rev=297758&view=rev Log: Mark LWG issues 2868, 2872, and 2890 as complete. There's nothing we need to do for them. Modified: libcxx/trunk/www/cxx1z_status.html Modified: libcxx/trun

[libcxx] r297872 - Implement LWG#2761: 'basic_string should require that charT match traits::char_type'. Tests for string_view, too

2017-03-15 Thread Marshall Clow via cfe-commits
Author: marshall Date: Wed Mar 15 13:41:11 2017 New Revision: 297872 URL: http://llvm.org/viewvc/llvm-project?rev=297872&view=rev Log: Implement LWG#2761: 'basic_string should require that charT match traits::char_type'. Tests for string_view, too Added: libcxx/trunk/test/std/strings/basic.s

[libcxx] r298284 - Add two more papers from Kona, and sort them

2017-03-20 Thread Marshall Clow via cfe-commits
Author: marshall Date: Mon Mar 20 13:18:09 2017 New Revision: 298284 URL: http://llvm.org/viewvc/llvm-project?rev=298284&view=rev Log: Add two more papers from Kona, and sort them Modified: libcxx/trunk/www/cxx1z_status.html Modified: libcxx/trunk/www/cxx1z_status.html URL: http://llvm.org/

[libcxx] r298416 - Implement P0548: 'common_type and duration' This involves a subtle change in the return type of the unary +/- operators for std::chrono::duration, though I expect that no one will n

2017-03-21 Thread Marshall Clow via cfe-commits
Author: marshall Date: Tue Mar 21 13:38:57 2017 New Revision: 298416 URL: http://llvm.org/viewvc/llvm-project?rev=298416&view=rev Log: Implement P0548: 'common_type and duration' This involves a subtle change in the return type of the unary +/- operators for std::chrono::duration, though I expec

[libcxx] r298418 - Add a bit more to one of the chrono tests

2017-03-21 Thread Marshall Clow via cfe-commits
Author: marshall Date: Tue Mar 21 13:40:46 2017 New Revision: 298418 URL: http://llvm.org/viewvc/llvm-project?rev=298418&view=rev Log: Add a bit more to one of the chrono tests Modified: libcxx/trunk/test/std/utilities/time/time.duration/time.duration.arithmetic/op_+.pass.cpp Modified: lib

[libcxx] r298422 - Fix a couple of 'C++11'-isms from the last checkin, which broke the '03 bot.

2017-03-21 Thread Marshall Clow via cfe-commits
Author: marshall Date: Tue Mar 21 14:12:21 2017 New Revision: 298422 URL: http://llvm.org/viewvc/llvm-project?rev=298422&view=rev Log: Fix a couple of 'C++11'-isms from the last checkin, which broke the '03 bot. Modified: libcxx/trunk/include/type_traits libcxx/trunk/test/std/utilities/t

[libcxx] r298438 - Fix test failure I introduced

2017-03-21 Thread Marshall Clow via cfe-commits
Author: marshall Date: Tue Mar 21 16:05:28 2017 New Revision: 298438 URL: http://llvm.org/viewvc/llvm-project?rev=298438&view=rev Log: Fix test failure I introduced Modified: libcxx/trunk/include/type_traits Modified: libcxx/trunk/include/type_traits URL: http://llvm.org/viewvc/llvm-project

[libcxx] r298573 - Implement P0599: 'noexcept for hash functions'. Fix a couple of hash functions (optional and unique_ptr) which were mistakenly marked as 'noexcept'. Reviewed as https://review

2017-03-22 Thread Marshall Clow via cfe-commits
Author: marshall Date: Wed Mar 22 21:40:28 2017 New Revision: 298573 URL: http://llvm.org/viewvc/llvm-project?rev=298573&view=rev Log: Implement P0599: 'noexcept for hash functions'. Fix a couple of hash functions (optional and unique_ptr) which were mistakenly marked as 'noexcept'. Reviewed as

[libcxx] r298580 - Can't test for noexcept on C++03; std::hash isn't available until C++17

2017-03-22 Thread Marshall Clow via cfe-commits
Author: marshall Date: Thu Mar 23 01:20:18 2017 New Revision: 298580 URL: http://llvm.org/viewvc/llvm-project?rev=298580&view=rev Log: Can't test for noexcept on C++03; std::hash isn't available until C++17 Modified: libcxx/trunk/include/functional libcxx/trunk/test/std/utilities/functio

[libcxx] r298582 - Silence a couple of 'unused variable' warnings in c++03 tests. No functional change

2017-03-22 Thread Marshall Clow via cfe-commits
Author: marshall Date: Thu Mar 23 01:25:26 2017 New Revision: 298582 URL: http://llvm.org/viewvc/llvm-project?rev=298582&view=rev Log: Silence a couple of 'unused variable' warnings in c++03 tests. No functional change Modified: libcxx/trunk/test/std/utilities/memory/util.smartptr/util.smar

[libcxx] r298597 - Remove random_shuffle in C++17. Please use shuffle instead. If you have to, you cant get it back by defining _LIBCPP_ENABLE_CXX17_REMOVED_RANDOM_SHUFFLE before including any libc++

2017-03-23 Thread Marshall Clow via cfe-commits
Author: marshall Date: Thu Mar 23 08:43:37 2017 New Revision: 298597 URL: http://llvm.org/viewvc/llvm-project?rev=298597&view=rev Log: Remove random_shuffle in C++17. Please use shuffle instead. If you have to, you cant get it back by defining _LIBCPP_ENABLE_CXX17_REMOVED_RANDOM_SHUFFLE before

[libcxx] r298598 - One more file for the random_shuffle removal

2017-03-23 Thread Marshall Clow via cfe-commits
Author: marshall Date: Thu Mar 23 08:44:06 2017 New Revision: 298598 URL: http://llvm.org/viewvc/llvm-project?rev=298598&view=rev Log: One more file for the random_shuffle removal Modified: libcxx/trunk/include/__config Modified: libcxx/trunk/include/__config URL: http://llvm.org/viewvc/llv

[libcxx] r298600 - Use 'REQUIRES: c++98 || c++03 || c++11 || c++14' instead of the deprecated 'REQUIRES-ANY: c++98, c++03, c++11, c++14'

2017-03-23 Thread Marshall Clow via cfe-commits
Author: marshall Date: Thu Mar 23 09:20:43 2017 New Revision: 298600 URL: http://llvm.org/viewvc/llvm-project?rev=298600&view=rev Log: Use 'REQUIRES: c++98 || c++03 || c++11 || c++14' instead of the deprecated 'REQUIRES-ANY: c++98, c++03, c++11, c++14' Modified: libcxx/trunk/test/std/algori

[libcxx] r298618 - Update the algorithm tests to not use the (deprecated) function binders. No functional change.

2017-03-23 Thread Marshall Clow via cfe-commits
Author: marshall Date: Thu Mar 23 11:13:50 2017 New Revision: 298618 URL: http://llvm.org/viewvc/llvm-project?rev=298618&view=rev Log: Update the algorithm tests to not use the (deprecated) function binders. No functional change. Modified: libcxx/trunk/test/std/algorithms/alg.modifying.oper

[libcxx] r298681 - Implement Pp0156r2: 'Variadic Lock Guard, version 5' Reviewed as https://reviews.llvm.org/D31163.

2017-03-23 Thread Marshall Clow via cfe-commits
Author: marshall Date: Thu Mar 23 22:40:36 2017 New Revision: 298681 URL: http://llvm.org/viewvc/llvm-project?rev=298681&view=rev Log: Implement Pp0156r2: 'Variadic Lock Guard, version 5' Reviewed as https://reviews.llvm.org/D31163. Added: libcxx/trunk/test/std/thread/thread.mutex/thread.lo

[libcxx] r298686 - Move the scoped_lock inside the '#ifndef NO_THREADS' block to fix the no-threading build

2017-03-23 Thread Marshall Clow via cfe-commits
Author: marshall Date: Fri Mar 24 00:19:15 2017 New Revision: 298686 URL: http://llvm.org/viewvc/llvm-project?rev=298686&view=rev Log: Move the scoped_lock inside the '#ifndef NO_THREADS' block to fix the no-threading build Modified: libcxx/trunk/include/mutex Modified: libcxx/trunk/include

[libcxx] r298689 - Implement P0298R3: 'std::byte'. Reviewed as https://reviews.llvm.org/D31022

2017-03-23 Thread Marshall Clow via cfe-commits
Author: marshall Date: Fri Mar 24 00:45:39 2017 New Revision: 298689 URL: http://llvm.org/viewvc/llvm-project?rev=298689&view=rev Log: Implement P0298R3: 'std::byte'. Reviewed as https://reviews.llvm.org/D31022 Added: libcxx/trunk/test/std/language.support/support.types/byte.pass.cpp libc

[libcxx] r298706 - XFAIL the std::byte tests on a bunch of old clang versions, because they don't like 'std::byte b1{1}'

2017-03-24 Thread Marshall Clow via cfe-commits
Author: marshall Date: Fri Mar 24 11:17:20 2017 New Revision: 298706 URL: http://llvm.org/viewvc/llvm-project?rev=298706&view=rev Log: XFAIL the std::byte tests on a bunch of old clang versions, because they don't like 'std::byte b1{1}' Modified: libcxx/trunk/test/std/language.support/suppo

[libcxx] r298832 - Mark *fail tests as UNUSUPPORTED instead of XFAIL on old compilers

2017-03-26 Thread Marshall Clow via cfe-commits
Author: marshall Date: Mon Mar 27 01:31:58 2017 New Revision: 298832 URL: http://llvm.org/viewvc/llvm-project?rev=298832&view=rev Log: Mark *fail tests as UNUSUPPORTED instead of XFAIL on old compilers Modified: libcxx/trunk/test/std/language.support/support.types/byteops/lshift.assign.fail.

[libcxx] r298839 - Mark *pass tests as UNUSUPPORTED instead of XFAIL on old compilers

2017-03-27 Thread Marshall Clow via cfe-commits
Author: marshall Date: Mon Mar 27 05:44:33 2017 New Revision: 298839 URL: http://llvm.org/viewvc/llvm-project?rev=298839&view=rev Log: Mark *pass tests as UNUSUPPORTED instead of XFAIL on old compilers Modified: libcxx/trunk/test/std/language.support/support.types/byteops/and.assign.pass.cpp

[libcxx] r299652 - Restore Missing awk regex tests. Thanks to dexonsmith for noticing, and proposing this as https://reviews.llvm.org/D16541

2017-04-06 Thread Marshall Clow via cfe-commits
Author: marshall Date: Thu Apr 6 09:32:42 2017 New Revision: 299652 URL: http://llvm.org/viewvc/llvm-project?rev=299652&view=rev Log: Restore Missing awk regex tests. Thanks to dexonsmith for noticing, and proposing this as https://reviews.llvm.org/D16541 Modified: libcxx/trunk/test/std/re/

[libcxx] r299680 - Recommit awk tests with warnings removed. Initial commit r299652, reverted r299656.

2017-04-06 Thread Marshall Clow via cfe-commits
Author: marshall Date: Thu Apr 6 13:34:36 2017 New Revision: 299680 URL: http://llvm.org/viewvc/llvm-project?rev=299680&view=rev Log: Recommit awk tests with warnings removed. Initial commit r299652, reverted r299656. Modified: libcxx/trunk/test/std/re/re.alg/re.alg.match/awk.pass.cpp Modi

[libcxx] r299686 - Some of Eric's buildbots don't like this test. Disable it while I figure out why.

2017-04-06 Thread Marshall Clow via cfe-commits
Author: marshall Date: Thu Apr 6 13:54:37 2017 New Revision: 299686 URL: http://llvm.org/viewvc/llvm-project?rev=299686&view=rev Log: Some of Eric's buildbots don't like this test. Disable it while I figure out why. Modified: libcxx/trunk/test/std/re/re.alg/re.alg.match/awk.pass.cpp Modifi

[libcxx] r299894 - Fix PR#32606: std::decay mishandles abominable function types

2017-04-10 Thread Marshall Clow via cfe-commits
Author: marshall Date: Mon Apr 10 17:51:07 2017 New Revision: 299894 URL: http://llvm.org/viewvc/llvm-project?rev=299894&view=rev Log: Fix PR#32606: std::decay mishandles abominable function types Modified: libcxx/trunk/include/type_traits libcxx/trunk/test/std/utilities/meta/meta.trans/

[libcxx] r299901 - Fix PR#32605: common_type is not SFINAE-friendly

2017-04-10 Thread Marshall Clow via cfe-commits
Author: marshall Date: Mon Apr 10 18:47:47 2017 New Revision: 299901 URL: http://llvm.org/viewvc/llvm-project?rev=299901&view=rev Log: Fix PR#32605: common_type is not SFINAE-friendly Modified: libcxx/trunk/include/type_traits libcxx/trunk/test/std/utilities/meta/meta.trans/meta.trans.ot

[libcxx] r299907 - Remove some trigraphs that GCC was complaining about

2017-04-10 Thread Marshall Clow via cfe-commits
Author: marshall Date: Mon Apr 10 19:18:28 2017 New Revision: 299907 URL: http://llvm.org/viewvc/llvm-project?rev=299907&view=rev Log: Remove some trigraphs that GCC was complaining about Modified: libcxx/trunk/test/std/utilities/meta/meta.trans/meta.trans.other/common_type.pass.cpp Modifie

[libcxx] r299909 - Fix a C++03 failure

2017-04-10 Thread Marshall Clow via cfe-commits
Author: marshall Date: Mon Apr 10 20:54:48 2017 New Revision: 299909 URL: http://llvm.org/viewvc/llvm-project?rev=299909&view=rev Log: Fix a C++03 failure Modified: libcxx/trunk/test/std/utilities/meta/meta.trans/meta.trans.other/common_type.pass.cpp Modified: libcxx/trunk/test/std/utiliti

[libcxx] r299941 - Mark P0599 as complete. It was implemented in r298573

2017-04-11 Thread Marshall Clow via cfe-commits
Author: marshall Date: Tue Apr 11 09:04:03 2017 New Revision: 299941 URL: http://llvm.org/viewvc/llvm-project?rev=299941&view=rev Log: Mark P0599 as complete. It was implemented in r298573 Modified: libcxx/trunk/www/cxx1z_status.html Modified: libcxx/trunk/www/cxx1z_status.html URL: http://

Re: [PATCH] D29877: Warn about unused static file scope function template declarations.

2017-04-11 Thread Marshall Clow via cfe-commits
On Tue, Apr 11, 2017 at 6:59 AM, Alex Lorenz via Phabricator via cfe-commits wrote: > arphaman added a comment. > > Ah, I see. I guess if `static` is removed the warning will go away. Thanks! > > https://reviews.llvm.org/D29877 > > I would have appreciated a heads-up here, since libc++ no longer

[libcxx] r299963 - Implement LWG#2873: 'Add noexcept to several shared_ptr related functions' This issue missed a couple, so I added those as well (see LWG#2942)

2017-04-11 Thread Marshall Clow via cfe-commits
Author: marshall Date: Tue Apr 11 12:08:53 2017 New Revision: 299963 URL: http://llvm.org/viewvc/llvm-project?rev=299963&view=rev Log: Implement LWG#2873: 'Add noexcept to several shared_ptr related functions' This issue missed a couple, so I added those as well (see LWG#2942) Modified: libc

[libcxx] r300009 - Add some FAIL constexpr tests for optional's copy/move ctors.

2017-04-11 Thread Marshall Clow via cfe-commits
Author: marshall Date: Tue Apr 11 19:07:29 2017 New Revision: 39 URL: http://llvm.org/viewvc/llvm-project?rev=39&view=rev Log: Add some FAIL constexpr tests for optional's copy/move ctors. Added: libcxx/trunk/test/std/utilities/optional/optional.object/optional.object.ctor/copy.fail.

[libcxx] r300123 - Implement part of LWG#2857 - any/optional. Still to do - variant. Reviewed as https://reviews.llvm.org/D31956

2017-04-12 Thread Marshall Clow via cfe-commits
Author: marshall Date: Wed Apr 12 17:51:27 2017 New Revision: 300123 URL: http://llvm.org/viewvc/llvm-project?rev=300123&view=rev Log: Implement part of LWG#2857 - any/optional. Still to do - variant. Reviewed as https://reviews.llvm.org/D31956 Modified: libcxx/trunk/include/any libcxx/t

[libcxx] r300124 - Additional test file for r300123

2017-04-12 Thread Marshall Clow via cfe-commits
Author: marshall Date: Wed Apr 12 17:51:56 2017 New Revision: 300124 URL: http://llvm.org/viewvc/llvm-project?rev=300124&view=rev Log: Additional test file for r300123 Modified: libcxx/trunk/test/std/utilities/optional/optional.object/optional.object.assign/emplace.pass.cpp Modified: libcx

[libcxx] r300197 - Refactor throw_with_nested. NFC.

2017-04-13 Thread Marshall Clow via cfe-commits
Author: marshall Date: Thu Apr 13 09:41:45 2017 New Revision: 300197 URL: http://llvm.org/viewvc/llvm-project?rev=300197&view=rev Log: Refactor throw_with_nested. NFC. Modified: libcxx/trunk/include/exception Modified: libcxx/trunk/include/exception URL: http://llvm.org/viewvc/llvm-project/

[libcxx] r300218 - Implement LWG#2855 - made easy by previous refactoring

2017-04-13 Thread Marshall Clow via cfe-commits
Author: marshall Date: Thu Apr 13 11:57:42 2017 New Revision: 300218 URL: http://llvm.org/viewvc/llvm-project?rev=300218&view=rev Log: Implement LWG#2855 - made easy by previous refactoring Modified: libcxx/trunk/include/exception libcxx/trunk/test/std/language.support/support.exception/

[libcxx] r300232 - Remove the binders from C++17. Reviewed as https://reviews.llvm.org/D31769

2017-04-13 Thread Marshall Clow via cfe-commits
Author: marshall Date: Thu Apr 13 13:25:32 2017 New Revision: 300232 URL: http://llvm.org/viewvc/llvm-project?rev=300232&view=rev Log: Remove the binders from C++17. Reviewed as https://reviews.llvm.org/D31769 Added: libcxx/trunk/test/libcxx/depr/depr.function.objects/ libcxx/trunk/test/l

[libcxx] r300449 - Mark LWG#2853 as complete. No code changes required, but added a couple of extra tests

2017-04-17 Thread Marshall Clow via cfe-commits
Author: marshall Date: Mon Apr 17 08:19:14 2017 New Revision: 300449 URL: http://llvm.org/viewvc/llvm-project?rev=300449&view=rev Log: Mark LWG#2853 as complete. No code changes required, but added a couple of extra tests Modified: libcxx/trunk/test/std/containers/sequences/vector/vector.mo

[libcxx] r300451 - Sigh. Once again forgot about the 'no exceptions' bots.

2017-04-17 Thread Marshall Clow via cfe-commits
Author: marshall Date: Mon Apr 17 09:18:44 2017 New Revision: 300451 URL: http://llvm.org/viewvc/llvm-project?rev=300451&view=rev Log: Sigh. Once again forgot about the 'no exceptions' bots. Modified: libcxx/trunk/test/std/containers/sequences/vector/vector.modifiers/erase_iter.pass.cpp

[libcxx] r300568 - Mark LWG#2788 as complete - we already do this

2017-04-18 Thread Marshall Clow via cfe-commits
Author: marshall Date: Tue Apr 18 12:22:49 2017 New Revision: 300568 URL: http://llvm.org/viewvc/llvm-project?rev=300568&view=rev Log: Mark LWG#2788 as complete - we already do this Modified: libcxx/trunk/www/cxx1z_status.html Modified: libcxx/trunk/www/cxx1z_status.html URL: http://llvm.or

[libcxx] r291773 - Add new macro _LIBCPP_BUILTIN_MEMCMP_ISCONSTEXPR to use in std::char_traits.

2017-01-12 Thread Marshall Clow via cfe-commits
Author: marshall Date: Thu Jan 12 10:25:07 2017 New Revision: 291773 URL: http://llvm.org/viewvc/llvm-project?rev=291773&view=rev Log: Add new macro _LIBCPP_BUILTIN_MEMCMP_ISCONSTEXPR to use in std::char_traits. This tells whether or not the builtin function __builtin_memcmp is constexpr. Only de

[libcxx] r292000 - Mark 'constexpr char_traits' as complete.

2017-01-13 Thread Marshall Clow via cfe-commits
Author: marshall Date: Fri Jan 13 23:55:17 2017 New Revision: 292000 URL: http://llvm.org/viewvc/llvm-project?rev=292000&view=rev Log: Mark 'constexpr char_traits' as complete. Modified: libcxx/trunk/www/cxx1z_status.html Modified: libcxx/trunk/www/cxx1z_status.html URL: http://llvm.org/vi

[libcxx] r292091 - Implement the missing constexpr stuff in . Fixes PR#31645.

2017-01-15 Thread Marshall Clow via cfe-commits
Author: marshall Date: Sun Jan 15 21:02:10 2017 New Revision: 292091 URL: http://llvm.org/viewvc/llvm-project?rev=292091&view=rev Log: Implement the missing constexpr stuff in . Fixes PR#31645. Modified: libcxx/trunk/include/array libcxx/trunk/test/std/containers/sequences/array/at.pass.c

[libcxxabi] r292135 - Mark the dynamic-exception tests as unsupported under C++17, since it has no dynamic-exception specs. Also, remove a FIXME workaround from the config that allowed these tests to

2017-01-16 Thread Marshall Clow via cfe-commits
Author: marshall Date: Mon Jan 16 09:28:03 2017 New Revision: 292135 URL: http://llvm.org/viewvc/llvm-project?rev=292135&view=rev Log: Mark the dynamic-exception tests as unsupported under C++17, since it has no dynamic-exception specs. Also, remove a FIXME workaround from the config that allowe

[libcxx] r292490 - Mark two of the TS implementations as 'in progress'

2017-01-19 Thread Marshall Clow via cfe-commits
Author: marshall Date: Thu Jan 19 09:30:36 2017 New Revision: 292490 URL: http://llvm.org/viewvc/llvm-project?rev=292490&view=rev Log: Mark two of the TS implementations as 'in progress' Modified: libcxx/trunk/www/cxx1z_status.html Modified: libcxx/trunk/www/cxx1z_status.html URL: http://ll

Re: [libcxx] r292582 - Still expose std::align_val_t in C++17 even if we don't have aligned new/delete.

2017-01-20 Thread Marshall Clow via cfe-commits
On Thu, Jan 19, 2017 at 10:40 PM, Eric Fiselier wrote: > Hi All, > > This patch addresses issues introduced by r292564. Specifically it makes > `align_val_t.pass.cpp` pass in C++17 even if the system > doesn't support aligned new/delete. > > Because r292564 was merged into 4.0, this should be as

[libcxx] r292806 - Removed some un-needed ifdefs

2017-01-23 Thread Marshall Clow via cfe-commits
Author: marshall Date: Mon Jan 23 11:25:38 2017 New Revision: 292806 URL: http://llvm.org/viewvc/llvm-project?rev=292806&view=rev Log: Removed some un-needed ifdefs Modified: libcxx/trunk/test/std/utilities/tuple/tuple.tuple/tuple.creation/tie.pass.cpp Modified: libcxx/trunk/test/std/utili

[libcxx] r292809 - Revert previous cleanup; I got too agressive removing #ifdefs

2017-01-23 Thread Marshall Clow via cfe-commits
Author: marshall Date: Mon Jan 23 12:00:15 2017 New Revision: 292809 URL: http://llvm.org/viewvc/llvm-project?rev=292809&view=rev Log: Revert previous cleanup; I got too agressive removing #ifdefs Modified: libcxx/trunk/test/std/utilities/tuple/tuple.tuple/tuple.creation/tie.pass.cpp Modifi

[libcxx] r292822 - Fixed a typo in __config that prevented the aligned new/delete tests from passing on Mac OS.

2017-01-23 Thread Marshall Clow via cfe-commits
Author: marshall Date: Mon Jan 23 13:51:54 2017 New Revision: 292822 URL: http://llvm.org/viewvc/llvm-project?rev=292822&view=rev Log: Fixed a typo in __config that prevented the aligned new/delete tests from passing on Mac OS. Modified: libcxx/trunk/include/__config Modified: libcxx/trunk/

[libcxx] r292823 - Implement LWG#2778: basic_string_view is missing constexpr.

2017-01-23 Thread Marshall Clow via cfe-commits
Author: marshall Date: Mon Jan 23 13:53:28 2017 New Revision: 292823 URL: http://llvm.org/viewvc/llvm-project?rev=292823&view=rev Log: Implement LWG#2778: basic_string_view is missing constexpr. Added: libcxx/trunk/test/std/strings/string.view/string.view.cons/assign.pass.cpp Modified: li

Re: [PATCH] D28933: Revert the return type for `emplace_(back|front)` to `void` in C++14 and before

2017-01-23 Thread Marshall Clow via cfe-commits
On Mon, Jan 23, 2017 at 4:33 PM, Hans Wennborg via Phabricator < revi...@reviews.llvm.org> wrote: > hans added a comment. > > This sounds like something we'll want to merge to the release branch when > it lands? > > > https://reviews.llvm.org/D28933 > Yes. I'll land it tomorrow afternoon. -- Ma

[libcxx] r292943 - A couple more tests for constexpr stuff in string_view. No changes other than test code.

2017-01-24 Thread Marshall Clow via cfe-commits
Author: marshall Date: Tue Jan 24 10:28:02 2017 New Revision: 292943 URL: http://llvm.org/viewvc/llvm-project?rev=292943&view=rev Log: A couple more tests for constexpr stuff in string_view. No changes other than test code. Modified: libcxx/trunk/test/std/strings/string.view/string.view.ite

[libcxx] r292958 - Mark LWG2736 as complete. No code changes, but we have more tests now

2017-01-24 Thread Marshall Clow via cfe-commits
Author: marshall Date: Tue Jan 24 12:03:32 2017 New Revision: 292958 URL: http://llvm.org/viewvc/llvm-project?rev=292958&view=rev Log: Mark LWG2736 as complete. No code changes, but we have more tests now Added: libcxx/trunk/test/std/utilities/optional/optional.nullopt/nullopt_t.fail.cpp Modi

[libcxx] r292962 - Implement LWG2733: [fund.ts.v2] gcd / lcm and bool. We already did tbis for C++17, so replicate the changes in experimental.

2017-01-24 Thread Marshall Clow via cfe-commits
Author: marshall Date: Tue Jan 24 12:15:48 2017 New Revision: 292962 URL: http://llvm.org/viewvc/llvm-project?rev=292962&view=rev Log: Implement LWG2733: [fund.ts.v2] gcd / lcm and bool. We already did tbis for C++17, so replicate the changes in experimental. Added: libcxx/trunk/test/std/e

[libcxx] r292967 - Update status for LWG2733

2017-01-24 Thread Marshall Clow via cfe-commits
Author: marshall Date: Tue Jan 24 13:37:09 2017 New Revision: 292967 URL: http://llvm.org/viewvc/llvm-project?rev=292967&view=rev Log: Update status for LWG2733 Modified: libcxx/trunk/www/cxx1z_status.html Modified: libcxx/trunk/www/cxx1z_status.html URL: http://llvm.org/viewvc/llvm-project

[libcxx] r292969 - Add a test to make sure that implicit conversion from error_code to bool will fail

2017-01-24 Thread Marshall Clow via cfe-commits
Author: marshall Date: Tue Jan 24 13:44:55 2017 New Revision: 292969 URL: http://llvm.org/viewvc/llvm-project?rev=292969&view=rev Log: Add a test to make sure that implicit conversion from error_code to bool will fail Added: libcxx/trunk/test/std/diagnostics/syserr/syserr.errcode/syserr.err

[libcxx] r292986 - Remove auto_ptr in C++17. Get it back by defining _LIBCPP_ENABLE_CXX17_REMOVED_AUTO_PTR

2017-01-24 Thread Marshall Clow via cfe-commits
Author: marshall Date: Tue Jan 24 16:22:33 2017 New Revision: 292986 URL: http://llvm.org/viewvc/llvm-project?rev=292986&view=rev Log: Remove auto_ptr in C++17. Get it back by defining _LIBCPP_ENABLE_CXX17_REMOVED_AUTO_PTR Added: libcxx/trunk/test/libcxx/depr/depr.auto.ptr/ libcxx/trunk/

[libcxx] r292992 - Implement LWG2556: Wide contract for future::share()

2017-01-24 Thread Marshall Clow via cfe-commits
Author: marshall Date: Tue Jan 24 17:28:25 2017 New Revision: 292992 URL: http://llvm.org/viewvc/llvm-project?rev=292992&view=rev Log: Implement LWG2556: Wide contract for future::share() Modified: libcxx/trunk/include/future libcxx/trunk/test/std/thread/futures/futures.unique_future/shar

[libcxx] r292990 - Change the return type of emplace_[front|back] back to void when building with C++14 or before. Resolves PR31680.

2017-01-24 Thread Marshall Clow via cfe-commits
Author: marshall Date: Tue Jan 24 17:09:12 2017 New Revision: 292990 URL: http://llvm.org/viewvc/llvm-project?rev=292990&view=rev Log: Change the return type of emplace_[front|back] back to void when building with C++14 or before. Resolves PR31680. Modified: libcxx/trunk/include/deque li

[libcxx] r293079 - Fixed a typo in the synopsis (noecept -> noexcept). Thanks to Kim for the catch

2017-01-25 Thread Marshall Clow via cfe-commits
Author: marshall Date: Wed Jan 25 14:14:03 2017 New Revision: 293079 URL: http://llvm.org/viewvc/llvm-project?rev=293079&view=rev Log: Fixed a typo in the synopsis (noecept -> noexcept). Thanks to Kim for the catch Modified: libcxx/trunk/include/future Modified: libcxx/trunk/include/future U

[libcxx] r293154 - Use the new __has_feature(cxx_constexpr_string_builtins) for detection of the C-string intrinsics for constexpr support in std::char_traits. Thanks to Richard for the intrisic suppo

2017-01-25 Thread Marshall Clow via cfe-commits
Author: marshall Date: Thu Jan 26 00:58:29 2017 New Revision: 293154 URL: http://llvm.org/viewvc/llvm-project?rev=293154&view=rev Log: Use the new __has_feature(cxx_constexpr_string_builtins) for detection of the C-string intrinsics for constexpr support in std::char_traits. Thanks to Richard fo

Re: [libcxx] r292990 - Change the return type of emplace_[front|back] back to void when building with C++14 or before. Resolves PR31680.

2017-01-26 Thread Marshall Clow via cfe-commits
On Wed, Jan 25, 2017 at 9:11 AM, Hans Wennborg wrote: > Should we merge this to 4.0? > Yes, please. -- Marshall > > On Tue, Jan 24, 2017 at 3:09 PM, Marshall Clow via cfe-commits > wrote: > > Author: marshall > > Date: Tue Jan 24 17:09:12 2017 > > New R

Re: [libcxx] r293154 - Use the new __has_feature(cxx_constexpr_string_builtins) for detection of the C-string intrinsics for constexpr support in std::char_traits. Thanks to Richard for the intrisic s

2017-01-26 Thread Marshall Clow via cfe-commits
On Wed, Jan 25, 2017 at 10:58 PM, Marshall Clow via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: marshall > Date: Thu Jan 26 00:58:29 2017 > New Revision: 293154 > > URL: http://llvm.org/viewvc/llvm-project?rev=293154&view=rev > Log:

[libcxx] r293179 - Fixed a couple of invalid statuses for 2665 and 2758

2017-01-26 Thread Marshall Clow via cfe-commits
Author: marshall Date: Thu Jan 26 08:36:14 2017 New Revision: 293179 URL: http://llvm.org/viewvc/llvm-project?rev=293179&view=rev Log: Fixed a couple of invalid statuses for 2665 and 2758 Modified: libcxx/trunk/www/cxx1z_status.html Modified: libcxx/trunk/www/cxx1z_status.html URL: http://l

Re: [libcxx] r292607 - Don't default older GCC's to C++17, but C++14 or C++11 instead

2017-01-26 Thread Marshall Clow via cfe-commits
On Thu, Jan 26, 2017 at 10:22 AM, Hans Wennborg wrote: > What's the status here? Waiting for Marshall? > I'm fine with merging this to the 4.0 branch -- Marshall ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mai

[libcxx] r293599 - Fix PR#31779: basic_string::operator= isn't exception safe.

2017-01-30 Thread Marshall Clow via cfe-commits
Author: marshall Date: Mon Jan 30 21:40:52 2017 New Revision: 293599 URL: http://llvm.org/viewvc/llvm-project?rev=293599&view=rev Log: Fix PR#31779: basic_string::operator= isn't exception safe. Modified: libcxx/trunk/include/string libcxx/trunk/test/std/strings/basic.string/string.cons/c

[libcxx] r293623 - Fix up some no-exception compile failures

2017-01-31 Thread Marshall Clow via cfe-commits
Author: marshall Date: Tue Jan 31 07:12:32 2017 New Revision: 293623 URL: http://llvm.org/viewvc/llvm-project?rev=293623&view=rev Log: Fix up some no-exception compile failures Modified: libcxx/trunk/test/std/strings/basic.string/string.cons/copy_alloc.pass.cpp Modified: libcxx/trunk/test/s

[libcxx] r294133 - Change the base class of std::bad_optional_access. This is a (subtle) ABI change, and is in response to http://http://wg21.link/LWG2806, which I *expect* to be adopted in Kona. I am

2017-02-05 Thread Marshall Clow via cfe-commits
Author: marshall Date: Sun Feb 5 14:06:38 2017 New Revision: 294133 URL: http://llvm.org/viewvc/llvm-project?rev=294133&view=rev Log: Change the base class of std::bad_optional_access. This is a (subtle) ABI change, and is in response to http://http://wg21.link/LWG2806, which I *expect* to be

[libcxx] r294142 - Restore the _NOEXCEPT on the dtor of bad_optional_access. Destructors are noexcept by default, so it's not really needed, but the other exception classes have the _NOEXCEPT, and gcc

2017-02-05 Thread Marshall Clow via cfe-commits
Author: marshall Date: Sun Feb 5 14:52:32 2017 New Revision: 294142 URL: http://llvm.org/viewvc/llvm-project?rev=294142&view=rev Log: Restore the _NOEXCEPT on the dtor of bad_optional_access. Destructors are noexcept by default, so it's not really needed, but the other exception classes have th

[libcxx] r294189 - Set up 'upcoming meeting' bug list

2017-02-06 Thread Marshall Clow via cfe-commits
Author: marshall Date: Mon Feb 6 09:17:22 2017 New Revision: 294189 URL: http://llvm.org/viewvc/llvm-project?rev=294189&view=rev Log: Set up 'upcoming meeting' bug list Modified: libcxx/trunk/www/upcoming_meeting.html Modified: libcxx/trunk/www/upcoming_meeting.html URL: http://llvm.org/vi

[libcxx] r294190 - Fix a typo - extra '>'

2017-02-06 Thread Marshall Clow via cfe-commits
Author: marshall Date: Mon Feb 6 09:29:03 2017 New Revision: 294190 URL: http://llvm.org/viewvc/llvm-project?rev=294190&view=rev Log: Fix a typo - extra '>' Modified: libcxx/trunk/www/upcoming_meeting.html Modified: libcxx/trunk/www/upcoming_meeting.html URL: http://llvm.org/viewvc/llvm-pr

[libcxx] r294194 - Add some tests to verify that we implement LWG#2837 correctly. No functional change.

2017-02-06 Thread Marshall Clow via cfe-commits
Author: marshall Date: Mon Feb 6 10:03:23 2017 New Revision: 294194 URL: http://llvm.org/viewvc/llvm-project?rev=294194&view=rev Log: Add some tests to verify that we implement LWG#2837 correctly. No functional change. Modified: libcxx/trunk/test/std/numerics/numeric.ops/numeric.ops.gcd/gcd

<    1   2   3   4   5   6   7   8   9   10   >