[PATCH] D152405: [WIP][clang] Add experimental option to omit the RTTI component from the vtable when -fno-rtti is used

2023-06-07 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan added a comment. > Can we extend the test cases to exercise both with and without > relative-vtables also enabled? Yup, the cases here already test with the regular itanium c++ abi and relative vtables abi. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D132275: [clang] Create alloca to pass into static lambda

2023-06-08 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan added a comment. Ok here's some of my findings. So there's a step in the attributor where it replaces some instructions with `unreachable`. One step is: *** IR Dump Before AttributorPass on [module] *** ; Function Attrs: inlinehint minsize nounwind optsize define linkonce_odr d

[PATCH] D152472: [Clang][MS] Remove assertion on BaseOffset can't be smaller than Size.

2023-06-14 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan added a comment. Hi. I think this caused the override-layout.cpp test to fail on our windows builder (https://logs.chromium.org/logs/fuchsia/buildbucket/cr-buildbucket/8778279637538184401/+/u/clang/test/stdout?format=raw): FAIL: Clang :: CodeGenCXX/override-layout.cpp (7816 of 187

[PATCH] D139589: [clang][Fuchsia] Re-enable hwasan global instrumentation on hwasan multilibs

2022-12-07 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan created this revision. leonardchan added reviewers: phosek, mcgrathr. leonardchan added a project: clang. Herald added a subscriber: abrachet. Herald added a project: All. leonardchan requested review of this revision. We can land this once we assert global instrumentation is enabled f

[PATCH] D134687: [clang] Ensure correct metadata for relative vtables

2022-12-07 Thread Leonard Chan via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG003b6033e1b2: [clang] Ensure correct metadata for relative vtables (authored by leonardchan). Changed prior to commit: https://reviews.llvm.org/D1

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

2021-04-22 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan updated this revision to Diff 339753. leonardchan marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85802/new/ https://reviews.llvm.org/D85802 Files: clang/include/clang/AST/ASTContext.h clang/include/cl

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

2021-04-22 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan added a comment. In D85802#2707677 , @jansvoboda11 wrote: > The fact that tests pass in assert builds without the argument generation > suggests the feature doesn't have sufficient test coverage. Currently, the > flag will be dropped during

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

2021-04-26 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan updated this revision to Diff 340620. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85802/new/ https://reviews.llvm.org/D85802 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/Basic/DiagnosticDriverKinds.td clang/inc

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

2021-04-26 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan added a comment. > That's odd. Does your `CMakeCache.txt` file have > `CLANG_ROUND_TRIP_CC1_ARGS:BOOL=OFF` by any chance? It's possible it didn't > get switched to `ON` when D97462 landed. > > With the way the tests are written now, I'd expect them t

[PATCH] D99381: [compiler-rt][hwasan] Add Fuchsia-specific sanitizer platform limits

2021-04-26 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan added a comment. *ping* @mcgrathr Given my explanation before, does it still make sense to refactor in this case? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99381/new/ https://reviews.llvm.org/D99381 ___

[PATCH] D99386: [compiler-rt][hwasan] Add definition for Symbolizer::SymbolizeFrame

2021-04-26 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan added a comment. *ping* Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99386/new/ https://reviews.llvm.org/D99386 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D99386: [compiler-rt][hwasan] Add definition for Symbolizer::SymbolizeFrame

2021-04-26 Thread Leonard Chan via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGa786f2badc41: [compiler-rt][hwasan] Add definition for Symbolizer::SymbolizeFrame (authored by leonardchan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99

[PATCH] D99381: [compiler-rt][hwasan] Add Fuchsia-specific sanitizer platform limits

2021-04-27 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan updated this revision to Diff 340983. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99381/new/ https://reviews.llvm.org/D99381 Files: compiler-rt/lib/sanitizer_common/sanitizer_platform_limits_posix.h Index: compiler-rt/lib/sanitizer

[PATCH] D99381: [compiler-rt][hwasan] Add Fuchsia-specific sanitizer platform limits

2021-04-27 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan added a comment. > we usually include them unconditionaly and .h itself has guards against > unsupported platforms @vitalybuka Did you mean something like this? Definitely simplifies the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

2021-04-28 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan updated this revision to Diff 341279. leonardchan marked 3 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85802/new/ https://reviews.llvm.org/D85802 Files: clang/include/clang/AST/ASTContext.h clang/include/cl

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

2021-04-28 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan updated this revision to Diff 341280. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85802/new/ https://reviews.llvm.org/D85802 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/Basic/DiagnosticDriverKinds.td clang/inc

[PATCH] D99381: [compiler-rt][hwasan] Add Fuchsia-specific sanitizer platform limits

2021-04-29 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan updated this revision to Diff 341610. leonardchan marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99381/new/ https://reviews.llvm.org/D99381 Files: compiler-rt/lib/hwasan/hwasan_interceptors.cpp compil

[PATCH] D99381: [compiler-rt][hwasan] Add Fuchsia-specific sanitizer platform limits

2021-04-29 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan added a comment. In D99381#2723563 , @vitalybuka wrote: > In D99381#2721619 , @phosek wrote: > >> What I think @vitalybuka meant is keeping >> `sanitizer_platform_limits_fuchsia.h` as you had it, but in

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

2021-05-03 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan added a comment. Will submit this later today unless there's any more comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85802/new/ https://reviews.llvm.org/D85802 ___ cfe-commits mailin

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

2021-05-04 Thread Leonard Chan via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG84c475437267: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use (authored by leonardchan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85802/

[PATCH] D101867: [clang][test] Update -fc++-abi tests

2021-05-04 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan created this revision. leonardchan added a reviewer: echristo. leonardchan added a project: clang. Herald added a subscriber: phosek. leonardchan requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D101867 Files: clang/test/Driver/cxx-a

[PATCH] D101867: [clang][test] Update -fc++-abi tests

2021-05-04 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan updated this revision to Diff 342889. leonardchan marked 2 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101867/new/ https://reviews.llvm.org/D101867 Files: clang/test/Driver/cxx-abi-flag.cpp clang/test/Front

[PATCH] D101867: [clang][test] Update -fc++-abi tests

2021-05-04 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan updated this revision to Diff 342891. leonardchan added a comment. Forgot the pipe in cxx-abi-flag.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101867/new/ https://reviews.llvm.org/D101867 Files: clang/test/Driver/cxx-abi-flag.c

[PATCH] D101867: [clang][test] Update -fc++-abi tests

2021-05-04 Thread Leonard Chan via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0277a24f4bba: [clang][test] Update -fc++-abi tests (authored by leonardchan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D93668: [clang] Override the Fuchsia platform ABI using the triple environment

2021-05-05 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan abandoned this revision. leonardchan added a comment. Abandoned in favor of D85802 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93668/new/ https://reviews.llvm.org/D93668

[PATCH] D101957: [clang][Fuchsia] Also use -fc++-abi=fuchsia for selecting relative-vtables multilibs

2021-05-05 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan created this revision. leonardchan added reviewers: phosek, mcgrathr. leonardchan added a project: clang. leonardchan requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D101957 Files: clang/lib/Driver/ToolChains/Fuchsia.cpp clang/tes

[PATCH] D91466: [WIP][clang][Fuchsia] Support HWASan for Fuchsia

2021-05-06 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan updated this revision to Diff 343468. leonardchan added a comment. Rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91466/new/ https://reviews.llvm.org/D91466 Files: clang/cmake/caches/Fuchsia-stage2.cmake compiler-rt/cmake/c

[PATCH] D91466: [WIP][clang][Fuchsia] Support HWASan for Fuchsia

2021-05-06 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan planned changes to this revision. leonardchan added inline comments. Comment at: compiler-rt/lib/hwasan/hwasan_dynamic_shadow.cpp:120 + +void InitShadowGOT() {} + Add comment. Fuchsia never uses dynamic shadow, which is what this sets up in the Linux

[PATCH] D102030: [clang][Fuchsia] Introduce compat multilibs

2021-05-06 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan created this revision. leonardchan added reviewers: phosek, mcgrathr. leonardchan added a project: clang. leonardchan requested review of this revision. These are GCC-compatible multilibs that use the generic Itanium C++ ABI instead of the Fuchsia C++ ABI. Repository: rG LLVM Gith

[PATCH] D102030: [clang][Fuchsia] Introduce compat multilibs

2021-05-06 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan marked an inline comment as done. leonardchan added inline comments. Comment at: clang/lib/Driver/ToolChains/Fuchsia.cpp:249-250 + .flag("+fc++-abi=itanium") + .flag("-fexceptions") + .flag("+f

[PATCH] D102030: [clang][Fuchsia] Introduce compat multilibs

2021-05-06 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan updated this revision to Diff 343526. leonardchan marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102030/new/ https://reviews.llvm.org/D102030 Files: clang/lib/Driver/ToolChains/Fuchsia.cpp clang/test

[PATCH] D102030: [clang][Fuchsia] Introduce compat multilibs

2021-05-11 Thread Leonard Chan via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. leonardchan marked an inline comment as done. Closed by commit rG5cb17728d194: [clang][Fuchsia] Introduce compat multilibs (authored by leonardchan). Changed prior to commit: https://reviews.llvm.org/D102030?vs=343526&id=

[PATCH] D99361: [clang][driver] Support HWASan in the Fuchsia toolchain

2021-03-25 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan created this revision. leonardchan added reviewers: mcgrathr, phosek. leonardchan added a project: clang. leonardchan requested review of this revision. These contain clang driver changes for supporting HWASan on Fuchsia. This includes hwasan multilibs and the dylib path change. Rep

[PATCH] D99364: [clang][cache] Update Fuchsia-stage2.cmake to create hwasan multilibs

2021-03-25 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan created this revision. leonardchan added reviewers: phosek, mcgrathr. leonardchan added a project: clang. Herald added a subscriber: mgorny. leonardchan requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D99364 Files: clang/cmake/cache

[PATCH] D99368: [compiler-rt][hwasan] Add C++17 new/delete operators with alignment

2021-03-25 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan created this revision. leonardchan added reviewers: phosek, mcgrathr, pcc, eugenis. leonardchan added a project: Sanitizers. Herald added a subscriber: dberris. leonardchan requested review of this revision. Herald added a subscriber: Sanitizers. Found that these were missing when atte

[PATCH] D99361: [clang][driver] Support HWASan in the Fuchsia toolchain

2021-03-25 Thread Leonard Chan via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG1abaadb30d37: [clang][driver] Support HWASan in the Fuchsia toolchain (authored by leonardchan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99361/new/ ht

[PATCH] D99381: [compiler-rt][hwasan] Add Fuchsia-specific sanitizer platform limits

2021-03-25 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan created this revision. leonardchan added reviewers: phosek, mcgrathr, pcc, eugenis. leonardchan added a project: Sanitizers. Herald added a subscriber: dberris. leonardchan requested review of this revision. Herald added a subscriber: Sanitizers. Fuchsia has it's own platform limits th

[PATCH] D99386: [compiler-rt][hwasan] Add definition for Symbolizer::SymbolizeFrame

2021-03-25 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan created this revision. leonardchan added reviewers: mcgrathr, phosek. leonardchan added a project: Sanitizers. Herald added a subscriber: dberris. leonardchan requested review of this revision. Herald added a subscriber: Sanitizers. This is undefined if `SANITIZER_SYMBOLIZER_MARKUP` is

[PATCH] D99381: [compiler-rt][hwasan] Add Fuchsia-specific sanitizer platform limits

2021-04-07 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan added a comment. In D99381#2651896 , @mcgrathr wrote: > I don't think this is warranted. There should not be any references to such > things when building for Fuchsia. > This looks like it's intended to satisfy one reference in dead code in

[PATCH] D91466: [WIP][clang][Fuchsia] Support HWASan for Fuchsia

2021-04-07 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan updated this revision to Diff 335951. leonardchan added a comment. Rebase against submitted changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91466/new/ https://reviews.llvm.org/D91466 Files: clang/cmake/caches/Fuchsia-stage2.cm

[PATCH] D99368: [compiler-rt][hwasan] Add C++17 new/delete operators with alignment

2021-04-08 Thread Leonard Chan via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. leonardchan marked an inline comment as done. Closed by commit rGa7b51d8a4fc8: [compiler-rt][hwasan] Add C++17 new/delete operators with alignment (authored by leonardc

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

2021-04-20 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan reopened this revision. leonardchan added a comment. This revision is now accepted and ready to land. Herald added a subscriber: jansvoboda11. Re-opening this based on discussions in D93668 . The consensus is that this is OK as long as the compiler kn

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

2021-04-21 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan updated this revision to Diff 339400. This revision is now accepted and ready to land. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85802/new/ https://reviews.llvm.org/D85802 Files: clang/include/clang/AST/ASTContext.h clang/include

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

2021-04-21 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan added a comment. I got LGTM for this before, but I'll leave it open for a few days to address any new comments folks might have. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3523 +else + Opts.CXXABI = TargetCXXABI::getKind(CXXABI); + } --

[PATCH] D93668: [clang] Add -ffuchsia-c++-abi flag to explicitly use the Fuchsia C++ ABI

2021-01-07 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan added a comment. In D93668#2482986 , @phosek wrote: > I'd prefer to use the target triple rather than introducing a custom flag. > > With dedicated flags, you might eventually end up in a similar situation as > D85802

[PATCH] D93668: [clang] Override the Fuchsia platform ABI using the triple environment

2021-01-11 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan updated this revision to Diff 315951. leonardchan retitled this revision from "[clang] Add -ffuchsia-c++-abi flag to explicitly use the Fuchsia C++ ABI" to "[clang] Override the Fuchsia platform ABI using the triple environment". leonardchan edited the summary of this revision. Repos

[PATCH] D91466: [WIP][clang][Fuchsia] Support HWASan for Fuchsia

2021-01-15 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan updated this revision to Diff 317118. leonardchan added a comment. Herald added subscribers: llvm-commits, jfb, hiraditya. Herald added a project: LLVM. Locally I'm able to build and run the `bringup.arm64` config (that is launch the shell and run some commands). Repository: rG LL

[PATCH] D91466: [WIP][clang][Fuchsia] Support HWASan for Fuchsia

2021-01-15 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan added a comment. In D91466#2395297 , @pcc wrote: > How does Zircon handle tagged addresses in syscalls? Are they handled > equivalently to Linux's tagged address ABI? Woops, accidentally let this slide. I'm guessing you saw this in the Fuchsi

[PATCH] D93668: [clang] Override the Fuchsia platform ABI using the triple environment

2021-01-19 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan added a comment. In D93668#2492081 , @phosek wrote: > I agree that if we want to allow selecting C++ ABI only, a flag like > `-fc++abi=` with some additional checks to disallow invalid combinations is > better. The question is whether we want

[PATCH] D93668: [clang] Override the Fuchsia platform ABI using the triple environment

2021-01-20 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan added a comment. Also, this probably isn't very important, but just as a heads up: if we were to depend on the environment component in the triple as the flag for selecting which multilib to use, then the multilib would be stored in a directory containing that environment. So assum

[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

2021-10-08 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan added a comment. Hi. I think our clang builders are failing from this after the reland (https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b8833962834812688769/overview): Script: -- /b/s/w/ir/x/w/staging/llvm_build/tools/clang/unittests/Interprete

[PATCH] D110451: [IR] Increase max alignment to 4GB

2021-10-08 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan added a comment. Hi. It seems the reland caused an assertion to fail on our clang builders (https://luci-milo.appspot.com/ui/p/fuchsia/builders/prod/clang-linux-x64/b8834065059600721665/overview): [194/194] Building CXX object lib/Target/AArch64/CMakeFiles/LLVMAArch64CodeGen.dir/A

[PATCH] D110451: [IR] Increase max alignment to 4GB

2021-10-08 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan added a comment. Finally got the stacktrace: leonardchan@cp-snakewater:~/llvm-monorepo/llvm-build-1-clang-only-debug$ bin/clang++ "-cc1" "-triple" "x86_64-unknown-linux-gnu" "-emit-obj" "--mrelax-relocations" "-disable-free" "-main-file-name" "AArch64SpeculationHardening.cpp" "-m

[PATCH] D108592: [WIP][clang][Fuchsia] Support __attribute__((availability)) on Fuchsia

2021-08-23 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan created this revision. leonardchan added reviewers: phosek, mcgrathr. leonardchan added a project: clang. Herald added a reviewer: aaron.ballman. leonardchan requested review of this revision. This also adds a warning that triggers when a non-zero minor/subminor are used. Repository:

[PATCH] D108592: [WIP][clang][Fuchsia] Support __attribute__((availability)) on Fuchsia

2021-08-23 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan planned changes to this revision. leonardchan added a comment. Some extra comments/open questions: - This patch supports using `N.0.0` as a version number. Do we want to just only accept `N` and disallow any number for minor/subminor, or will zeros be allowed? - This currently will

[PATCH] D108592: [WIP][clang][Fuchsia] Support __attribute__((availability)) on Fuchsia

2021-08-24 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan updated this revision to Diff 368423. leonardchan edited the summary of this revision. Herald added subscribers: dexonsmith, dang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108592/new/ https://reviews.llvm.org/D108592 Files: clang/

[PATCH] D108797: [WIP][compiler-rt] Build fuzzer tests

2021-08-26 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan created this revision. Herald added subscribers: mgorny, dberris. leonardchan requested review of this revision. Herald added projects: clang, Sanitizers. Herald added subscribers: Sanitizers, cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D108797 Files:

[PATCH] D109199: [compiler-rt][Fuchsia] Support building + running compiler-rt tests on fuchsia's host toolchain

2021-09-02 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan created this revision. leonardchan added reviewers: phosek, mcgrathr. leonardchan added a project: Sanitizers. Herald added subscribers: mgorny, dberris. leonardchan requested review of this revision. Herald added a project: clang. Herald added subscribers: Sanitizers, cfe-commits. Rep

[PATCH] D109199: [compiler-rt][Fuchsia] Support building + running compiler-rt tests on fuchsia's host toolchain

2021-09-02 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan added a comment. In D109199#2981174 , @phosek wrote: > @leonardchan would it be possible to break this up into 3 changes? Can do. Comment at: clang/cmake/caches/Fuchsia-stage2.cmake:123 set(RUNTIMES_${target}_COMPILER

[PATCH] D109199: [compiler-rt][Fuchsia] Support building + running compiler-rt tests on fuchsia's host toolchain

2021-09-02 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan added inline comments. Comment at: clang/cmake/caches/Fuchsia-stage2.cmake:141 +set(RUNTIMES_${target}_SANITIZER_COMMON_TEST_TARGET_CFLAGS "--unwindlib=libunwind -static-libgcc" CACHE STRING "") +set(RUNTIMES_${target}_TSAN_TEST_TARGET_CFLAGS "--unwindlib=lib

[PATCH] D109199: [compiler-rt][Fuchsia] Support building + running compiler-rt tests on fuchsia's host toolchain

2021-09-02 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan updated this revision to Diff 370447. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109199/new/ https://reviews.llvm.org/D109199 Files: clang/cmake/caches/Fuchsia-stage2.cmake Index: clang/cmake/caches/Fuchsia-stage2.cmake ==

[PATCH] D109199: [compiler-rt][Fuchsia] Support building + running compiler-rt tests on fuchsia's host toolchain

2021-09-02 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan added a comment. Split also into https://reviews.llvm.org/D109207 and https://reviews.llvm.org/D109208 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109199/new/ https://reviews.llvm.org/D109199

[PATCH] D109199: [compiler-rt][Fuchsia] Support building + running compiler-rt tests on fuchsia's host toolchain

2021-09-07 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan updated this revision to Diff 371163. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109199/new/ https://reviews.llvm.org/D109199 Files: clang/cmake/caches/Fuchsia-stage2.cmake Index: clang/cmake/caches/Fuchsia-stage2.cmake ==

[PATCH] D109199: [compiler-rt][Fuchsia] Support building + running compiler-rt tests on fuchsia's host toolchain

2021-09-07 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan added inline comments. Comment at: clang/cmake/caches/Fuchsia-stage2.cmake:123 set(RUNTIMES_${target}_COMPILER_RT_USE_BUILTINS_LIBRARY ON CACHE BOOL "") +set(RUNTIMES_${target}_COMPILER_RT_BUILD_BUILTINS ON CACHE BOOL "") +set(RUNTIMES_${target}_COMPILER_

[PATCH] D109199: [compiler-rt][Fuchsia] Support building + running compiler-rt tests on fuchsia's host toolchain

2021-09-08 Thread Leonard Chan via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe5673564a06b: [compiler-rt][Fuchsia] Support building + running compiler-rt tests on… (authored by leonardchan). Repository: rG LLVM Github Monore

[PATCH] D109625: [compiler-rt] Ensure LIT_TEST_DEP targets are actually built

2021-09-10 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan created this revision. leonardchan added a reviewer: phosek. Herald added subscribers: mgorny, dberris. leonardchan requested review of this revision. Herald added a project: Sanitizers. Herald added a subscriber: Sanitizers. When building compiler-rt via runtimes, many tests fail beca

<    4   5   6   7   8   9