omtcyfz added inline comments.
Comment at: change-namespace/ChangeNamespace.cpp:21
@@ +20,3 @@
+inline std::string formatNamespace(llvm::StringRef NS) {
+ (void)NS.ltrim(':');
+ return NS.str();
is `(void)` intended here?
Comment at: change-nam
omtcyfz added a comment.
In https://reviews.llvm.org/D24192#532981, @ioeric wrote:
> - You mentioned a design doc in the summary; maybe also include a link to it?
Done.
> - It would make the review easier if you could separate the migration of
> clang-rename into another patch...I think clang
omtcyfz updated this revision to Diff 70194.
omtcyfz added a comment.
Revert diff, as the last one "deletes and creates" files instead of "moving and
changing them" in the filesystem.
https://reviews.llvm.org/D24192
Files:
CMakeLists.txt
TemplatedClassFunction.cpp
clang-refactor/CMakeLis
omtcyfz updated this revision to Diff 70193.
omtcyfz added a comment.
Revert diff, as the last one "deletes and creates" files instead of "moving and
changing them" in the filesystem.
https://reviews.llvm.org/D23651
Files:
CMakeLists.txt
TemplatedClassFunction.cpp
clang-refactor/CMakeLis
omtcyfz added a comment.
In https://reviews.llvm.org/D24192#532981, @ioeric wrote:
> - It would make the review easier if you could separate the migration of
> clang-rename into another patch...
Another point is that if I try to separate the migration - what do I do about
USREngine? USREngine
omtcyfz abandoned this revision.
omtcyfz added a comment.
Oops, wrong patch... Abandoning this one anyway.
https://reviews.llvm.org/D23651
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
omtcyfz added a comment.
In https://reviews.llvm.org/D24192#533198, @ioeric wrote:
> In https://reviews.llvm.org/D24192#533174, @omtcyfz wrote:
>
> > In https://reviews.llvm.org/D24192#532981, @ioeric wrote:
> >
> > > - It would make the review easier if you could separate the migration of
> > >
Author: omtcyfz
Date: Sun Sep 4 17:19:52 2016
New Revision: 280638
URL: http://llvm.org/viewvc/llvm-project?rev=280638&view=rev
Log:
[clang-rename] Fix Clang-tidy and IWYU warnings; other minor fixes
Patch by Eugene Zelenko!
Differential Revision: https://reviews.llvm.org/D24178
Reviewers: omt
This revision was automatically updated to reflect the committed changes.
Closed by commit rL280638: [clang-rename] Fix Clang-tidy and IWYU warnings;
other minor fixes (authored by omtcyfz).
Changed prior to commit:
https://reviews.llvm.org/D24178?vs=70119&id=70293#toc
Repository:
rL LLVM
h
Author: omtcyfz
Date: Sun Sep 4 17:28:39 2016
New Revision: 280639
URL: http://llvm.org/viewvc/llvm-project?rev=280639&view=rev
Log:
[clang-rename] add failing test
For some reason clang-rename fails to rename method of templated class. Add
XFAIL test reproducing the issue.
Added:
clang-too
Author: omtcyfz
Date: Sun Sep 4 17:50:41 2016
New Revision: 280640
URL: http://llvm.org/viewvc/llvm-project?rev=280640&view=rev
Log:
[clang-rename] Enforce LLVM policy about braces around single line control flow
statement body.
Although it is not explicitly stated in LLVM Coding Standards, LLV
omtcyfz created this revision.
omtcyfz added reviewers: alexfh, ioeric, vmiklos.
omtcyfz added subscribers: cfe-commits, Eugene.Zelenko.
Having both rename-at and rename-all both seems confusing and introduces
unneeded difficulties. Allowing to use both -qualified-name and -offset at once
while
omtcyfz added a comment.
In https://reviews.llvm.org/D24192#533233, @ioeric wrote:
> It was not trivial to me why USREngine is so important to those tools. You
> might want to address that in the design doc as well. And given the weight
> USREngine carries in clang-refactor as you suggested, I
omtcyfz added a comment.
In https://reviews.llvm.org/D24192#533220, @ioeric wrote:
> Don't worry about a patch being small. Reviewers like small patches :)
>
> The reason that I suggested a dummy sub-tool is to lower the bar for
> developers, especially those who have never developed a clang too
omtcyfz added inline comments.
Comment at: change-namespace/ChangeNamespace.cpp:30
@@ +29,3 @@
+ std::string Result = Namespaces.front();
+ for (auto I = Namespaces.begin() + 1, E = Namespaces.end(); I != E; ++I) {
+Result += ("::" + *I).str();
Braces around
omtcyfz added inline comments.
Comment at: change-namespace/ChangeNamespace.cpp:480
@@ +479,3 @@
+Replaces = Replaces.merge(NewReplacements);
+format::FormatStyle Style = format::getStyle("file", FilePath, "google");
+// Clean up old namespaces if there is nothing in i
Author: omtcyfz
Date: Mon Sep 5 04:42:02 2016
New Revision: 280653
URL: http://llvm.org/viewvc/llvm-project?rev=280653&view=rev
Log:
[clang-rename] Add comment after namespace closing
Modified:
clang-tools-extra/trunk/clang-rename/RenamingAction.h
Modified: clang-tools-extra/trunk/clang-ren
omtcyfz added inline comments.
Comment at: change-namespace/ChangeNamespace.cpp:480
@@ +479,3 @@
+Replaces = Replaces.merge(NewReplacements);
+format::FormatStyle Style = format::getStyle("file", FilePath, "google");
+// Clean up old namespaces if there is nothing in i
omtcyfz added inline comments.
Comment at: clang-move/ClangMove.h:25
@@ +24,3 @@
+
+// TODO(hokein): Make it support more types, e.g. function definitions.
+// Currently only support moving class definition.
`FIXME`?
https://reviews.llvm.org/D24243
__
omtcyfz updated the summary for this revision.
omtcyfz removed a reviewer: bkramer.
omtcyfz added subscribers: bkramer, hokein.
omtcyfz updated this revision to Diff 70373.
omtcyfz added a comment.
Removed whole clang-rename part, only making this patch clang-rename specific.
https://reviews.llv
omtcyfz added a comment.
Bringing results of an offline discussion with Eric (@ioeric) live.
Eric's point was that this patch should only care about `clang-refactor` and
introduce changes directly related to creating `clang-rename`. `clang-rename`
and all other tools migration can be done later
omtcyfz updated this revision to Diff 70388.
omtcyfz marked 6 inline comments as done.
omtcyfz added a comment.
Address comments.
https://reviews.llvm.org/D24224
Files:
clang-rename/USRFindingAction.cpp
clang-rename/USRFindingAction.h
clang-rename/tool/ClangRename.cpp
docs/clang-rename.
omtcyfz added inline comments.
Comment at: clang-rename/USRFindingAction.h:23
@@ -19,1 +22,3 @@
+
+using llvm::ArrayRef;
alexfh wrote:
> No using declarations in headers, please. Also, since your code is in the
> clang namespace, you can include clang/Basic/LLV
omtcyfz updated this revision to Diff 70397.
omtcyfz marked 11 inline comments as done.
omtcyfz added a comment.
Addressing a round of comments.
https://reviews.llvm.org/D24192
Files:
CMakeLists.txt
clang-refactor/CMakeLists.txt
clang-refactor/driver/CMakeLists.txt
clang-refactor/driver
omtcyfz added a comment.
Thank you for reviewing, @hokein!
Also, please note that this is not a final version, the interface will change a
lot in the upcoming diffs.
Comment at: clang-refactor/driver/Driver.cpp:46
@@ +45,3 @@
+llvm::StringRef FirstArgument(argv[1]);
+i
omtcyfz updated this revision to Diff 70673.
omtcyfz marked 2 inline comments as done.
omtcyfz added a comment.
Address comments.
https://reviews.llvm.org/D24224
Files:
clang-rename/USRFindingAction.cpp
clang-rename/USRFindingAction.h
clang-rename/tool/ClangRename.cpp
docs/clang-rename.
omtcyfz updated this revision to Diff 70682.
omtcyfz marked 8 inline comments as done.
omtcyfz added a comment.
Herald added a subscriber: beanz.
Addressing few comments.
Major improvements on the way.
https://reviews.llvm.org/D24192
Files:
CMakeLists.txt
clang-refactor/CMakeLists.txt
cl
omtcyfz added inline comments.
Comment at: clang-refactor/driver/ModuleManager.cpp:22-24
@@ +21,5 @@
+int ModuleManager::Dispatch(StringRef Command, int argc, const char **argv) {
+ if (CommandToModuleID.find(Command) != CommandToModuleID.end()) {
+return RegisteredModules[Co
omtcyfz updated this revision to Diff 70687.
omtcyfz marked 4 inline comments as done.
omtcyfz added a comment.
Address another round of comments.
https://reviews.llvm.org/D24224
Files:
clang-rename/USRFindingAction.cpp
clang-rename/USRFindingAction.h
clang-rename/tool/ClangRename.cpp
d
omtcyfz added a comment.
A round of mostly stylistic comments.
Comment at: change-namespace/ChangeNamespace.cpp:85
@@ +84,3 @@
+
+SourceLocation getStartOfNextLine(SourceLocation Loc, const SourceManager &SM,
+ const LangOptions &LangOpts) {
omtcyfz added a comment.
Also +R Alex if he has some time to take a look at the code.
https://reviews.llvm.org/D24183
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
omtcyfz created this revision.
omtcyfz added reviewers: alexfh, Eugene.Zelenko, klimek.
omtcyfz added a subscriber: cfe-commits.
Implementing [[ https://llvm.org/bugs/show_bug.cgi?id=26823 | feature request
]].
This patch extends readability-container-size-empty check allowing it to
produce war
omtcyfz updated this revision to Diff 70717.
omtcyfz added a comment.
Blacklist `enum` and `bool` return types for `size()`.
https://reviews.llvm.org/D24349
Files:
clang-tidy/readability/ContainerSizeEmptyCheck.cpp
test/clang-tidy/readability-container-size-empty.cpp
Index: test/clang-tidy
omtcyfz marked an inline comment as done.
Comment at: clang-tidy/readability/ContainerSizeEmptyCheck.cpp:33
@@ +32,3 @@
+ const auto validContainer = namedDecl(
+ has(functionDecl(
+ isPublic(), hasName("size"), returns(isInteger()),
Thank you!
Bla
omtcyfz marked an inline comment as done.
omtcyfz added a comment.
In https://reviews.llvm.org/D24349#537350, @Eugene.Zelenko wrote:
> Probably check should have options to extend list of containers and also to
> assume all classes with integer type size() const and bool empty() const as
> cont
omtcyfz added a comment.
In https://reviews.llvm.org/D24349#537589, @Eugene.Zelenko wrote:
> If size() and empty() change object's state, it may be not equivalent
> replacement.
True. But my point is that they are not required to do that if they're just not
marked `const`.
Repository:
rL
omtcyfz added a comment.
In https://reviews.llvm.org/D24349#537624, @aaron.ballman wrote:
> I think that's reasonable, depending on whether we find false positives with
> the warning as well (I have a slight concern about `size()` and `empty()`
> being unrelated operations on a non-container cl
omtcyfz added inline comments.
Comment at: change-namespace/ChangeNamespace.cpp:232
@@ +231,3 @@
+}
+
+// FIXME(ioeric): handle the following symbols:
handle == "ioeric" here
s/FIXME(ioeric)/FIXME
Comment at: change-namespace/ChangeNamespace.cpp
omtcyfz updated this revision to Diff 70802.
omtcyfz marked 2 inline comments as done.
omtcyfz added a comment.
Slightly improve the interface.
Patch is still not complete, though.
https://reviews.llvm.org/D24192
Files:
CMakeLists.txt
clang-refactor/CMakeLists.txt
clang-refactor/driver/C
omtcyfz removed rL LLVM as the repository for this revision.
omtcyfz updated this revision to Diff 70818.
omtcyfz added a comment.
Restricted `size()` and `empty()` functions a little bit more.
https://reviews.llvm.org/D24349
Files:
clang-tidy/readability/ContainerSizeEmptyCheck.cpp
test/cl
omtcyfz updated this revision to Diff 70822.
omtcyfz added a comment.
Allow inheritance for `size()` and `empty()`.
https://reviews.llvm.org/D24349
Files:
clang-tidy/readability/ContainerSizeEmptyCheck.cpp
docs/clang-tidy/checks/readability-container-size-empty.rst
test/clang-tidy/clang-c
omtcyfz added a comment.
Ping.
Comment at: clang-rename/USRFindingAction.cpp:169
@@ -160,2 +168,3 @@
<< SymbolOffset << ").\n";
+exit(1);
} else {
alexfh wrote:
> I'd better not use `exit()` in library code and try to find a way to
omtcyfz added a comment.
In https://reviews.llvm.org/D24380#538556, @ioeric wrote:
> In https://reviews.llvm.org/D24380#538434, @Eugene.Zelenko wrote:
>
> > I think will be good idea to await clang-refactor and merge code there.
>
>
> This tool is not exactly a clang-tool; it is a framework that
omtcyfz updated this revision to Diff 70986.
omtcyfz marked 4 inline comments as done.
omtcyfz added a comment.
Address another round of comments.
https://reviews.llvm.org/D24349
Files:
clang-tidy/readability/ContainerSizeEmptyCheck.cpp
docs/clang-tidy/checks/readability-container-size-empt
omtcyfz updated this revision to Diff 70989.
omtcyfz added a comment.
Messed up with the last diff; fix that + clang-format the check.
https://reviews.llvm.org/D24349
Files:
clang-tidy/readability/ContainerSizeEmptyCheck.cpp
docs/clang-tidy/checks/readability-container-size-empty.rst
test
omtcyfz updated this revision to Diff 71119.
omtcyfz marked an inline comment as done.
omtcyfz added a comment.
Combine two `returns` matchers.
https://reviews.llvm.org/D24349
Files:
clang-tidy/readability/ContainerSizeEmptyCheck.cpp
docs/clang-tidy/checks/readability-container-size-empty.r
Author: omtcyfz
Date: Tue Sep 13 03:58:11 2016
New Revision: 281307
URL: http://llvm.org/viewvc/llvm-project?rev=281307&view=rev
Log:
[clang-tidy] Extend readability-container-size-empty to arbitrary class with
size() and empty()
This patch extends readability-container-size-empty check allowing
This revision was automatically updated to reflect the committed changes.
Closed by commit rL281307: [clang-tidy] Extend readability-container-size-empty
to arbitrary class with… (authored by omtcyfz).
Changed prior to commit:
https://reviews.llvm.org/D24349?vs=71119&id=71120#toc
Repository:
omtcyfz updated this revision to Diff 71130.
omtcyfz added a comment.
Remove redundant arguments passed to diagnostic.
https://reviews.llvm.org/D24224
Files:
clang-rename/USRFindingAction.cpp
clang-rename/USRFindingAction.h
clang-rename/tool/ClangRename.cpp
docs/clang-rename.rst
test/
Author: omtcyfz
Date: Tue Sep 13 05:19:13 2016
New Revision: 281313
URL: http://llvm.org/viewvc/llvm-project?rev=281313&view=rev
Log:
[clang-tidy] Fix naming in container-size-empty.
Modified:
clang-tools-extra/trunk/clang-tidy/readability/ContainerSizeEmptyCheck.cpp
Modified:
clang-tools-e
omtcyfz added inline comments.
Comment at: change-namespace/ChangeNamespace.cpp:359
@@ +358,3 @@
+ End, tok::semi, *Result.SourceManager, Result.Context->getLangOpts(),
+ /*SkipTrailingWhitespaceAndNewLine=*/true);
+ if (AfterSemi.isValid())
The indenta
omtcyfz updated this revision to Diff 71334.
omtcyfz marked an inline comment as done.
omtcyfz added a comment.
Nit.
https://reviews.llvm.org/D24224
Files:
clang-rename/USRFindingAction.cpp
clang-rename/USRFindingAction.h
clang-rename/tool/ClangRename.cpp
docs/clang-rename.rst
test/cl
Author: omtcyfz
Date: Wed Sep 14 08:00:36 2016
New Revision: 281456
URL: http://llvm.org/viewvc/llvm-project?rev=281456&view=rev
Log:
[clang-rename] Merge rename-{at|all} & optimize.
Having both rename-at and rename-all both seems confusing and introduces
unneeded difficulties. Allowing to use bo
This revision was automatically updated to reflect the committed changes.
Closed by commit rL281456: [clang-rename] Merge rename-{at|all} & optimize.
(authored by omtcyfz).
Changed prior to commit:
https://reviews.llvm.org/D24224?vs=71334&id=71336#toc
Repository:
rL LLVM
https://reviews.llv
Author: omtcyfz
Date: Wed Sep 14 08:23:14 2016
New Revision: 281459
URL: http://llvm.org/viewvc/llvm-project?rev=281459&view=rev
Log:
reverting r281456
Modified:
clang-tools-extra/trunk/clang-rename/USRFindingAction.cpp
clang-tools-extra/trunk/clang-rename/USRFindingAction.h
clang-too
omtcyfz created this revision.
omtcyfz added reviewers: alexfh, vmiklos.
omtcyfz added a subscriber: cfe-commits.
Having both rename-at and rename-all both seems confusing and introduces
unneeded difficulties. After merging rename-at and rename-all maintaining main
function wrappers and custom h
Author: omtcyfz
Date: Wed Sep 14 14:59:26 2016
New Revision: 281525
URL: http://llvm.org/viewvc/llvm-project?rev=281525&view=rev
Log:
Correct assert text in DeclGroup::getSingleDecl()
Assert text for getSingleDecl() is inaccurate. Appears to have been copy pasted
from getDeclGroup().
Patch by Be
This revision was automatically updated to reflect the committed changes.
Closed by commit rL281525: Correct assert text in DeclGroup::getSingleDecl()
(authored by omtcyfz).
Changed prior to commit:
https://reviews.llvm.org/D24518?vs=71188&id=71414#toc
Repository:
rL LLVM
https://reviews.ll
Author: omtcyfz
Date: Fri Sep 16 03:45:19 2016
New Revision: 281710
URL: http://llvm.org/viewvc/llvm-project?rev=281710&view=rev
Log:
[clang-rename] Merge rename-{at|all} & optimise.
Having both rename-at and rename-all both seems confusing and introduces
unneeded difficulties. After merging rena
omtcyfz added a comment.
In https://reviews.llvm.org/D24567#543459, @vmiklos wrote:
> As mentioned earlier, I have no problem with merging rename-at and rename-all.
Good, thanks!
https://reviews.llvm.org/D24567
___
cfe-commits mailing list
cfe-co
This revision was automatically updated to reflect the committed changes.
Closed by commit rL281710: [clang-rename] Merge rename-{at|all} & optimise.
(authored by omtcyfz).
Changed prior to commit:
https://reviews.llvm.org/D24567?vs=71367&id=71600#toc
Repository:
rL LLVM
https://reviews.llv
omtcyfz added inline comments.
Comment at: change-namespace/ChangeNamespace.cpp:448
@@ +447,3 @@
+ continue;
+const std::string &FilePath = FileAndNsMoves.first;
+auto &Replaces = FileToReplacements[FilePath];
`StringRef` here too.
https://reviews.l
omtcyfz added inline comments.
Comment at: change-namespace/ChangeNamespace.cpp:448
@@ +447,3 @@
+ continue;
+const std::string &FilePath = FileAndNsMoves.first;
+auto &Replaces = FileToReplacements[FilePath];
ioeric wrote:
> omtcyfz wrote:
> > `Strin
omtcyfz added a subscriber: omtcyfz.
omtcyfz added a comment.
Probably it also makes sense to reflect both `lambda` and template
instantiation parts in documentation, since I find current wording totally
confusing at the moment.
Comment at: clang-tidy/readability/AvoidConstPar
Author: omtcyfz
Date: Fri Sep 16 05:12:08 2016
New Revision: 281713
URL: http://llvm.org/viewvc/llvm-project?rev=281713&view=rev
Log:
[clang-tidy] Bugfix for readability-redundant-control-flow check
This check did not create FixItHints when the statement before the redundant
control flow was not
omtcyfz added a subscriber: omtcyfz.
omtcyfz added a comment.
In https://reviews.llvm.org/D24500#542284, @malcolm.parsons wrote:
> I didn't report a bug for this issue, and there isn't an existing one.
>
> I don't have commit access, so please commit it for me.
Since Alex is away at the moment
This revision was automatically updated to reflect the committed changes.
Closed by commit rL281713: [clang-tidy] Bugfix for
readability-redundant-control-flow check (authored by omtcyfz).
Changed prior to commit:
https://reviews.llvm.org/D24500?vs=71140&id=71608#toc
Repository:
rL LLVM
htt
omtcyfz added inline comments.
Comment at: clang-tidy/readability/AvoidConstParamsInDecls.cpp:41
@@ -40,1 +40,3 @@
+ unless(cxxMethodDecl(ofClass(cxxRecordDecl(anyOf(
+ isLambda(),
ast_matchers::isTemplateInstantiation()),
omtcyfz accepted this revision.
omtcyfz added a comment.
I have no other objections aswell.
LGTM.
https://reviews.llvm.org/D24183
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: omtcyfz
Date: Wed Jun 28 13:57:28 2017
New Revision: 306598
URL: http://llvm.org/viewvc/llvm-project?rev=306598&view=rev
Log:
[clangd] Cleanup ClangdUnit.cpp, update docs; NFC
* Enforce 80 characters limit where appropriate
* Use slightly more descriptive names for searched locations
* Up
omtcyfz added a comment.
Opened an [[ https://github.com/isocpp/CppCoreGuidelines/issues/770 | issue
]]in CppCoreGuidelines Github repo.
https://reviews.llvm.org/D25024
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/
omtcyfz updated this revision to Diff 76593.
omtcyfz added a comment.
Reversed "tabwidth:2 -> tabwidth:4" change.
Removed unused dependency (`re`).
Got rid of `sys.argv[0]` via using Pythonic `__file__` and removed (now)
redundant dependency (`sys`).
https://reviews.llvm.org/D25074
Files:
cl
omtcyfz added inline comments.
Comment at: clang-tidy/rename_check.py:89
- header_guard_old = module.upper() + '_' + check_name.upper().replace('-',
'_')
- header_guard_new = module.upper() + '_' +
check_name_new.upper().replace('-', '_')
+ header_guard_old = args.module.u
omtcyfz updated this revision to Diff 77168.
omtcyfz added a comment.
Addressing comments Alex made about line breaks.
https://reviews.llvm.org/D25074
Files:
clang-tidy/rename_check.py
Index: clang-tidy/rename_check.py
===
--- c
This revision was automatically updated to reflect the committed changes.
Closed by commit rL286228: [clang-tidy] Improve rename_check.py. (authored by
omtcyfz).
Changed prior to commit:
https://reviews.llvm.org/D25074?vs=77168&id=77169#toc
Repository:
rL LLVM
https://reviews.llvm.org/D2507
Author: omtcyfz
Date: Tue Nov 8 05:43:50 2016
New Revision: 286228
URL: http://llvm.org/viewvc/llvm-project?rev=286228&view=rev
Log:
[clang-tidy] Improve rename_check.py.
-Start using argparse instead of mimicking CLI parsing.
-PEPify the code.
-Decrease the number of imports by slightly cleanin
omtcyfz updated this revision to Diff 64374.
https://reviews.llvm.org/D22465
Files:
clang-rename/RenamingAction.cpp
clang-rename/USRFinder.cpp
clang-rename/USRLocFinder.cpp
test/clang-rename/ClassNameInFunctionDefenition.cpp
test/clang-rename/ComplicatedClassType.cpp
test/clang-rename
omtcyfz added a comment.
Removed two `FIXME`s. Seems like types are now handled correctly. +1 test
passing.
https://reviews.llvm.org/D22465
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
This revision was automatically updated to reflect the committed changes.
Closed by commit rL275958: [clang-rename] add support for overridden functions
(authored by omtcyfz).
Changed prior to commit:
https://reviews.llvm.org/D22408?vs=64293&id=64453#toc
Repository:
rL LLVM
https://reviews.
Author: omtcyfz
Date: Tue Jul 19 02:37:43 2016
New Revision: 275958
URL: http://llvm.org/viewvc/llvm-project?rev=275958&view=rev
Log:
[clang-rename] add support for overridden functions
Reviewers: klimek
Differential Revision: https://reviews.llvm.org/D22408
Modified:
clang-tools-extra/trun
omtcyfz updated this revision to Diff 64454.
omtcyfz added a comment.
applied few stylistic fixes
https://reviews.llvm.org/D22465
Files:
clang-rename/RenamingAction.cpp
clang-rename/USRFinder.cpp
clang-rename/USRLocFinder.cpp
test/clang-rename/ClassNameInFunctionDefenition.cpp
test/cl
omtcyfz added a comment.
Can anyone please take a look at this?
My current work is based on this patch and I'd be happy to know I'm doing
things right :)
https://reviews.llvm.org/D22465
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:
omtcyfz updated this revision to Diff 64668.
omtcyfz added a comment.
add support for renaming inside NestedNameSpecifier's
https://reviews.llvm.org/D22465
Files:
clang-rename/RenamingAction.cpp
clang-rename/USRFinder.cpp
clang-rename/USRFinder.h
clang-rename/USRLocFinder.cpp
test/cla
Author: omtcyfz
Date: Wed Jul 20 07:28:38 2016
New Revision: 276110
URL: http://llvm.org/viewvc/llvm-project?rev=276110&view=rev
Log:
[clang-tidy] readability-identifier-naming - support for other case types
Added Camel_Snake_Case and camel_Snake_Back
class Camel_Snake_Case_Class_Name
{
void p
This revision was automatically updated to reflect the committed changes.
Closed by commit rL276110: [clang-tidy] readability-identifier-naming - support
for other case types (authored by omtcyfz).
Changed prior to commit:
https://reviews.llvm.org/D21472?vs=63462&id=64671#toc
Repository:
rL
omtcyfz added a comment.
The patch looks fine to me (though I'm not sure if there are no new tests; if
they are interface changes should be applied).
If everyone seems to be in favor of such changes, I'm OK with it, but in
general I think it makes things more complicated and I'm not sure if it'
omtcyfz added a comment.
ping
https://reviews.llvm.org/D22465
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
omtcyfz updated this revision to Diff 64838.
omtcyfz added a comment.
few fixes
https://reviews.llvm.org/D22465
Files:
clang-rename/RenamingAction.cpp
clang-rename/USRFinder.cpp
clang-rename/USRFinder.h
clang-rename/USRLocFinder.cpp
test/clang-rename/ClassNameInFunctionDefenition.cpp
omtcyfz updated this revision to Diff 64839.
omtcyfz added a comment.
fix previously unsupported test
https://reviews.llvm.org/D22465
Files:
clang-rename/RenamingAction.cpp
clang-rename/USRFinder.cpp
clang-rename/USRFinder.h
clang-rename/USRLocFinder.cpp
test/clang-rename/ClassNameInF
omtcyfz updated this revision to Diff 64841.
omtcyfz added a comment.
add one more XFAIL test
https://reviews.llvm.org/D22465
Files:
clang-rename/RenamingAction.cpp
clang-rename/USRFinder.cpp
clang-rename/USRFinder.h
clang-rename/USRLocFinder.cpp
test/clang-rename/ClassNameInFunctionD
omtcyfz updated this revision to Diff 64844.
https://reviews.llvm.org/D22465
Files:
clang-rename/RenamingAction.cpp
clang-rename/USRFinder.cpp
clang-rename/USRFinder.h
clang-rename/USRLocFinder.cpp
test/clang-rename/ClassNameInFunctionDefenition.cpp
test/clang-rename/ComplicatedClassT
Author: omtcyfz
Date: Thu Jul 21 05:21:31 2016
New Revision: 276259
URL: http://llvm.org/viewvc/llvm-project?rev=276259&view=rev
Log:
[clang-rename] check whether -new-name is valid identifier in C++17
Added:
clang-tools-extra/trunk/test/clang-rename/InvalidNewName.cpp
Modified:
clang-to
omtcyfz updated this revision to Diff 65033.
omtcyfz marked an inline comment as done.
omtcyfz added a comment.
Address comments.
https://reviews.llvm.org/D22465
Files:
clang-rename/RenamingAction.cpp
clang-rename/USRFinder.cpp
clang-rename/USRFinder.h
clang-rename/USRLocFinder.cpp
te
omtcyfz added inline comments.
Comment at: clang-rename/USRFinder.cpp:94
@@ -91,4 +93,3 @@
const auto *Decl = NameLoc.getNestedNameSpecifier()->getAsNamespace();
- if (Decl && !setResult(Decl, NameLoc.getLocalBeginLoc(),
- Decl->getNameAsStr
omtcyfz added inline comments.
Comment at: clang-rename/tool/ClangRename.cpp:19
@@ +18,3 @@
+#include "clang/Basic/Diagnostic.h"
+#include "clang/Basic/DiagnosticIDs.h"
+#include "clang/Basic/DiagnosticOptions.h"
Do we use anything from `DiagnosticIDs.h` here?
R
omtcyfz added a comment.
I'd be actually happy if instead of having `-rename-at` option we'd have this
behavior by default unless `-rename-all` is used.
https://reviews.llvm.org/D21814
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://
omtcyfz added a comment.
> I can make the rename-at subcommand optional, and when not specifying a
> subcommand, assume rename-at was specified (unless -help or -version is
> used). Is this what you want?
Yep, exactly.
Sorry, I might have not expressed my idea good enough.
https://reviews.l
omtcyfz updated this revision to Diff 65053.
omtcyfz added a comment.
- reduce rate of hardcoding
- simplify symbol location finding
- introduce tests with templates, some of them are `PASS`ing
https://reviews.llvm.org/D22465
Files:
clang-rename/RenamingAction.cpp
clang-rename/USRFinder.cpp
omtcyfz updated this revision to Diff 65054.
omtcyfz added a comment.
split declarations
https://reviews.llvm.org/D22465
Files:
clang-rename/RenamingAction.cpp
clang-rename/USRFinder.cpp
clang-rename/USRFinder.h
clang-rename/USRFindingAction.cpp
clang-rename/USRLocFinder.cpp
test/cl
omtcyfz updated this revision to Diff 65056.
omtcyfz added a comment.
oops... actually split declarations
https://reviews.llvm.org/D22465
Files:
clang-rename/RenamingAction.cpp
clang-rename/USRFinder.cpp
clang-rename/USRFinder.h
clang-rename/USRFindingAction.cpp
clang-rename/USRLocFin
301 - 400 of 696 matches
Mail list logo
