[PATCH] D51917: [CodeCompletion] Enable signature help when initializing class/struct/union members.

This revision was automatically updated to reflect the committed changes. Closed by commit rL341949: [CodeCompletion] Enable signature help when initializing class/struct/union… (authored by kadircet, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.

[PATCH] D51924: [clangd] Add unittests for D51917

This revision was automatically updated to reflect the committed changes. Closed by commit rL341950: [clangd] Add unittests for D51917 (authored by kadircet, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D51924?vs=164845&id=164886#toc

[PATCH] D51996: [clangd] Simplify cancellation public API

kadircet added a comment. Seems a lot cleaner now, thanks! Do you plan to have other changes like moving control to JSONRPCDispatcher and recording timings for analysis on this patch? If not maybe we can add some fixme's so that we won't forget. Also the somewhat "caching" of cancellation toke

[PATCH] D52004: [clangd] Allow all LSP methods to signal cancellation via $/cancelRequest

kadircet added a comment. Wonder if we can still keep the onCancelRequest registry within ProtocolHandler's scope, so that it is clear that we implement it. Other than that seems fascinating, thanks! Comment at: clangd/JSONRPCDispatcher.cpp:246 + auto StrID = llvm::to_string

[PATCH] D51996: [clangd] Simplify cancellation public API

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51996 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lis

[PATCH] D51747: [clangd] Implement deprecation diagnostics with lower severity.

kadircet added a comment. As discussed offline with Ilya, decided to keep the compile flag addition since it would be easier to pass the logic of a command line flag to that point. Also not changing the severity level, since they will show up on diagnostics lists in anyway it doesn't save much.

[PATCH] D51747: [clangd] Implement deprecation diagnostics with lower severity.

kadircet updated this revision to Diff 165252. kadircet marked 5 inline comments as done. kadircet added a comment. - Resolve discussions. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51747 Files: clangd/ClangdServer.cpp unittests/clangd/ClangdUnitTests.cpp Index: unitt

[PATCH] D52004: [clangd] Allow all LSP methods to signal cancellation via $/cancelRequest

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52004 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D51747: [clangd] Implement deprecation diagnostics with lower severity.

kadircet updated this revision to Diff 165266. kadircet marked an inline comment as done. kadircet added a comment. - Do not show up as errors even on codebases with -Werror. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51747 Files: clangd/ClangdServer.cpp unittests/clang

[PATCH] D51747: [clangd] Implement deprecation diagnostics with lower severity.

kadircet added inline comments. Comment at: clangd/ClangdServer.cpp:537 C->CommandLine.push_back("-resource-dir=" + ResourceDir); + C->CommandLine.push_back("-Wdeprecated-declarations"); return std::move(*C); sammccall wrote: > kadircet wrote: > > sammccal

[PATCH] D51725: Allow un-setting the compilation database path

kadircet added inline comments. Comment at: clangd/Protocol.h:368 + /// both Optionals are instantiated. + llvm::Optional> compilationDatabasePath; ilya-biryukov wrote: > Not a big fan or something like this, but maybe give special meaning to empty > path in

[PATCH] D51747: [clangd] Show deprecation diagnostics

kadircet updated this revision to Diff 165275. kadircet marked 2 inline comments as done. kadircet added a comment. - Convert unit tests to lit tests and address comments. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51747 Files: clangd/ClangdServer.cpp test/clangd/overri

[PATCH] D51747: [clangd] Show deprecation diagnostics

kadircet planned changes to this revision. kadircet added a comment. When doing some manual testing saw that it causes a lot of slow down on vim, even when I have just about 200 diagnostics, will wait till a few others check that out. We might wanna limit the number of diagnostics and keep only

[PATCH] D51747: [clangd] Show deprecation diagnostics

kadircet added a comment. In https://reviews.llvm.org/D51747#1233371, @sammccall wrote: > Sorry for all the back and forth on this patch, but I have to ask... what's > up with switching to lit tests? > > We've mostly started avoiding these as they're hard to maintain and debug > (not to mention

[PATCH] D51747: [clangd] Show deprecation diagnostics

kadircet updated this revision to Diff 165302. kadircet added a comment. This revision is now accepted and ready to land. - Turn back to unit tests. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51747 Files: clangd/ClangdServer.cpp unittests/clangd/ClangdTests.cpp Index:

[PATCH] D51747: [clangd] Show deprecation diagnostics

kadircet added a comment. In https://reviews.llvm.org/D51747#1233401, @sammccall wrote: > In https://reviews.llvm.org/D51747#1233377, @kadircet wrote: > > > In https://reviews.llvm.org/D51747#1233371, @sammccall wrote: > > > > > Sorry for all the back and forth on this patch, but I have to ask...

[PATCH] D51747: [clangd] Show deprecation diagnostics

kadircet updated this revision to Diff 165462. kadircet marked 2 inline comments as done. kadircet added a comment. - Add matchers to test. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51747 Files: clangd/ClangdServer.cpp unittests/clangd/ClangdTests.cpp Index: unittest

[PATCH] D51747: [clangd] Show deprecation diagnostics

kadircet added a comment. In https://reviews.llvm.org/D51747#1233530, @ilya-biryukov wrote: > In https://reviews.llvm.org/D51747#1233499, @kadircet wrote: > > > Np, not planning to land it before we figure out the issue with vim can't > > handling lots of diagnostics anyway. > > > Just wondering

[PATCH] D52089: [clangd] Get rid of AST matchers in SymbolCollector. NFC

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52089 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lis

[PATCH] D50193: Added functionality to suggest FixIts for conversion of '->' to '.' and vice versa.

kadircet created this revision. kadircet added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, arphaman, jkorous, ioeric. Added functionality to suggest FixIts for conversion of '->' to '.' and vice versa. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D50193

[PATCH] D50193: Added functionality to suggest FixIts for conversion of '->' to '.' and vice versa.

kadircet updated this revision to Diff 159000. kadircet marked 8 inline comments as done. kadircet added a comment. Fixed discussions https://reviews.llvm.org/D50193 Files: clangd/CodeComplete.cpp clangd/CodeComplete.h clangd/Diagnostics.cpp clangd/Protocol.h clangd/SourceCode.cpp c

[PATCH] D50193: Added functionality to suggest FixIts for conversion of '->' to '.' and vice versa.

kadircet updated this revision to Diff 159261. kadircet marked 4 inline comments as done. kadircet added a comment. Added functionality to suggest FixIts for conversion of '->' to '.' and vice versa. - Fixes for comments. - Take unnecessary patches back - Second pass for comments. - Add downrank

[PATCH] D43303: [Format] Fix for bug 35641

kadircet created this revision. kadircet added reviewers: rsmith, djasper. kadircet added a project: clang. Herald added a subscriber: cfe-commits. Bug was caused due to comments at the start of scope. For a code like: int func() { // int b; int c; } the comment at the first line get

[PATCH] D43303: [Format] Fix for bug 35641

kadircet updated this revision to Diff 134414. kadircet added a comment. Changed description of unit test to include direct link to bug. Used different variable types to make sure alignment happens. Repository: rC Clang https://reviews.llvm.org/D43303 Files: unittests/Format/FormatTest.cpp

[PATCH] D43303: [Format] Fix for bug 35641

kadircet added a comment. Btw, I cannot commit the change myself, don't have commit rights. Repository: rC Clang https://reviews.llvm.org/D43303 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinf

[PATCH] D43303: [Format] Fix for bug 35641

kadircet updated this revision to Diff 134830. kadircet added a comment. Rebased and uploaded diff to the master. Sorry for the inconvenience. Repository: rC Clang https://reviews.llvm.org/D43303 Files: lib/Format/WhitespaceManager.cpp unittests/Format/FormatTest.cpp Index: unittests/F

[PATCH] D43303: [Format] Fix for bug 35641

kadircet added a comment. ping Repository: rC Clang https://reviews.llvm.org/D43303 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D53070: [CodeComplete] Fix crash when completing params function declarations.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rC Clang https://reviews.llvm.org/D53070 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.ll

[PATCH] D53186: [clangd] Support hover on "aut^o *".

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D53186 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D53191: [clang] Use Statement and Namespace instead of Name and PotentiallyQualifiedName

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added a subscriber: cfe-commits. New name suggestion contexts were being used in cases they were not suitable. This patch changes those contexts into more suitable ones. Repository: rC Clang https://reviews.llvm.org/

[PATCH] D53192: [clangd] Do not query index for new name completions.

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ioeric, ilya-biryukov. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D53192 Files: clangd/CodeComplete.cpp unittests/clangd/CodeCompleteTe

[PATCH] D53191: [clang] Use Statement and Namespace instead of Name and PotentiallyQualifiedName

kadircet updated this revision to Diff 169374. kadircet added a comment. - Use statement as context for using decls. Repository: rC Clang https://reviews.llvm.org/D53191 Files: lib/Sema/SemaCodeComplete.cpp test/CodeCompletion/ordinary-name.c Index: test/CodeCompletion/ordinary-name.c

[PATCH] D53213: [clangd] Send CodeAction responses to textDocument/codeAction (LSP 3.8)

kadircet added inline comments. Comment at: clangd/ClangdLSPServer.cpp:338 + Command Cmd; + if (Action.command && Action.edit) +return llvm::None; What would you think about emitting two commands in this case? First the edit and then the command. I believe

[PATCH] D53213: [clangd] Send CodeAction responses to textDocument/codeAction (LSP 3.8)

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: clangd/ClangdLSPServer.cpp:338 + Command Cmd; + if (Action.command && Action.edit) +return llvm::None; sammccall wrote: >

[PATCH] D53266: [clangd] Simplify client capabilities parsing.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, thanks for the change! Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D53266 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D52301: [clang] Set TypeSourceInfo for vardecl's in addition to type when we can deduce.

kadircet updated this revision to Diff 169885. kadircet added a comment. Herald added a subscriber: nhaehnle. rebase Repository: rC Clang https://reviews.llvm.org/D52301 Files: include/clang/AST/PrettyPrinter.h include/clang/Basic/DiagnosticSemaKinds.td include/clang/Sema/Sema.h lib/

[PATCH] D52301: [clang] Set TypeSourceInfo for vardecl's in addition to type when we can deduce.

kadircet added a comment. In https://reviews.llvm.org/D52301#1263275, @aaron.ballman wrote: > Can you give a bit more background on what problem you're trying to solve > with this patch? Sorry for the lack of context, it was about an offline discussion on `Sema::DeduceVariableDeclarationType`

[PATCH] D53347: [clangd] Simplify auto hover

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, it bugs me that some part in the documentation says it doesn't go through decltype(`This looks through declarators like pointer types, but not through decltype or typedefs`) but sinc

[PATCH] D52301: [clang] Set TypeSourceInfo for vardecl's in addition to type when we can deduce.

kadircet updated this revision to Diff 170215. kadircet added a comment. - Keep only relavant changes and rebase Repository: rC Clang https://reviews.llvm.org/D52301 Files: include/clang/AST/PrettyPrinter.h include/clang/Sema/Sema.h lib/AST/TypePrinter.cpp lib/Frontend/ASTConsumers.c

[PATCH] D53406: [clangd] Provide excuses for bad code completions, based on diagnostics. C++ API only.

kadircet added inline comments. Comment at: clangd/CodeComplete.cpp:700 + unsigned DiagLoc = Loc.second; + if (DiagLoc < StartOfLine || DiagLoc > Offset) + return; There are also a lot of cases where we can't find an include file(usually due to con

[PATCH] D53561: [clang] Fix a null pointer dereference.

kadircet created this revision. kadircet added reviewers: sammccall, ioeric, hokein. Herald added a subscriber: cfe-commits. Sometimes expression inside switch statement can be invalid, for example type might be incomplete. In those cases code were causing a null pointer dereference. This patch fi

[PATCH] D53561: [clang] Fix a null pointer dereference.

kadircet updated this revision to Diff 170608. kadircet added a comment. Herald added a subscriber: arphaman. - Add tests. Repository: rC Clang https://reviews.llvm.org/D53561 Files: lib/Sema/SemaCodeComplete.cpp test/Index/complete-switch.c Index: test/Index/complete-switch.c

[PATCH] D53192: [clangd] Do not query index for new name completions.

kadircet updated this revision to Diff 170626. kadircet added a comment. - Rebase and take in new changes. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D53192 Files: clangd/CodeComplete.cpp clangd/index/SymbolCollector.cpp unittests/clangd/CodeCompleteTests.cpp Index:

[PATCH] D53191: [clang] Use Statement and Namespace instead of Name and PotentiallyQualifiedName

kadircet updated this revision to Diff 170628. kadircet added a comment. Herald added a subscriber: arphaman. - Use new types - Rebase Repository: rC Clang https://reviews.llvm.org/D53191 Files: include/clang/Sema/CodeCompleteConsumer.h lib/Frontend/ASTUnit.cpp lib/Sema/CodeCompleteCon

[PATCH] D53191: [clang] Introduce new completion context types

kadircet added a comment. There are still some contexts where both a new name and an existing name is permissible, going to add a comment on those to leave some traces for the next person who cares Repository: rC Clang https://reviews.llvm.org/D53191 _

[PATCH] D53191: [clang] Introduce new completion context types

kadircet updated this revision to Diff 170631. kadircet added a comment. - Add comments. Repository: rC Clang https://reviews.llvm.org/D53191 Files: include/clang/Sema/CodeCompleteConsumer.h lib/Frontend/ASTUnit.cpp lib/Sema/CodeCompleteConsumer.cpp lib/Sema/SemaCodeComplete.cpp to

[PATCH] D53561: [clang] Fix a null pointer dereference.

This revision was automatically updated to reflect the committed changes. Closed by commit rL345029: [clang] Fix a null pointer dereference. (authored by kadircet, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D53561 Files: cfe/trunk/l

[PATCH] D53192: [clangd] Do not query index for new name completions.

kadircet updated this revision to Diff 170634. kadircet marked 2 inline comments as done. kadircet added a comment. - Address comments. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D53192 Files: clangd/CodeComplete.cpp clangd/index/SymbolCollector.cpp unittests/clangd/Co

[PATCH] D53192: [clangd] Do not query index for new name completions.

kadircet updated this revision to Diff 170678. kadircet added a comment. - Use new enum types. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D53192 Files: clangd/CodeComplete.cpp clangd/index/SymbolCollector.cpp unittests/clangd/CodeCompleteTests.cpp Index: unittests/cl

[PATCH] D53191: [clang] Introduce new completion context types

kadircet updated this revision to Diff 170677. kadircet marked 2 inline comments as done. kadircet added a comment. - Use Symol, SymbolOrNewName, NewName - Address comments. Repository: rC Clang https://reviews.llvm.org/D53191 Files: include/clang/Sema/CodeCompleteConsumer.h lib/Frontend

[PATCH] D53191: [clang] Introduce new completion context types

kadircet marked 2 inline comments as done. kadircet added inline comments. Comment at: include/clang/Sema/CodeCompleteConsumer.h:277 + +/// Code completion occurred where an existing name is expected. +CCC_ExistingName, sammccall wrote: > It's not obvious

[PATCH] D53191: [clang] Introduce new completion context types

kadircet updated this revision to Diff 170829. kadircet marked an inline comment as done. kadircet added a comment. - Update comment. Repository: rC Clang https://reviews.llvm.org/D53191 Files: include/clang/Sema/CodeCompleteConsumer.h lib/Frontend/ASTUnit.cpp lib/Sema/CodeCompleteCons

[PATCH] D53191: [clang] Introduce new completion context types

kadircet added a comment. Since it doesn't change any CXCompletionContext's in CIndex it doesn't seem possible. There are tests being added to clangd(https://reviews.llvm.org/D53192), since it uses context provided by sema to decide whether query the index or not, we can check the behavior. R

[PATCH] D53647: [clangd] When replying, log the method name and latency.

kadircet added a comment. LG, thanks! Comment at: clangd/ClangdLSPServer.cpp:218 +log("--> reply:{0}({1}) {2:ms}", Method, ID, Duration); +std::lock_guard Lock(Server->TranspWriter); +if (TraceArgs) Move locking below to not lock while c

[PATCH] D53192: [clangd] Do not query index for new name completions.

kadircet updated this revision to Diff 170900. kadircet marked an inline comment as done. kadircet added a comment. - Change symbols name to get a match from index. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D53192 Files: clangd/CodeComplete.cpp clangd/index/SymbolCollec

[PATCH] D53192: [clangd] Do not query index for new name completions.

kadircet added inline comments. Comment at: unittests/clangd/CodeCompleteTests.cpp:2180 + clangd::CodeCompleteOptions Opts; + Opts.AllScopes = true; + auto Results = completions(R"cpp( sammccall wrote: > Any need to actually enable this option, or just copied

[PATCH] D53191: [clang] Introduce new completion context types

This revision was automatically updated to reflect the committed changes. Closed by commit rC345152: [clang] Introduce new completion context types (authored by kadircet, committed by ). Changed prior to commit: https://reviews.llvm.org/D53191?vs=170829&id=170901#toc Repository: rC Clang ht

[PATCH] D53192: [clangd] Do not query index for new name completions.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE345153: [clangd] Do not query index for new name completions. (authored by kadircet, committed by ). Changed prior to commit: https://reviews.llvm.org/D53192?vs=170900&id=170902#toc Repository: rCT

[PATCH] D53651: [clangd] Use thread pool for background indexing.

kadircet created this revision. kadircet added reviewers: sammccall, ioeric. Herald added subscribers: cfe-commits, jfb, arphaman, jkorous, MaskRay, ilya-biryukov. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D53651 Files: clangd/index/Background.cpp clangd/index/Background

[PATCH] D53654: [clang] Improve ctor initializer completions.

kadircet created this revision. kadircet added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, arphaman, eraman. Instead of providing generic "args" for member and bas class initializations, tries to fetch relevant constructors and show their signatures. Repository: rC Clang

[PATCH] D53654: [clang] Improve ctor initializer completions.

kadircet added inline comments. Comment at: lib/Sema/SemaCodeComplete.cpp:5101 +const auto *ND = Base.getType()->getAsCXXRecordDecl(); +if (isa(ND) || +isa(ND)) { ilya-biryukov wrote: > Why special-case the template specializations? > Are we tryin

[PATCH] D53654: [clang] Improve ctor initializer completions.

kadircet added inline comments. Comment at: lib/Sema/SemaCodeComplete.cpp:5101 +const auto *ND = Base.getType()->getAsCXXRecordDecl(); +if (isa(ND) || +isa(ND)) { kadircet wrote: > ilya-biryukov wrote: > > Why special-case the template specializat

[PATCH] D53654: [clang] Improve ctor initializer completions.

kadircet updated this revision to Diff 171077. kadircet marked 7 inline comments as done. kadircet added a comment. - Address comments. Repository: rC Clang https://reviews.llvm.org/D53654 Files: include/clang/Sema/CodeCompleteConsumer.h lib/Sema/SemaCodeComplete.cpp test/CodeCompletio

[PATCH] D53654: [clang] Improve ctor initializer completions.

kadircet updated this revision to Diff 171099. kadircet marked an inline comment as done. kadircet added a comment. - Use addConstructorResult. Repository: rC Clang https://reviews.llvm.org/D53654 Files: include/clang/Sema/CodeCompleteConsumer.h lib/Sema/SemaCodeComplete.cpp test/CodeC

[PATCH] D53651: [clangd] Use thread pool for background indexing.

kadircet added a comment. Moving forward with priorities then. Comment at: clangd/index/Background.cpp:89 } - QueueCV.notify_all(); + QueueCV.notify_one(); } sammccall wrote: > I always forget the details of how these work :-\ > Is it possible for the "on

[PATCH] D53654: [clang] Improve ctor initializer completions.

kadircet updated this revision to Diff 171259. kadircet added a comment. - Add a generic constructor if found none. - format && add comments. - Add generic constructors to tests. Repository: rC Clang https://reviews.llvm.org/D53654 Files: include/clang/Sema/CodeCompleteConsumer.h lib/Sem

[PATCH] D53654: [clang] Improve ctor initializer completions.

kadircet updated this revision to Diff 171516. kadircet marked 5 inline comments as done. kadircet added a comment. - Address comments & offline discussions. Repository: rC Clang https://reviews.llvm.org/D53654 Files: lib/Sema/SemaCodeComplete.cpp test/CodeCompletion/ctor-initializer.cpp

[PATCH] D53651: [clangd] Use thread pool for background indexing.

kadircet updated this revision to Diff 171527. kadircet added a comment. - Use notify_all. - Use priorities. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D53651 Files: clangd/Threading.cpp clangd/Threading.h clangd/index/Background.cpp clangd/index/Background.h Index:

[PATCH] D53654: [clang] Improve ctor initializer completions.

kadircet added inline comments. Comment at: lib/Sema/SemaCodeComplete.cpp:5135 + }; + auto AddDefaultCtorInit = [&](const char *TypedName, +const char *TypeName, ZaMaZaN4iK wrote: > Is it good idea to capture ALL by reference? Pr

[PATCH] D53651: [clangd] Use thread pool for background indexing.

kadircet updated this revision to Diff 171655. kadircet marked 14 inline comments as done. kadircet added a comment. - Address comments && Use ThreadPool Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D53651 Files: clangd/Threading.cpp clangd/Threading.h clangd/index/Backg

[PATCH] D53651: [clangd] Use thread pool for background indexing.

kadircet added inline comments. Comment at: clangd/Threading.cpp:102 +void setThreadPriority(std::thread &T, ThreadPriority Priority) { +#ifdef HAVE_PTHREAD_H + sched_param priority; sammccall wrote: > don't you also need to actually include it? Turns out it was

[PATCH] D53651: [clangd] Use thread pool for background indexing.

kadircet updated this revision to Diff 171658. kadircet added a comment. - Delete outdated comment. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D53651 Files: clangd/Threading.cpp clangd/Threading.h clangd/index/Background.cpp clangd/index/Background.h Index: clangd/i

[PATCH] D53651: [clangd] Use thread pool for background indexing.

kadircet updated this revision to Diff 171672. kadircet added a comment. - Address comments. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D53651 Files: clangd/Threading.cpp clangd/Threading.h clangd/index/Background.cpp clangd/index/Background.h Index: clangd/index/Ba

[PATCH] D53651: [clangd] Use thread pool for background indexing.

kadircet updated this revision to Diff 171675. kadircet marked 2 inline comments as done. kadircet added a comment. - Add comment. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D53651 Files: clangd/Threading.cpp clangd/Threading.h clangd/index/Background.cpp clangd/inde

[PATCH] D53651: [clangd] Use thread pool for background indexing.

kadircet added inline comments. Comment at: clangd/Threading.cpp:101 +void setThreadPriority(std::thread &T, ThreadPriority Priority) { +#ifdef HAVE_PTHREAD_H ilya-biryukov wrote: > Maybe put this helper into `llvm/Support/Threading.h`? We talked with Sam about

[PATCH] D53651: [clangd] Use thread pool for background indexing.

kadircet updated this revision to Diff 171676. kadircet marked an inline comment as done. kadircet added a comment. - Format the code. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D53651 Files: clangd/Threading.cpp clangd/Threading.h clangd/index/Background.cpp clangd/

[PATCH] D53651: [clangd] Use thread pool for background indexing.

This revision was automatically updated to reflect the committed changes. Closed by commit rL345590: [clangd] Use thread pool for background indexing. (authored by kadircet, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D53651 Files: c

[PATCH] D53654: [clang] Improve ctor initializer completions.

kadircet updated this revision to Diff 171703. kadircet marked 8 inline comments as done. kadircet added a comment. - Address comments. Repository: rC Clang https://reviews.llvm.org/D53654 Files: lib/Sema/SemaCodeComplete.cpp test/CodeCompletion/ctor-initializer.cpp test/Index/complete

[PATCH] D53654: [clang] Improve ctor initializer completions.

kadircet added inline comments. Comment at: lib/Sema/SemaCodeComplete.cpp:821 + +DeclContext::lookup_result getConstructorResults(ASTContext &Context, + const CXXRecordDecl *Record, ilya-biryukov wrote: > There's a

[PATCH] D53433: [clangd] auto-index stores symbols per-file instead of per-TU.

kadircet added inline comments. Comment at: clangd/index/SymbolCollector.cpp:619 + shouldIndexFile(SM, SM.getFileID(Loc), Opts, &FilesToIndexCache); + if (auto DefLoc = getTokenLocation(Loc, ND.getASTContext().getSourceManager(), Opts, AST

[PATCH] D53654: [clang] Improve ctor initializer completions.

kadircet updated this revision to Diff 171899. kadircet marked 8 inline comments as done. kadircet added a comment. - Address comments. Repository: rC Clang https://reviews.llvm.org/D53654 Files: lib/Sema/SemaCodeComplete.cpp test/CodeCompletion/ctor-initializer.cpp test/Index/complete

[PATCH] D53654: [clang] Improve ctor initializer completions.

kadircet added inline comments. Comment at: lib/Sema/SemaCodeComplete.cpp:5136 + auto AddDefaultCtorInit = [&](const char *TypedName, +const char *TypeName, +const NamedDecl* ND) { ilya-biryukov wro

[PATCH] D56592: [clangd] Do not override contents of the shards without modification

kadircet created this revision. kadircet added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ioeric. We were writing shards with empty symbol and ref slabs whenever there were no change in the file. Just skip the shards that has up-to-date content.

[PATCH] D56656: [clangd] Fix a reference invalidation

kadircet created this revision. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ioeric, ilya-biryukov. Fix for the breakage in http://green.lab.llvm.org/green/job/clang-stage1-configure-RA/52811/consoleFull#-42777206a1ca8a51-895e-46c6-af87-ce24fa4cd561 Repository: rCTE Cla

[PATCH] D56656: [clangd] Fix a reference invalidation

kadircet updated this revision to Diff 181512. kadircet added a comment. - Change traversal logic to use two different containers Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56656/new/ https://reviews.llvm.org/D56656 Files: clangd/index/Backgro

[PATCH] D56656: [clangd] Fix a reference invalidation

kadircet updated this revision to Diff 181524. kadircet added a comment. - Add a comment Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56656/new/ https://reviews.llvm.org/D56656 Files: clangd/index/Background.cpp Index: clangd/index/Background.

[PATCH] D56656: [clangd] Fix a reference invalidation

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE351052: [clangd] Fix a reference invalidation (authored by kadircet, committed by ). Changed prior to commit: https://reviews.llvm.org/D56656?vs=181524&id=181525#toc Repository: rCTE Clang Tools Ex

[PATCH] D56592: [clangd] Do not override contents of the shards without modification

kadircet updated this revision to Diff 181540. kadircet marked an inline comment as done. kadircet added a comment. - Change the logic to detect updated files to take new files without any symbols into account. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D56592: [clangd] Fix updated file detection logic in indexing

kadircet added inline comments. Comment at: clangd/index/Background.cpp:309 for (const auto &I : *Index.Sources) { +// We already have the map from uris to absolutepaths in the cache, +// therefore traverse Index.Sources rather than Files to get rid of absolute --

[PATCH] D56655: [clangd] Fix mac buildbot failure.

kadircet added a comment. https://reviews.llvm.org/D56656 has landed to fix that issue Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56655/new/ https://reviews.llvm.org/D56655 ___ cfe-commits mailing li

[PATCH] D56592: [clangd] Fix updated file detection logic in indexing

kadircet updated this revision to Diff 181544. kadircet added a comment. - Change FileFilter and update logic to do not care about if there are any symbols coming from a file. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56592/new/ https://reviews

[PATCH] D56592: [clangd] Fix updated file detection logic in indexing

kadircet updated this revision to Diff 181545. kadircet added a comment. - Update comments Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56592/new/ https://reviews.llvm.org/D56592 Files: clangd/index/Background.cpp clangd/index/Background.h u

[PATCH] D56592: [clangd] Fix updated file detection logic in indexing

kadircet updated this revision to Diff 181735. kadircet marked 6 inline comments as done. kadircet added a comment. - Address comments Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56592/new/ https://reviews.llvm.org/D56592 Files: clangd/index/Ba

[PATCH] D56592: [clangd] Fix updated file detection logic in indexing

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE351170: [clangd] Fix updated file detection logic in indexing (authored by kadircet, committed by ). Changed prior to commit: https://reviews.llvm.org/D56592?vs=181735&id=181736#toc Repository: rCT

[PATCH] D56718: [clangd] Update docs to mention YCM integration and new LSP features

kadircet created this revision. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ioeric, ilya-biryukov. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D56718 Files: docs/clangd.rst Index: docs/clangd.rst ==

[PATCH] D56718: [clangd] Update docs to mention YCM integration and new LSP features

kadircet marked an inline comment as done. kadircet added inline comments. Comment at: docs/clangd.rst:129 +`Installation section on your OS +`_ for instructions. + ilya-biryukov wrote: > I believe this does

[PATCH] D56841: [clangd] Filter out plugin related flags.

kadircet created this revision. kadircet added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ioeric. Some projects make use of clang plugins when building, but clangd is not aware of those plugins therefore can't work with the same compile command ar

[PATCH] D56723: [CodeComplete] Propagate preferred types through parser in more cases

kadircet added a comment. That really looks awesome, thanks! One general comment: I am not really sure if the handling done in `ParseCastExpression` is extensive enough. But IIUC, this should not cause any regressions, rather should result in missing preferred types just as before this patch ?

[PATCH] D56841: [clangd] Filter out plugin related flags.

kadircet marked 3 inline comments as done. kadircet added a comment. It seems like the most relevant place in tooling is ArgumentsAdjuster as @ioeric pointed out. Happy to move it to there if @sammccall and @klimek agrees as well. As a side note `ArgumentsAdjuster`s unfortunately causes a copy

[PATCH] D56841: [clangd] Filter out plugin related flags.

kadircet updated this revision to Diff 182260. kadircet marked an inline comment as done. kadircet added a comment. - Address comments Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56841/new/ https://reviews.llvm.org/D56841 Files: clangd/ClangdUn

<    1   2   3   4   5   6   7   8   9   10   >