[PATCH] D100810: [llvm] Use `GNUInstallDirs` to support custom installation dirs

Ericson2314 updated this revision to Diff 396822. Ericson2314 added a comment. Big rebase and cleanup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100810/new/ https://reviews.llvm.org/D100810 Files: llvm/CMakeLists.txt llvm/cmake/modules/AddL

[PATCH] D100810: [llvm] Use `GNUInstallDirs` to support custom installation dirs

Ericson2314 updated this revision to Diff 396824. Ericson2314 added a comment. 1. Updating D100810 : [llvm] Use `GNUInstallDirs` to support custom installation dirs # 2. Enter a brief description of the changes included in this update. 3. The first line is used

[PATCH] D100810: [llvm] Use `GNUInstallDirs` to support custom installation dirs

Ericson2314 updated this revision to Diff 396825. Ericson2314 added a comment. 1. Updating D100810 : [llvm] Use `GNUInstallDirs` to support custom installation dirs # 2. Enter a brief description of the changes included in this update. 3. The first line is used

[PATCH] D100810: [llvm] Use `GNUInstallDirs` to support custom installation dirs

Ericson2314 updated this revision to Diff 396831. Ericson2314 added a comment. 1. Updating D100810 : [llvm] Use `GNUInstallDirs` to support custom installation dirs # 2. Enter a brief description of the changes included in this update. 3. The first line is used

[PATCH] D100810: [llvm] Use `GNUInstallDirs` to support custom installation dirs

Ericson2314 updated this revision to Diff 396846. Ericson2314 added a comment. 1. Updating D100810 : [llvm] Use `GNUInstallDirs` to support custom installation dirs # 2. Enter a brief description of the changes included in this update. 3. The first line is used

[PATCH] D116492: [lld] Deprecate using llvm-config to detect llvm installation

Ericson2314 created this revision. Ericson2314 added a reviewer: tstellar. Herald added a subscriber: mgorny. Ericson2314 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is continuing in the path of D51714

[PATCH] D116492: [lld] Deprecate using llvm-config to detect llvm installation

Ericson2314 added a comment. Note this is a first draft, I need to go test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116492/new/ https://reviews.llvm.org/D116492 ___ cfe-commits mailing list cfe-com

[PATCH] D114064: [clang] [MinGW] Pass --no-demangle through to the mingw linker

Ericson2314 accepted this revision. Ericson2314 added a comment. This revision is now accepted and ready to land. Not sure what the exact division of labor is between the GNU and MinGW backends, but assuming there is no way to share this between them the patch looks good. Repository: rG LLVM

[PATCH] D100810: [llvm] Use `GNUInstallDirs` to support custom installation dirs

Ericson2314 marked 2 inline comments as done. Ericson2314 added a comment. Mark some old threads done. Comment at: llvm/cmake/modules/CMakeLists.txt:3 -set(LLVM_INSTALL_PACKAGE_DIR lib${LLVM_LIBDIR_SUFFIX}/cmake/llvm) +set(LLVM_INSTALL_PACKAGE_DIR lib${LLVM_LIBDIR_SUFFIX}/cma

[PATCH] D100810: [llvm] Use `GNUInstallDirs` to support custom installation dirs

Ericson2314 updated this revision to Diff 396872. Ericson2314 added a comment. 1. Updating D100810 : [llvm] Use `GNUInstallDirs` to support custom installation dirs # 2. Enter a brief description of the changes included in this update. 3. The first line is used

[PATCH] D116521: [llvm][clang][cmake] Factor out config prefix finding logic

Ericson2314 created this revision. Ericson2314 added reviewers: mstorsjo, beanz. Herald added a subscriber: mgorny. Ericson2314 requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. See the docs in the new function for details.

[PATCH] D116521: [llvm][clang][cmake] Factor out config prefix finding logic

Ericson2314 updated this revision to Diff 397010. Ericson2314 added a comment. Fix arg order error in Clang Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116521/new/ https://reviews.llvm.org/D116521 Files: clang/CMakeLists.txt clang/cmake/modu

[PATCH] D116521: [llvm][clang][cmake] Factor out config prefix finding logic

Ericson2314 updated this revision to Diff 397015. Ericson2314 added a comment. Herald added a reviewer: sscalpone. Herald added a project: Flang. Oh, Flang and LLD are the same. Just do them now then Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116

[PATCH] D100810: [llvm] Use `GNUInstallDirs` to support custom installation dirs

Ericson2314 updated this revision to Diff 396972. Ericson2314 added a comment. Remove off topic bits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100810/new/ https://reviews.llvm.org/D100810 Files: llvm/CMakeLists.txt llvm/cmake/modules/AddLL

[PATCH] D100810: [llvm] Use `GNUInstallDirs` to support custom installation dirs

Ericson2314 marked 4 inline comments as done. Ericson2314 added inline comments. Comment at: llvm/CMakeLists.txt:75 set(LLVM_ENABLE_PROJECTS "" CACHE STRING - "Semicolon-separated list of projects to build (${LLVM_KNOWN_PROJECTS}), or \"all\".") + "Semicolon-separated l

[PATCH] D116492: [lld] Deprecate using llvm-config to detect llvm installation

Ericson2314 added inline comments. Comment at: clang/CMakeLists.txt:26 "--src-root" - "--cmakedir") + "--cmakedir" + "--bindir" beanz wrote: > I assume these are re-arranged to match what you're doing in lld. Is that > correct? > > General

[PATCH] D116548: [clang][cmake] Rearrange top-level CMakeLists.txt for D116492

Ericson2314 created this revision. Ericson2314 added reviewers: beanz, tstellar. Herald added a subscriber: mgorny. Ericson2314 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In that revision, I make LLD match Clang in deprecating `llvm-co

[PATCH] D116492: [lld] Deprecate using llvm-config to detect llvm installation

Ericson2314 updated this revision to Diff 397100. Ericson2314 added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Split out Clang changes into separate commit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116492/n

[PATCH] D116492: [lld] Deprecate using llvm-config to detect llvm installation

Ericson2314 marked 2 inline comments as done. Ericson2314 added inline comments. Comment at: clang/CMakeLists.txt:26 "--src-root" - "--cmakedir") + "--cmakedir" + "--bindir" beanz wrote: > Ericson2314 wrote: > > beanz wrote: > > > I assume t

[PATCH] D116492: [lld] Deprecate using llvm-config to detect llvm installation

Ericson2314 marked an inline comment as done. Ericson2314 added inline comments. Comment at: clang/CMakeLists.txt:26 "--src-root" - "--cmakedir") + "--cmakedir" + "--bindir" Ericson2314 wrote: > beanz wrote: > > Ericson2314 wrote: > > > bean

[PATCH] D116548: [clang][cmake] Rearrange top-level CMakeLists.txt for D116492

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa3ab2c94a271: [clang][cmake] Rearrange top-level CMakeLists.txt for D116492 (authored by Ericson2314). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D116548: [clang][cmake] Rearrange top-level CMakeLists.txt for D116492

Ericson2314 added a comment. (Note to posterity: I didn't wait for the build to finish because the last night's D116492 build already demonstrated this diff did not break things.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D116492: [lld] Deprecate using llvm-config to detect llvm installation

Ericson2314 added inline comments. Comment at: lld/CMakeLists.txt:17 - execute_process(COMMAND "${LLVM_CONFIG_PATH}" - "--obj-root" - "--includedir" `--obj-root` is the same thing as `--prefix`, so this is in fac

[PATCH] D116521: [llvm][clang][flang][lld][cmake] Factor out config prefix finding logic

Ericson2314 updated this revision to Diff 397114. Ericson2314 added a comment. Herald added subscribers: sdasgup3, wenzhicui, wrengr, Chia-hungDuan, dcaballe, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, stephenneuendorffer, liufengdb, aartbik, lucyrfox,

[PATCH] D116521: [CMake] Factor out config prefix finding logic

Ericson2314 updated this revision to Diff 397116. Ericson2314 added a comment. Oops, forgot some includes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116521/new/ https://reviews.llvm.org/D116521 Files: clang/CMakeLists.txt clang/cmake/module

[PATCH] D116521: [CMake] Factor out config prefix finding logic

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG44e336577510: [CMake] Factor out config prefix finding logic (authored by Ericson2314). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D100810: [llvm] Use `GNUInstallDirs` to support custom installation dirs

Ericson2314 updated this revision to Diff 398219. Ericson2314 marked 4 inline comments as done. Ericson2314 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100810/new/ https://reviews.llvm.org/D100810 Files: llvm/CMakeLists

[PATCH] D116492: [lld] Deprecate using llvm-config to detect llvm installation

This revision was automatically updated to reflect the committed changes. Closed by commit rGa1da5f3c2d65: [lld] Deprecate using llvm-config to detect llvm installation (authored by Ericson2314). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116492/n

[PATCH] D100810: [llvm] Use `GNUInstallDirs` to support custom installation dirs

Ericson2314 added a comment. OK, at long last, I this is the attempt that's gonna make it! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100810/new/ https://reviews.llvm.org/D100810 ___ cfe-commits maili

[PATCH] D100810: [llvm] Use `GNUInstallDirs` to support custom installation dirs

Ericson2314 added inline comments. Comment at: llvm/cmake/modules/AddSphinxTarget.cmake:1 include(GNUInstallDirs) N.B. this already had it from an earlier revision of mine, so didn't need to add it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D100810: [llvm] Use `GNUInstallDirs` to support custom installation dirs

This revision was automatically updated to reflect the committed changes. Closed by commit rGfeeff8a37c35: [llvm] Use `GNUInstallDirs` to support custom installation dirs (authored by Ericson2314). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100810

[PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 updated this revision to Diff 398318. Ericson2314 added a comment. Rebase on top of fixed polly Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99484/new/ https://reviews.llvm.org/D99484 Files: clang-tools-extra/clang-doc/tool/CMakeLis

[PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 updated this revision to Diff 398366. Ericson2314 added a comment. Make sure possibly exposed modules have their own `include(GNUInstallDirs)`s Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99484/new/ https://reviews.llvm.org/D99484 Fi

[PATCH] D99484: [cmake] Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 updated this revision to Diff 398857. Ericson2314 added a comment. Fix conflicts, one more thing for openmp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99484/new/ https://reviews.llvm.org/D99484 Files: clang-tools-extra/CMakeLists.

[PATCH] D99484: [cmake] Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 updated this revision to Diff 399020. Ericson2314 added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99484/new/ https://reviews.llvm.org/D99484 Files: clang-tools-extra/CMakeLists.txt clang-tools-extra/clang-doc/

[PATCH] D99484: [cmake] Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 updated this revision to Diff 399096. Ericson2314 added a comment. Retrigger CI now that deps are fixed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99484/new/ https://reviews.llvm.org/D99484 Files: clang-tools-extra/CMakeLists.txt

[PATCH] D99484: [cmake] Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 updated this revision to Diff 399883. Ericson2314 added a comment. Rebase after landing the polly change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99484/new/ https://reviews.llvm.org/D99484 Files: clang-tools-extra/CMakeLists.txt

[PATCH] D99484: [cmake] Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 marked 10 inline comments as done. Ericson2314 added a comment. The approval on this patch is quite old, but nothing much interesting has happened in it since then --- if anything, it has gotten more trivial as I created patches "under" it and landed them which cleared the way for th

[PATCH] D99484: [cmake] Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 marked 3 inline comments as done. Ericson2314 added inline comments. Comment at: polly/cmake/CMakeLists.txt:85 +set(POLLY_CONFIG_CMAKE_DIR "${POLLY_INSTALL_PREFIX}${CMAKE_INSTALL_PREFIX}/${POLLY_INSTALL_PACKAGE_DIR}") +set(POLLY_CONFIG_LIBRARY_DIRS "${POLLY_INSTALL_

[PATCH] D99484: [cmake] Use `GNUInstallDirs` to support custom installation dirs.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Ericson2314 marked an inline comment as done. Closed by commit rGefeb50197091: [cmake] Use `GNUInstallDirs` to support custom installation dirs. (authored by Ericson231

[PATCH] D99484: [cmake] Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 added a comment. Sorry about that. I think the issue was just one more `include(GNUInstallDirs)` for compiler-rt for the standalone build, but I am going to bed so just reverted for now to try again later. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D99484: [cmake] Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 reopened this revision. Ericson2314 added a comment. This revision is now accepted and ready to land. Found two more `include(GNUInstallDirs)` I should include which will hopefully fix the build. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D99484: [cmake] Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 updated this revision to Diff 400253. Ericson2314 added a comment. Try again, with more `include(GNUInstallDirs)` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99484/new/ https://reviews.llvm.org/D99484 Files: clang-tools-extra/CMake

[PATCH] D99484: [cmake] Use `GNUInstallDirs` to support custom installation dirs.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4a678f807200: [cmake] Use `GNUInstallDirs` to support custom installation dirs. (authored by Ericson2314). Repository: rG LLVM Github Monorepo CH

[PATCH] D99484: [cmake] Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 reopened this revision. Ericson2314 added a comment. This revision is now accepted and ready to land. Will try to break up the pathc further for better troubleshooting, but keeping this open to track progress. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D117419: [clang][cmake] Use `GNUInstallDirs` to support custom installation dirs

Ericson2314 created this revision. Herald added subscribers: arphaman, whisperity, mgorny. Ericson2314 requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. I am breaking apart D99484 so the cau

[PATCH] D99484: [cmake] Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 added a comment. OK I split out D117417 , D117418 , D117419 , and D117420 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D117419: [clang][cmake] Use `GNUInstallDirs` to support custom installation dirs

Ericson2314 updated this revision to Diff 400419. Ericson2314 added a comment. 1. Updating D117419 : [clang][cmake] Use `GNUInstallDirs` to support custom installation dirs # 2. Enter a brief description of the changes included in this update. 3. The first line i

[PATCH] D116521: [CMake] Factor out config prefix finding logic

Ericson2314 added inline comments. Comment at: llvm/CMakeLists.txt:209 "${CMAKE_CURRENT_SOURCE_DIR}/cmake/modules" + "${LLVM_COMMON_CMAKE_UTILS}/Modules" ) sebastian-ne wrote: > Hi, adding this module path overwrites the `llvm_check_linker_flag` from > `l

[PATCH] D115403: [clang][driver] update the darwin driver to point to correct macho_embedded path

Ericson2314 accepted this revision. Ericson2314 added a comment. This revision is now accepted and ready to land. Looks good. Thanks for fixing this for me! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115403/new/ https://reviews.llvm.org/D115403

[PATCH] D100810: Use `GNUInstallDirs` to support custom installation dirs. -- LLVM

Ericson2314 added a comment. @mib Can you help me reproduce? I ran cmake -G Ninja .. -DCMAKE_EXPORT_COMPILE_COMMANDS=ON -DCMAKE_INSTALL_PREFIX="$HOME/tmp/out" -DLLDB_TEST_USER_ARGS="--arch;x86_64;--build-dir;$HOME/tmp/out/lldb-test-build.noindex;-t;--env;TERM=vt100" '-DLLDB_ENABLE_PYTHON=On'

[PATCH] D115544: Revert "Revert "Use `GNUInstallDirs` to support custom installation dirs. -- LLVM""

Ericson2314 created this revision. Herald added subscribers: ormris, jvesely, steven_wu, hiraditya, mgorny. Ericson2314 requested review of this revision. Herald added projects: clang, LLDB, OpenMP, LLVM. Herald added subscribers: llvm-commits, openmp-commits, lldb-commits, cfe-commits. This reve

[PATCH] D115544: Revert "Revert "Use `GNUInstallDirs` to support custom installation dirs. -- LLVM""

Ericson2314 added a comment. This pre-merge build failure is in the ASAN tests and thus seems entirely unrelated, so I cam going to land this is and watch careful as instructed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115544/new/ https://rev

[PATCH] D115544: Revert "Revert "Use `GNUInstallDirs` to support custom installation dirs. -- LLVM""

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG492de35df443: Revert "Revert "Use `GNUInstallDirs` to support custom installation dirs. (authored by Ericson2314). Repository: rG LLVM Github Mono

[PATCH] D115544: Revert "Revert "Use `GNUInstallDirs` to support custom installation dirs. -- LLVM""

Ericson2314 added a comment. I see a build failure in https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/ and think I know how to fix it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115544/new/ https://reviews.llvm.org/D115544 _

[PATCH] D115544: Revert "Revert "Use `GNUInstallDirs` to support custom installation dirs. -- LLVM""

Ericson2314 added a comment. Sorry for this new build failure. I think I found the culprit and fixed it with https://reviews.llvm.org/D115553 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115544/new/ https://reviews.llvm.org/D115544 _

[PATCH] D100810: Use `GNUInstallDirs` to support custom installation dirs. -- LLVM

Ericson2314 added a comment. I tried again without lld in the list of enable projects, in case it that made a difference to force it to use ld64 more, but it still worked. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100810/new/ https://reviews.l

[PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 updated this revision to Diff 393575. Ericson2314 added a comment. Herald added a subscriber: sdasgup3. Rebase after landing parent diff again, take 2 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99484/new/ https://reviews.llvm.org/D99

[PATCH] D115566: Quote some more destination paths with variables

Ericson2314 created this revision. Herald added a subscriber: mgorny. Ericson2314 requested review of this revision. Herald added projects: clang, libc++, OpenMP. Herald added subscribers: openmp-commits, libcxx-commits, cfe-commits. Herald added a reviewer: libc++. Just defensive CMake-ing. I pul

[PATCH] D115566: Quote some more destination paths with variables

Ericson2314 updated this revision to Diff 393645. Ericson2314 added a comment. Herald added a reviewer: jdoerfert. Herald added subscribers: llvm-commits, lldb-commits, sstefan1, jvesely. Herald added projects: LLDB, LLVM. 1. Updating D115566 : Quote some more

[PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 added a comment. I split out D115568 D115569 D115570 from this. I think it is better to start from the outside and work back inward, so the LLVM-only commit that previously came

[PATCH] D115566: Quote some more destination paths with variables

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGddcc02dbcc47: Quote some more destination paths with variables (authored by Ericson2314). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D101070: Make `llvm_install_symlink` robust with respect to absolute dirs.

Ericson2314 updated this revision to Diff 396339. Ericson2314 added a comment. Herald added a project: Flang. 1. Updating D101070 : Make `llvm_install_symlink` robust with respect to absolute dirs. # 2. Enter a brief description of the changes included in this

[PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 updated this revision to Diff 396338. Ericson2314 added a comment. 1. Updating D99484 : Use `GNUInstallDirs` to support custom installation dirs. # 2. Enter a brief description of the changes included in this update. 3. The first line is used as subj

[PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 created this revision. Herald added subscribers: libc-commits, libcxx-commits, dcaballe, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, kerbowa, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, csigg, antiagainst, shauheen, rriddle, mehdi_a

[PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 added a comment. @lebedev.ri Those are intentional. I changed `POLLY_INSTALL_PREFIX` and `COMPILER_RT_INSTALL_PATH` to be `""` instead of `${CMAKE_INSTALL_PREFIX}` by default. If if kept it more as it was, the GNU dir outside the prefix (as I needed to do) wouldn't work. I suppose I

[PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 updated this revision to Diff 333885. Ericson2314 added a comment. 1. Updating D99484 : Use `GNUInstallDirs` to support custom installation dirs. # 2. Enter a brief description of the changes included in this update. 3. The first line is used as subj

[PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 updated this revision to Diff 334152. Ericson2314 added a comment. include(GNUInstallDirs) in each project unconditionally Before projects that might not be built standalone only included it when they were, but then we got into a situation where no project included it, and things brok

[PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 added inline comments. Comment at: clang/cmake/modules/AddClang.cmake:127 + LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR}${LLVM_LIBDIR_SUFFIX} + ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR}${LLVM_LIBDIR_SUFFIX} + RUNTIME DESTINATION ${CMAKE_INS

[PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 added inline comments. Comment at: clang/cmake/modules/AddClang.cmake:127 + LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR}${LLVM_LIBDIR_SUFFIX} + ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR}${LLVM_LIBDIR_SUFFIX} + RUNTIME DESTINATION ${CMAKE_INS

[PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 updated this revision to Diff 334576. Ericson2314 added a comment. Put on top of D99697 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99484/new/ https://reviews.llvm.org/D99484 Files: clang-tools-ext

[PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 marked an inline comment as not done. Ericson2314 added inline comments. Comment at: compiler-rt/cmake/Modules/CompilerRTUtils.cmake:389 get_compiler_rt_target(${arch} target) -set(${install_dir} ${COMPILER_RT_INSTALL_PATH}/lib/${target} PARENT_SCOPE) +se

[PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 updated this revision to Diff 334713. Ericson2314 added a comment. Rebase on newer version of previous diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99484/new/ https://reviews.llvm.org/D99484 Files: clang-tools-extra/clang-doc/t

[PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 updated this revision to Diff 334765. Ericson2314 added a comment. Rebase now that previous diff landed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99484/new/ https://reviews.llvm.org/D99484 Files: clang-tools-extra/clang-doc/tool/

[PATCH] D99755: Remove clang/runtime and `COMPILER_RT_INSTALL_PATH`

Ericson2314 created this revision. Herald added a subscriber: mgorny. Ericson2314 requested review of this revision. Herald added projects: clang, Sanitizers. Herald added subscribers: Sanitizers, cfe-commits. This patch removes those in order to simplify things for D99484

[PATCH] D99755: Remove clang/runtime and `COMPILER_RT_INSTALL_PATH`

Ericson2314 added inline comments. Comment at: compiler-rt/cmake/base-config-ix.cmake:95 set(COMPILER_RT_LIBRARY_INSTALL_DIR -${COMPILER_RT_INSTALL_PATH}) +"") else(LLVM_ENABLE_PER_TARGET_RUNTIME_DIR) I'm a bit confused we'd ever want too install libs

[PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 added inline comments. Comment at: compiler-rt/cmake/Modules/CompilerRTUtils.cmake:389 get_compiler_rt_target(${arch} target) -set(${install_dir} ${COMPILER_RT_INSTALL_PATH}/lib/${target} PARENT_SCOPE) +set(${install_dir} ${COMPILER_RT_INSTALL_PATH}/${CM

[PATCH] D99755: Remove clang/runtime and `COMPILER_RT_INSTALL_PATH`

Ericson2314 updated this revision to Diff 334780. Ericson2314 added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Also remove `clang/runtime` from a TODO comment elsewhere in the tree I put `runtimes` in there as it's evidentially its spiritual successor. Rep

[PATCH] D99755: Remove clang/runtime and `COMPILER_RT_INSTALL_PATH`

Ericson2314 updated this revision to Diff 334955. Ericson2314 added a comment. Remove add_subdirectory(runtime) for deleted dir Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99755/new/ https://reviews.llvm.org/D99755 Files: clang/CMakeLists.txt

[PATCH] D99755: Remove clang/runtime and `COMPILER_RT_INSTALL_PATH`

Ericson2314 added a comment. So unfortunately it seems the `clang/runtime`'s use was triggered by `LLVM_BUILD_EXTERNAL_COMPILER_RT`, which is in use in a few places still? (And not just Apple ones.) On the other hand, since this is doing an *external* CMake for compiler-rt, I fail to see why `

[PATCH] D99755: Remove clang/runtime and `COMPILER_RT_INSTALL_PATH`

Ericson2314 updated this revision to Diff 335149. Ericson2314 added a comment. Remove stray `COMPILER_RT_INSTALL_PATH` I am uncertain about is the redefining of `CMAKE_INSTALL_PREIX` in `compiler-rt/cmake/base-config-ix.cmake`. This occurs under `LLVM_TREE_AVAILABLE`. If this is just for separate

[PATCH] D99860: Remove `COMPILER_RT_INSTALL_PATH`

Ericson2314 created this revision. Herald added a subscriber: mgorny. Ericson2314 requested review of this revision. Herald added projects: clang, Sanitizers. Herald added subscribers: Sanitizers, cfe-commits. It turns out we don't neeed to remove `clang/runtime` to make this work, as @phosek thou

[PATCH] D99755: Remove clang/runtime and `COMPILER_RT_INSTALL_PATH`

Ericson2314 added a comment. See also D99860 . We may still want to remove `clang/runtime`, but I don't think it's necessary. I will turn this revision into one on top of that just for for removing `clang/runtime`. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D99755: Remove clang/runtime and `COMPILER_RT_INSTALL_PATH`

Ericson2314 updated this revision to Diff 335154. Ericson2314 added a comment. Put on top of D99860 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99755/new/ https://reviews.llvm.org/D99755 Files: clang/CMakeList

[PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 updated this revision to Diff 335157. Ericson2314 added a comment. Don't use CMAKE_INTALL_LIBDIR or convert compiler-rt for now These steps were suggested by @compnerd, IIUC. The compiler-rt stuff is in flux because I am now skeptical whether `COMPILER_RT_INSTALL_PATH` can now be so e

[PATCH] D99860: Remove `COMPILER_RT_INSTALL_PATH`

Ericson2314 added a comment. In D99860#2670359 , @phosek wrote: > I'm worried that overriding `CMAKE_INSTALL_PREFIX` is going to break the > runtimes build where we build compiler-rt, libcxx, libcxxabi, libunwind in a > single CMake build, and compiler-r

[PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 updated this revision to Diff 335685. Ericson2314 added a comment. Fix error, remove more CMAKE_INSTALL_LIBDIR Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99484/new/ https://reviews.llvm.org/D99484 Files: clang-tools-extra/clang-do

[PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 added a comment. I think with this last revision this diff might finally be ready! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99484/new/ https://reviews.llvm.org/D99484 ___ cfe-commits mai

[PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 added a comment. I simplified the description at the top in light of feedback (some harder issues we are just punting on for now). @compnerd does this now look good to you then? Does anyone want to approve the libunwind said of things? Anything else this is waiting on? Repository:

[PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 updated this revision to Diff 338697. Ericson2314 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99484/new/ https://reviews.llvm.org/D99484 Files: clang-tools-extra/clang-doc/tool/CMakeLists.txt clang-tools-e

[PATCH] D100810: Use `GNUInstallDirs` to support custom installation dirs. -- LLVM

Ericson2314 added inline comments. Comment at: llvm/tools/llvm-config/llvm-config.cpp:361 +{ + SmallString<256> Path(StringRef(LLVM_INSTALL_INCLUDEDIR)); + sys::fs::make_absolute(ActivePrefix, Path); Ericson2314 wrote: > Ericson2314 wrote: > > compn

[PATCH] D100810: Use `GNUInstallDirs` to support custom installation dirs. -- LLVM

Ericson2314 updated this revision to Diff 378391. Ericson2314 added a comment. Rebase, avoid extra string ref conversions in llvm-config Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100810/new/ https://reviews.llvm.org/D100810 Files: clang/tool

[PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 updated this revision to Diff 378392. Ericson2314 added a comment. Herald added a project: Flang. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99484/new/ https://reviews.llvm.org/D99484 Files: clang-tools-extra/clang-doc/tool

[PATCH] D100810: Use `GNUInstallDirs` to support custom installation dirs. -- LLVM

Ericson2314 marked 2 inline comments as done. Ericson2314 added a comment. Removed extraneous StringRef conversion after previous D111322 was landed. Comment at: llvm/tools/llvm-config/llvm-config.cpp:361 +{ + SmallString<256> Path(S

[PATCH] D100810: Use `GNUInstallDirs` to support custom installation dirs. -- LLVM

Ericson2314 updated this revision to Diff 379975. Ericson2314 added a comment. Skip ${project} change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100810/new/ https://reviews.llvm.org/D100810 Files: clang/tools/scan-build/CMakeLists.txt libcl

[PATCH] D100810: Use `GNUInstallDirs` to support custom installation dirs. -- LLVM

Ericson2314 marked an inline comment as done. Ericson2314 added a comment. Respond to last open thing Comment at: llvm/CMakeLists.txt:589 CACHE STRING "Doxygen-generated HTML documentation install directory") -set(LLVM_INSTALL_OCAMLDOC_HTML_DIR "share/doc/llvm/ocaml-html"

[PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 updated this revision to Diff 379976. Ericson2314 added a comment. Rebase again because previous diff changed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99484/new/ https://reviews.llvm.org/D99484 Files: clang-tools-extra/clang-doc

<    1   2   3