[PATCH] D132324: [RFC] Remove support for building C++ with `LLVM_ENABLE_PROJECTS`

Ericson2314 updated this revision to Diff 454271. Ericson2314 added a comment. Do the rename @phosek suggested Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132324/new/ https://reviews.llvm.org/D132324 Files: clang/lib/Driver/ToolChains/Linux.cp

[PATCH] D132324: [RFC] Remove support for building C++ with `LLVM_ENABLE_PROJECTS`

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Ericson2314 marked an inline comment as done. Closed by commit rG176db3b3ab25: [RFC] Remove support for building C++ with `LLVM_ENABLE_PROJEC

[PATCH] D132324: [RFC] Remove support for building libc++ with `LLVM_ENABLE_PROJECTS`

Ericson2314 added a comment. Ah I see email about sphinx jobs defined out of tree :/ I will take a look at that, see if it is easy to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132324/new/ https://reviews.llvm.org/D132324

[PATCH] D132324: [RFC] Remove support for building libc++ with `LLVM_ENABLE_PROJECTS`

Ericson2314 added a comment. In 952f90b72b3546d6b6b038d410f07ce520c59b48 I relented and made it a non-fatal error until the remaining jobs are figured out. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D132324: [RFC] Remove support for building libc++ with `LLVM_ENABLE_PROJECTS`

Ericson2314 added a comment. I did a "soft revert" in rG952f90b72b3546d6b6b038d410f07ce520c59b48 which makes it a non-fatal error so everything keeps on working, but I can do a real revert too if that is preferred. Reposito

[PATCH] D132324: [RFC] Remove support for building libc++ with `LLVM_ENABLE_PROJECTS`

Ericson2314 added a comment. https://reviews.llvm.org/rZORG3a209ca6c1b9 This s what I had started doing. but I am not sure it is a very good solution. I think I might write a discourse post with my thoughts. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D132324: [RFC] Remove support for building libc++ with `LLVM_ENABLE_PROJECTS`

Ericson2314 added a comment. https://reviews.llvm.org/D132411 should fix the issue @aaron.ballman mentioned. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132324/new/ https://reviews.llvm.org/D132324 ___

[PATCH] D132316: [CMake] `${LLVM_BINARY_DIR}/lib(${LLVM_LIBDIR_SUFFIX})?` -> `${LLVM_LIBRARY_DIR}`

Ericson2314 updated this revision to Diff 454829. Ericson2314 added a comment. Redo sed mandating ending on word boundary Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132316/new/ https://reviews.llvm.org/D132316 Files: bolt/lib/Target/AArch64/C

[PATCH] D132316: [CMake] `${LLVM_BINARY_DIR}/lib(${LLVM_LIBDIR_SUFFIX})?` -> `${LLVM_LIBRARY_DIR}`

Ericson2314 marked an inline comment as done. Ericson2314 added inline comments. Comment at: llvm/tools/llvm-shlib/CMakeLists.txt:91 set(LIB_DIR ${LLVM_BINARY_DIR}/${CMAKE_CFG_INTDIR}/lib${LLVM_LIBDIR_SUFFIX}) set(LIB_NAME ${LIB_DIR}/${CMAKE_SHARED_LIBRARY_PREFIX}LLVM) --

[PATCH] D132324: [RFC] Remove support for building libc++ with `LLVM_ENABLE_PROJECTS`

Ericson2314 added a comment. That sounds good to me too. Sorry I did unquestionably jump the gun here --- I suppose I was surprised to get a fairly simple approval when I put on the `[RFC]`, and thought "hmm, maybe this isn't so controversial as I feared because indeed the deprecation cycle ha

[PATCH] D132316: [CMake] `${LLVM_BINARY_DIR}/lib(${LLVM_LIBDIR_SUFFIX})?` -> `${LLVM_LIBRARY_DIR}`

Ericson2314 updated this revision to Diff 454982. Ericson2314 added a comment. Convert `CMAKE_CFG_INTDIR` as @sebastian-ne suggests, also .../bin Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132316/new/ https://reviews.llvm.org/D132316 Files: b

[PATCH] D132316: [CMake] `${LLVM_BINARY_DIR}/lib(${LLVM_LIBDIR_SUFFIX})?` -> `${LLVM_LIBRARY_DIR}`

Ericson2314 marked 3 inline comments as done. Ericson2314 added inline comments. Comment at: llvm/tools/llvm-shlib/CMakeLists.txt:91 set(LIB_DIR ${LLVM_BINARY_DIR}/${CMAKE_CFG_INTDIR}/lib${LLVM_LIBDIR_SUFFIX}) set(LIB_NAME ${LIB_DIR}/${CMAKE_SHARED_LIBRARY_PREFIX}LLVM) --

[PATCH] D132316: [CMake] Avoid `LLVM_BINARY_DIR` when other more specific variable are better-suited

This revision was automatically updated to reflect the committed changes. Ericson2314 marked an inline comment as done. Closed by commit rGad8c34bc3089: [CMake] Avoid `LLVM_BINARY_DIR` when other more specific variable are better… (authored by Ericson2314). Repository: rG LLVM Github Monorepo

[PATCH] D132316: [CMake] Avoid `LLVM_BINARY_DIR` when other more specific variable are better-suited

Ericson2314 added a comment. https://lab.llvm.org/buildbot#builders/13/builds/24958 I am worried this failure is not spurious? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132316/new/ https://reviews.llvm.org/D132316

[PATCH] D132316: [CMake] Avoid `LLVM_BINARY_DIR` when other more specific variable are better-suited

Ericson2314 added a comment. Whew, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132316/new/ https://reviews.llvm.org/D132316 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[PATCH] D132608: [CMake] Clean up CMake binary dir handling

Ericson2314 created this revision. Ericson2314 added reviewers: sebastian-ne, beanz, phosek, ldionne. Herald added subscribers: libc-commits, libcxx-commits, Enna1, bzcheeseman, pmatos, asb, ayermolo, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh

[PATCH] D132316: [CMake] Avoid `LLVM_BINARY_DIR` when other more specific variable are better-suited

Ericson2314 added a comment. Let's just revert this. I'll do it later today if no one beats me to it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132316/new/ https://reviews.llvm.org/D132316 ___ cfe-co

[PATCH] D132300: [clang][lldb][cmake] Use new `*_INSTALL_LIBDIR_BASENAME` CPP macro

Ericson2314 added a comment. Thanks @MaskRay that's good to know. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132300/new/ https://reviews.llvm.org/D132300 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D137224: clang/cmake: Simplify lit detection for standalone builds

Ericson2314 accepted this revision. Ericson2314 added a comment. LGTM. I also can't see why it would act differently. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137224/new/ https://reviews.llvm.org/D137224 __

[PATCH] D137337: Replace LLVM_LIBDIR_SUFFIX by CMAKE_INSTALL_LIBDIR

Ericson2314 added inline comments. Comment at: bolt/lib/RuntimeLibs/RuntimeLibrary.cpp:32 SmallString<128> LibPath = llvm::sys::path::parent_path(Dir); - llvm::sys::path::append(LibPath, "lib" LLVM_LIBDIR_SUFFIX); + llvm::sys::path::append(LibPath, CMAKE_INSTALL_LIBDIR);

[PATCH] D136809: [CMake] Make sure all headers are installed into `CLANG_RESOURCE_DIR`

Ericson2314 added a comment. This change introduces a lot of conditional code, that is not necessary. This change also uses `CLANG_` outside `clang/` which is messy. and confusing. Please clean up. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136809/new/ https://reviews.llvm.org/D136

[PATCH] D132608: [CMake] Clean up CMake binary dir handling

Ericson2314 updated this revision to Diff 473679. Ericson2314 added a comment. Herald added a subscriber: Moerafaat. Dedup code, rename variables Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132608/new/ https://reviews.llvm.org/D132608 Files: b

[PATCH] D132608: [CMake] Clean up CMake binary dir handling

Ericson2314 added a comment. I have done the deduping @phosek requested, and changed the variable names from `CMAKE_*` to `LLVMPROJ_*` which hopefully satisfies everyone's criteria. Happy with other non `LLVM_` options too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D133890: [CMake] Do these replacements to make use of D132608

Ericson2314 updated this revision to Diff 473684. Ericson2314 added a comment. Herald added a subscriber: Moerafaat. Rebase, rename variables Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133890/new/ https://reviews.llvm.org/D133890 Files: bolt/

[PATCH] D117977: [cmake] Don't export `LLVM_TOOLS_INSTALL_DIR` anymore

Ericson2314 reopened this revision. Ericson2314 added a comment. This revision is now accepted and ready to land. Thanks for finding this and sorry for the disruption. Hope the revert didn't come to slowly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D117977: [cmake] Don't export `LLVM_TOOLS_INSTALL_DIR` anymore

Ericson2314 updated this revision to Diff 436152. Ericson2314 added a comment. Fix typo Thank you @aaron.ballman and @nikic for finding the culprit! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117977/new/ https://reviews.llvm.org/D117977 Files:

[PATCH] D117977: [cmake] Don't export `LLVM_TOOLS_INSTALL_DIR` anymore

Ericson2314 marked an inline comment as done. Ericson2314 added inline comments. Comment at: openmp/tools/CMakeLists.txt:1-3 +set(OPENMP_TOOLS_INSTALL_DIR "${CMAKE_INSTALL_BINDIR}" CACHE PATH +"Path for binary subdirectory (defaults to '${CMAKE_INSTALL_BINDIR}')") +mark_as_ad

[PATCH] D117977: [cmake] Don't export `LLVM_TOOLS_INSTALL_DIR` anymore

Ericson2314 added a comment. Hmm, are all those errors from running out of file system space, or might there be another issue? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117977/new/ https://reviews.llvm.org/D117977

[PATCH] D117977: [cmake] Don't export `LLVM_TOOLS_INSTALL_DIR` anymore

Ericson2314 updated this revision to Diff 436874. Ericson2314 added a comment. Rebase again, to try to figure out if last round of errors were spurious Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117977/new/ https://reviews.llvm.org/D117977 File

[PATCH] D126308: cmake: use llvm dir variables for clang/utils/hmaptool

Ericson2314 added inline comments. Comment at: clang/utils/hmaptool/CMakeLists.txt:5 -add_custom_command(OUTPUT ${CMAKE_BINARY_DIR}/${CMAKE_CFG_INTDIR}/bin/${CLANG_HMAPTOOL} - COMMAND ${CMAKE_COMMAND} -E make_directory - ${CMAKE_BINARY_DIR

[PATCH] D126308: cmake: use llvm dir variables for clang/utils/hmaptool

Ericson2314 added a comment. There is a lot of cruft behind the signs. I would just use `LLVM_TOOLS_INSTALL_DIR` then which is exported to get this unblocked, and I'll rebase D117977 to try to clean these things up later. Repository: rG LLVM Github Monorep

[PATCH] D126308: cmake: use llvm dir variables for clang/utils/hmaptool

Ericson2314 added a comment. I am sorry, I completely forgot one of my motivations for https://reviews.llvm.org/D117977 was that `LLVM_TOOLS_BINARY_DIR` was completely misnamed and just this sort of foot-gun! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D117977: [cmake] Don't export `LLVM_TOOLS_INSTALL_DIR` anymore

Ericson2314 added a comment. Herald added a subscriber: bzcheeseman. Herald added a project: All. I moved the `openmp` definitions so they should be used. Don't need the other variables yet I don't think? Comment at: openmp/tools/CMakeLists.txt:1-3 +set(OPENMP_TOOLS_INSTALL_DI

[PATCH] D117977: [cmake] Don't export `LLVM_TOOLS_INSTALL_DIR` anymore

Ericson2314 updated this revision to Diff 435048. Ericson2314 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117977/new/ https://reviews.llvm.org/D117977 Files: bolt/tools/CMakeLists.txt bolt/tools/driver/CMakeLists.txt

[PATCH] D117973: [cmake] Support custom package install paths

Ericson2314 updated this revision to Diff 435049. Ericson2314 added a comment. Herald added a subscriber: bzcheeseman. Herald added a project: All. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117973/new/ https://reviews.llvm.org/D117973 F

[PATCH] D117977: [cmake] Don't export `LLVM_TOOLS_INSTALL_DIR` anymore

Ericson2314 added subscribers: mizvekov, nikic. Ericson2314 added a comment. @nikic @mizvekov inspired by the recent activity in D126308 , I rebased this. Would you mind giving it a review or trying out a local build? Repository: rG LLVM Github Monorepo CHA

[PATCH] D117977: [cmake] Don't export `LLVM_TOOLS_INSTALL_DIR` anymore

Ericson2314 added inline comments. Comment at: bolt/tools/CMakeLists.txt:11-13 +macro(add_bolt_tool_symlink name) + llvm_add_tool_symlink(BOLT ${ARGV}) +endmacro() mizvekov wrote: > Instead of each project having to define a different macro for this, why not >

[PATCH] D117977: [cmake] Don't export `LLVM_TOOLS_INSTALL_DIR` anymore

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd5daa5c5b091: [cmake] Don't export `LLVM_TOOLS_INSTALL_DIR` anymore (authored by Ericson2314). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D69760: [LLD][MinGW] Support --allow-multiple-definition

Ericson2314 created this revision. Herald added subscribers: llvm-commits, cfe-commits, mstorsjo. Herald added projects: clang, LLVM. We want the Clang CrossWindows toolchain to work with ld.lld and ld.bfd alike, and it uses this, so we need to support this. [Clang][Test]: Remaining "lld-link2" -

[PATCH] D69763: [Clang][Test]: Remaining "lld-link2" -> "lld-link"

Ericson2314 created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. No idea why these are still here. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D69763 Files: clang/test/Driver/windows-cross.c Index: clang/test/Driver/windows-cross.

[PATCH] D69766: [Clang][MSVC] Use GetLinkerPath like the other toolchains for consistency

Ericson2314 created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D69766 Files: clang/lib/Driver/ToolChains/MSVC.cpp Index: clang/lib/Driver/ToolChains/MSVC.cpp

[PATCH] D69760: [Clang][Driver] Don't pun -fuse-ld=lld as -fuse-ld=lld-link with msvc

Ericson2314 updated this revision to Diff 227621. Ericson2314 retitled this revision from "Better clang cross windows with gnu-style flags" to "Clang][Driver] Don't pun -fuse-ld=lld as -fuse-ld=lld-link with msvc". Ericson2314 edited the summary of this revision. Ericson2314 added a comment. Spl

[PATCH] D69769: [Clang][Driver] Don't pun -fuse-ld=lld as -fuse-ld=lld-link with msvc

Ericson2314 created this revision. Herald added subscribers: cfe-commits, mstorsjo. Herald added a project: clang. Besides the Mingw toolchain, there is also the CrossWindows toolchain, which means GNU-style cli but genuine windows headers + libraries. LLD's MinGW driver is as good a fit as binuti

[PATCH] D69763: [Clang][Test]: Remaining "lld-link2" -> "lld-link"

Ericson2314 added a comment. I am curious, how did this work since there is no longer an `lld-link2`? Were these tests failing or not being run? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69763/new/ https://reviews.llvm.org/D69763 __

[PATCH] D69760: [Clang][Driver] Don't pun -fuse-ld=lld as -fuse-ld=lld-link with msvc

Ericson2314 added a comment. While I am fine making `-fuse-ld=lld` mean "use that lld driver most appropriate for the clang driver", in principle the clang driver and lld driver choices are orthogonal, and I'd want to expose that with something like `-fuse-ld=ld.lld` to compliment `-fuse-ld=lld

[PATCH] D69766: [Clang][MSVC] Use GetLinkerPath like the other toolchains for consistency

Ericson2314 added a comment. Reading https://llvm.org/docs/DeveloperPolicy.html it looks like I need to submit an patch email? Is that true, or can/will someone with perms see the approval and eventually merge it from phabricator? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D69760: [Clang][Driver] Don't pun -fuse-ld=lld as -fuse-ld=lld-link with msvc

Ericson2314 abandoned this revision. Ericson2314 added a comment. OK sounds good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69760/new/ https://reviews.llvm.org/D69760 ___ cfe-commits mailing list c

[PATCH] D69769: [Driver] Don't pun -fuse-ld=lld as -fuse-ld=lld-link with msvc

Ericson2314 abandoned this revision. Ericson2314 added a comment. OK abandoning this too. Thanks for the extra info. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69769/new/ https://reviews.llvm.org/D69769 ___ cfe-co

[PATCH] D69760: [Clang][Driver] Don't pun -fuse-ld=lld as -fuse-ld=lld-link with msvc

Ericson2314 reclaimed this revision. Ericson2314 added a comment. Oops meant to abandon the backport Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69760/new/ https://reviews.llvm.org/D69760 ___ cfe-com

[PATCH] D69763: [Clang][Test]: Remaining "lld-link2" -> "lld-link"

Ericson2314 added a comment. Do I need to do anything more with this, or will somebody else just merge this at come point? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69763/new/ https://reviews.llvm.org/D69763

[PATCH] D44753: [Preprocessor] Rename __is_{target -> host}_* function-like builtin macros

Ericson2314 created this revision. Ericson2314 added reviewers: arphaman, compnerd, dexonsmith, bob.wilson, steven_wu. Herald added subscribers: cfe-commits, javed.absar. Per my belated [reply] to the mailing list, I believe the "target" nomenclature incorrect for cross compilation. [reply]: htt

[PATCH] D44753: [Preprocessor] Rename __is_{target -> host}_* function-like builtin macros

Ericson2314 added a comment. In https://reviews.llvm.org/D44753#1044935, @bob.wilson wrote: > Sorry that I missed your earlier comment about this. The confusion could only > arise in the context of a tool (like a compiler) that is being used for > cross-compilation. That is a small fraction of

[PATCH] D44753: [Preprocessor] Rename __is_{target -> host}_* function-like builtin macros

Ericson2314 added a comment. One that that might make my position clearer is to substitute the name "build", "host", and "target" for "build", "run", and "emit". [A colleague of mine proposed these alternative names and I do think they are vastly more human friendly.] Then if we write int m

[PATCH] D44753: [Preprocessor] Rename __is_{target -> host}_* function-like builtin macros

Ericson2314 added a comment. @steven_wu but what you say is directly contradicted by the GHC example. I'm sure I could fine a GCC example too where some macro with "target" is in the name affects the target of the compiler being built. In the vast majority of programs, no more than one platform

[PATCH] D44753: [Preprocessor] Rename __is_{target -> host}_* function-like builtin macros

Ericson2314 added a comment. > I'm sure I could fine a GCC example FWIW https://github.com/gcc-mirror/gcc/blob/master/gcc/config/aarch64/aarch64.c vs https://github.com/gcc-mirror/gcc/blob/master/gcc/common/config/aarch64/aarch64-common.c @steven_wu > It is not about matching command line na

[PATCH] D44753: [Preprocessor] Rename __is_{target -> host}_* function-like builtin macros

Ericson2314 added a comment. @steven_wu Maybe there is something outside of "build" "host" or "target" that won't suffer from these problems of vantage point? `__will_be_built_for_*` for a very lengthy example, but hopefully something shorter too? Repository: rC Clang https://reviews.llvm.o

[PATCH] D44753: [Preprocessor] Rename __is_{target -> host}_* function-like builtin macros

Ericson2314 added a comment. OK I'll happily admit that Autoconf's choices of names is terrible, and that, yes, the names can be defined from two differing perspectives. And, I actually do believe the GCC build system is far inferior, too. But on other points I think we're all talking past each

[PATCH] D44753: [Preprocessor] Rename __is_{target -> host}_* function-like builtin macros

Ericson2314 added a comment. Bummer, I didn't realize this had already shipped. I'm happy to discuss on the mailing list. Indeed I responded there first but it would appear nobody saw my message. Should I reply to my own message

[PATCH] D137337: Replace LLVM_LIBDIR_SUFFIX by CMAKE_INSTALL_LIBDIR

Ericson2314 added inline comments. Comment at: bolt/lib/RuntimeLibs/RuntimeLibrary.cpp:32 SmallString<128> LibPath = llvm::sys::path::parent_path(Dir); - llvm::sys::path::append(LibPath, "lib" LLVM_LIBDIR_SUFFIX); + llvm::sys::path::append(LibPath, CMAKE_INSTALL_LIBDIR);

[PATCH] D116521: [CMake] Factor out config prefix finding logic

Ericson2314 marked an inline comment as done. Ericson2314 added inline comments. Comment at: llvm/CMakeLists.txt:209 "${CMAKE_CURRENT_SOURCE_DIR}/cmake/modules" + "${LLVM_COMMON_CMAKE_UTILS}/Modules" ) Ericson2314 wrote: > sebastian-ne wrote: > > Hi, addin

[PATCH] D117419: [clang][cmake] Use `GNUInstallDirs` to support custom installation dirs

Ericson2314 updated this revision to Diff 401001. Ericson2314 added a comment. Fix bug Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117419/new/ https://reviews.llvm.org/D117419 Files: clang/CMakeLists.txt clang/cmake/modules/AddClang.cmake

[PATCH] D117419: [clang][cmake] Use `GNUInstallDirs` to support custom installation dirs

Ericson2314 added inline comments. Comment at: clang/CMakeLists.txt:3 +include(GNUInstallDirs) + beanz wrote: > If GNUInstallDirs is included before the `project` call enables languages it > results in a CMake warning being logged. See D117639 where we are dis

[PATCH] D117419: [clang][cmake] Use `GNUInstallDirs` to support custom installation dirs

Ericson2314 updated this revision to Diff 401304. Ericson2314 added a comment. Avoid warning Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117419/new/ https://reviews.llvm.org/D117419 Files: clang/CMakeLists.txt clang/cmake/modules/AddClang.cm

[PATCH] D101070: Make `llvm_install_symlink` robust with respect to absolute dirs.

Ericson2314 updated this revision to Diff 401784. Ericson2314 added a comment. Much simpler now Code taken from D99484 and then to D117419 and now to here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D101070: [llvm][cmake] Make `llvm_install_symlink` robust to absolute dirs.

Ericson2314 added a comment. Continuing my bisect of D99484 (since this change was in there at the time it was approved, but failing) I will land this one next. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101070

[PATCH] D101070: [llvm][cmake] Make `llvm_install_symlink` robust to absolute dirs.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG58580e922a69: [llvm][cmake] Make `llvm_install_symlink` robust to absolute dirs. (authored by Ericson2314). Repository:

[PATCH] D101070: [llvm][cmake] Make `llvm_install_symlink` robust to absolute dirs.

Ericson2314 reopened this revision. Ericson2314 added a comment. This seems to be the part of D99484 that wasn't working. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101070/new/ https://reviews.llvm.org/D101070

[PATCH] D117419: [clang][cmake] Use `GNUInstallDirs` to support custom installation dirs

Ericson2314 updated this revision to Diff 401843. Ericson2314 added a comment. Remove the LLVM part, which is now D101070 , and furthermore known to cause issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11741

[PATCH] D117419: [clang][cmake] Use `GNUInstallDirs` to support custom installation dirs

Ericson2314 added a comment. I will land this next as part of my great D99484 bisect. Now that I have in fact found the issue, I am more confident this part, which is analogous to all the parts that have gone in fine, is harmless. Repository: rG LLVM Github

[PATCH] D117419: [clang][cmake] Use `GNUInstallDirs` to support custom installation dirs

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG10d0d8c0c1db: [clang][cmake] Use `GNUInstallDirs` to support custom installation dirs (authored by Ericson2314). Reposito

[PATCH] D99484: [cmake] Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 updated this revision to Diff 402234. Ericson2314 added a comment. Trim down, now that many parts have been landed already Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99484/new/ https://reviews.llvm.org/D99484 Files: clang-tools-ex

[PATCH] D99484: [clang-tools-extra][cmake] Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 added a comment. Alright, this is the last bit (except for D101070 which evidently caused the issues), looking good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99484/new/ https://reviews.llvm.org/

[PATCH] D99484: [clang-tools-extra][cmake] Use `GNUInstallDirs` to support custom installation dirs.

This revision was automatically updated to reflect the committed changes. Closed by commit rG7c16647c3676: [clang-tools-extra][cmake] Use `GNUInstallDirs` to support custom installation… (authored by Ericson2314). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D117973: [cmake] Support custom package install paths

Ericson2314 created this revision. Ericson2314 added reviewers: compnerd, phosek, beanz, sterni. Herald added subscribers: sdasgup3, wenzhicui, wrengr, Chia-hungDuan, dcaballe, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, lucyrfox, mge

[PATCH] D117977: WIP: [cmake] Don't export `LLVM_TOOLS_INSTALL_DIR` anymore

Ericson2314 created this revision. Ericson2314 added reviewers: beanz, compnerd, phosek. Herald added subscribers: ayermolo, sdasgup3, wenzhicui, wrengr, Chia-hungDuan, dcaballe, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, lucyrfox, m

[PATCH] D116492: [lld] Deprecate using llvm-config to detect llvm installation

Ericson2314 added a comment. In D116492#3290087 , @nikic wrote: > Would it be possible to share a complete new-style cmake invocation that is > supposed to work? Our standalone LLD package in Nixpkgs works, but I see now we have been passing `-DLLVM_MA

[PATCH] D118792: [lld][clang][cmake] Clean up a few things

Ericson2314 created this revision. Ericson2314 added reviewers: nikic, beanz. Herald added a subscriber: mgorny. Ericson2314 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. - If not using `llvm-config`, `LLVM_MAIN_SRC_DIR` now has a sane de

[PATCH] D116492: [lld] Deprecate using llvm-config to detect llvm installation

Ericson2314 added a comment. @nikic I have tried to address your concerns in https://reviews.llvm.org/D118792 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116492/new/ https://reviews.llvm.org/D116492 __

[PATCH] D117977: [cmake] Don't export `LLVM_TOOLS_INSTALL_DIR` anymore

Ericson2314 added a comment. Could one of you review this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117977/new/ https://reviews.llvm.org/D117977 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D117973: [cmake] Support custom package install paths

Ericson2314 added a comment. Could one of you review this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117973/new/ https://reviews.llvm.org/D117973 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D101070: Make `llvm_install_symlink` robust with respect to absolute dirs.

Ericson2314 created this revision. Herald added a subscriber: mgorny. Ericson2314 requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. If `CMAKE_INSTALL_BINDIR` is a different absolute path per project, as it is with NixOS when

[PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 updated this revision to Diff 339626. Ericson2314 added a comment. Recombind revisions, need to convert everything at once Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99484/new/ https://reviews.llvm.org/D99484 Files: clang-tools-ex

[PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 updated this revision to Diff 339639. Ericson2314 added a comment. Resplit on @LebedevRI's advice that it's OK if not all patches build alone Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99484/new/ https://reviews.llvm.org/D99484 File

[PATCH] D100810: Use `GNUInstallDirs` to support custom installation dirs. -- LLVM

Ericson2314 updated this revision to Diff 341071. Ericson2314 added a comment. Herald added subscribers: openmp-commits, lldb-commits, cfe-commits, jvesely. Herald added projects: clang, LLDB, OpenMP. Quote variable usages Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 added inline comments. Comment at: clang-tools-extra/clang-doc/tool/CMakeLists.txt:26 install(FILES ../assets/index.js - DESTINATION share/clang + DESTINATION "${CMAKE_INSTALL_DATADIR}/clang" COMPONENT clang-doc) compnerd wrote: > Why are these

[PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 updated this revision to Diff 341072. Ericson2314 added a comment. Quote variable usages Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99484/new/ https://reviews.llvm.org/D99484 Files: clang-tools-extra/clang-doc/tool/CMakeLists.txt

[PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 added inline comments. Comment at: clang-tools-extra/clang-doc/tool/CMakeLists.txt:26 install(FILES ../assets/index.js - DESTINATION share/clang + DESTINATION "${CMAKE_INSTALL_DATADIR}/clang" COMPONENT clang-doc) Ericson2314 wrote: > compnerd wr

[PATCH] D100810: Use `GNUInstallDirs` to support custom installation dirs. -- LLVM

Ericson2314 updated this revision to Diff 341211. Ericson2314 added a comment. Fix stray ':' typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100810/new/ https://reviews.llvm.org/D100810 Files: clang/tools/scan-build/CMakeLists.txt libclc/CM

[PATCH] D100810: Use `GNUInstallDirs` to support custom installation dirs. -- LLVM

Ericson2314 updated this revision to Diff 341338. Ericson2314 added a comment. Rebase, no changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100810/new/ https://reviews.llvm.org/D100810 Files: clang/tools/scan-build/CMakeLists.txt libclc/CM

[PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 updated this revision to Diff 341213. Ericson2314 added a comment. Fix stray ':' typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99484/new/ https://reviews.llvm.org/D99484 Files: clang-tools-extra/clang-doc/tool/CMakeLists.txt c

[PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 updated this revision to Diff 341326. Ericson2314 added a comment. Fix bug makeing polly path full, and rebase fixing conflicts Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99484/new/ https://reviews.llvm.org/D99484 Files: clang-too

[PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 updated this revision to Diff 341339. Ericson2314 added a comment. Resubmit now prior diff is rebased, so CI doesn't trip up Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99484/new/ https://reviews.llvm.org/D99484 Files: clang-tools-

[PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 added a comment. In D99484#2724343 , @Meinersbur wrote: > In D99484#2724055 , @Ericson2314 > wrote: > >> Fix bug makeing polly path full, and rebase fixing conflicts > > What was the problem? I effecti

[PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 added inline comments. Comment at: polly/cmake/CMakeLists.txt:104-110 +set(tgt_prefix "${CMAKE_INSTALL_FULL_BINDIR}/") else() -set(tgt_prefix "lib/") +set(tgt_prefix "${CMAKE_INSTALL_FULL_LIBDIR}/") endif() - set(tgt_path "${CMAKE_INSTALL_PREFIX}

[PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 added a comment. This is now approved and passing CI, and I have also normalized the quoting @compnerd asked about (in I hope a satisfactory way). Should I be pinging someone to land it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99

[PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 added inline comments. Comment at: compiler-rt/cmake/base-config-ix.cmake:72 + set(COMPILER_RT_INSTALL_PATH "" CACHE PATH +"Prefix where built compiler-rt artifacts should be installed, comes before CMAKE_INSTALL_PREFIX.") option(COMPILER_RT_INCLUDE_TESTS "Ge

[PATCH] D100810: Use `GNUInstallDirs` to support custom installation dirs. -- LLVM

Ericson2314 added a subscriber: compnerd. Ericson2314 added a comment. @compnerd Would you like to review this one too (which the other you approved needs)? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100810/new/ https://reviews.llvm.org/D100810

[PATCH] D99860: Remove `COMPILER_RT_INSTALL_PATH`

Ericson2314 abandoned this revision. Ericson2314 added a comment. D101497 is more safe/conservative and gets the job done to prepare for`GnuInstallDirs`. Closing in favor of that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D99755: Remove `clang/runtime`

Ericson2314 added a comment. D101497 is more safe/conservative and gets the job done to prepare for`GnuInstallDirs`. Closing in favor of that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99755/new/ https://revi

[PATCH] D100810: Use `GNUInstallDirs` to support custom installation dirs. -- LLVM

Ericson2314 reopened this revision. Ericson2314 added a comment. This revision is now accepted and ready to land. I guess reopening is the better way to redo after revert? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100810/new/ https://reviews.ll

<    1   2   3   >