This revision was automatically updated to reflect the committed changes. Ericson2314 marked an inline comment as done. Closed by commit rGad8c34bc3089: [CMake] Avoid `LLVM_BINARY_DIR` when other more specific variable are better… (authored by Ericson2314).
Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132316/new/ https://reviews.llvm.org/D132316 Files: bolt/lib/Target/AArch64/CMakeLists.txt bolt/lib/Target/X86/CMakeLists.txt bolt/unittests/Core/CMakeLists.txt clang/cmake/modules/CMakeLists.txt clang/lib/Tooling/CMakeLists.txt flang/cmake/modules/CMakeLists.txt lld/cmake/modules/CMakeLists.txt lldb/cmake/modules/LLDBConfig.cmake lldb/test/API/CMakeLists.txt llvm/CMakeLists.txt llvm/cmake/modules/AddLLVM.cmake llvm/cmake/modules/CMakeLists.txt llvm/tools/llvm-exegesis/lib/AArch64/CMakeLists.txt llvm/tools/llvm-exegesis/lib/Mips/CMakeLists.txt llvm/tools/llvm-exegesis/lib/PowerPC/CMakeLists.txt llvm/tools/llvm-exegesis/lib/X86/CMakeLists.txt llvm/tools/llvm-shlib/CMakeLists.txt llvm/unittests/Target/ARM/CMakeLists.txt llvm/unittests/Target/DirectX/CMakeLists.txt llvm/unittests/tools/llvm-exegesis/AArch64/CMakeLists.txt llvm/unittests/tools/llvm-exegesis/ARM/CMakeLists.txt llvm/unittests/tools/llvm-exegesis/Mips/CMakeLists.txt llvm/unittests/tools/llvm-exegesis/PowerPC/CMakeLists.txt llvm/unittests/tools/llvm-exegesis/X86/CMakeLists.txt llvm/unittests/tools/llvm-mca/X86/CMakeLists.txt mlir/cmake/modules/CMakeLists.txt polly/cmake/CMakeLists.txt polly/test/CMakeLists.txt
Index: polly/test/CMakeLists.txt =================================================================== --- polly/test/CMakeLists.txt +++ polly/test/CMakeLists.txt @@ -46,7 +46,7 @@ set(LLVM_BINARY_DIR "${LLVM_BINARY_DIR}") set(LLVM_TOOLS_DIR "${LLVM_TOOLS_BINARY_DIR}") -set(LLVM_LIBS_DIR "${LLVM_BINARY_DIR}/lib${LLVM_LIBDIR_SUFFIX}") +set(LLVM_LIBS_DIR "${LLVM_LIBRARY_DIR}") if (CMAKE_LIBRARY_OUTPUT_DIRECTORY) set(POLLY_LIB_DIR ${CMAKE_LIBRARY_OUTPUT_DIRECTORY}) else() Index: polly/cmake/CMakeLists.txt =================================================================== --- polly/cmake/CMakeLists.txt +++ polly/cmake/CMakeLists.txt @@ -12,7 +12,7 @@ set(LLVM_INSTALL_PACKAGE_DIR "${CMAKE_INSTALL_PACKAGEDIR}/llvm" CACHE STRING "Path for CMake subdirectory for LLVM (defaults to '${CMAKE_INSTALL_PACKAGEDIR}/llvm')") # CMAKE_INSTALL_PACKAGEDIR might be absolute, so don't reuse below. -set(llvm_cmake_builddir "${LLVM_BINARY_DIR}/lib${LLVM_LIBDIR_SUFFIX}/cmake/llvm") +set(llvm_cmake_builddir "${LLVM_LIBRARY_DIR}/cmake/llvm") if (CMAKE_CONFIGURATION_TYPES) set(POLLY_EXPORTS_FILE_NAME "PollyExports-$<LOWER_CASE:$<CONFIG>>.cmake") Index: mlir/cmake/modules/CMakeLists.txt =================================================================== --- mlir/cmake/modules/CMakeLists.txt +++ mlir/cmake/modules/CMakeLists.txt @@ -15,7 +15,7 @@ set(LLVM_INSTALL_PACKAGE_DIR "${CMAKE_INSTALL_PACKAGEDIR}/llvm" CACHE STRING "Path for CMake subdirectory for LLVM (defaults to '${CMAKE_INSTALL_PACKAGEDIR}/llvm')") # CMAKE_INSTALL_PACKAGEDIR might be absolute, so don't reuse below. -set(llvm_cmake_builddir "${LLVM_BINARY_DIR}/lib${LLVM_LIBDIR_SUFFIX}/cmake/llvm") +set(llvm_cmake_builddir "${LLVM_LIBRARY_DIR}/cmake/llvm") get_property(MLIR_EXPORTS GLOBAL PROPERTY MLIR_EXPORTS) export(TARGETS ${MLIR_EXPORTS} FILE ${mlir_cmake_builddir}/MLIRTargets.cmake) Index: llvm/unittests/tools/llvm-mca/X86/CMakeLists.txt =================================================================== --- llvm/unittests/tools/llvm-mca/X86/CMakeLists.txt +++ llvm/unittests/tools/llvm-mca/X86/CMakeLists.txt @@ -1,6 +1,6 @@ add_llvm_mca_unittest_includes( ${LLVM_MAIN_SRC_DIR}/lib/Target/X86 - ${LLVM_BINARY_DIR}/lib/Target/X86 + ${LLVM_LIBRARY_DIR}/Target/X86 ) add_llvm_mca_unittest_sources( Index: llvm/unittests/tools/llvm-exegesis/X86/CMakeLists.txt =================================================================== --- llvm/unittests/tools/llvm-exegesis/X86/CMakeLists.txt +++ llvm/unittests/tools/llvm-exegesis/X86/CMakeLists.txt @@ -1,6 +1,6 @@ add_llvm_exegesis_unittest_includes( ${LLVM_MAIN_SRC_DIR}/lib/Target/X86 - ${LLVM_BINARY_DIR}/lib/Target/X86 + ${LLVM_LIBRARY_DIR}/Target/X86 ${LLVM_MAIN_SRC_DIR}/tools/llvm-exegesis/lib ) Index: llvm/unittests/tools/llvm-exegesis/PowerPC/CMakeLists.txt =================================================================== --- llvm/unittests/tools/llvm-exegesis/PowerPC/CMakeLists.txt +++ llvm/unittests/tools/llvm-exegesis/PowerPC/CMakeLists.txt @@ -1,6 +1,6 @@ add_llvm_exegesis_unittest_includes( ${LLVM_MAIN_SRC_DIR}/lib/Target/PowerPC - ${LLVM_BINARY_DIR}/lib/Target/PowerPC + ${LLVM_LIBRARY_DIR}/Target/PowerPC ${LLVM_MAIN_SRC_DIR}/tools/llvm-exegesis/lib ) Index: llvm/unittests/tools/llvm-exegesis/Mips/CMakeLists.txt =================================================================== --- llvm/unittests/tools/llvm-exegesis/Mips/CMakeLists.txt +++ llvm/unittests/tools/llvm-exegesis/Mips/CMakeLists.txt @@ -1,6 +1,6 @@ add_llvm_exegesis_unittest_includes( ${LLVM_MAIN_SRC_DIR}/lib/Target/Mips - ${LLVM_BINARY_DIR}/lib/Target/Mips + ${LLVM_LIBRARY_DIR}/Target/Mips ${LLVM_MAIN_SRC_DIR}/tools/llvm-exegesis/lib ) Index: llvm/unittests/tools/llvm-exegesis/ARM/CMakeLists.txt =================================================================== --- llvm/unittests/tools/llvm-exegesis/ARM/CMakeLists.txt +++ llvm/unittests/tools/llvm-exegesis/ARM/CMakeLists.txt @@ -1,6 +1,6 @@ add_llvm_exegesis_unittest_includes( ${LLVM_MAIN_SRC_DIR}/lib/Target/ARM - ${LLVM_BINARY_DIR}/lib/Target/ARM + ${LLVM_LIBRARY_DIR}/Target/ARM ${LLVM_MAIN_SRC_DIR}/tools/llvm-exegesis/lib ) Index: llvm/unittests/tools/llvm-exegesis/AArch64/CMakeLists.txt =================================================================== --- llvm/unittests/tools/llvm-exegesis/AArch64/CMakeLists.txt +++ llvm/unittests/tools/llvm-exegesis/AArch64/CMakeLists.txt @@ -1,6 +1,6 @@ add_llvm_exegesis_unittest_includes( ${LLVM_MAIN_SRC_DIR}/lib/Target/AArch64 - ${LLVM_BINARY_DIR}/lib/Target/AArch64 + ${LLVM_LIBRARY_DIR}/Target/AArch64 ${LLVM_MAIN_SRC_DIR}/tools/llvm-exegesis/lib ) Index: llvm/unittests/Target/DirectX/CMakeLists.txt =================================================================== --- llvm/unittests/Target/DirectX/CMakeLists.txt +++ llvm/unittests/Target/DirectX/CMakeLists.txt @@ -1,6 +1,6 @@ include_directories( ${LLVM_MAIN_SRC_DIR}/lib/Target/DirectX - ${LLVM_BINARY_DIR}/lib/Target/DirectX + ${LLVM_LIBRARY_DIR}/Target/DirectX ) set(LLVM_LINK_COMPONENTS Index: llvm/unittests/Target/ARM/CMakeLists.txt =================================================================== --- llvm/unittests/Target/ARM/CMakeLists.txt +++ llvm/unittests/Target/ARM/CMakeLists.txt @@ -1,6 +1,6 @@ include_directories( ${LLVM_MAIN_SRC_DIR}/lib/Target/ARM - ${LLVM_BINARY_DIR}/lib/Target/ARM + ${LLVM_LIBRARY_DIR}/Target/ARM ) set(LLVM_LINK_COMPONENTS Index: llvm/tools/llvm-shlib/CMakeLists.txt =================================================================== --- llvm/tools/llvm-shlib/CMakeLists.txt +++ llvm/tools/llvm-shlib/CMakeLists.txt @@ -88,7 +88,7 @@ set(LLVM_EXPORTED_SYMBOL_FILE ${LLVM_BINARY_DIR}/libllvm-c.exports) - set(LIB_DIR ${LLVM_BINARY_DIR}/${CMAKE_CFG_INTDIR}/lib${LLVM_LIBDIR_SUFFIX}) + set(LIB_DIR ${LLVM_LIBRARY_DIR}) set(LIB_NAME ${LIB_DIR}/${CMAKE_SHARED_LIBRARY_PREFIX}LLVM) set(LIB_PATH ${LIB_NAME}${CMAKE_SHARED_LIBRARY_SUFFIX}) set(LIB_EXPORTS_PATH ${LIB_NAME}.exports) @@ -136,7 +136,7 @@ # Get the full name to the libs so the python script understands them. foreach(lib ${LIB_NAMES}) - list(APPEND FULL_LIB_NAMES ${LLVM_BINARY_DIR}/${CMAKE_CFG_INTDIR}/lib/${lib}.lib) + list(APPEND FULL_LIB_NAMES ${LLVM_LIBRARY_DIR}/${lib}.lib) endforeach() # Need to separate lib names with newlines. Index: llvm/tools/llvm-exegesis/lib/X86/CMakeLists.txt =================================================================== --- llvm/tools/llvm-exegesis/lib/X86/CMakeLists.txt +++ llvm/tools/llvm-exegesis/lib/X86/CMakeLists.txt @@ -1,6 +1,6 @@ include_directories( ${LLVM_MAIN_SRC_DIR}/lib/Target/X86 - ${LLVM_BINARY_DIR}/lib/Target/X86 + ${LLVM_LIBRARY_DIR}/Target/X86 ) set(LLVM_LINK_COMPONENTS Index: llvm/tools/llvm-exegesis/lib/PowerPC/CMakeLists.txt =================================================================== --- llvm/tools/llvm-exegesis/lib/PowerPC/CMakeLists.txt +++ llvm/tools/llvm-exegesis/lib/PowerPC/CMakeLists.txt @@ -1,6 +1,6 @@ include_directories( ${LLVM_MAIN_SRC_DIR}/lib/Target/PowerPC - ${LLVM_BINARY_DIR}/lib/Target/PowerPC + ${LLVM_LIBRARY_DIR}/Target/PowerPC ) set(LLVM_LINK_COMPONENTS Index: llvm/tools/llvm-exegesis/lib/Mips/CMakeLists.txt =================================================================== --- llvm/tools/llvm-exegesis/lib/Mips/CMakeLists.txt +++ llvm/tools/llvm-exegesis/lib/Mips/CMakeLists.txt @@ -1,6 +1,6 @@ include_directories( ${LLVM_MAIN_SRC_DIR}/lib/Target/Mips - ${LLVM_BINARY_DIR}/lib/Target/Mips + ${LLVM_LIBRARY_DIR}/Target/Mips ) set(LLVM_LINK_COMPONENTS Index: llvm/tools/llvm-exegesis/lib/AArch64/CMakeLists.txt =================================================================== --- llvm/tools/llvm-exegesis/lib/AArch64/CMakeLists.txt +++ llvm/tools/llvm-exegesis/lib/AArch64/CMakeLists.txt @@ -1,6 +1,6 @@ include_directories( ${LLVM_MAIN_SRC_DIR}/lib/Target/AArch64 - ${LLVM_BINARY_DIR}/lib/Target/AArch64 + ${LLVM_LIBRARY_DIR}/Target/AArch64 ) set(LLVM_LINK_COMPONENTS Index: llvm/cmake/modules/CMakeLists.txt =================================================================== --- llvm/cmake/modules/CMakeLists.txt +++ llvm/cmake/modules/CMakeLists.txt @@ -3,7 +3,7 @@ include(FindPrefixFromConfig) # CMAKE_INSTALL_PACKAGEDIR might be absolute, so don't reuse below. -set(llvm_cmake_builddir "${LLVM_BINARY_DIR}/lib${LLVM_LIBDIR_SUFFIX}/cmake/llvm") +set(llvm_cmake_builddir "${LLVM_LIBRARY_DIR}/cmake/llvm") # First for users who use an installed LLVM, create the LLVMExports.cmake file. set(LLVM_EXPORTS_FILE ${llvm_cmake_builddir}/LLVMExports.cmake) Index: llvm/cmake/modules/AddLLVM.cmake =================================================================== --- llvm/cmake/modules/AddLLVM.cmake +++ llvm/cmake/modules/AddLLVM.cmake @@ -1093,7 +1093,7 @@ message(FATAL_ERROR "LLVM_INSTALL_PACKAGE_DIR must be defined and writable. GEN_CONFIG should only be passe when building LLVM proper.") endif() # LLVM_INSTALL_PACKAGE_DIR might be absolute, so don't reuse below. - set(llvm_cmake_builddir "${LLVM_BINARY_DIR}/lib${LLVM_LIBDIR_SUFFIX}/cmake/llvm") + set(llvm_cmake_builddir "${LLVM_LIBRARY_DIR}/cmake/llvm") file(WRITE "${llvm_cmake_builddir}/LLVMConfigExtensions.cmake" "set(LLVM_STATIC_EXTENSIONS ${LLVM_STATIC_EXTENSIONS})") Index: llvm/CMakeLists.txt =================================================================== --- llvm/CMakeLists.txt +++ llvm/CMakeLists.txt @@ -921,9 +921,9 @@ ) # They are not referenced. See set_output_directory(). -set( CMAKE_RUNTIME_OUTPUT_DIRECTORY ${LLVM_BINARY_DIR}/bin ) -set( CMAKE_LIBRARY_OUTPUT_DIRECTORY ${LLVM_BINARY_DIR}/lib${LLVM_LIBDIR_SUFFIX} ) -set( CMAKE_ARCHIVE_OUTPUT_DIRECTORY ${LLVM_BINARY_DIR}/lib${LLVM_LIBDIR_SUFFIX} ) +set( CMAKE_RUNTIME_OUTPUT_DIRECTORY ${LLVM_TOOLS_BINARY_DIR} ) +set( CMAKE_LIBRARY_OUTPUT_DIRECTORY ${LLVM_LIBRARY_DIR} ) +set( CMAKE_ARCHIVE_OUTPUT_DIRECTORY ${LLVM_LIBRARY_DIR} ) if(LLVM_INCLUDE_TESTS) include(GetErrcMessages) Index: lldb/test/API/CMakeLists.txt =================================================================== --- lldb/test/API/CMakeLists.txt +++ lldb/test/API/CMakeLists.txt @@ -45,10 +45,10 @@ # Set the path to the default lldb test executable. set(LLDB_DEFAULT_TEST_EXECUTABLE "${LLVM_RUNTIME_OUTPUT_INTDIR}/lldb${CMAKE_EXECUTABLE_SUFFIX}") -set(LLDB_DEFAULT_TEST_DSYMUTIL "${LLVM_BINARY_DIR}/${CMAKE_CFG_INTDIR}/bin/dsymutil${CMAKE_EXECUTABLE_SUFFIX}") +set(LLDB_DEFAULT_TEST_DSYMUTIL "${LLVM_TOOLS_BINARY_DIR}/dsymutil${CMAKE_EXECUTABLE_SUFFIX}") if (TARGET clang) - set(LLDB_DEFAULT_TEST_COMPILER "${LLVM_BINARY_DIR}/${CMAKE_CFG_INTDIR}/bin/clang${CMAKE_EXECUTABLE_SUFFIX}") + set(LLDB_DEFAULT_TEST_COMPILER "${LLVM_TOOLS_BINARY_DIR}/clang${CMAKE_EXECUTABLE_SUFFIX}") else() set(LLDB_DEFAULT_TEST_COMPILER "") endif() Index: lldb/cmake/modules/LLDBConfig.cmake =================================================================== --- lldb/cmake/modules/LLDBConfig.cmake +++ lldb/cmake/modules/LLDBConfig.cmake @@ -276,7 +276,7 @@ # could be and pick the first that exists. foreach(CANDIDATE "${Clang_DIR}/../.." "${LLVM_DIR}" "${LLVM_LIBRARY_DIRS}" "${LLVM_BUILD_LIBRARY_DIR}" - "${LLVM_BINARY_DIR}/lib${LLVM_LIBDIR_SUFFIX}") + "${LLVM_LIBRARY_DIR}") # Build the resource directory path by appending 'clang/<version number>'. set(CANDIDATE_RESOURCE_DIR "${CANDIDATE}/clang/${LLDB_CLANG_RESOURCE_DIR_NAME}") if (IS_DIRECTORY "${CANDIDATE_RESOURCE_DIR}") Index: lld/cmake/modules/CMakeLists.txt =================================================================== --- lld/cmake/modules/CMakeLists.txt +++ lld/cmake/modules/CMakeLists.txt @@ -14,7 +14,7 @@ set(LLVM_INSTALL_PACKAGE_DIR "${CMAKE_INSTALL_PACKAGEDIR}/llvm" CACHE STRING "Path for CMake subdirectory for LLVM (defaults to '${CMAKE_INSTALL_PACKAGEDIR}/llvm')") # CMAKE_INSTALL_PACKAGEDIR might be absolute, so don't reuse below. -set(llvm_cmake_builddir "${LLVM_BINARY_DIR}/lib${LLVM_LIBDIR_SUFFIX}/cmake/llvm") +set(llvm_cmake_builddir "${LLVM_LIBRARY_DIR}/cmake/llvm") get_property(LLD_EXPORTS GLOBAL PROPERTY LLD_EXPORTS) export(TARGETS ${LLD_EXPORTS} FILE ${lld_cmake_builddir}/LLDTargets.cmake) Index: flang/cmake/modules/CMakeLists.txt =================================================================== --- flang/cmake/modules/CMakeLists.txt +++ flang/cmake/modules/CMakeLists.txt @@ -14,7 +14,7 @@ set(LLVM_INSTALL_PACKAGE_DIR "${CMAKE_INSTALL_PACKAGEDIR}/llvm" CACHE STRING "Path for CMake subdirectory for LLVM (defaults to '${CMAKE_INSTALL_PACKAGEDIR}/llvm')") # CMAKE_INSTALL_PACKAGEDIR might be absolute, so don't reuse below. -set(llvm_cmake_builddir "${LLVM_BINARY_DIR}/lib${LLVM_LIBDIR_SUFFIX}/cmake/llvm") +set(llvm_cmake_builddir "${LLVM_LIBRARY_DIR}/cmake/llvm") get_property(FLANG_EXPORTS GLOBAL PROPERTY FLANG_EXPORTS) export(TARGETS ${FLANG_EXPORTS} FILE ${flang_cmake_builddir}/FlangTargets.cmake) Index: clang/lib/Tooling/CMakeLists.txt =================================================================== --- clang/lib/Tooling/CMakeLists.txt +++ clang/lib/Tooling/CMakeLists.txt @@ -60,7 +60,7 @@ $<TARGET_FILE:clang-ast-dump> # Skip this in debug mode because parsing AST.h is too slow --skip-processing=${skip_expensive_processing} - -I ${LLVM_BINARY_DIR}/lib/clang/${CLANG_VERSION}/include + -I ${LLVM_LIBRARY_DIR}/clang/${CLANG_VERSION}/include -I ${CLANG_SOURCE_DIR}/include -I ${LLVM_BINARY_DIR}/tools/clang/include -I ${LLVM_BINARY_DIR}/include Index: clang/cmake/modules/CMakeLists.txt =================================================================== --- clang/cmake/modules/CMakeLists.txt +++ clang/cmake/modules/CMakeLists.txt @@ -15,7 +15,7 @@ set(LLVM_INSTALL_PACKAGE_DIR "${CMAKE_INSTALL_PACKAGEDIR}/llvm" CACHE STRING "Path for CMake subdirectory for LLVM (defaults to '${CMAKE_INSTALL_PACKAGEDIR}/llvm')") # CMAKE_INSTALL_PACKAGEDIR might be absolute, so don't reuse below. -set(llvm_cmake_builddir "${LLVM_BINARY_DIR}/lib${LLVM_LIBDIR_SUFFIX}/cmake/llvm") +set(llvm_cmake_builddir "${LLVM_LIBRARY_DIR}/cmake/llvm") get_property(CLANG_EXPORTS GLOBAL PROPERTY CLANG_EXPORTS) export(TARGETS ${CLANG_EXPORTS} FILE ${clang_cmake_builddir}/ClangTargets.cmake) Index: bolt/unittests/Core/CMakeLists.txt =================================================================== --- bolt/unittests/Core/CMakeLists.txt +++ bolt/unittests/Core/CMakeLists.txt @@ -20,7 +20,7 @@ if ("AArch64" IN_LIST LLVM_TARGETS_TO_BUILD) include_directories( ${LLVM_MAIN_SRC_DIR}/lib/Target/AArch64 - ${LLVM_BINARY_DIR}/lib/Target/AArch64 + ${LLVM_LIBRARY_DIR}/Target/AArch64 ) target_compile_definitions(CoreTests PRIVATE AARCH64_AVAILABLE) @@ -29,7 +29,7 @@ if ("X86" IN_LIST LLVM_TARGETS_TO_BUILD) include_directories( ${LLVM_MAIN_SRC_DIR}/lib/Target/X86 - ${LLVM_BINARY_DIR}/lib/Target/X86 + ${LLVM_LIBRARY_DIR}/Target/X86 ) target_compile_definitions(CoreTests PRIVATE X86_AVAILABLE) Index: bolt/lib/Target/X86/CMakeLists.txt =================================================================== --- bolt/lib/Target/X86/CMakeLists.txt +++ bolt/lib/Target/X86/CMakeLists.txt @@ -17,5 +17,5 @@ include_directories( ${LLVM_MAIN_SRC_DIR}/lib/Target/X86 - ${LLVM_BINARY_DIR}/lib/Target/X86 + ${LLVM_LIBRARY_DIR}/Target/X86 ) Index: bolt/lib/Target/AArch64/CMakeLists.txt =================================================================== --- bolt/lib/Target/AArch64/CMakeLists.txt +++ bolt/lib/Target/AArch64/CMakeLists.txt @@ -14,5 +14,5 @@ include_directories( ${LLVM_MAIN_SRC_DIR}/lib/Target/AArch64 - ${LLVM_BINARY_DIR}/lib/Target/AArch64 + ${LLVM_LIBRARY_DIR}/Target/AArch64 )
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits