[PATCH] D140828: [C++] Implement "Deducing this" (P0847R7)

cor3ntin marked 2 inline comments as done. cor3ntin added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:7260-7265 +def ext_deducing_this : ExtWarn< + "explicit object parameters are a C++2b extension">, + InGroup; +def warn_cxx20_ext_deducing_thi

[PATCH] D140828: [C++] Implement "Deducing this" (P0847R7)

cor3ntin added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:13033 + ExprResult Res = FixOverloadedFunctionReference(E, DAP, Found); + if (Res.isInvalid()) +return false; aaron.ballman wrote: > Below you assume that `Res.get()` returns a nonn

[PATCH] D158591: Add support of Windows Trace Logging macros

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. I'm happy punting the new interpreter to a subsequent PR, maybe there are unresolved issues with string literals? Anyway, we don't have to scope creep further, LGTM Thanks for working on t

[PATCH] D158718: [Clang] Handle ellipsises in abiguous cast expressions.

cor3ntin abandoned this revision. cor3ntin added a comment. As described here, clang is actually conforming, there is an open core issue with unclear resolution and that ""fix"" doesn't cover all the ambiguous use cases https://github.com/llvm/llvm-project/issues/64926 Repository: rG LLVM Gi

[PATCH] D140828: [C++] Implement "Deducing this" (P0847R7)

cor3ntin marked 3 inline comments as done. cor3ntin added inline comments. Comment at: clang/include/clang/AST/ASTLambda.h:45 + return isLambdaCallOperator(DC) && + !cast(DC)->getType().isNull() && + !cast(DC)->isExplicitObjectMemberFunction(); e

[PATCH] D158808: [Clang] Modify Parser::ParseLambdaExpressionAfterIntroducer to check whether the lambda-declarator is valid

cor3ntin added a comment. Still missing a release note. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158808/new/ https://reviews.llvm.org/D158808 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[PATCH] D140828: [C++] Implement "Deducing this" (P0847R7)

cor3ntin added inline comments. Comment at: clang/lib/AST/DeclCXX.cpp:841 const auto *ParamTy = - Method->getParamDecl(0)->getType()->getAs(); + Method->getNonObjectParameter(0)->getType()->getAs(); if (!ParamTy || ParamTy->getPointeeType().isConst

[PATCH] D140828: [C++] Implement "Deducing this" (P0847R7)

cor3ntin added inline comments. Comment at: clang/test/CodeGenCXX/cxx2b-deducing-this.cpp:4 + +struct TrivialStruct { +void explicit_object_function(this TrivialStruct) {} cor3ntin wrote: > aaron.ballman wrote: > > I'd like to see more codegen tests in genera

[PATCH] D159024: [Parser] Parse string literal arguments of 'availability', 'external_source_symbol' and 'uuid' attributes as unevaluated

cor3ntin added a comment. Thanks a lot for working on this. LGTM, except for the failing test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159024/new/ https://reviews.llvm.org/D159024 ___ cfe-commits ma

[PATCH] D158933: [clang] Implement -funsigned-bitfields

cor3ntin added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:18137 + + // TODO: Somehow get the explicit signdness info, maybe with the usage of + // the typedef's name (Typedef->getDecl()->getNameAsString()), look it up The information seems

[PATCH] D156565: Diagnose use of VLAs in C++ by default

cor3ntin added a comment. In D156565#4605027 , @shafik wrote: > In D156565#4599812 , @aaron.ballman > wrote: > >> Enable the diagnostic by default in C++ language modes, and under -Wall in >> GNU++ language mode

[PATCH] D158808: [Clang] Modify Parser::ParseLambdaExpressionAfterIntroducer to check whether the lambda-declarator is valid

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158808/new/ https://reviews.llvm.org/D158808 ___ cfe-commits mailing list cfe-co

[PATCH] D159126: [Clang] Add captures to the instantiation scope of lambda call operators

cor3ntin created this revision. Herald added subscribers: ChuanqiXu, Anastasia. Herald added a project: All. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Like concepts checking, a trailing return type of a lambda in a dependent

[PATCH] D159126: [Clang] Add captures to the instantiation scope of lambda call operators

cor3ntin added a subscriber: beanz. cor3ntin added a comment. @beanz The changes to TreeTransform.h cause a lot of HLSL test failures similar to this one: clang: /home/cor3ntin/dev/compilers/LLVM/llvm-project/clang/lib/AST/ExprClassification.cpp:57: Cl clang::Expr::ClassifyImpl(clang::ASTCon

[PATCH] D159126: [Clang] Add captures to the instantiation scope of lambda call operators

cor3ntin added a comment. @beanz Oh wow, excellent, i did not expect a solution so fast! I'm glad to know there may indeed be an issue with HLSL rather than this patch because I'm not sure I could have come up with a different fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D159024: [Parser] Parse string literal arguments of 'availability', 'external_source_symbol' and 'uuid' attributes as unevaluated

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. LGTM. Thanks again for working on this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159024/new/ https://reviews.llvm.org/D159024

[PATCH] D159133: [Sema] Make C++ functional-style cast warn about dropped qualifiers (-Wcast-qual)

cor3ntin added a comment. I think this should get a mention in clang's releases notes. Otherwise LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159133/new/ https://reviews.llvm.org/D159133 ___ cfe-co

[PATCH] D152495: [Clang][SemaCXX] Add unused warning for variables declared in condition expressions

cor3ntin added a comment. It is used, but only in an assert. Seems like the right fix! In D152495#4628778 , @smeenai wrote: > In D152495#4628028 , @goncharov > wrote: > >> there is a number of unused vaiables in

[PATCH] D159247: [HLSL] Cleanup support for `this` as an l-value

cor3ntin added a comment. Thanks for working on this. This is going to conflict with deducing this (https://reviews.llvm.org/D140828) in interesting (ie, horrible) ways, so i guess I'll have to deal with that. For people following along we are trying to fix nasty lambda regression https://review

[PATCH] D159247: [HLSL] Cleanup support for `this` as an l-value

cor3ntin added a comment. I would like @aaron.ballman to weight in, (he might not get back to you until next week), but overall, i think I'm pretty happy with this new direction. Comment at: clang/include/clang/AST/DeclCXX.h:2174 + static QualType getThisType(const Functi

[PATCH] D159307: [Sema] add test cases for D152495

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. LGTM (this could be a NFC change) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159307/new/ https://reviews.llvm.org/D159307 __

[PATCH] D159345: [Clang] Handle non-ASCII after line splicing

cor3ntin created this revision. Herald added a project: All. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. int a\ ス; Failed to be parsed as a valid identifier. Fixes #65156 Repository: rG LLVM Github Monorepo https://revie

[PATCH] D159358: [Clang] Realize generic lambda call operators are dependent sooner

cor3ntin created this revision. Herald added a project: All. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When parsing a trailing return type / noexcept / constraint of a generic lambda, we need to know that we are in a dependen

[PATCH] D159358: [Clang] Realize generic lambda call operators are dependent sooner

cor3ntin updated this revision to Diff 555374. cor3ntin added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159358/new/ https://reviews.llvm.org/D159358 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Sema/Sema.h cla

[PATCH] D159358: [Clang] Realize generic lambda call operators are dependent sooner

cor3ntin updated this revision to Diff 555375. cor3ntin added a comment. Fix tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159358/new/ https://reviews.llvm.org/D159358 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Sema/Sema.h

[PATCH] D159358: [Clang] Realize generic lambda call operators are dependent sooner

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG890f11d60fef: [Clang] Realize generic lambda call operators are dependent sooner (authored by cor3ntin). Changed prior to commit: https://reviews.

[PATCH] D159345: [Clang] Handle non-ASCII after line splicing

cor3ntin updated this revision to Diff 63. cor3ntin marked an inline comment as done. cor3ntin added a comment. Add and fix comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159345/new/ https://reviews.llvm.org/D159345 Files: clang/docs

[PATCH] D159345: [Clang] Handle non-ASCII after line splicing

cor3ntin added inline comments. Comment at: clang/lib/Lex/Lexer.cpp:1761 + getCharAndSize(CurPtr, FirstCodeUnitSize); + const char *CharStart = CurPtr + FirstCodeUnitSize - 1; + const char *UnicodePtr = CharStart; shafik wrote: > Do we need to verify that `Fir

[PATCH] D158591: Add support of Windows Trace Logging macros

cor3ntin added a comment. @RIscRIpt Do you need further help on this patch? You have commit access, right? (I'm trying to make sure things don't fall through the cracks as we move to github) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158591/ne

[PATCH] D154893: [Clang] Fix some triviality computations

cor3ntin added a comment. @royjacobson Are you still working on that? It seems it's only missing updates to a comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154893/new/ https://reviews.llvm.org/D154893 _

[PATCH] D154716: [SemaCXX] Fix bug where unexpanded lambda captures where assumed to be expanded

cor3ntin added a comment. @MitalAshok Are you still working on this? Do you need further help on this patch? You have commit access, correct? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154716/new/ https://reviews.llvm.org/D154716 _

[PATCH] D158591: Add support of Windows Trace Logging macros

cor3ntin added a comment. Oh! I should have asked sooner. Will do! Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158591/new/ https://reviews.llvm.org/D158591 ___ cfe-commits mailing list cfe-commi

[PATCH] D158591: Add support of Windows Trace Logging macros

cor3ntin added a comment. Hum. before I do - I think the commit message could be more explicit as to what the patch does ("Add support of Windows Trace Logging macros" is a bit vague) - Do we need a release note ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D158591: Add support of Windows Trace Logging macros

cor3ntin updated this revision to Diff 555712. cor3ntin added a comment. Add release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158591/new/ https://reviews.llvm.org/D158591 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Sema/Se

[PATCH] D158591: Add support of Windows Trace Logging macros

cor3ntin added a comment. @RIscRIpt I added release notes, let me know if you are happy with everything before i land Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158591/new/ https://reviews.llvm.org/D158591 _

[PATCH] D158591: Add support of Windows Trace Logging macros

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe6d305e64fd3: Add support of Windows Trace Logging macros (authored by RIscRIpt, committed by cor3ntin). Changed prior to commit: https://reviews.

[PATCH] D155627: [clang][Interp] Handle SourceLocExprs

cor3ntin added a comment. So you can enable some of the sema source location tests? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155627/new/ https://reviews.llvm.org/D155627 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[PATCH] D154773: [AST] Use correct APSInt width when evaluating string literals

cor3ntin added a comment. @barannikov88 Don't forget to land this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154773/new/ https://reviews.llvm.org/D154773 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D92733: Fix PR25627 - false positive diagnostics involving implicit-captures in dependent lambda expressions.

cor3ntin added a subscriber: Fznamznon. cor3ntin added a comment. @Fznamznon This might be of interest to you @faisalv are you still working on this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92733/new/ https://reviews.llvm.org/D92733 ___

[PATCH] D159393: [clang] Fix several issues in the generated AttrHasAttributeImpl.inc

cor3ntin added a comment. No, existing PRs can stay there. I'm waiting for @aaron.ballman, our resident attributes guru, to look at that - even if the changes look reasonably good to me Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159393/new/ ht

[PATCH] D159126: [Clang] Add captures to the instantiation scope of lambda call operators

cor3ntin updated this revision to Diff 555973. cor3ntin added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159126/new/ https://reviews.llvm.org/D159126 Files: clang/include/clang/Sema/Sema.h clang/lib/Sema/SemaConcept.cpp

[PATCH] D159126: [Clang] Add captures to the instantiation scope of lambda call operators

cor3ntin updated this revision to Diff 555974. cor3ntin added a comment. Rebase and cleanups Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159126/new/ https://reviews.llvm.org/D159126 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Sema

[PATCH] D159126: [Clang] Add captures to the instantiation scope of lambda call operators

cor3ntin added a comment. @erichkeane @aaron.ballman This now pass the tests and is ready for review :) Thanks to @beanz for the quick turnaround on the HLSL issue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159126/new/ https://reviews.llvm.org/

[PATCH] D157526: [clang][Sema] Remove irrelevant diagnostics from constraint satisfaction failure

cor3ntin added a comment. Given that we still need to check for substitution errors in untaken branches, this look reasonable (especially as i think you are right that alternative approaches are likely to be more complex) however i think it does require a comment, and I'd like @erichkeane to ha

[PATCH] D159126: [Clang] Add captures to the instantiation scope of lambda call operators

cor3ntin added inline comments. Comment at: clang/lib/Sema/SemaLambda.cpp:2263 +LocalInstantiationScope &Scope) +: FunctionScope(SemasRef) { + if (!isLambdaCallOperator(FD)) { erichkeane wrote: > Wonder if `LambdaScopeForCallOperatorInstantiationRAII

[PATCH] D159126: [Clang] Add captures to the instantiation scope of lambda call operators

cor3ntin updated this revision to Diff 556068. cor3ntin added a comment. Inherit from FunctionScopeRAII as per @erichkeane Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159126/new/ https://reviews.llvm.org/D159126 Files: clang/docs/ReleaseNotes.

[PATCH] D159126: [Clang] Add captures to the instantiation scope of lambda call operators

cor3ntin added inline comments. Comment at: clang/lib/Sema/SemaLambda.cpp:2263 +LocalInstantiationScope &Scope) +: FunctionScope(SemasRef) { + if (!isLambdaCallOperator(FD)) { erichkeane wrote: > cor3ntin wrote: > > erichkeane wrote: > > > Wonder if

[PATCH] D159126: [Clang] Add captures to the instantiation scope of lambda call operators

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeaf725bc9371: [Clang] Add captures to the instantiation scope of lambda call operators (authored by cor3ntin). Repository: rG LLVM Github Monorepo

[PATCH] D159345: [Clang] Handle non-ASCII after line splicing

cor3ntin updated this revision to Diff 556076. cor3ntin added a comment. Address Tom's feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159345/new/ https://reviews.llvm.org/D159345 Files: clang/docs/ReleaseNotes.rst clang/include/clang/L

[PATCH] D155610: [Clang][Sema] Fix display of characters on static assertion failure

cor3ntin added inline comments. Comment at: clang/test/SemaCXX/static-assert-cxx26.cpp:304 +static_assert('\u{9}' == (char)1, ""); // expected-error {{failed}} \ + // expected-note {{evaluates to ''\t' (0x09, 9) == '' (0x01, 1)'}} +static_as

[PATCH] D155610: [Clang][Sema] Fix display of characters on static assertion failure

cor3ntin added inline comments. Comment at: clang/test/SemaCXX/static-assert.cpp:287 + static_assert((char16_t)L'ゆ' == L"C̵̭̯̠̎͌ͅť̺"[1], ""); // expected-error {{failed}} \ + // expected-note {{evaluates to ''ゆ' (0x3086) == '̵'

[PATCH] D155610: [Clang][Sema] Fix display of characters on static assertion failure

cor3ntin added a comment. @hazohelet I'm happy with the patch, I just need to make sure Hubert and I agree! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155610/new/ https://reviews.llvm.org/D155610 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D159345: [Clang] Handle non-ASCII after line splicing

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3eb67d28dee5: [Clang] Handle non-ASCII after line splicing (authored by cor3ntin). Changed prior to commit: https://reviews.llvm.org/D159345?vs=55

[PATCH] D159345: [Clang] Handle non-ASCII after line splicing

cor3ntin added a comment. In D159345#4640147 , @tahonermann wrote: > Even better than I asked for. I held back on suggesting the change of `Tok` > to `Result` to match `tryConsumeIdentifierUCN()`, but you made that change > anyway! You must have read m

[PATCH] D155610: [Clang][Sema] Fix display of characters on static assertion failure

cor3ntin added inline comments. Comment at: clang/test/SemaCXX/static-assert-cxx26.cpp:304 +static_assert('\u{9}' == (char)1, ""); // expected-error {{failed}} \ + // expected-note {{evaluates to ''\t' (0x09, 9) == '' (0x01, 1)'}} +static_as

[PATCH] D159126: [Clang] Add captures to the instantiation scope of lambda call operators

cor3ntin added a comment. @abrachet Thanks, i've reverted the patch while i investigate a fix I managed to reduced it to template concept cs = requires(b bj) { bj.begin(); }; struct { template requires cs auto operator()(b &&) {} } begin; template concept cu = re

[PATCH] D159126: [Clang] Add captures to the instantiation scope of lambda call operators

cor3ntin updated this revision to Diff 556115. cor3ntin added a comment. Fix libc++ compile @erichkeane I struggle to reduce further, do you think it's worth adding this inscrutable test case somewhere? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D158702: [clang][Interp] Check pointer inc/dec ops for initialization

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158702/new/ https://reviews.llvm.org/D158702 ___

[PATCH] D156400: [clang][Interp] Implement __builtin_offsetof

cor3ntin added a comment. Generally looks good but still a few unaddressed comments Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:1536-1537 + // Cast to Sint64. + if (IndexT != PT_Sint64) { +if (!this->emitCast(IndexT, PT_Sint64, E)) + return f

[PATCH] D156032: Implement CWG2137 (list-initialization from objects of the same type)

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. LGTM modulo one nit. @hubert.reinterpretcast If you want to make sure this is conforming Comment at: clang/docs/ReleaseNotes.rst:99 + list-initialization from objects of

[PATCH] D155064: [clang][SemaCXX] Diagnose tautological uses of consteval if and is_constant_evaluated

cor3ntin added a comment. @philnik @Mordante were the libc++ concerns addressed? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155064/new/ https://reviews.llvm.org/D155064 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[PATCH] D152083: [clang] Warning for incomplete array initializer lists

cor3ntin added a comment. Can you test in c++ mode? I'd like to see a test for something like struct { int a, b, c, d = 1; // d has an initializer } bar2 = { .a = 1, .b = 1, .c = 1 }; Otherwise looks good CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D138387: [Clang] Implement static operator[]

cor3ntin added a comment. Thanks for working on this, it was fast! It looks good except for an issue with the diagnostic (which was partly pre-existing) Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:9111-9115 def ext_operator_overload_static : ExtWarn< "decl

[PATCH] D124351: [Clang][WIP] Implement Change scope of lambda trailing-return-type - Take 2

cor3ntin added a comment. Now that Kona is over, I'm hoping to get back to that in the coming weeks. Rebasing will be... fun. I want to make sure we are all okay making that a DR following WG21 guidance, given that not making it a DR would have potentially large impact on the PR. Thanks! Repos

[PATCH] D124351: [Clang][WIP] Implement Change scope of lambda trailing-return-type - Take 2

cor3ntin added a comment. In D124351#3940888 , @aaron.ballman wrote: > In D124351#3940786 , @cor3ntin > wrote: > >> Now that Kona is over, I'm hoping to get back to that in the coming weeks. >> Rebasing will be

[PATCH] D136554: Implement CWG2631

cor3ntin updated this revision to Diff 477003. cor3ntin added a comment. Properly mark default members initializers as ODR-used. default members initializers were marked as maybe odr-used but never actually odr-used. We fix that by checking that an initializer consitutes a full expression at th

[PATCH] D138387: [Clang] Implement static operator[]

cor3ntin added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:14462-14467 + RLoc, CurFPFeatureOverrides()); +else + TheCall = + CallExpr::Create(Context, FnExpr.get(), MethodArgs, ResultTy, VK, +

[PATCH] D138387: [Clang] Implement static operator[]

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. Beside the formatting nitpick this looks good Comment at: clang/test/CodeGenCXX/cxx2b-static-subscript-operator.cpp:14 + f.operator[](201, 202); + Functor{}[301, 302];

[PATCH] D124351: [Clang][WIP] Implement Change scope of lambda trailing-return-type - Take 2

cor3ntin updated this revision to Diff 477938. cor3ntin added a comment. Rebase. This is still a bit rough, I have a few tests to fix and some dead code to remove. --- @erichkeanne I wouldn't mind picking your brain on this. Consider: template void dependent_init_capture(T x = 0) { [y

[PATCH] D138749: [clang] Compare constraints before diagnosing mismatched ref qualifiers (GH58962)

cor3ntin added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:1324 +if ((NewRC != nullptr) != (OldRC != nullptr)) + // RC are most certainly different - these are overloads. + return true; I know it's preexisting but, I'm not sure that

[PATCH] D136554: Implement CWG2631

cor3ntin updated this revision to Diff 478216. cor3ntin added a comment. Remove extra ; Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136554/new/ https://reviews.llvm.org/D136554 Files: clang/docs/ReleaseNotes.rst clang/include/clang/AST/ExprC

[PATCH] D136554: Implement CWG2631

cor3ntin added inline comments. Comment at: clang/include/clang/AST/ExprCXX.h:1274 + *getTrailingObjects() = RewrittenExpr; setDependence(computeDependence(this)); } aaron.ballman wrote: > Do we need to update `computeDependence()` to account for the

[PATCH] D138822: [clang] Add test for CWG36

cor3ntin added a comment. Could you make a separate pull request for updating the core issue list (I didn't know it had been updated recently)? Or, i think you could commit the update of the core issue list directly (do you have commit rights?) and then work on the DR. Repository: rG LLVM Gi

[PATCH] D138851: [Clang] Permit static constexpr variables in constexpr functions

cor3ntin created this revision. Herald added a project: All. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This implement the C++23 paper P2647R1 (adopted in Kona) Repository: rG LLVM Github Monorepo https://reviews.llvm.org

[PATCH] D138851: [Clang] Permit static constexpr variables in constexpr functions

cor3ntin updated this revision to Diff 478321. cor3ntin added a comment. Add an evaluation test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138851/new/ https://reviews.llvm.org/D138851 Files: clang/docs/ReleaseNotes.rst clang/lib/AST/ExprCo

[PATCH] D136554: Implement CWG2631

cor3ntin updated this revision to Diff 478328. cor3ntin added a comment. Update DR status Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136554/new/ https://reviews.llvm.org/D136554 Files: clang/docs/ReleaseNotes.rst clang/include/clang/AST/Exp

[PATCH] D138851: [Clang] Permit static constexpr variables in constexpr functions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5607fc002dd4: [Clang] Permit static constexpr variables in constexpr functions (authored by cor3ntin). Changed prior to commit: https://reviews.ll

[PATCH] D138861: [Clang] Implement CWG2640 Allow more characters in an n-char sequence

cor3ntin created this revision. Herald added a project: All. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D138861 Files: clang/lib/Lex/Lexer.cpp clang/lib/Lex/

[PATCH] D138861: [Clang] Implement CWG2640 Allow more characters in an n-char sequence

cor3ntin updated this revision to Diff 478362. cor3ntin added a comment. Update DR web page Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138861/new/ https://reviews.llvm.org/D138861 Files: clang/lib/Lex/Lexer.cpp clang/lib/Lex/LiteralSupport.

[PATCH] D138861: [Clang] Implement CWG2640 Allow more characters in an n-char sequence

cor3ntin updated this revision to Diff 478373. cor3ntin added a comment. Fix DR status (I didn't know the scrip supported versions, neat) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138861/new/ https://reviews.llvm.org/D138861 Files: clang/li

[PATCH] D136554: Implement CWG2631

cor3ntin added inline comments. Comment at: clang/include/clang/Sema/Sema.h:9654-9655 +return true; + if (Ctx.isConstantEvaluated() || Ctx.isImmediateFunctionContext() || + Ctx.isUnevaluated()) +return false; cor3ntin wrote: > aaron.

[PATCH] D138918: [Clang] Implement CWG2654: Un-deprecation of compound volatile assignments

cor3ntin created this revision. Herald added a project: All. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D138918 Files: clang/docs/ReleaseNotes.rst clang/incl

[PATCH] D138901: [clang] Propely handle tests for open DRs in make_cxx_dr_status

cor3ntin added a comment. I don't see anything wrong with the python either. There are probably clever ways to deal with the successions of if statements but i don't think it would be worth it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138901/

[PATCH] D137051: [Clang] Allow additional mathematical symbols in identifiers.

cor3ntin added a comment. @tahonermann gentle ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137051/new/ https://reviews.llvm.org/D137051 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D138918: [Clang] Implement CWG2654: Un-deprecation of compound volatile assignments

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb12aea6659e1: [Clang] Implement CWG2654: Un-deprecation of compound volatile assignments (authored by cor3ntin). Herald added subscribers: kadircet,

[PATCH] D138918: [Clang] Implement CWG2654: Un-deprecation of compound volatile assignments

cor3ntin added a comment. Thanks Erich! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138918/new/ https://reviews.llvm.org/D138918 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D138861: [Clang] Implement CWG2640 Allow more characters in an n-char sequence

cor3ntin updated this revision to Diff 478631. cor3ntin added a comment. - Add test - Add release notes entry - use isVerticalWhitespace Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138861/new/ https://reviews.llvm.org/D138861 Files: clang/docs

[PATCH] D138861: [Clang] Implement CWG2640 Allow more characters in an n-char sequence

cor3ntin updated this revision to Diff 478673. cor3ntin added a comment. Add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138861/new/ https://reviews.llvm.org/D138861 Files: clang/docs/ReleaseNotes.rst clang/lib/Lex/Lexer.cpp clang/lib

[PATCH] D138861: [Clang] Implement CWG2640 Allow more characters in an n-char sequence

cor3ntin updated this revision to Diff 478679. cor3ntin added a comment. Slightly improve error recovery Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138861/new/ https://reviews.llvm.org/D138861 Files: clang/docs/ReleaseNotes.rst clang/lib/Le

[PATCH] D138861: [Clang] Implement CWG2640 Allow more characters in an n-char sequence

cor3ntin updated this revision to Diff 478706. cor3ntin added a comment. Avoid duplicating errors in macros. Because of that we cannot alays recover nicely with a loose matching. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138861/new/ https://rev

[PATCH] D138861: [Clang] Implement CWG2640 Allow more characters in an n-char sequence

cor3ntin added inline comments. Comment at: clang/test/CXX/drs/dr26xx.cpp:41 +#define a z( +int x = a\N{abc}); // expected-error 2{{'abc' is not a valid Unicode character name}} + aaron.ballman wrote: > Why do we get two errors here? > > Also, can you add this

[PATCH] D138947: [Clang] Remove invalid assert from Sema::BuildCXXTypeConstructExpr

cor3ntin added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:1464 - (Exprs.size() == 1 && isa(Exprs[0]))) && - "List initialization must have initializer list as expression."); SourceRange FullRange = SourceRange(TyBeginLoc, RParenOrBraceLoc); --

[PATCH] D136554: Implement CWG2631

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. cor3ntin marked 2 inline comments as done. Closed by commit rG26fa17ed2914: Implement CWG2631 (authored by cor3ntin). Changed prior to commit: https://reviews.llvm.or

[PATCH] D136554: Implement CWG2631

cor3ntin added a comment. Thanks Aaron. I hope it sticks this time! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136554/new/ https://reviews.llvm.org/D136554 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D138861: [Clang] Implement CWG2640 Allow more characters in an n-char sequence

cor3ntin updated this revision to Diff 478914. cor3ntin added a comment. Remove extraneous space and braces Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138861/new/ https://reviews.llvm.org/D138861 Files: clang/docs/ReleaseNotes.rst clang/lib

[PATCH] D138861: [Clang] Implement CWG2640 Allow more characters in an n-char sequence

cor3ntin updated this revision to Diff 478919. cor3ntin added a comment. Restore a macro test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138861/new/ https://reviews.llvm.org/D138861 Files: clang/docs/ReleaseNotes.rst clang/lib/Lex/Lexer.cpp

[PATCH] D138861: [Clang] Implement CWG2640 Allow more characters in an n-char sequence

cor3ntin added inline comments. Comment at: clang/lib/Lex/Lexer.cpp:3379 - if (LooseMatch) + if (LooseMatch && Diagnose) Res = LooseMatch->CodePoint; aaron.ballman wrote: > Why do we only want to do this if we're diagnosing? The scenario we want to avoid

[PATCH] D136554: Implement CWG2631

cor3ntin reopened this revision. cor3ntin added a comment. This revision is now accepted and ready to land. There is still an ODR issue which caused linkers errors I think I managed to reduce the issue to template struct function_ref { function_ref(auto) {} }; struct S { f

[PATCH] D136554: Implement CWG2631

cor3ntin updated this revision to Diff 479395. cor3ntin added a comment. - Member initializers wwere not marked odr used properly - Fixing that unearthed an other bug: consteval calls in a nested member initializers were not properly detected if the member was list initialized to its default

[PATCH] D136554: Implement CWG2631

cor3ntin added a comment. @aaron.ballman if you don't scream, I'll probably try again this week end. I did multiple stage 2 full builds to be sure this time. The fix is pretty small but the investigation took a while... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

<    7   8   9   10   11   12   13   14   15   16   >