zaks.anna created this revision.
zaks.anna added a reviewer: dergachev.a.
zaks.anna added subscribers: dcoughlin, cfe-commits.
This fixes a reported false positive in the malloc checker.
https://reviews.llvm.org/D27599
Files:
lib/StaticAnalyzer/Core/CallEvent.cpp
test/Analysis/Inputs/system
zaks.anna created this revision.
zaks.anna added a reviewer: dcoughlin.
zaks.anna added subscribers: dergachev.a, cfe-commits.
This is a big deal for ObjC, where nullability annotations are extensively
used. I've also changed "Null" -> "null" and removed "is" as this is the
pattern that Sema is
zaks.anna added a comment.
Looks like Sema uses "null" not only when referring to literals (see below).
Also, if we were referring to literals, we would use single quotes, no?
I suggest keeping as is for consistency with the wording that uses nil. I do
not see much difference between the two ca
zaks.anna added a comment.
Thanks Artem!
Just to be clear, I think this patch should be committed once
"inTopLevelNamespace" issue is addressed. That is the only issue pending as far
as I can see.
The visitor should be a separate patch.
https://reviews.llvm.org/D25660
zaks.anna added inline comments.
Comment at: lib/CodeGen/CGExpr.cpp:1222
+/// modes, it's safe to treat such a type as 'the builtin bool'.
+static bool isObjCBool(QualType Ty, const SourceManager &SM,
+ const LangOptions &LO) {
Could you use
zaks.anna updated this revision to Diff 80925.
zaks.anna added a comment.
Updated "null"-> "Null" as per Devin's suggestion.
https://reviews.llvm.org/D27600
Files:
lib/StaticAnalyzer/Checkers/NullabilityChecker.cpp
test/Analysis/nullability-no-arc.mm
test/Analysis/nullability.mm
test/An
zaks.anna accepted this revision.
zaks.anna added a reviewer: zaks.anna.
zaks.anna added a comment.
This revision is now accepted and ready to land.
LGTM!
https://reviews.llvm.org/D27607
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:/
zaks.anna added inline comments.
Comment at: include/clang/StaticAnalyzer/Checkers/Checkers.td:494
+def ObjCPropertyChecker : Checker<"ObjCProperty">,
+ HelpText<"Find various issues with Objective-C properties">,
+ DescFile<"ObjCPropertyChecker.cpp">;
Nit: may
zaks.anna added a comment.
> Could you please remove the IteratorPastEndChecker file differences from this
> patch and make https://reviews.llvm.org/D25660
> dependent on this one?
Since this has not been reviewed yet while the IteratorPastEndChecker has been,
I do not think we should block t
zaks.anna added a comment.
Update: Adding support for top frame to the CallEvent is difficult, so let's
just use CallEvent API in the checkers for all frames but the top one and have
custom top frame handling in the Recursion checker itself. The top frame
handling does not need to be complete (
zaks.anna accepted this revision.
zaks.anna added a comment.
This revision is now accepted and ready to land.
Thank you!
Comment at: lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:459
// Notice that the lower bound is greater than the upper bound.
- RangeSet New = GetRa
zaks.anna created this revision.
zaks.anna added reviewers: dergachev.a, dcoughlin.
zaks.anna added a subscriber: cfe-commits.
When a macro expending to a literal is used in a comparison, use the macro name
in the diagnostic rather than the literal. This improves readability of path
notes.
Adde
zaks.anna created this revision.
zaks.anna added a reviewer: dcoughlin.
zaks.anna added subscribers: cfe-commits, dcoughlin.
The more detailed diagnostic will make identifying which object the diagnostics
refer to easier.
https://reviews.llvm.org/D27740
Files:
lib/StaticAnalyzer/Checkers/Ret
zaks.anna added a comment.
@baloghadamsoftware Thanks for working on this!
However, this patch is getting too big. Could you, please, split it into
incremental patches so that it would be easier to review? More motivation of
why this is very important is here
http://llvm.org/docs/DeveloperPol
zaks.anna added a comment.
I agree that scan-build or scan-build-py integration is an important issue to
resolve here. What I envision is that users will just call scan-build and pass
-whole-project as an option to it. Everything else will happen automagically:)
Another concern is dumping the A
zaks.anna accepted this revision.
zaks.anna added a comment.
This revision is now accepted and ready to land.
Thank you!
Repository:
rL LLVM
https://reviews.llvm.org/D32328
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm
zaks.anna added a comment.
Do you have commit access?
Repository:
rL LLVM
https://reviews.llvm.org/D32328
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zaks.anna added inline comments.
Comment at: cfe/trunk/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:80
}
-else if (isDeclRefExprToReference(E)) {
+else if (isa(E)) {
return E;
Not sure what this does, but looks like we are stricter here now
zaks.anna accepted this revision.
zaks.anna added a comment.
Thanks!
https://reviews.llvm.org/D32702
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zaks.anna accepted this revision.
zaks.anna added a comment.
This revision is now accepted and ready to land.
> These new "extra notes" of mine might be useful (we could put them at
> property declaration), i could add them if everybody likes this idea.
What are these? Is there a PR?
It would b
zaks.anna added a comment.
Sorry for the delay!!!
Comment at:
include/clang/StaticAnalyzer/Core/PathSensitive/BasicValueFactory.h:180
+ inline const llvm::APSInt &getZeroWithTypeSize(QualType T,
+ bool isUnsigned = true) {
+
zaks.anna added a comment.
> That wouldn't work this way because we'd have the completely redundant
> "calling property accessor" piece before that, and "returning..." after that.
I think we should not print "calling" and "returning" for calling into and
returning from autogenerated code, If we
zaks.anna added a comment.
Thank you for the patch! Could you please re-submit the patch with context?
Instructions on how to do that can be found here:
http://llvm.org/docs/Phabricator.html
Repository:
rL LLVM
https://reviews.llvm.org/D32449
__
zaks.anna accepted this revision.
zaks.anna added a comment.
This revision is now accepted and ready to land.
Looks good. Thank you!
Do you have commit access or should we commit?
https://reviews.llvm.org/D33263
___
cfe-commits mailing list
cfe-com
zaks.anna added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/DynamicTypePropagation.cpp:464
ASTContext &C) {
+ if (hasKindofArgs(StaticUpperBound)) {
+// If the upper bound type has more __kindof specs, we drop all the info,
zaks.anna added a comment.
Thanks! A couple of minor comments below.
Comment at: lib/StaticAnalyzer/Core/PathDiagnostic.cpp:699
+ // We cannot place diagnostics on autosynthesized code.
+ // Put them onto the call site through which we jumped into autosynthesized
+ // code f
501 - 526 of 526 matches
Mail list logo
