[clang] e3b1083 - [Clang][Sema] Fix comparison of constraint expressions

Author: Alexander Shaposhnikov Date: 2023-04-27T21:33:32Z New Revision: e3b1083e00e62f5d157d15cb8c63a1c3dfdf12e2 URL: https://github.com/llvm/llvm-project/commit/e3b1083e00e62f5d157d15cb8c63a1c3dfdf12e2 DIFF: https://github.com/llvm/llvm-project/commit/e3b1083e00e62f5d157d15cb8c63a1c3dfdf12e2.d

[clang] ce861ec - [Clang][Sema] Add a temporary workaround in SemaConcept.cpp

Author: Alexander Shaposhnikov Date: 2023-04-27T23:34:03Z New Revision: ce861ec782ae3f41807b61e855512aaccf3c2149 URL: https://github.com/llvm/llvm-project/commit/ce861ec782ae3f41807b61e855512aaccf3c2149 DIFF: https://github.com/llvm/llvm-project/commit/ce861ec782ae3f41807b61e855512aaccf3c2149.d

[clang] 3a54022 - [Clang][Sema] Fix comparison of constraint expressions

Author: Alexander Shaposhnikov Date: 2023-05-03T21:06:12Z New Revision: 3a540229341e3c8dc6d8ee61309eafaf943ea254 URL: https://github.com/llvm/llvm-project/commit/3a540229341e3c8dc6d8ee61309eafaf943ea254 DIFF: https://github.com/llvm/llvm-project/commit/3a540229341e3c8dc6d8ee61309eafaf943ea254.d

[clang] 8b0ea48 - [Clang][CUDA] Disable diagnostics for neon attrs for GPU-side CUDA compilation

Author: Alexander Shaposhnikov Date: 2023-06-09T09:27:01Z New Revision: 8b0ea48740935d819618d8254fc45d98179b672c URL: https://github.com/llvm/llvm-project/commit/8b0ea48740935d819618d8254fc45d98179b672c DIFF: https://github.com/llvm/llvm-project/commit/8b0ea48740935d819618d8254fc45d98179b672c.d

r290781 - [clang] Fix clean build of generate-order-file

Author: alexshap Date: Fri Dec 30 23:25:52 2016 New Revision: 290781 URL: http://llvm.org/viewvc/llvm-project?rev=290781&view=rev Log: [clang] Fix clean build of generate-order-file This diff fixes the clean build of the target generate-order-file. In llvm/tools/clang/CMakeLists.txt add_subdirec

r290936 - [clang] Update lit config in utils/perf-training

Author: alexshap Date: Tue Jan 3 22:33:28 2017 New Revision: 290936 URL: http://llvm.org/viewvc/llvm-project?rev=290936&view=rev Log: [clang] Update lit config in utils/perf-training This diff replaces --driver-mode=cpp in utils/perf-training/order-files.lit.cfg and utils/perf-training/lit.cfg w

r291449 - [clang] Enable using --section-ordering-file option of ld.gold

Author: alexshap Date: Mon Jan 9 11:06:24 2017 New Revision: 291449 URL: http://llvm.org/viewvc/llvm-project?rev=291449&view=rev Log: [clang] Enable using --section-ordering-file option of ld.gold This diffs enables using --section-ordering-file option of ld.gold via the variable CLANG_ORDER_FI

[PATCH] D23536: Remove excessive padding from ImmOp and RegOp.

alexshap created this revision. alexshap added a reviewer: tstellarAMD. alexshap added a subscriber: cfe-commits. alexshap changed the visibility of this Differential Revision from "Public (No Login Required)" to "All Users". Herald added subscribers: arsenm, aemerson. The structs ImmOp and RegOp

Re: [PATCH] D23536: Remove excessive padding from ImmOp and RegOp.

alexshap added a comment. Test plan: make -j8 check-llvm-unit F2273124: Screen Shot 2016-08-15 at 5.14.59 PM.png F2273127: Screen Shot 2016-08-15 at 5.14.29 PM.png https://reviews.llvm.org/D23536 _

Re: [PATCH] D23536: Remove excessive padding from ImmOp and RegOp.

alexshap added a comment. Thx, I don't have commit access, need smb to land this patch https://reviews.llvm.org/D23536 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23530: Remove excessive padding from BarrierOp, PrefetchOp, PSBHintOp.

alexshap added a comment. Yes: "Data, Length, Val" would work as well, i will update this diff https://reviews.llvm.org/D23530 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23530: Remove excessive padding from BarrierOp, PrefetchOp, PSBHintOp.

alexshap updated this revision to Diff 68128. alexshap added a comment. Address code review comment https://reviews.llvm.org/D23530 Files: lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp Index: lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp ==

[PATCH] D23546: Remove excessive padding from LineNoCacheTy

alexshap created this revision. alexshap added a reviewer: lattner. alexshap added a subscriber: cfe-commits. alexshap changed the visibility of this Differential Revision from "Public (No Login Required)" to "All Users". The struct LineNoCacheTy is in SourceMgr.cpp inside anonymous namespace. Th

Re: [PATCH] D23546: Remove excessive padding from LineNoCacheTy

alexshap added a comment. F2274214: Screen Shot 2016-08-16 at 3.34.00 AM.png https://reviews.llvm.org/D23546 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/

Re: [PATCH] D23546: Remove excessive padding from LineNoCacheTy

alexshap added a comment. Thanks, no, i don't. I will be grateful to you if you land this patch. https://reviews.llvm.org/D23546 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23651: [clang-rename] improve performance for rename-all

alexshap added a subscriber: alexshap. Comment at: clang-rename/USRFindingAction.h:38 @@ -37,5 +37,3 @@ private: - unsigned SymbolOffset; - std::string OldName; - std::string SpellingName; - std::vector USRs; + std::vector SymbolOffsets; + std::vector OldNames;

[PATCH] D23653: Minor cleanup of SimpleTypoCorrector

alexshap created this revision. alexshap added reviewers: gribozavr, bkramer. alexshap added a subscriber: cfe-commits. alexshap changed the visibility of this Differential Revision from "Public (No Login Required)" to "All Users". Add the "explicit" specifier to the single-argument constructor o

Re: [PATCH] D23653: Minor cleanup of SimpleTypoCorrector

alexshap added a comment. F2283280: Screen Shot 2016-08-18 at 4.29.34 AM.png https://reviews.llvm.org/D23653 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/

Re: [PATCH] D23651: [clang-rename] improve performance for rename-all

alexshap added inline comments. Comment at: clang-rename/USRFindingAction.cpp:205 @@ -196,2 +204,3 @@ + USRList)); return std::move(Consumer); } not particularly important, probably it can be simply return llvm::make_uniq

Re: [PATCH] D23651: [clang-rename] improve performance for rename-all

alexshap added inline comments. Comment at: clang-rename/USRFindingAction.cpp:190 @@ -175,1 +189,3 @@ + std::vector NextUSRBunch = Finder.Find(); + USRList.push_back(NextUSRBunch); } USRList.push_back(std::move(NextUSRBunch)) or (IMO even better)

Re: [PATCH] D23653: Minor cleanup of SimpleTypoCorrector

alexshap added a comment. ping https://reviews.llvm.org/D23653 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23279: clang-reorder-fields

alexshap removed rL LLVM as the repository for this revision. alexshap updated this revision to Diff 68738. alexshap added a comment. 1. Handle C++ ctors. 2. Add tests. 3. I have a diff for proper moving the attached comments based on http://llvm.org/devmtg/2012-11/Gribenko_CommentParsing.pdf . I

Re: [PATCH] D23653: Minor cleanup of SimpleTypoCorrector

alexshap added a comment. i can do that, although there will be a lot of changes (mostly because of clang-format). Another concern is that the style of the other files located inside the same folder also might be not clang-format compliant. Do you want me to do that ? (i mean to run clang-tidy

Re: [PATCH] D23653: Minor cleanup of SimpleTypoCorrector

alexshap added a comment. i see, it makes sense, thanks. Repository: rL LLVM https://reviews.llvm.org/D23653 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23653: Minor cleanup of SimpleTypoCorrector

alexshap added a reviewer: Eugene.Zelenko. alexshap removed rL LLVM as the repository for this revision. alexshap updated this revision to Diff 68746. alexshap added a comment. 1. clang-tidy -checks=google-explicit-constructor tools/clang/lib/AST/CommentSema.cpp - no other issues found 2. clang-f

Re: [PATCH] D23279: clang-reorder-fields

alexshap added a comment. ping Repository: rL LLVM https://reviews.llvm.org/D23279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23279: clang-reorder-fields

alexshap added a comment. Thanks for the comments. @bcraig, multi-TU support is in - in the sense that it's in at the same level, as it's in for clang-rename and the other tools (take a look my comments above, please). Also: @omtcyf0: > Well, multi-TU support is needed for many tools and it is

Re: [PATCH] D23279: clang-reorder-fields

alexshap added a comment. > My only high-level comment so far (will try to review in more detail later) > is: I find it strange to mix ASTMatchers and a >RecursiveASTVisitor in the > same tool. It seem that if you are using ASTMatchers internally for other > things, you should also >use ASTMatc

Re: [PATCH] D23279: clang-reorder-fields

alexshap added inline comments. Comment at: test/clang-reorder-fields/CStructAmbiguousName.cpp:6 @@ +5,3 @@ +struct Foo { + int x;// CHECK: int x; + double y; // CHECK: double y; djasper wrote: > Have you thought about how to handle comments that surround th

Re: [PATCH] D23279: clang-reorder-fields

alexshap added a comment. @djasper - regarding the visitor - thank you, i understand ur concerns - i will add a version which uses a matcher (will update this diff). Repository: rL LLVM https://reviews.llvm.org/D23279 ___ cfe-commits mailing lis

Re: [PATCH] D23279: clang-reorder-fields

alexshap updated this revision to Diff 68939. alexshap added a comment. 1. Get rid of the visitor. 2. Get rid of the dependency on libc++ in tests (ran and checked the tests under the minimal checkout: llvm + clang + extra tools) Repository: rL LLVM https://reviews.llvm.org/D23279 Files:

Re: [PATCH] D23279: clang-reorder-fields

alexshap removed rL LLVM as the repository for this revision. alexshap changed the visibility of this Differential Revision from "All Users" to "Public (No Login Required)". alexshap updated this revision to Diff 68943. alexshap added a comment. Fix typo https://reviews.llvm.org/D23279 Files:

Re: [PATCH] D23279: clang-reorder-fields

alexshap added a comment. @aaron.ballman Thanks, yeah, there is an issue. Also there are inline-comments by @bcraig and @compnerd about the tests. I used clang-rename, include-fixer, clang-tidy as examples. alexshap-mbp:extra alexshap$ grep -r -n "sed -e " ./* | head -n 5 ./test/clang-tidy/mode

Re: [PATCH] D23279: clang-reorder-fields

alexshap updated this revision to Diff 68953. alexshap added a comment. Drop support of -field-pos for now Repository: rL LLVM https://reviews.llvm.org/D23279 Files: CMakeLists.txt clang-reorder-fields/CMakeLists.txt clang-reorder-fields/ReorderFieldsAction.cpp clang-reorder-fields/R

Re: [PATCH] D23279: clang-reorder-fields

alexshap added a comment. @aaron.ballman thanks, yeah, i understand ur concerns that now we have zero tests that can run on windows. To be honest i would prefer not to depend on sed, cat etc at all and have most of the tests (i would prefer all of them) running on windows - but by this moment i

Re: [PATCH] D23279: clang-reorder-fields

alexshap added a comment. > but by this moment i have not figured out yet how to make it happen. oh, i see, let me check - i will update this diff Repository: rL LLVM https://reviews.llvm.org/D23279 ___ cfe-commits mailing list cfe-commits@list

Re: [PATCH] D23279: clang-reorder-fields

alexshap removed rL LLVM as the repository for this revision. alexshap updated this revision to Diff 68955. alexshap added a comment. Get rid of sed in tests https://reviews.llvm.org/D23279 Files: CMakeLists.txt clang-reorder-fields/CMakeLists.txt clang-reorder-fields/ReorderFieldsAction.

Re: [PATCH] D23279: clang-reorder-fields

alexshap marked 4 inline comments as done. alexshap added a comment. https://reviews.llvm.org/D23279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23279: clang-reorder-fields

alexshap added a comment. @djasper, @bcraig, @aaron.ballman - many thanks for the comments and suggestions, please, let me know if you are waiting for any other changes on my side (for v0) or if there is anything else i can do to make reviewing easier. Repository: rL LLVM https://reviews.ll

[PATCH] D23821: Minor cleanup of the class Pattern

alexshap created this revision. alexshap added reviewers: dsanders, probinson. alexshap added a subscriber: cfe-commits. alexshap set the repository for this revision to rL LLVM. alexshap changed the visibility of this Differential Revision from "Public (No Login Required)" to "All Users". Herald

Re: [PATCH] D23279: clang-reorder-fields

alexshap updated this revision to Diff 69056. alexshap added a comment. Drop the callbacks (the worst-case complexity might be worse, but this approach requires less code). Repository: rL LLVM https://reviews.llvm.org/D23279 Files: CMakeLists.txt clang-reorder-fields/CMakeLists.txt cl

Re: [PATCH] D23279: clang-reorder-fields

alexshap marked 2 inline comments as done. alexshap added a comment. Repository: rL LLVM https://reviews.llvm.org/D23279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23279: clang-reorder-fields

alexshap added inline comments. Comment at: clang-reorder-fields/ReorderFieldsAction.h:30 @@ +29,3 @@ + std::map &Replacements; + +public: the thing is that a few weeks ago there was a diff https://reviews.llvm.org/D21748?id=64016. That diff contains a lot of cha

Re: [PATCH] D23279: clang-reorder-fields

alexshap updated this revision to Diff 69065. alexshap added a comment. minor cleanup Repository: rL LLVM https://reviews.llvm.org/D23279 Files: CMakeLists.txt clang-reorder-fields/CMakeLists.txt clang-reorder-fields/ReorderFieldsAction.cpp clang-reorder-fields/ReorderFieldsAction.h

[PATCH] D23826: Remove excessive padding from PTHStatData

alexshap created this revision. alexshap added reviewers: mehdi_amini, bkramer. alexshap added a subscriber: cfe-commits. alexshap set the repository for this revision to rL LLVM. alexshap changed the visibility of this Differential Revision from "Public (No Login Required)" to "All Users". The c

Re: [PATCH] D23826: Remove excessive padding from PTHStatData

alexshap added a comment. Ok, thanks. Could you land this diff ? (i don't have commit access) Repository: rL LLVM https://reviews.llvm.org/D23826 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listin

Re: [PATCH] D23279: clang-reorder-fields

alexshap added inline comments. Comment at: clang-reorder-fields/tool/ClangReorderFields.cpp:44 @@ +43,3 @@ + bool parse(cl::Option &O, StringRef ArgName, const std::string &ArgValue, + SmallVector &Val) { +Val.clear(); djasper wrote: > Don't use

Re: [PATCH] D23279: clang-reorder-fields

alexshap added inline comments. Comment at: clang-reorder-fields/ReorderFieldsAction.h:31 @@ +30,3 @@ + +public: + ReorderFieldsAction( djasper wrote: > I don't why clang-rename does what it does at the moment. My main point is > that we have already implemented

Re: [PATCH] D23279: clang-reorder-fields

alexshap added a comment. regarding writing the comments - yeah, i will add them - just have not updated the diff yet (writing comments doesn't come to me easily) Repository: rL LLVM https://reviews.llvm.org/D23279 ___ cfe-commits mailing list c

Re: [PATCH] D23279: clang-reorder-fields

alexshap marked 2 inline comments as done. alexshap added a comment. Repository: rL LLVM https://reviews.llvm.org/D23279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D23828: Make InitListExpr::isExplicit const

alexshap created this revision. alexshap added reviewers: djasper, bkramer. alexshap added a subscriber: cfe-commits. alexshap set the repository for this revision to rL LLVM. alexshap changed the visibility of this Differential Revision from "Public (No Login Required)" to "All Users". Mark the

Re: [PATCH] D23279: clang-reorder-fields

alexshap added inline comments. Comment at: clang-reorder-fields/ReorderFieldsAction.cpp:152 @@ +151,3 @@ + // SourceLocation::isValid is const. + if (!const_cast(InitListEx)->isExplicit() || + !InitListEx->getNumInits()) djasper wrote: > I think it is an o

Re: [PATCH] D23828: Make InitListExpr::isExplicit const

alexshap added a comment. Thx, i don't have commit access, if u could land this diff i would be grateful Repository: rL LLVM https://reviews.llvm.org/D23828 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mai

Re: [PATCH] D23279: clang-reorder-fields

alexshap added a subscriber: ioeric. Comment at: clang-reorder-fields/ReorderFieldsAction.h:31 @@ +30,3 @@ + +public: + ReorderFieldsAction( alexshap wrote: > djasper wrote: > > I don't why clang-rename does what it does at the moment. My main point is > > that

Re: [PATCH] D23279: clang-reorder-fields

alexshap updated this revision to Diff 69174. alexshap added a comment. Address @djasper 's comments 1. Add brief comments to the helper functions. 2. Get rid of the workaround. (https://reviews.llvm.org/D23828 has been merged in and i have rebased on the latest revision) 3. Made stylistic / n

Re: [PATCH] D23279: clang-reorder-fields

alexshap marked 17 inline comments as done. alexshap added a comment. Repository: rL LLVM https://reviews.llvm.org/D23279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23279: clang-reorder-fields

alexshap updated this revision to Diff 69186. alexshap added a comment. Use a more elaborate approach for command line options. alexshap-mbp:srcs alexshap$ clang-reorder-fields -record-name Foo -fields-order s1,x,z,s2 main.cpp >/dev/null && echo ok ok alexshap-mbp:srcs alexshap$ clang-reorder-fi

Re: [PATCH] D23279: clang-reorder-fields

alexshap marked an inline comment as done. alexshap added a comment. Repository: rL LLVM https://reviews.llvm.org/D23279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23279: clang-reorder-fields

alexshap added a comment. so looks like i have marked all the inline comments as done - please, let me know if i need to change smth else. Many thanks for the code review/comments/suggestions. Repository: rL LLVM https://reviews.llvm.org/D23279

[PATCH] D23898: Minor cleanup of MismatchingNewDeleteDetector

alexshap created this revision. alexshap added reviewers: ismailp, rsmith, bkramer. alexshap added a subscriber: cfe-commits. alexshap set the repository for this revision to rL LLVM. alexshap changed the visibility of this Differential Revision from "Public (No Login Required)" to "All Users". T

Re: [PATCH] D23898: Minor cleanup of MismatchingNewDeleteDetector

alexshap added a comment. F2334424: Screen Shot 2016-08-25 at 5.30.51 PM.png Repository: rL LLVM https://reviews.llvm.org/D23898 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cg

Re: [PATCH] D23901: Minor cleanup of the class CallStackFrame

alexshap added a comment. F2334496: Screen Shot 2016-08-25 at 6.20.05 PM.png Repository: rL LLVM https://reviews.llvm.org/D23901 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cg

[PATCH] D23901: Minor cleanup of the class CallStackFrame

alexshap created this revision. alexshap added reviewers: rsmith, gbiv, bkramer. alexshap added a subscriber: cfe-commits. alexshap set the repository for this revision to rL LLVM. alexshap changed the visibility of this Differential Revision from "Public (No Login Required)" to "All Users". The

[PATCH] D23902: Minor cleanup of PTHWriter

alexshap created this revision. alexshap added reviewers: bogner, dblaikie, rnk. alexshap added a subscriber: cfe-commits. alexshap set the repository for this revision to rL LLVM. alexshap changed the visibility of this Differential Revision from "Public (No Login Required)" to "All Users". The

Re: [PATCH] D23902: Minor cleanup of PTHWriter

alexshap added a comment. F2334541: Screen Shot 2016-08-25 at 6.57.45 PM.png Repository: rL LLVM https://reviews.llvm.org/D23902 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cg

Re: [PATCH] D23279: clang-reorder-fields

alexshap added a comment. F2334952: pingpingpingping Repository: rL LLVM https://reviews.llvm.org/D23279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cf

Re: [PATCH] D23279: clang-reorder-fields

alexshap added inline comments. Comment at: clang-reorder-fields/ReorderFieldsAction.cpp:165 @@ +164,3 @@ +return; + assert(InitListEx->getNumInits() == NewFieldsOrder.size() && + "Currently only full initialization is supported"); djasper wrote: > Sa

Re: [PATCH] D23279: clang-reorder-fields

alexshap marked 2 inline comments as done. Comment at: clang-reorder-fields/ReorderFieldsAction.cpp:202 @@ +201,3 @@ +for (const auto *C : RD->ctors()) { + if (C->isImplicit() || C->isDelegatingConstructor()) +continue; djasper wrote: > Why are yo

Re: [PATCH] D23279: clang-reorder-fields

alexshap marked 4 inline comments as done. alexshap added a comment. Repository: rL LLVM https://reviews.llvm.org/D23279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23279: clang-reorder-fields

alexshap updated this revision to Diff 69445. alexshap added a comment. Address @djasper 's comments. 1. Try to flash out comments for helper functions / various interesting places in my code 2. More elaborate error-handling 3. Adjust the names of the variables: I -> i, E -> e 4. Minor cleanup &

Re: [PATCH] D23279: clang-reorder-fields

alexshap marked 10 inline comments as done. alexshap added a comment. I have marked all the inline comments as done, if i need to change/fix smth else - pls, reopen the corresponding comment or add a new one. **Current apporach** : correctly create all the necessary replacements supported by thi

Re: [PATCH] D23279: clang-reorder-fields

alexshap added a comment. I've just rerun the tests - they are green. Repository: rL LLVM https://reviews.llvm.org/D23279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23279: clang-reorder-fields

alexshap added a comment. F2347517: pingu Repository: rL LLVM https://reviews.llvm.org/D23279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23279: clang-reorder-fields

alexshap added a reviewer: djasper. alexshap updated this revision to Diff 69748. alexshap added a comment. Address @djasper 's comments Repository: rL LLVM https://reviews.llvm.org/D23279 Files: CMakeLists.txt clang-reorder-fields/CMakeLists.txt clang-reorder-fields/ReorderFieldsActio

Re: [PATCH] D23279: clang-reorder-fields

alexshap added inline comments. Comment at: clang-reorder-fields/ReorderFieldsAction.cpp:83 @@ +82,3 @@ +static void +addReplacement(SourceRange Old, SourceRange New, const ASTContext &Context, + std::map &Replacements) { khm, it Replaces Old by New,

Re: [PATCH] D23279: clang-reorder-fields

alexshap marked 5 inline comments as done. alexshap added a comment. Repository: rL LLVM https://reviews.llvm.org/D23279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23279: clang-reorder-fields

alexshap updated this revision to Diff 69769. alexshap marked an inline comment as not done. alexshap added a comment. Check the return value of reorderFieldsInInitListExpr. Repository: rL LLVM https://reviews.llvm.org/D23279 Files: CMakeLists.txt clang-reorder-fields/CMakeLists.txt cl

Re: [PATCH] D23279: clang-reorder-fields

alexshap added inline comments. Comment at: clang-reorder-fields/ReorderFieldsAction.cpp:179 @@ +178,3 @@ +const ASTContext &Context, +std::map &Replacements) { + assert(InitListEx && "Init list expression is null"); >Also, I don't understand what the pro

Re: [PATCH] D23279: clang-reorder-fields

alexshap marked 4 inline comments as done. alexshap added a comment. Repository: rL LLVM https://reviews.llvm.org/D23279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23279: clang-reorder-fields

alexshap added a comment. Okay, many thanks for the code review. May i commit this ? I will add more tests as a follow-up Repository: rL LLVM https://reviews.llvm.org/D23279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llv

Re: [PATCH] D23279: clang-reorder-fields

alexshap marked 2 inline comments as done. alexshap added a comment. Repository: rL LLVM https://reviews.llvm.org/D23279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23279: clang-reorder-fields

alexshap added a comment. good call, i have found a bug in handling of initListExprs. Will update this diff and add tests. Repository: rL LLVM https://reviews.llvm.org/D23279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.l

Re: [PATCH] D23279: clang-reorder-fields

alexshap updated this revision to Diff 69807. alexshap added a comment. 1. Fix handling of initListExprs. http://clang.llvm.org/doxygen/Expr_8h_source.html#l03701 2. Fix handling of unchanged files 3. Add tests (AggregatePartialInitialization and ClassDifferentFieldsAccesses) Repository: rL

Re: [PATCH] D23279: clang-reorder-fields

alexshap updated this revision to Diff 69814. alexshap added a comment. 1. Fix comments (hope so). 2. if (const auto *SyntacticForm = InitListEx->getSyntacticForm()) InitListEx = SyntacticForm; Repository: rL LLVM https://reviews.llvm.org/D23279 Files: CMakeLists.txt clang-reorder-field

Re: [PATCH] D23279: clang-reorder-fields

alexshap marked an inline comment as done. alexshap added a comment. Repository: rL LLVM https://reviews.llvm.org/D23279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23279: clang-reorder-fields

alexshap marked an inline comment as done. alexshap added a comment. Repository: rL LLVM https://reviews.llvm.org/D23279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r280426 - Remove excessive padding from MismatchingNewDeleteDetector

Author: alexshap Date: Thu Sep 1 18:18:00 2016 New Revision: 280426 URL: http://llvm.org/viewvc/llvm-project?rev=280426&view=rev Log: Remove excessive padding from MismatchingNewDeleteDetector The class MismatchingNewDeleteDetector is in lib/Sema/SemaExprCXX.cpp inside the anonymous namespace.

Re: [PATCH] D23898: Minor cleanup of MismatchingNewDeleteDetector

This revision was automatically updated to reflect the committed changes. Closed by commit rL280426: Remove excessive padding from MismatchingNewDeleteDetector (authored by alexshap). Changed prior to commit: https://reviews.llvm.org/D23898?vs=69306&id=70094#toc Repository: rL LLVM https://

Re: [PATCH] D23279: clang-reorder-fields

This revision was automatically updated to reflect the committed changes. Closed by commit rL280431: Add clang-reorder-fields to clang-tools-extra (authored by alexshap). Changed prior to commit: https://reviews.llvm.org/D23279?vs=69814&id=70102#toc Repository: rL LLVM https://reviews.llvm.

[clang-tools-extra] r280431 - Add clang-reorder-fields to clang-tools-extra

Author: alexshap Date: Thu Sep 1 18:49:48 2016 New Revision: 280431 URL: http://llvm.org/viewvc/llvm-project?rev=280431&view=rev Log: Add clang-reorder-fields to clang-tools-extra This diff adds v0 of clang-reorder-fields tool to clang/tools/extra. The main idea behind this tool is to simplify a

[clang-tools-extra] r280438 - Revert https://reviews.llvm.org/D23279 because the tests have failed on several platforms

Author: alexshap Date: Thu Sep 1 19:24:06 2016 New Revision: 280438 URL: http://llvm.org/viewvc/llvm-project?rev=280438&view=rev Log: Revert https://reviews.llvm.org/D23279 because the tests have failed on several platforms Removed: clang-tools-extra/trunk/clang-reorder-fields/ clang-to

[clang-tools-extra] r280456 - Add clang-reorder-fields to clang-tools-extra

Author: alexshap Date: Thu Sep 1 21:56:07 2016 New Revision: 280456 URL: http://llvm.org/viewvc/llvm-project?rev=280456&view=rev Log: Add clang-reorder-fields to clang-tools-extra This diff adds v0 of clang-reorder-fields tool to clang/tools/extra. The main idea behind this tool is to simplify a

Re: [PATCH] D24192: [clang-refactor] introducing clang-refactor

alexshap added a subscriber: alexshap. Comment at: clang-refactor/driver/Rename.h:192 @@ +191,3 @@ + auto ID = Sources.translateFile(Entry); + Rewrite.getEditBuffer(ID).write(outs()); +} if i am not mistaken if the file has not been modified this wil

Re: [PATCH] D24183: A clang tool for changing surrouding namespaces of class/function definitions.

alexshap added a subscriber: alexshap. Comment at: change-namespace/ChangeNamespace.cpp:125 @@ +124,3 @@ +// applying all existing Replaces first if there is conflict. +void addOrMergeReplacement(const tooling::Replacement &R, + tooling::Replacements *Rep

Re: [PATCH] D24183: A clang tool for changing surrouding namespaces of class/function definitions.

alexshap added inline comments. Comment at: change-namespace/tool/ClangChangeNamespace.cpp:48 @@ +47,3 @@ + +cl::opt OldNamespace("old_namespace", cl::desc("Old namespace."), + cl::cat(ChangeNamespaceCategory)); probably you need t

Re: [PATCH] D24383: Add addOrMerge interface to tooling::Replacements.

alexshap added a comment. disclaimer: i don't know if this method is the right thing to add (to be honest i would prefer a better interface but don't have any good suggestions on my mind at the moment), i see several issues (IMO, i might be mistaken, apologize in advance) with the current inter

[PATCH] D24484: [analyzer] Fix ExprEngine::VisitMemberExpr

alexshap created this revision. alexshap added reviewers: NoQ, bcraig, zaks.anna. alexshap added a subscriber: cfe-commits. alexshap set the repository for this revision to rL LLVM. alexshap changed the visibility of this Differential Revision from "Public (No Login Required)" to "All Users". AST

Re: [PATCH] D24484: [analyzer] Fix ExprEngine::VisitMemberExpr

alexshap added a comment. 1. For the code: struct TestBufferStruct { int Buffer[3]; }; struct TestBufferStruct GetTestBufferStruct() { struct TestBufferStruct a; return a; } void AcceptPointer(int *a) { } void TestFunc() { AcceptArray(((GetTestBufferStruct

Re: [PATCH] D23901: Minor cleanup of the class CallStackFrame

alexshap added a comment. ping Repository: rL LLVM https://reviews.llvm.org/D23901 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D24484: [analyzer] Fix ExprEngine::VisitMemberExpr

alexshap added inline comments. Comment at: test/Analysis/array-struct.c:147 @@ +146,3 @@ + bar(((gets3().a))); +} + compnerd wrote: > Perhaps Im missing something, but theres no change to actually verify the > output? without the changes the analyzer is crash

<    1   2   3   4   >