alexshap added a subscriber: alexshap.

================
Comment at: clang-rename/USRFindingAction.h:38
@@ -37,5 +37,3 @@
 private:
-  unsigned SymbolOffset;
-  std::string OldName;
-  std::string SpellingName;
-  std::vector<std::string> USRs;
+  std::vector<unsigned> SymbolOffsets;
+  std::vector<std::string> OldNames;
----------------
in the constructor SymbolOffsets, OldNames are passed by non-constant reference
but then you make a copy.  


https://reviews.llvm.org/D23651



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to