[PATCH] D36876: [IRGen] Evaluate constant static variables referenced through member expressions

arphaman updated this revision to Diff 112149. arphaman added a comment. Revert most of the changes and use temporary DREs as suggested by John. Repository: rL LLVM https://reviews.llvm.org/D36876 Files: lib/CodeGen/CGExprComplex.cpp lib/CodeGen/CGExprScalar.cpp test/CodeGenCXX/member-

[PATCH] D36969: [Basic] Add a DiagnosticOr type

arphaman added a comment. In https://reviews.llvm.org/D36969#847803, @vsk wrote: > Would it be more convenient to extend ErrorInfo instead of creating a new > diagnostic wrapper? E.g one benefit of passing around Expected's is that > there's some assurance the diagnostics will be reported. Po

[PATCH] D36969: [Basic] Add a DiagnosticOr type

arphaman added a comment. In https://reviews.llvm.org/D36969#848518, @arphaman wrote: > In https://reviews.llvm.org/D36969#847803, @vsk wrote: > > > Would it be more convenient to extend ErrorInfo instead of creating a new > > diagnostic wrapper? E.g one benefit of passing around Expected's is t

[PATCH] D36969: [Basic] Add a DiagnosticError llvm::ErrorInfo subclass

arphaman updated this revision to Diff 112169. arphaman retitled this revision from "[Basic] Add a DiagnosticOr type" to "[Basic] Add a DiagnosticError llvm::ErrorInfo subclass". arphaman edited the summary of this revision. arphaman added a comment. Use `ErrorInfo` subclass as suggested by Vedan

[PATCH] D36075: [refactor] Initial support for refactoring action rules

arphaman added inline comments. Comment at: include/clang/Tooling/Refactoring/RefactoringOperationController.h:19 + +/// Encapsulates all of the possible state that an individual refactoring +/// operation might have. Controls the process of initiation of refactoring ---

[PATCH] D36075: [refactor] Initial support for refactoring action rules

arphaman updated this revision to Diff 112195. arphaman marked 7 inline comments as done. arphaman added a comment. - Split the header - Remove DiagnosticOr in favour of Expected that will use a DiagnosticError that was proposed in the other patch. - Address the other review comments Repository

[PATCH] D36685: [clang-diff] HTML diff navigation

arphaman added a comment. LGTM. There are some unrelated highlighting bugs in HTML though, for example if you take: before: int foo(); void bar(int x) { switch (x) { case 0: bar(2); } } after: void bar(int x) { switch (x) { case 4: bar(2); brea

[PATCH] D36969: [Basic] Add a DiagnosticError llvm::ErrorInfo subclass

arphaman marked 2 inline comments as done. arphaman added a comment. In https://reviews.llvm.org/D36969#848906, @vsk wrote: > Nice! I'd like to get your thoughts on two candidate ergonomic changes: Makes sense, I've added two similar helper functions in the updated patch. Repository: rL LLV

[PATCH] D36969: [Basic] Add a DiagnosticError llvm::ErrorInfo subclass

arphaman updated this revision to Diff 112327. arphaman added a comment. Add helper functions as suggested by Vedant. Repository: rL LLVM https://reviews.llvm.org/D36969 Files: include/clang/Basic/DiagnosticError.h lib/Basic/Diagnostic.cpp unittests/Basic/DiagnosticTest.cpp Index: uni

[PATCH] D36876: [IRGen] Evaluate constant static variables referenced through member expressions

arphaman added inline comments. Comment at: lib/CodeGen/CGExprComplex.cpp:163 +else + CGF.EmitLValue(ME->getBase()); +return *Constant; rjmccall wrote: > rjmccall wrote: > > There's an EmitIgnoredExpr you could use. > > > > Also, I think

[PATCH] D36876: [IRGen] Evaluate constant static variables referenced through member expressions

arphaman updated this revision to Diff 112360. arphaman marked 2 inline comments as done. arphaman added a comment. - Create `tryEmitAsConstant` for MemberExprs and `emitConstant` helper for complex values as suggested by John. - Remove dead constant emission code from CGExprAggregate.cpp - Emit

[PATCH] D37004: [clang-diff] Fix the html output for CXXOperatorCallExpr

arphaman added inline comments. Comment at: test/Tooling/clang-diff-ast.cpp:42 // CHECK: CXXRecordDecl: X;X;( -class X : Base { +struct X : Base { int m; Looks like an unrelated change. https://reviews.llvm.org/D37004

[PATCH] D37004: [clang-diff] Fix the html output for CXXOperatorCallExpr

arphaman added inline comments. Comment at: test/Tooling/clang-diff-ast.cpp:113 + +// CHECK: CXXOperatorCallExpr +// CHECK-NEXT: DeclRefExpr: str::operator+ This test doesn't work because it passes prior to this patch. You should test the HTML output instead.

[PATCH] D37002: [clang-diff] Treat CXXCtorInitializer as a node

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM, with one request below: Comment at: lib/Tooling/ASTDiff/ASTDiff.cpp:954 } - // We need to subtract 1 to get the number of descendants excluding the root. + //

[PATCH] D37072: [clang-diff] Properly clear the selection in HTML diff

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D37072 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/c

[PATCH] D36642: [Lexer] Report more precise skipped regions (PR34166)

arphaman added inline comments. Comment at: test/Index/skipped-ranges.c:23 // RUN: env CINDEXTEST_SHOW_SKIPPED_RANGES=1 c-index-test -test-annotate-tokens=%s:1:1:16:1 %s | FileCheck %s -// CHECK: Skipping: [5:2 - 6:7] -// CHECK: Skipping: [8:2 - 12:7] -// CHECK: Skipping: [14:2

[PATCH] D36642: [Lexer] Report more precise skipped regions (PR34166)

arphaman added inline comments. Comment at: lib/Lex/PPDirectives.cpp:564 + if (Callbacks) +Callbacks->SourceRangeSkipped( +SourceRange(HashToken.getLocation(), CurPPLexer->getSourceLocation())); You'd have to update the pp-tests in clang-tools-extra

[PATCH] D37104: [libc++] PR34298: Change std::function constructor and move assignment operator SFINAE checks to allow std::function with an incomplete return type

arphaman created this revision. This patch fixes PR34298 (https://bugs.llvm.org/show_bug.cgi?id=34298). Since Clang changed in r284549, Clang and libc++ prohibit the use of `std::function` with an incomplete return type, like in the example below: struct Continuation { std::function fn;

[PATCH] D36075: [refactor] Initial support for refactoring action rules

arphaman added inline comments. Comment at: include/clang/Tooling/Refactoring/RefactoringResult.h:21 +struct RefactoringResult { + enum ResultKind { +/// A set of source replacements represented using a vector of ioeric wrote: > I'm a bit unsure about the ab

[PATCH] D36075: [refactor] Initial support for refactoring action rules

arphaman added a comment. In https://reviews.llvm.org/D36075#851278, @ioeric wrote: > Thanks for the changes! The code is much clearer. > > I am wondering if the current design could be extended to support tools (or > rules) that use AST matchers? Or is the selection expected to be powerful > e

[PATCH] D36075: [refactor] Initial support for refactoring action rules

arphaman added inline comments. Comment at: include/clang/Tooling/Refactoring/RefactoringActionRuleRequirements.h:26 +template +detail::SourceSelectionRequirement< +typename selection::detail::EvaluateSelectionChecker< ioeric wrote: > Could you help me unde

[PATCH] D37004: [clang-diff] Fix the html output for CXXOperatorCallExpr

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM with one request below: Comment at: tools/clang-diff/ClangDiff.cpp:319 + "A Binary operator is supposed to have two arguments."); +for (int I : {1, 0,

[PATCH] D37003: [clang-diff] Support templates

arphaman added inline comments. Comment at: lib/Tooling/ASTDiff/ASTDiff.cpp:299 } +// We want nodes to be in the same order as in the source code. +// So we traverse template parameters before the remainder of the declaration. Interesting, I didn't know that t

[PATCH] D35012: [refactor] Add the AST source selection component

This revision was automatically updated to reflect the committed changes. Closed by commit rL311655: [refactor] Add the AST source selection component (authored by arphaman). Changed prior to commit: https://reviews.llvm.org/D35012?vs=108078&id=112550#toc Repository: rL LLVM https://reviews

[PATCH] D35012: [refactor] Add the AST source selection component

arphaman added a comment. r311664 Repository: rL LLVM https://reviews.llvm.org/D35012 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36075: [refactor] Initial support for refactoring action rules

arphaman updated this revision to Diff 112566. arphaman marked 2 inline comments as done. arphaman added a comment. - Rename `detail` to `internal`. - Remove the `BaseSpecializedRule`. - Simplify selection requirement and constraint evaluation. Repository: rL LLVM https://reviews.llvm.org/D36

[PATCH] D36075: [refactor] Initial support for refactoring action rules

arphaman added inline comments. Comment at: include/clang/Tooling/Refactoring/RefactoringResult.h:21 +struct RefactoringResult { + enum ResultKind { +/// A set of source replacements represented using a vector of ioeric wrote: > arphaman wrote: > > ioeric wr

[PATCH] D36075: [refactor] Initial support for refactoring action rules

arphaman added inline comments. Comment at: lib/Tooling/Refactoring/SourceSelectionConstraints.cpp:13 + +using namespace clang; +using namespace tooling; ioeric wrote: > We are tempted to avoid `using namespace` if possible. Why? It's not in a header. `using nam

[PATCH] D36876: [IRGen] Evaluate constant static variables referenced through member expressions

This revision was automatically updated to reflect the committed changes. Closed by commit rL311772: [IRGen] Evaluate constant static variables referenced through member (authored by arphaman). Changed prior to commit: https://reviews.llvm.org/D36876?vs=112360&id=112675#toc Repository: rL LL

[PATCH] D36998: [AST] Traverse templates in LexicallyOrderedRecursiveASTVisitor

arphaman added a comment. Awesome, thanks! Comment at: unittests/Tooling/LexicallyOrderedRecursiveASTVisitorTest.cpp:146 + DummyMatchVisitor Visitor; + Visitor.ExpectMatch("/f/T", 2, 11); + Visitor.ExpectMatch("/f/f/", 2, 20); johannes wrote: > This test als

[PATCH] D72411: [CodeGen] partially revert 2b4fa5348ee157b6b1a1af44d0137ca8c7a71573 to fix Objective-C static variable initialization

arphaman created this revision. arphaman added reviewers: rsmith, rjmccall, erik.pilkington, ahatanak. Herald added subscribers: ributzka, dexonsmith, jkorous. Herald added a project: clang. The following commit: commit 2b4fa5348ee157b6b1a1af44d0137ca8c7a71573 Author: Richard Smith Date:

[PATCH] D72411: [CodeGen] partially revert 2b4fa5348ee157b6b1a1af44d0137ca8c7a71573 to fix Objective-C static variable initialization

arphaman marked an inline comment as done. arphaman added inline comments. Comment at: clang/lib/CodeGen/CGDecl.cpp:377 - if (D.needsDestruction(getContext()) && HaveInsertPoint()) { + if (hasNontrivialDestruction(D.getType()) && HaveInsertPoint()) { // We have a constan

[PATCH] D82777: Clang Driver: Use Apple ld64's new @response-file support.

arphaman added a comment. got it, we'll do what we can to release it as soon as possible in Xcode Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82777/new/ https://reviews.llvm.org/D82777 ___ cfe-commits

[PATCH] D93247: [Sema] Fix a miscompile by retaining array qualifiers when folding VLAs to constant arrays

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93247/new/ https://reviews.llvm.org/D93247 ___ cfe-commits mailing list cfe-comm

[PATCH] D92788: [clangd] NFC: Use SmallVector where possible

arphaman added inline comments. Comment at: clang-tools-extra/clangd/Headers.h:139 // Maps a file's index to that of the files it includes. - llvm::DenseMap> IncludeChildren; + llvm::DenseMap> IncludeChildren; }; It looks like the change on this line is fai

[PATCH] D92788: [clangd] NFC: Use SmallVector where possible

arphaman added inline comments. Comment at: clang-tools-extra/clangd/Headers.h:139 // Maps a file's index to that of the files it includes. - llvm::DenseMap> IncludeChildren; + llvm::DenseMap> IncludeChildren; }; sammccall wrote: > kbobyrev wrote: > > arpha

[PATCH] D92531: Basic: Support named pipes natively in SourceManager

arphaman added a comment. Left one minor suggestion , but LGTM otherwise Comment at: clang/lib/Basic/SourceManager.cpp:167 + // (which may have come from a stat cache). + if (ContentsEntry->isNamedPipe()) { +// Check the buffer size directly if this is a named pipe. -

[PATCH] D93148: Basic: Add native support for stdin to SourceManager and FileManager

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. Nice, it looks cleaner than the override of file contents that was used before. Left one NIT comment Comment at: clang/lib/Basic/FileManager.cpp:352 + + STDIN = getVirt

[PATCH] D86105: [darwin] Disable the -Wpsabi warning

arphaman updated this revision to Diff 302977. arphaman added a comment. Address Ahmed's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86105/new/ https://reviews.llvm.org/D86105 Files: clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGen/target-avx-abi-diag.c clang/test/

[PATCH] D86105: [darwin] Disable the -Wpsabi warning

arphaman marked 2 inline comments as done. arphaman added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:2561-2565 // The "avx" feature changes how vectors >128 in size are passed. "avx512f" // additionally changes how vectors >256 in size are passed. Lik

[PATCH] D90891: [clang] ns_error_domain attribute also supports CFString typed variables

arphaman created this revision. arphaman added reviewers: erik.pilkington, MForster. Herald added subscribers: ributzka, jkorous. Herald added a reviewer: aaron.ballman. arphaman requested review of this revision. The change in a5b8757506b07e3091fe243b6c1e004220d3cba3

[PATCH] D90891: [clang] ns_error_domain attribute also supports CFString typed variables

This revision was automatically updated to reflect the committed changes. Closed by commit rG3df3b62018c0: [clang] ns_error_domain attribute also supports CFString typed variables (authored by arphaman). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D91204: [clang-scan-deps] Fix for input file given as relative path in compilation database "command" entry

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. This make sense to me, thank you CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91204/new/ https://reviews.llvm.org/D91204 ___ cfe-comm

[PATCH] D66782: SourceManager: Prefer Optional over MemoryBuffer*

arphaman added inline comments. Comment at: clang-tools-extra/clangd/SourceCode.cpp:459 Position P) { - llvm::StringRef Code = SM.getBuffer(SM.getMainFileID())->getBuffer(); + llvm::StringRef Code = SM.getBufferOrFake(SM.

[PATCH] D89136: Lex: Avoid MemoryBuffer* key in ExcludedPreprocessorDirectiveSkipMapping, NFC

arphaman added inline comments. Comment at: clang/lib/Tooling/DependencyScanning/DependencyScanningFilesystem.cpp:222 - const llvm::MemoryBuffer *getBufferPtr() const { return Buffer.get(); } + const char *getBufferPtr() const { +return Buffer ? nullptr : Buffer->getBuff

[PATCH] D89136: Lex: Avoid MemoryBuffer* key in ExcludedPreprocessorDirectiveSkipMapping, NFC

arphaman accepted this revision. arphaman added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Tooling/DependencyScanning/DependencyScanningFilesystem.cpp:249 if (!Entry->getPPSkippedRangeMapping().empty() && PPSkipMappings) -(*PPS

[PATCH] D92354: [clang] add a new `swift_attr` attribute

arphaman created this revision. arphaman added reviewers: erik.pilkington, aaron.ballman. Herald added subscribers: ributzka, jkorous. Herald added a project: clang. arphaman requested review of this revision. The `swift_attr` attribute is a generic annotation attribute that's not used by clang,

[PATCH] D92355: [clang] add a `swift_async_name` attribute

arphaman created this revision. arphaman added reviewers: erik.pilkington, aaron.ballman. Herald added subscribers: ributzka, jkorous. Herald added a project: clang. arphaman requested review of this revision. The `swift_async_name` attribute provides a name for a function/method that can be used

[PATCH] D92602: [objc] diagnose protocol conformance in categories with direct members in their corresponding class interfaces

arphaman created this revision. arphaman added reviewers: erik.pilkington, MadCoder. Herald added subscribers: ributzka, jfb, jkorous. arphaman requested review of this revision. Herald added a project: clang. Categories that add protocol conformances to classes with direct members should prohibi

[PATCH] D92354: [clang] add a new `swift_attr` attribute

arphaman updated this revision to Diff 309553. arphaman marked 2 inline comments as done. arphaman added a comment. Updated for review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92354/new/ https://reviews.llvm.org/D92354 Files: clang

[PATCH] D92354: [clang] add a new `swift_attr` attribute

arphaman added a comment. Thanks for taking a look. In D92354#2428604 , @erik.pilkington wrote: > Do we need to add APINotes support for this? Not at the moment, maybe in the future Comment at: clang/include/clang/Basic/Attr.td:2153

[PATCH] D92355: [clang] add a `swift_async_name` attribute

arphaman updated this revision to Diff 309582. arphaman marked 3 inline comments as done. arphaman added a comment. Herald added a subscriber: jdoerfert. address review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92355/new/ https://reviews.llvm.org/D92355 Files: clang/incl

[PATCH] D92355: [clang] add a `swift_async_name` attribute

arphaman added a comment. In D92355#2429117 , @aaron.ballman wrote: > There's no information in either the attribute definition in Attr.td or in > the documentation as to what subject this attribute applies to. Added a subject list to the attribute.

[PATCH] D92354: [clang] add a new `swift_attr` attribute

This revision was automatically updated to reflect the committed changes. Closed by commit rG03dcd57ecf99: [clang] add a new `swift_attr` attribute (authored by arphaman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92354/new/ https://reviews.llvm

[PATCH] D92355: [clang] add a `swift_async_name` attribute

This revision was automatically updated to reflect the committed changes. Closed by commit rGeddd1d192bca: [clang] add a `swift_async_name` attribute (authored by arphaman). Changed prior to commit: https://reviews.llvm.org/D92355?vs=309582&id=309690#toc Repository: rG LLVM Github Monorepo

[PATCH] D92602: [objc] diagnose protocol conformance in categories with direct members in their corresponding class interfaces

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdb226cdf4cf9: [objc] diagnose protocol conformance in categories with direct members (authored by arphaman). Repository: rG LLVM Github Monorepo

[PATCH] D89469: FileManager: Test FileManager::getFileRef

arphaman added a comment. Thanks. Could you expand the comment in the test that this test path specifically exercises the behavior produced by the RedirectingFileSystem? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89469/new/ https://reviews.llvm.org/D89469 __

[PATCH] D82699: [driver][arm64] Set target CPU to A12 for compiler invocations that target Apple Silicon

arphaman updated this revision to Diff 299564. arphaman added a comment. Don't try to fallback to the "apple-a12" cpu type when the user explicitly specifies an older cpu. The default is still "apple-a12". CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82699/new/ https://reviews.llvm.or

[PATCH] D82699: [driver][arm64] Set target CPU to A12 for compiler invocations that target Apple Silicon

This revision was automatically updated to reflect the committed changes. Closed by commit rGde1016ce5cdc: [driver][arm64] Set target CPU to A12 for compiler invocations that (authored by arphaman). Changed prior to commit: https://reviews.llvm.org/D82699?vs=299564&id=299879#toc Repository:

[PATCH] D89514: clangd: Stop calling FileEntryRef::FileEntryRef

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM with a nit. Comment at: clang-tools-extra/clangd/ParsedAST.cpp:222 if (File) // FIXME: Use correctly named FileEntryRef. +Delegate->FileSkipp

[PATCH] D89488: FileManager: Shrink FileEntryRef to the size of a pointer

arphaman added inline comments. Comment at: clang/lib/Basic/FileManager.cpp:217 FileEntry *FE; -if (LLVM_LIKELY(FE = Value.dyn_cast())) - return FileEntryRef(SeenFileInsertResult.first->first(), *FE); -return getFileRef(*Value.get(), openFile, CacheFailure); +

[PATCH] D89834: FileManager: Improve the FileEntryRef API and add MaybeFileEntryRef

arphaman added a comment. What's wrong with using `Optional` instead of `MaybeFileEntryRef`? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89834/new/ https://reviews.llvm.org/D89834 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D89834: FileManager: Improve the FileEntryRef API and customize its OptionalStorage

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. This approach seems like a reasonable compromise, thanks! LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89834/new/ https://reviews.llvm.org/D89834 _

[PATCH] D90367: [darwin] add support for __isPlatformVersionAtLeast check for if (@available)

arphaman created this revision. arphaman added reviewers: thakis, dexonsmith. Herald added subscribers: Sanitizers, ributzka, dmgreen, jkorous. Herald added projects: clang, Sanitizers. arphaman requested review of this revision. The __isPlatformVersionAtLeast routine is an implementation of `if

[PATCH] D60193: [OpenCL] Added addrspace_cast operator

arphaman added a comment. This warrants a revert since it's breaking ABI compatibility for our libclang's users. @Anastasia will you be able to take a look at this soon? I plan on reverting this patch in a couple of weeks if the issue is still unresolved. Repository: rG LLVM Github Monorepo

[PATCH] D90367: [darwin] add support for __isPlatformVersionAtLeast check for if (@available)

arphaman added inline comments. Comment at: clang/lib/CodeGen/CGObjC.cpp:3874 if (!CGM.IsOSVersionAtLeastFn) { llvm::FunctionType *FTy = thakis wrote: > Isn't the rest of the function basically dead code? Do non-darwin targets > support this feature? A

[PATCH] D90481: Basic: Change Module::Umbrella to a PointerUnion, NFC

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM, thanks for cleaning it up CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90481/new/ https://reviews.llvm.org/D90481 ___ cfe-commi

[PATCH] D90367: [darwin] add support for __isPlatformVersionAtLeast check for if (@available)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG701456b52355: [darwin] add support for __isPlatformVersionAtLeast check for if (@available) (authored by arphaman). Repository: rG LLVM Github Mon

[PATCH] D102338: [Sema] Always search the full function scope context if a potential availability violation is encountered

arphaman added a comment. Thanks for the patch! I think the new checking semantics behavior provided by this patch are fine and match what the Swift compiler allows in the `if #available` blocks in Swift. I will do some additional testing tomorrow but I'm hoping I can approve your patch in the

[PATCH] D102459: [clang][ObjC] Allow different availability annotation on a method when implementing an optional protocol requirement

arphaman created this revision. arphaman added a reviewer: erik.pilkington. Herald added subscribers: ributzka, jfb. Herald added a reviewer: aaron.ballman. arphaman requested review of this revision. When an Objective-C method implements an optional protocol requirement, allow the method to use a

[PATCH] D102489: [Clang,Driver] Add -fveclib=Darwin_libsystem_m support.

arphaman added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:405 break; + case CodeGenOptions::Darwin_libsystem_m: +TLII->addVectorizableFunctionsFromVecLib( Can you add an IRGen testcase that verifies that TLII is setting the vecLib c

[PATCH] D102494: [Clang, Driver] Default to Darwin_libsystem_m veclib on iOS based targets.

arphaman added inline comments. Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:2492 + // Darwin_libsystem_m for iOS based targets. + if (isTargetIOSBased() && !DriverArgs.hasArgNoClaim(options::OPT_fveclib)) +CC1Args.push_back("-fveclib=Darwin_libsystem_m"); ---

[PATCH] D102489: [Clang,Driver] Add -fveclib=Darwin_libsystem_m support.

arphaman added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:405 break; + case CodeGenOptions::Darwin_libsystem_m: +TLII->addVectorizableFunctionsFromVecLib( fhahn wrote: > arphaman wrote: > > Can you add an IRGen testcase that verifies

[PATCH] D102494: [Clang, Driver] Default to Darwin_libsystem_m veclib on iOS based targets.

arphaman added inline comments. Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:2492 + // Darwin_libsystem_m for iOS based targets. + if (isTargetIOSBased() && !DriverArgs.hasArgNoClaim(options::OPT_fveclib)) +CC1Args.push_back("-fveclib=Darwin_libsystem_m"); ---

[PATCH] D102459: [clang][ObjC] Allow different availability annotation on a method when implementing an optional protocol requirement

arphaman updated this revision to Diff 345529. arphaman added a comment. Do not apply this to 'deprecated' availability annotations - the user has no way to check for deprecated as `respondsToSelector` will still return true even if the class has marked the method as deprecated. CHANGES SINCE

[PATCH] D102459: [clang][ObjC] Allow different availability annotation on a method when implementing an optional protocol requirement

This revision was automatically updated to reflect the committed changes. Closed by commit rG50be48b0f3c8: [clang][ObjC] Allow different availability annotation on a method (authored by arphaman). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D102633: [clang-scan-deps] Improvements to thread usage

arphaman added a reviewer: aganea. arphaman added a comment. It might be good for @aganea to take a look as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102633/new/ https://reviews.llvm.org/D102633 __

[PATCH] D102338: [Sema] Always search the full function scope context if a potential availability violation is encountered

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. I think this is good to go, I haven't observed any issues with this patch so far in my testing. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D86881: Make -fvisibility-inlines-hidden apply to static local variables in inline functions on Darwin

arphaman added a comment. Hey, thanks for following up on this PR. I've done some more digging and I think we can remove this Darwin-specific workaround in the near future. I'm hoping to provide an update in the next few weeks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D95845: [ObjC] Add a command line flag that disables recognition of objc_direct for testability

arphaman added inline comments. Comment at: clang/include/clang/Driver/Options.td:2141 + Group, Flags<[CC1Option]>, + HelpText<"Ignore attribute objc_direct so that direct methods can be tested">; + Do you need to use the new options marshaling infrastructure?

[PATCH] D105765: Prepare Compiler-RT for GnuInstallDirs, matching libcxx, document all

arphaman added inline comments. Comment at: compiler-rt/cmake/Modules/CompilerRTDarwinUtils.cmake:509 set(DARWIN_macho_embedded_LIBRARY_OUTPUT_DIR - ${COMPILER_RT_OUTPUT_DIR}/lib/macho_embedded) + ${COMPILER_RT_OUTPUT_LIBRARY_DIR}/macho_embedded) set(DARWIN_ma

[PATCH] D96572: [Clang][ASan] Introduce `-fsanitize-address-destructor-kind=` driver & frontend option.

arphaman accepted this revision. arphaman added a comment. Thanks, LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96572/new/ https://reviews.llvm.org/D96572 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D104031: [clang][deps] Move injection of `-Wno-error` from `clang-scan-deps` to `DependencyScanning` library

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. Thanks, LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104031/new/ https://reviews.llvm.org/D104031 ___

[PATCH] D104033: [clang][deps] Move enabling system header deps from `clang-scan-deps` to `DependencyScanning` library

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. Thanks, LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104033/new/ https://reviews.llvm.org/D104033 ___

[PATCH] D104348: [index] Fix performance regression with indexing macros

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. Thanks, LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104348/new/ https://reviews.llvm.org/D104348 __

[PATCH] D104462: [clang][lex] Add minimizer option to pad the output to the input size

arphaman added a comment. I agree with Duncan, it would be good to avoid modifying the existing test cases if possible Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104462/new/ https://reviews.llvm.org/D104462

[PATCH] D103930: [clang][HeaderSearch] Fix implicit module when using header maps

arphaman added a comment. I've started testing this change. I'll let you know how it looks in a few days. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103930/new/ https://reviews.llvm.org/D103930 ___ cf

[PATCH] D106316: [clang][darwin] Add support for the -mtargetos= option to the driver

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf575f371822f: [clang][darwin] Add support for the -mtargetos= option to the driver (authored by arphaman). Herald added a project: clang. Repository

[PATCH] D106864: [clang][cli] Expose -fno-cxx-modules in cc1

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. Thanks, LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106864/new/ https://reviews.llvm.org/D106864 ___ cfe-commits mailing list c

[PATCH] D105052: [clang][darwin] add support for Mac Catalyst availability

arphaman created this revision. arphaman added reviewers: dexonsmith, dcoughlin, Bigcheese. Herald added a subscriber: ributzka. Herald added a reviewer: aaron.ballman. arphaman requested review of this revision. This patch adds support for Mac Catalyst availability attribute, as supported by the

[PATCH] D105257: [clang][darwin] add support for remapping macOS availability to Mac Catalyst availability

arphaman created this revision. arphaman added reviewers: dexonsmith, Bigcheese, dcoughlin. Herald added a subscriber: ributzka. Herald added a reviewer: aaron.ballman. arphaman requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: llvm-commits. This pat

[PATCH] D105052: [clang][darwin] add support for Mac Catalyst availability

arphaman added a comment. Thanks for the feedback, I'll update this patch tomorrow. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105052/new/ https://reviews.llvm.org/D105052 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[PATCH] D103930: [clang][HeaderSearch] Fix implicit module when using header maps

arphaman added a comment. Looks like this patch causes a number of issues for us, I will work with @jansvoboda11 to see if there's some way to resolve them. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103930/new/ https://reviews.llvm.org/D103930

[PATCH] D105052: [clang][darwin] add support for Mac Catalyst availability

arphaman updated this revision to Diff 358457. arphaman added a comment. Sorry, took a bit longer than anticipated. I updated the patch to address reviewer's comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105052/new/ https://reviews.llvm.org/D105052 Files: clang/include/clan

[PATCH] D105958: [clang][darwin] add support for version remapping to the Darwin SDK Info class

arphaman created this revision. arphaman added reviewers: dexonsmith, Bigcheese. Herald added subscribers: ributzka, mgorny. arphaman requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: llvm-commits. This patch is a pre-commit for https://reviews.llvm.

[PATCH] D105958: [clang][darwin] add support for version remapping to the Darwin SDK Info class

arphaman updated this revision to Diff 358510. arphaman added a comment. fix typo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105958/new/ https://reviews.llvm.org/D105958 Files: clang/include/clang/Basic/DarwinSDKInfo.h clang/lib/Basic/DarwinSDKInfo.cpp clang/lib/Driver/ToolCha

[PATCH] D105257: [clang][darwin] add support for remapping macOS availability to Mac Catalyst availability

arphaman updated this revision to Diff 358511. arphaman marked 11 inline comments as done. arphaman added a comment. Split patch and address review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105257/new/ https://reviews.llvm.org/D105257 Files: clang/include/clang/Basic/Dia

[PATCH] D105257: [clang][darwin] add support for remapping macOS availability to Mac Catalyst availability

arphaman added inline comments. Comment at: clang/include/clang/Basic/DarwinSDKInfo.h:129 + static Optional + parseDarwinSDKSettingsJSON(StringRef FilePath, const llvm::json::Object *Obj); + dexonsmith wrote: > Should this take the VFS? No, the Filepath is not

[PATCH] D105257: [clang][darwin] add support for remapping macOS availability to Mac Catalyst availability

arphaman added a comment. In D105257#2853438 , @dexonsmith wrote: > Could the DarwinSDKInfo changes be tested directly with C++ unit tests? Since > this stuff is in Basic it'd be nice to test it separately from the driver. If > so, maybe they could als

[PATCH] D105958: [clang][darwin] add support for version remapping to the Darwin SDK Info class

arphaman added a comment. This patch depends on a small NFC commit that moves DarwinSDKInfo over to lib/Basic from lib/Driver, which isn't up on phabricator. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105958/new/ https://reviews.llvm.org/D105958

<    4   5   6   7   8   9   10   11   12   13   >