Re: r267464 - Module Debugging: Fix the condition for determining whether a template

> On Apr 26, 2016, at 4:11 PM, Richard Smith wrote: > > On Tue, Apr 26, 2016 at 3:10 PM, Adrian Prantl via cfe-commits > mailto:cfe-commits@lists.llvm.org>> wrote: > >> On Apr 25, 2016, at 5:34 PM, Richard Smith > <mailto:rich...@metafoo.co.uk>> wrote:

Re: [PATCH] D19567: PR21823: 'nodebug' attribute on global/static variables

aprantl added a comment. Debug info changes otherwise look good to me. Comment at: test/CodeGenCXX/debug-info-nodebug.cpp:17 @@ +16,3 @@ +// YESINFO-DAG: !DIGlobalVariable(name: "global_int_def" +// NOINFO-NOT: !DIGlobalVariable(name: "global_int_def" + I don't

r267740 - Module debugging: Fix the DWO filename for PCH in a relative path.

Author: adrian Date: Wed Apr 27 12:06:22 2016 New Revision: 267740 URL: http://llvm.org/viewvc/llvm-project?rev=267740&view=rev Log: Module debugging: Fix the DWO filename for PCH in a relative path. PCH in a relative location had a redundant relative path on the DWO filename and the DW_AT_compila

Re: [PATCH] D19567: PR21823: 'nodebug' attribute on global/static variables

aprantl added a comment. Ah great, I didn't know that! http://reviews.llvm.org/D19567 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19048: Test for a module related crash in CGDebugInfo.cpp

aprantl added a comment. Thanks! Is there anything meaningful that could be CHECKed here? Usually a crash means that we previously had a code path without test coverage. http://reviews.llvm.org/D19048 ___ cfe-commits mailing list cfe-commits@lists.

Re: [PATCH] D19443: Module Debugging: Fix the condition for determining whether a template instantiation is in a module.

aprantl closed this revision. aprantl added a comment. Thanks! Committed as 267464, 267633, 267630, 267612, 267611. Repository: rL LLVM http://reviews.llvm.org/D19443 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/c

Re: [PATCH] D19048: Test for a module related crash in CGDebugInfo.cpp

> On Apr 27, 2016, at 7:27 PM, Douglas Yung wrote: > > dyung added a comment. > > In http://reviews.llvm.org/D19048#414568, @aprantl wrote: > >> Thanks! >> >> Is there anything meaningful that could be CHECKed here? >> Usually a crash means that we previously had a code path without test >>

r267904 - Debug info: Apply an artificial debug location to __cyg_profile_func.* calls.

Author: adrian Date: Thu Apr 28 12:21:56 2016 New Revision: 267904 URL: http://llvm.org/viewvc/llvm-project?rev=267904&view=rev Log: Debug info: Apply an artificial debug location to __cyg_profile_func.* calls. The LLVM Verifier expects all inlinable calls in debuggable functions to have a locatio

Re: r267904 - Debug info: Apply an artificial debug location to __cyg_profile_func.* calls.

a (terrible) example (given the nature of these function calls :-p) if you look at a profile you wouldn’t want these function calls to be misattributed to any line in the source code. -- adrian > > On Thu, Apr 28, 2016 at 10:21 AM, Adrian Prantl via cfe-commits > mailto:cfe-commits@lis

Re: r267904 - Debug info: Apply an artificial debug location to __cyg_profile_func.* calls.

of the instructions before it. - Debugging: Since there is no source code for it a source-based debugger (you can still switch to disassembly) should treat the function call as transparent and skip over it as if it didn’t exist. -- adrian > > - Dave > > > -- adrian > >>

Re: [PATCH] D19048: Test for a module related crash in CGDebugInfo.cpp

aprantl added inline comments. Comment at: test/Modules/getSourceDescriptor-crash.cpp:6 @@ +5,2 @@ + +// CHECK: DIModule2 This doesn't actually appear in the output :-) You probably want to at least check for the correct name of the module and for the DIImportedE

Re: [PATCH] D19679: Method pool in modules: sync up out of date selectors before writing the module

aprantl added inline comments. Comment at: include/clang/Serialization/ASTReader.h:657 @@ +656,3 @@ + /// Whether a selector is out of date. We mark a selector as out of date + // if we load another module after the method pool entry was pulled in. + llvm::DenseMap SelectorOutO

Re: [PATCH] D19048: Test for a module related crash in CGDebugInfo.cpp

aprantl added a comment. Please make sure that the two DINodes are connected, otherwise LGTM. Thanks! http://reviews.llvm.org/D19048 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r267904 - Debug info: Apply an artificial debug location to __cyg_profile_func.* calls.

id at the beginning that this example was a terrible one :-) > Do people sample /and/ counter profile the same binary?) Hopefully not. This was really just meant as an example why someone would choose an artificial location over a concrete one in similar situations. In the end, I’m not particul

Re: [PATCH] D19679: Method pool in modules: sync up out of date selectors before writing the module

aprantl added inline comments. Comment at: test/Modules/method_pool_write.m:3 @@ +2,3 @@ +// RUN: %clang_cc1 -fmodules-cache-path=%t -fmodules -fimplicit-module-maps -I %S/Inputs %s -verify +// expected-no-diagnostics + manmanren wrote: > aprantl wrote: > > Is th

Re: [PATCH] D20415: Update Clang for D20147 ("DebugInfo: New metadata representation for global variables.")

aprantl added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:3393 @@ +3392,3 @@ +DContext, FieldName, LinkageName, Unit, LineNo, FieldTy, +Var->hasInternalLinkage(), nullptr, nullptr); +Var->addDebugInfo(GV); Is there a good reason fo

Re: [PATCH] D20415: Update Clang for D20147 ("DebugInfo: New metadata representation for global variables.")

aprantl added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:3393 @@ +3392,3 @@ +DContext, FieldName, LinkageName, Unit, LineNo, FieldTy, +Var->hasInternalLinkage(), nullptr, nullptr); +Var->addDebugInfo(GV); aprantl wrote: > Is there

Re: [PATCH] D20415: Update Clang for D20147 ("DebugInfo: New metadata representation for global variables.")

aprantl added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:3477 @@ -3473,1 +3476,3 @@ +InitExpr = +DBuilder.createConstantValueExpression(Init.getInt().getExtValue()); GV.reset(DBuilder.createGlobalVariable( pcc wrote: > aprantl wrote: >

Re: [PATCH] D20415: Update Clang for D20147 ("DebugInfo: New metadata representation for global variables.")

aprantl added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:3477 @@ -3473,1 +3476,3 @@ +InitExpr = +DBuilder.createConstantValueExpression(Init.getInt().getExtValue()); GV.reset(DBuilder.createGlobalVariable( pcc wrote: > aprantl wrote: >

[PATCH] D18565: Implement an "I'm dtrace, please retain all debug types" option.

aprantl created this revision. aprantl added reviewers: dblaikie, dexonsmith. aprantl added a subscriber: cfe-commits. aprantl set the repository for this revision to rL LLVM. As noted in the review thread for http://reviews.llvm.org/D18477 on llvm-commits, DWARF consumers such as dtrace's ctfcon

Re: [PATCH] D18565: Implement an "I'm dtrace, please retain all debug types" option.

> On Mar 29, 2016, at 12:00 PM, Joerg Sonnenberger > wrote: > > On Tue, Mar 29, 2016 at 06:47:24PM +0000, Adrian Prantl via cfe-commits wrote: >> This code in this patch listens to the driver option -gfull, and lowers it >> to the new cc1 option -debug-retain-types (1

Re: [PATCH] D18565: Implement an "I'm dtrace, please retain all debug types" option.

> On Mar 29, 2016, at 10:06 PM, David Blaikie wrote: > > > > On Tue, Mar 29, 2016 at 12:03 PM, Adrian Prantl via cfe-commits > mailto:cfe-commits@lists.llvm.org>> wrote: > > > On Mar 29, 2016, at 12:00 PM, Joerg Sonnenberger > <mailto:jo...@britannica

Re: [PATCH] D18565: Implement an "I'm dtrace, please retain all debug types" option.

> On Mar 30, 2016, at 12:50 AM, Joerg Sonnenberger via cfe-commits > wrote: > > On Tue, Mar 29, 2016 at 12:03:46PM -0700, Adrian Prantl via cfe-commits wrote: >> >>> On Mar 29, 2016, at 12:00 PM, Joerg Sonnenberger >>> wrote: >>> >>> O

Re: [PATCH] D18565: Implement an "I'm dtrace, please retain all debug types" option.

> On Mar 30, 2016, at 2:19 PM, Joerg Sonnenberger via cfe-commits > wrote: > > On Wed, Mar 30, 2016 at 10:54:32AM -0700, Adrian Prantl via cfe-commits wrote: >>> Let's take a kernel as example. I want to include certain types for >>> dtrace-like use with /

r265078 - Adapt to LLVM API change in r265077.

Author: adrian Date: Thu Mar 31 18:57:45 2016 New Revision: 265078 URL: http://llvm.org/viewvc/llvm-project?rev=265078&view=rev Log: Adapt to LLVM API change in r265077. EmissionKind moved from DIBuilder to DICompileUnit. Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp cfe/trunk/test/C

Re: [PATCH] D18565: Implement an "I'm dtrace, please retain all debug types" option.

>> >> >> On Tue, Mar 29, 2016 at 12:03 PM, Adrian Prantl via cfe-commits >> mailto:cfe-commits@lists.llvm.org>> wrote: >> >> > On Mar 29, 2016, at 12:00 PM, Joerg Sonnenberger > > <mailto:jo...@britannica.bec.de>> wrote: >> > >>

Re: r265195 - [modules] Start moving the code for encoding AST records out of ASTWriter into

Hi Richard, it looks like this commit has caused a 6% size regression when building a PCH from OS X’s Cocoa.h. When comparing the llvm-bcanalyzer output for r265187 and r265195 the most noticeable diff is in the DECLTYPES_BLOCK: Block ID #11 (DECLTYPES_BLOCK): Num Instances: 1 -

Re: [PATCH] D18565: Implement an "I'm dtrace, please retain all debug types" option.

aprantl abandoned this revision. aprantl added a comment. Meanwhile I made an experiment and compiled XNU with http://reviews.llvm.org/D18477 and compared the debug info from before and after and found no missing types at all. It is plausible that r107027 was added to work around the fact that

[PATCH] D18808: Use the NoDebug emission kind to identify compile units that no debug info should be created from.

aprantl created this revision. aprantl added reviewers: dblaikie, echristo, dexonsmith. aprantl added subscribers: davide, llvm-commits, cfe-commits. aprantl set the repository for this revision to rL LLVM. As indicated in D18612, sample-based profiling and optimization remarks currently remove D

Re: [PATCH] D18808: Use the NoDebug emission kind to identify compile units that no debug info should be created from.

> On Apr 6, 2016, at 8:16 AM, David Blaikie wrote: > > > > On Tue, Apr 5, 2016 at 10:17 PM, Eric Christopher via llvm-commits > mailto:llvm-comm...@lists.llvm.org>> wrote: > echristo added inline comments. > > > Comment at: lib/CodeGen/AsmPrinter/DwarfDebug.cpp:477-479 > @@

Re: [PATCH] D18808: Use the NoDebug emission kind to identify compile units that no debug info should be created from.

aprantl removed rL LLVM as the repository for this revision. aprantl updated this revision to Diff 52842. aprantl added a comment. This patch adds a DICompileUnit iterator to Module that skips over NoDebug CUs. http://reviews.llvm.org/D18808 Files: include/llvm/IR/DIBuilder.h include/llvm/I

Re: [PATCH] D18808: Use the NoDebug emission kind to identify compile units that no debug info should be created from.

aprantl added a comment. Oh. And I also discovered a completely bit-rotted pass called BreakpointPrinter that can impossible function because it looks at llvm.dbg.sp. Looks like it could be easily updated, though. http://reviews.llvm.org/D18808 __

Re: [PATCH] D18808: Use the NoDebug emission kind to identify compile units that no debug info should be created from.

aprantl added a comment. Duncan: There already exists a verifier check that ensures each DICompileUnit is listed in llvm.dbg.cu. This didn't break existing users of sample-based profiling, because the Verifier cannot *find* the orphaned DICompileUnits. After the DISubprogram / DICompileUnit poi

Re: [PATCH] D18808: Use the NoDebug emission kind to identify compile units that no debug info should be created from.

> On Apr 6, 2016, at 2:56 PM, David Blaikie wrote: > > > > On Wed, Apr 6, 2016 at 8:44 AM, Adrian Prantl > wrote: > >> On Apr 6, 2016, at 8:16 AM, David Blaikie > > wrote: >> >> >> >> On Tue, Apr 5, 2016 at 10:17 PM, Eric Christopher vi

Re: [PATCH] D11958: Add a -gmodules option to the clang driver.

aprantl accepted this revision. aprantl added a reviewer: aprantl. aprantl added a comment. This revision is now accepted and ready to land. This landed a long time ago as r246192. Repository: rL LLVM http://reviews.llvm.org/D11958 ___ cfe-commit

r265862 - Use NoDebug compile units to mark debug metadata used only for sample-based

Author: adrian Date: Fri Apr 8 17:43:06 2016 New Revision: 265862 URL: http://llvm.org/viewvc/llvm-project?rev=265862&view=rev Log: Use NoDebug compile units to mark debug metadata used only for sample-based profiling and optimization remarks and indicate that no debug info shall be emitted for t

Re: [PATCH] D18808: Use the NoDebug emission kind to identify compile units that no debug info should be created from.

aprantl closed this revision. aprantl marked an inline comment as done. aprantl added a comment. 265860+265861 http://reviews.llvm.org/D18808 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

Re: [PATCH] D19072: [CodeGen] Split CGDebugInfo into CGDebugInfo and CGDebugDwarf

aprantl added inline comments. Comment at: lib/CodeGen/CodeGenModule.h:292 @@ -291,3 +291,3 @@ CGCUDARuntime* CUDARuntime; - CGDebugInfo* DebugInfo; + std::unique_ptr DebugInfo; ObjCEntrypoints *ObjCData; This could be a separate useful NFC commit. http:

r266445 - Update to match LLVM changes for PR27284.

Author: adrian Date: Fri Apr 15 10:55:45 2016 New Revision: 266445 URL: http://llvm.org/viewvc/llvm-project?rev=266445&view=rev Log: Update to match LLVM changes for PR27284. (Reverse the ownership between DICompileUnit and DISubprogram.) http://reviews.llvm.org/D19034 Modified: cfe/trunk/l

r266447 - Update testcase to new debug info metadata format.

Author: adrian Date: Fri Apr 15 11:05:13 2016 New Revision: 266447 URL: http://llvm.org/viewvc/llvm-project?rev=266447&view=rev Log: Update testcase to new debug info metadata format. Modified: cfe/trunk/test/CodeGen/backend-unsupported-error.ll Modified: cfe/trunk/test/CodeGen/backend-unsup

r266449 - Fix testcase for MSVC targets where the output ordering is different.

Author: adrian Date: Fri Apr 15 11:21:23 2016 New Revision: 266449 URL: http://llvm.org/viewvc/llvm-project?rev=266449&view=rev Log: Fix testcase for MSVC targets where the output ordering is different. Modified: cfe/trunk/test/CodeGenCXX/debug-info-limited.cpp Modified: cfe/trunk/test/CodeG

Re: [PATCH] D19072: [CodeGen] Split CGDebugInfo into CGDebugInfo and CGDebugDwarf

aprantl added inline comments. Comment at: lib/CodeGen/CGDebugInfo.h:97 @@ -273,3 +96,3 @@ /// Set the main CU's DwoId field to \p Signature. - void setDwoId(uint64_t Signature); + virtual void setDwoId(uint64_t Signature) = 0; Why does this need to be virt

r266698 - [ObjC++] Fix crash when emitting debug info for a block member capturing this.

Author: adrian Date: Mon Apr 18 18:48:16 2016 New Revision: 266698 URL: http://llvm.org/viewvc/llvm-project?rev=266698&view=rev Log: [ObjC++] Fix crash when emitting debug info for a block member capturing this. rdar://problem/23871824 Added: cfe/trunk/test/CodeGenObjCXX/debug-info-block-cap

r266814 - cc1as: Don't crash when CIE is requested and no DWARF version is specified.

Author: adrian Date: Tue Apr 19 15:31:19 2016 New Revision: 266814 URL: http://llvm.org/viewvc/llvm-project?rev=266814&view=rev Log: cc1as: Don't crash when CIE is requested and no DWARF version is specified. This patch changes the default DWARF version for cc1as from invalid 0 to 2, which should

r266937 - Module Debugging: Emit the canonical debug info for Objective-C classes

Author: adrian Date: Wed Apr 20 18:59:32 2016 New Revision: 266937 URL: http://llvm.org/viewvc/llvm-project?rev=266937&view=rev Log: Module Debugging: Emit the canonical debug info for Objective-C classes in the compile unit that contains their implementation even if their interface is declared in

[PATCH] D19443: Module Debugging: Fix the condition for determining whether a template instantiation is in a module.

aprantl created this revision. aprantl added a reviewer: doug.gregor. aprantl added a subscriber: cfe-commits. aprantl set the repository for this revision to rL LLVM. This patch fixes the condition for determining whether the debug info for a template instantiation will exist in an imported clan

r267369 - Debug info: Apply an empty debug location for global OpenMP destructors.

Author: adrian Date: Sun Apr 24 17:22:29 2016 New Revision: 267369 URL: http://llvm.org/viewvc/llvm-project?rev=267369&view=rev Log: Debug info: Apply an empty debug location for global OpenMP destructors. LLVM really wants a debug location on every inlinable call in a function with debug info, be

r267464 - Module Debugging: Fix the condition for determining whether a template

Author: adrian Date: Mon Apr 25 15:52:40 2016 New Revision: 267464 URL: http://llvm.org/viewvc/llvm-project?rev=267464&view=rev Log: Module Debugging: Fix the condition for determining whether a template instantiation is in a module. This patch fixes the condition for determining whether the debu

Re: [PATCH] D20415: Update Clang for D20147 ("DebugInfo: New metadata representation for global variables.")

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. LGTM with small changes. Comment at: lib/CodeGen/CGDebugInfo.cpp:3427 @@ -3425,3 +3426,3 @@ DContext, DeclName, LinkageName, Unit, LineNo, getOrCreateType(T, Unit)

Re: [PATCH] D20415: Update Clang for D20147 ("DebugInfo: New metadata representation for global variables.")

aprantl added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:3427 @@ -3425,3 +3426,3 @@ DContext, DeclName, LinkageName, Unit, LineNo, getOrCreateType(T, Unit), -Var->hasInternalLinkage(), Var, +Var->hasInternalLinkage(), nullptr, getOr

Re: [PATCH] D21141: [DebugInfo] Add calling conventions to DISubroutineType

aprantl added a comment. Assuming that we could usually get the calling convention from the Function — what's the motivation for emitting the calling convention of a subprogram that has been optimized away? http://reviews.llvm.org/D21141 ___ cfe-c

Re: [PATCH] D21141: [DebugInfo] Add calling conventions to DISubroutineType

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Function pointers make sense to me, thanks! LGTM Comment at: lib/CodeGen/CGDebugInfo.cpp:834 @@ -833,1 +833,3 @@ +static unsigned getDwarfCC(CallingConv CC) { + switch (C

Re: [llvm-dev] [RFC] Embedded bitcode and related upstream (Part II)

> On Jun 13, 2016, at 9:37 AM, Steven Wu wrote: > > Thanks for the feedback! Replies inline. > >> On Jun 12, 2016, at 11:44 PM, Eric Christopher > > wrote: >> >> Hi Steven, >> >> Great to see the commentary and updates here. I've got a few questions about >> some

Re: [libcxx] r273034 - Add Filesystem TS -- Complete

Hello Eric, this commit causes new warnings on our bots: clang/src/projects/libcxx/include/fstream:816:5: warning: default label in switch which covers all enumeration values [-Wcovered-switch-default] default: The problem is with this defensive default statement in fstream: template 07

r275076 - [man page] Document -gline-tables-only in the clang man page.

Author: adrian Date: Mon Jul 11 12:03:16 2016 New Revision: 275076 URL: http://llvm.org/viewvc/llvm-project?rev=275076&view=rev Log: [man page] Document -gline-tables-only in the clang man page. Modified: cfe/trunk/docs/CommandGuide/clang.rst Modified: cfe/trunk/docs/CommandGuide/clang.rst U

r275075 - [man page] Fix two sphinx build errors.

Author: adrian Date: Mon Jul 11 12:03:13 2016 New Revision: 275075 URL: http://llvm.org/viewvc/llvm-project?rev=275075&view=rev Log: [man page] Fix two sphinx build errors. These options were referenced by other paragraphs, but never specified. Modified: cfe/trunk/docs/CommandGuide/clang.rst

r275356 - Add a comment mirroring the one in LLVM's Dwarf.h

Author: adrian Date: Wed Jul 13 19:42:53 2016 New Revision: 275356 URL: http://llvm.org/viewvc/llvm-project?rev=275356&view=rev Log: Add a comment mirroring the one in LLVM's Dwarf.h Modified: cfe/trunk/include/clang/Sema/DeclSpec.h Modified: cfe/trunk/include/clang/Sema/DeclSpec.h URL: htt

Re: r256907 - [modules] When a tag type that was imported from a module is referenced via an

Hi Richard, it looks like this commit causes an assertion failure in Sema when mixing PCH and modules. The following script is the smallest reproduction I could come up with. Could you please have a look? $ cat ../repro.sh mkdir -p usr/include mkdir -p usr/include/bsm mkdir -p usr/include/netin

r262851 - Module Debugging: Fix a crash when emitting debug info for nested tag types

Author: adrian Date: Mon Mar 7 14:58:52 2016 New Revision: 262851 URL: http://llvm.org/viewvc/llvm-project?rev=262851&view=rev Log: Module Debugging: Fix a crash when emitting debug info for nested tag types whose DeclContext is not yet complete by deferring their emission. rdar://problem/249186

Re: r262851 - Module Debugging: Fix a crash when emitting debug info for nested tag types

clear to me just by > looking at it) In the ASTConsumer callback for a finished TagDecl, we check whether the DeclContext is complete and only try to emit debug info for the Decl if the DeclContext is available. -- adrian > > On Mon, Mar 7, 2016 at 12:58 PM, Adrian Prantl via

Re: r262851 - Module Debugging: Fix a crash when emitting debug info for nested tag types

ite clear to me just by > > looking at it) > > In the ASTConsumer callback for a finished TagDecl, we check whether the > DeclContext is complete and only try to emit debug info for the Decl if the > DeclContext is available. > > -- adrian > > > > > On Mon,

Re: [libcxx] r249738 - Split out of .

> On Mar 11, 2016, at 4:11 PM, Duncan P. N. Exon Smith > wrote: > > Did anyone file a PR for this? > I filed PR 26928 - Prune the include path for modules https://llvm.org/bugs/show_bug.cgi?id=26928 as a starting point. -- adrian ___ cfe-commits m

r264366 - Debug Info: Add a testcase for the bug introduced by r259975.

Author: adrian Date: Thu Mar 24 19:20:35 2016 New Revision: 264366 URL: http://llvm.org/viewvc/llvm-project?rev=264366&view=rev Log: Debug Info: Add a testcase for the bug introduced by r259975. In r259975 we rauw'ed the scope of enum declarations without taking into account that DIBuilder strips

Re: r259975 - Fix a crash when emitting dbeug info for forward-declared scoped enums.

the testcase), I just would like to understand what’s > > going on. > > > > > > I am a bit. I don't have a reduction at the moment small enough to debug > > what's wrong with this and the current patch doesn't appear necessary so > > I'm un

Re: r252960 - [modules] Simplify and generalize the existing rule for finding hidden

> On Dec 16, 2015, at 5:19 PM, Bob Wilson via cfe-commits > wrote: > >> >> On Nov 12, 2015, at 2:19 PM, Richard Smith via cfe-commits >> wrote: >> >> Author: rsmith >> Date: Thu Nov 12 16:19:45 2015 >> New Revision: 252960 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=252960&view=rev

r256874 - Fix a typo in testcase and increase its coverage!

Author: adrian Date: Tue Jan 5 17:54:01 2016 New Revision: 256874 URL: http://llvm.org/viewvc/llvm-project?rev=256874&view=rev Log: Fix a typo in testcase and increase its coverage! Modified: cfe/trunk/test/Modules/ModuleDebugInfo.cpp Modified: cfe/trunk/test/Modules/ModuleDebugInfo.cpp URL

r256962 - Module debugging: Defer emitting tag types until their definition

Author: adrian Date: Wed Jan 6 13:22:19 2016 New Revision: 256962 URL: http://llvm.org/viewvc/llvm-project?rev=256962&view=rev Log: Module debugging: Defer emitting tag types until their definition was visited and all decls have been merged. We only get a single chance to emit the types for virt

r256963 - Fix a typo.

Author: adrian Date: Wed Jan 6 13:22:23 2016 New Revision: 256963 URL: http://llvm.org/viewvc/llvm-project?rev=256963&view=rev Log: Fix a typo. Modified: cfe/trunk/test/Modules/Inputs/DebugCXX.h Modified: cfe/trunk/test/Modules/Inputs/DebugCXX.h URL: http://llvm.org/viewvc/llvm-project/cfe

Re: r252960 - [modules] Simplify and generalize the existing rule for finding hidden

> On Jan 5, 2016, at 6:56 PM, Richard Smith wrote: > > On Tue, Jan 5, 2016 at 1:32 PM, Adrian Prantl via cfe-commits > mailto:cfe-commits@lists.llvm.org>> wrote: > > On Dec 16, 2015, at 5:19 PM, Bob Wilson via cfe-commits > > mailto:cfe-commits@lists.llvm.org>

Re: r256979 - Fix half of PR26048. We don't yet diagnose the case where the anonymous union member is declared first and the tag name is declared second.

> On Jan 6, 2016, at 1:54 PM, Richard Smith via cfe-commits > wrote: > > Author: rsmith > Date: Wed Jan 6 15:54:29 2016 > New Revision: 256979 > > URL: http://llvm.org/viewvc/llvm-project?rev=256979&view=rev > Log: > Fix half of PR26048. We don't yet diagnose the case where the anonymous unio

Re: r256287 - Document that we recommend to turn off -gmodules when building a static

d/broken/etc anyway) Why would explicit modules be any different? Unless you distribute the modules together with the static library (and ensure they end up in the same location on the other machine) you would still run into the problem, wouldn’t you? -- adrian > > On Tue, Dec 22, 201

Re: r256962 - Module debugging: Defer emitting tag types until their definition

> On Jan 8, 2016, at 1:31 PM, David Blaikie wrote: > > > > On Wed, Jan 6, 2016 at 11:22 AM, Adrian Prantl via cfe-commits > mailto:cfe-commits@lists.llvm.org>> wrote: > Author: adrian > Date: Wed Jan 6 13:22:19 2016 > New Revision: 256962 > > URL:

Re: r256962 - Module debugging: Defer emitting tag types until their definition

> On Jan 8, 2016, at 1:59 PM, David Blaikie wrote: > > > > On Fri, Jan 8, 2016 at 1:34 PM, Adrian Prantl <mailto:apra...@apple.com>> wrote: > >> On Jan 8, 2016, at 1:31 PM, David Blaikie > <mailto:dblai...@gmail.com>> wrote: >> >>

Re: r252114 - [modules] If we're given a module file, via -fmodule-file=, for a module, but

Hi Richard, This change > @@ -2239,16 +2240,21 @@ ASTReader::ReadControlBlock(ModuleFile &F, [...] > - if (!DisableValidation && Result != Success && > - (Result != ConfigurationMismatch || > !AllowConfigurationMismatch)) > + if (DisableValidation || > +

Re: r252114 - [modules] If we're given a module file, via -fmodule-file=, for a module, but

> On Jan 8, 2016, at 2:39 PM, Adrian Prantl wrote: > > Hi Richard, > > This change >> @@ -2239,16 +2240,21 @@ ASTReader::ReadControlBlock(ModuleFile &F, > [...] >> - if (!DisableValidation && Result != Success && >> - (Result != ConfigurationMismatch || >> !AllowConfigur

r257241 - Module debugging: Add a testcase for standalone forward declarations.

Author: adrian Date: Fri Jan 8 19:11:35 2016 New Revision: 257241 URL: http://llvm.org/viewvc/llvm-project?rev=257241&view=rev Log: Module debugging: Add a testcase for standalone forward declarations. Modified: cfe/trunk/test/Modules/Inputs/DebugCXX.h cfe/trunk/test/Modules/ModuleDebugI

Re: r256962 - Module debugging: Defer emitting tag types until their definition

> On Jan 8, 2016, at 2:18 PM, Adrian Prantl via cfe-commits > wrote: > >> >> On Jan 8, 2016, at 1:59 PM, David Blaikie wrote: >> >> >> >> On Fri, Jan 8, 2016 at 1:34 PM, Adrian Prantl wrote: >> >>> On Jan 8, 2016, at 1:31 PM,

r257520 - Module debugging: Make the module format part of the module hash instead

Author: adrian Date: Tue Jan 12 15:01:56 2016 New Revision: 257520 URL: http://llvm.org/viewvc/llvm-project?rev=257520&view=rev Log: Module debugging: Make the module format part of the module hash instead of the file name. This is consistent with how other HeaderSearchOptions are handled. Due to

Re: [PATCH] D16135: Macro Debug Info support in Clang

aprantl added a comment. Added a few stylistic comments and request for more documentation. Comment at: lib/CodeGen/MacroPPCallbacks.cpp:1 @@ +1,2 @@ +//===--- MacroPPCallbacks.h ---*- C++ -*-===// +// Please run your patch t

r258152 - Module Debugging: Defer the emission of anonymous tag decls

Author: adrian Date: Tue Jan 19 12:02:47 2016 New Revision: 258152 URL: http://llvm.org/viewvc/llvm-project?rev=258152&view=rev Log: Module Debugging: Defer the emission of anonymous tag decls until we are visiting their declcontext. This fixes a regression introduced in r256962: When building de

Re: [PATCH] D8822: Proposed fix for PR23076 (conditional branch debug line info)

aprantl added a subscriber: aprantl. aprantl added a comment. Reposting dblaikie's example hoping that phabricator doesn't mangle it this time: 1: int main() { 2: if ( 3: tr() 4: && 5: tr() 6: ) 7: func(); 8: if ( 9: fa() 10: && 11: tr() 12: ) 13: func(); 14:

r258251 - Module Debugging: Don't emit external type references to anonymous types.

Author: adrian Date: Tue Jan 19 17:42:53 2016 New Revision: 258251 URL: http://llvm.org/viewvc/llvm-project?rev=258251&view=rev Log: Module Debugging: Don't emit external type references to anonymous types. Even if they exist in the module, they can't be matched with the forward declaration in the

r258252 - Module Debugging: Add Objective-C testcases for anonymous tag decls. (NFC)

Author: adrian Date: Tue Jan 19 17:42:56 2016 New Revision: 258252 URL: http://llvm.org/viewvc/llvm-project?rev=258252&view=rev Log: Module Debugging: Add Objective-C testcases for anonymous tag decls. (NFC) rdar://problem/24199640 Modified: cfe/trunk/test/Modules/ExtDebugInfo.m cfe/trun

r258250 - Module Debugging: Make sure that anonymous tag decls that define global

Author: adrian Date: Tue Jan 19 17:42:44 2016 New Revision: 258250 URL: http://llvm.org/viewvc/llvm-project?rev=258250&view=rev Log: Module Debugging: Make sure that anonymous tag decls that define global variables are visited. This shouldn't encourage anyone to put global variables into clang mo

Re: r258251 - Module Debugging: Don't emit external type references to anonymous types.

> On Jan 19, 2016, at 3:52 PM, David Blaikie wrote: > > > > On Tue, Jan 19, 2016 at 3:42 PM, Adrian Prantl via cfe-commits > mailto:cfe-commits@lists.llvm.org>> wrote: > Author: adrian > Date: Tue Jan 19 17:42:53 2016 > New Revision: 258251 > > URL:

r258272 - Module Debugging: Fine-tune the condition that determines whether a type

Author: adrian Date: Tue Jan 19 19:29:34 2016 New Revision: 258272 URL: http://llvm.org/viewvc/llvm-project?rev=258272&view=rev Log: Module Debugging: Fine-tune the condition that determines whether a type can be found in a module. There are externally visible anonymous types that can be found:

Re: r258251 - Module Debugging: Don't emit external type references to anonymous types.

> On Jan 19, 2016, at 4:23 PM, David Blaikie wrote: > > > > On Tue, Jan 19, 2016 at 4:04 PM, Adrian Prantl wrote: > >> On Jan 19, 2016, at 3:52 PM, David Blaikie wrote: >> >> >> >> On Tue, Jan 19, 2016 at 3:42 PM, Adrian Prantl via cfe-co

r258507 - Module Debugging: Use a nonzero DWO id for precompiled headers.

Author: adrian Date: Fri Jan 22 11:43:43 2016 New Revision: 258507 URL: http://llvm.org/viewvc/llvm-project?rev=258507&view=rev Log: Module Debugging: Use a nonzero DWO id for precompiled headers. PCH files don't have a module signature and LLVM uses a nonzero DWO id as an indicator for skeleton /

Re: r258507 - Module Debugging: Use a nonzero DWO id for precompiled headers.

> On Jan 22, 2016, at 9:50 AM, David Blaikie wrote: > > > > On Fri, Jan 22, 2016 at 9:43 AM, Adrian Prantl via cfe-commits > mailto:cfe-commits@lists.llvm.org>> wrote: > Author: adrian > Date: Fri Jan 22 11:43:43 2016 > New Revision: 258507 > > URL:

r258519 - Fix a typo in r258507 and change the PCH dwoid constant to ~1UL.

Author: adrian Date: Fri Jan 22 12:46:45 2016 New Revision: 258519 URL: http://llvm.org/viewvc/llvm-project?rev=258519&view=rev Log: Fix a typo in r258507 and change the PCH dwoid constant to ~1UL. rdar://problem/24290667 Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp cfe/trunk/lib/Code

r258518 - Fix 80-column violations.

Author: adrian Date: Fri Jan 22 12:46:40 2016 New Revision: 258518 URL: http://llvm.org/viewvc/llvm-project?rev=258518&view=rev Log: Fix 80-column violations. Modified: cfe/trunk/test/Modules/ExtDebugInfo.cpp Modified: cfe/trunk/test/Modules/ExtDebugInfo.cpp URL: http://llvm.org/viewvc/llvm

r258526 - Rephrase this test to help debug a buildbot issue

Author: adrian Date: Fri Jan 22 13:14:24 2016 New Revision: 258526 URL: http://llvm.org/viewvc/llvm-project?rev=258526&view=rev Log: Rephrase this test to help debug a buildbot issue Modified: cfe/trunk/test/Modules/ExtDebugInfo.cpp Modified: cfe/trunk/test/Modules/ExtDebugInfo.cpp URL: htt

r258531 - Fix the build by using the correct suffix for 64 bit literals

Author: adrian Date: Fri Jan 22 13:29:41 2016 New Revision: 258531 URL: http://llvm.org/viewvc/llvm-project?rev=258531&view=rev Log: Fix the build by using the correct suffix for 64 bit literals Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp cfe/trunk/lib/CodeGen/ObjectFilePCHContainerOp

r258555 - Module debugging: Create a parent DIModule with the PCH name for types

Author: adrian Date: Fri Jan 22 15:14:41 2016 New Revision: 258555 URL: http://llvm.org/viewvc/llvm-project?rev=258555&view=rev Log: Module debugging: Create a parent DIModule with the PCH name for types emitted into a precompiled header to mirror the debug info emitted for object files importing

r258582 - Module Debugging: Canonicalize the file names used as PCH module names

Author: adrian Date: Fri Jan 22 17:30:56 2016 New Revision: 258582 URL: http://llvm.org/viewvc/llvm-project?rev=258582&view=rev Log: Module Debugging: Canonicalize the file names used as PCH module names by stripping the path. Follow-up to r258555. This is safe because only one PCH per CU is curr

Re: [PATCH] D8822: Proposed fix for PR23076 (conditional branch debug line info)

aprantl added a comment. The linetable produced by GCC appears to be the most accurate one (stopping at the && for the short-circuit evaluation and then returning there for the actual & and the branch). I would not have a problem with clang implementing it. The downside of it is that it breaks t

Re: [PATCH] D16697: Updating .debug_line section version information to match DWARF version.

> On Jan 28, 2016, at 4:57 PM, David Blaikie wrote: > > +Adrian for Apple/LLDB perspective > > One way to merge the tests would be to add another command line argument into > DwarfDebug (see the way the split-dwarf command line argument is used), just > for testing purposes. The command line

Re: [PATCH] D16697: Updating .debug_line section version information to match DWARF version.

> > There is now a public bot that runs the LLDB testsuite on Darwin > (http://lab.llvm.org:8080/green/job/LLDB/) so you’ll find out immediately :-) > LLDB can be fixed, I’m not too worried about it. > > There are, however, also DWARF consumers that are not debuggers that will > read the line t

r254451 - Add an accessor to Decl::LoadedFieldsFromExternalStorage for LLDB.

Author: adrian Date: Tue Dec 1 13:54:07 2015 New Revision: 254451 URL: http://llvm.org/viewvc/llvm-project?rev=254451&view=rev Log: Add an accessor to Decl::LoadedFieldsFromExternalStorage for LLDB. Patch by Greg Clayton Reviewed by Doug Gregor Modified: cfe/trunk/include/clang/AST/Decl.h

r254455 - Clang-format an 80-column violation.

Author: adrian Date: Tue Dec 1 14:19:44 2015 New Revision: 254455 URL: http://llvm.org/viewvc/llvm-project?rev=254455&view=rev Log: Clang-format an 80-column violation. Modified: cfe/trunk/include/clang/AST/Decl.h Modified: cfe/trunk/include/clang/AST/Decl.h URL: http://llvm.org/viewvc/llv

<    1   2   3   4   5   6   >