aprantl added inline comments.

================
Comment at: lib/CodeGen/CGDebugInfo.cpp:3393
@@ +3392,3 @@
+        DContext, FieldName, LinkageName, Unit, LineNo, FieldTy,
+        Var->hasInternalLinkage(), nullptr, nullptr);
+    Var->addDebugInfo(GV);
----------------
aprantl wrote:
> Is there a good reason for not changing the DIBuilder interface to drop the 
> global field?
Sorry about the confusion, I should have read the other patch first. This has 
morphed into the DIExpression. That's fine!


http://reviews.llvm.org/D20415



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to