r248101 - Further simplify the interface of PCHContainerGenerator

Author: adrian Date: Sat Sep 19 16:42:52 2015 New Revision: 248101 URL: http://llvm.org/viewvc/llvm-project?rev=248101&view=rev Log: Further simplify the interface of PCHContainerGenerator by dropping the const qualifier on the CI. NFC Modified: cfe/trunk/include/clang/CodeGen/ObjectFilePCHC

r248127 - Module debugging: Support submodules in the PCM/PCH debug info.

Author: adrian Date: Sun Sep 20 11:51:35 2015 New Revision: 248127 URL: http://llvm.org/viewvc/llvm-project?rev=248127&view=rev Log: Module debugging: Support submodules in the PCM/PCH debug info. Added: cfe/trunk/test/Modules/DebugInfoSubmodules.c cfe/trunk/test/Modules/Inputs/DebugSubmo

Re: r248142 - clang/test/Modules/DebugInfoSubmodules.c REQUIRES asserts due to -debug-only.

Thanks for fixing this! -- adrian > On Sep 20, 2015, at 11:57 PM, NAKAMURA Takumi via cfe-commits > wrote: > > Author: chapuni > Date: Mon Sep 21 01:57:36 2015 > New Revision: 248142 > > URL: http://llvm.org/viewvc/llvm-project?rev=248142&view=rev > Log: > clang/test/Modules/DebugInfoSubmodule

r248184 - Debug Info: When building a module, emit skeleton CUs for imported modules.

Author: adrian Date: Mon Sep 21 12:48:37 2015 New Revision: 248184 URL: http://llvm.org/viewvc/llvm-project?rev=248184&view=rev Log: Debug Info: When building a module, emit skeleton CUs for imported modules. Added: cfe/trunk/test/Modules/DebugInfoTransitiveImport.m Modified: cfe/trunk/li

r248185 - Add a belated testcase for the skeleton CU behavior in r248062.

Author: adrian Date: Mon Sep 21 12:48:42 2015 New Revision: 248185 URL: http://llvm.org/viewvc/llvm-project?rev=248185&view=rev Log: Add a belated testcase for the skeleton CU behavior in r248062. Modified: cfe/trunk/test/Modules/debug-info-moduleimport.m Modified: cfe/trunk/test/Modules/deb

Re: r248184 - Debug Info: When building a module, emit skeleton CUs for imported modules.

> On Sep 21, 2015, at 10:59 AM, David Blaikie wrote: > > > > On Mon, Sep 21, 2015 at 10:48 AM, Adrian Prantl via cfe-commits > mailto:cfe-commits@lists.llvm.org>> wrote: > Author: adrian > Date: Mon Sep 21 12:48:37 2015 > New Revision: 248184 > > URL:

Re: r248184 - Debug Info: When building a module, emit skeleton CUs for imported modules.

>> >> >> On Mon, Sep 21, 2015 at 10:48 AM, Adrian Prantl via cfe-commits >> mailto:cfe-commits@lists.llvm.org>> wrote: >> Author: adrian >> Date: Mon Sep 21 12:48:37 2015 >> New Revision: 248184 >> >> URL: http://llvm.org/viewvc/llvm-projec

r248345 - Module Debugging: Use the clang module signature as the module's dwo_id

Author: adrian Date: Tue Sep 22 18:26:43 2015 New Revision: 248345 URL: http://llvm.org/viewvc/llvm-project?rev=248345&view=rev Log: Module Debugging: Use the clang module signature as the module's dwo_id when building a module. Clang already records the module signature when building a skeleton C

r248344 - Serialization: Let ASTWriter return the signature of the written module.

Author: adrian Date: Tue Sep 22 18:26:31 2015 New Revision: 248344 URL: http://llvm.org/viewvc/llvm-project?rev=248344&view=rev Log: Serialization: Let ASTWriter return the signature of the written module. NFC Modified: cfe/trunk/include/clang/Serialization/ASTWriter.h cfe/trunk/lib/Seri

r248509 - Refactor ASTSourceDescriptor to not store copies of all strings. (NFC)

Author: adrian Date: Thu Sep 24 11:10:00 2015 New Revision: 248509 URL: http://llvm.org/viewvc/llvm-project?rev=248509&view=rev Log: Refactor ASTSourceDescriptor to not store copies of all strings. (NFC) Modified: cfe/trunk/include/clang/AST/ExternalASTSource.h cfe/trunk/lib/AST/ExternalA

r248510 - Debug Info: Use the module pointer as key for the module cache.

Author: adrian Date: Thu Sep 24 11:10:04 2015 New Revision: 248510 URL: http://llvm.org/viewvc/llvm-project?rev=248510&view=rev Log: Debug Info: Use the module pointer as key for the module cache. This way we don't need to rebuild the full module name for every decl. Modified: cfe/trunk/inclu

r248511 - Module Debugging: Emit submodules as nested DW_TAG_modules.

Author: adrian Date: Thu Sep 24 11:10:10 2015 New Revision: 248511 URL: http://llvm.org/viewvc/llvm-project?rev=248511&view=rev Log: Module Debugging: Emit submodules as nested DW_TAG_modules. Added: cfe/trunk/test/Modules/DebugInfoSubmoduleImport.c Modified: cfe/trunk/include/clang/AST/E

Re: r241035 - Pass HeaderSearchOptions and PreprocessorOptions into CodeGenModule.

Thanks, Eric! Should be fixed in r248762. -- adrian > On Sep 28, 2015, at 4:40 PM, Eric Christopher wrote: > > Actually using the right list now... > > On Mon, Sep 28, 2015 at 4:39 PM Eric Christopher wrote: > Hi Adrian, > > >: CGO(new CodeGenOptions), > -CGM(new CodeGen::CodeGenMo

r248762 - Unique-pointerify these pointers an plug a memory leak.

Author: adrian Date: Mon Sep 28 18:56:10 2015 New Revision: 248762 URL: http://llvm.org/viewvc/llvm-project?rev=248762&view=rev Log: Unique-pointerify these pointers an plug a memory leak. Thanks to echristo for noticing! Modified: cfe/trunk/include/clang/CodeGen/CodeGenABITypes.h cfe/tru

r248826 - CGDebugInfo: Don't reuse a reference into a DenseMap if the DenseMap may

Author: adrian Date: Tue Sep 29 15:44:46 2015 New Revision: 248826 URL: http://llvm.org/viewvc/llvm-project?rev=248826&view=rev Log: CGDebugInfo: Don't reuse a reference into a DenseMap if the DenseMap may be modified in between. (NFC) Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp Modified

Re: r248826 - CGDebugInfo: Don't reuse a reference into a DenseMap if the DenseMap may

> On Sep 29, 2015, at 3:52 PM, David Blaikie wrote: > > > > On Tue, Sep 29, 2015 at 1:44 PM, Adrian Prantl via cfe-commits > mailto:cfe-commits@lists.llvm.org>> wrote: > Author: adrian > Date: Tue Sep 29 15:44:46 2015 > New Revision: 248826 > > URL:

r248974 - Module debugging: Emit Objective-C interfaces in their module scope when

Author: adrian Date: Wed Sep 30 19:48:51 2015 New Revision: 248974 URL: http://llvm.org/viewvc/llvm-project?rev=248974&view=rev Log: Module debugging: Emit Objective-C interfaces in their module scope when building a clang module. Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp cfe/trunk/

r249031 - Module debugging: Also emit Objective-C interfaces forward declarations

Author: adrian Date: Thu Oct 1 11:57:02 2015 New Revision: 249031 URL: http://llvm.org/viewvc/llvm-project?rev=249031&view=rev Log: Module debugging: Also emit Objective-C interfaces forward declarations in their module scope when building a clang module. Modified: cfe/trunk/lib/CodeGen/CGDe

r249156 - Break long lines for readability.

Author: adrian Date: Fri Oct 2 12:36:10 2015 New Revision: 249156 URL: http://llvm.org/viewvc/llvm-project?rev=249156&view=rev Log: Break long lines for readability. Modified: cfe/trunk/test/Modules/ModuleDebugInfo.m Modified: cfe/trunk/test/Modules/ModuleDebugInfo.m URL: http://llvm.org/v

r249155 - Remove unused variable.

Author: adrian Date: Fri Oct 2 12:36:03 2015 New Revision: 249155 URL: http://llvm.org/viewvc/llvm-project?rev=249155&view=rev Log: Remove unused variable. Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp URL: http://llvm.org/viewvc/llvm-proje

r249157 - Module debugging: Don't emit forward declarations in module scopes.

Author: adrian Date: Fri Oct 2 12:36:14 2015 New Revision: 249157 URL: http://llvm.org/viewvc/llvm-project?rev=249157&view=rev Log: Module debugging: Don't emit forward declarations in module scopes. A forward declaration inside a module header does not belong to the module. Modified: cfe/tr

Re: r249157 - Module debugging: Don't emit forward declarations in module scopes.

laration would end up in a DeclContext that is not the DeclContext of the definition. Looking at this through the dsymutil goggles, the different DeclContexts effectively prevent the forward declaration from being uniqued with the type's definition. -- adrian > On Fri, Oct 2, 2015 at 1

Re: r249157 - Module debugging: Don't emit forward declarations in module scopes.

”? The CU is not part of the DeclContext (for dsymutil’s interpretation of a DeclContext). Otherwise cross-CU type uniquing would never work. -- adrian > > > -- adrian > >> On Fri, Oct 2, 2015 at 10:36 AM, Adrian Prantl via cfe-commits >> mailto:cfe-commits@lists.llv

Re: r249157 - Module debugging: Don't emit forward declarations in module scopes.

to be, for correctness. (None of this applies to C++. Oversimplified: because of the ODR we can omit the parent DW_TAG_module from all CXXRecordDecls). For C and ObjC it is perfectly legal to have two modules with conflicting definitions for a type, so we need the DW_TAG_module as part of

Re: [libcxx] r249226 - [libcxx] Use newest supported language dialect when running the test suite.

Hello Eric, it looks like this patch broke the lab.llvm.org buildbots (darwin+cmake): http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA_check/7544/consoleFull#2729576478254eaf0-7326-4999-85b0-388101f2d404 could you please investigate and/or revert the change? thanks, Adrian > On Oct 2,

Re: [libcxx] r249226 - [libcxx] Use newest supported language dialect when running the test suite.

> On Oct 3, 2015, at 4:33 PM, Eric Fiselier wrote: > > Hi Adrian, > > So the goal of this patch was to increase the coverage of the test > suite by default. > Previously we used C++11 as the default but this meant that new C++14 > and C++1z tests > were never run. The failures you are seeing a

r249282 - Module Debugging: Emit (ObjC) function declarations in the module scope

Author: adrian Date: Sun Oct 4 18:23:04 2015 New Revision: 249282 URL: http://llvm.org/viewvc/llvm-project?rev=249282&view=rev Log: Module Debugging: Emit (ObjC) function declarations in the module scope when building a module. Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp cfe/trunk/te

Re: [PATCH] D13221: Make CompilerInvocation's use of the debug options more understandable.

aprantl added a comment. Some bikeshedding about -di-kind={full|limited|line-tables}: 1. Is there a good reason not to spell out -debug-info-kind? 2. "full" is misleading as it will still only emit debug info for types actually used by the program. I think "standalone" would be more descriptive.

Re: r249157 - Module debugging: Don't emit forward declarations in module scopes.

a specific type. The one thing that I don’t like about emitting “real" forward declarations into the DW_TAG_module is that they are indistinguishable from the forward declarations that are emitted for external type references, for which there is an actual definition in the module itself. This is more of an a

r249328 - Undo the unique_ptr'fication of CodeGenABITypes::CGM introduced in r248762.

Author: adrian Date: Mon Oct 5 12:41:16 2015 New Revision: 249328 URL: http://llvm.org/viewvc/llvm-project?rev=249328&view=rev Log: Undo the unique_ptr'fication of CodeGenABITypes::CGM introduced in r248762. include/clang/CodeGenABITypes.h is in meant to be included by external users, but using a

r249336 - Re-introduce the unique_ptr removed in r249328 and just make

Author: adrian Date: Mon Oct 5 13:54:30 2015 New Revision: 249336 URL: http://llvm.org/viewvc/llvm-project?rev=249336&view=rev Log: Re-introduce the unique_ptr removed in r249328 and just make ~CodeGenABITypes out-of-line, which should have the same effect. Thanks to David Blaikie for pointing t

Re: [PATCH] D13445: [libcxx] Reexport std::bad_array_length symbols from libc++abi on OS X.

aprantl accepted this revision. aprantl added a reviewer: aprantl. aprantl added a comment. This revision is now accepted and ready to land. Grepping through the nm output of libc++abi it looks like bad_array_length is included in Xcode 7 and Xcode 6.4, which is also what is installed on the lab

Re: [libcxx] r249226 - [libcxx] Use newest supported language dialect when running the test suite.

Thanks for looking into this, the builder is green again! http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA_check/7586/ -- adrian ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] Have clang list the imported modules in the debug info

[resending because I accidentally sent this to the old mailing list]. > On Jul 24, 2015, at 12:33 PM, David Blaikie > wrote: > > *reads back through the thread* appreciated, it’s long :-) > So what I originally had in mind about a year ago when we discussed this, was

[PATCH] D11958: Add a -gmodules option to the clang driver.

aprantl created this revision. aprantl added reviewers: dblaikie, echristo. aprantl added a subscriber: cfe-commits. aprantl set the repository for this revision to rL LLVM. This patch adds a -gmodules option to the driver and a -dwarf-ext-refs to cc1 to enable the use of external type references

Re: [PATCH] Have clang list the imported modules in the debug info

(ping.) > On Aug 10, 2015, at 5:03 PM, Adrian Prantl wrote: > > [resending because I accidentally sent this to the old mailing list]. > >> On Jul 24, 2015, at 12:33 PM, David Blaikie > > wrote: >> >> *reads back through the thread* > > appreciated, it’s long :-) >

Re: [PATCH] D11958: Add a -gmodules option to the clang driver.

aprantl added a comment. Ping. Repository: rL LLVM http://reviews.llvm.org/D11958 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D11958: Add a -gmodules option to the clang driver.

> On Aug 19, 2015, at 1:12 PM, David Blaikie wrote: > > > > On Tue, Aug 11, 2015 at 1:49 PM, Adrian Prantl > wrote: > aprantl created this revision. > aprantl added reviewers: dblaikie, echristo. > aprantl added a subscriber: cfe-commits. > aprantl set the repository

Re: [PATCH] D11958: Add a -gmodules option to the clang driver.

> On Aug 19, 2015, at 2:15 PM, Richard Smith wrote: > > rsmith added a subscriber: rsmith. > > > Comment at: include/clang/Frontend/CodeGenOptions.def:164-165 > @@ -163,1 +163,4 @@ > > +CODEGENOPT(DebugTypeExtRefs, 1, 0) ///< Whether or not debug info should > contain > +

Re: [PATCH] D11958: Add a -gmodules option to the clang driver.

aprantl added a comment. Maybe this is missing the point, but a hash collision between module files with different formats should be highly unlikely because we add the module format into the hash. llvm::hash_code Hash = llvm::hash_combine(DirName.lower(), FileName.lower(),

Re: [PATCH] D11958: Add a -gmodules option to the clang driver.

aprantl added inline comments. Comment at: include/clang/Frontend/CodeGenOptions.def:164-165 @@ -163,1 +163,4 @@ +CODEGENOPT(DebugTypeExtRefs, 1, 0) ///< Whether or not debug info should contain + ///< external references to a PCH or module. +

Re: [PATCH] D11958: Add a -gmodules option to the clang driver.

aprantl added a comment. Alright, let's hash it, then. Repository: rL LLVM http://reviews.llvm.org/D11958 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] Have clang list the imported modules in the debug info

> On Aug 19, 2015, at 1:20 PM, David Blaikie wrote: > > > > On Mon, Aug 10, 2015 at 5:00 PM, Adrian Prantl > wrote: > >> On Jul 24, 2015, at 12:33 PM, David Blaikie > > wrote: >> >> *reads back through the thread* > > appreciated, it’s l

Re: [PATCH] Have clang list the imported modules in the debug info

> On Aug 24, 2015, at 2:01 PM, David Blaikie wrote: > > > > On Mon, Aug 24, 2015 at 1:23 PM, Adrian Prantl > wrote: > >> On Aug 19, 2015, at 1:20 PM, David Blaikie > > wrote: >> >> >> >> On Mon, Aug 10, 2015 at 5:00 PM, Adrian Prantl >

Re: [PATCH] Have clang list the imported modules in the debug info

> On Aug 24, 2015, at 4:17 PM, David Blaikie wrote: > > > > On Mon, Aug 24, 2015 at 3:34 PM, Adrian Prantl > wrote: > >> On Aug 24, 2015, at 2:01 PM, David Blaikie > > wrote: >> >> >> >> On Mon, Aug 24, 2015 at 1:23 PM, Adrian Prantl >

r246192 - Add a -gmodules option to the driver and a -dwarf-ext-refs to cc1

Author: adrian Date: Thu Aug 27 14:46:20 2015 New Revision: 246192 URL: http://llvm.org/viewvc/llvm-project?rev=246192&view=rev Log: Add a -gmodules option to the driver and a -dwarf-ext-refs to cc1 to enable the use of external type references in the debug info (a.k.a. module debugging). The dri

r246210 - CGDebugInfo: Factor out a getOrCreateStandaloneType() method.

Author: adrian Date: Thu Aug 27 16:21:19 2015 New Revision: 246210 URL: http://llvm.org/viewvc/llvm-project?rev=246210&view=rev Log: CGDebugInfo: Factor out a getOrCreateStandaloneType() method. Usually debug info is created on the fly while during codegen. With this API it becomes possible to cr

Re: r246210 - CGDebugInfo: Factor out a getOrCreateStandaloneType() method.

> On Aug 27, 2015, at 2:25 PM, David Blaikie wrote: > > > > On Thu, Aug 27, 2015 at 2:21 PM, Adrian Prantl via cfe-commits > mailto:cfe-commits@lists.llvm.org>> wrote: > Author: adrian > Date: Thu Aug 27 16:21:19 2015 > New Revision: 246210 > > URL:

r246231 - CGDebugInfo: Instead of uniquing RetainedTypes, just refrain from retaining

Author: adrian Date: Thu Aug 27 17:56:46 2015 New Revision: 246231 URL: http://llvm.org/viewvc/llvm-project?rev=246231&view=rev Log: CGDebugInfo: Instead of uniquing RetainedTypes, just refrain from retaining them more than once. (NFC) Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp Modified

Re: r246210 - CGDebugInfo: Factor out a getOrCreateStandaloneType() method.

t; >> >> On Thu, Aug 27, 2015 at 2:21 PM, Adrian Prantl via cfe-commits >> mailto:cfe-commits@lists.llvm.org>> wrote: >> Author: adrian >> Date: Thu Aug 27 16:21:19 2015 >> New Revision: 246210 >> >> URL: http://llvm.org/viewvc/llvm-project?re

Re: [libcxx] r249738 - Split out of .

Hi Richard, this commit appears to break the module self-host on Darwin. When compiling the following program generated by clang’s own cmake script: > #undef NDEBUG > #include > #define NDEBUG > #include > int main() { assert(this code is not compiled); } with clang++ -std=c++11 -fmodules -fc

Re: [libcxx] r249738 - Split out of .

To make it easier to find and investigate issues like this, I set up an experimental bot on the Green Dragon Jenkins installation on lab.llvm.org that builds a stage2 on Darwin with LLVM_ENABLE_MODULES: http://lab.llvm.org:8080/green/job/clang-stage2-cmake-modulesRDA/ I’ve configured it to du

Re: [libcxx] r249738 - Split out of .

PM, Sean Silva <mailto:chisophu...@gmail.com>> wrote: > On Tue, Oct 13, 2015 at 3:17 PM, Richard Smith via cfe-commits > mailto:cfe-commits@lists.llvm.org>> wrote: > On Tue, Oct 13, 2015 at 2:10 PM, Adrian Prantl via cfe-commits > mailto:cfe-commits@lists.llvm.org>>

Re: [libcxx] r249738 - Split out of .

> On Oct 14, 2015, at 11:37 AM, Adrian Prantl via cfe-commits > wrote: > >> >> On Oct 13, 2015, at 7:43 PM, Richard Smith > <mailto:rich...@metafoo.co.uk>> wrote: >> >> On Tue, Oct 13, 2015 at 6:54 PM, Sean Silva > <mailto:chisophu...@gm

Re: [libcxx] r249738 - Split out of .

> On Oct 14, 2015, at 3:32 PM, Richard Smith wrote: > > On Wed, Oct 14, 2015 at 2:03 PM, Adrian Prantl via cfe-commits > mailto:cfe-commits@lists.llvm.org>> wrote: >> On Oct 14, 2015, at 11:37 AM, Adrian Prantl via cfe-commits >> mailto:cfe-commits@lists.llvm.or

Re: [libcxx] r249738 - Split out of .

> On Oct 14, 2015, at 5:07 PM, Richard Smith wrote: > > On Wed, Oct 14, 2015 at 3:58 PM, Adrian Prantl via cfe-commits > mailto:cfe-commits@lists.llvm.org>> wrote: >> On Oct 14, 2015, at 3:32 PM, Richard Smith > <mailto:rich...@metafoo.co.uk>> wrote: &g

Re: r250418 - [CodeGen] Remove dead code. NFC.

> On Oct 15, 2015, at 8:29 AM, Benjamin Kramer via cfe-commits > wrote: > > Author: d0k > Date: Thu Oct 15 10:29:40 2015 > New Revision: 250418 > > URL: http://llvm.org/viewvc/llvm-project?rev=250418&view=rev > Log: > [CodeGen] Remove dead code. NFC. > > Modified: >cfe/trunk/lib/CodeGen/C

Re: [libcxx] r249738 - Split out of .

On Oct 14, 2015, at 5:07 PM, Richard Smith wrote:Ack, there are non-modular headers in the Darwin module. =( I seem to recall that they're not version-locked to your compiler, so we've got to support them as-is?If we can't turn on local submodule visibility, then we need a m

Re: [libcxx] r249738 - Split out of .

> On Oct 15, 2015, at 1:42 PM, Richard Smith wrote: > > On Thu, Oct 15, 2015 at 11:14 AM, Adrian Prantl > wrote: > >> On Oct 14, 2015, at 5:07 PM, Richard Smith > > wrote: >> >> Ack, there are non-modular headers in the Darwin module. =(

Re: [libcxx] r249738 - Split out of .

> On Oct 15, 2015, at 2:09 PM, Adrian Prantl via cfe-commits > wrote: > >> >> On Oct 15, 2015, at 1:42 PM, Richard Smith > <mailto:rich...@metafoo.co.uk>> wrote: >> >> On Thu, Oct 15, 2015 at 11:14 AM, Adrian Prantl > <mailto:apra...@app

Re: [libcxx] r249738 - Split out of .

> On Oct 15, 2015, at 2:51 PM, Alex Rosenberg wrote: > > On Oct 15, 2015, at 2:20 PM, Adrian Prantl via cfe-commits > mailto:cfe-commits@lists.llvm.org>> wrote: > >>> >>> On Oct 15, 2015, at 2:09 PM, Adrian Prantl via cfe-commits >&g

Re: [libcxx] r249738 - Split out of .

> On Oct 16, 2015, at 3:27 PM, Richard Smith wrote: > > On Thu, Oct 15, 2015 at 11:14 AM, Adrian Prantl > wrote: > >> On Oct 14, 2015, at 5:07 PM, Richard Smith > > wrote: >> >> Ack, there are non-modular headers in the Darwin module. =(

Re: [libcxx] r249738 - Split out of .

> On Oct 16, 2015, at 5:13 PM, Richard Smith wrote: > > On Fri, Oct 16, 2015 at 4:48 PM, Adrian Prantl via cfe-commits > mailto:cfe-commits@lists.llvm.org>> wrote: >> On Oct 16, 2015, at 3:27 PM, Richard Smith > <mailto:rich...@metafoo.co.uk>> wrote: >

Re: [libcxx] r249738 - Split out of .

> On Oct 16, 2015, at 5:28 PM, Richard Smith wrote: > > Getting there :-) In file included from :86: In file included from /Volumes/Data/llvm/_build.ninja.release/bin/../lib/clang/3.8.0/include/tgmath.h:29: /Volumes/Data/llvm/_build.ninja.release/bin/../include/c++/v1/math.h:309:10: fatal e

Re: [libcxx] r249738 - Split out of .

> On Oct 16, 2015, at 5:30 PM, Adrian Prantl via cfe-commits > wrote: > > >> On Oct 16, 2015, at 5:28 PM, Richard Smith > <mailto:rich...@metafoo.co.uk>> wrote: >> >> > > Getting there :-) > While building module 'Darwin

Re: [libcxx] r249738 - Split out of .

> On Oct 16, 2015, at 5:47 PM, Richard Smith wrote: > > Great, looks like progress. Next you need a correct module map for libc++ > that actually covers all of its headers :) Try the attached one. > Sorry for the delay. With the updated module map I get /Volumes/Data/llvm/_build.ninja.releas

Re: [libcxx] r249738 - Split out of .

While building module 'std' imported from /Volumes/Data/llvm/_build.ninja.release/bin/../include/c++/v1/cassert:20: While building module 'Darwin' imported from /Volumes/Data/llvm/_build.ninja.release/bin/../include/c++/v1/ctype.h:39: In file included from :95: In file included from /Xcode.app/C

r251116 - Remove a redundant check. NFC

Author: adrian Date: Fri Oct 23 11:51:32 2015 New Revision: 251116 URL: http://llvm.org/viewvc/llvm-project?rev=251116&view=rev Log: Remove a redundant check. NFC Modified: cfe/trunk/lib/CodeGen/ObjectFilePCHContainerOperations.cpp Modified: cfe/trunk/lib/CodeGen/ObjectFilePCHContainerOperat

r251120 - Module Debugging: Emit module debug info for types inside of Objective-C

Author: adrian Date: Fri Oct 23 12:02:22 2015 New Revision: 251120 URL: http://llvm.org/viewvc/llvm-project?rev=251120&view=rev Log: Module Debugging: Emit module debug info for types inside of Objective-C containers. rdar://problem/23196170 Modified: cfe/trunk/lib/CodeGen/ObjectFilePCHConta

r251126 - Fixup this testcase after r251120.

Author: adrian Date: Fri Oct 23 12:25:17 2015 New Revision: 251126 URL: http://llvm.org/viewvc/llvm-project?rev=251126&view=rev Log: Fixup this testcase after r251120. I accidentally tested r251120 with assertions disabled. Modified: cfe/trunk/test/Modules/ModuleDebugInfo.m Modified: cfe/tru

Re: [PATCH] D14358: DWARF's forward decl of a template should have template parameters.

aprantl added a comment. Unless this is some kind of optimization that we specifically added to minimize debug info size (I have never looked at our template support in detail), this looks totally reasonable. Do other compilers do the same here? http://reviews.llvm.org/D14358 __

Re: [libcxx] r249738 - Split out of .

13, 2016 at 12:53 AM, Adrian Prantl via cfe-commits > mailto:cfe-commits@lists.llvm.org>> wrote: > > On Mar 11, 2016, at 4:11 PM, Duncan P. N. Exon Smith > <mailto:dexonsm...@apple.com>> wrote: > > > > Did anyone file a PR for this? > > > > I fil

Re: [libcxx] r273034 - Add Filesystem TS -- Complete

> On Aug 3, 2016, at 1:56 PM, Bruno Cardoso Lopes > wrote: > > Hi Eric, > > After we upgraded our green dragon bots to El Captain (10.11), the > test below started to fail on some of our machines: > > -- > test/std/experimental/filesystem/fs.op.funcs/fs.op.hard_lk_ct/hard_link_count.pass.cpp

Re: [PATCH] D23167: emit_DW_AT_noreturn flag

aprantl added a comment. Thanks for working in this! Technically this is a DWARF 5 feature, but unknown attributes can be ignored by consumers, so there's no reason to emit it conditionally. Could you please also add a test for llvm-dwarfdump? Could you please also add a textual LLVM IR parser t

Re: [PATCH] D23168: emit_DW_AT_noreturn flag

aprantl added a comment. Please add separate testcases for C11 and C++11 (and possibly Objective-C?). https://reviews.llvm.org/D23168 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23167: emit_DW_AT_noreturn flag

aprantl added a comment. Thanks, now all that's missing is an LLVM IR round-trip test. Adding the new flag to test/Assembler/disubprogram would work. Comment at: test/DebugInfo/noreturn_c11.ll:9 @@ +8,3 @@ + +; CHECK: DW_AT_noreturn + Maybe

Re: [PATCH] D23167: emit_DW_AT_noreturn flag

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. LGTM on the condition that the missing IR roundtrip test (e.g., by extending test/Assembler/disubprogram.ll) is added before committing. https://reviews.llvm.org/D23167 _

Re: [PATCH] D23167: emit_DW_AT_noreturn flag

aprantl added a comment. Found one more. Comment at: test/DebugInfo/noreturn_c11.ll:10 @@ +9,3 @@ +; CHECK: DW_TAG_subprogram +; CHECK: DW_AT_noreturn + One more thing: please rewrite this (and the other testcases) as ``` ; CHECK: DW_TAG_subprogram ; CHECK-NOT

Re: [PATCH] D23167: emit_DW_AT_noreturn flag

aprantl added a comment. Did you forget to add the IR test before uploading the patch? https://reviews.llvm.org/D23167 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23168: emit_DW_AT_noreturn flag

aprantl added inline comments. Comment at: test/Frontend/dinoreturn.c:2 @@ +1,3 @@ +// RUN: %clang %s -c -std=c11 -emit-llvm -S -g -o - | FileCheck %s +// CHECK: DIFlagNoReturn +#include Please check for more context. For example: CHECK: !DISubprogram({{.*}}na

Re: [PATCH] D23167: emit_DW_AT_noreturn flag

aprantl added a comment. You are adding a new constant to the LLVM IR, so there should be a round-trip test that tests the LLVM IR parser, bitcode writer, bitcode reader, and LLVM IR printer to make sure we're handling the new constant correctly. One easy way to do this is by adding the new fla

Re: [libcxx] r278191 - test/hard_link_count(): Fix test on darwin

I'm just curious: Is libcxx generally supposed to merely pass through what the operating system is returning (as in this case) or is is supposed to provide a common abstraction that behaves the same on all platforms? -- adrian > On Aug 10, 2016, at 8:23 PM, Eric Fiselier via cfe-commits > wro

Re: [PATCH] D16135: Macro Debug Info support in Clang

aprantl added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:2099 @@ -2098,1 +2098,3 @@ +llvm::DIMacro *CGDebugInfo::CreateMacro(llvm::DIMacroFile *Parent, bool IsUndef, +SourceLocation LineLoc, StringRef Name,

r259975 - Fix a crash when emitting dbeug info for forward-declared scoped enums.

Author: adrian Date: Fri Feb 5 19:59:09 2016 New Revision: 259975 URL: http://llvm.org/viewvc/llvm-project?rev=259975&view=rev Log: Fix a crash when emitting dbeug info for forward-declared scoped enums. It is possible for enums to be created as part of their own declcontext. We need to cache a p

r260002 - Add a missing call to MDNode::deleteTemporary().

Author: adrian Date: Sat Feb 6 12:39:34 2016 New Revision: 260002 URL: http://llvm.org/viewvc/llvm-project?rev=260002&view=rev Log: Add a missing call to MDNode::deleteTemporary(). Follow-up to r259975. Kudos to the ASAN bots! Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp Modified: cfe/

r260113 - Use llvm::TempDIScope instead of manually deleting a temporary MDNode.

Author: adrian Date: Mon Feb 8 11:03:28 2016 New Revision: 260113 URL: http://llvm.org/viewvc/llvm-project?rev=260113&view=rev Log: Use llvm::TempDIScope instead of manually deleting a temporary MDNode. Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp Modified: cfe/trunk/lib/CodeGen/CGDebugI

Re: r260002 - Add a missing call to MDNode::deleteTemporary().

> On Feb 6, 2016, at 12:38 PM, Duncan P. N. Exon Smith > wrote: > >> >> On 2016-Feb-06, at 10:39, Adrian Prantl via cfe-commits >> wrote: >> >> Author: adrian >> Date: Sat Feb 6 12:39:34 2016 >> New Revision: 260002 >> >&g

Re: r252114 - [modules] If we're given a module file, via -fmodule-file=, for a module, but

> On Feb 11, 2016, at 11:04 AM, Ben Langmuir wrote: > > FYI I changed this to early-exit again in r260563 to fix implicit builds. > It’s not safe to keep reading if we haven’t told ReadOptionsBlock to expect > failures, since it will itself early-exit, leaving the stream in the middle > of a

Re: r259975 - Fix a crash when emitting dbeug info for forward-declared scoped enums.

e got a different testcase? There's not > enough information in the commit to construct one up for you. > > Thanks! > > -eric > > On Fri, Feb 5, 2016 at 6:03 PM Adrian Prantl via cfe-commits > wrote: > Author: adrian > Date: Fri Feb 5 19:59:09 2016 >

Re: r261448 - Lex: Check buckets on header map construction

> On Feb 20, 2016, at 1:00 PM, Duncan P. N. Exon Smith via cfe-commits > wrote: > > Author: dexonsmith > Date: Sat Feb 20 15:00:58 2016 > New Revision: 261448 > > URL: http://llvm.org/viewvc/llvm-project?rev=261448&view=rev > Log: > Lex: Check buckets on header map construction > > If the num

r261657 - Remove an unnecessary workaround introduced in r259975. (NFC)

Author: adrian Date: Tue Feb 23 11:13:47 2016 New Revision: 261657 URL: http://llvm.org/viewvc/llvm-project?rev=261657&view=rev Log: Remove an unnecessary workaround introduced in r259975. (NFC) Now that LLVM r259973 allows replacing a temporary type with another temporary we can rely on the orig

Re: r259975 - Fix a crash when emitting dbeug info for forward-declared scoped enums.

rent patch doesn't appear necessary so I'm > unable to debug the original problem at this point to try to help more. > > -eric > > -- adrian > > > Can you take a look/revert until you've got a different testcase? There's > > not enough information

Re: r261657 - Remove an unnecessary workaround introduced in r259975. (NFC)

13 AM, Adrian Prantl via cfe-commits > wrote: >> Author: adrian >> Date: Tue Feb 23 11:13:47 2016 >> New Revision: 261657 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=261657&view=rev >> Log: >> Remove an unnecessary workaround introduced in r25

r261673 - Reapply r261657.

Author: adrian Date: Tue Feb 23 13:30:08 2016 New Revision: 261673 URL: http://llvm.org/viewvc/llvm-project?rev=261673&view=rev Log: Reapply r261657. Remove an unnecessary workaround introduced in r259975. (NFC) Now that LLVM r259973 allows replacing a temporary type with another temporary we can

Re: r261657 - Remove an unnecessary workaround introduced in r259975. (NFC)

Done in r261673. -- adrian > On Feb 23, 2016, at 11:23 AM, Adrian Prantl via cfe-commits > wrote: > > I will carefully revert the revert of this commit on top of the current > trunk. Thanks for the notice. > > -- adrian > >> On Feb 23, 2016, at 11:15 AM, Ha

r267611 - Module debugging: Use the definition to determine module-defined types.

Author: adrian Date: Tue Apr 26 16:58:18 2016 New Revision: 267611 URL: http://llvm.org/viewvc/llvm-project?rev=267611&view=rev Log: Module debugging: Use the definition to determine module-defined types. Follow-up to r267464. Thanks to Richard Smith for pointing this out! Modified: cfe/trun

r267612 - Module debugging: Add testcase for member classes of class template specializations.

Author: adrian Date: Tue Apr 26 16:58:23 2016 New Revision: 267612 URL: http://llvm.org/viewvc/llvm-project?rev=267612&view=rev Log: Module debugging: Add testcase for member classes of class template specializations. Modified: cfe/trunk/test/Modules/ExtDebugInfo.cpp cfe/trunk/test/Modul

Re: r267464 - Module Debugging: Fix the condition for determining whether a template

> On Apr 25, 2016, at 5:34 PM, Richard Smith wrote: > > On Mon, Apr 25, 2016 at 1:52 PM, Adrian Prantl via cfe-commits > mailto:cfe-commits@lists.llvm.org>> wrote: > Author: adrian > Date: Mon Apr 25 15:52:40 2016 > New Revision: 267464 > > URL: http://llvm.o

r267630 - Module debugging: Also correctly handle typedef'd foward-declared members.

Author: adrian Date: Tue Apr 26 18:37:38 2016 New Revision: 267630 URL: http://llvm.org/viewvc/llvm-project?rev=267630&view=rev Log: Module debugging: Also correctly handle typedef'd foward-declared members. Thanks again to Richard Smith for pointing this out. Modified: cfe/trunk/lib/CodeGen/

r267633 - Module debugging: Add an assertion.

Author: adrian Date: Tue Apr 26 18:42:43 2016 New Revision: 267633 URL: http://llvm.org/viewvc/llvm-project?rev=267633&view=rev Log: Module debugging: Add an assertion. Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp URL: http://llvm.org/viewv

<    1   2   3   4   5   6   >