aprantl added a comment.

Found one more.


================
Comment at: test/DebugInfo/noreturn_c11.ll:10
@@ +9,3 @@
+; CHECK: DW_TAG_subprogram 
+; CHECK: DW_AT_noreturn
+
----------------
One more thing: please rewrite this (and the other testcases) as
```
; CHECK: DW_TAG_subprogram 
; CHECK-NOT: DW_TAG
; CHECK: DW_AT_name{{.*}}"f"
; CHECK-NOT: DW_TAG
; CHECK: DW_AT_noreturn
``

The check for the name ensures we're in the right function, the CHECK-NOT: 
ensures that we are not skipping into a subsequent tag.


https://reviews.llvm.org/D23167



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to