[clang] [NFC][C++][Modules] Mark P2788R0(DR) as implemented and added more test (PR #144214)

2025-07-08 Thread via cfe-commits
https://github.com/yronglin closed https://github.com/llvm/llvm-project/pull/144214 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC] [C++] [Modules] Mark P2788 as implemented and add test (PR #147138)

2025-07-08 Thread via cfe-commits
yronglin wrote: Can you add the test from https://github.com/llvm/llvm-project/pull/144214? I think we also need to check that in clang/test/CXX/basic/basic.link/p3.cpp https://github.com/llvm/llvm-project/pull/147138 ___ cfe-commits mailing list cfe-

[clang] [NFC][C++][Modules] Mark P2788R0(DR) as implemented and added more test (PR #144214)

2025-07-08 Thread via cfe-commits
yronglin wrote: Duplicated with https://github.com/llvm/llvm-project/pull/147138, I think we can close this one. https://github.com/llvm/llvm-project/pull/144214 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[clang] [RISCV] Split out the intrinsic tests for bfloat16 into a separate directory named zvfbfmin. NFC. (PR #147644)

2025-07-08 Thread Brandon Wu via cfe-commits
https://github.com/4vtomat approved this pull request. I agree with you that it's easier to maintain, btw are you going to do that for all extensions? https://github.com/llvm/llvm-project/pull/147644 ___ cfe-commits mailing list cfe-commits@lists.llvm

[clang] 6ee3751 - [RISCV] Correct type lowering of struct of fixed-vector array in VLS (#147173)

2025-07-08 Thread via cfe-commits
Author: Brandon Wu Date: 2025-07-08T21:14:40-07:00 New Revision: 6ee375147b0b70cd44d06b83dc366c5862599280 URL: https://github.com/llvm/llvm-project/commit/6ee375147b0b70cd44d06b83dc366c5862599280 DIFF: https://github.com/llvm/llvm-project/commit/6ee375147b0b70cd44d06b83dc366c5862599280.diff LO

[clang] [RISCV] Correct type lowering of struct of fixed-vector array in VLS (PR #147173)

2025-07-08 Thread Brandon Wu via cfe-commits
https://github.com/4vtomat closed https://github.com/llvm/llvm-project/pull/147173 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Split line comments separated by backslashes (PR #147648)

2025-07-08 Thread Owen Pan via cfe-commits
https://github.com/owenca created https://github.com/llvm/llvm-project/pull/147648 Fixes #147341 >From 3efb5ca11d67ad36c4cbb1ea78220a1ca69a8339 Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Tue, 8 Jul 2025 21:16:12 -0700 Subject: [PATCH] [clang-format] Split line comments separated by backslas

[clang] [clang-format] Split line comments separated by backslashes (PR #147648)

2025-07-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-format Author: Owen Pan (owenca) Changes Fixes #147341 --- Full diff: https://github.com/llvm/llvm-project/pull/147648.diff 5 Files Affected: - (modified) clang/docs/ClangFormatStyleOptions.rst (+3-3) - (modified) clang/include/clang/Format/Fo

[clang] [llvm] Fix Windows EH IP2State tables (remove +1 bias) (PR #144745)

2025-07-08 Thread Eli Friedman via cfe-commits
@@ -2660,6 +2644,133 @@ void X86AsmPrinter::emitCallInstruction(const llvm::MCInst &MCI) { OutStreamer->emitInstruction(MCI, getSubtargetInfo()); } +// Checks whether a NOP is required after a CALL and inserts the NOP, if +// necessary. +void X86AsmPrinter::emitNopAfterCall

[clang] [llvm] Fix Windows EH IP2State tables (remove +1 bias) (PR #144745)

2025-07-08 Thread Eli Friedman via cfe-commits
@@ -9,7 +9,6 @@ define i32 @foobar() gc "statepoint-example" personality ptr @__gxx_personality_ ; CHECK-NEXT:.seh_endprologue ; CHECK-NEXT:callq bar ; CHECK-NEXT: .Ltmp0: -; CHECK-NEXT:nop efriedma-quic wrote: So the conclusion here is this part

[clang] [llvm] Fix Windows EH IP2State tables (remove +1 bias) (PR #144745)

2025-07-08 Thread Eli Friedman via cfe-commits
@@ -2537,26 +2538,6 @@ void X86AsmPrinter::emitInstruction(const MachineInstr *MI) { case X86::SEH_BeginEpilogue: { assert(MF->hasWinCFI() && "SEH_ instruction in function without WinCFI?"); -// Windows unwinder will not invoke function's exception handler if IP is

[clang] [llvm] Fix Windows EH IP2State tables (remove +1 bias) (PR #144745)

2025-07-08 Thread Eli Friedman via cfe-commits
@@ -9,7 +9,6 @@ define i32 @foobar() gc "statepoint-example" personality ptr @__gxx_personality_ ; CHECK-NEXT:.seh_endprologue ; CHECK-NEXT:callq bar ; CHECK-NEXT: .Ltmp0: -; CHECK-NEXT:nop efriedma-quic wrote: Looking a bit more, if you drop the

[clang] Sema: filter out invalid base-specifiers before attaching (PR #147213)

2025-07-08 Thread Corentin Jabot via cfe-commits
https://github.com/cor3ntin approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/147213 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Sema: filter out invalid base-specifiers before attaching (PR #147213)

2025-07-08 Thread Corentin Jabot via cfe-commits
@@ -2252,7 +2252,10 @@ void Parser::ParseBaseClause(Decl *ClassDecl) { while (true) { // Parse a base-specifier. BaseResult Result = ParseBaseSpecifier(ClassDecl); -if (Result.isInvalid()) { +// Skip any base-specifier we couldn’t actually build into a usable

[clang] Sema: filter out invalid base-specifiers before attaching (PR #147213)

2025-07-08 Thread Corentin Jabot via cfe-commits
@@ -0,0 +1,13 @@ +// Tests that invalid base-specifiers no longer crash the compiler. +// RUN: %clang_cc1 -std=c++20 -fsyntax-only -verify %s + +class X; // expected-note {{forward declaration of 'X'}} expected-note {{forward declaration of 'X'}} + +class A : X { // expected-erro

[clang] [RISCV] Split out the intrinsic tests for bfloat16 into a separate directory named zvfbfmin. NFC. (PR #147644)

2025-07-08 Thread Jim Lin via cfe-commits
tclin914 wrote: > I agree with you that it's easier to maintain, btw are you going to do that > for all extensions? For now, I'm going to do this for zvfh/zvfhmin/zvfbfmin/zvfbfwma. https://github.com/llvm/llvm-project/pull/147644 ___ cfe-commits mai

[clang] Sema: filter out invalid base-specifiers before attaching (PR #147213)

2025-07-08 Thread Corentin Jabot via cfe-commits
https://github.com/cor3ntin edited https://github.com/llvm/llvm-project/pull/147213 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Sema: filter out invalid base-specifiers before attaching (PR #147213)

2025-07-08 Thread Corentin Jabot via cfe-commits
@@ -923,6 +923,7 @@ Bug Fixes to C++ Support - Improved handling of variables with ``consteval`` constructors, to consistently treat the initializer as manifestly constant-evaluated. (#GH135281) +- Switch `ParseBaseClause` to use `BaseResult::isUsable()` instead of `isInva

[clang-tools-extra] [clang-tidy] Add portability-avoid-platform-specific-fundamental-types (PR #146970)

2025-07-08 Thread Baranov Victor via cfe-commits
@@ -0,0 +1,260 @@ +//===--- AvoidPlatformSpecificFundamentalTypesCheck.cpp - clang-tidy --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [NFC][PowerPC][clang] Update clang/test/Driver/aix-default-target-triple.c for AIX specific targets (PR #147584)

2025-07-08 Thread Tony Varghese via cfe-commits
https://github.com/tonykuttai updated https://github.com/llvm/llvm-project/pull/147584 >From 8530b1d115c06c1796b640ce16de47fce684a469 Mon Sep 17 00:00:00 2001 From: Tony Varghese Date: Tue, 8 Jul 2025 18:55:31 + Subject: [PATCH 1/2] [NFC][PowerPC][clang] Update clang/test/Driver/aix-defaul

[clang] [NFC][PowerPC][clang] Update clang/test/Driver/aix-default-target-triple.c for AIX specific targets (PR #147584)

2025-07-08 Thread Tony Varghese via cfe-commits
https://github.com/tonykuttai updated https://github.com/llvm/llvm-project/pull/147584 >From 8530b1d115c06c1796b640ce16de47fce684a469 Mon Sep 17 00:00:00 2001 From: Tony Varghese Date: Tue, 8 Jul 2025 18:55:31 + Subject: [PATCH 1/2] [NFC][PowerPC][clang] Update clang/test/Driver/aix-defaul

[clang-tools-extra] fbc4255 - [clang-tidy] Teach `modernize-type-traits` about more type traits (#147074)

2025-07-08 Thread via cfe-commits
Author: Victor Chernyakin Date: 2025-07-09T08:21:40+03:00 New Revision: fbc4255ffcb8412a098926c7fc1ede823d6fb0e5 URL: https://github.com/llvm/llvm-project/commit/fbc4255ffcb8412a098926c7fc1ede823d6fb0e5 DIFF: https://github.com/llvm/llvm-project/commit/fbc4255ffcb8412a098926c7fc1ede823d6fb0e5.d

[clang-tools-extra] [clang-tidy] Teach `modernize-type-traits` about more type traits (PR #147074)

2025-07-08 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor closed https://github.com/llvm/llvm-project/pull/147074 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Teach `modernize-type-traits` about more type traits (PR #147074)

2025-07-08 Thread via cfe-commits
github-actions[bot] wrote: @localspook Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a bui

[clang] [CIR] Add support for parsing complete records (PR #147403)

2025-07-08 Thread Henrich Lauko via cfe-commits
xlauko wrote: Can you add to CIR_RecordType description an example with packed/padded flag? https://github.com/llvm/llvm-project/pull/147403 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[clang] [CIR] Add bit reverse and byte reverse operations (PR #147200)

2025-07-08 Thread Henrich Lauko via cfe-commits
https://github.com/xlauko edited https://github.com/llvm/llvm-project/pull/147200 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Add warning for blocks capturing {'this', raw pointers, references} (PR #144388)

2025-07-08 Thread Sylvain Defresne via cfe-commits
@@ -1641,6 +1641,17 @@ def warn_implicitly_retains_self : Warning < "block implicitly retains 'self'; explicitly mention 'self' to indicate " "this is intended behavior">, InGroup>, DefaultIgnore; +def warn_blocks_capturing_this : Warning<"block implicitly captures 'this'

[clang] [Clang] Fix crash on `void{}` (PR #147514)

2025-07-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Corentin Jabot (cor3ntin) Changes Caused by an incorrect assertion. Fixes #116440 --- Full diff: https://github.com/llvm/llvm-project/pull/147514.diff 2 Files Affected: - (modified) clang/lib/CodeGen/CGExprScalar.cpp (+3-1) - (modifie

[clang] [Clang] Fix crash on `void{}` (PR #147514)

2025-07-08 Thread Corentin Jabot via cfe-commits
https://github.com/cor3ntin created https://github.com/llvm/llvm-project/pull/147514 Caused by an incorrect assertion. Fixes #116440 >From 4b536efe500f3b9099d1cf1a1a8775633e193249 Mon Sep 17 00:00:00 2001 From: Corentin Jabot Date: Tue, 8 Jul 2025 14:34:16 +0200 Subject: [PATCH] [Clang] Fix c

[clang] [clang-tools-extra] [lldb] [clang] Extend SourceLocation to 64 bits. (PR #147292)

2025-07-08 Thread Erich Keane via cfe-commits
erichkeane wrote: > > Why is this a new review? What changed from the last one I looked at? > > Ah, right -- this patch is actually derived from the previous one, and it is > simpler. That older patch became a bit outdated since some of its changes > were split out and already landed in main.

[clang] 77ea912 - [clang][diagnostics] Refactor "warn_doc_container_decl_mismatch" to use enum_select (#147120)

2025-07-08 Thread via cfe-commits
Author: Ayokunle Amodu Date: 2025-07-08T06:15:41-07:00 New Revision: 77ea912a796e00f86a6a114de45c01017a9d51d3 URL: https://github.com/llvm/llvm-project/commit/77ea912a796e00f86a6a114de45c01017a9d51d3 DIFF: https://github.com/llvm/llvm-project/commit/77ea912a796e00f86a6a114de45c01017a9d51d3.diff

[clang] [clang][diagnostics] Refactor "warn_doc_container_decl_mismatch" to use enum_select (PR #147120)

2025-07-08 Thread Erich Keane via cfe-commits
https://github.com/erichkeane closed https://github.com/llvm/llvm-project/pull/147120 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [PowerPC][clang] Fix triple constructor ambiguity causing "unknown" target triple on AIX (PR #147488)

2025-07-08 Thread Matt Arsenault via cfe-commits
@@ -0,0 +1,15 @@ +// Test for the Triple constructor ambiguity fix on AIX +// This test verifies that the default target triple is correctly resolved +// and doesn't fall back to "unknown" due to constructor ambiguity. + +// REQUIRES: system-aix +// RUN: %clang -v %s -c 2>&1 | Fil

[clang] [llvm] [PowerPC][clang] Fix triple constructor ambiguity causing "unknown" target triple on AIX (PR #147488)

2025-07-08 Thread Matt Arsenault via cfe-commits
@@ -0,0 +1,15 @@ +// Test for the Triple constructor ambiguity fix on AIX +// This test verifies that the default target triple is correctly resolved +// and doesn't fall back to "unknown" due to constructor ambiguity. + +// REQUIRES: system-aix +// RUN: %clang -v %s -c 2>&1 | Fil

[clang] [llvm] [PowerPC][clang] Fix triple constructor ambiguity causing "unknown" target triple on AIX (PR #147488)

2025-07-08 Thread Matt Arsenault via cfe-commits
https://github.com/arsenm approved this pull request. lgtm with test nits https://github.com/llvm/llvm-project/pull/147488 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [PowerPC][clang] Fix triple constructor ambiguity causing "unknown" target triple on AIX (PR #147488)

2025-07-08 Thread Matt Arsenault via cfe-commits
https://github.com/arsenm edited https://github.com/llvm/llvm-project/pull/147488 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang] Avoid printing overly large integer/_BitInt numbers in static assertion failure diagnostics #71675 (PR #145053)

2025-07-08 Thread Erich Keane via cfe-commits
@@ -2278,8 +2285,28 @@ void APInt::toString(SmallVectorImpl &Str, unsigned Radix, bool Signed, } } else { int Pos = 0; +// The value of cutOffSize is not special, it is just a number of +// characters that gives us enough info without losing readability. +

[clang-tools-extra] [clang-tidy] support ak_attr_info in diagnostic forwarding (PR #147503)

2025-07-08 Thread Mikael Holmén via cfe-commits
mikaelholmen wrote: > Did any of the builders caught this, or it is some local configuration? > Asking just in case if we should create one for catching such CE's. I saw it locally when compiling with -Wall -Werror. I don't know if any builder use -Werror? I don't see any sign of it in https:

[clang-tools-extra] [clang-tidy] Add new check: `readability-use-concise-preprocessor-directives` (PR #146830)

2025-07-08 Thread Victor Chernyakin via cfe-commits
localspook wrote: When we're ready to merge, someone please do it for me, I don't have write permissions. https://github.com/llvm/llvm-project/pull/146830 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/l

[clang] Propose new ClangIR Maintainer (PR #147365)

2025-07-08 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman commented: Awesome! We just need @xlauko to explicitly approve and then we're good to go! https://github.com/llvm/llvm-project/pull/147365 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[clang] Propose new ClangIR Maintainer (PR #147365)

2025-07-08 Thread Henrich Lauko via cfe-commits
https://github.com/xlauko approved this pull request. https://github.com/llvm/llvm-project/pull/147365 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [C23][Parser] Diagnostic for attribute declaration where statement is required (PR #146224)

2025-07-08 Thread via cfe-commits
https://github.com/yronglin updated https://github.com/llvm/llvm-project/pull/146224 >From 43e2dc670d7c9ed5e23b5d26dff1e273c84b5a53 Mon Sep 17 00:00:00 2001 From: yronglin Date: Thu, 3 Jul 2025 02:15:22 +0800 Subject: [PATCH 1/6] [C23][Parser] Diagnostic for attribute declaration where stateme

[clang] [llvm] [AMDGPU] Add support for `v_cvt_f16_bf8` on gfx1250 (PR #146305)

2025-07-08 Thread Shilei Tian via cfe-commits
@@ -2,51 +2,41 @@ # RUN: llvm-mc -triple=amdgcn -mcpu=gfx1250 -mattr=+real-true16 -disassemble -show-encoding < %s | FileCheck -check-prefixes=GFX1250,GFX1250-REAL16 %s # RUN: llvm-mc -triple=amdgcn -mcpu=gfx1250 -mattr=-real-true16 -disassemble -show-encoding < %s | FileCheck

[clang] [C23][Parser] Diagnostic for attribute declaration where statement is required (PR #146224)

2025-07-08 Thread via cfe-commits
https://github.com/yronglin updated https://github.com/llvm/llvm-project/pull/146224 >From 43e2dc670d7c9ed5e23b5d26dff1e273c84b5a53 Mon Sep 17 00:00:00 2001 From: yronglin Date: Thu, 3 Jul 2025 02:15:22 +0800 Subject: [PATCH 1/6] [C23][Parser] Diagnostic for attribute declaration where stateme

[clang] [C23][Parser] Diagnostic for attribute declaration where statement is required (PR #146224)

2025-07-08 Thread via cfe-commits
@@ -276,6 +276,9 @@ def err_expected_while : Error<"expected 'while' in do/while loop">; def err_expected_semi_after_stmt : Error<"expected ';' after %0 statement">; def err_expected_semi_after_expr : Error<"expected ';' after expression">; +def warn_attr_in_secondary_block :

[clang] [analyzer] Enforce not making overly complicated symbols (PR #144327)

2025-07-08 Thread Donát Nagy via cfe-commits
NagyDonat wrote: Thank you for the very through statistical analysis and visualization -- this paints a clear picture about the effects of the change. > In conclusion, in contrast to the originally proposed variant of this patch > this evolved version is more controversial and the benefits are

[clang] [Clang] suppress deprecated field warnings in implicit special-member functions (PR #147400)

2025-07-08 Thread Corentin Jabot via cfe-commits
@@ -547,6 +547,15 @@ static void DoEmitAvailabilityWarning(Sema &S, AvailabilityResult K, return; } case AR_Deprecated: +// Suppress -Wdeprecated-declarations in purely implicit special-member functions. +if (auto *MD = dyn_cast_if_present(S.getCurFunctionDecl

[clang] [Clang] suppress deprecated field warnings in implicit special-member functions (PR #147400)

2025-07-08 Thread Shashi Shankar via cfe-commits
@@ -547,6 +547,15 @@ static void DoEmitAvailabilityWarning(Sema &S, AvailabilityResult K, return; } case AR_Deprecated: +// Suppress -Wdeprecated-declarations in purely implicit special-member functions. +if (auto *MD = dyn_cast_if_present(S.getCurFunctionDecl

[clang] [Clang] Do not mark ambiguous specialization invalid. (PR #147275)

2025-07-08 Thread Corentin Jabot via cfe-commits
https://github.com/cor3ntin updated https://github.com/llvm/llvm-project/pull/147275 >From 346ac892d7575ac779295b9db11bc895f37f160e Mon Sep 17 00:00:00 2001 From: Corentin Jabot Date: Mon, 7 Jul 2025 12:41:53 +0200 Subject: [PATCH 1/4] [Clang] Do not mark ambiguous specialization invalid. When

[clang] [analyzer] Conversion to CheckerFamily: MallocChecker (PR #147080)

2025-07-08 Thread Donát Nagy via cfe-commits
https://github.com/NagyDonat closed https://github.com/llvm/llvm-project/pull/147080 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] f72e53f - [clang][CompundLiteralExpr] Don't defer evaluation for CLEs (#137163)

2025-07-08 Thread via cfe-commits
Author: kadir çetinkaya Date: 2025-07-08T16:00:40+02:00 New Revision: f72e53f35070140cbd6d4acdf7f8bc37f72d0445 URL: https://github.com/llvm/llvm-project/commit/f72e53f35070140cbd6d4acdf7f8bc37f72d0445 DIFF: https://github.com/llvm/llvm-project/commit/f72e53f35070140cbd6d4acdf7f8bc37f72d0445.dif

[clang] [clang][CompundLiteralExpr] Don't defer evaluation for CLEs (PR #137163)

2025-07-08 Thread kadir çetinkaya via cfe-commits
https://github.com/kadircet closed https://github.com/llvm/llvm-project/pull/137163 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Add bit reverse and byte reverse operations (PR #147200)

2025-07-08 Thread Henrich Lauko via cfe-commits
@@ -2661,6 +2661,55 @@ def BitPopcountOp : CIR_BitOpBase<"bit.popcnt", }]; } +def BitReverseOp : CIR_BitOpBase<"bit.reverse", CIR_UIntOfWidths<[8, 16, 32, 64]>> { + let summary = "Reverse the bit pattern of the operand integer"; + let description = [{ +The `cir.bit.re

[clang] [CIR] Add bit reverse and byte reverse operations (PR #147200)

2025-07-08 Thread Henrich Lauko via cfe-commits
@@ -2661,6 +2661,55 @@ def BitPopcountOp : CIR_BitOpBase<"bit.popcnt", }]; } +def BitReverseOp : CIR_BitOpBase<"bit.reverse", CIR_UIntOfWidths<[8, 16, 32, 64]>> { xlauko wrote: ```suggestion def CIR_BitReverseOp : CIR_BitOpBase<"bit.reverse", CIR_UI

[clang] [CIR] Add bit reverse and byte reverse operations (PR #147200)

2025-07-08 Thread Henrich Lauko via cfe-commits
@@ -2661,6 +2661,55 @@ def BitPopcountOp : CIR_BitOpBase<"bit.popcnt", }]; } +def BitReverseOp : CIR_BitOpBase<"bit.reverse", CIR_UIntOfWidths<[8, 16, 32, 64]>> { xlauko wrote: I would also suggest to rename to `bitreverse` to mirror builtins name. Also d

[clang] [CIR] Add bit reverse and byte reverse operations (PR #147200)

2025-07-08 Thread Henrich Lauko via cfe-commits
@@ -190,6 +190,26 @@ RValue CIRGenFunction::emitBuiltinExpr(const GlobalDecl &gd, unsigned builtinID, expectedValue, probAttr); return RValue::get(result); } + + case Builtin::BI__builtin_bswap16: + case Builtin::BI__buil

[clang] [CIR] Add bit reverse and byte reverse operations (PR #147200)

2025-07-08 Thread Henrich Lauko via cfe-commits
@@ -2661,6 +2661,55 @@ def BitPopcountOp : CIR_BitOpBase<"bit.popcnt", }]; } +def BitReverseOp : CIR_BitOpBase<"bit.reverse", CIR_UIntOfWidths<[8, 16, 32, 64]>> { + let summary = "Reverse the bit pattern of the operand integer"; + let description = [{ +The `cir.bit.re

[clang] [CIR] Add bit reverse and byte reverse operations (PR #147200)

2025-07-08 Thread Henrich Lauko via cfe-commits
@@ -2661,6 +2661,55 @@ def BitPopcountOp : CIR_BitOpBase<"bit.popcnt", }]; } +def BitReverseOp : CIR_BitOpBase<"bit.reverse", CIR_UIntOfWidths<[8, 16, 32, 64]>> { + let summary = "Reverse the bit pattern of the operand integer"; + let description = [{ +The `cir.bit.re

[clang] [CIR] Add bit reverse and byte reverse operations (PR #147200)

2025-07-08 Thread Henrich Lauko via cfe-commits
@@ -2661,6 +2661,55 @@ def BitPopcountOp : CIR_BitOpBase<"bit.popcnt", }]; } +def BitReverseOp : CIR_BitOpBase<"bit.reverse", CIR_UIntOfWidths<[8, 16, 32, 64]>> { xlauko wrote: These are inherited from `CIR_BitOpBase`. https://github.com/llvm/llvm-project

[clang] [llvm] [SYCL] Add offload wrapping for SYCL kind. (PR #147508)

2025-07-08 Thread Maksim Sabianin via cfe-commits
https://github.com/maksimsab created https://github.com/llvm/llvm-project/pull/147508 None >From 524da07f8449154a40796c5734d674df64e3f9af Mon Sep 17 00:00:00 2001 From: "Sabianin, Maksim" Date: Mon, 7 Jul 2025 08:30:12 -0700 Subject: [PATCH] [SYCL] Add offload wrapping for SYCL kind. --- cla

[clang] [llvm] [SYCL] Add offload wrapping for SYCL kind. (PR #147508)

2025-07-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver @llvm/pr-subscribers-clang Author: Maksim Sabianin (maksimsab) Changes --- Patch is 34.84 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/147508.diff 11 Files Affected: - (modified) clang/tes

[clang-tools-extra] [clang-tidy] support ak_attr_info in diagnostic forwarding (PR #147503)

2025-07-08 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/147503 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Add bit reverse and byte reverse operations (PR #147200)

2025-07-08 Thread Sirui Mu via cfe-commits
@@ -2661,6 +2661,55 @@ def BitPopcountOp : CIR_BitOpBase<"bit.popcnt", }]; } +def BitReverseOp : CIR_BitOpBase<"bit.reverse", CIR_UIntOfWidths<[8, 16, 32, 64]>> { + let summary = "Reverse the bit pattern of the operand integer"; + let description = [{ +The `cir.bit.re

[clang] [CIR] Add bit reverse and byte reverse operations (PR #147200)

2025-07-08 Thread Sirui Mu via cfe-commits
@@ -2661,6 +2661,55 @@ def BitPopcountOp : CIR_BitOpBase<"bit.popcnt", }]; } +def BitReverseOp : CIR_BitOpBase<"bit.reverse", CIR_UIntOfWidths<[8, 16, 32, 64]>> { Lancern wrote: Well I think we need to think about what the exact scope of `CIR_BitOpBase` is

[clang] [PowerPC][NFC] Define new alias for mma accumulate builtins (PR #147382)

2025-07-08 Thread Amy Kwan via cfe-commits
@@ -35,6 +35,13 @@ #define UNALIASED_CUSTOM_BUILTIN(ID, TYPES, ACCUMULATE, FEATURE) \ CUSTOM_BUILTIN(ID, ID, TYPES, ACCUMULATE, FEATURE) +#define UNALIASED_CUSTOM_MMA_BUILTIN(ID, TYPES, FEATURE) \ amy-kwan wrote: Can we

[clang] [llvm] [openmp] [clang][OpenMP] New OpenMP 6.0 threadset clause (PR #135807)

2025-07-08 Thread via cfe-commits
https://github.com/Ritanya-B-Bharadwaj updated https://github.com/llvm/llvm-project/pull/135807 >From 9c56e59ba9984c14c15a8d5a95a02e7192a64e8f Mon Sep 17 00:00:00 2001 From: Ritanya B Bharadwaj Date: Sun, 6 Apr 2025 09:33:06 -0500 Subject: [PATCH 1/7] [OpenMP] Parsing Support of ThreadSets in T

[clang] [Sema] Remove an unnecessary cast (NFC) (PR #147546)

2025-07-08 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/147546 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] d0c1f14 - [Sema] Remove an unnecessary cast (NFC) (#147546)

2025-07-08 Thread via cfe-commits
Author: Kazu Hirata Date: 2025-07-08T12:47:03-07:00 New Revision: d0c1f148ced2a599dc36046f3bd46af64e3f5ed0 URL: https://github.com/llvm/llvm-project/commit/d0c1f148ced2a599dc36046f3bd46af64e3f5ed0 DIFF: https://github.com/llvm/llvm-project/commit/d0c1f148ced2a599dc36046f3bd46af64e3f5ed0.diff L

[clang] Propogate linker flags when -static-pie is enabled in BareMetal Toolchain (PR #147589)

2025-07-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Garvit Gupta (quic-garvgupt) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/147589.diff 9 Files Affected: - (modified) clang/include/clang/Driver/CommonArgs.h (+2) - (modified) clang/lib/Driver/ToolChains/BareMetal.c

[clang] [clang][test] Fix RUN lines in cxx2a-constexpr-dynalloc.cpp (PR #147590)

2025-07-08 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/147590 These were added in https://github.com/llvm/llvm-project/pull/147303, but the -fexperimental-new-constant-interpreter was missing. >From d37db46dd55d3948cd6c7d002c9e9dd5edc2568c Mon Sep 17 00:00:00 2001 From:

[clang] [clang][test] Fix RUN lines in cxx2a-constexpr-dynalloc.cpp (PR #147590)

2025-07-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) Changes These were added in https://github.com/llvm/llvm-project/pull/147303, but the -fexperimental-new-constant-interpreter was missing. --- Full diff: https://github.com/llvm/llvm-project/pull/147590.diff 1 Fil

[clang] Propogate linker flags when -static-pie is enabled in BareMetal Toolchain (PR #147589)

2025-07-08 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions cpp,c,h -- clang/include/clang/Driver/CommonArgs.h clang/li

[clang] [clang-tools-extra] [ASTMatchers][NFC] Replace `makeMatcher` function with CTAD (PR #147197)

2025-07-08 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor approved this pull request. https://github.com/llvm/llvm-project/pull/147197 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Propogate linker flags when -static-pie is enabled in BareMetal Toolchain (PR #147589)

2025-07-08 Thread Garvit Gupta via cfe-commits
https://github.com/quic-garvgupt updated https://github.com/llvm/llvm-project/pull/147589 >From 6f96fc844751a95ee18b69ddb850ddd2fe76a89c Mon Sep 17 00:00:00 2001 From: Garvit Gupta Date: Tue, 8 Jul 2025 07:21:37 -0700 Subject: [PATCH 1/2] Propogate appropriate linker flags for `-static-pie` in

[clang] f7a0922 - [clang][test] Fix RUN lines in cxx2a-constexpr-dynalloc.cpp (#147590)

2025-07-08 Thread via cfe-commits
Author: Timm Baeder Date: 2025-07-09T07:59:45+02:00 New Revision: f7a09222f42a3fbb44ecbf8b1dd52583fb60efa8 URL: https://github.com/llvm/llvm-project/commit/f7a09222f42a3fbb44ecbf8b1dd52583fb60efa8 DIFF: https://github.com/llvm/llvm-project/commit/f7a09222f42a3fbb44ecbf8b1dd52583fb60efa8.diff L

[clang] [clang][test] Fix RUN lines in cxx2a-constexpr-dynalloc.cpp (PR #147590)

2025-07-08 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/147590 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [REAPPLY][Clang-Repl] Add support for out-of-process execution. #110418 (PR #144064)

2025-07-08 Thread Anutosh Bhat via cfe-commits
https://github.com/anutosh491 milestoned https://github.com/llvm/llvm-project/pull/144064 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RISCV] Split out the intrinsic tests for bfloat16 into a separate directory named zvfbfmin. NFC. (PR #147644)

2025-07-08 Thread Jim Lin via cfe-commits
https://github.com/tclin914 closed https://github.com/llvm/llvm-project/pull/147644 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] disallow # operators in attribute argument lists (PR #147308)

2025-07-08 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/147308 >From 8f1c383f8f84fb636af4a78e0ff504830f9272f5 Mon Sep 17 00:00:00 2001 From: Oleksandr Tarasiuk Date: Mon, 7 Jul 2025 17:20:48 +0300 Subject: [PATCH 1/3] [Clang] disallow operator in attribute argument list

[clang] [analyzer] Conversion to CheckerFamily: MallocChecker (PR #147080)

2025-07-08 Thread via cfe-commits
=?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy Message-ID: In-Reply-To: github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You c

[clang] [llvm] [WebAssembly,llvm] Add llvm.wasm.ref.test.func intrinsic (PR #147076)

2025-07-08 Thread Hood Chatham via cfe-commits
hoodmane wrote: Okay I opened https://github.com/llvm/llvm-project/pull/147486/ with a second option. I think that's a bit cleaner, I modified SelectionDAG to be able to emit CImm arguments rather than going to all this trouble to avoid it. https://github.com/llvm/llvm-project/pull/147076

[clang] [NFC] [C++] [Modules] Mark P2115 as implemented and add test (PR #147489)

2025-07-08 Thread Ashwin Kishin Banwari via cfe-commits
https://github.com/kish1n created https://github.com/llvm/llvm-project/pull/147489 This is already implemented. Proposal: https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2020/p2115r0.html >From 9d24a78f734e5398a1bfc977b77b3287a5f5203e Mon Sep 17 00:00:00 2001 From: Ashwin Banwari Date: Tu

[clang] [NFC] [C++] [Modules] Mark P2115 as implemented and add test (PR #147489)

2025-07-08 Thread Ashwin Kishin Banwari via cfe-commits
kish1n wrote: @ChuanqiXu9 https://github.com/llvm/llvm-project/pull/147489 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][PowerPC][clang] Update clang/test/Driver/aix-default-target-triple.c for AIX specific targets (PR #147584)

2025-07-08 Thread Hubert Tong via cfe-commits
https://github.com/hubert-reinterpretcast edited https://github.com/llvm/llvm-project/pull/147584 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][PowerPC][clang] Update clang/test/Driver/aix-default-target-triple.c for AIX specific targets (PR #147584)

2025-07-08 Thread Hubert Tong via cfe-commits
https://github.com/hubert-reinterpretcast approved this pull request. LGTM with suggested changes. https://github.com/llvm/llvm-project/pull/147584 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/

[clang] [CIR] Fold ComplexRealOp from ComplexCreateOp (PR #147592)

2025-07-08 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper created https://github.com/llvm/llvm-project/pull/147592 Folding ComplexRealOp if the operand is ComplexCreateOp, inspired by MLIR Complex dialect Ref: https://github.com/llvm/llvm-project/blob/8b65c9d1ed298a9f4be675d1da9d678fd61ff2b0/mlir/lib/Dialect/Complex/I

[clang] [PowerPC][NFC] Define new alias for mma accumulate builtins (PR #147382)

2025-07-08 Thread Lei Huang via cfe-commits
https://github.com/lei137 updated https://github.com/llvm/llvm-project/pull/147382 >From 36d2b8fc61ab67b8d8010e8b33e3e871f8e1c4f2 Mon Sep 17 00:00:00 2001 From: Lei Huang Date: Fri, 4 Jul 2025 14:53:15 -0500 Subject: [PATCH 1/5] define new alias for accumulate builtins --- clang/include/clang

[clang-tools-extra] [clang-tidy][NFC] Do less unnecessary work in `NoLintDirectiveHandler` (PR #147553)

2025-07-08 Thread Julian Schmidt via cfe-commits
https://github.com/5chmidti approved this pull request. https://github.com/llvm/llvm-project/pull/147553 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Consistently handle consteval constructors for variables. (PR #144970)

2025-07-08 Thread Eli Friedman via cfe-commits
https://github.com/efriedma-quic updated https://github.com/llvm/llvm-project/pull/144970 >From b1f7402423af22b0ea8cdf0b3d3734bcce68a636 Mon Sep 17 00:00:00 2001 From: Eli Friedman Date: Thu, 19 Jun 2025 18:29:49 -0700 Subject: [PATCH 1/2] [clang] Consistently handle consteval constructors for

[clang] [clang] Consistently handle consteval constructors for variables. (PR #144970)

2025-07-08 Thread Eli Friedman via cfe-commits
https://github.com/efriedma-quic closed https://github.com/llvm/llvm-project/pull/144970 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 6a99326 - [clang] Consistently handle consteval constructors for variables. (#144970)

2025-07-08 Thread via cfe-commits
Author: Eli Friedman Date: 2025-07-08T14:47:04-07:00 New Revision: 6a993264ee0105da32a6a57fb077796076cf6bf4 URL: https://github.com/llvm/llvm-project/commit/6a993264ee0105da32a6a57fb077796076cf6bf4 DIFF: https://github.com/llvm/llvm-project/commit/6a993264ee0105da32a6a57fb077796076cf6bf4.diff

[clang] [llvm] [AMDGPU] Add support for `v_cvt_f32_fp8` on gfx1250 (PR #147579)

2025-07-08 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `arc-builder` running on `arc-worker` while building `clang,llvm` at step 6 "test-build-unified-tree-check-all". Full details are available at: https://lab.llvm.org/buildbot/#/builders/3/builds/18743 Here is the relevant pie

[clang] [HLSL][RootSignature] Implement diagnostic for missed comma (PR #147350)

2025-07-08 Thread Finn Plummer via cfe-commits
https://github.com/inbelic edited https://github.com/llvm/llvm-project/pull/147350 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [NFC][HLSL] Move resource range logic from `SemaHLSL` to `RootSignatureValidations` (PR #147117)

2025-07-08 Thread Finn Plummer via cfe-commits
https://github.com/inbelic edited https://github.com/llvm/llvm-project/pull/147117 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [NVPTX] Fix v2i8 call lowering, use generic ld/st nodes for call params (PR #146930)

2025-07-08 Thread Alex MacLean via cfe-commits
@@ -1487,14 +1380,39 @@ SDValue NVPTXTargetLowering::LowerCall(TargetLowering::CallLoweringInfo &CLI, // After all vararg is processed, 'VAOffset' holds the size of the // vararg byte array. - SDValue VADeclareParam; // vararg byte array + SDValue VADecl

[clang] [llvm] [WebAssembly,llvm] Add llvm.wasm.ref.test.func intrinsic (PR #147076)

2025-07-08 Thread Hood Chatham via cfe-commits
https://github.com/hoodmane edited https://github.com/llvm/llvm-project/pull/147076 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Clang-Repl] Add pipe-based redirection and fetch PID of launched executor (PR #147478)

2025-07-08 Thread Abhinav Kumar via cfe-commits
https://github.com/kr-2003 updated https://github.com/llvm/llvm-project/pull/147478 >From fbe4344831538480be33accd35ef618c6d0e50b3 Mon Sep 17 00:00:00 2001 From: kr-2003 Date: Tue, 1 Jul 2025 18:55:21 +0530 Subject: [PATCH 1/6] pipes for redirection in oop jit --- .../clang/Interpreter/Remote

[clang] [analyzer] Conversion to CheckerFamily: MallocChecker (PR #147080)

2025-07-08 Thread Donát Nagy via cfe-commits
https://github.com/NagyDonat updated https://github.com/llvm/llvm-project/pull/147080 From c0e669a4f31702a871fce4c8c3805b322c331afd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Don=C3=A1t=20Nagy?= Date: Wed, 2 Jul 2025 15:09:42 +0200 Subject: [PATCH 01/10] [analyzer] Connversion to CheckerFamily: M

[clang] [analyzer] Conversion to CheckerFamily: MallocChecker (PR #147080)

2025-07-08 Thread Donát Nagy via cfe-commits
@@ -333,11 +333,55 @@ template static bool isStandardNewDelete(const T &FD) { return isStandardDelete(FD) || isStandardNew(FD); } +namespace { + //===--===// -// Definition of the MallocChecker class. +/

[clang] [analyzer] Conversion to CheckerFamily: MallocChecker (PR #147080)

2025-07-08 Thread Donát Nagy via cfe-commits
@@ -333,11 +333,55 @@ template static bool isStandardNewDelete(const T &FD) { return isStandardDelete(FD) || isStandardNew(FD); } +namespace { + //===--===// -// Definition of the MallocChecker class. +/

  1   2   3   4   >